[01:25:34] (03PS1) 10VolkerE: Remove unnecessary div wrapper on overflow menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/473651 [01:29:31] (03CR) 10VolkerE: "I'm ~99% sure that there is one gadget/one user scripts that might block that. But I needed to try before dying." [skins/Vector] - 10https://gerrit.wikimedia.org/r/473651 (owner: 10VolkerE) [01:38:26] (03CR) 10Jdlrobson: [C: 04-1] "https://imgur.com/a/a2wxxm1" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/473651 (owner: 10VolkerE) [03:10:57] 10Pywikibot: Add shnwikipedia to pywikibot - https://phabricator.wikimedia.org/T209555 (10Ninjastrikers) [03:11:18] 10Pywikibot: Add shnwikipedia to pywikibot - https://phabricator.wikimedia.org/T209555 (10Ninjastrikers) p:05Triage>03Low [03:12:27] (03PS1) 10Mischanix: Quote indexes in createTable [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473655 [03:16:32] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10Waffles51) {F27213897} [03:38:42] (03PS1) 10JJMC89: Add shnwikipedia [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473657 [03:41:03] 10Pywikibot: Add shnwikipedia to pywikibot - https://phabricator.wikimedia.org/T209555 (10JJMC89) a:03JJMC89 [03:43:01] (03PS2) 10JJMC89: [L10N] Add shnwiki [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473657 (https://phabricator.wikimedia.org/T209555) [04:12:06] (03CR) 10Xqt: [C: 04-1] [L10N] Add shnwiki (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473657 (https://phabricator.wikimedia.org/T209555) (owner: 10JJMC89) [04:16:16] (03PS3) 10JJMC89: [L10N] Add shnwiki [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473657 (https://phabricator.wikimedia.org/T209555) [04:17:16] (03CR) 10JJMC89: [L10N] Add shnwiki (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473657 (https://phabricator.wikimedia.org/T209555) (owner: 10JJMC89) [04:18:45] (03CR) 10Yaron Koren: [C: 032] Quote indexes in createTable [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473655 (owner: 10Mischanix) [04:24:15] (03Merged) 10jenkins-bot: Quote indexes in createTable [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473655 (owner: 10Mischanix) [04:26:34] (03CR) 10jenkins-bot: Quote indexes in createTable [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473655 (owner: 10Mischanix) [04:42:55] (03PS2) 10VolkerE: Remove unnecessary div wrapper on overflow menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/473651 (https://phabricator.wikimedia.org/T209558) [04:43:18] (03CR) 10VolkerE: Remove unnecessary div wrapper on overflow menu (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/473651 (https://phabricator.wikimedia.org/T209558) (owner: 10VolkerE) [04:57:04] 10Google-Code-in-2018, 10JSDoc WMF theme: Make the visibility indicators clearer - https://phabricator.wikimedia.org/T207384 (10Prtksxna) [04:57:47] 10Google-Code-in-2018, 10JSDoc WMF theme: Remove the redundant Class:* heading from the page - https://phabricator.wikimedia.org/T207381 (10Prtksxna) [04:58:14] 10Google-Code-in-2018, 10JSDoc WMF theme: Remove the redundant Class:* heading from the page - https://phabricator.wikimedia.org/T207381 (10Prtksxna) [04:58:30] 10Google-Code-in-2018, 10JSDoc WMF theme: Reverse the order of names in the - https://phabricator.wikimedia.org/T207380 (10Prtksxna) [04:58:54] <wikibugs> 10Google-Code-in-2018, 10JSDoc WMF theme: JSDoc: Use "/" instead of ":" as a delimiter in the heading - https://phabricator.wikimedia.org/T207379 (10Prtksxna) [04:59:23] <wikibugs> 10Google-Code-in-2018, 10JSDoc WMF theme: Add margins between method name heading and the content above it - https://phabricator.wikimedia.org/T206736 (10Prtksxna) [05:01:53] <wikibugs> 10Google-Code-in-2018, 10JSDoc WMF theme: Remove the redundant Class:* heading from the page - https://phabricator.wikimedia.org/T207381 (10Prtksxna) [05:11:03] <wikibugs> 10Google-Code-in-2018, 10JSDoc WMF theme: Remove the redundant Class:* heading from the page - https://phabricator.wikimedia.org/T207381 (10Prtksxna) [05:13:26] <wikibugs> 10Google-Code-in-2018, 10MediaWiki-History-or-Diffs: "→" link to page section on History page can be hard to click, should be larger somehow - https://phabricator.wikimedia.org/T165189 (10Legoktm) [05:13:43] <wikibugs> 10Google-Code-in-2018, 10JSDoc WMF theme: Reverse the order of names in the <title> - https://phabricator.wikimedia.org/T207380 (10Prtksxna) [05:14:15] <wikibugs> 10Google-Code-in-2018, 10MediaWiki-History-or-Diffs: "→" link to page section on History page can be hard to click, should be larger somehow - https://phabricator.wikimedia.org/T165189 (10Legoktm) I've proposed this as a GCI task, it should be relatively straightforward. [05:15:43] <wikibugs> 10Google-Code-in-2018, 10JSDoc WMF theme: JSDoc: Use "/" instead of ":" as a delimiter in the heading - https://phabricator.wikimedia.org/T207379 (10Prtksxna) [05:51:44] <wikibugs> (03CR) 10Legoktm: [C: 032] api: Organize API files into /includes/api/ [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/471098 (owner: 10D3r1ck01) [06:09:18] <wikibugs> (03Merged) 10jenkins-bot: api: Organize API files into /includes/api/ [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/471098 (owner: 10D3r1ck01) [06:12:50] <wikibugs> (03CR) 10Xqt: [C: 032] [L10N] Add shnwiki [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473657 (https://phabricator.wikimedia.org/T209555) (owner: 10JJMC89) [06:14:39] <wikibugs> (03Merged) 10jenkins-bot: [L10N] Add shnwiki [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473657 (https://phabricator.wikimedia.org/T209555) (owner: 10JJMC89) [06:16:06] <wikibugs> 10Pywikibot, 10Patch-For-Review: Add shnwikipedia to pywikibot - https://phabricator.wikimedia.org/T209555 (10Xqt) 05Open>03Resolved [06:16:52] <wikibugs> (03CR) 10jenkins-bot: [L10N] Add shnwiki [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473657 (https://phabricator.wikimedia.org/T209555) (owner: 10JJMC89) [06:18:55] <wikibugs> (03CR) 10jenkins-bot: api: Organize API files into /includes/api/ [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/471098 (owner: 10D3r1ck01) [06:27:08] <wikibugs> 10Pywikibot: Add shnwikipedia to pywikibot - https://phabricator.wikimedia.org/T209555 (10JJMC89) [08:16:20] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow users to watch grants - https://phabricator.wikimedia.org/T209538 (10Arcayn) p:05Triage>03Normal a:03Arcayn [09:27:34] <wikibugs> (03PS1) 10Nathan fraignt: Fix W504 in family.py and site_detect.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473703 (https://phabricator.wikimedia.org/T207836) [09:29:11] <wikibugs> (03CR) 10Nathan fraignt: "Hmm, every line is edited. Maybe git bug or editor encoding is wrong? I'm using pycharm." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473703 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [09:43:43] <wikibugs> 10goodfirstbug, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Need-volunteer, 10Patch-For-Review: Add monolingual language code hbo (Biblical Hebrew) - https://phabricator.wikimedia.org/T155368 (10Addshore) Just poking this after 1 month of inactivity, what's the status? Are we adding it or no... [09:59:11] <wikibugs> (03CR) 10D3r1ck01: [C: 04-1] "Thanks a lot for your work Nathan. But the way this patch is, it's difficult to see what exactly was changed, could you please submit a pa" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473703 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [10:02:56] <wikibugs> (03PS2) 10Nathan fraignt: Fix W504 in family.py and site_detect.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473703 (https://phabricator.wikimedia.org/T207836) [10:03:43] <wikibugs> (03CR) 10Nathan fraignt: "> Patch Set 1: Code-Review-1" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473703 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [10:16:25] <wikibugs> (03CR) 10D3r1ck01: [C: 04-1] Fix W504 in family.py and site_detect.py (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473703 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [10:18:44] <wikibugs> (03PS3) 10Nathan fraignt: Fix W504 in family.py and site_detect.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473703 (https://phabricator.wikimedia.org/T207836) [10:32:42] <wikibugs> (03CR) 10D3r1ck01: [C: 031] Fix W504 in family.py and site_detect.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473703 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [11:26:00] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10Readers-Web-Backlog: [Bug] Back to top intercepts gallery details button click - https://phabricator.wikimedia.org/T208152 (10Sevagen) a:03Sevagen If no one else is working on this , I will try to fix it. [11:31:03] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Tracker returns 500 instead of 404 when trying to edit non-existent ticket in admin - https://phabricator.wikimedia.org/T209340 (10Urbanecm) 05Open>03Resolved [11:36:17] <wikibugs> 10goodfirstbug, 10Huggle, 10Need-volunteer, 10WorkType-Maintenance: look for new messages on all projects - https://phabricator.wikimedia.org/T70502 (10Avanishka) Does this still need to be worked on? If yes, I am willing to do it. [11:36:49] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow users to deactivate their own account - https://phabricator.wikimedia.org/T209317 (10Urbanecm) [11:41:32] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow users to deactivate their own account - https://phabricator.wikimedia.org/T209317 (10Urbanecm) [11:41:56] <tybanash> Hello , pls I need some help [11:44:47] <tybanash> Trying to add my username to the contributors.json file on the awmd-stats tool . When I got to the part to type my commit message ,when I type the commit message and enter they say aborting commit due to empty commit message . What can I do to solve this? https://usercontent.irccloud-cdn.com/file/qUgfNmIg/B4C3F96B-3878-42B9-8363-DECC7DE29A40.JPG [11:45:08] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow users to deactivate their own account - https://phabricator.wikimedia.org/T209317 (10Urbanecm) I imported this as https://codein.withgoogle.com/tasks/4634351892430848/ and I will mentor it. [11:50:23] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: User that was created by OAuth cannot set password - https://phabricator.wikimedia.org/T209320 (10Urbanecm) [11:50:48] <wikibugs> (03CR) 10Xqt: [C: 032] Fix W504 in family.py and site_detect.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473703 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [11:50:53] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: User that was created by OAuth cannot set password - https://phabricator.wikimedia.org/T209320 (10Urbanecm) I imported this as https://codein.withgoogle.com/tasks/6427825612521472/ and I will mentor it. [11:53:44] <wikibugs> (03Merged) 10jenkins-bot: Fix W504 in family.py and site_detect.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473703 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [11:55:57] <wikibugs> (03CR) 10jenkins-bot: Fix W504 in family.py and site_detect.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473703 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [12:01:11] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: User that was created by OAuth cannot set password - https://phabricator.wikimedia.org/T209320 (10Bawolff) Wait, so how can oauth create a user with no password? Should this sort of thing require a password reset via email instead? [12:10:01] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MediaWiki-extensions-Quiz, 10Patch-For-Review: Some messages in Quiz extension use camel case; change messages in Quiz extension to all use lower case and dashes - https://phabricator.wikimedia.org/T200252 (10Padthaidev) a:03Padthaidev [12:12:38] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MediaWiki-extensions-Quiz, 10Patch-For-Review: Some messages in Quiz extension use camel case; change messages in Quiz extension to all use lower case and dashes - https://phabricator.wikimedia.org/T200252 (10Mvolz) a:05Padthaidev>03None [12:13:01] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MediaWiki-extensions-Quiz, 10Patch-For-Review: Some messages in Quiz extension use camel case; change messages in Quiz extension to all use lower case and dashes - https://phabricator.wikimedia.org/T200252 (10Mvolz) @Padthaidev sorry this is already done by someone... [13:21:14] <wikibugs> 10Google-Code-in-2018, 10MediaWiki-API: Action api should reject requests with unsupported http methods with a 405 - https://phabricator.wikimedia.org/T209228 (10Shreyasminocha) a:03Shreyasminocha [13:34:36] <wikibugs> 10goodfirstbug, 10Huggle, 10Need-volunteer, 10WorkType-Maintenance: look for new messages on all projects - https://phabricator.wikimedia.org/T70502 (10Petrb) Hello, yes [13:46:46] <wikibugs> 10goodfirstbug, 10Huggle, 10Need-volunteer, 10WorkType-Maintenance: look for new messages on all projects - https://phabricator.wikimedia.org/T70502 (10Petrb) Currently the check for new messages is real crap. There is a timer in Main Window you can see the code which is called here every 20 seconds: http... [14:08:13] <d3r1ck> tybanash: That sounds like you're using Vi right? [14:08:23] <d3r1ck> In that case, let me walk you through [14:08:39] <d3r1ck> tybanash: Still around? [14:17:49] <wikibugs> 10Google-Code-in-2018, 10Pywikibot, 10goodfirstbug: Fix W504 issues across files in the Pywikibot repository - https://phabricator.wikimedia.org/T207836 (10D3r1ck01) [14:36:25] <wikibugs> (03PS1) 10Dvorapa: [bugfix] Disable empty sections cc in userspace [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473747 [14:39:00] <wikibugs> (03CR) 10D3r1ck01: "@Nathan, in upcoming patches, use the prefix [fix] before the title of the commit message. For more information, see this: https://www.med" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473703 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [14:42:13] <wikibugs> (03PS2) 10Dvorapa: [bugfix] Disable empty sections cc in userspace [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473747 [14:43:09] <paladox> d3r1ck 2.16 has been released! [14:43:39] <d3r1ck> Wow! [14:43:52] <d3r1ck> paladox: Coming home soon? [14:43:58] <paladox> Coming home soon? [14:44:02] <paladox> what do you mean? :) [14:44:03] <d3r1ck> WMF [14:44:09] <paladox> oh, not sure [14:44:16] <paladox> thats up to the releng team :) [14:44:21] <d3r1ck> I mean if 2.16 will be coming to wmf soon :) [14:44:24] <d3r1ck> Ahhh, okay! [14:44:39] <d3r1ck> I'm happy [14:44:56] <d3r1ck> I'm seeing some more changes in 2.15.6 [14:45:19] <d3r1ck> When a new PS is uploaded and you're on the page of the PS on Gerrit, I see something below [14:45:22] <d3r1ck> paladox: ^^ [14:45:27] <d3r1ck> Have you noticed that too? [14:45:41] <d3r1ck> It says a new patchset has been uploaded, reload or something like that [14:45:51] <paladox> d3r1ck yep [14:45:55] <d3r1ck> Nice! [14:45:56] <paladox> thats in polygerrit now [14:47:21] <wikibugs> (03PS1) 10Nathan fraignt: Fix W504 in site.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) [14:47:25] <d3r1ck> Cool! [14:48:18] <wikibugs> (03CR) 10D3r1ck01: "use the prefix [fix] before the title of the commit message. For more information, see this: https://www.mediawiki.org/wiki/Manual:Pywikib" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [14:50:18] <d3r1ck> paladox: I'm looking forward to the day 3.0 will hit the streets :D [14:50:23] <paladox> :) [14:50:30] <d3r1ck> What version is upstream using? [14:50:39] <d3r1ck> Their UI seems very sofisticated [14:50:39] <wikibugs> 10Pywikibot, 10Pywikibot-login.py, 10Pywikibot-tests: login.py: Assigning to function call which doesn't return - https://phabricator.wikimedia.org/T209193 (10Dvorapa) [14:50:41] <wikibugs> (03PS2) 10Nathan fraignt: [FIX] Fix W504 in site.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) [14:51:00] <wikibugs> (03CR) 10Nathan fraignt: "> Patch Set 1:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [14:51:20] <wikibugs> 10Pywikibot, 10goodfirstbug, 10Pywikibot-cosmetic-changes.py: Cosmetic changes breaks tables - https://phabricator.wikimedia.org/T138765 (10Dvorapa) Still valid: https://cs.wikipedia.org/w/index.php?title=Wikipedista:Oasis98&diff=prev&oldid=16161207&diffmode=source [14:54:50] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Send ticket_delete notification type - https://phabricator.wikimedia.org/T205447 (10Urbanecm) [14:55:25] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Send ticket_delete notification type - https://phabricator.wikimedia.org/T205447 (10Urbanecm) I imported this as https://codein.withgoogle.com/tasks/5751014499024896/ and I will mentor it. [14:56:50] <paladox> d3r1ck they are using the master branch [14:56:52] <paladox> aka 3.0 [14:57:04] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Add open_for_tickets value to edit grant admin view - https://phabricator.wikimedia.org/T206006 (10Urbanecm) [14:57:38] <d3r1ck> Wow [14:58:15] <wikibugs> (03CR) 10D3r1ck01: "Minor fix and I'll suggest to polish up the commit message a little bit. It's too few :)" (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [14:59:47] <wikibugs> (03CR) 10Dvorapa: "The same issue is maybe with moving categories to bottom of the page if user in his/her sandbox prepares in one sandbox page multiple arti" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473747 (owner: 10Dvorapa) [15:01:18] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Add open_for_tickets value to edit grant admin view - https://phabricator.wikimedia.org/T206006 (10Urbanecm) I imported this as https://codein.withgoogle.com/tasks/6418485467938816/ and I will mentor it. [15:01:40] <wikibugs> (03PS3) 10Dvorapa: [bugfix] Disable empty sections cc in userspace [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473747 [15:01:46] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Do not display field description repeatedly in edit_ticket/create_ticket - https://phabricator.wikimedia.org/T206104 (10Urbanecm) 05Open>03Resolved [15:02:03] <wikibugs> (03PS3) 10Nathan fraignt: Fix W504 in site.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) [15:02:56] <wikibugs> (03PS4) 10Nathan fraignt: Fix W504 errors in pywikibot/site.py script [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) [15:05:05] <wikibugs> (03PS5) 10Nathan fraignt: [FIX] Fix W504 errors in pywikibot/site.py script [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) [15:13:55] <wikibugs> (03CR) 10D3r1ck01: [FIX] Fix W504 errors in pywikibot/site.py script (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [15:20:08] <wikibugs> (03PS6) 10Nathan fraignt: Fix W504 in site.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) [15:25:37] <wikibugs> 10Google-Code-in-2018: Design a "Personal Space Needed" sticker - https://phabricator.wikimedia.org/T200540 (10Mbonu) {F27230103} Under Creative Commons Attribution 4.0 Wikimedia Commons Link: https://commons.wikimedia.org/wiki/File:MbonuStickers.svg [15:26:18] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Allow users to watch grants - https://phabricator.wikimedia.org/T209538 (10Urbanecm) 05Open>03Resolved [15:27:17] <wikibugs> (03CR) 10D3r1ck01: Fix W504 in site.py (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [15:27:46] <wikibugs> (03CR) 10D3r1ck01: [C: 04-1] "Update commit message to prev PS's" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [15:31:08] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Tickets with no event date are being in unuseful order - https://phabricator.wikimedia.org/T196776 (10Urbanecm) [15:31:18] <wikibugs> 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Tickets with no event date are being in unuseful order - https://phabricator.wikimedia.org/T196776 (10Urbanecm) https://codein.withgoogle.com/tasks/4984021353234432/ [15:33:18] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10Contributors-Team, 10Ladies-That-FOSS-MediaWiki, 10MobileFrontend: After editing redirects on mobile-web, you are linked to the target instead of &redirect=no - https://phabricator.wikimedia.org/T137067 (10Aklapper) @jdlrobson: Can you confirm that your patch link... [15:38:40] <tybanash> Am using windows @d3r1ck [15:38:53] <d3r1ck> Yeah! [15:39:00] <d3r1ck> But the editor is called "vi" [15:39:07] <d3r1ck> So this is what we're going to do [15:39:17] <d3r1ck> Do you have the patchset ready and you want to commit it? [15:39:25] <tybanash> Yes I do [15:39:50] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 3 others: Outputting '<sup>β</sup>` on every page, not only on beta, as part of the logo is disadvantageous - https://phabricator.wikimedia.org/T208185 (10phuedx) a:05Bjornskjald>03phuedx [15:39:51] <d3r1ck> Okay [15:39:56] <d3r1ck> Let's do the following [15:39:59] <d3r1ck> "git add ." [15:40:02] <d3r1ck> Run that [15:40:11] <d3r1ck> Then this "git commit -a" [15:40:24] <d3r1ck> That will open you a "vi" editor to type in your commit message [15:40:44] <d3r1ck> Press the letter "a" on your keyboard to activate edit mode on the editor [15:40:45] <wikibugs> 10goodfirstbug, 10MediaWiki-Cache, 10MediaWiki-Database, 10MediaWiki-General-or-Unknown, 10Performance-Team: MediaWiki needlessly queries page data twice on page views - https://phabricator.wikimedia.org/T206498 (10daniel) >>! In T206498#4748098, @jlinehan wrote: > Simplest/safest solution here is just t... [15:41:24] <d3r1ck> After pressing the letter "a", then type in your commit message (title and body) and reference the bug on phab, see this: https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines [15:41:24] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 3 others: Outputting '<sup>β</sup>` on every page, not only on beta, as part of the logo is disadvantageous - https://phabricator.wikimedia.org/T208185 (10phuedx) [15:42:00] <d3r1ck> Once you're done writting the commit message and it's ready, press "esc" to exit edit mode and then type ":wq" to save and quit the editor [15:42:12] <d3r1ck> You can check if your commit went through by typing "git log" [15:42:21] <d3r1ck> The latest commit is your (verified?) [15:42:26] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 3 others: Outputting '<sup>β</sup>` on every page, not only on beta, as part of the logo is disadvantageous - https://phabricator.wikimedia.org/T208185 (10phuedx) > includes/skins/MinervaTemplate.php shoul... [15:42:44] <d3r1ck> If you want to edit your commit message, use "git commit --amend" then same steps as when you wanted to add etc [15:42:48] <d3r1ck> Let me know if it works! [15:42:59] <tybanash> Ok thank u [15:43:25] <d3r1ck> Sure! [15:44:10] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 3 others: Outputting '<sup>β</sup>` on every page, not only on beta, as part of the logo is disadvantageous - https://phabricator.wikimedia.org/T208185 (10phuedx) [15:45:10] <wikibugs> 10Google-Code-in-2018, 10FormWizard, 10FormWizard-Gadget: Design a logo for FormWizard Extension. - https://phabricator.wikimedia.org/T208193 (10Aklapper) @Eugene233: If the task description is fine and complete, feel very free to create a task on the GCI site for this! :) [15:45:37] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 3 others: Outputting '<sup>β</sup>` on every page, not only on beta, as part of the logo is disadvantageous - https://phabricator.wikimedia.org/T208185 (10phuedx) a:05phuedx>03None [15:47:32] <tybanash> Is the bug id T202230 [15:47:36] <tybanash> ? [15:49:59] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10Contributors-Team, 10Ladies-That-FOSS-MediaWiki, 10MobileFrontend: After editing redirects on mobile-web, you are linked to the target instead of &redirect=no - https://phabricator.wikimedia.org/T137067 (10Jdlrobson) 05Open>03Resolved a:03Jdlrobson I guess i... [15:51:36] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10Contributors-Team, 10Ladies-That-FOSS-MediaWiki, 10MobileFrontend: After editing redirects on mobile-web, you are linked to the target instead of &redirect=no - https://phabricator.wikimedia.org/T137067 (10Jdlrobson) @aklapper investigating a bug is just as import... [15:51:39] <wikibugs> 10Google-Code-in-2018, 10JSDoc WMF theme: "Mixed" return type looks like and behaves like a link, but does nothing when clicked. Should be plain text. - https://phabricator.wikimedia.org/T206734 (10Aklapper) [15:52:11] <wikibugs> 10goodfirstbug, 10MediaWiki-Cache, 10MediaWiki-Database, 10MediaWiki-General-or-Unknown, 10Performance-Team: MediaWiki needlessly queries page data twice on page views - https://phabricator.wikimedia.org/T206498 (10jlinehan) >>! In T206498#4750417, @daniel wrote: > Changing it to Title now could in theor... [15:52:18] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [Bug] Back to top intercepts gallery details button click - https://phabricator.wikimedia.org/T208152 (10Jdlrobson) I will review! Ping me if you need any help! [16:11:14] <wikibugs> 10goodfirstbug, 10MediaWiki-Cache, 10MediaWiki-Database, 10MediaWiki-General-or-Unknown, 10Performance-Team: MediaWiki needlessly queries page data twice on page views - https://phabricator.wikimedia.org/T206498 (10daniel) >>! In T206498#4750462, @jlinehan wrote: >>>! In T206498#4750417, @daniel wrote: >... [16:11:37] <wikibugs> (03CR) 10Nathan fraignt: "> Patch Set 6:" (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [16:12:12] <wikibugs> (03PS7) 10Nathan fraignt: [FIX] Fix W504 errors in pywikibot/site.py script [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) [16:13:49] <tybanash> Can I push to gerrit now? https://usercontent.irccloud-cdn.com/file/Tu5qWXiw/IMG_9215.JPG [16:14:30] <tybanash> @d3r1ck? [16:19:59] <d3r1ck> No [16:20:10] <d3r1ck> Run "git review -s" [16:20:14] <d3r1ck> We need to have a Change-Id [16:20:30] <d3r1ck> So after running that, ammend the commit "git commit --amend" [16:20:45] <d3r1ck> and just save again "esc, then :wq" [16:20:49] <d3r1ck> Do that 2 times [16:20:53] <d3r1ck> tybanash: ^^ [16:25:26] <tybanash> Ok [16:27:06] <tybanash> Wn am typing nothing is showing on the screen [16:32:04] <tybanash> Wn am typing nothing is showing , iv pressed escape but nthg [16:36:17] <wikibugs> 10Google-Code-in-2018, 10JSDoc WMF theme: Reverse the order of names in the <title> - https://phabricator.wikimedia.org/T207380 (10Arcayn) p:05Triage>03Normal a:03Arcayn [16:45:01] <wikibugs> (03PS1) 10Yaron Koren: Add "slideshow" format, using Slick JS library [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473779 [17:20:11] <wikibugs> (03PS2) 10Yaron Koren: Add "slideshow" format, using Slick JS library [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473779 [17:21:50] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add "slideshow" format, using Slick JS library [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473779 (owner: 10Yaron Koren) [17:23:59] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add "slideshow" format, using Slick JS library [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473779 (owner: 10Yaron Koren) [17:37:46] <wikibugs> (03CR) 10Jdlrobson: [C: 032] Remove unnecessary div wrapper on overflow menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/473651 (https://phabricator.wikimedia.org/T209558) (owner: 10VolkerE) [17:45:09] <wikibugs> (03Merged) 10jenkins-bot: Remove unnecessary div wrapper on overflow menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/473651 (https://phabricator.wikimedia.org/T209558) (owner: 10VolkerE) [17:46:43] <wikibugs> (03PS3) 10Yaron Koren: Add "slideshow" format, using Slick JS library [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473779 [17:50:45] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add "slideshow" format, using Slick JS library [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473779 (owner: 10Yaron Koren) [17:56:07] <wikibugs> (03PS4) 10Yaron Koren: Add "slideshow" format, using Slick JS library [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473779 [18:00:18] <tybanash> I’ve done it 2 times @ d3r1ck [18:00:45] <tybanash> What do I do next ? [18:03:54] <wikibugs> (03CR) 10Yaron Koren: [C: 032] Add "slideshow" format, using Slick JS library [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473779 (owner: 10Yaron Koren) [18:08:26] <d3r1ck> Submit the patch I guess [18:08:30] <d3r1ck> git review -Ry [18:08:31] <d3r1ck> reset [18:08:39] <d3r1ck> Ops, disregard the "reset" part [18:09:47] <wikibugs> (03Merged) 10jenkins-bot: Add "slideshow" format, using Slick JS library [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473779 (owner: 10Yaron Koren) [18:10:42] <tybanash> Ok [18:16:53] <wikibugs> (03CR) 10jenkins-bot: Add "slideshow" format, using Slick JS library [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473779 (owner: 10Yaron Koren) [18:20:17] <tybanash> When I type git review .... I get authentication failed [18:20:32] <tybanash> Unauthorized [18:21:01] <d3r1ck> I need the full error [18:21:23] <d3r1ck> But do you have "git review" installed? [18:21:27] <d3r1ck> Yes I guess [18:21:35] <d3r1ck> Can you give me the output of "git remove -vv" [18:21:36] <d3r1ck> ? [18:34:16] <tybanash> This the error https://usercontent.irccloud-cdn.com/file/T6JcNahg/IMG_9217.JPG [18:34:36] <tybanash> Ok let me do the git remove ... now [18:35:43] <d3r1ck> Sorry, it's "remote" not "remove" [18:35:51] <tybanash> Ok [18:36:10] <d3r1ck> What is the output of the remote command? [18:37:15] <tybanash> Pls check here https://usercontent.irccloud-cdn.com/file/5dlfbJaN/1542307017.JPG [18:38:15] <d3r1ck> Yes, that is the problem [18:38:21] <d3r1ck> What is your gerrit handle? [18:39:55] <d3r1ck> This is how my own looks like, the links: [18:39:57] <d3r1ck> ssh://d3r1ck01@gerrit.wikimedia.org:29418/labs/tools/awmd-stats.git [18:40:18] <d3r1ck> Yours should maybe be: ssh://tybanash@gerrit.wikimedia.org:29418/labs/tools/awmd-stats.git [18:41:14] <tybanash> What could be the problem [18:42:05] <d3r1ck> The problem is the remote links are wrong [18:42:22] <d3r1ck> So do "git remote rm origin" [18:42:43] <d3r1ck> Then do "git remote add origin ssh://tybanash@gerrit.wikimedia.org:29418/labs/tools/awmd-stats.git" [18:42:56] <d3r1ck> What is your Gerrit username? [18:43:07] <d3r1ck> Replace <tybanash> with your gerrit username [18:43:10] <tybanash> Ok wn I open my gerrit account I see code review error [18:43:29] <d3r1ck> tybanash: What is your Gerrit username? Let's start from there first? [18:44:24] <wikibugs> 10Google-Code-in-2018, 10Page-Previews, 10Readers-Web-Backlog, 10Technical-Debt: Update babel-preset-env and friends - https://phabricator.wikimedia.org/T197883 (10Jdlrobson) p:05Normal>03High [18:44:34] <wikibugs> 10Google-Code-in-2018, 10Page-Previews, 10Readers-Web-Backlog, 10Technical-Debt: Popups: Update babel-preset-env and friends - https://phabricator.wikimedia.org/T197883 (10Jdlrobson) [18:46:16] <tybanash> My username is tybanash [18:46:20] <d3r1ck> Good [18:46:25] <d3r1ck> So run the commands above [18:46:32] <d3r1ck> Or let me paste them again [18:46:37] <d3r1ck> git remote rm origin [18:46:44] <d3r1ck> git remote add origin ssh://tybanash@gerrit.wikimedia.org:29418/labs/tools/awmd-stats.git [18:46:54] <tybanash> But whenever I use tybanash to sign in it does not go , I use Awah Nadege to sign in [18:46:55] <d3r1ck> First will remove your current remote URL [18:47:01] <d3r1ck> Second will add the correct one [18:47:19] <d3r1ck> Then your username is "Awah Nadege" not "tybanash" [18:48:33] <tybanash> It got me a bit confused https://usercontent.irccloud-cdn.com/file/xMMqo26N/1542307687.JPG [18:48:54] <tybanash> Let me do the commands u mentioned [18:57:20] <tybanash> I’ve done it [18:57:26] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10Wikimedia-Site-requests, and 2 others: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10Jdlrobson) [18:57:44] <d3r1ck> tybanash: Your username is "tybanash" then [18:57:48] <d3r1ck> Gerrit would not lie [18:57:48] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10Wikimedia-Site-requests, and 2 others: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10Jdlrobson) (SWAT deploy) [18:57:54] <d3r1ck> But why can't you login with that? [18:58:04] <wikibugs> 10Google-Code-in-2018, 10MinervaNeue (Desktop), 10Need-volunteer, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): AMC: Fix MobileWebMainMenuClickTracking schema for Minerva desktop to avoid errors - https://phabricator.wikimedia.org/T193505 (10Jdlrobson) [18:58:12] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10Wikimedia-Site-requests, and 2 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10Jdlrobson) [18:58:17] <tybanash> I don’t know , since I created the account it never goes [18:58:33] <tybanash> I always use Awah Nadege to log in [18:58:54] <tybanash> tybanash doesn’t log me in [18:59:02] <tybanash> It says wrong username [19:00:10] <tybanash> This is what I have now https://usercontent.irccloud-cdn.com/file/Lvajfzkc/1542308394.JPG [19:02:55] <d3r1ck> The Awah Nadege should be with a space [19:03:06] <d3r1ck> So redo it [19:03:17] <d3r1ck> If the space is not there, it won't work [19:03:31] <d3r1ck> But before that, try the "tybanash" instead [19:03:37] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MobileFrontend, 10Readers-Web-Backlog, 10Need-volunteer: [Bug - development NOT production] Nearby TypeError when using JSONPForeignApi - https://phabricator.wikimedia.org/T204876 (10Jdlrobson) p:05Normal>03Low [19:03:37] <d3r1ck> That is your username [19:03:55] <d3r1ck> tybanash: So instead of "Awah Nadege", use tybanash instead [19:05:20] <tybanash> Ok [19:05:56] <tybanash> Result here https://usercontent.irccloud-cdn.com/file/YNFXaaEJ/1542308741.JPG [19:19:24] <wikibugs> (03CR) 10Xqt: [FIX] Fix W504 errors in pywikibot/site.py script (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [19:26:13] <wikibugs> (03CR) 10Xqt: [FIX] Fix W504 errors in pywikibot/site.py script (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [19:32:39] <wikibugs> (03CR) 10Xqt: [C: 04-1] "Have a look at pep8 and what it means: Don’t break the corresponding operand (which is “in” here) and keep readability" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [19:47:39] <wikibugs> (03CR) 10Xqt: [C: 04-1] "> use the prefix [fix] before the title of the commit message. For" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473749 (https://phabricator.wikimedia.org/T207836) (owner: 10Nathan fraignt) [19:56:33] <tybanash> Hello [19:56:48] <d3r1ck> tybanash: You need to remove remote first [19:56:52] <d3r1ck> "git remote rm origin" [19:56:55] <d3r1ck> Before adding a new one [20:00:19] <wikibugs> (03CR) 10Xqt: [C: 031] "This might be also valid for draft namespace. As loan has draft is not a common namespace this could also implemented by a separate patch " [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473747 (owner: 10Dvorapa) [20:13:39] <tybanash> Ok [20:14:37] <tybanash> I’ve done [20:14:49] <tybanash> Ive done so [20:14:55] <d3r1ck> So try to got a "git review -Ry" now [20:15:06] <tybanash> Ok [20:15:08] <d3r1ck> Ping me if you need me, I'm deep into some MobileFrontend test right now [20:15:13] <d3r1ck> So it's taking me away from IRC [20:15:22] <tybanash> Ok [20:16:21] <tybanash> My name or service is not known [20:16:46] <d3r1ck> What's the error message? [20:16:53] <wikibugs> 10Pywikibot, 10Pywikibot-login.py, 10Pywikibot-tests: login.py: Assigning to function call which doesn't return - https://phabricator.wikimedia.org/T209193 (10Xqt) The code is: cookiedata = self.getCookie() But cookiedata is never used (and getCookie() is method which does nothing) [20:17:21] <tybanash> https://usercontent.irccloud-cdn.com/file/yFbYarq2/1542313028.JPG [20:17:30] <wikibugs> 10Pywikibot, 10Pywikibot-login.py, 10Pywikibot-tests: login.py: Assigning to function call which doesn't return - https://phabricator.wikimedia.org/T209193 (10Xqt) p:05Triage>03Low [20:18:54] <d3r1ck> tybanash: Go "git review -s" [20:19:02] <d3r1ck> Then try to submit the patch again let's see [20:19:12] <tybanash> Ok [20:19:52] <tybanash> Wn I do git review... [20:20:12] <d3r1ck> I don't understand your question [20:20:17] <tybanash> I hv could not read from remote repository [20:20:32] <d3r1ck> Do you have the right permission? [20:20:49] <tybanash> Could not fetch origin [20:21:03] <d3r1ck> tybanash: Follow this: https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_to_submit_a_patch [20:22:49] <tybanash> I followed all the steps in the gerrit turorial [20:23:58] <d3r1ck> Nope! [20:24:05] <d3r1ck> Follow that particular one [20:24:18] <d3r1ck> You need to do something around eval `ssh-agent` [20:24:26] <d3r1ck> etc, to make sure you can connect Gerrit [20:25:08] <d3r1ck> When you run this what do you get? ssh -p 29418 <tybanash>@gerrit.wikimedia.org [20:25:12] <d3r1ck> tybanash: ^^ [20:25:34] <d3r1ck> Sorry this: "ssh -p 29418 tybanash@gerrit.wikimedia.org" [20:25:43] <d3r1ck> Grrrrrr it's hard to switch mind context :( [20:25:52] <tybanash> Ok [20:26:04] <d3r1ck> What's the output of that command when you run it? [20:27:08] <tybanash> I get this https://usercontent.irccloud-cdn.com/file/8NY8S7kT/1542313616.JPG [20:27:51] <d3r1ck> No [20:27:56] <d3r1ck> That is not the command I gave you [20:28:10] <d3r1ck> This: "ssh -p 29418 tybanash@gerrit.wikimedia.org" [20:29:53] <tybanash> Ok [20:31:17] <tybanash> Could not resolve host name [20:32:03] <d3r1ck> Copy paste the error here [20:32:43] <tybanash> Ok [20:35:02] <tybanash> MR USER@USER MINGW64 ~/awmd-stats (develop) [20:35:02] <tybanash> $ ssh -p 29418 tybanash@gerrit.wikimedia.org [20:35:02] <tybanash> ssh: Could not resolve hostname gerrit.wikimedia.org: Name or service not known [20:35:54] <d3r1ck> Check your internet and run the command again [20:47:32] <tybanash> ok [20:47:57] <wikibugs> 10Google-Code-in-2018, 10MobileFrontend, 10Readers-Web-Backlog, 10Need-volunteer: MobileFrontend throws away warnings and other data from action=parse - https://phabricator.wikimedia.org/T86210 (10Bawolff) Its kind of unclear to me if just earnings should be copied over, or if it should loop through all th... [20:48:06] <tybanash> my output https://www.irccloud.com/pastebin/PVV4NJat/ [20:49:26] <wikibugs> 10Google-Code-in-2018, 10MobileFrontend, 10Readers-Web-Backlog, 10Need-volunteer: MobileFrontend throws away warnings and other data from action=parse - https://phabricator.wikimedia.org/T86210 (10Anomie) Everything should be copied over, not just the warnings. [20:50:09] <wikibugs> 10Pywikibot, 10Pywikibot-login.py, 10Pywikibot-tests: login.py: Assigning to function call which doesn't return - https://phabricator.wikimedia.org/T209193 (10Xqt) a:03Xqt [20:54:37] <d3r1ck> Try doing a "git review -Ry" now [20:54:45] <d3r1ck> You had that due to internet connection I guess [20:55:01] <d3r1ck> I mean "Could not resolve host name" [20:55:01] <tybanash> ok [20:55:07] <d3r1ck> But try to submit the patch again let's see [20:55:21] <tybanash> ok [20:56:40] <wikibugs> (03PS1) 10Awah Nadege: contributors.json: Change-Id add new contributor [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/473842 (https://phabricator.wikimedia.org/T202230) [20:56:55] <d3r1ck> tybanash: ^^ [20:57:42] <d3r1ck> Did you see that the patch was submitted successfully? [20:57:55] <d3r1ck> Check and see on this channel that wikibugs said so [20:58:37] <tybanash> ok ive seen it [20:59:10] <tybanash> this is my output https://www.irccloud.com/pastebin/er4RlzlI/ [21:00:15] <tybanash> d3r1ck: i wasnt working with my ssh key was that my error? [21:02:11] <d3r1ck> You've submitted the patch [21:02:28] <d3r1ck> Here is it on Gerrit: https://gerrit.wikimedia.org/r/c/labs/tools/awmd-stats/+/473842 [21:02:38] <d3r1ck> No [21:02:43] <d3r1ck> It was internet connection [21:02:52] <d3r1ck> So host was unreachable at that moment [21:03:46] <d3r1ck> tybanash: Change your commit message title [21:03:56] <d3r1ck> It should be "contributors.json: Add new contributor" [21:03:58] <d3r1ck> Not "contributors.json: Change-Id add new contributor" [21:04:15] <d3r1ck> "git commit --amend" then ... [21:05:04] <tybanash> i did Change-Id because u said earlier it has to be in the commit message [21:05:49] <d3r1ck> No [21:05:57] <d3r1ck> It's generated automatically by "git review" [21:06:04] <d3r1ck> And yes it has to be there but not put by you [21:06:20] <d3r1ck> See the full commit message, you'll see "git review" generated it and placed it at the bottom [21:06:42] <d3r1ck> See the link I sent to you [21:06:50] <tybanash> oops!! [21:06:51] <tybanash> ok [21:08:06] <tybanash> ive seen it [21:08:11] <d3r1ck> Your username in the contributors.json file should be "tybanash" not "Awah Nadege" [21:08:16] <d3r1ck> tybanash: ^^ [21:09:00] <tybanash> ok [21:10:01] <d3r1ck> Isn't "tybanash" your username? [21:12:43] <tybanash> I was confused as I said earlier , because tybanash doesn’t sign me in. I did t know what to use [21:13:25] <tybanash> Wn I want to sign in tybanash gives username not found https://usercontent.irccloud-cdn.com/file/JMVSN5uq/IMG_9232.JPG [21:16:25] <tybanash> I was probably confused btwn the username and the UNIx shell username 🤦🏻‍♀️ [21:16:50] <d3r1ck> Okay [21:16:50] <wikibugs> (03PS1) 10Xqt: [fix] Return None in LoginManager.getCookie() [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473848 (https://phabricator.wikimedia.org/T209193) [21:17:06] <d3r1ck> That's fine [21:18:45] <tybanash> tybanash is the unixshell username , should I use it when to editx the contributors... file? [21:19:39] <wikibugs> 10Pywikibot, 10Pywikibot-login.py, 10Patch-For-Review, 10Pywikibot-tests: login.py: Assigning to function call which doesn't return - https://phabricator.wikimedia.org/T209193 (10Xqt) @Zoranzoki21, could you check whether this patch helps. Otherwise you should ignore that test. It is more or less unclear. [21:25:19] <d3r1ck> Wait [21:25:28] <d3r1ck> What is the output of "git remote -vv" again? [21:25:29] <wikibugs> 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Remove flake8-invalid-escape-sequences from tox.ini - https://phabricator.wikimedia.org/T192429 (10Dvorapa) [21:27:06] <tybanash> when i did it be4 that was the result https://www.irccloud.com/pastebin/zjVRz1sL/ [21:27:55] <d3r1ck> What is it now? [21:28:37] <wikibugs> 10Google-Code-in-2018, 10International-Developer-Events: GCI: US Event Venue Research - https://phabricator.wikimedia.org/T209645 (10Rfarrand) [21:32:18] <tybanash> MR USER@USER MINGW64 ~/awmd-stats (develop) [21:32:18] <tybanash> $ git remote -vv [21:32:18] <tybanash> origin ssh://tybanash@gerrit.wikimedia.org:29418/labs/tools/awmd-stats.git (fetch) [21:32:18] <tybanash> origin ssh://tybanash@gerrit.wikimedia.org:29418/labs/tools/awmd-stats.git (push) [21:32:32] <d3r1ck> Then yes, "tybanash" is your username [21:32:37] <d3r1ck> Add it in the contributors file [21:32:42] <d3r1ck> Replace it with what is there now [21:34:03] <tybanash> so i hv to edit the file in my editor and repeat all the steps from square 1? [21:34:17] <wikibugs> (03CR) 10Dvorapa: "> This might be also valid for draft namespace. As loan has draft is" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473747 (owner: 10Dvorapa) [21:40:03] <d3r1ck> Edit the contributors.json file and start with "git commit --amend" [21:40:07] <d3r1ck> Sorry [21:40:12] <d3r1ck> Start with "git add ." [21:40:23] <d3r1ck> Then instead of "git commit -a", do "git commit --amend" [21:40:28] <d3r1ck> Because you're working on same patch [21:40:31] <d3r1ck> So you just want to ammend it [21:41:10] <d3r1ck> See this: https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_(your_own_or_someone_else's) [21:41:34] <d3r1ck> But since you already have the patch locally, no need for the "git review -d" part [21:41:46] <d3r1ck> You use that only when the change is not local and you want to get it from Gerrit [21:45:07] <wikibugs> (03PS1) 10Xqt: [IMPR] Simpifiy error message handling in login.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473858 [21:47:15] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Simpifiy error message handling in login.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473858 (owner: 10Xqt) [21:50:58] <wikibugs> (03CR) 10Xqt: [C: 032] [bugfix] Disable empty sections cc in userspace [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473747 (owner: 10Dvorapa) [21:52:24] <wikibugs> (03PS2) 10Xqt: [IMPR] Simpifiy error message handling in login.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473858 [21:53:00] <tybanash> ok [21:54:20] <wikibugs> (03Merged) 10jenkins-bot: [bugfix] Disable empty sections cc in userspace [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473747 (owner: 10Dvorapa) [21:55:02] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Simpifiy error message handling in login.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473858 (owner: 10Xqt) [21:56:31] <wikibugs> (03CR) 10jenkins-bot: [bugfix] Disable empty sections cc in userspace [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473747 (owner: 10Dvorapa) [22:04:23] <wikibugs> 10Pywikibot: Disable cc removeEmptySections for "draft" namespace - https://phabricator.wikimedia.org/T209650 (10Xqt) [22:04:26] <wikibugs> 10Pywikibot: Disable cc removeEmptySections for "draft" namespace - https://phabricator.wikimedia.org/T209650 (10Xqt) p:05Triage>03Low [22:06:51] <wikibugs> 10Pywikibot, 10Pywikibot-pagegenerators.py: APIError: too-many-titles with -start: page generator - https://phabricator.wikimedia.org/T209111 (10Mpaa) The problem is that in site.preloadpages(), max_ids is computed after the pageslist is splitted in chunks of 240. ` for sublist in itergroup(pagelist, g... [22:09:19] <wikibugs> (03PS3) 10Xqt: [IMPR] Simpifiy error message handling in login.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473858 [22:09:33] <wikibugs> (03PS2) 10Awah Nadege: contributors.json: Add new contributor [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/473842 (https://phabricator.wikimedia.org/T202230) [22:12:30] <tybanash> d3r1ck: ive done all what u said [22:12:44] <d3r1ck> Good, I see another patch [22:14:53] <tybanash> am i good to go? [22:16:40] <wikibugs> (03PS1) 10Mischanix: Use column names in CargoStore COUNT queries [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473936 [22:18:23] <wikibugs> (03CR) 10Mischanix: "On gamepedia wikis the numeric column indexes of $row are not available for compatibility reasons. This patch fixes that issue." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473936 (owner: 10Mischanix) [22:18:31] <wikibugs> 10Pywikibot, 10Pywikibot-cosmetic-changes.py: Don't move categories to bottom by cc in userspace - https://phabricator.wikimedia.org/T209654 (10Dvorapa) [22:21:26] <wikibugs> (03PS1) 10Xqt: [L10N] Update languages_by_size [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473938 [22:24:05] <wikibugs> (03CR) 10Xqt: [C: 032] [L10N] Update languages_by_size [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473938 (owner: 10Xqt) [22:27:24] <wikibugs> (03Merged) 10jenkins-bot: [L10N] Update languages_by_size [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473938 (owner: 10Xqt) [22:29:37] <wikibugs> (03CR) 10jenkins-bot: [L10N] Update languages_by_size [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473938 (owner: 10Xqt) [22:31:36] <tybanash> d3r1ck: thanks for walking me thru [22:31:57] <d3r1ck> tybanash: Yes, I think the patch is okay, I'll review tomorrow [22:32:04] <d3r1ck> Don't mention [22:32:10] <d3r1ck> Read the Gerrit Tutorials again [22:32:15] <d3r1ck> Over and over [22:32:22] <d3r1ck> I've read that page more than 100 times :) [22:32:32] <tybanash> Ok [22:33:01] <tybanash> Ok [22:34:07] <tybanash> Good night 👋 [22:37:01] <wikibugs> (03PS1) 10Mpaa: [FIX] site.preloadpages: split pagelist in max_ids maximum [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473940 (https://phabricator.wikimedia.org/T209111) [22:48:15] <wikibugs> (03PS1) 10Mpaa: [IMPR] Start filling doc_subpages for wikinews family [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473942 [22:53:11] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Start filling doc_subpages for wikinews family [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473942 (owner: 10Mpaa) [22:58:15] <wikibugs> 10Google-Code-in-2018, 10goodfirstbug, 10MediaWiki-extensions-General, 10translatewiki.net, and 3 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10rafidaslam) [23:04:59] <d3r1ck> o/ [23:10:14] <wikibugs> (03CR) 10Yaron Koren: "@Mischanix - I didn't know there were times when the numeric index couldn't be used. Could you clarify what you mean by "compatibility iss" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473936 (owner: 10Mischanix) [23:10:31] <wikibugs> (03CR) 10Yaron Koren: ""Compatibility reasons", that is." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473936 (owner: 10Mischanix) [23:11:25] <wikibugs> (03PS2) 10Mpaa: [IMPR] Start filling doc_subpages for wikinews family [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473942 [23:24:23] <wikibugs> (03CR) 10D3r1ck01: "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/473842 (https://phabricator.wikimedia.org/T202230) (owner: 10Awah Nadege) [23:35:41] <wikibugs> 10goodfirstbug, 10MediaWiki-extensions-SecurePoll: Pressing return on any inputbox deletes the topmost election admin - https://phabricator.wikimedia.org/T209658 (10jrbs) Actually going to tag this #goodfirstbug since I don't think it's that difficult a fix (sounds like there's some weirdness in the JS, but no... [23:38:23] <wikibugs> 10goodfirstbug, 10RESTBase, 10Services (later), 10User-Clarakosi: Eliminate Parsoid section.offsets table from Cassandra - https://phabricator.wikimedia.org/T206048 (10Eevans) [23:42:28] <wikibugs> (03CR) 10Mischanix: "> Patch Set 1:" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473936 (owner: 10Mischanix) [23:44:16] <wikibugs> (03PS2) 10Mpaa: [FIX] site.preloadpages: split pagelist in at most max_ids elements [pywikibot/core] - 10https://gerrit.wikimedia.org/r/473940 (https://phabricator.wikimedia.org/T209111)