[00:00:50] 10goodfirstbug, 10Operations, 10monitoring, 10Performance-Team (Radar), 10Release-Engineering-Team (Watching / External): Increase "check_legal_html" coverage to group0 wikis - https://phabricator.wikimedia.org/T208284 (10greg) [00:21:15] (03PS1) 10Yaron Koren: Fix for assessing type of MIN(), MAX() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475028 [00:28:16] (03PS2) 10Yaron Koren: Fix for assessing type of MIN(), MAX() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475028 [00:30:35] 10Pywikibot, 10GitHub-Mirrors, 10Continuous-Integration-Config, 10Pywikibot-tests: AppVeyor test not running since months - https://phabricator.wikimedia.org/T183860 (10greg) [00:44:14] (03CR) 10Yaron Koren: [C: 032] Fix for assessing type of MIN(), MAX() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475028 (owner: 10Yaron Koren) [00:50:45] (03Merged) 10jenkins-bot: Fix for assessing type of MIN(), MAX() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475028 (owner: 10Yaron Koren) [00:52:52] (03CR) 10jenkins-bot: Fix for assessing type of MIN(), MAX() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475028 (owner: 10Yaron Koren) [01:01:55] (03PS1) 10Yaron Koren: Fix for 05422498d891 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475029 [01:03:13] (03PS2) 10Yaron Koren: Fix for 05422498d891 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475029 [01:09:56] (03CR) 10Yaron Koren: [C: 032] Fix for 05422498d891 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475029 (owner: 10Yaron Koren) [01:15:21] (03Merged) 10jenkins-bot: Fix for 05422498d891 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475029 (owner: 10Yaron Koren) [01:17:21] (03CR) 10jenkins-bot: Fix for 05422498d891 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475029 (owner: 10Yaron Koren) [02:39:31] (03PS2) 10Yaron Koren: Use column names in CargoStore COUNT queries [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473936 (owner: 10Mischanix) [03:15:20] (03PS1) 10Dalba: docs/requirements-py3.txt: Use sphinx >= 1.8 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475037 (https://phabricator.wikimedia.org/T204189) [03:17:18] (03CR) 10jerkins-bot: [V: 04-1] docs/requirements-py3.txt: Use sphinx >= 1.8 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475037 (https://phabricator.wikimedia.org/T204189) (owner: 10Dalba) [03:27:21] (03CR) 10Dalba: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475037 (https://phabricator.wikimedia.org/T204189) (owner: 10Dalba) [04:40:00] (03CR) 10Yaron Koren: [C: 032] Use column names in CargoStore COUNT queries [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473936 (owner: 10Mischanix) [04:40:17] (03CR) 10Yaron Koren: [C: 032] "Alright, you've convinced me - I hope this helps." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473936 (owner: 10Mischanix) [04:47:28] (03Merged) 10jenkins-bot: Use column names in CargoStore COUNT queries [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473936 (owner: 10Mischanix) [04:49:30] (03CR) 10jenkins-bot: Use column names in CargoStore COUNT queries [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/473936 (owner: 10Mischanix) [06:16:40] (03CR) 10Xqt: [C: 032] docs/requirements-py3.txt: Use sphinx >= 1.8 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475037 (https://phabricator.wikimedia.org/T204189) (owner: 10Dalba) [06:17:54] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-Documentation, 10Pywikibot-tests: Doc source and destination directories cannot be identical since Sphinx 1.8.0 - https://phabricator.wikimedia.org/T204189 (10Xqt) 05Open>03Resolved [06:19:22] (03Merged) 10jenkins-bot: docs/requirements-py3.txt: Use sphinx >= 1.8 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475037 (https://phabricator.wikimedia.org/T204189) (owner: 10Dalba) [06:22:32] (03CR) 10jenkins-bot: docs/requirements-py3.txt: Use sphinx >= 1.8 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475037 (https://phabricator.wikimedia.org/T204189) (owner: 10Dalba) [06:23:54] (03CR) 10Xqt: [C: 04-1] [cleanup] Remove unused code in 4 files (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/474727 (https://phabricator.wikimedia.org/T203395) (owner: 10Nils ANDRE) [07:16:17] 10Pywikibot, 10Pywikibot-Other-scripts: Add Shan Wikipedia to clean_sandbox.py - https://phabricator.wikimedia.org/T210047 (10Ninjastrikers) [07:16:32] 10Pywikibot, 10Pywikibot-Other-scripts: Add Shan Wikipedia to clean_sandbox.py - https://phabricator.wikimedia.org/T210047 (10Ninjastrikers) [07:22:11] 10Pywikibot, 10Pywikibot-Other-scripts: Add Shan Wikipedia welcome template to welcome.py - https://phabricator.wikimedia.org/T210048 (10Ninjastrikers) [07:36:03] (03PS1) 10JJMC89: Add Shan Wikipedia (shnwiki) welcome template to welcome.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475052 [07:38:00] 10Pywikibot, 10Pywikibot-Other-scripts: Add Shan Wikipedia welcome template to welcome.py - https://phabricator.wikimedia.org/T210048 (10JJMC89) a:03JJMC89 [07:38:59] (03PS2) 10JJMC89: Add Shan Wikipedia (shnwiki) welcome template to welcome.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475052 (https://phabricator.wikimedia.org/T210048) [07:40:56] (03CR) 10Zoranzoki21: [C: 031] "Looks good, LGTM." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475052 (https://phabricator.wikimedia.org/T210048) (owner: 10JJMC89) [07:47:12] (03PS1) 10JJMC89: Add Shan (shn) to clean_sandbox.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475057 [07:47:15] 10Pywikibot, 10Pywikibot-Other-scripts: Add Shan Wikipedia to clean_sandbox.py - https://phabricator.wikimedia.org/T210047 (10JJMC89) a:03JJMC89 [07:50:21] (03PS2) 10JJMC89: Add Shan (shn) to clean_sandbox.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475057 (https://phabricator.wikimedia.org/T210047) [08:16:02] 10Google-Code-in-2018, 10FormWizard, 10Patch-For-Review, 10User-Zoranzoki21: Modify extension group on Special:SpecialPages - https://phabricator.wikimedia.org/T203097 (10Eugene233) 05Open>03Resolved Marking this as resolved. [09:13:56] 10Pywikibot, 10GitHub-Mirrors, 10Release-Engineering-Team, 10Continuous-Integration-Config, 10Pywikibot-tests: AppVeyor test not running since months - https://phabricator.wikimedia.org/T183860 (10Dvorapa) No, we need your help! [09:46:02] 10Google-Code-in-2018, 10goodfirstbug, 10MediaWiki-extensions-General, 10translatewiki.net, and 4 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10Amire80) [09:46:20] 10Google-Code-in-2018, 10goodfirstbug, 10MediaWiki-extensions-General, 10translatewiki.net, and 4 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10Amire80) [10:39:03] 10Pywikibot, 10GitHub-Mirrors, 10Release-Engineering-Team, 10Continuous-Integration-Config, 10Pywikibot-tests: AppVeyor test not running since months - https://phabricator.wikimedia.org/T183860 (10hashar) >>! In T183860#4683354, @Dvorapa wrote: > I'm not sure, why I added RepoAds, sorry. The problem is t... [10:41:09] 10Pywikibot, 10Release-Engineering-Team (Watching / External): Share Appveyor account credentials with Release Engineering - https://phabricator.wikimedia.org/T104306 (10hashar) There is some documentation at https://www.appveyor.com/docs/team-setup/ Seems the AppVeyor accounts/team can be tied to the GitHub o... [10:42:40] (03CR) 10Xqt: [C: 032] Add Shan (shn) to clean_sandbox.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475057 (https://phabricator.wikimedia.org/T210047) (owner: 10JJMC89) [10:43:15] 10Pywikibot, 10Pywikibot-Other-scripts, 10Patch-For-Review: Add Shan Wikipedia welcome template to welcome.py - https://phabricator.wikimedia.org/T210048 (10Xqt) p:05Triage>03Normal [10:44:10] (03CR) 10Xqt: [C: 032] Add Shan Wikipedia (shnwiki) welcome template to welcome.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475052 (https://phabricator.wikimedia.org/T210048) (owner: 10JJMC89) [10:44:40] (03Merged) 10jenkins-bot: Add Shan (shn) to clean_sandbox.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475057 (https://phabricator.wikimedia.org/T210047) (owner: 10JJMC89) [10:46:43] (03Merged) 10jenkins-bot: Add Shan Wikipedia (shnwiki) welcome template to welcome.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475052 (https://phabricator.wikimedia.org/T210048) (owner: 10JJMC89) [10:47:36] (03CR) 10jenkins-bot: Add Shan (shn) to clean_sandbox.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475057 (https://phabricator.wikimedia.org/T210047) (owner: 10JJMC89) [10:49:11] (03CR) 10jenkins-bot: Add Shan Wikipedia (shnwiki) welcome template to welcome.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475052 (https://phabricator.wikimedia.org/T210048) (owner: 10JJMC89) [10:50:58] 10Pywikibot, 10Pywikibot-Other-scripts, 10Patch-For-Review: Add Shan Wikipedia to clean_sandbox.py - https://phabricator.wikimedia.org/T210047 (10Xqt) 05Open>03Resolved p:05Triage>03Normal [10:51:19] 10Pywikibot, 10Pywikibot-Other-scripts, 10Patch-For-Review: Add Shan Wikipedia welcome template to welcome.py - https://phabricator.wikimedia.org/T210048 (10Xqt) 05Open>03Resolved [11:28:24] 10Google-Code-in-2018, 10goodfirstbug, 10MediaWiki-extensions-General, 10translatewiki.net, and 4 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10rafidaslam) [11:55:33] 10Google-Code-in-2018, 10goodfirstbug, 10MediaWiki-extensions-General, 10translatewiki.net, and 4 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10rafidaslam) [12:07:15] 10Pywikibot, 10GitHub-Mirrors, 10Release-Engineering-Team, 10Continuous-Integration-Config, 10Pywikibot-tests: AppVeyor test not running since months - https://phabricator.wikimedia.org/T183860 (10Dvorapa) >>! In T183860#4765323, @hashar wrote: >>>! In T183860#4683354, @Dvorapa wrote: >> I'm not sure, wh... [12:10:27] 10Pywikibot, 10GitHub-Mirrors, 10Release-Engineering-Team, 10Continuous-Integration-Config, 10Pywikibot-tests: AppVeyor test not running since months - https://phabricator.wikimedia.org/T183860 (10Dvorapa) [12:26:51] 10Pywikibot, 10GitHub-Mirrors, 10Release-Engineering-Team, 10Continuous-Integration-Config, 10Pywikibot-tests: AppVeyor test not running since months - https://phabricator.wikimedia.org/T183860 (10Krenair) There is a request open to install AppVeyor on some of the wikimedia github repositories. Is it sup... [14:32:05] 10goodfirstbug, 10Growth-Team, 10MediaWiki-extensions-FlaggedRevs, 10JavaScript, and 2 others: Rewrite ext.flaggedRevs.review.js to make use of action review - https://phabricator.wikimedia.org/T203783 (10Liuxinyu970226) [15:01:31] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @CFisch_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:52:20] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @CFisch_WMDE & @chiborg - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:59:28] (03PS1) 10Arcayn: (Re)move unused code reoprted by vulture [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) [17:42:11] (03CR) 10Xqt: [C: 04-1] (Re)move unused code reoprted by vulture (033 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) (owner: 10Arcayn) [17:51:56] (03CR) 10Arcayn: "@Xqt apologies but I don't see how the code after the break statement breaks the script, could you possibly explain the unexpected behavio" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) (owner: 10Arcayn) [17:52:17] (03PS1) 10Yaron Koren: Add logging of table actions [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475125 [18:00:44] 10Pywikibot, 10Pywikibot-Other-scripts: Add Shan Wikipedia welcome template to welcome.py - https://phabricator.wikimedia.org/T210048 (10JJMC89) [18:00:49] 10Pywikibot, 10Pywikibot-Other-scripts: Add Shan Wikipedia to clean_sandbox.py - https://phabricator.wikimedia.org/T210047 (10JJMC89) [18:08:43] (03PS2) 10Arcayn: (Re)move unused code reported by vulture [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) [18:11:20] (03CR) 10jerkins-bot: [V: 04-1] (Re)move unused code reported by vulture [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) (owner: 10Arcayn) [18:11:24] 10Google-Code-in-2018, 10goodfirstbug, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 2 others: [Bug] Control clicking image doesn't open in new tab - https://phabricator.wikimedia.org/T206348 (10ovasileva) a:03ABorbaWMF [18:21:31] (03PS2) 10Yaron Koren: Add logging of table actions [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475125 [18:23:31] (03CR) 10jerkins-bot: [V: 04-1] Add logging of table actions [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475125 (owner: 10Yaron Koren) [18:24:08] (03CR) 10jerkins-bot: [V: 04-1] Add logging of table actions [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475125 (owner: 10Yaron Koren) [18:25:50] (03PS3) 10Arcayn: (Re)move unused code reported by vulture [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) [18:28:06] (03CR) 10jerkins-bot: [V: 04-1] (Re)move unused code reported by vulture [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) (owner: 10Arcayn) [18:40:53] (03PS3) 10Yaron Koren: Add logging of table actions [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475125 [18:43:12] (03PS4) 10Arcayn: (Re)move unused code reported by vulture [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) [18:52:52] (03CR) 10Yaron Koren: [C: 032] Add logging of table actions [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475125 (owner: 10Yaron Koren) [18:59:04] (03Merged) 10jenkins-bot: Add logging of table actions [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475125 (owner: 10Yaron Koren) [18:59:45] (03CR) 10Arcayn: "@Xqt is that entire block of code which checks for redirect loops made obsolete by the introduction of the check for CircularRedirect erro" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) (owner: 10Arcayn) [19:01:55] (03CR) 10jenkins-bot: Add logging of table actions [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475125 (owner: 10Yaron Koren) [19:12:23] (03CR) 10Framawiki: [C: 04-1] (Re)move unused code reported by vulture (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) (owner: 10Arcayn) [19:13:38] (03CR) 10Framawiki: [C: 04-1] (Re)move unused code reported by vulture (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) (owner: 10Arcayn) [19:40:02] (03PS5) 10Arcayn: (Re)move unused code reported by vulture [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) [19:40:42] (03PS6) 10Arcayn: [cleanup] remove unused code in 2 scripts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) [19:45:30] (03PS7) 10Arcayn: [cleanup] remove unused code in 2 scripts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) [19:56:19] (03PS8) 10Arcayn: [cleanup] remove unused code in 2 scripts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) [19:58:10] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] remove unused code in 2 scripts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) (owner: 10Arcayn) [20:08:27] (03PS9) 10Arcayn: [cleanup] remove unused code in 2 scripts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) [20:10:46] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] remove unused code in 2 scripts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) (owner: 10Arcayn) [20:11:40] (03PS10) 10Arcayn: [cleanup] remove unused code in 2 scripts [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) [21:38:45] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475160 (owner: 10L10n-bot) [22:00:40] (03CR) 10Xqt: "I propose to split this patch into parts because the second one is more difficult to review" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) (owner: 10Arcayn) [22:12:25] (03CR) 10Arcayn: "@Xqt sorry I've never had to split a patch before, do I just re-commit the changes in two separate patches or is there a specific way to s" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475109 (https://phabricator.wikimedia.org/T203395) (owner: 10Arcayn) [22:47:39] (03PS1) 10Yaron Koren: Replace deprecated SpecialPage::getTitle() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475229 [23:18:57] (03PS2) 10Yaron Koren: Replace deprecated SpecialPage::getTitle() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475229 [23:36:20] (03CR) 10Yaron Koren: [C: 032] Replace deprecated SpecialPage::getTitle() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475229 (owner: 10Yaron Koren) [23:42:04] (03Merged) 10jenkins-bot: Replace deprecated SpecialPage::getTitle() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475229 (owner: 10Yaron Koren) [23:43:57] (03CR) 10jenkins-bot: Replace deprecated SpecialPage::getTitle() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475229 (owner: 10Yaron Koren)