[00:00:12] (03PS4) 10D3r1ck01: Add more coverage for SGHooks methods [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/475914 [00:01:27] (03PS5) 10D3r1ck01: Add more coverage for SGHooks methods [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/475914 [00:03:02] (03CR) 10Krinkle: [C: 032] Vector menu: Simplify and cleanup LESS structure [skins/Vector] - 10https://gerrit.wikimedia.org/r/435067 (owner: 10VolkerE) [00:04:28] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.9.0 [skins/Vector] - 10https://gerrit.wikimedia.org/r/475916 (owner: 10Esanders) [00:06:44] 10Google-Code-in-2018, 10goodfirstbug, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 4 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10ABorbaWMF) Looks good to me on master {F27316525} {F27316528} {F27316530} {F2... [00:06:55] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/475914 (owner: 10D3r1ck01) [00:07:43] (03CR) 10D3r1ck01: [C: 032] "Wooo, figured it out! Will need to write test for the exception path in sendEmail()." [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/475914 (owner: 10D3r1ck01) [00:27:38] (03Merged) 10jenkins-bot: Vector menu: Simplify and cleanup LESS structure [skins/Vector] - 10https://gerrit.wikimedia.org/r/435067 (owner: 10VolkerE) [00:31:01] 10Google-Code-in-2018, 10goodfirstbug, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 2 others: [Bug] Control clicking image doesn't open in new tab - https://phabricator.wikimedia.org/T206348 (10ABorbaWMF) Seems to be working on Beta for both desktop and mobile {F27316613} [00:33:23] (03Merged) 10jenkins-bot: Add more coverage for SGHooks methods [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/475914 (owner: 10D3r1ck01) [00:35:53] (03CR) 10jenkins-bot: Add more coverage for SGHooks methods [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/475914 (owner: 10D3r1ck01) [01:47:02] 10Google-Code-in-2018, 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Isarra) [01:54:14] 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10Wikimedia-Site-requests, and 2 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10pmiazga) [01:55:46] (03CR) 10Zhuyifei1999: "I'm genuinely surprised by this PEP8 change. o.O" (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475823 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [02:07:01] (03CR) 10Zhuyifei1999: [PEP8] Fixed W504 violations in scripts/ directory (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475690 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [02:23:37] (03CR) 10Xqt: [C: 04-1] [PEP8] Fixed W504 violations in scripts/ directory (035 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475690 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [02:24:46] (03CR) 10Xqt: [C: 04-1] "> recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475690 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [02:26:57] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10siyam-_-) @Aklapper I have got the font from Adobe Illustrator CC 2019 font list [02:28:01] (03CR) 10Xqt: [C: 04-1] [PEP8] Fixed W504 violations in scripts/ directory (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475823 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [02:30:41] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10siyam-_-) @Aklapper Did I make any mistake? As you said siyam's fault......Is there any fault that I have... [02:33:41] (03CR) 10Xqt: [C: 04-1] [PEP8] Fixed W504 violations in scripts/ directory (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475823 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [02:38:38] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10Ebe123) > that's not siyam's fault It's *not* your fault. [02:41:23] (03CR) 10Xqt: [C: 04-1] [PEP8] Fixed W504 violations in script/ directory (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475837 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [04:09:17] (03PS2) 10VolkerE: Use `opacity` for a WikimediaUI aligned transition on opening menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/475802 [04:37:09] 10goodfirstbug, 10Revision-Slider, 10TCB-Team, 10UI-Standardization, and 6 others: Replace custom pin icon with OOUI's 'pushPin' - https://phabricator.wikimedia.org/T194613 (10Volker_E) [06:08:25] (03CR) 10Takidelfin: [PEP8] Fixed W504 violations in scripts/ directory (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475823 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [06:15:10] (03PS2) 10Takidelfin: [PEP8] Fixed W504 violations in script/ directory [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475837 (https://phabricator.wikimedia.org/T207836) [06:15:49] (03CR) 10Takidelfin: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475837 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [06:17:20] (03CR) 10jerkins-bot: [V: 04-1] [PEP8] Fixed W504 violations in script/ directory [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475837 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [07:07:22] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10siyam-_-) @Ebe123 but what fault? [07:11:10] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10Wwdjbox) {F27317397} [07:35:29] (03CR) 10Xqt: "> recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475833 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [07:44:32] (03CR) 10Xqt: [C: 04-1] [PEP8] Fixed W504 violations in scripts/ directory (033 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475833 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [07:49:55] (03CR) 10Xqt: [PEP8] Fixed W504 violations in script/ directory (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475837 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [07:51:28] (03CR) 10Xqt: [C: 04-1] [PEP8] Fixed W504 violations in script/ directory [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475837 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [07:51:51] (03CR) 10Xqt: [C: 04-1] [cleanup] Remove unused code in 4 files [pywikibot/core] - 10https://gerrit.wikimedia.org/r/474727 (https://phabricator.wikimedia.org/T203395) (owner: 10Nils ANDRE) [08:29:04] 10Pywikibot: Add Arabic (ar) translation for welcome.py (patch against Pywikibot core) - https://phabricator.wikimedia.org/T210480 (10Meno25) [08:30:30] 10Pywikibot: Update Arabic (ar) translation for welcome.py (patch against Pywikibot core) - https://phabricator.wikimedia.org/T210480 (10Meno25) [08:37:59] 10Pywikibot: Update Arabic (ar) translation for welcome.py (patch against Pywikibot core) - https://phabricator.wikimedia.org/T210480 (10JJMC89) a:03JJMC89 [08:41:01] (03PS1) 10JJMC89: Add Arabic welcome templates to welcome.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475966 [08:42:57] 10Pywikibot: Update Arabic (ar) translation for welcome.py (patch against Pywikibot core) - https://phabricator.wikimedia.org/T210480 (10JJMC89) p:05Triage>03Normal [08:44:34] (03PS2) 10JJMC89: Add Arabic welcome templates to welcome.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475966 (https://phabricator.wikimedia.org/T210480) [09:27:21] 10Pywikibot, 10Patch-For-Review: Update Arabic (ar) translation for welcome.py (patch against Pywikibot core) - https://phabricator.wikimedia.org/T210480 (10Xqt) 05Open>03Resolved [09:27:45] (03CR) 10Xqt: [C: 032] Add Arabic welcome templates to welcome.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475966 (https://phabricator.wikimedia.org/T210480) (owner: 10JJMC89) [09:29:44] (03Merged) 10jenkins-bot: Add Arabic welcome templates to welcome.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475966 (https://phabricator.wikimedia.org/T210480) (owner: 10JJMC89) [09:31:46] (03CR) 10jenkins-bot: Add Arabic welcome templates to welcome.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475966 (https://phabricator.wikimedia.org/T210480) (owner: 10JJMC89) [10:54:42] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Disable ReCaptcha for logged in users - https://phabricator.wikimedia.org/T205136 (10Nathan_fraignt) a:03Nathan_fraignt [11:24:27] 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10Wikimedia-Site-requests, and 2 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10phuedx) [11:35:10] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Disable ReCaptcha for logged in users - https://phabricator.wikimedia.org/T205136 (10Urbanecm) 05Open>03Resolved [11:43:54] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Incorporate 404 and 500 messages better in Tracker's interface - https://phabricator.wikimedia.org/T210395 (10Nathan_fraignt) a:03Nathan_fraignt [12:53:10] 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10Wikimedia-Site-requests, and 2 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10phuedx) [13:22:02] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Wikidata-Campsite, and 2 others: Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10Lydia_Pintscher) Thank you for your patch :) [13:38:47] 10Pywikibot, 10Pywikibot-Other-scripts, 10Patch-For-Review, 10User-Zoranzoki21: Add Sindhi (sd) welcome template to welcome.py - https://phabricator.wikimedia.org/T203292 (10Dvorapa) @Arslanali Are you running the Pywikibot welcome.py script? [13:41:30] (03Abandoned) 10Takidelfin: [PEP8] Fixed W504 violations in scripts/ directory [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475833 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [13:41:42] (03Abandoned) 10Takidelfin: [PEP8] Fixed W504 violations in scripts/ directory [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475690 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [13:41:46] (03Abandoned) 10Takidelfin: [PEP8] Fixed W504 violations in script/ directory [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475837 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [13:42:56] (03Abandoned) 10Takidelfin: [PEP8] Fixed W504 violations in scripts/ directory [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475823 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [14:05:04] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer, and 2 others: Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10Lucas_Werkmeister_WMDE) [14:50:28] (03CR) 10Xqt: "> Abandoned due to 'relation chain'. It was causing problems with" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/475833 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [16:10:40] (03PS1) 10D3r1ck01: Use $this->setMwGlobals() to set test globals / configs [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/476045 [16:11:50] (03CR) 10jerkins-bot: [V: 04-1] Use $this->setMwGlobals() to set test globals / configs [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/476045 (owner: 10D3r1ck01) [16:13:03] (03PS2) 10D3r1ck01: Use $this->setMwGlobals() to set test globals / configs [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/476045 [16:22:00] (03PS2) 10D3r1ck01: [IMPR] Add contributor from Côte d'Ivoire [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/475601 [16:22:37] (03CR) 10D3r1ck01: [C: 031] "I think this should be good now!" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/475601 (owner: 10D3r1ck01) [16:23:01] africanhope: This should be good! [16:23:03] https://gerrit.wikimedia.org/r/c/labs/tools/awmd-stats/+/475601 [16:23:10] Anytime you have time, you can deploy! [16:23:17] Will add to the calendar, meh! [16:24:25] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/476045 (owner: 10D3r1ck01) [16:30:38] 10Africa-Wikimedia-Developers: [Deployments] Calendar for deployment of patches for AWMD tools - https://phabricator.wikimedia.org/T206401 (10D3r1ck01) [16:46:18] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10abian) [16:46:27] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10abian) [16:57:25] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10rafidaslam) a:05rafidaslam>03None [17:10:55] 10Google-Code-in-2018, 10Page-Previews, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Technical-Debt: Popups: Update babel-preset-env and friends - https://phabricator.wikimedia.org/T197883 (10ovasileva) [18:22:38] 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10Wikimedia-Site-requests, and 3 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10nray) a:03nray [18:24:18] 10Africa-Wikimedia-Developers: Fix broken tests for the AWMD stats tool - https://phabricator.wikimedia.org/T210336 (10D3r1ck01) 05Open>03Resolved a:03D3r1ck01 Fixed here: https://gerrit.wikimedia.org/r/c/labs/tools/awmd-stats/+/475601. [18:41:16] 10Google-Code-in-2018, 10goodfirstbug, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 2 others: [Bug] Control clicking image doesn't open in new tab - https://phabricator.wikimedia.org/T206348 (10ovasileva) 05Open>03Resolved looks good, thanks all! [18:42:43] 10Google-Code-in-2018, 10goodfirstbug, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 4 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10ovasileva) 05Open>03Resolved [18:51:55] (03PS1) 10Xqt: [fix] Temporarily deactivate WikibaseKnownTypesTests for ws/wpbeta [pywikibot/core] - 10https://gerrit.wikimedia.org/r/476084 (https://phabricator.wikimedia.org/T210322) [20:27:18] 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10Wikimedia-Site-requests, and 3 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10nray) Tested on https://en.m.wikipedia.org and we are still sending eve... [20:27:33] 10Google-Code-in-2018, 10goodfirstbug, 10MinervaNeue, 10Wikimedia-Site-requests, and 3 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10nray) 05Open>03Resolved [20:52:50] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Looks very nice!" [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/476045 (owner: 10D3r1ck01) [20:54:50] (03CR) 10D3r1ck01: "> Is there somebody else actively working on this extension who want's to have a look?" [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/476045 (owner: 10D3r1ck01) [20:59:38] (03PS1) 10Takidelfin: [PEP8] Fixed W504 violations in script/ directory [pywikibot/core] - 10https://gerrit.wikimedia.org/r/476106 (https://phabricator.wikimedia.org/T207836) [21:18:28] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476113 (owner: 10L10n-bot) [21:19:18] (03PS1) 10Yaron Koren: Add quoting of DB index names [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476139 [21:55:22] (03CR) 10Xqt: "Looks good. Some minor problems remaining" (0313 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/476106 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [22:04:11] 10goodfirstbug, 10MinervaNeue, 10Wikimedia-Site-requests, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 2 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10Aklapper) [22:06:27] 10Google-Code-in-2018, 10MediaWiki-extensions-General, 10Patch-For-Review: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable) - https://phabricator.wikimedia.org/T210365 (10Legoktm) [22:06:38] (03CR) 10Takidelfin: [PEP8] Fixed W504 violations in script/ directory (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/476106 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [22:09:16] (03CR) 10Takidelfin: [PEP8] Fixed W504 violations in script/ directory (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/476106 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [22:13:11] (03PS2) 10Takidelfin: [PEP8] Fixed W504 violations in script/ directory [pywikibot/core] - 10https://gerrit.wikimedia.org/r/476106 (https://phabricator.wikimedia.org/T207836) [22:14:49] (03CR) 10jerkins-bot: [V: 04-1] [PEP8] Fixed W504 violations in script/ directory [pywikibot/core] - 10https://gerrit.wikimedia.org/r/476106 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [22:25:28] (03CR) 10Takidelfin: [PEP8] Fixed W504 violations in script/ directory (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/476106 (https://phabricator.wikimedia.org/T207836) (owner: 10Takidelfin) [22:26:15] (03PS3) 10Takidelfin: [PEP8] Fixed W504 violations in script/ directory [pywikibot/core] - 10https://gerrit.wikimedia.org/r/476106 (https://phabricator.wikimedia.org/T207836) [22:41:11] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10Aryanmediratta) {F27319785}