[00:20:14] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer, and 3 others: Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10Ladsgroup) a:05Ladsgroup→03None [00:39:21] 10Google-Code-in-2018, 10OOUI, 10Patch-For-Review, 10User-Zoranzoki21: OOUI Documentation: ClippableElement: Fix typo in #$element - https://phabricator.wikimedia.org/T210133 (10Prtksxna) >>! In T210133#4824296, @Esanders wrote: > Why is $element not a link? I note on https://doc.wikimedia.org/oojs-ui/mas... [05:26:35] (03CR) 10Zhuyifei1999: [cleanup] Split site.py into site folder (033 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480503 (owner: 10Xqt) [08:03:02] (03CR) 10Xqt: "> YAY, this is a million times easier for me to read :)" (035 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480503 (owner: 10Xqt) [09:05:56] 10Pywikibot: --help option should works too - https://phabricator.wikimedia.org/T212046 (10Dvorapa) >>! In T212046#4830548, @Xqt wrote: >> Pywikibot was warned multiple times about this issue > > Can you explain? Me: Sphinx devs, please improve your parameter parser for doc Sphinx devs: Pywikibot doesn't follo... [09:07:21] 10Pywikibot: --help option should works too - https://phabricator.wikimedia.org/T212046 (10Dvorapa) Users get used to it quickly, only other devs are somehow not understanding, why we are not using what everyone uses. [09:30:36] (03CR) 10Zhuyifei1999: [cleanup] Split site.py into site folder (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480503 (owner: 10Xqt) [09:34:49] (03CR) 10Zhuyifei1999: [C: 03+1] "I think this is a nice step forward, and don't seem to break compatibility in public interfaces. We can do more moves in follow up patches" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480503 (owner: 10Xqt) [09:39:55] 10Pywikibot, 10Pywikibot-archivebot.py: archivebot.str2time does not respect minutes and months - https://phabricator.wikimedia.org/T147739 (10whym) If the two time scales are still needed, I would suggest using longer forms ('600min' and '2mon'') or full spells ('600minute' and '2month', not sure if it should... [12:42:00] 10goodfirstbug, 10Wikidata, 10Need-volunteer: Add data value type to Special:ListDatatypes - https://phabricator.wikimedia.org/T210598 (10Addshore) p:05Triage→03Low [14:28:17] (03PS10) 10Xqt: [cleanup] Split site.py into site folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480503 [14:29:52] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Split site.py into site folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480503 (owner: 10Xqt) [14:32:55] (03PS11) 10Xqt: [cleanup] Split site.py into site folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480503 [14:34:25] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Split site.py into site folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480503 (owner: 10Xqt) [14:35:59] (03PS12) 10Xqt: [cleanup] Split site.py into site folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480503 [14:42:39] (03PS13) 10Xqt: [cleanup] Split site.py into site folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480503 [14:46:50] (03PS1) 10Yaron Koren: Another year fix - follow-up to d294bbacffd2 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480754 [14:50:22] (03PS2) 10Yaron Koren: Another year fix - follow-up to d294bbacffd2 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480754 [14:55:31] (03CR) 10Yaron Koren: [C: 03+2] Another year fix - follow-up to d294bbacffd2 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480754 (owner: 10Yaron Koren) [15:25:37] (03Merged) 10jenkins-bot: Another year fix - follow-up to d294bbacffd2 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480754 (owner: 10Yaron Koren) [15:27:45] (03CR) 10jenkins-bot: Another year fix - follow-up to d294bbacffd2 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480754 (owner: 10Yaron Koren) [15:30:02] (03CR) 10D3r1ck01: [C: 03+2] "Schedule for deployment! LGTM!" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480665 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [15:31:03] (03Merged) 10jenkins-bot: [FIX] Adjust test method getContributors() [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480665 (https://phabricator.wikimedia.org/T202231) (owner: 10African Hope) [15:33:44] (03CR) 10D3r1ck01: "This has been around for a while, anything left to improve on it? Or is it good to go?" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296 (owner: 10D3r1ck01) [15:36:05] (03PS1) 10Xqt: [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 [15:37:28] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 (owner: 10Xqt) [15:39:49] (03PS1) 10Mahveotm: I added my name to AWMD contibutors list [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480771 [15:39:52] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480771 (owner: 10Mahveotm) [15:42:32] (03CR) 10D3r1ck01: [C: 04-1] "There is a syntax error." (031 comment) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480771 (owner: 10Mahveotm) [15:42:44] (03CR) 10D3r1ck01: [C: 04-1] "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480771 (owner: 10Mahveotm) [15:43:09] (03CR) 10jerkins-bot: [V: 04-1] I added my name to AWMD contibutors list [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480771 (owner: 10Mahveotm) [15:47:27] (03PS2) 10Xqt: [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 [15:48:45] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 (owner: 10Xqt) [15:50:54] (03PS14) 10Xqt: [cleanup] Split site.py into site folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480503 [15:52:23] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Split site.py into site folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480503 (owner: 10Xqt) [16:06:12] (03PS1) 10Thiemo Kreuz (WMDE): Streamline ListContentSpamlistLookupTest [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/480784 [16:07:50] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "What the new test cases do is all fine. But I found the code not well readable. I uploaded a possible refactoring as Id45c886. Please have" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296 (owner: 10D3r1ck01) [16:11:21] (03PS3) 10Xqt: [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 [16:13:14] (03PS15) 10Xqt: [cleanup] Split site.py into site folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480503 [16:13:18] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 (owner: 10Xqt) [16:20:10] (03CR) 10D3r1ck01: "> What the new test cases do is all fine. But I found the code not well readable. I uploaded a possible refactoring as Id45c886. Please ha" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296 (owner: 10D3r1ck01) [16:29:19] (03PS4) 10Xqt: [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 [16:30:45] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 (owner: 10Xqt) [16:39:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "You can +2 both in any order you like. Gerrit takes care of it. Or squash the later patch into this one. Or abandon it. Feel free. :-)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296 (owner: 10D3r1ck01) [16:49:36] (03CR) 10D3r1ck01: [C: 03+2] "Thank you @Thiemo :)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296 (owner: 10D3r1ck01) [16:49:38] (03CR) 10D3r1ck01: [C: 03+2] Streamline ListContentSpamlistLookupTest [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/480784 (owner: 10Thiemo Kreuz (WMDE)) [16:54:08] (03Merged) 10jenkins-bot: tests: Add unit tests for SpamlistLookup::factory() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296 (owner: 10D3r1ck01) [16:54:10] (03Merged) 10jenkins-bot: Streamline ListContentSpamlistLookupTest [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/480784 (owner: 10Thiemo Kreuz (WMDE)) [16:56:15] (03CR) 10D3r1ck01: [C: 04-1] I added my name to AWMD contibutors list (031 comment) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480771 (owner: 10Mahveotm) [16:57:30] (03CR) 10jenkins-bot: tests: Add unit tests for SpamlistLookup::factory() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296 (owner: 10D3r1ck01) [17:05:35] (03CR) 10jenkins-bot: Streamline ListContentSpamlistLookupTest [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/480784 (owner: 10Thiemo Kreuz (WMDE)) [17:09:21] (03PS5) 10Xqt: [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 [17:10:52] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 (owner: 10Xqt) [17:12:03] (03PS1) 10Mahveotm: I added my name to the list of AWMD contributors [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480797 [17:18:22] (03CR) 10D3r1ck01: "Please, amend this change instead: Icc0969aff43163899cea50. For more information on how to do that, see: https://www.mediawiki.org/wiki/Ge" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480797 (owner: 10Mahveotm) [17:18:44] (03Abandoned) 10D3r1ck01: I added my name to the list of AWMD contributors [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480797 (owner: 10Mahveotm) [17:20:50] (03PS6) 10Xqt: [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 [17:22:19] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 (owner: 10Xqt) [17:27:53] (03PS2) 10Mahveotm: I added my name to AWMD contibutors list [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480771 [17:32:21] (03CR) 10D3r1ck01: "Good! Now amend the commit message to that in the comment." [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480771 (owner: 10Mahveotm) [17:34:48] (03PS7) 10Xqt: [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 [17:36:07] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Split page.py into page folder [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480765 (owner: 10Xqt) [17:45:52] (03CR) 10Samwilson: Another year fix - follow-up to d294bbacffd2 (031 comment) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480754 (owner: 10Yaron Koren) [18:04:47] (03CR) 10Yaron Koren: [C: 03+2] "Why yes, yes it is. :(" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480754 (owner: 10Yaron Koren) [18:05:37] (03PS1) 10Yaron Koren: Fix for 2eec3d84efa2 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480808 [18:06:25] (03PS2) 10Yaron Koren: Fix for 2eec3d84efa2 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480808 [18:06:57] 10Pywikibot, 10Pywikibot-tests: proofreadpage_tests.TestPageOCR.test_ocr_googleocr sometimes fails with ValueError - https://phabricator.wikimedia.org/T212076 (10Mpaa) I copy it here for convenience. Interesting, it looks like googleOCR answer is not deterministic or some bytes are lost somewhere. ` FAIL: tes... [18:12:46] (03CR) 10Yaron Koren: [C: 03+2] Fix for 2eec3d84efa2 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480808 (owner: 10Yaron Koren) [18:22:04] (03Merged) 10jenkins-bot: Fix for 2eec3d84efa2 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480808 (owner: 10Yaron Koren) [18:23:53] (03CR) 10jenkins-bot: Fix for 2eec3d84efa2 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480808 (owner: 10Yaron Koren) [18:26:16] (03CR) 10Yaron Koren: [C: 03+2] "Thanks for pointing that out - it was a copy-and-paste error. I just checked in a fix." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480754 (owner: 10Yaron Koren) [18:31:06] (03CR) 10Samwilson: "> Patch Set 2:" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/480754 (owner: 10Yaron Koren) [18:40:55] (03PS1) 10Mpaa: proofreadpage_tests.py: add error text to Exception [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480810 (https://phabricator.wikimedia.org/T212076) [18:51:32] 10goodfirstbug, 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10Patch-For-Review: Editor summary on mobile does neither receive mediawiki.ui appearance nor inherit font-size - https://phabricator.wikimedia.org/T211743 (10JTannerWMF) 05Open→03Resolved a:03JTannerWMF [18:51:42] 10goodfirstbug, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10Patch-For-Review: Editor summary on mobile does neither receive mediawiki.ui appearance nor inherit font-size - https://phabricator.wikimedia.org/T211743 (10matmarex) [19:14:56] (03PS1) 10Mahveotm: Icc0969aff43163899cea50 [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480813 [19:52:54] (03CR) 10Samwilson: "recheck" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/466839 (https://phabricator.wikimedia.org/T177810) (owner: 10Samwilson) [19:53:44] (03CR) 10jerkins-bot: [V: 04-1] Remove ParamNameNoMatch phpcs sniff and fix errors [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/466839 (https://phabricator.wikimedia.org/T177810) (owner: 10Samwilson) [20:00:33] (03CR) 10Framawiki: [C: 03+2] [IMPR] Use SingleSiteBot with states_redirect.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480076 (owner: 10Xqt) [20:00:57] (03CR) 10Xqt: [C: 03+2] proofreadpage_tests.py: add error text to Exception [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480810 (https://phabricator.wikimedia.org/T212076) (owner: 10Mpaa) [20:01:57] (03CR) 10Framawiki: [C: 03+2] "I think that you can allow you to self merge L10N patches :)" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480088 (owner: 10Xqt) [20:02:52] (03Merged) 10jenkins-bot: [IMPR] Use SingleSiteBot with states_redirect.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480076 (owner: 10Xqt) [20:03:22] (03Merged) 10jenkins-bot: proofreadpage_tests.py: add error text to Exception [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480810 (https://phabricator.wikimedia.org/T212076) (owner: 10Mpaa) [20:03:31] (03Merged) 10jenkins-bot: [L10N] Update languages_by_size [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480088 (owner: 10Xqt) [20:04:49] (03CR) 10jenkins-bot: [IMPR] Use SingleSiteBot with states_redirect.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480076 (owner: 10Xqt) [20:06:29] (03CR) 10jenkins-bot: proofreadpage_tests.py: add error text to Exception [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480810 (https://phabricator.wikimedia.org/T212076) (owner: 10Mpaa) [20:08:12] (03CR) 10jenkins-bot: [L10N] Update languages_by_size [pywikibot/core] - 10https://gerrit.wikimedia.org/r/480088 (owner: 10Xqt) [20:23:41] (03CR) 10Framawiki: [C: 03+2] [IMPR] Additional ListOption subclasses [pywikibot/core] - 10https://gerrit.wikimedia.org/r/439472 (owner: 10Xqt) [20:25:21] (03Merged) 10jenkins-bot: [IMPR] Additional ListOption subclasses [pywikibot/core] - 10https://gerrit.wikimedia.org/r/439472 (owner: 10Xqt) [20:28:03] (03CR) 10jenkins-bot: [IMPR] Additional ListOption subclasses [pywikibot/core] - 10https://gerrit.wikimedia.org/r/439472 (owner: 10Xqt) [20:56:13] (03Abandoned) 10D3r1ck01: Icc0969aff43163899cea50 [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/480813 (owner: 10Mahveotm) [21:48:40] 10goodfirstbug, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-consensus-needed, 10Need-volunteer: Add monolingual language code en-in (Indian English) - https://phabricator.wikimedia.org/T212313 (10Mbch331) @GerardM @jhsoby What's the opinion of LangCom about this request? [22:51:12] (03PS2) 10Samwilson: Remove ParamNameNoMatch phpcs sniff and fix errors [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/466839 (https://phabricator.wikimedia.org/T177810) [23:10:49] (03CR) 10Samwilson: "Hi Yaron :) have you got a mo' for this one?" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/466839 (https://phabricator.wikimedia.org/T177810) (owner: 10Samwilson)