[01:06:14] (03CR) 10Jdlrobson: [C: 03+2] "Did a wget before and after the change on pages with site banners and wikidata page banners. No difference in the HTML between the two" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [01:06:38] (03CR) 10Jdlrobson: [C: 03+2] template: Avoid raw HTML parameter for jump link labels [skins/Vector] - 10https://gerrit.wikimedia.org/r/486002 (owner: 10Krinkle) [01:10:46] (03Merged) 10jenkins-bot: Start extracting rendering from PHP into Mustache [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [01:11:08] (03Merged) 10jenkins-bot: template: Remove is_callable check for getIndicators() [skins/Vector] - 10https://gerrit.wikimedia.org/r/486001 (owner: 10Krinkle) [01:11:10] (03Merged) 10jenkins-bot: template: Avoid raw HTML parameter for jump link labels [skins/Vector] - 10https://gerrit.wikimedia.org/r/486002 (owner: 10Krinkle) [01:11:55] (03CR) 10VolkerE: [C: 03+1] "Exciting!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [01:12:16] (03CR) 10Krinkle: "@James There's a number of client-side only cases where Mustache added undesirable overhead. I haven't personally looked into that, but it" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [12:14:33] (03Abandoned) 10MarcoAurelio: Add 'massmessage-optout-category' as tracking category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/485681 (https://phabricator.wikimedia.org/T213911) (owner: 10MarcoAurelio) [14:32:33] (03PS1) 10Ammarpad: Update copyright year [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/486298 [14:35:16] (03PS2) 10Ammarpad: Update copyright year [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/486298 [14:42:58] (03PS3) 10Ammarpad: Update copyright year [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/486298 [14:47:54] (03PS4) 10Ammarpad: Update copyright year [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/486298 [14:53:02] (03CR) 10D3r1ck01: "Thanks for your patch! While I'm about to review the patch, please your "Gerrit Topic" should not contain spaces as it's malformed. Next t" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/486298 (owner: 10Ammarpad) [14:54:44] (03CR) 10Ammarpad: "> Thanks for your patch! While I'm about to review the patch, please" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/486298 (owner: 10Ammarpad) [15:01:41] (03CR) 10D3r1ck01: "I played with your patch a little bit and made some improvements. See PS4, thanks for your work and you can finish the rest :)" (032 comments) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/486298 (owner: 10Ammarpad) [15:02:00] (03CR) 10D3r1ck01: "Ops, I meant to say PS5" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/486298 (owner: 10Ammarpad) [15:02:22] (03PS5) 10D3r1ck01: [IMPR] Update Copyright current year [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/486298 (owner: 10Ammarpad) [15:04:40] (03CR) 10D3r1ck01: [IMPR] Update Copyright current year (031 comment) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/486298 (owner: 10Ammarpad) [17:33:37] (03CR) 10Isarra: "This seems woefully premature. The skinning backend lacks any of the consistency I would have expected to see before we do any such meanin" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [17:39:00] (03CR) 10D3r1ck01: "Okay, this can be finally reviewed for now, will continue working on this class in the future." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/477130 (owner: 10D3r1ck01) [18:55:23] (03CR) 10Jdlrobson: [C: 03+2] "I'm sorry, but I don't share your concerns here. A few comments inline." [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [19:49:23] Evening! [19:50:29] Just want to notify xSavitar, I won't be able to participate in tomorrows meeting as I would be having an exact at roughly the same time. [19:50:35] Warm regards! [20:05:27] I'm not the one hosting! But thanks for notifying [20:20:54] paladox: You know I'm going to poke you right? [20:21:01] Seeing some UI changes [20:21:04] hi [20:21:04] Anything up? [20:21:09] yup, we updated the ui [20:21:17] by that just a colour change [20:21:18] from grey [20:21:31] Hmmm! CSS? [20:21:43] yeh [20:21:50] Cool! Nice effect! [20:22:02] yup! (thcipriani came up with that colour!) [20:22:15] sent a email to wikitech-i about it [20:23:11] Also the original PolyGerrit team has disbranded and a new one taking over. [20:23:32] so development of PolyGerrit will ramp up (came from the new maintainers words) [20:26:30] xSavitar ^^ [20:26:59] I saw the email, cool! [20:27:14] Tell thcipriani that I send my thanks [20:27:28] ok [20:27:39] note that hes in #wikimedia-releng :) [21:40:53] (03CR) 10Isarra: "One of the main problems with MediaWiki skins and skin-whatever compatibility currently is the wild inconsistency between the skins themse" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [21:44:09] (03CR) 10Krinkle: "@Isarra There will be no DOM changes. There will be no interface changes to Skin or SkinTemplate. MW core remains compatible. Vector outpu" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [21:47:13] (03CR) 10Isarra: "@Krinkle: That's good, but doesn't change anything with regards to the complexity concerns." [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [21:50:33] (03CR) 10Isarra: "I didn't find any related tickets for this specifically - can you direct me to that?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle)