[00:15:52] (03CR) 10Aklapper: "Hi Eric, feel free to abandon your changeset, as it seems to be a test. Thanks!" [extensions/examples] - 10https://gerrit.wikimedia.org/r/487099 (owner: 10Eric Gardner) [00:20:34] (03Abandoned) 10Eric Gardner: Example commit [extensions/examples] - 10https://gerrit.wikimedia.org/r/487099 (owner: 10Eric Gardner) [02:10:52] 10Google-Code-in-2018, 10Developer-Advocacy (Jan-Mar 2019): Decide which GCI 2018 mentor/admin to attend GCI Grand Prize winners weekend June 10-13, 2019 - https://phabricator.wikimedia.org/T212827 (10Ebe123) [02:13:28] 10Google-Code-in-2018, 10Developer-Advocacy (Jan-Mar 2019): Decide which GCI 2018 mentor/admin to attend GCI Grand Prize winners weekend June 10-13, 2019 - https://phabricator.wikimedia.org/T212827 (10Ebe123) The slot for Wikimedia have been confirmed to be **June 10-13**. I will be sending out a message to th... [06:34:48] (03Abandoned) 10Xqt: [test] travis.yml: disable wikia tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/485483 (https://phabricator.wikimedia.org/T214009) (owner: 10Xqt) [07:33:57] 10Pywikibot, 10Pywikibot-Other-scripts, 10Pywikibot-pagegenerators.py, 10good first bug: Add -unusedcategories param - https://phabricator.wikimedia.org/T214923 (10Xqt) p:05Triage→03Low [07:57:58] (03PS1) 10Xqt: [tests] Skip site_tests.TestUserContribsWithoutUser for wikia [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487114 (https://phabricator.wikimedia.org/T214263) [08:04:54] (03CR) 10jerkins-bot: [V: 04-1] [tests] Skip site_tests.TestUserContribsWithoutUser for wikia [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487114 (https://phabricator.wikimedia.org/T214263) (owner: 10Xqt) [08:10:51] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487114 (https://phabricator.wikimedia.org/T214263) (owner: 10Xqt) [08:12:41] (03CR) 10jerkins-bot: [V: 04-1] [tests] Skip site_tests.TestUserContribsWithoutUser for wikia [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487114 (https://phabricator.wikimedia.org/T214263) (owner: 10Xqt) [08:15:12] (03PS1) 10Xqt: [tests] Skip some site_tests.TestSiteGenerators methods for wikia [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487116 (https://phabricator.wikimedia.org/T214265) [08:17:44] (03CR) 10jerkins-bot: [V: 04-1] [tests] Skip some site_tests.TestSiteGenerators methods for wikia [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487116 (https://phabricator.wikimedia.org/T214265) (owner: 10Xqt) [08:21:46] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487116 (https://phabricator.wikimedia.org/T214265) (owner: 10Xqt) [08:24:19] (03CR) 10jerkins-bot: [V: 04-1] [tests] Skip some site_tests.TestSiteGenerators methods for wikia [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487116 (https://phabricator.wikimedia.org/T214265) (owner: 10Xqt) [08:30:16] 10Pywikibot, 10Pywikibot-tests: pywikibot-core-tox-docker test is failing with flake8 3.7.0 and 3.7.1 - https://phabricator.wikimedia.org/T214962 (10Xqt) [08:30:22] 10Pywikibot, 10Pywikibot-tests: pywikibot-core-tox-docker test is failing with flake8 3.7.0 and 3.7.1 - https://phabricator.wikimedia.org/T214962 (10Xqt) p:05Triage→03High [08:30:33] 10Google-Code-in-2018, 10Developer-Advocacy (Jan-Mar 2019): Decide which GCI 2018 mentor/admin to attend GCI Grand Prize winners weekend June 10-13, 2019 - https://phabricator.wikimedia.org/T212827 (10Urbanecm) Yes, I'm available. [08:37:14] (03PS1) 10Xqt: [tests] Set flake8 release 3.6.0 mandatory [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) [08:49:29] (03PS2) 10Xqt: [tests] Set flake8 release 3.6.0 mandatory [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) [09:01:46] (03PS3) 10Xqt: [tests] Require flake8 release 3.7.0 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) [09:12:29] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: pywikibot-core-tox-docker test is failing with flake8 3.7.0 and 3.7.1 - https://phabricator.wikimedia.org/T214962 (10Xqt) Seems flake8 3.7 has its own flake8-per-file-ignores option http://flake8.pycqa.org/en/latest/user/options.html?highlight=per-file-igno... [09:14:59] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) (owner: 10Xqt) [09:16:39] (03CR) 10jerkins-bot: [V: 04-1] [tests] Require flake8 release 3.7.0 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) (owner: 10Xqt) [09:56:58] (03PS4) 10Xqt: [tests] Require flake8 release 3.7.0 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) [09:58:35] (03CR) 10jerkins-bot: [V: 04-1] [tests] Require flake8 release 3.7.0 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) (owner: 10Xqt) [10:16:08] (03PS5) 10Xqt: [tests] Require flake8 release 3.7.0 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) [10:16:31] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: pywikibot-core-tox-docker test is failing with flake8 3.7.0 and 3.7.1 - https://phabricator.wikimedia.org/T214962 (10Xqt) a:03Xqt [10:31:17] (03CR) 10jerkins-bot: [V: 04-1] [tests] Require flake8 release 3.7.0 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) (owner: 10Xqt) [10:47:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Add PHPUnit tests for methods in MassMessageListDiffEngine::class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/477130 (owner: 10D3r1ck01) [11:00:10] (03PS6) 10Xqt: [tests] Require flake8 release 3.7.0 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) [11:01:58] (03Merged) 10jenkins-bot: Add PHPUnit tests for methods in MassMessageListDiffEngine::class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/477130 (owner: 10D3r1ck01) [11:04:56] 10Pywikibot: inline interwiki links shouldn't be treated as such - https://phabricator.wikimedia.org/T57298 (10Xqt) p:05Low→03High [11:14:51] (03CR) 10jerkins-bot: [V: 04-1] [tests] Require flake8 release 3.7.0 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) (owner: 10Xqt) [11:16:43] (03CR) 10jenkins-bot: Add PHPUnit tests for methods in MassMessageListDiffEngine::class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/477130 (owner: 10D3r1ck01) [12:15:17] (03PS7) 10Xqt: [tests] Require flake8 release 3.7.0 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) [13:29:36] 10Google-Code-in-2018, 10Developer-Advocacy (Jan-Mar 2019): Decide which GCI 2018 mentor/admin to attend GCI Grand Prize winners weekend June 10-13, 2019 - https://phabricator.wikimedia.org/T212827 (10Abdulwd) I'm available. [14:49:57] (03PS8) 10Xqt: [tests] Require flake8 release 3.7.0+ [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) [15:01:40] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @amir1 & @Thiemo_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:17:51] (03CR) 10Dalba: [C: 03+2] [tests] Require flake8 release 3.7.0+ [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) (owner: 10Xqt) [15:24:07] (03CR) 10Dalba: [C: 04-2] "I missed to review the changes in" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) (owner: 10Xqt) [15:29:28] 10Pywikibot, 10Documentation, 10Pywikibot-Documentation, 10good first bug: document pywikibot.error and pywikibot.exception - https://phabricator.wikimedia.org/T85271 (10Urstrulykkr) Hi @Dvorapa Thanks for your patience. Could you please look over my commit ? [15:51:40] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @amir1 & @Thiemo_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [16:02:31] 10Pywikibot, 10Documentation, 10Pywikibot-Documentation, 10good first bug: document pywikibot.error and pywikibot.exception - https://phabricator.wikimedia.org/T85271 (10Dvorapa) There are multiple errors you should fix. I and @valhallasw gave you ideas what to fix there. Also there are errors reported by... [16:16:29] (03CR) 10Xqt: "> I missed to review the changes in" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487118 (https://phabricator.wikimedia.org/T214962) (owner: 10Xqt) [17:05:44] I will let you know when I see jonathan around here [17:05:44] @notify jonathan [17:58:40] (03Abandoned) 10Yaron Koren: Add quoting of DB index names [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476139 (owner: 10Yaron Koren) [18:10:09] 10Google-Code-in-2018, 10Developer-Advocacy (Jan-Mar 2019): Decide which GCI 2018 mentor/admin to attend GCI Grand Prize winners weekend June 10-13, 2019 - https://phabricator.wikimedia.org/T212827 (10Gopavasanth) I'm Interested and the trip dates are also flexible to me. [18:57:03] 10Google-Code-in-2018, 10MediaWiki-extensions-General, 10translatewiki.net, 10I18n, and 3 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10MarcoAurelio) [19:44:40] 10Pywikibot: Page.touch() removes whitespace at the end of a page - https://phabricator.wikimedia.org/T214806 (10abian) [19:45:03] 10Pywikibot: Page.touch() removes whitespace at the end of a page - https://phabricator.wikimedia.org/T214806 (10abian) >>! In T214806#4913619, @Dvorapa wrote: > The spaces at the end of the page should never exist and if they do exist, this is a correct behavior. This is not produced by Pywikibot, but by MediaW... [19:49:30] 10Pywikibot: Page.touch() removes whitespace at the end of a page - https://phabricator.wikimedia.org/T214806 (10Dvorapa) >>! In T214806#4918852, @abian wrote: >>>! In T214806#4913619, @Dvorapa wrote: >> The spaces at the end of the page should never exist and if they do exist, this is a correct behavior. This i... [19:51:37] mahveotm_: Per this patch, https://gerrit.wikimedia.org/r/c/pywikibot/core/+/487083 [19:51:48] Those are all false positives, so I'll suggest you abandon the patch [19:52:24] 10Pywikibot: Page.touch() removes whitespace at the end of a page - https://phabricator.wikimedia.org/T214806 (10abian) >>! In T214806#4918856, @Dvorapa wrote: > But that would prevent to touch the page containing whitespace at the end at all. There is no other way to touch the page without removing the whitespa... [19:53:03] 10Pywikibot: Page.touch() removes whitespace at the end of a page - https://phabricator.wikimedia.org/T214806 (10Dvorapa) Or you can avoid touching those pages using `-grep:"\S$"` parameter [19:54:52] 10Pywikibot: Page.touch() removes whitespace at the end of a page - https://phabricator.wikimedia.org/T214806 (10Dvorapa) p:05Normal→03Lowest [19:59:26] 10Pywikibot, 10Pywikibot-Other-scripts, 10Pywikibot-pagegenerators.py, 10good first bug: Add -unusedcategories param - https://phabricator.wikimedia.org/T214923 (10Mpaa) I do not agree. There is a patch proposing to introduce -querypage, which will be valid for all special pages, in order to avoid prolifer... [20:05:59] 10Pywikibot: Page.touch() removes whitespace at the end of a page - https://phabricator.wikimedia.org/T214806 (10Dreamy_Jazz) 05Open→03Resolved [20:07:22] 10Pywikibot: Page.touch() removes whitespace at the end of a page - https://phabricator.wikimedia.org/T214806 (10Dvorapa) 05Resolved→03Invalid (no code change was done in here) [20:08:54] 10Pywikibot, 10ProofreadPage, 10Pywikibot-Other-scripts: touch.py makes empty edits on ProofreadPage pages - https://phabricator.wikimedia.org/T199042 (10Dvorapa) >>! In T199042#4490983, @Tacsipacsi wrote: > There are several cases where touch.py actually edits the page, which sounds like it’s way easier to... [20:13:31] 10Pywikibot, 10ProofreadPage, 10Pywikibot-Other-scripts: touch.py makes empty edits on ProofreadPage pages - https://phabricator.wikimedia.org/T199042 (10Dvorapa) >>! In T199042#4406112, @Ankry wrote: >>>! In T199042#4406095, @Dvorapa wrote: >> This is weird, the change has removed 122 bytes, but the diff is... [20:21:00] 10Pywikibot, 10MediaWiki-General-or-Unknown: touch.py made changes in page, without flag in RecentCHanges - https://phabricator.wikimedia.org/T112480 (10Dvorapa) From Pywikibot side there is nothing we can do about as the diff is zero. It seems like a server-side behavior [20:22:18] 10Pywikibot, 10MediaWiki-General-or-Unknown: touch.py made changes in page, without flag in RecentCHanges - https://phabricator.wikimedia.org/T112480 (10Dvorapa) p:05Low→03Triage [20:24:52] (03CR) 10Dvorapa: "Probably we could mark all the Special pages generators as deprecated in the follow-up patch after this! :)" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/485364 (https://phabricator.wikimedia.org/T214234) (owner: 10Mpaa) [20:25:44] 10Pywikibot, 10Pywikibot-Other-scripts, 10Pywikibot-pagegenerators.py, 10good first bug: Add -unusedcategories param - https://phabricator.wikimedia.org/T214923 (10Dvorapa) Probably we can close this as a duplicate of that one? [20:36:22] 10Pywikibot: inline interwiki links shouldn't be treated as such - https://phabricator.wikimedia.org/T57298 (10Dvorapa) [20:36:42] 10Pywikibot, 10Pywikibot-interwiki.py: inline interwiki links shouldn't be treated as such - https://phabricator.wikimedia.org/T57298 (10Dvorapa) [20:37:48] 10Pywikibot, 10Pywikibot-cosmetic-changes.py, 10Pywikibot-interwiki.py: inline interwiki links shouldn't be treated as such - https://phabricator.wikimedia.org/T57298 (10Dvorapa) [20:38:39] 10Pywikibot, 10Pywikibot-cosmetic-changes.py, 10Pywikibot-interwiki.py: inline interwiki links shouldn't be treated as such - https://phabricator.wikimedia.org/T57298 (10Dvorapa) [20:43:22] 10Pywikibot: desambiguation category changes in catalan wikipedia - https://phabricator.wikimedia.org/T56534 (10Dvorapa) [20:43:24] 10Pywikibot: desambiguation category changes in catalan wikipedia - https://phabricator.wikimedia.org/T56536 (10Dvorapa) [20:44:24] 10Pywikibot: Don't replace LF with CR LF in xmlreader - https://phabricator.wikimedia.org/T56558 (10Dvorapa) [20:46:05] 10Pywikibot: Upload protection - https://phabricator.wikimedia.org/T57052 (10Dvorapa) [20:46:07] 10Pywikibot: Add upload protection to protect.py - https://phabricator.wikimedia.org/T57057 (10Dvorapa) [20:47:37] 10Pywikibot: "pywikibot.exceptions.Error: API write action attempted without userinfo" despite being logged in - https://phabricator.wikimedia.org/T214987 (10Mike_Peel) [20:49:51] 10Pywikibot, 10StructuredDataOnCommons: "pywikibot.exceptions.Error: API write action attempted without userinfo" despite being logged in - https://phabricator.wikimedia.org/T214987 (10Mike_Peel) [21:09:02] africanhope: Around? [21:09:26] paladox: Thanks for that awesome plugin, in fact, let me reply on the mailing list right now! [21:09:35] your welcome :) [21:16:04] paladox: Sent! [21:16:12] thanks :) [21:20:18] Sure :), you're welcome! [21:26:46] 2.16 on the day paladox? [21:26:56] s/day/way [21:27:06] I think so. [21:27:17] Hmm... mind blowing UI [21:27:40] I haven't a date yet. But hopefully will find out soon :) [21:27:42] I've had issues changing my name on PollyGerrit [21:27:47] Cool [21:28:03] But 2.16 will have that support I guess, you once told me [21:29:43] Support to change your name? [21:30:22] Due to us using LDAP, i think gerrit locks changing your name. So it has to be manually done on wikitech/ldap. [21:30:40] Okay [21:35:07] (03CR) 10Mpaa: "> Patch Set 3:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/485364 (https://phabricator.wikimedia.org/T214234) (owner: 10Mpaa) [21:41:44] xSavitar: hey mate [21:42:26] xSavitar: wassup? I had taken a break [22:15:59] 10Pywikibot, 10Pywikibot-Other-scripts, 10Pywikibot-pagegenerators.py, 10good first bug: Add -unusedcategories param - https://phabricator.wikimedia.org/T214923 (10Zoranzoki21) >>! In T214923#4918878, @Mpaa wrote: > I do not agree. > There is a patch proposing to introduce -querypage, which will be valid f... [22:24:48] (03Abandoned) 10Mahveotm: [cleanup] removed unused variabe in pywikibot [pywikibot/core] - 10https://gerrit.wikimedia.org/r/487083 (https://phabricator.wikimedia.org/T203395) (owner: 10Mahveotm) [22:27:58] xSavitar, done. Thanks! [22:28:13] Hi africanhope! [22:29:01] mahveotm_ hey [22:35:38] 10Pywikibot: Deprecate possibly unused code reported in 60% confidence by Vulture - https://phabricator.wikimedia.org/T214993 (10Dvorapa) [22:36:57] 10Pywikibot, 10Patch-For-Review, 10good first bug: (Re)move unused code reported by Vulture - https://phabricator.wikimedia.org/T203395 (10Dvorapa) There are some others in {T214993}, but one have to be careful and know, what he is doing in 60% confidence... [22:37:13] 10Pywikibot: Deprecate possibly unused code reported in 60% confidence by Vulture - https://phabricator.wikimedia.org/T214993 (10Dvorapa)