[00:46:22] 10Pywikibot, 10Pywikibot-archivebot.py, 10Regression: archivebot resets the numbering to 1 even for non-year archives - https://phabricator.wikimedia.org/T217107 (10Dvorapa) @matej_suchanek It also edits the 1st archive if it exists, see https://cs.wikipedia.org/w/index.php?title=Wikipedie:N%C3%A1st%C4%9Bnka... [00:50:55] (03CR) 10Dvorapa: "Per T217107 and T218607 this should be reverted" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/488544 (https://phabricator.wikimedia.org/T215247) (owner: 10Matěj Suchánek) [00:59:04] 10Africa-Wikimedia-Developers, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2019): Develop a tool for use by event organizers to track developer activity - https://phabricator.wikimedia.org/T202233 (10Tuxology) @Ssomansh Great questions! Me and @srishakatux brainstormed a bit about this. > I had... [01:06:25] (03CR) 10Gergő Tisza: "Maybe worth proposing the naming conventions as a mustache coding convention? Templates do not have type annotations so this kind of pseud" [skins/Vector] - 10https://gerrit.wikimedia.org/r/493093 (https://phabricator.wikimedia.org/T217172) (owner: 10Jdlrobson) [01:50:25] 10Africa-Wikimedia-Developers, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2019): Develop a tool for use by event organizers to track developer activity - https://phabricator.wikimedia.org/T202233 (10Ssomansh) @Tuxology Thanks for replying. I have sent you and @srishakatux the project details an... [05:23:04] (03PS1) 10Xqt: Revert "archivebot.py: Reset counter when timestamp fragment changes" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497454 [05:23:52] (03PS2) 10Xqt: Revert "archivebot.py: Reset counter when timestamp fragment changes" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497454 [05:25:10] 10Pywikibot, 10Pywikibot-archivebot.py, 10Patch-For-Review: archivebot should reset counter when changing a year - https://phabricator.wikimedia.org/T215247 (10Xqt) 05Resolved→03Open Per T217107 and T218607 [05:27:05] (03PS2) 10Mill: vbaaaaaaaaaaaa [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497355 (owner: 10Zoranzoki21) [05:30:21] (03PS2) 10Mill: 2daaaaaaaaaaaa [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497291 (owner: 10Xqt) [05:32:46] (03PS2) 10Mill: jfaaaaaaaaaaaa [pywikibot/core] - 10https://gerrit.wikimedia.org/r/495172 (owner: 10Xqt) [05:32:59] (03PS4) 10Mill: !faaaaaaaaaaaa [pywikibot/core] - 10https://gerrit.wikimedia.org/r/496758 (owner: 10Dvorapa) [05:33:48] (03PS4) 10Mill: $gaaaaaaaaaaaa [pywikibot/i18n] - 10https://gerrit.wikimedia.org/r/496760 (owner: 10Dvorapa) [05:42:58] (03PS7) 10Mill: zoaaaaaaaaaaaa [pywikibot/core] - 10https://gerrit.wikimedia.org/r/481338 (owner: 10Xqt) [05:43:11] (03PS3) 10Mill: a$aaaaaaaaaaaa [pywikibot/core] - 10https://gerrit.wikimedia.org/r/495740 (owner: 10Hashar) [05:54:31] (03PS8) 10Mill: epaaaaaaaaaaaa [pywikibot/core] - 10https://gerrit.wikimedia.org/r/491884 (owner: 10Dvorapa) [05:54:38] (03PS7) 10Mill: kpaaaaaaaaaaaa [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/490402 (owner: 10Gopavasanth) [05:56:53] (03PS3) 10Mill: vqaaaaaaaaaaaa [pywikibot/core] - 10https://gerrit.wikimedia.org/r/491946 (owner: 10Xqt) [05:56:56] (03PS4) 10Mill: uqaaaaaaaaaaaa [pywikibot/core] - 10https://gerrit.wikimedia.org/r/461118 (owner: 10Xqt) [05:57:07] (03PS2) 10Mill: 1qaaaaaaaaaaaa [pywikibot/core] - 10https://gerrit.wikimedia.org/r/491886 (owner: 10Dvorapa) [06:07:06] (03PS6) 10Mill: qgbaaaaaaaaaaa [pywikibot/core] - 10https://gerrit.wikimedia.org/r/404435 (owner: 10Xqt) [06:07:13] (03PS6) 10Mill: vgbaaaaaaaaaaa [pywikibot/core] - 10https://gerrit.wikimedia.org/r/463061 (owner: 10Dalba) [06:08:46] (03PS21) 10Mill: 5jbaaaaaaaaaaa [pywikibot/core] - 10https://gerrit.wikimedia.org/r/428143 (owner: 10Xqt) [06:09:45] (03CR) 10jerkins-bot: [V: 04-1] 1eaaaaaaaaaaaa [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497123 (owner: 10Xqt) [10:54:40] hello !, i tried accessing the gerrit page but it seem down and not loading up [10:54:46] https://gerrit.wikimedia.org [11:05:10] jonathan2: Hey! [11:05:12] Gerrit is down and it's a known issue [11:05:14] It's been worked on as we speak currently [11:05:16] So it's been addressed and try to be a little patient :) [11:05:25] Collins: Hey! :) [11:05:27] m-alpha: :) [11:05:58] okey [11:06:05] hi xSavitar [11:06:11] Hey @all [11:06:22] You've been missing :) [11:06:22] i was kinda curious thinking the problem was from my end [11:06:58] jonathan2: No, it's not you [11:07:04] m-alpha: I'm always here! [11:07:07] yeah, i have @ m-alpha....my laptop crashed, just fixed it [11:07:32] ohh ! [11:07:43] great we are all here [11:07:45] okey @ xSavitar...thank you [11:08:14] please need help getting started [11:08:27] xSavitar: hi all am around [11:08:44] i will say the documentation is so unclear [11:09:46] @m-alpha, i thought so too, but it became clearer when i read between lines and followed all links for more info [11:10:15] xSavitar and others are here to help us all out🤗 [11:11:55] :) [11:13:09] m-alpha: What exactly do you need help about? [11:13:43] The truth is, most of us don't READ to understand, we READ to execute [11:13:51] I'm a self testimony, I know what I'm saying [11:14:10] It took me a while to be able to read tech documentation, not just to execute but understand. [11:14:36] By understanding, you can find out flaws in the docs and update to make it work and the truth is, if you don't understand, execution will be hard and almost unsuccessful [11:14:50] m-alpha: So, what exactly is the issue, I'm here to trash it out [11:15:28] Yes that is an issue am currently retracing my steps because of the same issue. [11:15:39] Collins: Good! :) [11:15:43] xSavitar : i want to work on this https://phabricator.wikimedia.org/T210771 [11:16:51] xSavitar : :D you are right just that we need the mvp running [11:17:09] mvp? [11:17:21] Also, that project poses a problem for a repo that was deleted [11:17:41] Tgr proposes two ways to solve the project [11:17:46] 😢🤦🏾‍♂️ [11:17:59] 1. Restore the repository which I think is not possible for you to do as you're not part of the organization yet [11:18:21] 2. You can instead update the repo URL, that is doable [11:18:53] You just need to find the repo URL that is currently available and then update it here: https://www.npmjs.com/package/passport-mediawiki-oauth [11:19:24] So by that, you can read how to update repo URL on NPMJS website and work on it [11:19:33] Also, you'll need to find the current repo too [11:21:02] I'm thinking this could be the most recent repo: https://github.com/milimetric/passport-mediawiki-oauth [11:21:07] But try to double check on that m-alpha [11:22:33] m-alpha: Tgr is very friendly user that supports and holds other volunteers at high esteem. He's a very nice person, show interest on the task on phabricator and he'll give you a helping hand [11:22:55] I see that you're not subscribed to the task and have not showed interest yet. Please do that and you'll be surprised. [11:31:59] ok let me do that [11:39:53] Sure! [11:44:58] xSavitar : the inistruction "so either update the repo URL" [11:45:17] is it in the package.json file ? [11:45:55] btw why did you say i will be surprised :) ? [11:46:20] Before updating anything, you need to understand what happens when you run the `npm install ` command [11:46:38] Once you understand what happens when that command is run, you will know exactly where to update what [11:46:57] And for the surprised part, Tgr, will give you a lot of helping hand if you ask smart questions :) [11:51:09] m-alpha: Read this page: https://www.npmjs.com/package/passport-mediawiki-oauth [11:51:18] If something is not clear about the task, comment on Phabricator [11:51:22] Ask there! [11:51:51] ok because the link "url": "https://git.wikimedia.org/git/passport-mediawiki.git" is not valid [11:52:05] that is why i thought i will change that [12:24:47] m-alpha: Okay! [12:37:14] 10Pywikibot, 10Pywikibot-Other-scripts, 10Pywikibot-cosmetic-changes.py: checkimages.py hangs when putting a file page - https://phabricator.wikimedia.org/T191113 (10Xqt) 05Open→03Invalid Python 2.7.2 and 2.7.3 has been dropped [13:41:42] (03CR) 10Dvorapa: [C: 03+2] Revert "archivebot.py: Reset counter when timestamp fragment changes" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497454 (owner: 10Xqt) [13:44:35] (03Merged) 10jenkins-bot: Revert "archivebot.py: Reset counter when timestamp fragment changes" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497454 (owner: 10Xqt) [13:49:44] (03PS1) 10Xqt: [doc] Print a more explainable error messages_available [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497476 (https://phabricator.wikimedia.org/T217948) [13:51:24] 10Pywikibot, 10Pywikibot-i18n, 10Patch-For-Review: newitem.py -touch crashes on missing i18n - https://phabricator.wikimedia.org/T217948 (10Xqt) p:05Triage→03Lowest [13:51:58] 10Pywikibot, 10Pywikibot-archivebot.py: archivebot should reset counter when changing a year - https://phabricator.wikimedia.org/T215247 (10Xqt) [13:58:12] (03PS1) 10Xqt: [doc] Update CREDITS [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497480 [13:59:50] (03PS2) 10Xqt: [doc] Print a more explainable error messages [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497476 (https://phabricator.wikimedia.org/T217948) [14:36:30] (03PS5) 10D3r1ck01: [IMPR] contributors.json: Add user to contributor tracking file [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/495516 (https://phabricator.wikimedia.org/T202230) [15:11:18] whats the best mobile app for IRC that can keep me connected and notify me on any chat drop? [15:19:27] 10Pywikibot, 10Pywikibot-tests: site_tests.TestLogPages are failing for test_logpages and test_logpages_dump - https://phabricator.wikimedia.org/T217664 (10Xqt) a:03Xqt [15:31:16] (03PS1) 10Xqt: [bugfix] Set optional parameter namespace to None in site.logpages [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497519 (https://phabricator.wikimedia.org/T217664) [15:34:46] (03CR) 10jerkins-bot: [V: 04-1] [bugfix] Set optional parameter namespace to None in site.logpages [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497519 (https://phabricator.wikimedia.org/T217664) (owner: 10Xqt) [15:36:23] (03PS2) 10Xqt: [bugfix] Set optional parameter namespace to None in site.logpages [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497519 (https://phabricator.wikimedia.org/T217664) [15:47:22] (03PS1) 10D3r1ck01: [IMPR] Refactor code base to follow base practices [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497525 [15:50:26] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: site_tests.TestLogPages are failing for test_logpages and test_logpages_dump - https://phabricator.wikimedia.org/T217664 (10Xqt) [15:51:03] (03CR) 10D3r1ck01: [C: 04-1] "Hi Zoran, you are awesome! So the `contributors.json` file is for African, to track their contributions but hey, you being there is very n" (032 comments) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497355 (https://phabricator.wikimedia.org/T202230) (owner: 10Zoranzoki21) [15:52:06] 10Pywikibot, 10MediaWiki-extensions-FlaggedRevs, 10Outreach-Programs-Projects, 10User-Tgr: Implement support for Flagged Revisions in Pywikibot - https://phabricator.wikimedia.org/T57081 (10Xqt) [15:54:28] (03CR) 10D3r1ck01: [C: 04-1] "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497355 (https://phabricator.wikimedia.org/T202230) (owner: 10Zoranzoki21) [15:54:57] jonathan2: So Gerrit is back up :) [15:56:22] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: pytest 5.0 will no longer support Python 2.7 and 3.4 - https://phabricator.wikimedia.org/T215874 (10Xqt) [15:57:12] (03CR) 10jerkins-bot: [V: 04-1] Add Zoranzoki21 in contributors.json [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497355 (https://phabricator.wikimedia.org/T202230) (owner: 10Zoranzoki21) [15:58:41] (03PS2) 10D3r1ck01: [IMPR] Refactor code base to follow base practices [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497525 [15:58:45] 10Pywikibot, 10Pywikibot-archivebot.py: archivebot failing when archive counter starts with zero (0) - https://phabricator.wikimedia.org/T218607 (10matej_suchanek) Note that you may want to use correctly zero-padded counter `%(counter)03d`. Because `lang=python >>> str(int('034') + 1) '35' ` [15:58:54] (03CR) 10D3r1ck01: "@Samuel, can you throw an eye or two on this patch for review? Thanks!" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497525 (owner: 10D3r1ck01) [15:58:58] 10Pywikibot, 10Pywikibot-archivebot.py: archivebot should reset counter when changing a year - https://phabricator.wikimedia.org/T215247 (10matej_suchanek) a:05matej_suchanek→03None Some notes: >>! In T217107#4984900, @matej_suchanek wrote: > Perhaps we shouldn't attempt to reset counter if the archive pa... [15:59:02] africanhope: ^^ [15:59:06] https://gerrit.wikimedia.org/r/c/labs/tools/awmd-stats/+/497525 [16:00:34] xSavitar: roger that. I have a break in about an hour, I'll do it if it's not too urgent [16:00:54] No problem, thanks in advance :) [16:05:46] 10Pywikibot, 10Pywikibot-archivebot.py: archivebot failing when archive counter starts with zero (0) - https://phabricator.wikimedia.org/T218607 (10MarcoAurelio) >>! In T218607#5036693, @matej_suchanek wrote: > Note that you may want to use correctly zero-padded counter `%(counter)03d`. Because > `lang=python... [16:12:41] 10Pywikibot, 10Pywikibot-archivebot.py: archivebot failing when archive counter starts with zero (0) - https://phabricator.wikimedia.org/T218607 (10MarcoAurelio) However archivebot keeps removing the 0 from the counter parameter: https://en.wikiquote.org?diff=2563236 Would that be an issue? They want their arc... [16:16:22] 10Pywikibot, 10Pywikibot-archivebot.py: archivebot failing when archive counter starts with zero (0) - https://phabricator.wikimedia.org/T218607 (10matej_suchanek) That's expected, as I demonstrated in my comment. The counter is a number, its format `%03d` (integer, 3 characters, missing ones filled with zeros... [16:18:13] @xSavitar, thanks a bunch for the update... [16:18:22] 10Pywikibot, 10Pywikibot-archivebot.py: archivebot should reset counter when changing a year - https://phabricator.wikimedia.org/T215247 (10matej_suchanek) [16:18:24] 10Pywikibot, 10Pywikibot-archivebot.py, 10Regression: archivebot resets the numbering to 1 even for non-year archives - https://phabricator.wikimedia.org/T217107 (10matej_suchanek) [16:18:31] Sure, I didn't bring Gerrit back to life, WMF staffs did [16:18:44] I'm just passing some information here :) [16:18:47] But enjoy [16:19:02] Zppix: Hi sir! [16:19:07] It's been a while [16:22:27] (03CR) 10D3r1ck01: [C: 04-1] Add Zoranzoki21 in contributors.json (031 comment) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497355 (https://phabricator.wikimedia.org/T202230) (owner: 10Zoranzoki21) [16:23:28] (03PS3) 10D3r1ck01: [IMPR] Add Zoranzoki21 in contributors.json [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497355 (https://phabricator.wikimedia.org/T202230) (owner: 10Zoranzoki21) [16:25:15] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Add Zoranzoki21 in contributors.json [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497355 (https://phabricator.wikimedia.org/T202230) (owner: 10Zoranzoki21) [16:25:51] (03CR) 10Jeropbrendawm: [C: 03+1] [doc] Update CREDITS [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497480 (owner: 10Xqt) [16:28:22] (03CR) 10D3r1ck01: [C: 04-1] "See Iba8d0d14f1adef08195dc5bb7dfbcfd2d3148e35 for best practices, I've done some refactoring already. Thanks!" (037 comments) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [16:34:29] (03CR) 10D3r1ck01: "recheck" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497355 (https://phabricator.wikimedia.org/T202230) (owner: 10Zoranzoki21) [16:36:23] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Add Zoranzoki21 in contributors.json [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497355 (https://phabricator.wikimedia.org/T202230) (owner: 10Zoranzoki21) [16:42:29] (03PS1) 10Xqt: [tox] Remove externals folder from exclude list [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497549 [16:50:50] xSavitar: i try to get on everyday [16:51:17] (03CR) 10D3r1ck01: [C: 03+2] "Nice to see more Africans coming into the PWB projects, keep it up folks :)" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497480 (owner: 10Xqt) [16:51:24] Zppix: You're awesome :) [16:51:34] Thanks [16:51:52] xSavitar: development is pretty hard when gerrit is down though lol luckily it seems fine atm [16:52:04] :) [16:55:02] (03Merged) 10jenkins-bot: [doc] Update CREDITS [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497480 (owner: 10Xqt) [17:08:33] hello !! [17:09:57] pls whats the i should use for git clone [17:15:19] figured it out [17:32:39] (03PS5) 10Jeropbrendawm: [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) [17:37:20] (03CR) 10African Hope: "Great work overall, I flagged two minor things for consistency." (032 comments) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497525 (owner: 10D3r1ck01) [17:37:41] xSavitar: reviewed with 2 minor suggestions [17:40:10] (03PS6) 10Jeropbrendawm: [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) [17:45:58] (03CR) 10D3r1ck01: "What do you think, should I include it in this change or should I just make a separate patch?" (032 comments) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497525 (owner: 10D3r1ck01) [17:47:05] (03PS7) 10D3r1ck01: [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [17:47:10] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [17:52:30] (03PS8) 10D3r1ck01: [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [17:52:32] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [17:53:24] africanhope: Yeah, I'm wondering whether to just apply them or do it in another patch? [17:53:32] That patch seems too big already, what do you think? [17:53:36] Maybe a follow up will be good? [17:54:12] (03PS9) 10D3r1ck01: [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [17:56:03] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [18:03:19] (03PS10) 10D3r1ck01: [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [18:03:28] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [18:04:38] (03CR) 10D3r1ck01: "So this patch is fine, just that it's conflicting with the refactor patch, let me clean that up so africanhope can merge :)" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [18:07:27] (03PS1) 10Nikitrain: Improve docstrings to the Pywikibot library [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497580 (https://phabricator.wikimedia.org/T118423) [18:07:50] africanhope: Let me update the patch with your suggestion, I'll try not to break things [18:08:21] you'd probably need to tweak some templates files where monthID is used [18:09:00] :D stakes are high that something gets broken but hopefully, running tests would mitigate that [18:12:22] :D [18:12:50] (03PS3) 10D3r1ck01: [IMPR] Refactor code base to follow base practices [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497525 [18:13:49] africanhope: ^^ [18:13:51] You're up [18:14:03] A patch depends on this so we need it landed as soon as we can so we can review the other :) [18:15:55] (03CR) 10D3r1ck01: "> Great work overall, I flagged two minor things for consistency." [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497525 (owner: 10D3r1ck01) [19:23:33] (03PS1) 10Yaron Koren: Another Postgres fix for drilldown with Start/End Date [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/497588 [19:27:02] (03PS2) 10Yaron Koren: Another Postgres fix for drilldown with Start/End Date [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/497588 [19:34:40] (03CR) 10Xqt: "Thank you for your contribution." (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497580 (https://phabricator.wikimedia.org/T118423) (owner: 10Nikitrain) [19:37:37] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497580 (https://phabricator.wikimedia.org/T118423) (owner: 10Nikitrain) [19:38:21] 10Pywikibot, 10Pywikibot-archivebot.py: archivebot failing when archive counter starts with zero (0) - https://phabricator.wikimedia.org/T218607 (10Dvorapa) Okay, should we close this as invalid/resolved? [19:41:05] (03CR) 10jerkins-bot: [V: 04-1] Improve docstrings to the Pywikibot library [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497580 (https://phabricator.wikimedia.org/T118423) (owner: 10Nikitrain) [19:42:50] (03CR) 10Dvorapa: [C: 03+2] [tox] Remove externals folder from exclude list [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497549 (owner: 10Xqt) [19:45:51] (03Merged) 10jenkins-bot: [tox] Remove externals folder from exclude list [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497549 (owner: 10Xqt) [19:48:01] (03CR) 10Dvorapa: [bugfix] Set optional parameter namespace to None in site.logpages (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497519 (https://phabricator.wikimedia.org/T217664) (owner: 10Xqt) [19:52:48] (03CR) 10Dvorapa: [C: 03+2] [doc] Print a more explainable error messages [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497476 (https://phabricator.wikimedia.org/T217948) (owner: 10Xqt) [19:55:56] (03Merged) 10jenkins-bot: [doc] Print a more explainable error messages [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497476 (https://phabricator.wikimedia.org/T217948) (owner: 10Xqt) [20:31:44] 10Google-Code-in-2018, 10MediaWiki-extensions-General, 10translatewiki.net, 10I18n, and 3 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10Amire80) [20:50:13] (03CR) 10African Hope: [C: 03+2] [IMPR] Refactor code base to follow base practices [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497525 (owner: 10D3r1ck01) [20:51:26] (03Merged) 10jenkins-bot: [IMPR] Refactor code base to follow base practices [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497525 (owner: 10D3r1ck01) [20:53:07] (03PS11) 10D3r1ck01: [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [20:53:13] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [21:02:18] (03PS12) 10D3r1ck01: [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [21:11:04] (03CR) 10D3r1ck01: [C: 03+2] "Thanks for increasing the tools code coverage :)" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [21:11:13] africanhope: Thanks a lot! [21:11:23] Please when you have time, can you update prod? [21:11:35] I'll be leaving now to get some rest, enough work for today :) [21:11:45] Good night -dev-africa :) [21:11:55] xSavitar: gnite [21:12:18] (03Merged) 10jenkins-bot: [IMPR] Add unit tests for the awmd-stats tool [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/497311 (https://phabricator.wikimedia.org/T205450) (owner: 10Jeropbrendawm) [21:13:41] 10Africa-Wikimedia-Developers, 10Google-Code-in-2018: [Recurring] Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T205450 (10D3r1ck01) [21:20:47] 10Africa-Wikimedia-Developers, 10Google-Code-in-2018: [Recurring] Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T205450 (10D3r1ck01) As of today ` collected 23 items tests/test_app.py ........... [21:45:10] 10Africa-Wikimedia-Developers, 10ArticleFeedbackv5, 10I18n, 10good first bug: Undefined i18n message in aftv5: articleFeedbackv5-view-activity-error - https://phabricator.wikimedia.org/T154883 (10ashley) The "nonexistent message" was introduced in 9ac9a637792e97d903125074b683272fdd489274 in February 2012,... [21:55:55] (03PS1) 10813gan: pywikibot: Add support for property creation [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497646 (https://phabricator.wikimedia.org/T160402) [21:55:58] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497646 (https://phabricator.wikimedia.org/T160402) (owner: 10813gan) [23:56:47] (03CR) 10Yaron Koren: [C: 03+2] Another Postgres fix for drilldown with Start/End Date [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/497588 (owner: 10Yaron Koren) [23:59:43] (03CR) 10Xqt: "Thanks for your contribution" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497646 (https://phabricator.wikimedia.org/T160402) (owner: 10813gan) [23:59:58] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/497646 (https://phabricator.wikimedia.org/T160402) (owner: 10813gan)