[00:28:30] <xSavitar>	 paladox: How does the circular dep work?
[00:28:35] <xSavitar>	 Can you just brief me?
[00:28:43] <xSavitar>	 On does it display on zuul?
[00:29:50] <paladox>	 you add "Depends-On: <change-number>"
[00:30:21] <xSavitar>	 Yup
[00:30:23] <xSavitar>	 I've done that
[00:30:29] <xSavitar>	 Let me share with you the patches
[00:30:42] <xSavitar>	 I was asking how it shows on the Zuul interface
[00:30:50] <xSavitar>	 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/504589
[00:30:55] <xSavitar>	 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Thanks/+/504818
[00:31:04] <xSavitar>	 Those two are CD
[00:31:08] <xSavitar>	 paladox: ^^
[00:31:59] <paladox>	 https://integration.wikimedia.org/zuul/
[00:32:13] <paladox>	 it showed thanks as requiring the echo change
[00:33:46] <xSavitar>	 Okay, saw that and does it do the other way round?
[00:33:54] <xSavitar>	 As it didn't show the other way round for Echo
[00:34:11] <xSavitar>	 Okay, like now, I want to submit the two again
[00:34:16] <xSavitar>	 Watch the zuul interface
[00:35:08] <xSavitar>	 01:34 (wikibugs) (PS25) D3r1ck01: Remove usage of deprecated Revision class in Echo [extensions/Echo] - https://gerrit.wikimedia.org/r/504589 (https://phabricator.wikimedia.org/T221163)
[00:35:13] <xSavitar>	 paladox: ^^
[00:35:18] <xSavitar>	 But nothing on Zuul
[00:35:54] <paladox>	 Nope, it should only run it one way
[00:36:04] <paladox>	 though see if putting Bug: under Depends-On.
[00:36:09] <paladox>	 helps
[00:36:49] <xSavitar>	 Not sure :(
[00:36:56] <xSavitar>	 I'll do one way, then do the other way :D
[00:37:01] <xSavitar>	 Or maybe one way should work
[00:37:09] <paladox>	 heh
[00:37:27] <xSavitar>	 I badly need the CD aspect but anyway
[08:54:33] <wikibugs>	 10Pywikibot: Change subst method on replace.py - https://phabricator.wikimedia.org/T221344 (10Hercule)
[09:27:59] <wikibugs>	 10Pywikibot: Change subst method on replace.py - https://phabricator.wikimedia.org/T221344 (10Dvorapa) See also T4700
[09:28:41] <wikibugs>	 10Pywikibot: Change subst method on template.py - https://phabricator.wikimedia.org/T221344 (10Dvorapa)
[10:59:34] <wikibugs>	 (03CR) 10D3r1ck01: "@AfricanHope, should I have another look at this?" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/503421 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[11:18:10] <wikibugs>	 (03PS1) 10D3r1ck01: logging: Replace use of deprecated Linker::link() with LinkRenderer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/504858
[11:19:45] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] logging: Replace use of deprecated Linker::link() with LinkRenderer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/504858 (owner: 10D3r1ck01)
[11:20:21] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] logging: Replace use of deprecated Linker::link() with LinkRenderer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/504858 (owner: 10D3r1ck01)
[11:20:48] <wikibugs>	 (03PS2) 10D3r1ck01: logging: Replace use of deprecated Linker::link() with LinkRenderer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/504858
[11:29:53] <wikibugs>	 (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/504858 (owner: 10D3r1ck01)
[11:41:58] <wikibugs>	 10Pywikibot: Change subst method on template.py - https://phabricator.wikimedia.org/T221344 (10Xqt) We either could have a `-safesubst` option for this or a `-subst:safe` which is `-subst` with `"safe"` value. I prefer the last one, this enables to add a recursive subst method-like `-subst:recursive`: https://en...
[11:47:19] <wikibugs>	 (03CR) 10African Hope: "> @AfricanHope, should I have another look at this?" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/503421 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[11:59:03] <wikibugs>	 (03PS1) 10D3r1ck01: SGHooks: Handle some possible exceptions that could be thrown [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/504864
[11:59:45] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] SGHooks: Handle some possible exceptions that could be thrown [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/504864 (owner: 10D3r1ck01)
[12:01:39] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] SGHooks: Handle some possible exceptions that could be thrown [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/504864 (owner: 10D3r1ck01)
[12:02:35] <wikibugs>	 (03PS2) 10D3r1ck01: SGHooks: Handle some possible exceptions that could be thrown [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/504864
[12:05:24] <wikibugs>	 (03CR) 10D3r1ck01: "Tested and it works! Thanks!" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/503421 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[12:05:26] <wikibugs>	 (03CR) 10D3r1ck01: [C: 03+2] [IMPR] Add support for json to endpoint /month-rank/<month>/<format> [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/503421 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[12:06:20] <wikibugs>	 (03Merged) 10jenkins-bot: [IMPR] Add support for json to endpoint /month-rank/<month>/<format> [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/503421 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[12:08:23] <wikibugs>	 10Africa-Wikimedia-Developers, 10Developer-Advocacy: Africa Wikimedia Developers Leader Board Monthly Statistics for the year 2019 - https://phabricator.wikimedia.org/T213581 (10D3r1ck01)
[12:08:53] <wikibugs>	 (03CR) 10D3r1ck01: "This change is ready for review." [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/504864 (owner: 10D3r1ck01)
[12:09:02] <africanhope>	 xSavitar: hey
[12:09:32] <africanhope>	 just want to double check with you that the readme in awmd-stats needs some update
[12:10:25] <africanhope>	 xSavitar: the steps for quickstarting the tool kind have changed
[12:13:59] <africanhope>	 xSavitar: please discard my previous comments, I did a pull before jenkins merged the latest commit so I had not seen the changes
[12:41:09] <xSavitar>	 africanhope: Yup. I updated it.
[12:41:11] <xSavitar>	 Sometime ago :)
[12:41:13] <xSavitar>	 Maybe it needs more updates, but the key ones have been touched
[12:44:15] <wikibugs>	 (03CR) 10D3r1ck01: [C: 03+2] SGHooks: Handle some possible exceptions that could be thrown [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/504864 (owner: 10D3r1ck01)
[12:48:16] <wikibugs>	 (03Merged) 10jenkins-bot: SGHooks: Handle some possible exceptions that could be thrown [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/504864 (owner: 10D3r1ck01)
[12:50:00] <wikibugs>	 (03CR) 10jenkins-bot: SGHooks: Handle some possible exceptions that could be thrown [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/504864 (owner: 10D3r1ck01)
[12:54:55] <wikibugs>	 (03PS1) 10African Hope: [FIX] Correct content-type and charset for endpoint /month-rank/<month>/<format> [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504871 (https://phabricator.wikimedia.org/T213581)
[12:57:11] <xSavitar>	 africanhope: #lhf :)
[13:03:02] <africanhope>	 xSavitar: #lhf, that's the spirit :)
[13:03:20] <africanhope>	 paulwiki: hey
[13:03:45] <xSavitar>	 africanhope: It keeps the clock ticking :D
[13:04:07] <paulwiki>	 Hello 
[13:12:31] <paulwiki>	 africanhope, With the link : "git clone https://github.com/wikimedia/labs-tools-awmd-stats", I am finished to clone the repo git of application awmd
[13:13:27] <paulwiki>	 africanhope, now, what is next step ?
[13:15:16] <africanhope>	 xSavitar, paul ended up cloning the github repo cause he couldn't clode the Gerrit one, due to him being able to create a gerrit account for now
[13:15:42] <africanhope>	 paulwiki: try to follow the steps detailed in the README.MD file
[13:16:37] <paulwiki>	 africanhope, Ok, I am understood
[13:17:08] <africanhope>	 paulwiki: try it and let me know or ping xSavitar :P
[13:17:10] <xSavitar>	 Okay
[13:17:22] <xSavitar>	 Paul, hold africanhope for anything on that tool
[13:17:33] <xSavitar>	 I usually do that as well, he's my mentor :)
[13:18:01] <paulwiki>	 Ok
[13:18:33] <xSavitar>	 \o/
[13:47:04] <wikibugs>	 10Pywikibot: Change subst method on template.py - https://phabricator.wikimedia.org/T221344 (10Dvorapa) (BTW there is a workaround of using replace.py like this: `pwb.py replace "<noinclude" "<noinclud{{subst:#if: always | e }}" "\{\{[Oo]ldtemplate" "{{subst:newtemplate"` - substituting noinclude or its part as...
[13:58:19] <xSavitar>	 africanhope: I'll be reviewing your most recent patch now
[13:58:28] <xSavitar>	 When I'm done, can you update on TF?
[14:00:47] <africanh_>	 power failure, gosh
[14:01:04] <xSavitar>	 :(
[14:01:10] <xSavitar>	 I see a regression in your patch
[14:04:29] <wikibugs>	 (03CR) 10D3r1ck01: [C: 04-1] "Introduced in Iedfd7d31600eec0852a0, the wiki format shows only the first entry and no more. It should show all. A follow up fix would be " [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504871 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[14:09:14] <wikibugs>	 (03PS1) 10African Hope: [IMP] Test the /month-rank/<month>/json route [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581)
[14:15:46] <xSavitar>	 africanhope: Two patches are up right now, do you want me to look at both or is the previous one to be discarded?
[14:16:23] <africanhope>	 you can discard the previous one an look at the latest since the branch derived from the previous patch
[14:19:48] <xSavitar>	 africanhope: I think you can abandon it and leave an abandon message like so "Already covered by <Change-Id>"
[14:20:02] <xSavitar>	 Then I can review the latest, thanks.
[14:37:15] <africanhope>	 xSavitar: thanks to you 
[14:39:39] <wikibugs>	 (03Abandoned) 10African Hope: [FIX] Correct content-type and charset for endpoint /month-rank/<month>/<format> [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504871 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[14:52:03] <wikibugs>	 10Pywikibot, 10Pywikibot-Other-scripts, 10good first bug: Change subst method on template.py - https://phabricator.wikimedia.org/T221344 (10Xqt) p:05Triage→03Low
[14:54:24] <wikibugs>	 (03CR) 10D3r1ck01: [C: 04-1] "Look good but some more improvements can be done." (033 comments) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[14:58:52] <wikibugs>	 (03CR) 10Mz83ude: "> Alright. What about getContentLanguage() - can you get that check" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/502798 (owner: 10Ankita Mandal)
[15:09:22] <wikibugs>	 (03CR) 10African Hope: [IMP] Test the /month-rank/<month>/json route (033 comments) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[15:09:38] <wikibugs>	 (03PS2) 10African Hope: [IMPR] Test the /month-rank/<month>/json route [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581)
[15:10:21] <wikibugs>	 (03PS1) 10Ankita Mandal: Changes in CargoMySQLsearch.php to supprt all MW versions. Added appropriate spacing and comments. Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504893
[15:12:12] <wikibugs>	 (03CR) 10Ankita Mandal: "> Alright. What about getContentLanguage() - can you get that check" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/502798 (owner: 10Ankita Mandal)
[15:20:21] <wikibugs>	 (03PS1) 10Ankita Mandal: Changes in CargoMySQLsearch.php to support all MW versions. Added appropriate spacing and comments. Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900
[15:22:19] <wikibugs>	 (03CR) 10Ankita Mandal: "@Yaron Koren- This is the final patch with all the function calls tested." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal)
[15:23:51] <wikibugs>	 (03CR) 10Reedy: "Please learn how to amend gerrit changesets, you don't need to create a new one every time. It makes it harder to review changes to the sa" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal)
[15:28:47] <wikibugs>	 (03CR) 10D3r1ck01: [C: 04-1] [IMPR] Test the /month-rank/<month>/json route (031 comment) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[15:35:20] <xSavitar>	 africanhope: Do you think the suggested approach will help? Or do the trick?
[15:35:36] <xSavitar>	 Something doesn't feel right about the 2 if's
[15:36:48] <africanhope>	 lemme take a closer look
[15:40:47] <wikibugs>	 (03CR) 10Ankita Mandal: "> Please learn how to amend gerrit changesets, you don't need to" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal)
[15:41:48] <wikibugs>	 (03CR) 10African Hope: [IMPR] Test the /month-rank/<month>/json route (031 comment) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[15:50:26] <africanhope>	 xSavitar: I reorganized as you suggested and all tests passed
[15:50:46] <wikibugs>	 (03PS3) 10African Hope: [IMPR] Test the /month-rank/<month>/json route [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581)
[15:51:18] <xSavitar>	 Tested visually and it works as expected?
[15:51:44] <africanhope>	 indeed
[15:52:27] <xSavitar>	 Nice!
[15:52:33] <xSavitar>	 I'll do another round of review and land it
[15:52:38] <xSavitar>	 if all is fine :)
[15:55:05] <xSavitar>	 africanhope: What do you think about our new Flask CLI and killing of Flask-Script?
[15:55:14] <xSavitar>	 aka `flask run`
[15:55:31] <wikibugs>	 (03CR) 10D3r1ck01: [C: 03+2] "Thanks!" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[15:55:49] <wikibugs>	 (03CR) 10D3r1ck01: [C: 03+2] "I've also confirmed that the regression has been fixed." [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[15:56:53] <wikibugs>	 (03CR) 10D3r1ck01: "This needs a manual rebase! It was made on the previous commit that is now abandoned." [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[15:57:09] <africanhope>	 The change is welcomed, as I've always used flask CLI in other projects, I feel it's more natural, as compared to Flask-script
[15:57:20] <xSavitar>	 africanhope: That patch needs a rebase, I've tested it already. I hit the +2 before realizing that it's in a relation chain
[15:57:37] <africanhope>	 xSavitar: ouch
[15:57:53] <xSavitar>	 A manual rebase and that's it
[16:12:18] <wikibugs>	 (03PS4) 10African Hope: [IMPR] Test the /month-rank/<month>/json route [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581)
[16:12:47] <africanhope>	 rebased 
[16:15:56] <wikibugs>	 (03CR) 10D3r1ck01: [C: 03+2] [IMPR] Test the /month-rank/<month>/json route [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[16:16:28] <wikibugs>	 (03CR) 10D3r1ck01: "Relation chain still there :(" [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[16:16:37] <xSavitar>	 africanhope: relation chain still there
[16:16:41] <xSavitar>	 You need to break it
[17:18:05] <wikibugs>	 (03CR) 10Yaron Koren: "Fantastic! The only small problem I see is that there need to be spaces within all parentheses - like ( this ), not (this). The patch can'" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal)
[17:18:53] <wikibugs>	 (03PS5) 10African Hope: [IMPR] Test the /month-rank/<month>/json route [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581)
[17:19:19] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Test the /month-rank/<month>/json route [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[17:44:37] <wikibugs>	 (03PS6) 10African Hope: [IMPR] Test the /month-rank/<month>/json route [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581)
[17:55:51] <africanhope>	 xSavitar: Jenkins seems to be happy, so am I
[19:15:14] <xSavitar>	 africanhope: Okay
[20:03:19] <wikibugs>	 (03CR) 10D3r1ck01: "nit :)" (031 comment) [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[20:03:32] <xSavitar>	 africanhope: One nit and I'll land that patch, sorry
[20:05:42] <africanhope>	 xSavitar:  sure
[20:06:30] <xSavitar>	 thanks
[20:07:00] <wikibugs>	 (03PS7) 10African Hope: [IMPR] Test the /month-rank/<month>/json route [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581)
[20:12:45] <wikibugs>	 (03CR) 10D3r1ck01: [C: 03+2] [IMPR] Test the /month-rank/<month>/json route [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[20:13:31] <wikibugs>	 (03Merged) 10jenkins-bot: [IMPR] Test the /month-rank/<month>/json route [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/504882 (https://phabricator.wikimedia.org/T213581) (owner: 10African Hope)
[20:16:03] <wikibugs>	 10Africa-Wikimedia-Developers, 10Developer-Advocacy: Africa Wikimedia Developers Leader Board Monthly Statistics for the year 2019 - https://phabricator.wikimedia.org/T213581 (10D3r1ck01)
[20:24:51] <africanhope>	 xSavitar: thanks mate
[20:25:01] <xSavitar>	 Oh common, thank you
[20:25:06] <africanhope>	 xSavitar: haha
[20:25:41] <xSavitar>	 africanhope: You can deploy
[20:25:46] <africanhope>	 sure
[20:25:48] <xSavitar>	 We need those changes :)
[20:25:49] <xSavitar>	 thanks
[20:25:56] <xSavitar>	 Signal me when everything is online so I can test live
[20:29:29] <africanhope>	 prod was restarted and is live
[20:29:40] <africanhope>	 xSavitar: ^^
[20:30:38] <xSavitar>	 africanhope: Cool
[20:30:46] <xSavitar>	 You see that #lhf are the best right? :D
[20:33:23] <africanhope>	 xSavitar: haha I'd say a right balance of #lhf and challenging bugs make a good soup :D
[20:33:35] <xSavitar>	 :D