[09:46:50] (03PS1) 10D3r1ck01: [IMPR] DRY when preparing chart data to be displayed on home page [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/507757 [09:47:50] (03PS2) 10D3r1ck01: [IMPR] DRY when preparing chart data to be displayed on home page [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/507757 [09:53:35] (03PS3) 10D3r1ck01: [IMPR] DRY when preparing chart data to be displayed on home page [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/507757 [09:54:10] (03PS4) 10D3r1ck01: [IMPR] DRY when preparing chart data to be displayed on home page [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/507757 [09:55:15] (03CR) 10D3r1ck01: [C: 03+2] "This change is ready for review." [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/507757 (owner: 10D3r1ck01) [09:56:04] (03Merged) 10jenkins-bot: [IMPR] DRY when preparing chart data to be displayed on home page [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/507757 (owner: 10D3r1ck01) [10:22:32] (03PS1) 10D3r1ck01: [style] Resort all utility methods into alphabetical order [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/507765 [10:22:38] 10Pywikibot, 10Patch-For-Review, 10good first bug: Add script misspelling support to pwb.py - https://phabricator.wikimedia.org/T217195 (10Xqt) >>! In T217195#5041642, @Dvorapa wrote: > I mean where should I start with reviewing and where should I continue afterwards? # https://gerrit.wikimedia.org/r/#/c/p... [10:23:10] 10Pywikibot, 10Patch-For-Review, 10good first bug: Add script misspelling support to pwb.py - https://phabricator.wikimedia.org/T217195 (10Xqt) [10:25:57] (03CR) 10D3r1ck01: [C: 03+2] "This change is ready for review." [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/507765 (owner: 10D3r1ck01) [10:26:39] (03Merged) 10jenkins-bot: [style] Resort all utility methods into alphabetical order [labs/tools/awmd-stats] - 10https://gerrit.wikimedia.org/r/507765 (owner: 10D3r1ck01) [11:57:13] Hello ! [12:02:35] Hi [12:03:08] Zppix, How are you ? [12:04:54] Fine you? [12:09:47] Zppix, Well [16:50:08] (03PS1) 10Xqt: [IMPR] Derive CommonscatBot from ExistingPageBot and NoRedirectPageBot [pywikibot/core] - 10https://gerrit.wikimedia.org/r/507838 [16:52:47] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Derive CommonscatBot from ExistingPageBot and NoRedirectPageBot [pywikibot/core] - 10https://gerrit.wikimedia.org/r/507838 (owner: 10Xqt) [16:57:55] (03PS2) 10Xqt: [IMPR] Derive CommonscatBot from ExistingPageBot and NoRedirectPageBot [pywikibot/core] - 10https://gerrit.wikimedia.org/r/507838 [17:04:01] (03PS1) 10Xqt: [IMPR] Rename addCommonscat method to treat_page [pywikibot/core] - 10https://gerrit.wikimedia.org/r/507840 [17:20:31] r054l13: This edit has some issues to address: https://www.mediawiki.org/w/index.php?title=Awmd-stats&diff=next&oldid=3215444 [17:21:02] For now, the ranking based on points have not yet been done, feel free to make a patch [17:21:14] Abandoned patches have no points [17:21:44] In fact, recently it's useless and I've cleaned it off the tool so abandoned patches are not supposed to be considered. They're to be ignored completely [17:22:03] thats a good update [17:22:08] If someone submits N patches and abandons N patches, he/she doesn't even feature on the tool. [17:22:18] We only consider merged + under review patches [17:22:31] I use to wonder why an abandoned patch is counted as a patch :) [17:22:46] Abandoned stuff basically is as good as not doing anything, it's useless stats. [17:23:00] Thanks, will update [17:23:01] It was wasn't from the beginning. It has never been so [17:23:30] I can recall seeing abandoned patches listed on the tool [17:24:44] But it had no points ever [17:25:00] It was just there for show but really, it doesn't have any use, hence the cleanup [17:25:40] ok [17:26:55] If you're interested in the on-going changes, see: https://gerrit.wikimedia.org/r/q/project:labs%252Ftools%252Fawmd-stats+status:merged [17:27:10] The most recent patches and if you feel something is not right, create a ticket. [17:27:49] Ok thank you [17:28:05] What goes here: https://www.mediawiki.org/wiki/Awmd-stats should be accurate and consistent with what is on the tool [17:28:11] If you're unsure about something, ask here or file a task. [17:28:22] yeah [17:30:51] xSavitar: This can be misinterpreted https://phabricator.wikimedia.org/T213581#5074350 [17:31:10] well i did not understand it right [17:31:33] I think might be good to update it? [17:31:56] You mean "Points for number of merged patches > points for number of submitted patches under review > points for number of submitted > number of patches abandoned. [17:31:57] " [17:32:25] yes :( [17:32:44] That is the initial ranking which I explained to Brenda [17:32:53] That is how it was in the beginning. [17:33:01] Ahh ok [17:33:01] Number of points for abandoned patches is 0 [17:33:04] Always 0 [17:33:13] 100 abandoned patches x 0 = 0 [17:33:13] ok [17:33:21] understood [17:33:29] But it's useless having 0 on the dashboard hence the cleanup [17:33:41] yeah. [17:33:50] I didn't want to be inconsistent with what is on the tool by writing what the tool is not doing [17:33:52] but is the a place this is noted? [17:33:55] for reference [17:34:10] You can add that in the README and make a patch [17:34:14] xSavitar: I understand I cleared the edit [17:34:42] I don't know how the calculation is done either [17:34:59] The huristic we're using is (2 x number_of_merged_patches + number_of_under_review_patches) [17:35:26] ok cool then [17:35:38] will update docs [17:36:12] https://gerrit.wikimedia.org/r/c/labs/tools/awmd-stats/+/504218 that is the patch that introduced it [17:36:57] Ranking per points have not yet been done but I've narrowed it down but it's still not done [17:37:10] ok [17:37:57] 👍🏿 [18:55:43] (03CR) 10Xqt: [C: 03+2] [tests] Revert "Temporary deactivate wikidata default site tests" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/507245 (https://phabricator.wikimedia.org/T221543) (owner: 10Xqt) [18:56:43] 10Pywikibot, 10MediaWiki-API, 10Wikidata, 10Patch-For-Review, and 3 others: Travis test fails for wikidata:wikidata site - https://phabricator.wikimedia.org/T221543 (10Xqt) 05Open→03Resolved a:03Xqt [18:58:14] (03Merged) 10jenkins-bot: [tests] Revert "Temporary deactivate wikidata default site tests" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/507245 (https://phabricator.wikimedia.org/T221543) (owner: 10Xqt) [18:59:49] (03CR) 10jenkins-bot: [tests] Revert "Temporary deactivate wikidata default site tests" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/507245 (https://phabricator.wikimedia.org/T221543) (owner: 10Xqt) [21:46:22] (03CR) 10Dvorapa: [C: 03+2] [IMPR] Rename addCommonscat method to treat_page [pywikibot/core] - 10https://gerrit.wikimedia.org/r/507840 (owner: 10Xqt)