[03:43:13] 10Pywikibot: FilePage.getRedirectTarget should return a FilePage - https://phabricator.wikimedia.org/T233392 (10JJMC89) I'd go further and have `BasePage.getRedirectTarget()` return an object of the same class as the redirect. This would keep the implementation general and allow other subclasses that want the re... [07:50:43] 10Pywikibot: FilePage.getRedirectTarget should return a FilePage - https://phabricator.wikimedia.org/T233392 (10Xqt) p:05Triage→03Low [08:02:19] 10Pywikibot, 10Pywikibot-tests: TestFileArchive test fails with TypeError - https://phabricator.wikimedia.org/T233476 (10Xqt) [08:02:25] 10Pywikibot, 10Pywikibot-tests: TestFileArchive test fails with TypeError - https://phabricator.wikimedia.org/T233476 (10Xqt) p:05Triage→03High [08:04:57] (03PS1) 10Xqt: [bugfix] Fix method call for assert_valid_iter_param [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538369 (https://phabricator.wikimedia.org/T233476) [09:35:59] (03PS10) 10Xqt: [bugfix] Implement deletedrevisions api call [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538006 (https://phabricator.wikimedia.org/T75370) [09:36:22] (03CR) 10Xqt: [bugfix] Implement deletedrevisions api call (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538006 (https://phabricator.wikimedia.org/T75370) (owner: 10Xqt) [10:03:06] 10Pywikibot: FilePage.getRedirectTarget should return a FilePage - https://phabricator.wikimedia.org/T233392 (10Dvorapa) Whaqt about internamespace redirects? [10:29:07] (03Abandoned) 10Aklapper: Insert the description of the change. [extensions/examples] (REL1_33) - 10https://gerrit.wikimedia.org/r/522034 (owner: 10Kongweimin) [10:32:29] 10Pywikibot: Check/Update Pywikibot for blockexpiry timestamps from list=users and list=allusers - https://phabricator.wikimedia.org/T233477 (10Multichill) [10:50:16] (03CR) 10Aklapper: "What's left to do here to get this in? "Only" a review?" [extensions/examples] - 10https://gerrit.wikimedia.org/r/482488 (owner: 10Krinkle) [10:50:19] (03PS1) 10Xqt: [bugfix] Fix assert_valid_iter_params [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538371 (https://phabricator.wikimedia.org/T233476) [10:50:55] (03Abandoned) 10Xqt: [bugfix] Fix assert_valid_iter_params [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538371 (https://phabricator.wikimedia.org/T233476) (owner: 10Xqt) [10:52:08] (03PS2) 10Xqt: [bugfix] Fix method call for assert_valid_iter_param [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538369 (https://phabricator.wikimedia.org/T233476) [10:54:17] (03CR) 10jerkins-bot: [V: 04-1] [bugfix] Fix method call for assert_valid_iter_param [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538369 (https://phabricator.wikimedia.org/T233476) (owner: 10Xqt) [10:55:02] 10Pywikibot: Check/Update Pywikibot for Reporting of edit failures due to AbuseFilter and SpamBlacklist - https://phabricator.wikimedia.org/T233479 (10Multichill) [10:58:42] (03PS3) 10Xqt: [bugfix] Fix method call for assert_valid_iter_param [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538369 (https://phabricator.wikimedia.org/T233476) [11:00:35] (03CR) 10jerkins-bot: [V: 04-1] [bugfix] Fix method call for assert_valid_iter_param [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538369 (https://phabricator.wikimedia.org/T233476) (owner: 10Xqt) [11:21:49] (03PS4) 10Xqt: [bugfix] Fix method call for assert_valid_iter_param [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538369 (https://phabricator.wikimedia.org/T233476) [11:24:33] 10Pywikibot, 10Pywikibot-tests: Unexpected success for FailingSiteTestCase.test_hackerspaces - https://phabricator.wikimedia.org/T233419 (10Xqt) >>! In T233419#5511804, @Dvorapa wrote: > Wasn't this a test of the decorator then? > surely not. We don't test unittest itself. > Anyway it should be clearly state... [11:35:19] (03PS1) 10Xqt: [tests] Remove test_hackerspaces [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538377 (https://phabricator.wikimedia.org/T233419) [12:12:54] (03PS1) 10Xqt: [IMPR] Upcast getRedirectTarget result [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538378 (https://phabricator.wikimedia.org/T233392) [12:13:10] 10Pywikibot, 10Patch-For-Review: FilePage.getRedirectTarget should return a FilePage - https://phabricator.wikimedia.org/T233392 (10Xqt) a:03Xqt [13:06:13] 10Pywikibot: Check/Update Pywikibot for blockexpiry timestamps from list=users and list=allusers - https://phabricator.wikimedia.org/T233477 (10Xqt) Site.allusers method doesn't gives all au props. It just gives `'editcount|groups|registration'` currently where the registration is in ISO-Format (not in pywikibo... [14:02:34] 10Pywikibot: Check/Update Pywikibot for Reporting of edit failures due to AbuseFilter and SpamBlacklist - https://phabricator.wikimedia.org/T233479 (10Xqt) Probably Site._ep_errors must be updated then or it raises an api.APIError. But with the current implementation api errors always raises an exception and th... [14:02:46] 10Pywikibot: Check/Update Pywikibot for Reporting of edit failures due to AbuseFilter and SpamBlacklist - https://phabricator.wikimedia.org/T233479 (10Xqt) p:05Triage→03Normal [14:05:27] 10Pywikibot, 10Pywikibot-tests: script_tests' collector function should be validated - https://phabricator.wikimedia.org/T233438 (10Xqt) >>! In T233438#5510005, @Dvorapa wrote: > I did some work on this issue here: https://github.com/dvorapa/pywikibot/commits/dvorapa-test Yes I guess this test script must be... [14:05:47] 10Pywikibot, 10Pywikibot-tests: script_tests' collector function should be validated - https://phabricator.wikimedia.org/T233438 (10Xqt) p:05Triage→03Low [14:08:08] 10Pywikibot, 10Patch-For-Review: FilePage.getRedirectTarget should return a FilePage - https://phabricator.wikimedia.org/T233392 (10Xqt) >>! In T233392#5512600, @Dvorapa wrote: > What about internamespace redirects? Currently a InterwikiRedirectPage exception will be raised [14:18:14] 10Pywikibot, 10Pywikibot-tests: Unexpected success with TestGenerateFamilyFiles.test_attributes_after_run - https://phabricator.wikimedia.org/T233484 (10Xqt) [14:18:20] 10Pywikibot, 10Pywikibot-tests: Unexpected success with TestGenerateFamilyFiles.test_attributes_after_run - https://phabricator.wikimedia.org/T233484 (10Xqt) p:05Triage→03High [14:18:47] 10Pywikibot, 10Pywikibot-tests: Unexpected success with TestGenerateFamilyFiles.test_attributes_after_run - https://phabricator.wikimedia.org/T233484 (10Xqt) [14:18:50] 10Pywikibot, 10Pywikibot-tests: generate_family_files test fails on Travis and AppVeyor - https://phabricator.wikimedia.org/T194138 (10Xqt) [16:04:28] (03PS1) 10Xqt: [tests] use subTest to detect failing tests more specific [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538383 (https://phabricator.wikimedia.org/T233484) [16:35:28] (03CR) 10Strainu: [C: 03+2] [IMPR] Upcast getRedirectTarget result [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538378 (https://phabricator.wikimedia.org/T233392) (owner: 10Xqt) [16:37:27] (03Merged) 10jenkins-bot: [IMPR] Upcast getRedirectTarget result [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538378 (https://phabricator.wikimedia.org/T233392) (owner: 10Xqt) [16:39:03] (03CR) 10jenkins-bot: [IMPR] Upcast getRedirectTarget result [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538378 (https://phabricator.wikimedia.org/T233392) (owner: 10Xqt) [16:41:25] (03CR) 10JJMC89: [IMPR] Upcast getRedirectTarget result (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538378 (https://phabricator.wikimedia.org/T233392) (owner: 10Xqt) [16:41:37] 10Pywikibot, 10Pywikibot-tests: Enable unexpected successes? - https://phabricator.wikimedia.org/T209798 (10Xqt) There is a different behaviour between Python 2 and 3. Python 3 counts an unexcpected success as failure whereas Python 2 passes. [16:42:13] 10Pywikibot, 10Pywikibot-tests: Enable unexpected successes? - https://phabricator.wikimedia.org/T209798 (10Xqt) [16:42:23] 10Pywikibot, 10Pywikibot-tests: Usages of unittest.expectedFailure and allowed_failure should be solved (goal) - https://phabricator.wikimedia.org/T129368 (10Xqt) [16:42:38] 10Pywikibot, 10Pywikibot-tests: Enable unexpected successes? - https://phabricator.wikimedia.org/T209798 (10Xqt) [16:42:41] 10Pywikibot, 10Pywikibot-tests: Cleanup test warnings (goal) - https://phabricator.wikimedia.org/T195826 (10Xqt) [16:43:56] 10Pywikibot, 10Patch-For-Review: FilePage.getRedirectTarget should return a FilePage - https://phabricator.wikimedia.org/T233392 (10Strainu) >>! In T233392#5512600, @Dvorapa wrote: > What about internamespace redirects? These are not affected by Xqt's patch - you just get the right class according to the clas... [16:52:03] 10Pywikibot, 10Pywikibot-tests: creating a site from url raises SiteDefinitionError for closed wikis - https://phabricator.wikimedia.org/T233487 (10Xqt) [16:52:10] 10Pywikibot, 10Pywikibot-tests: creating a site from url raises SiteDefinitionError for closed wikis - https://phabricator.wikimedia.org/T233487 (10Xqt) p:05Triage→03High [16:53:30] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: Unexpected success with TestGenerateFamilyFiles.test_attributes_after_run - https://phabricator.wikimedia.org/T233484 (10Xqt) Removing the expectedFailure decorator and enabling subTest we can find two sorts of failures: # Assertion Error reported in T19... [16:54:15] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: Unexpected success with TestGenerateFamilyFiles.test_attributes_after_run - https://phabricator.wikimedia.org/T233484 (10Xqt) [16:54:18] 10Pywikibot, 10Pywikibot-tests: Usages of unittest.expectedFailure and allowed_failure should be solved (goal) - https://phabricator.wikimedia.org/T129368 (10Xqt) [16:55:25] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: Unexpected success with TestGenerateFamilyFiles.test_attributes_after_run - https://phabricator.wikimedia.org/T233484 (10Xqt) [16:55:28] 10Pywikibot, 10Pywikibot-tests: generate_family_files test fails on Travis and AppVeyor - https://phabricator.wikimedia.org/T194138 (10Xqt) [16:55:52] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: Unexpected success with TestGenerateFamilyFiles.test_attributes_after_run - https://phabricator.wikimedia.org/T233484 (10Xqt) [16:55:55] 10Pywikibot, 10Pywikibot-tests: creating a site from url raises SiteDefinitionError for closed wikis - https://phabricator.wikimedia.org/T233487 (10Xqt) [16:55:58] 10Pywikibot, 10Pywikibot-tests: generate_family_files test fails on Travis and AppVeyor - https://phabricator.wikimedia.org/T194138 (10Xqt) [17:16:19] (03PS1) 10Xqt: [bugfix] enable creating sites from url for closed wikis [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538384 (https://phabricator.wikimedia.org/T233487) [17:21:11] (03CR) 10Xqt: [IMPR] Upcast getRedirectTarget result (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538378 (https://phabricator.wikimedia.org/T233392) (owner: 10Xqt) [17:21:32] 10Pywikibot: FilePage.getRedirectTarget should return a FilePage - https://phabricator.wikimedia.org/T233392 (10Xqt) 05Open→03Resolved [17:23:01] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: creating a site from url raises SiteDefinitionError for closed wikis - https://phabricator.wikimedia.org/T233487 (10Xqt) a:03Xqt [18:35:23] (03PS1) 10Zoranzoki21: Add Serbian Wikipedia in wikis which welcome.py works [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538386 [18:40:43] (03PS2) 10Zoranzoki21: Add Serbian Wikipedia in wikis where welcome.py works [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538386 [18:42:53] (03CR) 10Zoranzoki21: "Hmm, when I uploaded patch set 2, it added Derick instead of Dvorapa :/" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538386 (owner: 10Zoranzoki21) [19:25:47] (03CR) 10Xqt: Add Serbian Wikipedia in wikis where welcome.py works (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538386 (owner: 10Zoranzoki21) [21:22:41] (03CR) 10Mpaa: [bugfix] Fix method call for assert_valid_iter_param (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538369 (https://phabricator.wikimedia.org/T233476) (owner: 10Xqt) [21:39:40] (03PS1) 10Mpaa: site_tests.py: Remove deprecated allowed_failure and allowed_failure_if [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538401 (https://phabricator.wikimedia.org/T223030) [21:50:45] (03CR) 10Xqt: [bugfix] Fix method call for assert_valid_iter_param (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538369 (https://phabricator.wikimedia.org/T233476) (owner: 10Xqt) [22:14:56] (03CR) 10Mpaa: [C: 03+2] [tests] use subTest to detect failing tests more specific [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538383 (https://phabricator.wikimedia.org/T233484) (owner: 10Xqt) [22:16:57] (03Merged) 10jenkins-bot: [tests] use subTest to detect failing tests more specific [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538383 (https://phabricator.wikimedia.org/T233484) (owner: 10Xqt) [22:18:38] (03CR) 10jenkins-bot: [tests] use subTest to detect failing tests more specific [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538383 (https://phabricator.wikimedia.org/T233484) (owner: 10Xqt) [22:22:06] (03CR) 10Mpaa: [C: 03+2] "Hhmm I merged already, but what about python2?" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538383 (https://phabricator.wikimedia.org/T233484) (owner: 10Xqt) [22:26:10] (03CR) 10Mpaa: [C: 03+2] "We use unittest2, right?" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538383 (https://phabricator.wikimedia.org/T233484) (owner: 10Xqt) [22:29:11] (03CR) 10Mpaa: [bugfix] Fix method call for assert_valid_iter_param (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538369 (https://phabricator.wikimedia.org/T233476) (owner: 10Xqt) [23:06:41] (03CR) 10Xqt: "> We use unittest2, right?" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538383 (https://phabricator.wikimedia.org/T233484) (owner: 10Xqt) [23:55:05] (03PS3) 10Zoranzoki21: Remove list of wikis in documentation of welcome.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538386 [23:55:20] (03PS4) 10Zoranzoki21: Remove list of wikis in documentation of welcome.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538386 [23:55:38] (03CR) 10Zoranzoki21: Remove list of wikis in documentation of welcome.py (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/538386 (owner: 10Zoranzoki21)