[05:42:43] (03PS3) 10VolkerE: Make extra `` in Vector tabs optional [skins/Vector] - 10https://gerrit.wikimedia.org/r/545904 (https://phabricator.wikimedia.org/T236410) (owner: 10Krinkle) [06:40:51] (03PS1) 10Jack Tan: add example_test.c to repo [extensions/examples] - 10https://gerrit.wikimedia.org/r/546024 [06:40:53] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/examples] - 10https://gerrit.wikimedia.org/r/546024 (owner: 10Jack Tan) [06:52:03] (03PS2) 10Jack Tan: add example_test.c to repo for testing purpose [extensions/examples] - 10https://gerrit.wikimedia.org/r/546024 [07:33:20] (03CR) 10Aklapper: [C: 04-2] "Jack-Tan: Hi and congratulations to your patch in Wikimedia Gerrit but this is not a place to play. Please abandon your changeset, as it s" [extensions/examples] - 10https://gerrit.wikimedia.org/r/546024 (owner: 10Jack Tan) [08:23:31] 10Pywikibot: pywikibot.page.BasePage.imagelinks() crashes - https://phabricator.wikimedia.org/T236405 (10Xqt) Couldn't reproduce it with the current master branch: ` >>> import pwb, pywikibot as py Warning (from warnings module): File "C:\pwb\GIT\core\pywikibot\config2.py", line 1136 warn('"{0}" present... [08:43:53] (03Abandoned) 10Jack Tan: add example_test.c to repo for testing purpose [extensions/examples] - 10https://gerrit.wikimedia.org/r/546024 (owner: 10Jack Tan) [08:44:30] (03CR) 10Jack Tan: "> Jack-Tan: Hi and congratulations to your patch in Wikimedia Gerrit" [extensions/examples] - 10https://gerrit.wikimedia.org/r/546024 (owner: 10Jack Tan) [09:06:22] 10Pywikibot: pywikibot.page.BasePage.imagelinks() crashes - https://phabricator.wikimedia.org/T236405 (10OlehOnyshchcak) @Xqt, thank you for the resolution! While pypi version still has this bug, I will switch directly to the master branch. And just from curiosity, do we have in backlog a task to make pywikibo... [11:06:48] 10Pywikibot, 10Pywikibot-redirect.py: Pywikibot-redirect ignoring -namespace - https://phabricator.wikimedia.org/T234133 (10Aklapper) @Dvorapa: #good_first_bug tasks are self-contained, non-controversial issues with a clear approach and should be well-described with pointers to help a completely new contributo... [11:26:18] 10Pywikibot: pywikibot.page.BasePage.imagelinks() crashes - https://phabricator.wikimedia.org/T236405 (10Xqt) >>! In T236405#5605642, @OlehOnyshchcak wrote: > @Xqt, thank you for the resolution! While pypi version still has this bug, I will switch directly to the master branch. > Be aware: master branch is the... [11:36:33] 10Pywikibot: pywikibot.page.BasePage.imagelinks() crashes - https://phabricator.wikimedia.org/T236405 (10Dvorapa) >>! In T236405#5605967, @Xqt wrote: >>>! In T236405#5605642, @OlehOnyshchcak wrote: >> And just from curiosity, do we have in backlog a task to make pywikibot versioning working with pip? As @Dvorapa... [11:44:04] 10Pywikibot: pywikibot.page.BasePage.imagelinks() crashes - https://phabricator.wikimedia.org/T236405 (10Xqt) 05Open→03Invalid [11:44:53] 10Pywikibot: Pywikibot identifies iteself with the wrong version, breaking pip freeze - https://phabricator.wikimedia.org/T198374 (10Xqt) p:05Triage→03Normal [11:45:00] 10Pywikibot, 10Pywikibot-redirect.py, 10good first bug: Pywikibot-redirect ignoring -namespace - https://phabricator.wikimedia.org/T234133 (10Dvorapa) @Xqt -namespace should always filter the source. This behavior is default in 100 % of scripts and should not be interrupted. @Aklapper The goal is easy. Add... [11:45:52] 10Pywikibot: Pywikibot identifies itself with the wrong version, breaking pip freeze - https://phabricator.wikimedia.org/T198374 (10Dvorapa) [11:49:05] 10Pywikibot: pywikibot.page.BasePage.imagelinks() crashes - https://phabricator.wikimedia.org/T236405 (10Dvorapa) 05Invalid→03Resolved a:03Strainu Perhaps mark as resolved already? [11:50:50] 10Pywikibot: pywikibot.page.BasePage.imagelinks() crashes - https://phabricator.wikimedia.org/T236405 (10Xqt) >>! In T236405#5606020, @Dvorapa wrote: > Perhaps mark as resolved already? Sure [11:55:42] 10Pywikibot: pywikibot.page.BasePage.imagelinks() crashes - https://phabricator.wikimedia.org/T236405 (10OlehOnyshchcak) @Dvorapa @Xqt, thanks for support and information! [12:01:22] 10Pywikibot, 10Pywikibot-redirect.py, 10good first bug: Pywikibot-redirect ignoring -namespace - https://phabricator.wikimedia.org/T234133 (10Xqt) >>! In T234133#5606000, @Dvorapa wrote: > @Xqt -namespace should always filter the source. This behavior is default in 100 % of scripts and should not be interrup... [12:08:32] 10Pywikibot, 10Pywikibot-Scripts, 10good first bug: add Sindhi (sd) welcome log to welcome.py - https://phabricator.wikimedia.org/T236118 (10Xqt) See https://github.com/wikimedia/pywikibot/pull/30 [13:41:56] 10Pywikibot, 10Pywikibot-redirect.py, 10good first bug: Pywikibot-redirect ignoring -namespace - https://phabricator.wikimedia.org/T234133 (10Dvorapa) Parameter for the page to be changed should be done using a different parameter (-targetns), not -ns used for filtering the source code. The description seems... [13:44:47] 10Pywikibot, 10Pywikibot-redirect.py, 10good first bug: Pywikibot-redirect ignoring -namespace - https://phabricator.wikimedia.org/T234133 (10Xqt) >>! In T234133#5606411, @Dvorapa wrote: > Parameter for the page to be changed should be done using a different parameter (-targetns), not -ns used for filtering... [14:11:33] 10Pywikibot, 10Pywikibot-redirect.py, 10good first bug: Pywikibot-redirect ignoring -namespace - https://phabricator.wikimedia.org/T234133 (10Dvorapa) Yeah, but you got my point: -ns reserved to generator filder, -targetns -changens -whateverns to the others [14:43:53] (03CR) 10VolkerE: "That took a bit more time than expected, but is, besides a possible better use of mixins for the `em` calculation a much better, hardened " [skins/Vector] - 10https://gerrit.wikimedia.org/r/545904 (https://phabricator.wikimedia.org/T236410) (owner: 10Krinkle) [14:45:23] (03PS1) 10Yaron Koren: Another fix for f2b020b9bced - update error message [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/546196 [14:46:04] (03PS2) 10Yaron Koren: Another fix for f2b020b9bced - update error message [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/546196 [15:00:23] (03CR) 10Yaron Koren: [C: 03+2] Another fix for f2b020b9bced - update error message [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/546196 (owner: 10Yaron Koren) [15:13:21] (03Merged) 10jenkins-bot: Another fix for f2b020b9bced - update error message [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/546196 (owner: 10Yaron Koren) [15:22:35] (03PS2) 10Krinkle: [WIP] Remove extra from Vector tabs [skins/Vector] - 10https://gerrit.wikimedia.org/r/545905 (https://phabricator.wikimedia.org/T236410) [15:23:00] (03PS3) 10Krinkle: Remove extra from Vector tabs [skins/Vector] - 10https://gerrit.wikimedia.org/r/545905 (https://phabricator.wikimedia.org/T236410) [15:43:39] (03CR) 10Krinkle: [C: 03+1] "Tested in:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/545904 (https://phabricator.wikimedia.org/T236410) (owner: 10Krinkle) [15:53:09] (03CR) 10Krinkle: [C: 03+2] Make extra `` in Vector tabs optional [skins/Vector] - 10https://gerrit.wikimedia.org/r/545904 (https://phabricator.wikimedia.org/T236410) (owner: 10Krinkle) [16:07:54] (03Merged) 10jenkins-bot: Make extra `` in Vector tabs optional [skins/Vector] - 10https://gerrit.wikimedia.org/r/545904 (https://phabricator.wikimedia.org/T236410) (owner: 10Krinkle) [16:27:07] (03CR) 10Bartosz Dziewoński: [C: 03+1] Make extra `` in Vector tabs optional [skins/Vector] - 10https://gerrit.wikimedia.org/r/545904 (https://phabricator.wikimedia.org/T236410) (owner: 10Krinkle) [16:27:09] (03CR) 10Bartosz Dziewoński: [C: 03+1] Remove extra from Vector tabs [skins/Vector] - 10https://gerrit.wikimedia.org/r/545905 (https://phabricator.wikimedia.org/T236410) (owner: 10Krinkle) [16:27:34] (03CR) 10Bartosz Dziewoński: [C: 03+1] "Does this need to wait for caches to expire?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/545905 (https://phabricator.wikimedia.org/T236410) (owner: 10Krinkle) [16:30:10] (03CR) 10Krinkle: "No" [skins/Vector] - 10https://gerrit.wikimedia.org/r/545905 (https://phabricator.wikimedia.org/T236410) (owner: 10Krinkle) [17:35:54] (03CR) 10VolkerE: [C: 03+2] Remove extra from Vector tabs [skins/Vector] - 10https://gerrit.wikimedia.org/r/545905 (https://phabricator.wikimedia.org/T236410) (owner: 10Krinkle) [17:48:46] (03Merged) 10jenkins-bot: Remove extra from Vector tabs [skins/Vector] - 10https://gerrit.wikimedia.org/r/545905 (https://phabricator.wikimedia.org/T236410) (owner: 10Krinkle) [20:47:56] (03PS1) 10VolkerE: hygiene: Make LESS imports non-ambigious [skins/Vector] - 10https://gerrit.wikimedia.org/r/546291 [20:54:55] (03PS2) 10VolkerE: hygiene: Make LESS imports non-ambigious [skins/Vector] - 10https://gerrit.wikimedia.org/r/546291 [21:05:57] (03CR) 10jerkins-bot: [V: 04-1] hygiene: Make LESS imports non-ambigious [skins/Vector] - 10https://gerrit.wikimedia.org/r/546291 (owner: 10VolkerE) [22:20:49] (03CR) 10Jdlrobson: [C: 03+2] hygiene: Make LESS imports non-ambigious [skins/Vector] - 10https://gerrit.wikimedia.org/r/546291 (owner: 10VolkerE) [22:31:48] (03CR) 10jerkins-bot: [V: 04-1] hygiene: Make LESS imports non-ambigious [skins/Vector] - 10https://gerrit.wikimedia.org/r/546291 (owner: 10VolkerE)