[02:03:24] (03PS14) 10Jdlrobson: Drop usage of mediawiki.skinning.interface module in favor of SkinModule [skins/Vector] - 10https://gerrit.wikimedia.org/r/550531 (https://phabricator.wikimedia.org/T232140) [02:05:12] (03CR) 10Jdlrobson: [C: 03+2] "Restoring Catrope's +2 (not sure why rebase despite no changes dropped it https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/5505" [skins/Vector] - 10https://gerrit.wikimedia.org/r/550531 (https://phabricator.wikimedia.org/T232140) (owner: 10Jdlrobson) [02:20:27] (03CR) 10jerkins-bot: [V: 04-1] Drop usage of mediawiki.skinning.interface module in favor of SkinModule [skins/Vector] - 10https://gerrit.wikimedia.org/r/550531 (https://phabricator.wikimedia.org/T232140) (owner: 10Jdlrobson) [02:20:54] (03Merged) 10jenkins-bot: Drop usage of mediawiki.skinning.interface module in favor of SkinModule [skins/Vector] - 10https://gerrit.wikimedia.org/r/550531 (https://phabricator.wikimedia.org/T232140) (owner: 10Jdlrobson) [02:44:54] 10Pywikibot, 10good first task: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character - https://phabricator.wikimedia.org/T236614 (10srishakatux) I'm being bold and removing the #good_first_task tag; it can be put back when there is more clarity on the next steps :) [02:45:03] 10Pywikibot: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character - https://phabricator.wikimedia.org/T236614 (10srishakatux) [05:33:24] (03PS8) 10Nray: Add Coding Conventions Section to Vector README [skins/Vector] - 10https://gerrit.wikimedia.org/r/566885 (https://phabricator.wikimedia.org/T239269) [06:02:51] (03PS6) 10DannyS712: Pass a user to LogPage::addEntry [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/567182 (https://phabricator.wikimedia.org/T243652) [13:12:57] (03PS1) 10D3r1ck01: CargoUtils: Optmize/Avoid repetitive calls to `strlen()` [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570318 [13:30:05] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570318 (owner: 10D3r1ck01) [14:01:18] (03CR) 10Yaron Koren: [C: 03+2] Pass a user to LogPage::addEntry [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/567182 (https://phabricator.wikimedia.org/T243652) (owner: 10DannyS712) [14:16:09] (03PS2) 10Yaron Koren: CargoUtils: Optmize/Avoid repetitive calls to `strlen()` [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570318 (owner: 10D3r1ck01) [14:16:16] (03PS3) 10Yaron Koren: CargoUtils: Optmize/Avoid repetitive calls to `strlen()` [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570318 (owner: 10D3r1ck01) [14:20:06] (03CR) 10Yaron Koren: [C: 03+2] "Thank you!" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570318 (owner: 10D3r1ck01) [14:49:20] (03CR) 10Yaron Koren: [C: 03+2] "." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570318 (owner: 10D3r1ck01) [15:06:02] (03Merged) 10jenkins-bot: CargoUtils: Optmize/Avoid repetitive calls to `strlen()` [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570318 (owner: 10D3r1ck01) [15:19:10] (03CR) 10Niedzielski: [C: 03+1] Add Coding Conventions Section to Vector README [skins/Vector] - 10https://gerrit.wikimedia.org/r/566885 (https://phabricator.wikimedia.org/T239269) (owner: 10Nray) [20:17:46] (03PS1) 10Yaron Koren: Fix for 60ddb9cfc3dd for multi-byte characters [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570426 [20:22:10] (03PS2) 10Yaron Koren: Fix for 60ddb9cfc3dd for multi-byte characters [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570426 [20:30:38] (03CR) 10Yaron Koren: [C: 03+2] Fix for 60ddb9cfc3dd for multi-byte characters [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570426 (owner: 10Yaron Koren) [20:46:11] 10Pywikibot, 10Pywikibot-Wikidata, 10Pywikibot-tests: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10Dvorapa) Introduced in rPWBCa892b382d15253f2f66a9f88a563090bb647710e [21:03:42] 10Pywikibot, 10Pywikibot-Wikidata, 10Pywikibot-tests: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10Dvorapa) @Xqt @matej_suchanek The error occurs only sometimes and it makes test produce milions of errors at once. I think thi... [21:03:45] 10Pywikibot, 10Pywikibot-Wikidata, 10Pywikibot-tests: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10Dvorapa) @Xqt @matej_suchanek The error occurs only sometimes and it makes test produce milions of errors at once. I think thi... [21:08:17] 10Pywikibot, 10Pywikibot-Wikidata, 10Pywikibot-tests: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10Dvorapa) But the code haven't changed much in the mentioned patch, which is weird [21:08:19] 10Pywikibot, 10Pywikibot-Wikidata, 10Pywikibot-tests: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10Dvorapa) But the code haven't changed much in the mentioned patch, which is weird [21:17:29] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Random tests fail with timeout - https://phabricator.wikimedia.org/T242081 (10Dvorapa) ` $ python pwb.py shell Welcome to the Pywikibot interactive shell! >>> s=pywikibot.Site('wikidata', 'wikidata') >>> s DataSite("wikidata", "wikidata") >>>... [21:17:37] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Random tests fail with timeout - https://phabricator.wikimedia.org/T242081 (10Dvorapa) ` $ python pwb.py shell Welcome to the Pywikibot interactive shell! >>> s=pywikibot.Site('wikidata', 'wikidata') >>> s DataSite("wikidata", "wikidata") >>>... [22:23:40] 10Pywikibot, 10Pywikibot-Wikidata, 10Pywikibot-tests: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10Dvorapa) Okay, if DataSite.namespaces fails to get namespaces (due to timeout), this error is thrown, which is not a good beha... [22:26:01] 10Pywikibot, 10Pywikibot-Wikidata, 10Pywikibot-tests: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10Dvorapa) So this is a duplicate of T242081, but the error message is not much useful [22:26:32] (03PS9) 10Nray: Add Coding Conventions Section to Vector README [skins/Vector] - 10https://gerrit.wikimedia.org/r/566885 (https://phabricator.wikimedia.org/T239269) [22:33:24] 10Pywikibot, 10Pywikibot-Wikidata, 10Pywikibot-tests: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10Dvorapa) Basically, here (_build_namespaces): https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/pywikibot/site.py... [22:44:04] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Random tests fail with timeout - https://phabricator.wikimedia.org/T242081 (10Xqt) > LOL A known upstream issue. can’t laugh about it anymore. [22:46:59] 10Pywikibot, 10Pywikibot-Wikidata, 10Pywikibot-tests: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10Xqt) >>! In T242083#5854100, @Dvorapa wrote: > Okay, if DataSite.namespaces fails to get namespaces (due to timeout), this err... [22:51:07] 10Pywikibot, 10Pywikibot-Wikidata, 10Pywikibot-tests: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10Dvorapa) It seems so as it then works with empty/incomplete namespace list and produces the error message in the description [22:52:52] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Random tests fail with timeout - https://phabricator.wikimedia.org/T242081 (10Dvorapa) I'm not laughing, I'm crying as it means Pywikibot is sometimes useless with Wikidata API [22:55:01] 10Pywikibot, 10Pywikibot-tests: PetScanPageGeneratorTestCase.test_petscan sometimes fails with ReadTimeout - https://phabricator.wikimedia.org/T216005 (10Dvorapa) >>! In T216005#4969196, @Framawiki wrote: > I've already seen the petscan server a lot of times temporarily not responding correctly. Does that mean... [23:33:30] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Pywikibot fails to access Wikidata due to high maxlag - https://phabricator.wikimedia.org/T242081 (10Dvorapa) [23:35:07] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Pywikibot fails to access Wikidata due to high maxlag - https://phabricator.wikimedia.org/T242081 (10Dvorapa) [23:36:01] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Pywikibot fails to access Wikidata due to high maxlag - https://phabricator.wikimedia.org/T242081 (10Dvorapa) [23:40:21] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Pywikibot fails to access Wikidata due to high maxlag - https://phabricator.wikimedia.org/T242081 (10Dvorapa) [23:41:03] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Pywikibot fails to access Wikidata due to high maxlag - https://phabricator.wikimedia.org/T242081 (10Dvorapa) [23:41:45] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Pywikibot fails to access Wikidata due to high maxlag - https://phabricator.wikimedia.org/T242081 (10Dvorapa) [23:42:32] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Pywikibot fails to access Wikidata due to high maxlag - https://phabricator.wikimedia.org/T242081 (10Dvorapa) [23:42:35] 10Pywikibot, 10Pywikibot-Wikidata, 10Pywikibot-tests: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10Dvorapa) [23:44:42] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Pywikibot fails to access Wikidata due to high maxlag lately - https://phabricator.wikimedia.org/T242081 (10Dvorapa) [23:45:48] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Pywikibot fails to access Wikidata due to high maxlag lately - https://phabricator.wikimedia.org/T242081 (10Dvorapa)