[10:12:54] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Pywikibot fails to access Wikidata due to high maxlag lately - https://phabricator.wikimedia.org/T242081 (10JeanFred) [10:13:07] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Pywikibot fails to access Wikidata due to high maxlag lately - https://phabricator.wikimedia.org/T242081 (10JeanFred) [10:14:53] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Pywikibot fails to access Wikidata due to high maxlag lately - https://phabricator.wikimedia.org/T242081 (10JeanFred) [10:15:01] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests, 10Upstream: Pywikibot fails to access Wikidata due to high maxlag lately - https://phabricator.wikimedia.org/T242081 (10JeanFred) [13:31:08] (03PS1) 10Aron Manning: Unify `@font-*` variables among skins. Import font stack from 'mediawiki.ui/fonts.less'. This commit does not change the default article font (system's default sans-serif font), but changes headings to the serif stack, only using fonts available on the client system. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T243508) [13:31:10] (03PS1) 10Aron Manning: TEST: Import Roboto webfonts for consistent look on all platforms. This is only for the purpose of testing. For production the @font-face stylesheets need to be loaded asynchronously from html: @import blocks page drawing until the stylesheet is loaded. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [13:37:08] (03CR) 10jerkins-bot: [V: 04-1] Unify `@font-*` variables among skins. Import font stack from 'mediawiki.ui/fonts.less'. This commit does not change the default article font (system's default sans-serif font), but changes headings to the serif stack, only using fonts available on the client system. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T243508) (owner: 10Aron Mannin [13:37:17] (03CR) 10jerkins-bot: [V: 04-1] TEST: Import Roboto webfonts for consistent look on all platforms. This is only for the purpose of testing. For production the @font-face stylesheets need to be loaded asynchronously from html: @import blocks page drawing until the stylesheet is loaded. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) (owner: 10Aron Manning) [13:51:28] (03CR) 10Aron Manning: "Depends on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/570597 being merged." [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T243508) (owner: 10Aron Manning) [13:51:49] (03CR) 10Aron Manning: "Depends on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/570597 being merged." [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) (owner: 10Aron Manning) [14:48:42] (03CR) 10Niedzielski: [C: 03+1] Add Coding Conventions Section to Vector README [skins/Vector] - 10https://gerrit.wikimedia.org/r/566885 (https://phabricator.wikimedia.org/T239269) (owner: 10Nray) [15:14:25] 10Pywikibot, 10Analytics, 10Event-Platform: EventStreams first message never found - https://phabricator.wikimedia.org/T244491 (10TheSandDoctor) [15:21:08] (03PS2) 10Niedzielski: [WIP] Add skin version user preference and configs [skins/Vector] - 10https://gerrit.wikimedia.org/r/566881 (https://phabricator.wikimedia.org/T242381) [15:35:40] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add skin version user preference and configs [skins/Vector] - 10https://gerrit.wikimedia.org/r/566881 (https://phabricator.wikimedia.org/T242381) (owner: 10Niedzielski) [18:21:59] (03CR) 10Phuedx: [C: 03+1] "I note that a lot of our coding conventions are requirements of certain tools or can be enforced automatically by tooling ;)" [skins/Vector] - 10https://gerrit.wikimedia.org/r/566885 (https://phabricator.wikimedia.org/T239269) (owner: 10Nray) [18:24:32] (03CR) 10Niedzielski: [C: 03+1] "I'm going to +2 this later today if there's no objections." [skins/Vector] - 10https://gerrit.wikimedia.org/r/566885 (https://phabricator.wikimedia.org/T239269) (owner: 10Nray) [18:45:14] 10Pywikibot, 10Analytics, 10Event-Platform: EventStreams first message never found - https://phabricator.wikimedia.org/T244491 (10TheSandDoctor) [19:53:59] (03CR) 10VolkerE: [C: 03+1] Add Coding Conventions Section to Vector README [skins/Vector] - 10https://gerrit.wikimedia.org/r/566885 (https://phabricator.wikimedia.org/T239269) (owner: 10Nray) [20:24:25] (03CR) 10VolkerE: [C: 04-1] "These classes use the standard LESS variable naming, which is established in WikimediaUI Base and follows exactly the same logic of having" [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T243508) (owner: 10Aron Manning) [20:33:06] (03CR) 10Nray: [C: 04-1] POC: Using Danger.js to codify conventions (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/566639 (https://phabricator.wikimedia.org/T239269) (owner: 10Nray) [20:59:12] (03PS2) 10Aron Manning: Unify `@font-*` variables among skins. Import font stack from 'mediawiki.ui/fonts.less'. This commit does not change the default article font (system's default sans-serif font), but changes headings to the serif stack, only using fonts available on the client system. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T243508) [20:59:14] (03PS2) 10Aron Manning: TEST: Import Roboto webfonts for consistent look on all platforms. This is only for the purpose of testing. For production the @font-face stylesheets need to be loaded asynchronously from html: @import blocks page drawing until the stylesheet is loaded. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [21:05:14] (03CR) 10VolkerE: [C: 04-1] "See my comment on PS 1. This goes wrong direction." [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T243508) (owner: 10Aron Manning) [21:07:31] (03CR) 10jerkins-bot: [V: 04-1] TEST: Import Roboto webfonts for consistent look on all platforms. This is only for the purpose of testing. For production the @font-face stylesheets need to be loaded asynchronously from html: @import blocks page drawing until the stylesheet is loaded. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) (owner: 10Aron Manning) [21:08:06] (03CR) 10jerkins-bot: [V: 04-1] Unify `@font-*` variables among skins. Import font stack from 'mediawiki.ui/fonts.less'. This commit does not change the default article font (system's default sans-serif font), but changes headings to the serif stack, only using fonts available on the client system. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T243508) (owner: 10Aron Mannin [21:09:57] (03CR) 10Aron Manning: "Great! Do you mean using the Emmet-style abbr variants? Please clarify with a few examples." [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T243508) (owner: 10Aron Manning) [21:18:10] (03CR) 10Niedzielski: [C: 03+2] Add Coding Conventions Section to Vector README [skins/Vector] - 10https://gerrit.wikimedia.org/r/566885 (https://phabricator.wikimedia.org/T239269) (owner: 10Nray) [21:21:33] 10Pywikibot: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character - https://phabricator.wikimedia.org/T236614 (10Mpaa) > and also wasted me a lot of time in the process of realizing that I need to implement this and re-download data. Obviously developers and maintainers are not happy when... [21:32:13] (03Merged) 10jenkins-bot: Add Coding Conventions Section to Vector README [skins/Vector] - 10https://gerrit.wikimedia.org/r/566885 (https://phabricator.wikimedia.org/T239269) (owner: 10Nray) [22:23:59] (03PS3) 10Niedzielski: [WIP] Add skin version user preference and configs [skins/Vector] - 10https://gerrit.wikimedia.org/r/566881 (https://phabricator.wikimedia.org/T242381) [22:25:39] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add skin version user preference and configs [skins/Vector] - 10https://gerrit.wikimedia.org/r/566881 (https://phabricator.wikimedia.org/T242381) (owner: 10Niedzielski)