[00:28:17] (03PS3) 10Aron Manning: Unify `@ff-*` (was: `@font-family-*`) variables among skins. Import font stack from 'mediawiki.ui/fonts.less'. This commit does not change the default article font (system's default sans-serif font), but changes headings to the serif stack, only using fonts available on the client system. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T243508) [00:28:20] (03PS3) 10Aron Manning: TEST: Import Roboto webfonts for consistent look on all platforms. This is only for the purpose of testing. For production the @font-face stylesheets need to be loaded asynchronously from html: @import blocks page drawing until the stylesheet is loaded. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [00:33:14] (03CR) 10jerkins-bot: [V: 04-1] TEST: Import Roboto webfonts for consistent look on all platforms. This is only for the purpose of testing. For production the @font-face stylesheets need to be loaded asynchronously from html: @import blocks page drawing until the stylesheet is loaded. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) (owner: 10Aron Manning) [00:33:57] (03PS4) 10Aron Manning: Unify `@ff-*` (was: `@font-family-*`) variables among skins. Import font stack from 'mediawiki.fonts.less'. This commit does not change the default article font (system's default sans-serif font), but changes headings to the serif stack, only using fonts available on the client system. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T243508) [00:33:59] (03PS4) 10Aron Manning: TEST: Import Roboto webfonts for consistent look on all platforms. This is only for the purpose of testing. For production the @font-face stylesheets need to be loaded asynchronously from html: @import blocks page drawing until the stylesheet is loaded. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [00:39:02] (03CR) 10jerkins-bot: [V: 04-1] Unify `@ff-*` (was: `@font-family-*`) variables among skins. Import font stack from 'mediawiki.fonts.less'. This commit does not change the default article font (system's default sans-serif font), but changes headings to the serif stack, only using fonts available on the client system. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T243508) (own [01:18:46] (03PS1) 10Nray: POC: Use shared eslint web team rules [skins/Vector] - 10https://gerrit.wikimedia.org/r/570761 (https://phabricator.wikimedia.org/T239269) [01:23:02] (03CR) 10Nray: [C: 04-1] POC: Using Danger.js to codify conventions (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/566639 (https://phabricator.wikimedia.org/T239269) (owner: 10Nray) [01:34:55] (03CR) 10jerkins-bot: [V: 04-1] POC: Use shared eslint web team rules [skins/Vector] - 10https://gerrit.wikimedia.org/r/570761 (https://phabricator.wikimedia.org/T239269) (owner: 10Nray) [08:46:44] 10Pywikibot: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character - https://phabricator.wikimedia.org/T236614 (10OlehOnyshchcak) >>! In T236614#5858056, @Mpaa wrote: >> and also wasted me a lot of time in the process of realizing that I need to implement this and re-download data. > > Obv... [09:12:53] (03PS1) 10Jdlrobson: Use template partials [skins/Vector] - 10https://gerrit.wikimedia.org/r/570861 [09:40:33] (03PS5) 10Aron Manning: Unify `@ff-*` (was: `@font-family-*`) variables among skins. This commit changes the default article font from system-default (Arial on Windows) to one in the stack (Segoe UI on Windows). [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T243508) [09:40:35] (03PS5) 10Aron Manning: TEST: Import Roboto webfonts for consistent look on all platforms. This is only for the purpose of testing. For production the @font-face stylesheets need to be loaded asynchronously from html: @import blocks page drawing until the stylesheet is loaded. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [09:52:18] (03PS1) 10Dvorapa: [docs] Fix doc warning introduced in [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570865 [09:57:52] (03PS2) 10Dvorapa: [docs] Fix newly occurring doc warning [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570865 [10:01:40] (03PS1) 10Dvorapa: [bugfix] Fix as_filename for Windows and Linux [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570867 [10:40:31] (03PS2) 10Dvorapa: [bugfix] Fix as_filename for Windows and Linux [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570867 [10:41:35] (03PS3) 10Dvorapa: [bugfix] Fix as_filename for Windows [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570867 [10:48:40] (03PS4) 10Dvorapa: [bugfix] Fix as_filename for Windows [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570867 (https://phabricator.wikimedia.org/T236614) [10:51:13] (03CR) 10jerkins-bot: [V: 04-1] [bugfix] Fix as_filename for Windows [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570867 (https://phabricator.wikimedia.org/T236614) (owner: 10Dvorapa) [10:52:15] (03PS5) 10Dvorapa: [bugfix] Fix as_filename for Windows [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570867 (https://phabricator.wikimedia.org/T236614) [10:53:12] (03PS6) 10Dvorapa: [bugfix] Fix as_filename for Windows [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570867 (https://phabricator.wikimedia.org/T236614) [10:56:23] (03PS7) 10Dvorapa: [bugfix] Fix as_filename for Windows [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570867 (https://phabricator.wikimedia.org/T236614) [10:58:35] 10Pywikibot, 10Patch-For-Review: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character - https://phabricator.wikimedia.org/T236614 (10Dvorapa) I did some research and it's correct: Only one Windows illegal filename character (") has been missing from our list. I fixed it then with detaile... [11:00:33] 10Pywikibot, 10Patch-For-Review: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character - https://phabricator.wikimedia.org/T236614 (10Dvorapa) a:03Dvorapa [11:02:55] 10Pywikibot, 10Patch-For-Review: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character - https://phabricator.wikimedia.org/T236614 (10Dvorapa) In my opinion, POSIX compliant filenames would be too much there as modern OSes and software can handle Unicode filenames just well [11:07:16] 10Pywikibot, 10Patch-For-Review: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character - https://phabricator.wikimedia.org/T236614 (10Dvorapa) `"` is the last character added to the list. Be aware, that Pywikibot's aim is not to produce filenames adjusted for your OS and your filesystem n... [14:07:17] (03PS1) 10Yaron Koren: Fix for 9dac38db7e98 - fix Special:Drilldown in Special:SpecialPages [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570894 [14:10:52] (03PS2) 10Yaron Koren: Fix for 9dac38db7e98 - fix Special:Drilldown in Special:SpecialPages [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570894 [14:22:39] (03CR) 10Yaron Koren: [C: 03+2] Fix for 9dac38db7e98 - fix Special:Drilldown in Special:SpecialPages [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570894 (owner: 10Yaron Koren) [14:25:56] (03Merged) 10jenkins-bot: Fix for 9dac38db7e98 - fix Special:Drilldown in Special:SpecialPages [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/570894 (owner: 10Yaron Koren) [17:33:29] (03CR) 10Xqt: [C: 03+2] [bugfix] Fix as_filename for Windows [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570867 (https://phabricator.wikimedia.org/T236614) (owner: 10Dvorapa) [17:34:13] (03CR) 10Xqt: [C: 03+2] [docs] Fix newly occurring doc warning [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570865 (owner: 10Dvorapa) [17:36:07] (03Merged) 10jenkins-bot: [bugfix] Fix as_filename for Windows [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570867 (https://phabricator.wikimedia.org/T236614) (owner: 10Dvorapa) [17:36:22] (03Merged) 10jenkins-bot: [docs] Fix newly occurring doc warning [pywikibot/core] - 10https://gerrit.wikimedia.org/r/570865 (owner: 10Dvorapa) [17:39:50] 10Pywikibot, 10Patch-For-Review: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character - https://phabricator.wikimedia.org/T236614 (10Dvorapa) 05Open→03Resolved [18:11:36] (03PS2) 10Nray: POC: Use shared eslint web team rules [skins/Vector] - 10https://gerrit.wikimedia.org/r/570761 (https://phabricator.wikimedia.org/T239269) [20:45:19] 10Pywikibot: DeprecationWarning for the sysop argument in pywikibot.login.LoginManager.__init__ - https://phabricator.wikimedia.org/T244604 (10Lofhi) [20:50:45] 10Pywikibot: canBeEdited method seems broken since the depreciation of the sysop argument in pywikibot.login.LoginManager.__init__ - https://phabricator.wikimedia.org/T244604 (10Lofhi) [23:45:22] 10Pywikibot, 10Patch-For-Review: Page.title(as_filename=True) don't remove "\"" (quotes) forbidden character - https://phabricator.wikimedia.org/T236614 (10Mpaa) @OlehOnyshchcak, thanks for the clarification. Appreciated!