[00:07:42] (03CR) 10jerkins-bot: [V: 04-1] Add .svg minifier script `npm run svgmin` [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (owner: 10Aron Manning) [00:08:00] (03CR) 10jerkins-bot: [V: 04-1] Add NPM script `npm run lint:fix` to fix trivial lint errors [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [00:08:17] (03CR) 10jerkins-bot: [V: 04-1] Run .svg minifier [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 (owner: 10Aron Manning) [00:16:14] (03CR) 10Jdlrobson: [C: 03+2] Isolate Vector Styles to their Respective Component (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [00:52:37] (03PS9) 10Aron Manning: Add NPM script `npm run lint:fix` to fix trivial lint errors [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T242781) [00:52:41] (03PS9) 10Aron Manning: Add .svg minifier script `npm run svgmin` [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 [00:52:45] (03PS9) 10Aron Manning: Run .svg minifier [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 [00:53:28] (03PS1) 10Aron Manning: [POC] Make sidebar scrolled [skins/Vector] - 10https://gerrit.wikimedia.org/r/576170 (https://phabricator.wikimedia.org/T245734) [01:08:54] (03CR) 10jerkins-bot: [V: 04-1] [POC] Make sidebar scrolled [skins/Vector] - 10https://gerrit.wikimedia.org/r/576170 (https://phabricator.wikimedia.org/T245734) (owner: 10Aron Manning) [03:24:55] (03CR) 10Aron Manning: [C: 03+1] "DONE again, 3 patches in chain up to https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/575812" [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [07:12:54] (03PS2) 10Aron Manning: [POC] Make sidebar scrolled [skins/Vector] - 10https://gerrit.wikimedia.org/r/576170 (https://phabricator.wikimedia.org/T245734) [09:00:07] (03PS3) 10Aron Manning: [POC] Make sidebar scrolled, header sticky and DIP-like. [skins/Vector] - 10https://gerrit.wikimedia.org/r/576170 (https://phabricator.wikimedia.org/T245734) [09:08:28] (03PS4) 10Aron Manning: [POC] Make sidebar scrolled, header sticky and DIP-like. [skins/Vector] - 10https://gerrit.wikimedia.org/r/576170 (https://phabricator.wikimedia.org/T245734) [09:12:14] (03PS10) 10Aron Manning: Add NPM script `npm run lint:fix` to fix trivial lint errors [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T242781) [09:12:18] (03PS10) 10Aron Manning: Add .svg minifier script `npm run svgmin` [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 [09:12:22] (03PS10) 10Aron Manning: Run .svg minifier [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 [10:05:46] (03PS16) 10Aron Manning: Consistently follow WikimediaUI Base's CSS variable naming convention for font variable names. Document the fonts. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T245136) [10:05:50] (03PS3) 10Aron Manning: Cleanup: add Less variables `@font-size-heading-4`, -5, -6 [skins/Vector] - 10https://gerrit.wikimedia.org/r/576105 (https://phabricator.wikimedia.org/T245838) [10:05:56] (03PS3) 10Aron Manning: Cleanup: remove redundant CSS selectors [skins/Vector] - 10https://gerrit.wikimedia.org/r/576106 (https://phabricator.wikimedia.org/T245838) [10:06:20] (03PS18) 10Aron Manning: [TEST] Font update: use Roboto (sans) and Noto Serif (heading) webfonts with monospace Fira Code for consistent look on all platforms. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [10:16:26] (03CR) 10Aron Manning: "Functionally equivalent to previous version." [skins/Vector] - 10https://gerrit.wikimedia.org/r/576105 (https://phabricator.wikimedia.org/T245838) (owner: 10Aron Manning) [10:16:34] (03CR) 10Aron Manning: "Functionally equivalent to previous version." [skins/Vector] - 10https://gerrit.wikimedia.org/r/576106 (https://phabricator.wikimedia.org/T245838) (owner: 10Aron Manning) [10:20:56] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-network: detect write api actions - https://phabricator.wikimedia.org/T74207 (10matej_suchanek) [10:23:12] (03CR) 10jerkins-bot: [V: 04-1] Consistently follow WikimediaUI Base's CSS variable naming convention for font variable names. Document the fonts. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T245136) (owner: 10Aron Manning) [10:45:05] (03PS1) 10Abijeet Patro: Remove use of deprecated wfWikiID() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576300 [10:46:03] (03CR) 10Abijeet Patro: Remove use of deprecated wfWikiID() (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576300 (owner: 10Abijeet Patro) [10:47:00] (03CR) 10jerkins-bot: [V: 04-1] Remove use of deprecated wfWikiID() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576300 (owner: 10Abijeet Patro) [10:53:41] (03CR) 10Aron Manning: [C: 03+1] "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T245136) (owner: 10Aron Manning) [11:14:24] (03PS1) 10Abijeet Patro: Add debounce when validating page title in Special:MassMessage page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576306 [11:16:10] (03CR) 10jerkins-bot: [V: 04-1] Add debounce when validating page title in Special:MassMessage page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576306 (owner: 10Abijeet Patro) [11:16:45] (03PS2) 10Abijeet Patro: Remove use of deprecated wfWikiID() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576300 [11:24:03] (03PS2) 10Abijeet Patro: Add debounce when validating page title in Special:MassMessage page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576306 [12:18:55] (03CR) 10Fomafix: Cleanup: remove redundant CSS selectors (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576106 (https://phabricator.wikimedia.org/T245838) (owner: 10Aron Manning) [12:36:46] (03CR) 10Aron Manning: Cleanup: remove redundant CSS selectors (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576106 (https://phabricator.wikimedia.org/T245838) (owner: 10Aron Manning) [13:09:49] (03PS3) 10VolkerE: Get legacy styles from ResourceLoaderSkinModule [skins/Vector] - 10https://gerrit.wikimedia.org/r/574585 (https://phabricator.wikimedia.org/T242177) (owner: 10Jdlrobson) [13:55:46] (03CR) 10VolkerE: "Addendum: https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines is pretty clear about commit message being short and featuring c" [skins/Vector] - 10https://gerrit.wikimedia.org/r/566881 (https://phabricator.wikimedia.org/T242381) (owner: 10Niedzielski) [13:56:08] (03CR) 10VolkerE: "I've added PHP as an example." [skins/Vector] - 10https://gerrit.wikimedia.org/r/566881 (https://phabricator.wikimedia.org/T242381) (owner: 10Niedzielski) [16:51:38] (03PS4) 10Shizhao: Change getFilename() for support all file format in flickr from flickr API get file format [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576071 [17:05:50] (03PS8) 10Jdlrobson: Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) [17:06:13] (03CR) 10Jdlrobson: [C: 03+2] "Restoring @nray +2 after trivial rebase concerning Ib3539b1e3bc12341c79913af3c95acad8619cff4" [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [17:07:12] (03CR) 10jerkins-bot: [V: 04-1] Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [17:07:46] (03PS9) 10Jdlrobson: Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) [17:07:56] (03CR) 10Jdlrobson: [C: 03+2] Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [17:08:00] (03PS7) 10Jdlrobson: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [17:08:06] (03PS4) 10Jdlrobson: Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [17:22:16] (03CR) 10jerkins-bot: [V: 04-1] Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [17:22:48] (03CR) 10Jdlrobson: WIP: Spit head and content into their own components/styles (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575778 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [17:23:11] (03CR) 10jerkins-bot: [V: 04-1] Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [17:23:27] (03CR) 10jerkins-bot: [V: 04-1] Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [17:23:35] (03PS5) 10Shizhao: Change getFilename() for support all file format in flickr from flickr API get file format [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576071 [17:25:47] (03PS8) 10Jdlrobson: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [17:25:51] (03CR) 10Jdlrobson: [C: 03+2] Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [17:28:00] (03CR) 10jerkins-bot: [V: 04-1] Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [17:29:00] (03PS10) 10Jdlrobson: Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) [17:29:13] (03CR) 10Jdlrobson: [C: 03+2] "PS10 fixes a line length issue." [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [17:29:23] (03PS9) 10Jdlrobson: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [17:29:31] (03PS5) 10Jdlrobson: Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [17:30:57] (03CR) 10Jdlrobson: "thanks for the proof of concept here Aron." [skins/Vector] - 10https://gerrit.wikimedia.org/r/576170 (https://phabricator.wikimedia.org/T245734) (owner: 10Aron Manning) [17:35:24] (03CR) 10Jdlrobson: "The scope of this is too big. Please limit the task to one thing at a time. It makes review easier and simplifies the conversation" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [17:35:37] (03CR) 10Jdlrobson: [C: 04-1] Add NPM script `npm run lint:fix` to fix trivial lint errors [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [17:36:14] (03CR) 10Jdlrobson: [C: 04-1] "(Also please don't +1 your own patch. Krinkle has mentioned this to you before and it does create a lot of confusion in the review queue." [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [17:36:42] (03PS6) 10Shizhao: Change getFilename() for support all file format in flickr from flickr API get file format [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576071 [17:37:49] (03CR) 10Jdlrobson: [C: 04-1] "Only one person is involved in the Phabricator ticket discussion and that's also the patch submitter. More discussion and agreement that t" [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T245136) (owner: 10Aron Manning) [17:43:23] (03CR) 10Jdlrobson: WIP: Introduce "children" prop to Sidebar Component and the ITemplate Interface (033 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575779 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [17:43:30] (03CR) 10jerkins-bot: [V: 04-1] Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [17:44:22] (03CR) 10Jdlrobson: [C: 03+2] Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [17:46:33] (03CR) 10jerkins-bot: [V: 04-1] Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [17:46:58] (03CR) 10jerkins-bot: [V: 04-1] Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [17:57:59] (03CR) 10jerkins-bot: [V: 04-1] Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [17:59:05] (03CR) 10Jdlrobson: [C: 03+2] "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [17:59:25] (03CR) 10Jdrewniak: [C: 04-1] "> "Add NPM script `npm run lint:fix` to fix trivial lint errors"" [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [18:14:26] (03Merged) 10jenkins-bot: Use template partials rather than HTML strings [skins/Vector] - 10https://gerrit.wikimedia.org/r/572738 (https://phabricator.wikimedia.org/T245456) (owner: 10Jdlrobson) [18:14:46] (03CR) 10jerkins-bot: [V: 04-1] Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [18:14:50] (03CR) 10jerkins-bot: [V: 04-1] Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [18:20:22] (03PS10) 10Jdlrobson: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [18:20:29] (03CR) 10Jdlrobson: [C: 03+2] Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [18:32:57] (03PS6) 10Jdlrobson: Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [18:51:17] (03CR) 10Jdlrobson: [C: 04-1] Add .svg minifier script `npm run svgmin` (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (owner: 10Aron Manning) [18:52:08] (03Merged) 10jenkins-bot: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [18:53:18] (03CR) 10Jdlrobson: [C: 04-1] Add .svg minifier script `npm run svgmin` (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (owner: 10Aron Manning) [19:09:45] (03CR) 10Jdlrobson: [C: 03+2] Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [19:25:09] (03Merged) 10jenkins-bot: Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [19:37:44] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576300 (owner: 10Abijeet Patro) [19:43:14] (03PS1) 10Jdlrobson: Legacy styles now come from ResourceLoaderSkinModule [skins/Vector] - 10https://gerrit.wikimedia.org/r/576429 (https://phabricator.wikimedia.org/T242177) [19:54:58] (03CR) 10Aron Manning: "Thanks for the comments, good points:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [20:17:08] 10Pywikibot, 10Pywikibot-tests: http.fake_user_agent() sometimes gives the same result - https://phabricator.wikimedia.org/T246538 (10Framawiki) Dummy question, why do we need more that 250 UA for pwb? @Xqt looks like CI link you posted is now dead, do you have a copy to paste here? [20:39:36] 10Pywikibot, 10Pywikibot-tests: http.fake_user_agent() sometimes gives the same result - https://phabricator.wikimedia.org/T246538 (10Dvorapa) It happens all the time, I'll find and paste here some other occurence [20:40:13] (03CR) 10Aron Manning: Add .svg minifier script `npm run svgmin` (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (owner: 10Aron Manning) [20:42:45] 10Pywikibot, 10Pywikibot-tests: http.fake_user_agent() sometimes gives the same result - https://phabricator.wikimedia.org/T246538 (10Dvorapa) https://ci.appveyor.com/project/Ladsgroup/pywikibot-g4xqx/builds/31027821/job/n0f465xi7vhqcpbj#L5368 [20:52:20] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576071 (owner: 10Shizhao) [20:53:43] (03CR) 10Jdlrobson: [C: 04-1] "To get merged you will need to drop the npm global install. That's not standard in wikimedia wikis for good reasons and not something that" [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (owner: 10Aron Manning) [20:54:22] (03CR) 10jerkins-bot: [V: 04-1] Change getFilename() for support all file format in flickr from flickr API get file format [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576071 (owner: 10Shizhao) [20:54:46] (03PS7) 10Xqt: Change getFilename() for support all file format in flickr from flickr API get file format [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576071 (owner: 10Shizhao) [20:57:10] (03CR) 10jerkins-bot: [V: 04-1] Change getFilename() for support all file format in flickr from flickr API get file format [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576071 (owner: 10Shizhao) [21:00:16] (03CR) 10Xqt: [C: 04-1] "Do not change doc strings which aren’t related to the patch. It causes the doc test to fail and the automatically created documentation to" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576071 (owner: 10Shizhao) [21:27:42] (03CR) 10Aron Manning: "Will do if you insist. Any answers to the other questions?" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (owner: 10Aron Manning) [21:32:51] (03CR) 10Jdlrobson: [C: 04-1] Add .svg minifier script `npm run svgmin` (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (owner: 10Aron Manning) [21:47:09] (03CR) 10Aron Manning: Add .svg minifier script `npm run svgmin` (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (owner: 10Aron Manning) [22:00:00] (03CR) 10Jdlrobson: [C: 04-1] Add .svg minifier script `npm run svgmin` (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (owner: 10Aron Manning) [23:10:47] (03PS2) 10Jdlrobson: Legacy styles now come from ResourceLoaderSkinModule [skins/Vector] - 10https://gerrit.wikimedia.org/r/576429 (https://phabricator.wikimedia.org/T242177) [23:13:57] (03PS4) 10Jdlrobson: Get legacy styles from ResourceLoaderSkinModule [skins/Vector] - 10https://gerrit.wikimedia.org/r/574585 (https://phabricator.wikimedia.org/T242177) [23:15:33] (03PS3) 10Jdlrobson: Legacy styles now come from ResourceLoaderSkinModule [skins/Vector] - 10https://gerrit.wikimedia.org/r/576429 [23:15:45] (03Abandoned) 10Jdlrobson: Legacy styles now come from ResourceLoaderSkinModule [skins/Vector] - 10https://gerrit.wikimedia.org/r/576429 (owner: 10Jdlrobson) [23:16:50] (03PS5) 10Jdlrobson: Get legacy styles from ResourceLoaderSkinModule [skins/Vector] - 10https://gerrit.wikimedia.org/r/574585 (https://phabricator.wikimedia.org/T242177) [23:17:57] (03CR) 10jerkins-bot: [V: 04-1] Get legacy styles from ResourceLoaderSkinModule [skins/Vector] - 10https://gerrit.wikimedia.org/r/574585 (https://phabricator.wikimedia.org/T242177) (owner: 10Jdlrobson) [23:35:07] (03PS11) 10Aron Manning: Add NPM script `npm run lint:fix` to fix trivial lint errors [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T242781) [23:35:11] (03PS11) 10Aron Manning: Add .svg minifier script `npm run svgmin` [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 [23:35:15] (03PS11) 10Aron Manning: Run .svg minifier [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 [23:35:19] (03PS1) 10Aron Manning: Port 'storybook' scripts to windows, merge 'jsdoc' into 'doc' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (https://phabricator.wikimedia.org/T242781) [23:35:23] (03PS1) 10Aron Manning: Add necessary devdependency 'eslint', remove not-explicitly-necessary 'stylelint' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576472 (https://phabricator.wikimedia.org/T242781) [23:40:40] (03CR) 10Aron Manning: "This change is ready for review." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (owner: 10Aron Manning) [23:41:08] (03CR) 10Aron Manning: "This change is ready for review." [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 (owner: 10Aron Manning) [23:41:58] (03CR) 10Aron Manning: "'storybook' script port split" [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [23:42:41] (03CR) 10Aron Manning: "Dependency update split." [skins/Vector] - 10https://gerrit.wikimedia.org/r/576472 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [23:49:35] (03CR) 10Aron Manning: "Thank you all for the helpful reviews." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [23:51:33] (03CR) 10Aron Manning: "I've incorporated all the comments from Minerva and MF." [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (owner: 10Aron Manning) [23:57:17] (03CR) 10Aron Manning: "I'm not sure why svgmin wasn't run before in Vector. This is the only commit in the chain that affects production. Is bigger visibility ne" [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 (owner: 10Aron Manning)