[00:31:55] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/575262 (owner: 10Shizhao) [00:56:12] (03CR) 10Xqt: [C: 03+2] add replace('|', ',') [pywikibot/core] - 10https://gerrit.wikimedia.org/r/575262 (owner: 10Shizhao) [00:59:39] (03Merged) 10jenkins-bot: add replace('|', ',') [pywikibot/core] - 10https://gerrit.wikimedia.org/r/575262 (owner: 10Shizhao) [02:01:28] (03PS5) 10Aron Manning: [POC] Make sidebar scrolled, header sticky and more like those in Desktop Improvements Project [skins/Vector] - 10https://gerrit.wikimedia.org/r/576170 (https://phabricator.wikimedia.org/T245734) [02:01:32] (03PS1) 10Aron Manning: [POC] Scrollbar styling moved to mixins, applied to main content [skins/Vector] - 10https://gerrit.wikimedia.org/r/577032 [02:06:59] (03CR) 10jerkins-bot: [V: 04-1] [POC] Make sidebar scrolled, header sticky and more like those in Desktop Improvements Project [skins/Vector] - 10https://gerrit.wikimedia.org/r/576170 (https://phabricator.wikimedia.org/T245734) (owner: 10Aron Manning) [02:08:20] (03CR) 10jerkins-bot: [V: 04-1] [POC] Scrollbar styling moved to mixins, applied to main content [skins/Vector] - 10https://gerrit.wikimedia.org/r/577032 (owner: 10Aron Manning) [02:16:14] (03PS6) 10Aron Manning: [POC] Make sidebar scrolled, header sticky and more like those in Desktop Improvements Project [skins/Vector] - 10https://gerrit.wikimedia.org/r/576170 (https://phabricator.wikimedia.org/T245734) [02:16:18] (03PS2) 10Aron Manning: [POC] Scrollbar styling moved to mixins, applied to main content [skins/Vector] - 10https://gerrit.wikimedia.org/r/577032 [02:21:50] (03CR) 10jerkins-bot: [V: 04-1] [POC] Scrollbar styling moved to mixins, applied to main content [skins/Vector] - 10https://gerrit.wikimedia.org/r/577032 (owner: 10Aron Manning) [02:22:13] (03CR) 10jerkins-bot: [V: 04-1] [POC] Make sidebar scrolled, header sticky and more like those in Desktop Improvements Project [skins/Vector] - 10https://gerrit.wikimedia.org/r/576170 (https://phabricator.wikimedia.org/T245734) (owner: 10Aron Manning) [02:27:52] (03PS7) 10Aron Manning: [POC] Make sidebar scrolled, header sticky and more like those in Desktop Improvements Project [skins/Vector] - 10https://gerrit.wikimedia.org/r/576170 (https://phabricator.wikimedia.org/T245734) [02:27:56] (03PS3) 10Aron Manning: [POC] Scrollbar styling moved to mixins, applied to main content [skins/Vector] - 10https://gerrit.wikimedia.org/r/577032 [03:27:21] (03CR) 10Abijeet Patro: "> Patch Set 2:" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576300 (owner: 10Abijeet Patro) [04:29:59] (03PS3) 10Abijeet Patro: Remove use of deprecated wfWikiID() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576300 [04:33:34] (03CR) 10jerkins-bot: [V: 04-1] Remove use of deprecated wfWikiID() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576300 (owner: 10Abijeet Patro) [05:16:50] (03PS4) 10Abijeet Patro: Remove use of deprecated wfWikiID() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576300 [05:19:32] (03PS5) 10Abijeet Patro: Remove use of deprecated wfWikiID() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576300 [07:45:18] (03PS8) 10Shizhao: [IMPR] use template {{Taken on}} + fix flinfo output format update [pywikibot/core] - 10https://gerrit.wikimedia.org/r/575846 [07:48:13] (03CR) 10Shizhao: [C: 03+1] [IMPR] use template {{Taken on}} + fix flinfo output format update (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/575846 (owner: 10Shizhao) [07:53:14] (03PS3) 10Abijeet Patro: Add debounce when validating page title in Special:MassMessage page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576306 [07:53:21] (03PS2) 10Abijeet Patro: [WIP] Add a message page field on the Special:MassMessage page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576850 (https://phabricator.wikimedia.org/T165128) [08:00:28] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a message page field on the Special:MassMessage page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/576850 (https://phabricator.wikimedia.org/T165128) (owner: 10Abijeet Patro) [08:17:34] (03PS1) 10Shizhao: [IMPR] use original tag name [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 [08:44:13] (03PS1) 10Shizhao: [FIX] Username with illegal characters as titles, need to be cleaned up [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577181 [08:53:58] (03CR) 10Xqt: [FIX] Username with illegal characters as titles, need to be cleaned up (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577181 (owner: 10Shizhao) [08:58:19] (03CR) 10Xqt: [IMPR] use original tag name (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [09:09:17] (03PS1) 10Shizhao: [IMPR] Should request category check [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577188 [09:15:13] (03CR) 10Shizhao: [C: 03+1] [IMPR] use original tag name (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [09:15:25] (03CR) 10Xqt: "> > Just 1 month and 2 weeks till the final Python 2 release:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576912 (owner: 10Xqt) [09:22:57] (03PS2) 10Shizhao: [FIX] Username with illegal characters as titles, need to be cleaned up [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577181 [09:23:53] (03CR) 10Shizhao: [C: 03+1] [FIX] Username with illegal characters as titles, need to be cleaned up (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577181 (owner: 10Shizhao) [09:31:06] (03CR) 10Jdrewniak: [C: 03+2] Port 'storybook' scripts to windows, merge 'jsdoc' into 'doc' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [09:47:57] (03PS5) 10Xqt: [IMPR] Use UserDict for LogEntry with Python 3 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576912 [09:59:06] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576912 (owner: 10Xqt) [10:02:12] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Use UserDict for LogEntry with Python 3 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576912 (owner: 10Xqt) [10:03:42] (03PS6) 10Xqt: [IMPR] Use UserDict for LogEntry with Python 3 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576912 [10:06:41] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/575846 (owner: 10Shizhao) [10:09:19] (03PS3) 10Xqt: [FIX] Username with illegal characters as titles, need to be cleaned up [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577181 (owner: 10Shizhao) [10:09:27] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577181 (owner: 10Shizhao) [10:12:20] (03CR) 10Xqt: [IMPR] use original tag name (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [10:14:11] (03CR) 10Xqt: [C: 03+2] [FIX] Username with illegal characters as titles, need to be cleaned up [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577181 (owner: 10Shizhao) [10:16:55] (03Merged) 10jenkins-bot: [FIX] Username with illegal characters as titles, need to be cleaned up [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577181 (owner: 10Shizhao) [11:01:19] (03CR) 10Jdrewniak: [C: 04-1] "I don't see why eslint is needed as an explicit dependency, it's declared as an explicit dependency in eslint-config-wikimedia:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/576472 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [11:26:59] (03CR) 10Aron Manning: "See the comments I made to Umherirrender:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/576472 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [11:29:09] (03CR) 10Aron Manning: "> or windows npm / npm 6.13.4 (node 12.14.1) does the flattening differently." [skins/Vector] - 10https://gerrit.wikimedia.org/r/576472 (https://phabricator.wikimedia.org/T242781) (owner: 10Aron Manning) [12:12:30] 10Pywikibot, 10Pywikibot-tests: test_logpages_dump when 'title' isnt present - https://phabricator.wikimedia.org/T112223 (10Xqt) 05Open→03Resolved a:03Xqt Seems this is solved; haven't seen this issue for a long time [12:13:47] 10Pywikibot, 10Continuous-Integration-Config, 10Pywikibot-tests: Jenkins output for pywikibot job is hard to read - https://phabricator.wikimedia.org/T117570 (10Xqt) 05Open→03Resolved a:03Xqt I think it is better now. [12:27:36] 10Pywikibot, 10Pywikibot-tests, 10Upstream: py.test on PyPy error on some test metaclasses - https://phabricator.wikimedia.org/T136389 (10Xqt) 05Open→03Declined This is very outdated and cannot be reproduced [12:27:39] 10Pywikibot, 10Pywikibot-Announce, 10Pywikibot-tests: Add PyPy 2 support - https://phabricator.wikimedia.org/T101592 (10Xqt) [13:04:51] (03PS9) 10Shizhao: [IMPR] use template {{Taken on}} + fix flinfo output format update [pywikibot/core] - 10https://gerrit.wikimedia.org/r/575846 [13:04:53] (03PS2) 10Shizhao: [IMPR] use original tag name [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 [13:04:56] (03PS2) 10Shizhao: [IMPR] Should request category check [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577188 [13:22:47] (03CR) 10Shizhao: [C: 03+1] [IMPR] use original tag name (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [13:29:06] (03PS3) 10Shizhao: [IMPR] use original tag name [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 [13:29:44] (03CR) 10Shizhao: [C: 03+1] [IMPR] use original tag name [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [13:44:38] (03CR) 10Xqt: [IMPR] Should request category check (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577188 (owner: 10Shizhao) [13:48:26] (03CR) 10Xqt: [IMPR] use original tag name (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [14:18:25] 10Pywikibot, 10Pywikibot-tests: test_commons test of site_tests.TestSingleCodeFamilySite was skipped since August, 2017 - https://phabricator.wikimedia.org/T213519 (10Xqt) 05Open→03Resolved a:03Xqt [14:18:28] 10Pywikibot, 10Pywikibot-tests: Fix tests that never run - https://phabricator.wikimedia.org/T223481 (10Xqt) [14:30:02] (03PS3) 10Shizhao: [IMPR] Should request category check [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577188 [14:31:21] (03CR) 10Shizhao: [C: 03+1] [IMPR] Should request category check (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577188 (owner: 10Shizhao) [15:40:22] (03PS4) 10Shizhao: [IMPR] use original tag name [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 [15:44:22] (03CR) 10Shizhao: [C: 03+1] [IMPR] use original tag name (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [16:08:15] (03PS1) 10Xqt: [IMPR] Improve option handling [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577277 [16:11:01] (03PS5) 10Xqt: [IMPR] use original tag name [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [16:11:10] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [16:13:09] (03PS2) 10Jdlrobson: Rename npm script 'lint:styles' to 'lint:ss' (stylesheet) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576535 (owner: 10Aron Manning) [16:13:17] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] use original tag name [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [16:13:34] (03CR) 10Jdlrobson: "This is not related to T242781 which is about removing Gruntfile and associated Grunt commands" [skins/Vector] - 10https://gerrit.wikimedia.org/r/576535 (owner: 10Aron Manning) [16:14:01] (03PS16) 10Jdlrobson: Add SVG minifier script `npm run svgmin` and unify SVGO rules to Wikimedia coding conventions [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T245296) (owner: 10Aron Manning) [16:14:05] (03CR) 10Jdlrobson: "This is not related to T242781 which is about removing Gruntfile and associated Grunt commands" [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T245296) (owner: 10Aron Manning) [16:14:08] (03CR) 10Xqt: [IMPR] Should request category check (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577188 (owner: 10Shizhao) [16:14:19] (03PS2) 10Jdlrobson: Add linting *.json to script 'npm run lint:js' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576534 (owner: 10Aron Manning) [16:14:23] (03CR) 10Jdlrobson: "This is not related to T242781 which is about removing Gruntfile and associated Grunt commands" [skins/Vector] - 10https://gerrit.wikimedia.org/r/576534 (owner: 10Aron Manning) [16:14:30] (03PS14) 10Jdlrobson: Add script `npm run lint:fix` to fix trivial lint errors [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (owner: 10Aron Manning) [16:14:34] (03CR) 10Jdlrobson: "This is not related to T242781 which is about removing Gruntfile and associated Grunt commands" [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (owner: 10Aron Manning) [16:14:42] (03PS2) 10Jdlrobson: Separate scripts `npm test` and `npm run build`: 'test' won't build documentation [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (owner: 10Aron Manning) [16:14:46] (03CR) 10Jdlrobson: [C: 04-2] "This is not related to T242781 which is about removing Gruntfile and associated Grunt commands" [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (owner: 10Aron Manning) [16:14:55] (03PS3) 10Jdlrobson: Port 'storybook' scripts to windows, merge 'jsdoc' into 'doc' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [16:14:59] (03CR) 10Jdlrobson: "This is not related to T242781 which is about removing Gruntfile and associated Grunt commands" [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [16:16:33] (03CR) 10Xqt: [IMPR] use original tag name (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [16:17:16] (03PS6) 10Xqt: [IMPR] use original tag name [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [16:17:26] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [16:18:47] (03CR) 10Jdlrobson: [C: 04-1] Rename npm script 'lint:styles' to 'lint:ss' (stylesheet) (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576535 (owner: 10Aron Manning) [16:19:37] (03CR) 10Jdlrobson: [C: 04-1] "Despite my concern with this misleading I'm happy to merge but cannot because it's too tied to the change in https://gerrit.wikimedia.org/" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (owner: 10Aron Manning) [16:21:07] (03PS4) 10Jdlrobson: Port 'storybook' scripts to windows, merge 'jsdoc' into 'doc' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [16:21:18] (03CR) 10Jdlrobson: "PS4 fixes some whitespace issues." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [16:22:56] (03PS5) 10Jdlrobson: Port 'storybook' scripts to windows, merge 'jsdoc' into 'doc' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [16:23:25] (03PS6) 10Jdlrobson: Port 'storybook' scripts to windows, merge 'jsdoc' into 'doc' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [16:24:26] (03CR) 10Xqt: [C: 03+2] [IMPR] use original tag name [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [16:25:21] (03CR) 10Jdlrobson: [C: 03+1] Port 'storybook' scripts to windows, merge 'jsdoc' into 'doc' (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [16:26:43] (03Merged) 10jenkins-bot: [IMPR] use original tag name [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577177 (owner: 10Shizhao) [16:38:16] (03CR) 10Jdlrobson: Add linting *.json to script 'npm run lint:js' (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576534 (owner: 10Aron Manning) [16:38:24] (03PS3) 10Jdlrobson: Add linting *.json to script 'npm run lint:js' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576534 (owner: 10Aron Manning) [16:41:40] (03CR) 10Jdlrobson: Add linting *.json to script 'npm run lint:js' (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576534 (owner: 10Aron Manning) [16:42:49] (03PS3) 10Xqt: [IMPR] Simplify code [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576633 [16:45:05] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Simplify code [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576633 (owner: 10Xqt) [16:45:15] (03PS17) 10Jdlrobson: Add SVG minifier script `npm run svgmin` and unify SVGO rules to Wikimedia coding conventions [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T245296) (owner: 10Aron Manning) [16:45:32] (03PS18) 10Jdlrobson: Add SVG minifier script `npm run svgmin` and unify SVGO rules to Wikimedia coding conventions [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T245296) (owner: 10Aron Manning) [16:46:10] (03CR) 10Shizhao: [C: 03+1] [IMPR] Should request category check (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577188 (owner: 10Shizhao) [16:46:17] (03CR) 10Jdlrobson: "PS18 fixes the order of commands." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T245296) (owner: 10Aron Manning) [16:48:05] (03CR) 10Jdlrobson: [C: 04-1] Add SVG minifier script `npm run svgmin` and unify SVGO rules to Wikimedia coding conventions (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T245296) (owner: 10Aron Manning) [16:53:45] (03PS3) 10Jdlrobson: Separate scripts `npm test` and `npm run build`: 'test' won't build documentation [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (owner: 10Aron Manning) [16:53:49] (03CR) 10jerkins-bot: [V: 04-1] Add linting *.json to script 'npm run lint:js' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576534 (owner: 10Aron Manning) [16:54:58] (03CR) 10Aron Manning: "I'll fix the whole chain, as usual. Thanks for spending time to review." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (owner: 10Aron Manning) [16:57:27] (03CR) 10VolkerE: [C: 04-1] "We try to stay away from abbreviations, that are not very common and widely used. As using them would make it (even) harder for newcomers " [skins/Vector] - 10https://gerrit.wikimedia.org/r/576535 (owner: 10Aron Manning) [17:00:52] (03CR) 10Aron Manning: Separate scripts `npm test` and `npm run build`: 'test' won't build documentation (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (owner: 10Aron Manning) [17:07:00] (03CR) 10Aron Manning: Port 'storybook' scripts to windows, merge 'jsdoc' into 'doc' (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [17:07:13] (03CR) 10jerkins-bot: [V: 04-1] Separate scripts `npm test` and `npm run build`: 'test' won't build documentation [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (owner: 10Aron Manning) [17:18:12] (03PS1) 10Shizhao: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/pywikibot/core into review/shizhao/flickr [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577300 [17:21:04] (03PS2) 10Shizhao: fix 577188 Merge Conflict [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577300 [17:26:19] (03CR) 10Aron Manning: Add SVG minifier script `npm run svgmin` and unify SVGO rules to Wikimedia coding conventions (033 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T245296) (owner: 10Aron Manning) [17:28:38] (03PS4) 10Xqt: [IMPR] Simplify code [pywikibot/core] - 10https://gerrit.wikimedia.org/r/576633 [17:30:22] (03CR) 10Xqt: "No idea what this means" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577300 (owner: 10Shizhao) [17:32:50] (03CR) 10Xqt: "Rebase this patch to master du to merge conflict." (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577188 (owner: 10Shizhao) [17:35:14] (03PS4) 10Xqt: [IMPR] Should request category check [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577188 (owner: 10Shizhao) [17:35:42] (03CR) 10Jdlrobson: [C: 04-1] Add SVG minifier script `npm run svgmin` and unify SVGO rules to Wikimedia coding conventions (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T245296) (owner: 10Aron Manning) [17:36:31] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577188 (owner: 10Shizhao) [17:36:38] (03CR) 10Xqt: [C: 03+1] [IMPR] Should request category check [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577188 (owner: 10Shizhao) [17:36:42] (03CR) 10Aron Manning: "Thank you for paying attention to this and writing a response within minutes. May I have your attention in the many patches that conclude " (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576535 (owner: 10Aron Manning) [17:36:55] (03Abandoned) 10Xqt: fix 577188 Merge Conflict [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577300 (owner: 10Shizhao) [17:37:38] (03CR) 10Jdlrobson: [C: 04-2] Separate scripts `npm test` and `npm run build`: 'test' won't build documentation (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (owner: 10Aron Manning) [17:38:07] (03PS4) 10Jdlrobson: Separate scripts `npm test` and `npm run build`: 'test' won't build documentation [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (owner: 10Aron Manning) [17:40:15] (03CR) 10Jdlrobson: [C: 04-1] "Ok looks like stuff has changed in releng land. Once I've chatted to James F and confirmed this is expected I will merge later today." [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (owner: 10Aron Manning) [17:42:47] (03PS5) 10Shizhao: [IMPR] Should request category check [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577188 [17:43:47] (03CR) 10VolkerE: [C: 04-1] "This patch is nowhere connected to https://phabricator.wikimedia.org/T245296." [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 (https://phabricator.wikimedia.org/T245296) (owner: 10Aron Manning) [17:47:52] (03CR) 10VolkerE: [C: 04-1] "Please explain why 'styles' would be “very bad”? Stylesheets contain styles and we a) go for overarching multiple Foundation project rules" [skins/Vector] - 10https://gerrit.wikimedia.org/r/576535 (owner: 10Aron Manning) [17:48:15] (03PS7) 10Jdlrobson: Port 'storybook' scripts to windows, merge 'jsdoc' into 'doc' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [17:50:46] (03CR) 10Jdlrobson: [C: 03+2] Port 'storybook' scripts to windows, merge 'jsdoc' into 'doc' (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [18:04:03] (03CR) 10Aron Manning: "Thanks for the merge, anyway!" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [18:11:28] (03CR) 10Jdlrobson: [C: 03+1] Port 'storybook' scripts to windows, merge 'jsdoc' into 'doc' (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [18:11:32] (03Merged) 10jenkins-bot: Port 'storybook' scripts to windows, merge 'jsdoc' into 'doc' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [18:13:26] 10Pywikibot, 10Continuous-Integration-Config, 10Pywikibot-tests: Jenkins output for pywikibot job is hard to read - https://phabricator.wikimedia.org/T117570 (10Dvorapa) 05Resolved→03Open I don't think so, it is similar to the example in description [18:14:26] (03CR) 10Aron Manning: Add linting *.json to script 'npm run lint:js' (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576534 (owner: 10Aron Manning) [18:15:44] (03CR) 10Jdlrobson: [C: 04-2] "lint:styles makes the most sense here. We lint CSS and LESS." [skins/Vector] - 10https://gerrit.wikimedia.org/r/576535 (owner: 10Aron Manning) [19:01:17] (03CR) 10Jdlrobson: [C: 04-1] Add script `npm run lint:fix` to fix trivial lint errors (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (owner: 10Aron Manning) [19:38:20] (03CR) 10Aron Manning: Add script `npm run lint:fix` to fix trivial lint errors (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (owner: 10Aron Manning) [19:47:11] (03CR) 10Polishdeveloper: [C: 03+2] featureManager: Add typehints [skins/Vector] - 10https://gerrit.wikimedia.org/r/576123 (https://phabricator.wikimedia.org/T244481) (owner: 10Phuedx) [19:47:51] (03CR) 10Jdlrobson: [C: 04-1] "> Actually, I've already documented what you need:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (owner: 10Aron Manning) [20:03:53] (03CR) 10Nray: "> We will likely want to update how we import CSS as well so that" [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [21:49:46] (03CR) 10Nray: WIP: Introduce "children" prop to Sidebar Component and the ITemplate Interface (033 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/575779 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [22:18:05] (03PS15) 10Aron Manning: Add script 'npm run lint:fix' to fix trivial lint errors [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T247004) [22:18:09] (03PS5) 10Aron Manning: Separate scripts `npm test` and `npm run build`: 'test' won't build documentation [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (https://phabricator.wikimedia.org/T247004) [22:18:15] (03PS3) 10Aron Manning: Add necessary devdependency 'eslint', remove not-explicitly-necessary 'stylelint' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576472 (https://phabricator.wikimedia.org/T247004) [22:18:21] (03PS1) 10Aron Manning: Add script 'npm run lint:fix:js' and 'lint:fix:styles', remove 'lint:fix' [skins/Vector] - 10https://gerrit.wikimedia.org/r/577359 (https://phabricator.wikimedia.org/T247004) [22:44:05] (03CR) 10Xqt: [C: 03+1] [IMPR] Should request category check (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/577188 (owner: 10Shizhao) [22:45:56] 10Pywikibot, 10Continuous-Integration-Config, 10Pywikibot-tests: Jenkins output for pywikibot job is hard to read - https://phabricator.wikimedia.org/T117570 (10Xqt) a:05Xqt→03None [22:49:25] (03CR) 10Aron Manning: Port 'storybook' scripts to windows, merge 'jsdoc' into 'doc' (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/576471 (owner: 10Aron Manning) [23:10:41] (03CR) 10Jdlrobson: [C: 03+2] Add script 'npm run lint:fix' to fix trivial lint errors [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [23:13:20] (03CR) 10Aron Manning: "> I don't need this. I do not maintain MultimediaViewer." [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [23:13:56] (03CR) 10Aron Manning: "This change is ready for review." [skins/Vector] - 10https://gerrit.wikimedia.org/r/577359 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [23:23:44] (03Merged) 10jenkins-bot: Add script 'npm run lint:fix' to fix trivial lint errors [skins/Vector] - 10https://gerrit.wikimedia.org/r/575809 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [23:29:16] (03PS19) 10Aron Manning: Add SVG minifier script `npm run svgmin` and unify SVGO rules to Wikimedia coding conventions [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T247004) [23:29:20] (03PS16) 10Aron Manning: Run SVG minifier in Vector skin [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 (https://phabricator.wikimedia.org/T178867) [23:33:00] (03CR) 10Jdlrobson: "As I mentioned on https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/575809/ I probably won't use this but if somebody else think" [skins/Vector] - 10https://gerrit.wikimedia.org/r/577359 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [23:35:51] (03CR) 10Jdlrobson: [C: 03+2] "checked in with James" [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [23:36:32] (03PS6) 10Aron Manning: Separate scripts `npm test` and `npm run build`, remove `npm run doc` from `test` [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (https://phabricator.wikimedia.org/T247004) [23:36:36] (03PS4) 10Aron Manning: Add necessary devdependency 'eslint', remove not-explicitly-necessary 'stylelint' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576472 (https://phabricator.wikimedia.org/T247004) [23:36:40] (03PS20) 10Aron Manning: Add SVG minifier script `npm run svgmin` and unify SVGO rules to Wikimedia coding conventions [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T247004) [23:36:44] (03PS17) 10Aron Manning: Run SVG minifier in Vector skin [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 (https://phabricator.wikimedia.org/T178867) [23:37:25] (03CR) 10Aron Manning: "Thank you for your help, feedback and the previous merge." [skins/Vector] - 10https://gerrit.wikimedia.org/r/577359 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [23:42:25] (03CR) 10Aron Manning: "I've rebased this on master and extended the commit comment as you asked." [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [23:43:43] (03PS8) 10Jdlrobson: Separate scripts `npm test` and `npm run build`, remove `npm run doc` from `test` [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [23:43:57] (03CR) 10Jdlrobson: [C: 03+2] Separate scripts `npm test` and `npm run build`, remove `npm run doc` from `test` [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [23:44:14] (03CR) 10jerkins-bot: [V: 04-1] Add SVG minifier script `npm run svgmin` and unify SVGO rules to Wikimedia coding conventions [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [23:45:08] (03CR) 10Aron Manning: "> checked in with James" [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [23:57:34] (03Merged) 10jenkins-bot: Separate scripts `npm test` and `npm run build`, remove `npm run doc` from `test` [skins/Vector] - 10https://gerrit.wikimedia.org/r/576533 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [23:57:46] (03CR) 10jerkins-bot: [V: 04-1] Run SVG minifier in Vector skin [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 (https://phabricator.wikimedia.org/T178867) (owner: 10Aron Manning)