[00:08:59] (03CR) 10Jdlrobson: Refactor: DRY up menu creation! (033 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:12:17] (03PS14) 10Jdlrobson: Refactor: DRY up menu creation! [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) [00:12:21] (03PS13) 10Jdlrobson: Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [00:12:53] (03PS15) 10Jdlrobson: Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) [00:13:09] (03Abandoned) 10Jdlrobson: POC: Use `when` to separate legacy and modern styles [skins/Vector] - 10https://gerrit.wikimedia.org/r/589119 (owner: 10Jdlrobson) [00:15:14] (03CR) 10Polishdeveloper: Add opt-out link to Sidebar for Vector/Logged-in Users With Abstractions (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/579293 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [00:16:52] (03PS5) 10Jdlrobson: Bump Vector depends to to 1.35.0 [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [00:16:56] (03PS1) 10Jdlrobson: Fix Special:Preferences sub section link [skins/Vector] - 10https://gerrit.wikimedia.org/r/589161 (https://phabricator.wikimedia.org/T248644) [00:18:07] (03CR) 10Aron Manning: [legacy] Split sidebar code and mark layout as legacy in preparation for new layout (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/588461 (https://phabricator.wikimedia.org/T246170) (owner: 10Jdlrobson) [00:19:31] (03CR) 10Polishdeveloper: Refactor: DRY up menu creation! (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:20:56] (03CR) 10Jdlrobson: [C: 04-1] "As outlined I don't believe this is a blocker." [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [00:21:07] (03CR) 10Jdlrobson: [C: 03+1] "This is blocked on reaching consensus on https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/589071 but looks good to me." [skins/Vector] - 10https://gerrit.wikimedia.org/r/589161 (https://phabricator.wikimedia.org/T248644) (owner: 10Jdlrobson) [00:26:05] (03CR) 10jerkins-bot: [V: 04-1] Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:26:21] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:26:28] (03CR) 10jerkins-bot: [V: 04-1] Refactor: DRY up menu creation! [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:28:46] (03CR) 10Jdlrobson: [C: 04-1] "Will take another look at this tomorrow when my mind is more fresh :)" [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:35:50] (03CR) 10Jforrester: "> Patch Set 5: Code-Review-1" [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [00:53:47] (03CR) 10Jdlrobson: [C: 04-1] "> Patch Set 5:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [07:28:06] (03CR) 10Aron Manning: Organize CSS by base, layout and components (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [08:25:07] 10Pywikibot, 10Pywikibot-archivebot.py: Archiving breaks links - https://phabricator.wikimedia.org/T250340 (10Majavah) [12:56:48] (03CR) 10Polishdeveloper: "@Jforrester - I think that the idea is to keep the skin.json values in sync with MediaWiki version." [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [15:34:48] (03CR) 10Jforrester: "> Patch Set 5:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [16:00:03] (03CR) 10Jdlrobson: Organize CSS by base, layout and components (0310 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [17:48:53] (03PS6) 10Jdlrobson: Bump Vector to depend on MediaWiki 1.35.0 [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [17:48:58] (03CR) 10Jdlrobson: [C: 03+1] Bump Vector to depend on MediaWiki 1.35.0 [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [17:49:06] (03PS2) 10Jdlrobson: Fix Special:Preferences sub section link [skins/Vector] - 10https://gerrit.wikimedia.org/r/589161 (https://phabricator.wikimedia.org/T248644) [17:49:10] (03CR) 10Jdlrobson: [C: 03+2] Fix Special:Preferences sub section link [skins/Vector] - 10https://gerrit.wikimedia.org/r/589161 (https://phabricator.wikimedia.org/T248644) (owner: 10Jdlrobson) [17:52:38] (03CR) 10VolkerE: [C: 03+1] Bump Vector to depend on MediaWiki 1.35.0 [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [18:01:33] (03PS11) 10Jdlrobson: [legacy] Split sidebar code and mark layout as legacy in preparation for new layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/588461 (https://phabricator.wikimedia.org/T246170) [18:01:40] (03CR) 10Jdlrobson: [legacy] Split sidebar code and mark layout as legacy in preparation for new layout (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/588461 (https://phabricator.wikimedia.org/T246170) (owner: 10Jdlrobson) [18:12:46] (03CR) 10jerkins-bot: [V: 04-1] [legacy] Split sidebar code and mark layout as legacy in preparation for new layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/588461 (https://phabricator.wikimedia.org/T246170) (owner: 10Jdlrobson) [18:21:32] (03CR) 10Jforrester: [C: 03+2] Bump Vector to depend on MediaWiki 1.35.0 [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [18:22:27] (03PS15) 10Jdlrobson: Refactor: DRY up menu creation! [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) [18:23:53] (03PS14) 10Jdlrobson: Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [18:23:57] (03PS16) 10Jdlrobson: Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) [18:29:17] (03PS12) 10Jdlrobson: [legacy] Split sidebar code and mark layout as legacy in preparation for new layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/588461 (https://phabricator.wikimedia.org/T246170) [18:34:14] (03CR) 10jerkins-bot: [V: 04-1] Bump Vector to depend on MediaWiki 1.35.0 [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [18:34:18] (03CR) 10jerkins-bot: [V: 04-1] Fix Special:Preferences sub section link [skins/Vector] - 10https://gerrit.wikimedia.org/r/589161 (https://phabricator.wikimedia.org/T248644) (owner: 10Jdlrobson) [18:36:18] (03PS7) 10Jdlrobson: Bump Vector to depend on MediaWiki 1.35.0 [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [18:36:25] (03CR) 10Jdlrobson: [C: 03+2] Bump Vector to depend on MediaWiki 1.35.0 [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [18:36:37] (03PS17) 10Jdlrobson: Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) [18:42:13] (03PS1) 10Jdlrobson: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 [18:42:46] (03PS2) 10Jdlrobson: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 [18:48:38] (03CR) 10jerkins-bot: [V: 04-1] Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 (owner: 10Jdlrobson) [18:53:23] (03Merged) 10jenkins-bot: Bump Vector to depend on MediaWiki 1.35.0 [skins/Vector] - 10https://gerrit.wikimedia.org/r/589071 (owner: 10VolkerE) [18:56:28] (03PS3) 10Jdlrobson: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 [18:58:00] (03CR) 10VolkerE: [C: 04-1] Organize CSS by base, layout and components (033 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [19:08:20] (03CR) 10jerkins-bot: [V: 04-1] Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 (owner: 10Jdlrobson) [20:08:06] (03CR) 10Aron Manning: "The benefits of a 'base' folder is still not clear and hasn't been mentioned on T249073. You've said something about summarizing slack dis" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [20:08:55] (03CR) 10Aron Manning: Refactor: Portal is also a Menu (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [20:09:21] (03CR) 10Aron Manning: "See https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/587536/17/includes/VectorTemplate.php#45" [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [20:23:07] (03CR) 10Nray: [C: 03+2] [legacy] Split sidebar code and mark layout as legacy in preparation for new layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/588461 (https://phabricator.wikimedia.org/T246170) (owner: 10Jdlrobson) [20:24:05] (03CR) 10Aron Manning: [legacy] Split sidebar code and mark layout as legacy in preparation for new layout (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/588461 (https://phabricator.wikimedia.org/T246170) (owner: 10Jdlrobson) [20:27:12] (03CR) 10Aron Manning: [WIP] [feature] add collapsible sidebar toggle (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [20:31:46] (03CR) 10Aron Manning: Organize CSS by base, layout and components (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [20:39:09] (03Merged) 10jenkins-bot: [legacy] Split sidebar code and mark layout as legacy in preparation for new layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/588461 (https://phabricator.wikimedia.org/T246170) (owner: 10Jdlrobson) [20:47:46] (03PS16) 10Jdlrobson: Refactor: DRY up menu creation! [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) [20:50:28] (03CR) 10Jdlrobson: Refactor: DRY up menu creation! (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [20:53:05] (03PS15) 10Jdlrobson: Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [21:05:52] (03PS18) 10Jdlrobson: Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) [21:05:56] (03PS4) 10Jdlrobson: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 [21:21:04] (03CR) 10Aron Manning: "What's the meaning of "default" in MenuDefault? It confused me, big time..." [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [21:46:57] (03PS13) 10Aron Manning: Add Header element and styles to new Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/585367 (https://phabricator.wikimedia.org/T246170) [21:47:01] (03PS1) 10Aron Manning: [cleanup] Move up `.portal` underline gradient from `.body` to `h3` [skins/Vector] - 10https://gerrit.wikimedia.org/r/589433 [21:50:30] (03PS11) 10Niedzielski: [fix] [config] Remove "existing account only" skin version config [skins/Vector] - 10https://gerrit.wikimedia.org/r/585302 [21:50:34] (03PS17) 10Niedzielski: [WIP] [feature] add collapsible sidebar toggle [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) [21:50:47] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [feature] add collapsible sidebar toggle [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [21:50:56] (03CR) 10Niedzielski: [C: 04-1] [fix] [config] Remove "existing account only" skin version config [skins/Vector] - 10https://gerrit.wikimedia.org/r/585302 (owner: 10Niedzielski) [21:59:40] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Move up `.portal` underline gradient from `.body` to `h3` [skins/Vector] - 10https://gerrit.wikimedia.org/r/589433 (owner: 10Aron Manning) [22:00:28] (03CR) 10jerkins-bot: [V: 04-1] Add Header element and styles to new Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/585367 (https://phabricator.wikimedia.org/T246170) (owner: 10Aron Manning) [23:52:33] (03PS10) 10Jdlrobson: WIP: [modern] A new version of Vector with a new logo [skins/Vector] - 10https://gerrit.wikimedia.org/r/577682 (https://phabricator.wikimedia.org/T246170) [23:52:37] (03PS1) 10Jdlrobson: [Refactor] Move footer layout rules to layout.less [skins/Vector] - 10https://gerrit.wikimedia.org/r/589451 [23:59:02] (03CR) 10Jdlrobson: "> What's the meaning of "default" in MenuDefault? It confused me, big time..." [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [23:59:17] (03CR) 10Nray: [C: 03+1] "I'll merge tomorrow if no else has by then (I'm about to take off for the day)" [skins/Vector] - 10https://gerrit.wikimedia.org/r/589451 (owner: 10Jdlrobson)