[00:11:42] (03CR) 10VolkerE: [C: 04-1] "Looks good, only the nitpick of Jon should be accomplished" [skins/Vector] - 10https://gerrit.wikimedia.org/r/594331 (https://phabricator.wikimedia.org/T250093) (owner: 10Nray) [01:06:54] (03CR) 10Samwilson: "A couple of tiny things." (031 comment) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/594259 (owner: 10Yaron Koren) [02:28:49] (03PS1) 10Yaron Koren: Add use of Database::selectRowCount() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/594341 [02:31:40] (03PS2) 10Yaron Koren: Add use of Database::selectRowCount() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/594341 [03:24:15] (03CR) 10Yaron Koren: [C: 03+2] Add use of Database::selectRowCount() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/594341 (owner: 10Yaron Koren) [03:27:25] (03Merged) 10jenkins-bot: Add use of Database::selectRowCount() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/594341 (owner: 10Yaron Koren) [03:27:58] (03CR) 10VolkerE: [dev][JavaScript] allow clients to be versioned (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593881 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [04:00:10] (03CR) 10Yaron Koren: [C: 03+2] "@Samwilson - thanks for letting me know about that. I don't think I knew about selectRowCount()... I just checked in a patch that adds it " [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/594259 (owner: 10Yaron Koren) [05:03:16] (03CR) 10Samwilson: "> Patch Set 3:" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/594259 (owner: 10Yaron Koren) [06:57:02] (03CR) 10Xqt: "Another way is to run the tests locally with Python 2.7.18." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594106 (https://phabricator.wikimedia.org/T213287) (owner: 10Xqt) [13:36:15] (03CR) 10Niedzielski: [dev][JavaScript] allow clients to be versioned (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593881 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [13:36:58] (03PS1) 10Xqt: [cleanup] Always use mwparserfromhell if present [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594478 [13:39:49] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Always use mwparserfromhell if present [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594478 (owner: 10Xqt) [14:07:49] (03PS2) 10Xqt: [cleanup] Always use mwparserfromhell if present [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594478 [14:10:42] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Always use mwparserfromhell if present [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594478 (owner: 10Xqt) [14:16:05] (03PS3) 10Xqt: [cleanup] Always use mwparserfromhell if present [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594478 [14:19:00] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Always use mwparserfromhell if present [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594478 (owner: 10Xqt) [14:26:51] (03PS4) 10Xqt: [cleanup] Always use mwparserfromhell if present [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594478 [15:52:36] (03PS2) 10Nray: Add title attribute to opt-out link [skins/Vector] - 10https://gerrit.wikimedia.org/r/594331 (https://phabricator.wikimedia.org/T250093) [15:53:25] (03CR) 10Nray: "New patch made requested changes" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/594331 (https://phabricator.wikimedia.org/T250093) (owner: 10Nray) [16:38:55] 10Pywikibot, 10Gerrit-Privilege-Requests, 10Release-Engineering-Team, 10Pywikibot-tests: Grant Pywikibot-gerritbot an access to Gerrit stream (stream-events group) - https://phabricator.wikimedia.org/T248262 (10Urbanecm) >>! In T248262#6083047, @Legoktm wrote: > Approved from my perspective. @Dvorapa can y... [16:59:08] (03PS1) 10Xqt: [IMPR] Faster lookup for write actions [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594524 [17:29:46] (03CR) 10Niedzielski: [C: 03+1] Add title attribute to opt-out link [skins/Vector] - 10https://gerrit.wikimedia.org/r/594331 (https://phabricator.wikimedia.org/T250093) (owner: 10Nray) [17:31:25] (03PS18) 10Jdlrobson: Organize CSS by base, layout and components [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) [17:31:40] (03CR) 10Jdlrobson: [C: 03+2] Add title attribute to opt-out link [skins/Vector] - 10https://gerrit.wikimedia.org/r/594331 (https://phabricator.wikimedia.org/T250093) (owner: 10Nray) [17:47:07] (03Merged) 10jenkins-bot: Add title attribute to opt-out link [skins/Vector] - 10https://gerrit.wikimedia.org/r/594331 (https://phabricator.wikimedia.org/T250093) (owner: 10Nray) [17:54:25] (03PS35) 10Niedzielski: [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) [17:56:45] 10Africa-Wikimedia-Developers, 10Outreach-Programs-Projects, 10Technical-Tool-Request, 10Google-Summer-of-Code (2020): Design and Develop a tool to correct false depicts claims manually on Wikimedia Commons - https://phabricator.wikimedia.org/T245758 (10Pavithraes) [17:59:53] (03PS1) 10DC Slagel: [IMPR] Add to docs in scripts/data_ingestion.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594535 (https://phabricator.wikimedia.org/T250636) [18:02:57] (03PS1) 10Yaron Koren: Only show drilldown column in Special:CargoTables if user is allowed [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/594537 [18:08:39] (03PS2) 10Yaron Koren: Only show drilldown column in Special:CargoTables if user is allowed [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/594537 [18:10:10] (03CR) 10jerkins-bot: [V: 04-1] [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [18:12:32] (03CR) 10DC Slagel: "Hi this is an initial attempt to add detail to the documentation for pywikibot/scripts/data_ingestion.py." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594535 (https://phabricator.wikimedia.org/T250636) (owner: 10DC Slagel) [18:30:38] 10Africa-Wikimedia-Developers, 10Outreach-Programs-Projects, 10Technical-Tool-Request, 10Google-Summer-of-Code (2020): Design and Develop a tool to correct false depicts claims manually on Wikimedia Commons - https://phabricator.wikimedia.org/T245758 (10Pavithraes) [18:37:58] 10Africa-Wikimedia-Developers, 10Outreach-Programs-Projects, 10Technical-Tool-Request, 10Google-Summer-of-Code (2020): Design and Develop a tool to correct false depicts claims manually on Wikimedia Commons - https://phabricator.wikimedia.org/T245758 (10Pavithraes) [18:44:08] 10Africa-Wikimedia-Developers, 10Outreach-Programs-Projects, 10Technical-Tool-Request, 10Google-Summer-of-Code (2020): Design and Develop a tool to correct false depicts claims manually on Wikimedia Commons - https://phabricator.wikimedia.org/T245758 (10Pavithraes) [18:51:50] (03CR) 10Jdlrobson: [feature] add menu button to toggle panel visibility (036 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [18:57:32] 10Africa-Wikimedia-Developers, 10Outreach-Programs-Projects, 10Technical-Tool-Request, 10Google-Summer-of-Code (2020): Design and Develop a tool to correct false depicts claims manually on Wikimedia Commons - https://phabricator.wikimedia.org/T245758 (10Pavithraes) [19:00:38] 10Africa-Wikimedia-Developers, 10Outreach-Programs-Projects, 10Technical-Tool-Request, 10Google-Summer-of-Code (2020): Design and Develop a tool to correct false depicts claims manually on Wikimedia Commons - https://phabricator.wikimedia.org/T245758 (10Pavithraes) [19:03:18] 10Africa-Wikimedia-Developers, 10Outreach-Programs-Projects, 10Technical-Tool-Request, 10Google-Summer-of-Code (2020): Design and Develop a tool to correct false depicts claims manually on Wikimedia Commons - https://phabricator.wikimedia.org/T245758 (10Pavithraes) [19:23:29] (03CR) 10Nray: [C: 04-1] "Looks good, just had a couple questions" (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593020 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:28:23] (03PS10) 10Jdlrobson: Refactor: Remove indirection (where alternatives exist) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593020 (https://phabricator.wikimedia.org/T251212) [19:28:29] (03CR) 10Jdlrobson: Refactor: Remove indirection (where alternatives exist) (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593020 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:28:39] (03PS33) 10Jdlrobson: Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [19:34:13] (03CR) 10Nray: [C: 04-1] Refactor: Remove indirection (where alternatives exist) (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593020 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:35:23] (03CR) 10Yaron Koren: [C: 03+2] Only show drilldown column in Special:CargoTables if user is allowed [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/594537 (owner: 10Yaron Koren) [19:38:37] (03Merged) 10jenkins-bot: Only show drilldown column in Special:CargoTables if user is allowed [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/594537 (owner: 10Yaron Koren) [19:42:26] (03CR) 10jerkins-bot: [V: 04-1] Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [19:43:11] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Remove indirection (where alternatives exist) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593020 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:47:33] (03CR) 10Xqt: "Thanks a lot for your work. Please remove the i18n file from committing" (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594535 (https://phabricator.wikimedia.org/T250636) (owner: 10DC Slagel) [20:07:36] (03PS11) 10Jdlrobson: Refactor: Remove indirection (where alternatives exist) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593020 (https://phabricator.wikimedia.org/T251212) [20:08:11] (03CR) 10Jdlrobson: Refactor: Remove indirection (where alternatives exist) (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593020 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [20:09:19] (03PS2) 10DC Slagel: [IMPR] Add to docs in scripts/data_ingestion.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594535 (https://phabricator.wikimedia.org/T250636) [20:11:19] (03CR) 10DC Slagel: "Hi Xqt," (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594535 (https://phabricator.wikimedia.org/T250636) (owner: 10DC Slagel) [20:17:27] (03PS34) 10Jdlrobson: Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [20:20:08] (03CR) 10Nray: [C: 03+2] Refactor: Remove indirection (where alternatives exist) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593020 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [20:34:04] (03Merged) 10jenkins-bot: Refactor: Remove indirection (where alternatives exist) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593020 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [21:16:37] (03CR) 10Dvorapa: "$ python -m timeit "1 in {1,2,3}"" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594524 (owner: 10Xqt) [21:26:57] (03PS35) 10Jdlrobson: Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [21:27:01] (03PS32) 10Jdlrobson: Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) [21:27:06] (03PS18) 10Jdlrobson: Refactor: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 (https://phabricator.wikimedia.org/T249372) [21:41:57] (03CR) 10jerkins-bot: [V: 04-1] Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [21:42:57] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [21:43:05] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [22:28:59] (03CR) 10Jdlrobson: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [22:46:03] (03CR) 10Jdlrobson: [C: 04-1] "I say if you plan to upstream it, be bold and do it now." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593881 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [22:56:09] (03CR) 10Jdlrobson: [C: 04-1] "I don't want to add the legacy breakpoints to Vector given we will soon be introducing a fixed width and this is all going to change." [skins/Vector] - 10https://gerrit.wikimedia.org/r/593954 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [23:50:44] (03CR) 10Nray: [C: 04-1] Refactor: One menu template to rule them all (037 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson)