[00:01:13] (03PS36) 10Jdlrobson: Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [00:01:17] (03PS1) 10Jdlrobson: Generalise personal menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/594601 (https://phabricator.wikimedia.org/T249372) [00:03:46] (03PS37) 10Jdlrobson: Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [00:04:35] (03PS2) 10Jdlrobson: Refactor: Generalise personal menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/594601 (https://phabricator.wikimedia.org/T249372) [00:05:51] (03PS3) 10Jdlrobson: Refactor: Generalise personal menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/594601 (https://phabricator.wikimedia.org/T249372) [00:07:13] (03CR) 10Jdlrobson: Refactor: Generalise personal menu (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/594601 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:09:33] (03PS38) 10Jdlrobson: Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [00:09:37] (03PS33) 10Jdlrobson: Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) [00:09:41] (03PS19) 10Jdlrobson: Refactor: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 (https://phabricator.wikimedia.org/T249372) [00:10:37] (03CR) 10Jdlrobson: "Nick: I decided this patch was too hard to follow so I pulled out https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/594601/3 whi" [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:12:00] (03CR) 10Jdlrobson: Refactor: One menu template to rule them all (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:12:35] (03CR) 10Jdlrobson: [C: 04-1] "Will break out the tabs changes and dropdown changes into separate patchsets." [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:13:16] (03CR) 10Jdlrobson: Refactor: One menu template to rule them all (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:16:16] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Generalise personal menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/594601 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:16:21] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Generalise personal menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/594601 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:32:33] (03CR) 10Jdlrobson: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/594601 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [00:34:51] (03PS4) 10Jdlrobson: Refactor: Generalise personal menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/594601 (https://phabricator.wikimedia.org/T249372) [00:34:55] (03PS39) 10Jdlrobson: Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [00:34:59] (03PS34) 10Jdlrobson: Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) [00:35:03] (03PS20) 10Jdlrobson: Refactor: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 (https://phabricator.wikimedia.org/T249372) [01:33:37] (03PS5) 10Yaron Koren: Add icalendar export format [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/589825 (https://phabricator.wikimedia.org/T250547) (owner: 10Samwilson) [03:06:52] (03CR) 10Niedzielski: [dev][JavaScript] allow clients to be versioned (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593881 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [04:09:15] (03CR) 10Xqt: "There is no difference if there are only a few items in the tuple. And try the worst case because you can always find the first item in a " [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594524 (owner: 10Xqt) [04:11:15] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594535 (https://phabricator.wikimedia.org/T250636) (owner: 10DC Slagel) [04:14:08] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Add to docs in scripts/data_ingestion.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594535 (https://phabricator.wikimedia.org/T250636) (owner: 10DC Slagel) [04:29:10] (03CR) 10Aron Manning: "Very clean code!" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [04:36:07] (03CR) 10Aron Manning: "I don't want to, either." [skins/Vector] - 10https://gerrit.wikimedia.org/r/593954 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [05:35:03] (03CR) 10Aron Manning: "Sure. As I see you've already done 1) when rebasing the parent patch." [skins/Vector] - 10https://gerrit.wikimedia.org/r/593647 (https://phabricator.wikimedia.org/T251583) (owner: 10Aron Manning) [05:45:25] (03PS2) 10Aron Manning: [modern] Drop the background gradient [skins/Vector] - 10https://gerrit.wikimedia.org/r/593647 (https://phabricator.wikimedia.org/T251583) [05:49:35] (03CR) 10Xqt: "There are some other lines which exceed the 80 chars limit" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594535 (https://phabricator.wikimedia.org/T250636) (owner: 10DC Slagel) [11:27:19] (03CR) 10Jdrewniak: [C: 03+1] "Asides from what I learned about loading print styles (comment below), looks good to me." (033 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [11:34:49] (03CR) 10Matěj Suchánek: [C: 03+1] "No brainer." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594524 (owner: 10Xqt) [14:58:52] (03PS3) 10DC Slagel: [IMPR] Add to docs in scripts/data_ingestion.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594535 (https://phabricator.wikimedia.org/T250636) [15:00:30] (03CR) 10DC Slagel: "Corrected all lines over 80 chars, and adjusted some formating to be standard with other scripts." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/594535 (https://phabricator.wikimedia.org/T250636) (owner: 10DC Slagel) [16:26:49] (03PS19) 10Jdlrobson: Organize CSS by base, layout and components [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) [16:30:54] (03CR) 10Esanders: Add CSS class on body to mark the skin version (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593955 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [16:44:20] (03CR) 10Aron Manning: Add CSS class on body to mark the skin version (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593955 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [16:52:38] 10Pywikibot, 10Proposal, 10Pywikibot-RfCs, 10covid-19: RFC: Sharing templates and modules between wikis - poor man's version (investigation) - https://phabricator.wikimedia.org/T122086 (10Dvorapa) >>! In T122086#6088917, @Tgr wrote: > It seems the bot stopped working in 2019 May. [[https://www.mediawiki.or... [17:24:13] (03PS1) 10Jdlrobson: Refactor: Merge VectorTabs into Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/594761 (https://phabricator.wikimedia.org/T249372) [17:31:01] (03PS40) 10Jdlrobson: Refactor: VectorMenu merged in to Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [17:31:05] (03PS35) 10Jdlrobson: Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) [18:39:59] (03PS36) 10Jdlrobson: Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) [18:40:03] (03PS21) 10Jdlrobson: Refactor: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 (https://phabricator.wikimedia.org/T249372) [20:03:09] (03CR) 10Bartosz Dziewoński: Add CSS class on body to mark the skin version (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593955 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [20:07:33] (03PS4) 10Bartosz Dziewoński: Add CSS class on body to mark the skin version [skins/Vector] - 10https://gerrit.wikimedia.org/r/593955 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [20:08:22] (03CR) 10Bartosz Dziewoński: [C: 03+2] "This will work for us in VE, and it looks like the Reading team is also fine with it, so let's get it in. It's extremely annoying to have " [skins/Vector] - 10https://gerrit.wikimedia.org/r/593955 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [20:08:57] (03Abandoned) 10Bartosz Dziewoński: [modern] Temporarily restore the #content (.mw-body) padding for VisualEditor's alignment [skins/Vector] - 10https://gerrit.wikimedia.org/r/593954 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [20:15:41] (03CR) 10VolkerE: [C: 04-1] "Sorry to break here, but could we quickly have a conversation about the class naming. -1 & -2 vs -legacy & -modern. It's the first time th" [skins/Vector] - 10https://gerrit.wikimedia.org/r/593955 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [20:19:15] (03CR) 10Bartosz Dziewoński: "We should not name anything "modern", because whatever name you choose will still be in use 20 years from now. In particular, we should no" [skins/Vector] - 10https://gerrit.wikimedia.org/r/593955 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [20:22:13] (03CR) 10Jdlrobson: "We refer to modern in commit messages but not code." [skins/Vector] - 10https://gerrit.wikimedia.org/r/593955 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [20:23:38] (03CR) 10Jdlrobson: Add CSS class on body to mark the skin version (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593955 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [20:33:30] (03CR) 10VolkerE: [C: 04-1] "@Bartosz And how would anybody just glancing through know what -1 and -2 stands for." [skins/Vector] - 10https://gerrit.wikimedia.org/r/593955 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [20:44:56] (03CR) 10Bartosz Dziewoński: "I mean, I'm not particularly attached to these names, go with that if you want." [skins/Vector] - 10https://gerrit.wikimedia.org/r/593955 (https://phabricator.wikimedia.org/T251648) (owner: 10Aron Manning) [20:47:17] (03CR) 10VolkerE: [C: 04-1] Organize CSS by base, layout and components (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [20:50:58] (03CR) 10VolkerE: [C: 04-1] "I hope we're not seeing more grade-c.less contents, had the same discussion back then with Krinkle, he wanted to have a more general name." [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [21:23:39] (03CR) 10Jdlrobson: "> Also, why WatchstarTab.less instead of Watchstar?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [21:24:18] (03CR) 10Jdlrobson: Organize CSS by base, layout and components (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [22:16:40] (03CR) 10Jdlrobson: [C: 04-1] [dev][JavaScript] allow clients to be versioned (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593881 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [22:17:04] (03CR) 10Nray: [C: 03+2] Refactor: Generalise personal menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/594601 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [22:31:13] (03Merged) 10jenkins-bot: Refactor: Generalise personal menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/594601 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [22:41:25] (03CR) 10Nray: [C: 03+2] Refactor: Merge VectorTabs into Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/594761 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [22:54:47] (03Merged) 10jenkins-bot: Refactor: Merge VectorTabs into Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/594761 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [22:55:44] (03PS41) 10Jdlrobson: Refactor: VectorMenu merged in to Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [22:55:50] (03PS37) 10Jdlrobson: Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) [22:55:59] (03PS22) 10Jdlrobson: Refactor: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 (https://phabricator.wikimedia.org/T249372) [23:01:01] (03PS23) 10Jdlrobson: Refactor: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 (https://phabricator.wikimedia.org/T249372) [23:09:35] (03PS42) 10Jdlrobson: Refactor: VectorMenu merged in to Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [23:39:55] (03PS20) 10VolkerE: Organize CSS by common, layout, typography and components [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [23:40:08] (03CR) 10jerkins-bot: [V: 04-1] Organize CSS by common, layout, typography and components [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [23:46:37] (03CR) 10Nray: [C: 03+2] Refactor: VectorMenu merged in to Menu (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [23:50:50] (03CR) 10VolkerE: "@Jdrewniak While I agree with the take of moving IE 8 styles to a conditional comment in many other contexts I'd oppose it here. It's so f" [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson)