[00:38:56] (03PS1) 10VolkerE: Make class attribute optional when empty [skins/Vector] - 10https://gerrit.wikimedia.org/r/596897 [04:05:21] 10Pywikibot, 10Pywikibot-Scripts: imageharvest: on line 78 (urllib.basejoin), basejoin attribute don't exists - https://phabricator.wikimedia.org/T252197 (10Xqt) [04:05:26] 10Pywikibot, 10Pywikibot-Scripts, 10Patch-For-Review, 10Pywikibot-tests: test_imageharvest breaks tests - https://phabricator.wikimedia.org/T167726 (10Xqt) [08:58:17] (03CR) 10D3r1ck01: [C: 03+2] [IMPR] use defaultdict within replicate_wiki.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/595887 (owner: 10Xqt) [09:00:45] (03Merged) 10jenkins-bot: [IMPR] use defaultdict within replicate_wiki.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/595887 (owner: 10Xqt) [09:02:20] (03CR) 10D3r1ck01: [C: 03+1] "Awesome improvement! Thanks @xqt" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [12:43:10] (03CR) 10Hashar: [C: 03+2] "I am deploying it right now." [skins/Vector] (wmf/1.35.0-wmf.32) - 10https://gerrit.wikimedia.org/r/596768 (https://phabricator.wikimedia.org/T252906) (owner: 10Krinkle) [12:57:26] (03Merged) 10jenkins-bot: VectorTemplate: SkinTemplateToolboxEnd hook isn't deprecated [skins/Vector] (wmf/1.35.0-wmf.32) - 10https://gerrit.wikimedia.org/r/596768 (https://phabricator.wikimedia.org/T252906) (owner: 10Krinkle) [14:08:30] 10Africa-Wikimedia-Developers, 10Commons, 10Tools: Create a tool to upload to Commons icons previously downloaded from The Noun Project - https://phabricator.wikimedia.org/T189368 (10BamLifa) @samuelguebo: Hi! Thank you so much for the effort to build this tool. However, I tried to check your repo and notice... [14:31:15] (03PS1) 10Yaron Koren: Replace wfMessage() with $this->msg() in special pages [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597088 [14:34:26] (03PS2) 10Yaron Koren: Replace wfMessage() with $this->msg() in special pages [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597088 [14:41:16] (03CR) 10Yaron Koren: [C: 03+2] Replace wfMessage() with $this->msg() in special pages [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597088 (owner: 10Yaron Koren) [14:53:07] (03Merged) 10jenkins-bot: Replace wfMessage() with $this->msg() in special pages [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597088 (owner: 10Yaron Koren) [14:56:43] (03PS1) 10Yaron Koren: Minor coding improvements [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597092 [15:01:50] (03PS2) 10Yaron Koren: Minor coding improvements [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597092 [15:05:07] (03CR) 10Yaron Koren: [C: 03+2] Minor coding improvements [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597092 (owner: 10Yaron Koren) [15:07:52] (03Merged) 10jenkins-bot: Minor coding improvements [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/597092 (owner: 10Yaron Koren) [17:45:55] 10Africa-Wikimedia-Developers, 10Commons, 10Tools: Create a tool to upload to Commons icons previously downloaded from The Noun Project - https://phabricator.wikimedia.org/T189368 (10samuelguebo) >>! In T189368#6144873, @BamLifa wrote: > @samuelguebo: Hi! Thank you so much for the effort to build this tool.... [18:17:04] (03PS11) 10Jdlrobson: BaseTemplate:makeListItem is deprecated [skins/Vector] - 10https://gerrit.wikimedia.org/r/595662 (https://phabricator.wikimedia.org/T251212) [18:38:10] (03CR) 10Jdlrobson: "rebase also needed" (035 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [19:02:01] (03PS12) 10Jdlrobson: BaseTemplate:makeListItem is deprecated [skins/Vector] - 10https://gerrit.wikimedia.org/r/595662 (https://phabricator.wikimedia.org/T251212) [19:02:05] (03PS1) 10Jdlrobson: Avoid using `get` indirection in VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) [19:06:45] (03PS22) 10Jdlrobson: Begin merge of SkinVector and VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) [19:08:21] (03CR) 10Niedzielski: Avoid using `get` indirection in VectorTemplate (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:11:19] (03PS2) 10Jdlrobson: Avoid using `get` indirection in VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) [19:12:01] (03CR) 10Jdlrobson: Avoid using `get` indirection in VectorTemplate (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:12:52] (03CR) 10Jdlrobson: Avoid using `get` indirection in VectorTemplate (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:19:51] (03CR) 10jerkins-bot: [V: 04-1] BaseTemplate:makeListItem is deprecated [skins/Vector] - 10https://gerrit.wikimedia.org/r/595662 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:20:45] (03CR) 10jerkins-bot: [V: 04-1] Avoid using `get` indirection in VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:20:49] (03PS13) 10Jdlrobson: BaseTemplate:makeListItem is deprecated [skins/Vector] - 10https://gerrit.wikimedia.org/r/595662 (https://phabricator.wikimedia.org/T251212) [19:20:56] (03PS3) 10Jdlrobson: Avoid using `get` indirection in VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) [19:22:46] (03CR) 10Jdlrobson: "> @Jdlrobson So you would rather want to see the entrance points in legacy folders? That would make comparison of skin-legacy.less and ski" [skins/Vector] - 10https://gerrit.wikimedia.org/r/596512 (https://phabricator.wikimedia.org/T249073) (owner: 10VolkerE) [19:23:35] (03CR) 10jerkins-bot: [V: 04-1] Begin merge of SkinVector and VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:23:54] (03CR) 10Jdlrobson: Naming convention using 'skin' as entrance point (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/596512 (https://phabricator.wikimedia.org/T249073) (owner: 10VolkerE) [19:25:07] (03CR) 10VolkerE: "Wearing hat of a newcomer for a moment, just looking at file names: 'legacy' on its own doesn't mean anything. 'skin-legacy' is identifiab" [skins/Vector] - 10https://gerrit.wikimedia.org/r/596512 (https://phabricator.wikimedia.org/T249073) (owner: 10VolkerE) [19:39:27] (03CR) 10jerkins-bot: [V: 04-1] Avoid using `get` indirection in VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [20:45:38] (03PS4) 10Jdlrobson: Avoid using `get` indirection in VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) [21:07:14] (03CR) 10jerkins-bot: [V: 04-1] Avoid using `get` indirection in VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [21:22:43] (03CR) 10Nray: Begin merge of SkinVector and VectorTemplate (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [22:12:53] (03PS5) 10Jdlrobson: Avoid using `get` indirection in VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) [22:22:14] (03CR) 10Jdlrobson: [C: 03+2] Make class attribute optional when empty [skins/Vector] - 10https://gerrit.wikimedia.org/r/596897 (owner: 10VolkerE) [22:22:27] (03CR) 10Jdlrobson: Refactor: Standardize menu data (DRY!) (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585801 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [22:23:04] (03CR) 10Jdlrobson: [C: 03+2] [dev] use skin name constant instead of string [skins/Vector] - 10https://gerrit.wikimedia.org/r/597164 (owner: 10Niedzielski) [22:39:49] (03Merged) 10jenkins-bot: Make class attribute optional when empty [skins/Vector] - 10https://gerrit.wikimedia.org/r/596897 (owner: 10VolkerE) [22:41:14] (03Merged) 10jenkins-bot: [dev] use skin name constant instead of string [skins/Vector] - 10https://gerrit.wikimedia.org/r/597164 (owner: 10Niedzielski) [23:23:57] (03CR) 10VolkerE: [feature] add menu button to toggle panel visibility (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski)