[00:06:01] (03PS27) 10Aron Manning: [modern] Vertically align the PersonalMenu with the Logo [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 [00:06:05] (03PS9) 10Aron Manning: [modern] Limit content width, remove background, gradient, article border [skins/Vector] - 10https://gerrit.wikimedia.org/r/589774 (https://phabricator.wikimedia.org/T246420) [00:06:09] (03PS21) 10Aron Manning: [modern] Move SearchBox into Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585851 (https://phabricator.wikimedia.org/T249363) [00:24:22] (03CR) 10Aron Manning: [C: 03+1] "Yes, from this is one of the many possible solutions I agree with. Thanks for asking." [skins/Vector] - 10https://gerrit.wikimedia.org/r/596512 (https://phabricator.wikimedia.org/T249073) (owner: 10VolkerE) [00:28:21] (03CR) 10Aron Manning: "This change is ready for review." [skins/Vector] - 10https://gerrit.wikimedia.org/r/599459 (https://phabricator.wikimedia.org/T253599) (owner: 10Aron Manning) [00:47:35] (03Abandoned) 10DannyS712: 70c80049b74ca4bc536961506e9f090fdb5f0b2b [extensions/examples] - 10https://gerrit.wikimedia.org/r/596689 (owner: 10Gituser) [01:08:32] (03CR) 10Aron Manning: "Demo: http://patchdemo.wmflabs.org/wikis/95699c2d37452c377799fc8cf6d3b48c/w/?useskinversion=2" [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (owner: 10Aron Manning) [01:17:48] (03CR) 10Jdlrobson: [C: 04-1] "Volker please rebase and we'll land this tomorrow." [skins/Vector] - 10https://gerrit.wikimedia.org/r/596512 (https://phabricator.wikimedia.org/T249073) (owner: 10VolkerE) [03:05:03] (03CR) 10Xqt: "> Why are we treating two invalid syntaxes differently? Not editing" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/599271 (https://phabricator.wikimedia.org/T253709) (owner: 10Xqt) [03:25:18] (03PS2) 10Niedzielski: [fix][Less] disable sidebar animations on page load [skins/Vector] - 10https://gerrit.wikimedia.org/r/599431 (https://phabricator.wikimedia.org/T246419) [03:58:25] (03PS4) 10VolkerE: Naming convention using 'skin' as entrance point [skins/Vector] - 10https://gerrit.wikimedia.org/r/596512 (https://phabricator.wikimedia.org/T249073) [03:59:23] (03CR) 10VolkerE: "Thanks Jan for the input. Changed in PS 4." [skins/Vector] - 10https://gerrit.wikimedia.org/r/596512 (https://phabricator.wikimedia.org/T249073) (owner: 10VolkerE) [03:59:46] (03CR) 10VolkerE: "One thing that's still disgusting is vector.js." [skins/Vector] - 10https://gerrit.wikimedia.org/r/596512 (https://phabricator.wikimedia.org/T249073) (owner: 10VolkerE) [04:11:27] (03PS1) 10Vigneshsweekaran: Adding sample.txt [extensions/examples] - 10https://gerrit.wikimedia.org/r/599532 [04:11:29] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/examples] - 10https://gerrit.wikimedia.org/r/599532 (owner: 10Vigneshsweekaran) [04:25:00] (03Abandoned) 10Vigneshsweekaran: Adding sample.txt [extensions/examples] - 10https://gerrit.wikimedia.org/r/599532 (owner: 10Vigneshsweekaran) [05:00:21] (03PS3) 10Aron Manning: [modern] Adjust wrapping of personal menu items [skins/Vector] - 10https://gerrit.wikimedia.org/r/599459 (https://phabricator.wikimedia.org/T253599) [05:00:25] (03PS3) 10Aron Manning: [modern] Hide header when printing [skins/Vector] - 10https://gerrit.wikimedia.org/r/599357 (https://phabricator.wikimedia.org/T253842) [05:00:29] (03PS28) 10Aron Manning: [modern] Vertically align the PersonalMenu with the Logo [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 [05:00:33] (03PS10) 10Aron Manning: [modern] Limit content width, remove background, gradient, article border [skins/Vector] - 10https://gerrit.wikimedia.org/r/589774 (https://phabricator.wikimedia.org/T246420) [05:00:37] (03PS22) 10Aron Manning: [modern] Move SearchBox into Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585851 (https://phabricator.wikimedia.org/T249363) [05:23:07] (03CR) 10jerkins-bot: [V: 04-1] [modern] Limit content width, remove background, gradient, article border [skins/Vector] - 10https://gerrit.wikimedia.org/r/589774 (https://phabricator.wikimedia.org/T246420) (owner: 10Aron Manning) [05:24:24] (03CR) 10jerkins-bot: [V: 04-1] [modern] Move SearchBox into Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585851 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [05:43:38] (03PS11) 10Aron Manning: [modern] Limit content width, remove background, gradient, article border [skins/Vector] - 10https://gerrit.wikimedia.org/r/589774 (https://phabricator.wikimedia.org/T246420) [05:43:42] (03PS23) 10Aron Manning: [modern] Move SearchBox into Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585851 (https://phabricator.wikimedia.org/T249363) [06:17:34] (03PS1) 10Nray: POC: Testing, Testing 123 [skins/Vector] - 10https://gerrit.wikimedia.org/r/599607 [06:21:28] (03CR) 10Aklapper: "Vigneshsweekaran: Hi. How did you find this place and repo? I'm asking as this is not a place to play. :) If you only want to play with Ge" [extensions/examples] - 10https://gerrit.wikimedia.org/r/599532 (owner: 10Vigneshsweekaran) [06:22:32] (03PS1) 10VolkerE: [WIP] Use .mixin-clearfix instead of DOM element [skins/Vector] - 10https://gerrit.wikimedia.org/r/599611 [06:30:51] (03Abandoned) 10Nray: POC: Testing, Testing 123 [skins/Vector] - 10https://gerrit.wikimedia.org/r/599607 (owner: 10Nray) [06:40:59] (03CR) 10VolkerE: "Open discussion points:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/599611 (owner: 10VolkerE) [07:23:11] (03CR) 10Xqt: [IMPR] Use one central point for framework version (0319 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [07:23:39] (03PS43) 10Xqt: [IMPR] Use one central point for framework version [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) [07:26:23] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Use one central point for framework version [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [07:30:06] (03PS44) 10Xqt: [IMPR] Use one central point for framework version [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) [07:32:50] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Use one central point for framework version [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [07:43:25] 10Pywikibot: UserWarning: Site wikipedia:be-tarask instantiated using different code "be-x-old" - https://phabricator.wikimedia.org/T234147 (10Xqt) >>! In T234147#6168512, @Dvorapa wrote: > The following patch might help: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaMaintenance/+/587863/ > Tw... [07:50:54] (03PS45) 10Xqt: [IMPR] Use one central point for framework version [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) [07:59:40] (03PS4) 10Xqt: [doc] Update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598255 [08:02:41] (03PS8) 10Xqt: [cleanup] Remove deprecated ip submodule [pywikibot/core] - 10https://gerrit.wikimedia.org/r/595213 (https://phabricator.wikimedia.org/T243171) [09:34:32] 10Pywikibot: UserWarning: Site wikipedia:be-tarask instantiated using different code "be-x-old" - https://phabricator.wikimedia.org/T234147 (10Dvorapa) Well, the patch to wikis will be deployed next thursday, then we can test, how our issues with be-tarask/be-x-old changed [10:05:27] (03CR) 10Dvorapa: [C: 03+2] [doc] Update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598255 (owner: 10Xqt) [10:07:51] (03Merged) 10jenkins-bot: [doc] Update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/598255 (owner: 10Xqt) [10:10:25] (03CR) 10Dvorapa: [IMPR] Use one central point for framework version (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [10:34:48] (03CR) 10Ammarpad: [C: 04-1] Drop support for SkinTemplateToolboxEnd (033 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/596760 (https://phabricator.wikimedia.org/T252917) (owner: 10Jdlrobson) [11:24:31] 10Pywikibot: Add some kind of -nowarn option to CurrentPageBot subclasses - https://phabricator.wikimedia.org/T253987 (10Xqt) [11:24:55] 10Pywikibot: Add some kind of -nowarn option to CurrentPageBot subclasses - https://phabricator.wikimedia.org/T253987 (10Xqt) p:05Triage→03Low [11:59:30] (03CR) 10Xqt: [IMPR] Use one central point for framework version (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [12:19:14] 10Pywikibot, 10DBA, 10MediaWiki-API, 10Wikidata, and 3 others: Wikidata API fails with timeout when asking for 5 RC redirects - https://phabricator.wikimedia.org/T245989 (10Marostegui) On 10.4 the optimizer keeps choosing the wrong plan, so we need to fix this in code with an `ignore index (page_redirect_n... [12:19:24] 10Pywikibot, 10MediaWiki-API, 10Wikidata, 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: Wikidata API fails with timeout when asking for 5 RC redirects - https://phabricator.wikimedia.org/T245989 (10Marostegui) [12:46:58] 10Pywikibot: How to use pywikibot to get data from SMW ask API? - https://phabricator.wikimedia.org/T254003 (10Seppl2013) [12:47:11] 10Pywikibot: How to use pywikibot to get data from SMW ask API? - https://phabricator.wikimedia.org/T254003 (10Seppl2013) [13:01:48] 10Pywikibot: UserWarning: Site wikipedia:be-tarask instantiated using different code "be-x-old" - https://phabricator.wikimedia.org/T234147 (10Huji) In fact, I think after the patch to wiki is deployed (next week) some additional step needs to be taken (@Ladsgroup described it as "rebuild the interwiki cache" bu... [13:02:03] 10Pywikibot: UserWarning: Site wikipedia:be-tarask instantiated using different code "be-x-old" - https://phabricator.wikimedia.org/T234147 (10Huji) [13:40:51] (03CR) 10Dvorapa: [IMPR] Use one central point for framework version (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [13:48:48] (03CR) 10Dvorapa: [IMPR] Use one central point for framework version (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [14:01:00] 10Pywikibot: How to use pywikibot to get data from SMW ask API? - https://phabricator.wikimedia.org/T254003 (10Xqt) I see. SMW does not have the MW api continue system but an offset parameter which must be given to the query string delimited by "|" i guess. The returned Offset is not response['continue']['contin... [14:29:42] (03CR) 10Jdlrobson: [C: 03+1] "Volker mentioned there are probably accessibility benefits of this change." [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (owner: 10Aron Manning) [16:42:23] 10Pywikibot: How to use pywikibot to get data from SMW ask API? - https://phabricator.wikimedia.org/T254003 (10Seppl2013) @Xqt - thanks for looking into this. I am currently adding this to https://github.com/WolfgangFahl/py-3rdparty-mediawiki/issues/1 with https://github.com/WolfgangFahl/py-3rdparty-mediawiki/bl... [17:44:30] (03CR) 10Jdlrobson: [C: 03+2] Naming convention using 'skin' as entrance point [skins/Vector] - 10https://gerrit.wikimedia.org/r/596512 (https://phabricator.wikimedia.org/T249073) (owner: 10VolkerE) [17:48:33] (03PS10) 10Jdlrobson: Avoid using `get` indirection in VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) [17:48:38] (03PS9) 10Jdlrobson: Drop support for SkinTemplateToolboxEnd [skins/Vector] - 10https://gerrit.wikimedia.org/r/596760 (https://phabricator.wikimedia.org/T252917) [17:48:45] (03PS3) 10Jdlrobson: Model indicators as their own template rather than a block of HTML [skins/Vector] - 10https://gerrit.wikimedia.org/r/598843 (https://phabricator.wikimedia.org/T251212) [17:48:49] (03PS28) 10Jdlrobson: Begin merge of SkinVector and VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) [17:48:53] (03PS12) 10Jdlrobson: SkinTemplateVector: Big switchermovearoo [skins/Vector] - 10https://gerrit.wikimedia.org/r/592790 (https://phabricator.wikimedia.org/T251212) [18:00:25] (03Merged) 10jenkins-bot: Naming convention using 'skin' as entrance point [skins/Vector] - 10https://gerrit.wikimedia.org/r/596512 (https://phabricator.wikimedia.org/T249073) (owner: 10VolkerE) [18:05:48] (03PS1) 10Niedzielski: [fix][a11y][Less] use pixel dimensions for sidebar button [skins/Vector] - 10https://gerrit.wikimedia.org/r/599938 (https://phabricator.wikimedia.org/T246419) [18:05:55] (03PS1) 10Niedzielski: [config] Change the sidebar's default state to open [skins/Vector] - 10https://gerrit.wikimedia.org/r/599939 (https://phabricator.wikimedia.org/T246419) [18:06:15] (03CR) 10jerkins-bot: [V: 04-1] [fix][a11y][Less] use pixel dimensions for sidebar button [skins/Vector] - 10https://gerrit.wikimedia.org/r/599938 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [18:06:19] (03CR) 10jerkins-bot: [V: 04-1] [config] Change the sidebar's default state to open [skins/Vector] - 10https://gerrit.wikimedia.org/r/599939 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [18:13:56] (03PS3) 10Niedzielski: [fix][Less] disable sidebar animations on page load [skins/Vector] - 10https://gerrit.wikimedia.org/r/599431 (https://phabricator.wikimedia.org/T246419) [18:14:00] (03PS2) 10Niedzielski: [fix][a11y][Less] use pixel dimensions for sidebar button [skins/Vector] - 10https://gerrit.wikimedia.org/r/599938 (https://phabricator.wikimedia.org/T246419) [18:14:04] (03PS2) 10Niedzielski: [config] Change the sidebar's default state to open [skins/Vector] - 10https://gerrit.wikimedia.org/r/599939 (https://phabricator.wikimedia.org/T246419) [18:15:16] (03CR) 10VolkerE: "What's a [fix]? Everything that's not a [feature]?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/599431 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [18:17:39] (03CR) 10VolkerE: [C: 04-2] "That's actually exactly the opposite of what we would like the users to enable." [skins/Vector] - 10https://gerrit.wikimedia.org/r/599938 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [18:24:01] (03CR) 10Niedzielski: "No, there's changes specifically for development, changes for configuration, upgrading libraries, and probably others. These often have ov" [skins/Vector] - 10https://gerrit.wikimedia.org/r/599431 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [18:50:00] (03PS3) 10Niedzielski: [fix][a11y][Less] use em dimensions for sidebar button icon [skins/Vector] - 10https://gerrit.wikimedia.org/r/599938 (https://phabricator.wikimedia.org/T246419) [18:50:04] (03PS3) 10Niedzielski: [config] Change the sidebar's default state to open [skins/Vector] - 10https://gerrit.wikimedia.org/r/599939 (https://phabricator.wikimedia.org/T246419) [19:14:06] (03PS1) 10Jdlrobson: Cleanup: Use consistent naming in SearchBox [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 [19:31:58] (03PS2) 10Jdlrobson: Cleanup: Use consistent naming in SearchBox [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 [19:32:02] (03PS11) 10Jdlrobson: Avoid using `get` indirection in VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) [19:32:06] (03PS4) 10Jdlrobson: Model indicators as their own template rather than a block of HTML [skins/Vector] - 10https://gerrit.wikimedia.org/r/598843 (https://phabricator.wikimedia.org/T251212) [19:35:22] (03CR) 10VolkerE: [C: 04-1] [fix][a11y][Less] use em dimensions for sidebar button icon (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/599938 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [19:35:27] (03CR) 10Aron Manning: "Please inform me when any of these patches is intended to be merged. I'm available today. I'll pull out that patch, rebase on master, reso" [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (owner: 10Aron Manning) [19:43:08] (03CR) 10Jdlrobson: [C: 03+2] [config] Change the sidebar's default state to open [skins/Vector] - 10https://gerrit.wikimedia.org/r/599939 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [19:48:53] (03PS4) 10Niedzielski: [fix][a11y][Less] use percentage for sidebar button icon size [skins/Vector] - 10https://gerrit.wikimedia.org/r/599938 (https://phabricator.wikimedia.org/T246419) [19:48:57] (03PS4) 10Niedzielski: [config] Change the sidebar's default state to open [skins/Vector] - 10https://gerrit.wikimedia.org/r/599939 (https://phabricator.wikimedia.org/T246419) [19:49:21] (03CR) 10jerkins-bot: [V: 04-1] Cleanup: Use consistent naming in SearchBox [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 (owner: 10Jdlrobson) [19:50:34] (03CR) 10Niedzielski: [fix][a11y][Less] use percentage for sidebar button icon size (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/599938 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [19:52:44] (03CR) 10jerkins-bot: [V: 04-1] Drop support for SkinTemplateToolboxEnd [skins/Vector] - 10https://gerrit.wikimedia.org/r/596760 (https://phabricator.wikimedia.org/T252917) (owner: 10Jdlrobson) [19:52:50] (03CR) 10jerkins-bot: [V: 04-1] Model indicators as their own template rather than a block of HTML [skins/Vector] - 10https://gerrit.wikimedia.org/r/598843 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:54:15] (03CR) 10jerkins-bot: [V: 04-1] Generalize the Mustache renderer [skins/Vector] - 10https://gerrit.wikimedia.org/r/599972 (owner: 10Jdlrobson) [19:54:46] (03CR) 10jerkins-bot: [V: 04-1] Begin merge of SkinVector and VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:55:24] (03CR) 10jerkins-bot: [V: 04-1] Avoid using `get` indirection in VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:55:45] (03CR) 10jerkins-bot: [V: 04-1] SkinTemplateVector: Big switchermovearoo [skins/Vector] - 10https://gerrit.wikimedia.org/r/592790 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:55:55] (03PS3) 10Jdlrobson: Cleanup: Use consistent naming in SearchBox [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 [19:55:59] (03PS12) 10Jdlrobson: Avoid using `get` indirection in VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) [19:56:20] (03PS2) 10Jdlrobson: Generalize the Mustache renderer [skins/Vector] - 10https://gerrit.wikimedia.org/r/599972 [20:03:08] (03CR) 10DannyS712: Generalize the Mustache renderer (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/599972 (owner: 10Jdlrobson) [20:08:30] (03CR) 10jerkins-bot: [V: 04-1] Begin merge of SkinVector and VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [20:08:34] (03CR) 10jerkins-bot: [V: 04-1] SkinTemplateVector: Big switchermovearoo [skins/Vector] - 10https://gerrit.wikimedia.org/r/592790 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [20:08:38] (03CR) 10jerkins-bot: [V: 04-1] Generalize the Mustache renderer [skins/Vector] - 10https://gerrit.wikimedia.org/r/599972 (owner: 10Jdlrobson) [20:40:06] (03PS5) 10VolkerE: [fix][a11y][Less] use percentage for sidebar button icon size [skins/Vector] - 10https://gerrit.wikimedia.org/r/599938 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [20:40:17] (03CR) 10VolkerE: [C: 03+2] [fix][a11y][Less] use percentage for sidebar button icon size [skins/Vector] - 10https://gerrit.wikimedia.org/r/599938 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [20:46:50] (03CR) 10VolkerE: "Thanks, I like that a lot. One nitpick" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 (owner: 10Jdlrobson) [20:48:18] (03PS6) 10VolkerE: [fix][a11y][Less] use percentage for sidebar button icon size [skins/Vector] - 10https://gerrit.wikimedia.org/r/599938 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [20:48:23] (03CR) 10VolkerE: [C: 03+2] [fix][a11y][Less] use percentage for sidebar button icon size [skins/Vector] - 10https://gerrit.wikimedia.org/r/599938 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [20:51:58] (03CR) 10Jdlrobson: Cleanup: Use consistent naming in SearchBox (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 (owner: 10Jdlrobson) [21:12:07] (03CR) 10VolkerE: Cleanup: Use consistent naming in SearchBox (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 (owner: 10Jdlrobson) [21:14:11] (03CR) 10Jdlrobson: "In a follow up? The main thing I want to get rid of here is the camel casing and to make sure this is consistent with everything else." [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 (owner: 10Jdlrobson) [21:34:05] (03CR) 10VolkerE: Cleanup: Use consistent naming in SearchBox (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 (owner: 10Jdlrobson) [21:55:12] (03PS1) 10VolkerE: Fix misconception on icon coloring [skins/Vector] - 10https://gerrit.wikimedia.org/r/600012 [21:56:34] (03PS2) 10VolkerE: Fix misconception on icon coloring [skins/Vector] - 10https://gerrit.wikimedia.org/r/600012 (https://phabricator.wikimedia.org/T246419) [22:00:58] (03PS4) 10Jdlrobson: Cleanup: Use consistent naming in SearchBox [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 [22:01:45] (03CR) 10Jdlrobson: Cleanup: Use consistent naming in SearchBox (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 (owner: 10Jdlrobson) [22:10:21] (03CR) 10Niedzielski: [C: 04-1] Fix misconception on icon coloring (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/600012 (https://phabricator.wikimedia.org/T246419) (owner: 10VolkerE) [22:20:15] (03CR) 10VolkerE: [C: 04-1] Cleanup: Use consistent naming in SearchBox (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 (owner: 10Jdlrobson) [22:26:33] (03CR) 10VolkerE: Fix misconception on icon coloring (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/600012 (https://phabricator.wikimedia.org/T246419) (owner: 10VolkerE) [22:29:20] (03CR) 10Jdlrobson: "not sure i understand the -1. Did you see ps4?" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 (owner: 10Jdlrobson) [22:29:47] (03CR) 10Niedzielski: [C: 04-1] Fix misconception on icon coloring (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/600012 (https://phabricator.wikimedia.org/T246419) (owner: 10VolkerE) [22:29:59] (03CR) 10VolkerE: "I should have added to the commit description. There's a mistake currently, having a toned down variant icon “-base20”. On top we add opac" [skins/Vector] - 10https://gerrit.wikimedia.org/r/600012 (https://phabricator.wikimedia.org/T246419) (owner: 10VolkerE) [22:45:10] (03PS5) 10Jdlrobson: Cleanup: Use consistent naming in SearchBox [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 [22:56:20] (03CR) 10VolkerE: Cleanup: Use consistent naming in SearchBox (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 (owner: 10Jdlrobson) [22:56:54] (03CR) 10VolkerE: "-1 for “Is this really searching page content?” Is the name reflecting reality and describing it appropriately?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 (owner: 10Jdlrobson) [23:00:01] (03CR) 10jerkins-bot: [V: 04-1] Cleanup: Use consistent naming in SearchBox [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 (owner: 10Jdlrobson) [23:10:19] (03CR) 10Jdlrobson: "> -1 for “Is this really searching page content?” Is the name reflecting reality and describing it appropriately?" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968 (owner: 10Jdlrobson) [23:12:41] (03PS6) 10Jdlrobson: Cleanup: Use consistent naming in SearchBox [skins/Vector] - 10https://gerrit.wikimedia.org/r/599968