[01:14:45] (03CR) 10VolkerE: [C: 04-1] "Superseded by Iddf8f1dffc2d30299b" [skins/Vector] - 10https://gerrit.wikimedia.org/r/599611 (owner: 10VolkerE) [01:35:37] (03PS1) 10Samwilson: Account for non-UTC $wgLocaltimezone in icalendar exports [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601507 (https://phabricator.wikimedia.org/T250547) [01:36:29] (03PS2) 10VolkerE: Use core `.mixin-clearfix()` instead of DOM element [skins/Vector] - 10https://gerrit.wikimedia.org/r/599611 (https://phabricator.wikimedia.org/T254195) [01:37:15] (03CR) 10jerkins-bot: [V: 04-1] Use core `.mixin-clearfix()` instead of DOM element [skins/Vector] - 10https://gerrit.wikimedia.org/r/599611 (https://phabricator.wikimedia.org/T254195) (owner: 10VolkerE) [01:40:36] (03CR) 10VolkerE: "Should have stated “partly superseded”." [skins/Vector] - 10https://gerrit.wikimedia.org/r/599611 (https://phabricator.wikimedia.org/T254195) (owner: 10VolkerE) [01:58:10] (03CR) 10Yaron Koren: "@Samwilson - this looks good to me... is it ready for merging?" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601507 (https://phabricator.wikimedia.org/T250547) (owner: 10Samwilson) [02:47:33] (03CR) 10VolkerE: [C: 03+1] "Merge with some more testing after train tomorrow." [skins/Vector] - 10https://gerrit.wikimedia.org/r/598843 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [03:10:58] (03PS1) 10Niedzielski: [fix][RTL] flip menu collapse button icon [skins/Vector] - 10https://gerrit.wikimedia.org/r/601548 (https://phabricator.wikimedia.org/T246419) [03:11:19] (03CR) 10jerkins-bot: [V: 04-1] [fix][RTL] flip menu collapse button icon [skins/Vector] - 10https://gerrit.wikimedia.org/r/601548 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [04:21:55] (03CR) 10Samwilson: "> Patch Set 1:" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601507 (https://phabricator.wikimedia.org/T250547) (owner: 10Samwilson) [05:09:58] (03PS1) 10Xqt: [L10N] Update languages_by_size [pywikibot/core] - 10https://gerrit.wikimedia.org/r/601585 [05:13:28] (03CR) 10Xqt: [C: 03+2] [L10N] Update languages_by_size [pywikibot/core] - 10https://gerrit.wikimedia.org/r/601585 (owner: 10Xqt) [05:16:18] (03Merged) 10jenkins-bot: [L10N] Update languages_by_size [pywikibot/core] - 10https://gerrit.wikimedia.org/r/601585 (owner: 10Xqt) [06:32:03] (03CR) 10Aron Manning: [C: 04-1] "This removes a necessary functionality without giving an alternative." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/601368 (https://phabricator.wikimedia.org/T71729) (owner: 10Jdlrobson) [06:37:08] (03CR) 10Aron Manning: [C: 04-1] "This will cause layout issues in narrow windows as detailed in:" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/601371 (owner: 10Jdlrobson) [09:16:18] (03PS8) 10Aron Manning: [DNM-POC] Demo: Sidebar checkbox in header, Sidebar separately in #navigation [skins/Vector] - 10https://gerrit.wikimedia.org/r/592328 [09:16:36] (03CR) 10jerkins-bot: [V: 04-1] [DNM-POC] Demo: Sidebar checkbox in header, Sidebar separately in #navigation [skins/Vector] - 10https://gerrit.wikimedia.org/r/592328 (owner: 10Aron Manning) [09:18:34] (03PS9) 10Aron Manning: [DNM-POC] Demo: Sidebar checkbox in header, Sidebar separately in #navigation [skins/Vector] - 10https://gerrit.wikimedia.org/r/592328 (https://phabricator.wikimedia.org/T246427) [09:18:46] (03CR) 10jerkins-bot: [V: 04-1] [DNM-POC] Demo: Sidebar checkbox in header, Sidebar separately in #navigation [skins/Vector] - 10https://gerrit.wikimedia.org/r/592328 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [09:18:52] (03CR) 10Aron Manning: [C: 04-1] "POC, don't merge." [skins/Vector] - 10https://gerrit.wikimedia.org/r/592328 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [09:19:27] (03CR) 10Aron Manning: [C: 04-1] "POC, don't merge." [skins/Vector] - 10https://gerrit.wikimedia.org/r/592395 (owner: 10Aron Manning) [11:56:06] (03PS4) 10Sahajsk: Fix parse error in HOLDS query in where clause [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601255 [13:43:54] (03CR) 10VolkerE: [C: 04-1] "I like most of this patch, nonetheless wondering if you considered that" [skins/Vector] - 10https://gerrit.wikimedia.org/r/601548 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [13:48:20] (03CR) 10VolkerE: Fix misconception on icon coloring (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/600012 (https://phabricator.wikimedia.org/T246419) (owner: 10VolkerE) [14:11:14] (03CR) 10VolkerE: [C: 04-1] "I'm not a fan of `noprint` utlity class. I'd prefer to handle this via adding the selector to the print stylesheet instead of adding an ad" [skins/Vector] - 10https://gerrit.wikimedia.org/r/599357 (https://phabricator.wikimedia.org/T253842) (owner: 10Aron Manning) [14:14:52] (03PS5) 10Sahajsk: Change pattern to match quotes inside string in HOLDS query [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601255 [14:39:58] (03PS6) 10Sahajsk: Change pattern to match quotes inside string in HOLDS query [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601255 [14:43:05] (03CR) 10Yaron Koren: [C: 03+2] Change pattern to match quotes inside string in HOLDS query [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601255 (owner: 10Sahajsk) [14:45:54] (03Merged) 10jenkins-bot: Change pattern to match quotes inside string in HOLDS query [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601255 (owner: 10Sahajsk) [15:08:14] (03PS1) 10Jdrewniak: Add bundlesize test for ResourceLoader modules. [skins/Vector] - 10https://gerrit.wikimedia.org/r/601758 (https://phabricator.wikimedia.org/T244276) [15:20:30] (03PS1) 10D3r1ck01: tests: Increase code coverage for CargoUtils class [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601765 [15:21:08] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601765 (owner: 10D3r1ck01) [15:24:27] (03CR) 10jerkins-bot: [V: 04-1] Add bundlesize test for ResourceLoader modules. [skins/Vector] - 10https://gerrit.wikimedia.org/r/601758 (https://phabricator.wikimedia.org/T244276) (owner: 10Jdrewniak) [15:34:36] (03PS2) 10Jdrewniak: Add bundlesize test for ResourceLoader modules. [skins/Vector] - 10https://gerrit.wikimedia.org/r/601758 (https://phabricator.wikimedia.org/T244276) [15:47:07] (03PS2) 10D3r1ck01: tests: Increase code coverage for CargoUtils class [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601765 [15:48:54] (03CR) 10Yaron Koren: [C: 03+2] tests: Increase code coverage for CargoUtils class [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601765 (owner: 10D3r1ck01) [15:53:22] (03CR) 10jerkins-bot: [V: 04-1] Add bundlesize test for ResourceLoader modules. [skins/Vector] - 10https://gerrit.wikimedia.org/r/601758 (https://phabricator.wikimedia.org/T244276) (owner: 10Jdrewniak) [15:58:18] (03Merged) 10jenkins-bot: tests: Increase code coverage for CargoUtils class [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601765 (owner: 10D3r1ck01) [17:21:16] (03CR) 10Jdlrobson: Fix misconception on icon coloring (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/600012 (https://phabricator.wikimedia.org/T246419) (owner: 10VolkerE) [17:44:44] (03PS1) 10D3r1ck01: tests/unit: Increase code coverage for the CargoUtils class [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601812 [17:45:21] (03PS6) 10Jdlrobson: [modern] Drop collapsibleTabs from Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/601371 [17:45:57] (03PS6) 10Jdlrobson: [legacy] Drop the collapsibleTabs code [skins/Vector] - 10https://gerrit.wikimedia.org/r/601368 (https://phabricator.wikimedia.org/T71729) [17:46:18] (03PS2) 10D3r1ck01: tests/unit: Increase code coverage for the CargoUtils class [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601812 [17:47:02] (03CR) 10Jdlrobson: [C: 04-1] "needs a rebase but I'm happy this is happening!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/599611 (https://phabricator.wikimedia.org/T254195) (owner: 10VolkerE) [17:47:20] (03CR) 10Jdlrobson: "Please note dependency on https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/597133/13 :)" [skins/Vector] - 10https://gerrit.wikimedia.org/r/598843 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [17:50:05] (03CR) 10jerkins-bot: [V: 04-1] tests/unit: Increase code coverage for the CargoUtils class [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601812 (owner: 10D3r1ck01) [17:52:14] (03PS3) 10D3r1ck01: tests/unit: Increase code coverage for the CargoUtils class [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601812 [17:54:51] (03CR) 10jerkins-bot: [V: 04-1] tests/unit: Increase code coverage for the CargoUtils class [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601812 (owner: 10D3r1ck01) [17:58:10] (03PS4) 10D3r1ck01: tests/unit: Increase code coverage for the CargoUtils class [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601812 [18:03:09] (03CR) 10Yaron Koren: [C: 03+2] tests/unit: Increase code coverage for the CargoUtils class [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601812 (owner: 10D3r1ck01) [18:03:13] (03CR) 10jerkins-bot: [V: 04-1] [modern] Drop collapsibleTabs from Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/601371 (owner: 10Jdlrobson) [18:25:31] (03PS14) 10VolkerE: Avoid using `get` indirection in VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/597133 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [18:28:20] (03CR) 10VolkerE: [C: 03+2] Model indicators as their own template rather than a block of HTML [skins/Vector] - 10https://gerrit.wikimedia.org/r/598843 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [19:08:42] (03CR) 10Jdlrobson: [C: 04-1] "I checked with Olga and Alex and we want to show this header when you click file > print" [skins/Vector] - 10https://gerrit.wikimedia.org/r/599357 (https://phabricator.wikimedia.org/T253842) (owner: 10Aron Manning) [19:11:56] (03PS7) 10Jdlrobson: [modern] Drop collapsibleTabs from Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/601371 [19:50:41] (03PS1) 10D3r1ck01: tests: Add automated test for CargoUtils::makeLink() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601837 [19:52:56] (03CR) 10jerkins-bot: [V: 04-1] tests: Add automated test for CargoUtils::makeLink() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601837 (owner: 10D3r1ck01) [19:54:22] (03PS2) 10D3r1ck01: tests: Add automated test for CargoUtils::makeLink() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601837 [20:00:42] (03PS3) 10D3r1ck01: tests: Add automated test for CargoUtils::makeLink() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601837 [20:01:34] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601837 (owner: 10D3r1ck01) [20:29:20] 10Africa-Wikimedia-Developers: Africa Wikimedia Developers Leader Board Monthly Statistics for the year 2020 - https://phabricator.wikimedia.org/T253440 (10Aklapper) I'm going to remove #Developer-Advocacy from this tag as there seems nothing for our team to track here. [21:32:57] (03CR) 10Yaron Koren: [C: 03+2] tests: Add automated test for CargoUtils::makeLink() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601837 (owner: 10D3r1ck01) [21:35:26] (03Merged) 10jenkins-bot: tests: Add automated test for CargoUtils::makeLink() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601837 (owner: 10D3r1ck01) [23:56:46] (03PS7) 10Jdlrobson: [legacy] Drop the collapsibleTabs code [skins/Vector] - 10https://gerrit.wikimedia.org/r/601368 (https://phabricator.wikimedia.org/T71729)