[02:13:59] (03PS1) 10Yaron Koren: Version 2.6 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604222 [02:18:31] (03PS2) 10Yaron Koren: Version 2.6 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604222 [02:21:54] (03CR) 10Yaron Koren: [C: 03+2] Version 2.6 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604222 (owner: 10Yaron Koren) [02:29:25] (03Merged) 10jenkins-bot: Version 2.6 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604222 (owner: 10Yaron Koren) [07:37:28] (03PS3) 10Xqt: [L10N] Update linktrails [pywikibot/core] - 10https://gerrit.wikimedia.org/r/603517 [07:43:34] (03PS8) 10Xqt: [maintenance] Add update_linktrails.py maintenance script [pywikibot/core] - 10https://gerrit.wikimedia.org/r/602984 [07:51:49] (03PS1) 10Xqt: [doc] update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/604295 [07:53:37] (03CR) 10Xqt: [IMPR] Use one central point for framework version (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [08:29:35] 10Pywikibot, 10Pywikibot-redirect.py: Wrong link replacements made by redirect.py - https://phabricator.wikimedia.org/T254839 (10Xqt) A simple test with bs4 and without bs4 works: # https://de.wikipedia.org/w/index.php?title=Benutzer:Xqt/Test&diff=200812594&oldid=200812583&diffmode=source # https://de.wik... [09:15:56] 10Pywikibot, 10Commons, 10Internet-Archive: Large PDF upload issue - https://phabricator.wikimedia.org/T254459 (10Fae) Sticking the upload script inside an infinite loop, allowing the upload to break on any first API error seems a practical but bad //brute-force// work around. However this is incredibly slow... [09:59:19] 10Pywikibot, 10Commons, 10Core Platform Team, 10Internet-Archive, 10MediaWiki-API: Large PDF upload issue - https://phabricator.wikimedia.org/T254459 (10Dvorapa) Let's try the API team about the successfull/duplicate messages not retrieved when expected [10:11:36] (03CR) 10Dvorapa: [C: 03+1] [doc] update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/604295 (owner: 10Xqt) [10:41:15] (03CR) 10Dvorapa: [maintenance] Add update_linktrails.py maintenance script (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/602984 (owner: 10Xqt) [12:15:03] (03CR) 10Xqt: [maintenance] Add update_linktrails.py maintenance script (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/602984 (owner: 10Xqt) [12:16:09] (03PS9) 10Xqt: [maintenance] Add update_linktrails.py maintenance script [pywikibot/core] - 10https://gerrit.wikimedia.org/r/602984 [12:20:31] (03CR) 10Xqt: [maintenance] Add update_linktrails.py maintenance script (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/602984 (owner: 10Xqt) [13:22:11] (03PS10) 10Xqt: [maintenance] Add update_linktrails.py maintenance script [pywikibot/core] - 10https://gerrit.wikimedia.org/r/602984 [13:22:22] (03CR) 10Xqt: [maintenance] Add update_linktrails.py maintenance script (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/602984 (owner: 10Xqt) [13:44:36] (03PS4) 10Xqt: [L10N] Update linktrails [pywikibot/core] - 10https://gerrit.wikimedia.org/r/603517 [13:55:03] (03CR) 10Dvorapa: [maintenance] Add update_linktrails.py maintenance script (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/602984 (owner: 10Xqt) [14:07:34] 10Pywikibot, 10Commons, 10Core Platform Team, 10Internet-Archive, 10MediaWiki-API: Large PDF upload issue - https://phabricator.wikimedia.org/T254459 (10Fae) Slight addition. [[https://commons.wikimedia.org/wiki/File:Catalog_of_Copyright_Entries_1937_Musical_Compositions_New_Series_Vol_32_Pt_3_For_the_Ye... [15:15:36] (03PS3) 10Yaron Koren: Use SidebarBeforeOutput hook to add toolbox item [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/602796 (https://phabricator.wikimedia.org/T253416) (owner: 10Ammarpad) [15:18:32] (03CR) 10jerkins-bot: [V: 04-1] Use SidebarBeforeOutput hook to add toolbox item [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/602796 (https://phabricator.wikimedia.org/T253416) (owner: 10Ammarpad) [15:50:48] (03CR) 10Ammarpad: "Tests for BaseTemplate merged: I12f9ca133578680cebddafc0faa5e816912244ce" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/602796 (https://phabricator.wikimedia.org/T253416) (owner: 10Ammarpad) [15:50:50] (03PS4) 10Yaron Koren: Use SidebarBeforeOutput hook to add toolbox item [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/602796 (https://phabricator.wikimedia.org/T253416) (owner: 10Ammarpad) [16:24:50] (03CR) 10Yaron Koren: [C: 03+2] Use SidebarBeforeOutput hook to add toolbox item [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/602796 (https://phabricator.wikimedia.org/T253416) (owner: 10Ammarpad) [16:36:11] (03Merged) 10jenkins-bot: Use SidebarBeforeOutput hook to add toolbox item [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/602796 (https://phabricator.wikimedia.org/T253416) (owner: 10Ammarpad) [16:40:51] (03PS1) 10C. Scott Ananian: Update to use new Hooks system [extensions/examples] - 10https://gerrit.wikimedia.org/r/604439 (https://phabricator.wikimedia.org/T254381) [16:42:08] (03CR) 10jerkins-bot: [V: 04-1] Update to use new Hooks system [extensions/examples] - 10https://gerrit.wikimedia.org/r/604439 (https://phabricator.wikimedia.org/T254381) (owner: 10C. Scott Ananian) [16:44:12] (03Abandoned) 10C. Scott Ananian: Update to use new Hooks system [extensions/examples] - 10https://gerrit.wikimedia.org/r/604439 (https://phabricator.wikimedia.org/T254381) (owner: 10C. Scott Ananian) [18:24:09] (03CR) 10Jdlrobson: [C: 04-1] "* This changes legacy as well as modern - those parts of the change should be in a separate patchset" [skins/Vector] - 10https://gerrit.wikimedia.org/r/602848 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [20:34:16] (03PS1) 10Ammarpad: Improve sidebar link test [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 [20:37:03] (03CR) 10jerkins-bot: [V: 04-1] Improve sidebar link test [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [20:39:01] (03PS2) 10Ammarpad: Improve sidebar link test [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 [20:46:55] (03CR) 10Yaron Koren: "This is great! But there's no need to return the $sidebar in the main function - it doesn't help with anything." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [21:07:31] (03CR) 10Ammarpad: "If you don't return the $sidebar, you cannot test whether the link was added in that array. You can only test that the method returns null" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [21:42:13] (03CR) 10Yaron Koren: "You just need to remove that is_array() call, no?" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [22:06:22] (03CR) 10Ammarpad: Improve sidebar link test (031 comment) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [22:09:24] (03CR) 10Yaron Koren: "But this particular test is not being called for a special page (or a mock special page, or whatever it is), so $sidebar will always get s" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [22:29:13] (03CR) 10Ammarpad: "The second dataset is Title::newFromText( 'Test', NS_SPECIAL ). This is a special page title, when when run in the test it must return fal" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [22:34:58] (03CR) 10Yaron Koren: "Oh, I didn't notice that. Well, how about replacing "if ( is_array( $actual ) )" with something like "if ( $title->getNamespace() == NS_SP" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [22:35:30] (03CR) 10Yaron Koren: "Or actually, "!== NS_SPECIAL"." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [22:41:13] (03PS3) 10Ammarpad: Improve sidebar link test [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 [22:43:55] (03CR) 10Yaron Koren: "Alright, great. But can you make addLink() look more like it did before?" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [22:49:27] (03PS4) 10Ammarpad: Improve sidebar link test [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 [22:51:22] (03CR) 10Ammarpad: "> Alright, great. But can you make addLink() look more like it did" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [22:52:08] (03CR) 10jerkins-bot: [V: 04-1] Improve sidebar link test [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [22:55:36] (03CR) 10Yaron Koren: "Well, I'm guessing that line 47 of the test file needs to change - the return value is no longer an array or false, it's null or false. Of" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [23:13:23] (03PS5) 10Ammarpad: Improve sidebar link test [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 [23:34:37] (03CR) 10Yaron Koren: "What happened to the check of the $sidebar value?" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad) [23:52:40] (03CR) 10Ammarpad: "> What happened to the check of the $sidebar value?" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604505 (owner: 10Ammarpad)