[00:43:00] (03Restored) 10Aron Manning: [modern] Hide header when printing [skins/Vector] - 10https://gerrit.wikimedia.org/r/599357 (https://phabricator.wikimedia.org/T253842) (owner: 10Aron Manning) [00:43:16] (03PS5) 10Aron Manning: [modern] Hide header when printing, show old logo instead [skins/Vector] - 10https://gerrit.wikimedia.org/r/599357 (https://phabricator.wikimedia.org/T253842) [00:44:20] (03CR) 10Aron Manning: "This change is ready for review." [skins/Vector] - 10https://gerrit.wikimedia.org/r/599357 (https://phabricator.wikimedia.org/T253842) (owner: 10Aron Manning) [03:46:49] (03PS1) 10Aron Manning: Make source editor font-size relative to browser font-size [skins/Vector] - 10https://gerrit.wikimedia.org/r/605435 (https://phabricator.wikimedia.org/T251469) [03:54:31] (03PS2) 10Aron Manning: [CSS] Make source editor font-size relative to browser font-size [skins/Vector] - 10https://gerrit.wikimedia.org/r/605435 (https://phabricator.wikimedia.org/T251469) [04:10:33] (03PS3) 10Aron Manning: [WIP] [CSS] Make source editor font-size relative to browser font-size [skins/Vector] - 10https://gerrit.wikimedia.org/r/605435 (https://phabricator.wikimedia.org/T251469) [04:59:19] (03CR) 10Aron Manning: "In this form these styles aren't loaded by DiscussionTools - which loads core's 'mediawiki.editfont.less' directly -, thus it's not a solu" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605435 (https://phabricator.wikimedia.org/T251469) (owner: 10Aron Manning) [05:03:53] (03PS4) 10Aron Manning: [WIP] [CSS] Make source editor font-size relative to browser font-size [skins/Vector] - 10https://gerrit.wikimedia.org/r/605435 (https://phabricator.wikimedia.org/T245476) [05:57:13] (03PS5) 10Aron Manning: [WIP] [CSS] Make source editor font-size relative to browser font-size [skins/Vector] - 10https://gerrit.wikimedia.org/r/605435 (https://phabricator.wikimedia.org/T245476) [05:57:15] (03PS1) 10Aron Manning: [WIP] [CSS] Serve .mw-editfont-* styles on all pages [skins/Vector] - 10https://gerrit.wikimedia.org/r/605443 (https://phabricator.wikimedia.org/T245476) [06:03:06] (03CR) 10Aron Manning: "3 libraries are already tracked, their version matches" [skins/Vector] - 10https://gerrit.wikimedia.org/r/599361 (owner: 10Aron Manning) [06:06:39] (03CR) 10Aron Manning: "This change is ready for review." [skins/Vector] - 10https://gerrit.wikimedia.org/r/605435 (https://phabricator.wikimedia.org/T245476) (owner: 10Aron Manning) [06:21:29] (03CR) 10Aron Manning: "The hack's sibling selector requires the checkbox to be above the affected elements (content, button, sidebar). This is an unavoidable con" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [07:16:34] 10Pywikibot, 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team, and 2 others: Jenkins can't merge patchsets sometimes - https://phabricator.wikimedia.org/T252310 (10hashar) That is the same as previously, whenever the `python2` or `stable` tags are updated, git would plainly ref... [07:20:38] 10Pywikibot, 10Continuous-Integration-Infrastructure, 10Regression, 10Release-Engineering-Team (CI & Testing services), and 2 others: pywikibot get merge rejections due to zuul-merger not being able to update tags - https://phabricator.wikimedia.org/T252310 (10hashar) a:03hashar [07:22:08] 10Pywikibot, 10Continuous-Integration-Infrastructure, 10Regression, 10Release-Engineering-Team (CI & Testing services), and 2 others: pywikibot get merge rejections due to zuul-merger not being able to update tags - https://phabricator.wikimedia.org/T252310 (10hashar) I have updated the repositories that w... [07:33:56] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605402 (owner: 10Beta16) [07:34:57] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605363 (https://phabricator.wikimedia.org/T255349) (owner: 10Xqt) [07:35:07] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/602298 (https://phabricator.wikimedia.org/T254435) (owner: 10Xqt) [07:35:21] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/542456 (owner: 10Gary Benson) [07:39:11] (03PS2) 10Xqt: Add asteroids 162173 Ryugu (Q1385178) and 101955 Bennu (Q11558) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605402 (owner: 10Beta16) [07:41:55] 10Pywikibot, 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10Regression, and 3 others: pywikibot get merge rejections due to zuul-merger not being able to update tags - https://phabricator.wikimedia.org/T252310 (10Xqt) 05Open→03Resolved @hashar: thanks a lot! [07:44:46] 10Pywikibot, 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10Regression, and 3 others: pywikibot get merge rejections due to zuul-merger not being able to update tags - https://phabricator.wikimedia.org/T252310 (10hashar) Repro: ` git --version # 2.20.1 pip2 install --user GitPython==2.1.11... [07:45:00] 10Pywikibot, 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10Regression, and 3 others: pywikibot get merge rejections due to zuul-merger not being able to update tags - https://phabricator.wikimedia.org/T252310 (10hashar) 05Resolved→03Open [07:45:03] (03CR) 10Xqt: [C: 03+2] Add asteroids 162173 Ryugu (Q1385178) and 101955 Bennu (Q11558) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605402 (owner: 10Beta16) [07:47:59] (03Merged) 10jenkins-bot: Add asteroids 162173 Ryugu (Q1385178) and 101955 Bennu (Q11558) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605402 (owner: 10Beta16) [07:50:55] 10Pywikibot, 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10Regression, and 3 others: pywikibot get merge rejections due to zuul-merger not being able to update tags - https://phabricator.wikimedia.org/T252310 (10hashar) I will update Zuul in production when I get time ahead to properly mon... [09:12:59] (03PS1) 10Xqt: [IMPR] Do not use hardcoded url with wikidata [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605537 [09:13:08] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Do not use hardcoded url with wikidata [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605537 (owner: 10Xqt) [09:14:17] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605537 (owner: 10Xqt) [09:15:57] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605363 (https://phabricator.wikimedia.org/T255349) (owner: 10Xqt) [09:19:14] (03PS2) 10Xqt: [IMPR] Do not use hardcoded url with wikidata [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605537 [09:22:00] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Do not use hardcoded url with wikidata [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605537 (owner: 10Xqt) [09:23:34] (03PS3) 10Xqt: [IMPR] Do not use hardcoded url with wikidata [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605537 [09:44:37] (03PS1) 10Xqt: [doc] Update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605547 [10:53:23] (03PS2) 10Vas Yaremchuk: Drop wgVectorResponsive support from modern Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/605210 (https://phabricator.wikimedia.org/T254378) [12:04:12] 10Pywikibot, 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10Regression, and 3 others: pywikibot get merge rejections due to zuul-merger not being able to update tags - https://phabricator.wikimedia.org/T252310 (10hashar) [12:08:53] (03CR) 10Beta16: [C: 03+1] [IMPR] Do not use hardcoded url with wikidata [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605537 (owner: 10Xqt) [13:30:55] 10Pywikibot, 10Continuous-Integration-Infrastructure, 10Regression, 10Release-Engineering-Team (CI & Testing services), and 2 others: pywikibot get merge rejections due to zuul-merger not being able to update tags - https://phabricator.wikimedia.org/T252310 (10hashar) I have updated the `zuul-merger` on `c... [13:55:31] (03CR) 10Dvorapa: [C: 03+1] [doc] Update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605547 (owner: 10Xqt) [14:27:06] (03CR) 10VolkerE: "> Patch Set 9:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605298 (owner: 10Aron Manning) [14:29:14] (03PS1) 10Xqt: [IMPR] Shorten known_families constructor [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605600 [14:31:58] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Shorten known_families constructor [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605600 (owner: 10Xqt) [14:35:20] (03PS2) 10Xqt: [IMPR] Shorten known_families constructor [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605600 [14:38:20] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Shorten known_families constructor [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605600 (owner: 10Xqt) [15:00:10] (03PS3) 10Xqt: [IMPR] Shorten known_families constructor [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605600 [15:02:07] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: installing pytest fails due to pytest-cov requirement - https://phabricator.wikimedia.org/T255349 (10Xqt) a:03Xqt [15:53:58] (03PS1) 10Xqt: [IMPR] Fill lists up to 80 chars [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605618 [16:50:31] (03PS2) 10Jdlrobson: Favor SkinTemplateNavigation::Universal [skins/Vector] - 10https://gerrit.wikimedia.org/r/605326 [16:51:53] (03PS3) 10Jdlrobson: Favor SkinTemplateNavigation::Universal [skins/Vector] - 10https://gerrit.wikimedia.org/r/605326 [17:09:26] (03CR) 10jerkins-bot: [V: 04-1] Favor SkinTemplateNavigation::Universal [skins/Vector] - 10https://gerrit.wikimedia.org/r/605326 (owner: 10Jdlrobson) [17:49:19] (03CR) 10Jdlrobson: [C: 04-1] "I think there's been a misunderstanding of the goal of this task." (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605210 (https://phabricator.wikimedia.org/T254378) (owner: 10Vas Yaremchuk) [17:50:36] (03CR) 10Jdlrobson: [C: 04-1] Drop wgVectorResponsive support from modern Vector (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605210 (https://phabricator.wikimedia.org/T254378) (owner: 10Vas Yaremchuk) [18:10:57] (03CR) 10DannyS712: [C: 03+1] "LGTM" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605547 (owner: 10Xqt) [18:17:13] (03CR) 10Dvorapa: [C: 03+2] [doc] Update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605547 (owner: 10Xqt) [18:18:27] (03CR) 10Dvorapa: [C: 03+2] [IMPR] Fill lists up to 80 chars [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605618 (owner: 10Xqt) [18:20:21] (03Merged) 10jenkins-bot: [doc] Update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605547 (owner: 10Xqt) [18:21:17] (03Merged) 10jenkins-bot: [IMPR] Fill lists up to 80 chars [pywikibot/core] - 10https://gerrit.wikimedia.org/r/605618 (owner: 10Xqt) [18:40:36] (03CR) 10Jdlrobson: [C: 04-1] [fix][dev] use "skin" module for JavaScript, not "Vector" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/602192 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [19:08:59] (03CR) 10Jdlrobson: [C: 04-1] "Looking closer at this code, I notice that we also set it inside the onBeforePageDisplayMobile hook. I suggest that we therefore use this " (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605210 (https://phabricator.wikimedia.org/T254378) (owner: 10Vas Yaremchuk) [21:14:38] (03PS36) 10Jdlrobson: WIP [1.36] Begin merge of SkinVector and VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) [21:18:13] (03Abandoned) 10Jdlrobson: POC: Bring back the compact personal tools [skins/Vector] - 10https://gerrit.wikimedia.org/r/605344 (owner: 10Jdlrobson) [21:31:58] (03CR) 10jerkins-bot: [V: 04-1] WIP [1.36] Begin merge of SkinVector and VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [21:38:30] (03PS17) 10Jdlrobson: SkinTemplateVector: Big switchermovearoo [skins/Vector] - 10https://gerrit.wikimedia.org/r/592790 (https://phabricator.wikimedia.org/T251212) [21:38:33] (03PS7) 10Jdlrobson: Generalize the Mustache renderer [skins/Vector] - 10https://gerrit.wikimedia.org/r/599972 [21:38:37] (03PS1) 10Jdlrobson: SkinTemplateVector -> SkinVector [skins/Vector] - 10https://gerrit.wikimedia.org/r/605675 [21:46:56] (03PS1) 10Jdlrobson: [refactor] encapsulate footer data in single function [skins/Vector] - 10https://gerrit.wikimedia.org/r/605677 [22:00:26] (03Abandoned) 10Jdlrobson: [modern] Drop collapsibleTabs from Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/601371 (owner: 10Jdlrobson) [22:02:15] (03CR) 10jerkins-bot: [V: 04-1] Generalize the Mustache renderer [skins/Vector] - 10https://gerrit.wikimedia.org/r/599972 (owner: 10Jdlrobson) [22:02:36] (03CR) 10jerkins-bot: [V: 04-1] SkinTemplateVector -> SkinVector [skins/Vector] - 10https://gerrit.wikimedia.org/r/605675 (owner: 10Jdlrobson) [22:07:36] (03PS6) 10Jdlrobson: [modern] Hide header when printing, show old logo instead [skins/Vector] - 10https://gerrit.wikimedia.org/r/599357 (https://phabricator.wikimedia.org/T253842) (owner: 10Aron Manning) [22:11:45] (03CR) 10jerkins-bot: [V: 04-1] SkinTemplateVector: Big switchermovearoo [skins/Vector] - 10https://gerrit.wikimedia.org/r/592790 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [22:16:11] (03CR) 10Jdlrobson: [C: 04-1] [modern] Hide header when printing, show old logo instead (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/599357 (https://phabricator.wikimedia.org/T253842) (owner: 10Aron Manning) [22:20:30] (03PS3) 10Jdlrobson: [less] Normalize focus styles in Blink based browsers [skins/Vector] - 10https://gerrit.wikimedia.org/r/604945 (https://phabricator.wikimedia.org/T245887) (owner: 10VolkerE) [22:20:41] (03PS2) 10Jdlrobson: [less] Amend subtle color to WikimediaUI Base default [skins/Vector] - 10https://gerrit.wikimedia.org/r/604970 (https://phabricator.wikimedia.org/T254474) (owner: 10VolkerE) [22:21:06] (03CR) 10Jdlrobson: [C: 03+2] [less] Amend subtle color to WikimediaUI Base default [skins/Vector] - 10https://gerrit.wikimedia.org/r/604970 (https://phabricator.wikimedia.org/T254474) (owner: 10VolkerE) [22:25:43] (03CR) 10Jdlrobson: [C: 03+2] [less] Normalize focus styles in Blink based browsers [skins/Vector] - 10https://gerrit.wikimedia.org/r/604945 (https://phabricator.wikimedia.org/T245887) (owner: 10VolkerE) [22:35:17] (03PS37) 10Jdlrobson: [1.36] Begin merge of SkinVector and VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) [22:35:35] (03CR) 10Jdlrobson: [C: 03+1] Remove unused `mw-checkbox-hack-target` class [skins/Vector] - 10https://gerrit.wikimedia.org/r/604870 (owner: 10VolkerE) [22:36:10] (03CR) 10Jdlrobson: "Volker - worth pursuing?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605339 (owner: 10Jdlrobson) [22:38:18] (03PS2) 10Jdlrobson: build: Update devDependencies [skins/Vector] - 10https://gerrit.wikimedia.org/r/603639 (owner: 10Esanders) [22:41:26] (03Merged) 10jenkins-bot: [less] Amend subtle color to WikimediaUI Base default [skins/Vector] - 10https://gerrit.wikimedia.org/r/604970 (https://phabricator.wikimedia.org/T254474) (owner: 10VolkerE) [22:44:28] (03Merged) 10jenkins-bot: [less] Normalize focus styles in Blink based browsers [skins/Vector] - 10https://gerrit.wikimedia.org/r/604945 (https://phabricator.wikimedia.org/T245887) (owner: 10VolkerE) [22:45:03] (03CR) 10VolkerE: Remove unused `mw-checkbox-hack-target` class (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/604870 (owner: 10VolkerE) [22:46:41] (03Abandoned) 10Jdlrobson: WIP: addPortletLink should reveal hidden menus [skins/Vector] - 10https://gerrit.wikimedia.org/r/599437 (https://phabricator.wikimedia.org/T253938) (owner: 10Jdlrobson) [22:53:21] (03CR) 10jerkins-bot: [V: 04-1] [1.36] Begin merge of SkinVector and VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [22:57:05] (03CR) 10jerkins-bot: [V: 04-1] build: Update devDependencies [skins/Vector] - 10https://gerrit.wikimedia.org/r/603639 (owner: 10Esanders) [22:57:17] (03PS1) 10Jdlrobson: Add a unique class to all menus [skins/Vector] - 10https://gerrit.wikimedia.org/r/605693 [22:58:56] (03CR) 10Jdlrobson: [C: 04-1] "https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/605693 Add a unique class to all menus would be a more simple way to achi" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605298 (owner: 10Aron Manning) [23:00:03] (03CR) 10Jdlrobson: [C: 04-1] "some eslint errors still exist" [skins/Vector] - 10https://gerrit.wikimedia.org/r/603639 (owner: 10Esanders) [23:00:44] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [skins/Vector] - 10https://gerrit.wikimedia.org/r/604930 (owner: 10VolkerE) [23:09:44] (03PS4) 10Jdlrobson: Favor SkinTemplateNavigation::Universal [skins/Vector] - 10https://gerrit.wikimedia.org/r/605326 [23:19:00] (03CR) 10jerkins-bot: [V: 04-1] Add a unique class to all menus [skins/Vector] - 10https://gerrit.wikimedia.org/r/605693 (owner: 10Jdlrobson) [23:21:14] (03CR) 10Jdlrobson: [C: 04-1] "If this works for everyone I'll fix up the tests." [skins/Vector] - 10https://gerrit.wikimedia.org/r/605693 (owner: 10Jdlrobson) [23:22:36] (03PS1) 10VolkerE: [less] Remove default, already inherited user-agent properties [skins/Vector] - 10https://gerrit.wikimedia.org/r/605700 [23:35:58] (03CR) 10VolkerE: [C: 03+1] "Works for me." [skins/Vector] - 10https://gerrit.wikimedia.org/r/605693 (owner: 10Jdlrobson)