[01:56:31] (03PS1) 10Samwilson: Avoid use of Sanitizer::escapeId for MW > 1.30 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606305 [02:45:34] (03PS2) 10Yaron Koren: Account for non-UTC $wgLocaltimezone in icalendar exports [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601507 (https://phabricator.wikimedia.org/T250547) (owner: 10Samwilson) [02:46:40] (03PS3) 10Aron Manning: [WIP] [modern] Move sidebar checkbox above content, sidebar button into header [skins/Vector] - 10https://gerrit.wikimedia.org/r/605427 (https://phabricator.wikimedia.org/T246420) [02:46:42] (03PS1) 10Aron Manning: Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (https://phabricator.wikimedia.org/T246427) [02:55:15] (03CR) 10Yaron Koren: [C: 03+2] Account for non-UTC $wgLocaltimezone in icalendar exports [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601507 (https://phabricator.wikimedia.org/T250547) (owner: 10Samwilson) [02:58:57] (03Merged) 10jenkins-bot: Account for non-UTC $wgLocaltimezone in icalendar exports [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/601507 (https://phabricator.wikimedia.org/T250547) (owner: 10Samwilson) [03:00:57] (03Abandoned) 10Aron Manning: [DNM-POC] Demo: Sidebar button (label) in header, Sidebar separately in #navigation [skins/Vector] - 10https://gerrit.wikimedia.org/r/592328 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [03:01:16] (03Abandoned) 10Aron Manning: [DNM-POC] Demo: Sidebar moved into header [skins/Vector] - 10https://gerrit.wikimedia.org/r/592395 (owner: 10Aron Manning) [03:04:53] (03CR) 10jerkins-bot: [V: 04-1] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [03:08:24] (03PS2) 10Aron Manning: Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (https://phabricator.wikimedia.org/T246427) [03:27:08] (03CR) 10jerkins-bot: [V: 04-1] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [03:27:30] (03CR) 10Aron Manning: "Follow-up to I8e153c0ab927f9d880a68fb9efb0bf37b91d26b2" [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [03:29:08] (03CR) 10Aron Manning: "This change is ready for review." [skins/Vector] - 10https://gerrit.wikimedia.org/r/605427 (https://phabricator.wikimedia.org/T246420) (owner: 10Aron Manning) [03:59:41] (03PS3) 10Aron Manning: Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (https://phabricator.wikimedia.org/T246427) [04:02:09] (03PS1) 10Yaron Koren: Fix for 74cda6b5cdcb - had the wrong check [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606309 [04:04:24] (03PS2) 10Yaron Koren: Fix for 74cda6b5cdcb - had the wrong check [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606309 [04:13:40] (03CR) 10Yaron Koren: [C: 03+2] Fix for 74cda6b5cdcb - had the wrong check [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606309 (owner: 10Yaron Koren) [04:16:14] (03CR) 10Yaron Koren: [C: 03+2] "." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606309 (owner: 10Yaron Koren) [04:16:26] (03Merged) 10jenkins-bot: Fix for 74cda6b5cdcb - had the wrong check [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606309 (owner: 10Yaron Koren) [04:16:31] (03CR) 10jerkins-bot: [V: 04-1] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [04:24:51] (03CR) 10Samwilson: Fix for 74cda6b5cdcb - had the wrong check (031 comment) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606309 (owner: 10Yaron Koren) [05:31:52] 10Pywikibot, 10Malayalam-Sites: Welcoming new users using Pywikibot - https://phabricator.wikimedia.org/T255744 (10Adithyak1997) [06:08:36] (03PS1) 10Xqt: [cleanup] Use FutureWarning for methods deprecated 2012 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606313 [06:10:44] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Use FutureWarning for methods deprecated 2012 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606313 (owner: 10Xqt) [06:27:19] (03PS2) 10Xqt: [cleanup] Use FutureWarning for methods deprecated 2012 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606313 [06:29:18] (03PS3) 10Xqt: [cleanup] Use FutureWarning for methods deprecated 2012 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606313 [07:49:57] (03PS4) 10Aron Manning: Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (https://phabricator.wikimedia.org/T246427) [08:04:15] (03CR) 10Aron Manning: "Sorry, disregard. The other patch is the follow-up: I3d9ac0eb20337e21e0b1fc286ccd2148118fdeea" [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [11:10:44] (03PS1) 10Xqt: [IMPR] Simplify return statements in http.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606410 [11:27:26] (03PS1) 10Xqt: [IMPR] Return explicitly in threadedhttp.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606413 [11:29:40] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Return explicitly in threadedhttp.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606413 (owner: 10Xqt) [12:13:19] (03PS1) 10Xqt: [IMPR] Add explicit return value for _query_continue and _continue [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606415 [12:15:04] (03PS2) 10Xqt: [IMPR] Return explicitly in threadedhttp.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606413 [13:21:10] (03PS1) 10Xqt: [IMPR] Add missing return statements [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606430 [13:21:52] (03PS1) 10Ammarpad: Vector: Use OutputPageBodyAttributes hook to add body attributes [skins/Vector] - 10https://gerrit.wikimedia.org/r/606431 (https://phabricator.wikimedia.org/T255698) [13:31:29] (03PS2) 10Ammarpad: Vector: Use OutputPageBodyAttributes hook to add body attributes [skins/Vector] - 10https://gerrit.wikimedia.org/r/606431 (https://phabricator.wikimedia.org/T255698) [13:43:13] (03PS1) 10Aron Manning: [DNM] Persist sidebar collapsed state client-side (rebased on HEAD) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606436 [13:43:56] (03PS1) 10Xqt: [cleanup] Cleanup getFilesFromAnHash and getImagesFromAnHash [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606438 (https://phabricator.wikimedia.org/T106121) [13:46:39] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Cleanup getFilesFromAnHash and getImagesFromAnHash [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606438 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [13:59:56] (03PS1) 10Xqt: [cleanup] return request.submit() directly [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606440 [14:09:54] (03CR) 10DannyS712: [C: 03+1] "LGTM, 1 nitpick" (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606440 (owner: 10Xqt) [14:22:28] (03PS2) 10Xqt: [cleanup] Cleanup getFilesFromAnHash and getImagesFromAnHash [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606438 (https://phabricator.wikimedia.org/T106121) [14:24:33] (03PS2) 10Xqt: [cleanup] return request.submit() directly [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606440 [14:37:16] (03CR) 10Xqt: [cleanup] return request.submit() directly (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606440 (owner: 10Xqt) [14:50:18] (03PS2) 10Yaron Koren: Avoid use of Sanitizer::escapeId for MW > 1.30 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606305 (owner: 10Samwilson) [14:50:20] (03PS1) 10Xqt: [L10N] Add welcome tempates for several ml projects [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606447 (https://phabricator.wikimedia.org/T255744) [14:58:08] (03CR) 10Yaron Koren: [C: 03+2] Avoid use of Sanitizer::escapeId for MW > 1.30 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606305 (owner: 10Samwilson) [14:58:16] (03CR) 10Yaron Koren: [C: 03+2] "Thank you!" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606305 (owner: 10Samwilson) [15:00:50] 10Pywikibot, 10Malayalam-Sites, 10Patch-For-Review: Welcoming new users using Pywikibot - https://phabricator.wikimedia.org/T255744 (10Xqt) p:05Triage→03Low a:03Xqt I added this to master branch. It will be included to stable branch in 2 or 3 weeks. Other dSettings aren't mandatory. i18n from translate... [15:04:42] (03Merged) 10jenkins-bot: Avoid use of Sanitizer::escapeId for MW > 1.30 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606305 (owner: 10Samwilson) [15:07:05] (03PS15) 10Aron Manning: [WIP] [modern] Move SearchBox into Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/602848 (https://phabricator.wikimedia.org/T249363) [15:07:07] (03PS2) 10Aron Manning: [DNM] Persist sidebar collapsed state client-side (rebased on dropdown usermenu) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606436 [15:07:21] 10Pywikibot, 10Malayalam-Sites, 10Patch-For-Review: Welcoming new users using Pywikibot - https://phabricator.wikimedia.org/T255744 (10Xqt) [15:10:22] (03PS3) 10Aron Manning: [DNM] Persist sidebar collapsed state client-side (rebased on dropdown usermenu) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606436 [15:22:39] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Persist sidebar collapsed state client-side (rebased on dropdown usermenu) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606436 (owner: 10Aron Manning) [15:22:54] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [modern] Move SearchBox into Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/602848 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [15:50:39] (03CR) 10Yaron Koren: [C: 03+2] "@Samwilson - oh, I only saw this now... I'll have to check in a fix." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606309 (owner: 10Yaron Koren) [15:52:38] (03PS1) 10Yaron Koren: Fix for b0426b2e20d - wrong class name [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606456 [15:56:03] (03PS2) 10Yaron Koren: Fix for b0426b2e20d - wrong class name [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606456 [16:12:09] 10Pywikibot, 10Pywikibot-Scripts, 10Malayalam-Sites, 10Patch-For-Review: Welcoming new users using Pywikibot - https://phabricator.wikimedia.org/T255744 (10Xqt) [16:24:31] (03PS4) 10Aron Manning: [DNM] Persist sidebar collapsed state client-side (rebased on dropdown usermenu) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606436 [16:28:11] (03CR) 10JJMC89: [L10N] Add welcome tempates for several ml projects (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606447 (https://phabricator.wikimedia.org/T255744) (owner: 10Xqt) [16:50:45] (03CR) 10Jdlrobson: [C: 03+2] Vector: Use OutputPageBodyAttributes hook to add body attributes (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606431 (https://phabricator.wikimedia.org/T255698) (owner: 10Ammarpad) [16:56:01] 10Pywikibot, 10Pywikibot-Scripts, 10Malayalam-Sites, 10Patch-For-Review: Welcoming new users using Pywikibot - https://phabricator.wikimedia.org/T255744 (10Adithyak1997) > You may verify whether pywikibot-welcome-... are translated already. Did you mean [[https://translatewiki.net/wiki/Pywikibot:Welcome-w... [17:09:19] (03Merged) 10jenkins-bot: Vector: Use OutputPageBodyAttributes hook to add body attributes [skins/Vector] - 10https://gerrit.wikimedia.org/r/606431 (https://phabricator.wikimedia.org/T255698) (owner: 10Ammarpad) [17:12:36] 10Pywikibot, 10Pywikibot-Scripts, 10Malayalam-Sites, 10Patch-For-Review: Welcoming new users using Pywikibot - https://phabricator.wikimedia.org/T255744 (10Adithyak1997) I think there is a small mistake in the code being added by @Xqt. In all the additions done by you, the template namespace has been added... [17:49:52] (03PS3) 10Jforrester: build: Upgrade eslint-config-wikimedia from 0.15.3 to 0.16.2 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/604757 [17:51:07] (03PS1) 10Jforrester: build: Drop jsonlint, job done by eslint already [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/606482 [19:27:57] (03CR) 10Nray: [C: 04-1] "Thank you for investing your time into this! I appreciate the work, and I think it is pretty close to being mergeable - I'd just like to s" (038 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605427 (https://phabricator.wikimedia.org/T246420) (owner: 10Aron Manning) [20:02:23] (03PS6) 10Jdlrobson: Drop wgVectorResponsive support from modern Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/605210 (https://phabricator.wikimedia.org/T254378) (owner: 10Vas Yaremchuk) [20:02:25] (03PS2) 10Jdlrobson: [refactor] Drop form-id template property [skins/Vector] - 10https://gerrit.wikimedia.org/r/606231 [20:02:29] (03PS3) 10Jdlrobson: [refactor] encapsulate footer data in single function [skins/Vector] - 10https://gerrit.wikimedia.org/r/605677 [20:02:54] (03CR) 10jerkins-bot: [V: 04-1] [1.36] Begin merge of SkinVector and VectorTemplate [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [20:02:56] (03CR) 10jerkins-bot: [V: 04-1] Move SkinVector methods to SkinTemplateVector [skins/Vector] - 10https://gerrit.wikimedia.org/r/592790 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [20:03:00] (03CR) 10jerkins-bot: [V: 04-1] SkinTemplateVector -> SkinVector [skins/Vector] - 10https://gerrit.wikimedia.org/r/605675 (owner: 10Jdlrobson) [20:03:04] (03CR) 10jerkins-bot: [V: 04-1] Generalize the Mustache renderer [skins/Vector] - 10https://gerrit.wikimedia.org/r/599972 (owner: 10Jdlrobson) [20:24:30] (03CR) 10jerkins-bot: [V: 04-1] Drop wgVectorResponsive support from modern Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/605210 (https://phabricator.wikimedia.org/T254378) (owner: 10Vas Yaremchuk) [20:24:49] (03CR) 10jerkins-bot: [V: 04-1] [refactor] encapsulate footer data in single function [skins/Vector] - 10https://gerrit.wikimedia.org/r/605677 (owner: 10Jdlrobson) [20:28:34] (03CR) 10jerkins-bot: [V: 04-1] [refactor] Drop form-id template property [skins/Vector] - 10https://gerrit.wikimedia.org/r/606231 (owner: 10Jdlrobson) [21:09:09] (03PS5) 10Aron Manning: [DNM] Persist sidebar collapsed state client-side (rebased on dropdown usermenu) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606436 [21:16:14] (03PS5) 10Aron Manning: Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (https://phabricator.wikimedia.org/T246427) [21:21:06] (03CR) 10Samwilson: [C: 03+2] "Looks good to me." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606456 (owner: 10Yaron Koren) [21:28:08] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Persist sidebar collapsed state client-side (rebased on dropdown usermenu) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606436 (owner: 10Aron Manning) [21:28:26] (03Merged) 10jenkins-bot: Fix for b0426b2e20d - wrong class name [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/606456 (owner: 10Yaron Koren) [21:37:30] (03CR) 10jerkins-bot: [V: 04-1] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [22:02:36] (03CR) 10Jdrewniak: "Two things when testing the patch out by tabbing through with a keyboard:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [22:29:49] (03PS1) 10Aron Manning: [WIP] [modern] Sidebar button (label) is focusable instead of the checkbox [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T246420) [22:31:10] (03PS6) 10Aron Manning: [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (https://phabricator.wikimedia.org/T246427) [22:36:37] (03CR) 10Jdrewniak: POC/WIP: Implement Page, Workspace, Content, and Article Toolbar Containers (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [22:50:37] (03CR) 10jerkins-bot: [V: 04-1] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [22:51:14] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [modern] Sidebar button (label) is focusable instead of the checkbox [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T246420) (owner: 10Aron Manning) [23:15:46] (03PS12) 10Nray: POC/WIP: Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) [23:25:45] (03CR) 10Nray: POC/WIP: Implement Page, Workspace, Content, and Article Toolbar Containers (035 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:31:18] (03CR) 10Nray: "> Two things when testing the patch out by tabbing through with a" [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:37:42] (03CR) 10Aron Manning: "> - for some reason neither the space-bar or the keyboard work to expand/collapse the sidebar" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray)