[00:05:08] (03CR) 10Jdrewniak: Implement Page, Workspace, Content, and Article Toolbar Containers (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [00:20:23] (03CR) 10Jdrewniak: Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [01:13:28] (03PS5) 10Aron Manning: [WIP] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) [01:19:13] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [01:36:49] (03CR) 10Aron Manning: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [01:54:08] (03CR) 10Aron Manning: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [02:03:06] (03CR) 10Aron Manning: "> Patch Set 5:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [02:08:20] (03PS6) 10Aron Manning: [WIP] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) [02:17:42] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [02:22:21] (03CR) 10Aron Manning: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [02:34:14] (03PS3) 10Aron Manning: [modern] Fix broken rendering of `main` and `dialog` elements in IE9-11 [skins/Vector] - 10https://gerrit.wikimedia.org/r/607157 (https://phabricator.wikimedia.org/T256092) [02:34:58] (03PS6) 10Aron Manning: Simplify SkinVector::isLegacy(), add SkinVector::skinversion property. [skins/Vector] - 10https://gerrit.wikimedia.org/r/607024 (https://phabricator.wikimedia.org/T254378) [02:35:44] (03PS13) 10Aron Manning: [dev] Add peer devDependencies to support Yarn 2 and Pnpm package managers [skins/Vector] - 10https://gerrit.wikimedia.org/r/599361 [03:29:51] (03PS17) 10Aron Manning: Add unique `.vector-menu-*` classes to all menus [skins/Vector] - 10https://gerrit.wikimedia.org/r/605298 [03:29:53] (03PS18) 10Aron Manning: [cleanup] Distinguish `.vector-menu` and `.vector-menu-personal` [skins/Vector] - 10https://gerrit.wikimedia.org/r/602847 [03:29:57] (03PS13) 10Aron Manning: Split SearchBox layout styles for legacy and modern [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) [03:30:15] (03PS16) 10Aron Manning: [DNM] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606436 (https://phabricator.wikimedia.org/T246427) [03:34:21] (03PS17) 10Aron Manning: [DNM] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606436 (https://phabricator.wikimedia.org/T246427) [03:36:03] (03PS7) 10Aron Manning: [WIP] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) [03:55:36] (03Restored) 10Aron Manning: [DNM-POC] Demo: Sidebar button (label) in header, Sidebar separately in #navigation [skins/Vector] - 10https://gerrit.wikimedia.org/r/592328 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [03:55:46] (03PS11) 10Aron Manning: [DNM-POC] Demo: Sidebar button (label) in header, Sidebar separately in #navigation [skins/Vector] - 10https://gerrit.wikimedia.org/r/592328 [03:56:00] (03CR) 10jerkins-bot: [V: 04-1] [DNM-POC] Demo: Sidebar button (label) in header, Sidebar separately in #navigation [skins/Vector] - 10https://gerrit.wikimedia.org/r/592328 (owner: 10Aron Manning) [03:56:19] (03PS12) 10Aron Manning: [DNM][POC] Demo: Sidebar button (label) in header, Sidebar separately in #navigation [skins/Vector] - 10https://gerrit.wikimedia.org/r/592328 [03:56:33] (03CR) 10jerkins-bot: [V: 04-1] [DNM][POC] Demo: Sidebar button (label) in header, Sidebar separately in #navigation [skins/Vector] - 10https://gerrit.wikimedia.org/r/592328 (owner: 10Aron Manning) [03:57:17] (03CR) 10jerkins-bot: [V: 04-1] [DNM] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606436 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [03:58:30] (03PS8) 10Aron Manning: [WIP] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 [03:59:46] (03CR) 10jerkins-bot: [V: 04-1] [DNM] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606436 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [03:59:59] (03PS9) 10Aron Manning: [WIP] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) [04:01:48] (03PS18) 10Aron Manning: [DNM] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606436 [04:02:31] (03Abandoned) 10Aron Manning: [DNM][POC] Demo: Sidebar button (label) in header, Sidebar separately in #navigation [skins/Vector] - 10https://gerrit.wikimedia.org/r/592328 (owner: 10Aron Manning) [04:08:41] (03PS19) 10Aron Manning: [DNM] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606436 [04:14:25] (03CR) 10Aron Manning: [cleanup] Move Personal menu styles up to Header styles (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605328 (owner: 10Aron Manning) [04:16:12] (03CR) 10Aron Manning: "Legacy "change" split as requested in" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [04:31:11] 10Africa-Wikimedia-Developers, 10MediaWiki-extensions-UrlShortener, 10Patch-Needs-Improvement, 10good first task: Include the protocol in the ajax popup for shortened URLs and Special:UrlShortener - https://phabricator.wikimedia.org/T141705 (10Aklapper) [04:44:48] (03PS1) 10Aron Manning: Fix search jumplink [skins/Vector] - 10https://gerrit.wikimedia.org/r/607405 [04:50:59] (03CR) 10Aron Manning: "This change is ready for review." [skins/Vector] - 10https://gerrit.wikimedia.org/r/607405 (owner: 10Aron Manning) [04:53:11] (03CR) 10Aron Manning: "Not done: testing with screenreader." [skins/Vector] - 10https://gerrit.wikimedia.org/r/607405 (owner: 10Aron Manning) [05:15:56] (03CR) 10Aron Manning: Implement Page, Workspace, Content, and Article Toolbar Containers (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [05:55:21] (03PS1) 10Aron Manning: Move indicators underneath firstHeading (float layout) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607412 (https://phabricator.wikimedia.org/T248761) [06:14:28] (03CR) 10jerkins-bot: [V: 04-1] Move indicators underneath firstHeading (float layout) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607412 (https://phabricator.wikimedia.org/T248761) (owner: 10Aron Manning) [06:29:33] (03PS2) 10Aron Manning: Move indicators underneath firstHeading (float layout) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607412 (https://phabricator.wikimedia.org/T248761) [07:51:06] (03CR) 10Matěj Suchánek: "So what do we want? This or Ie12ddb65f2ed9a9d520b39a4c372d3ee5d9f6309?" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/602984 (owner: 10Xqt) [08:53:27] (03CR) 10Xqt: "> So what do we want? This or Ie12ddb65f2ed9a9d520b39a4c372d3ee5d9f6309?" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/602984 (owner: 10Xqt) [10:44:17] (03PS1) 10Ckram: This commit is for testing purpose. [extensions/examples] - 10https://gerrit.wikimedia.org/r/607466 [10:51:36] (03Abandoned) 10Ckram: This commit is for testing purpose. [extensions/examples] - 10https://gerrit.wikimedia.org/r/607466 (owner: 10Ckram) [10:52:38] (03CR) 10Aklapper: "Hi Kaushik Ram! Congratulations to your patch in Wikimedia Gerrit, however this is not a place to play. If you only want to play with Wiki" [extensions/examples] - 10https://gerrit.wikimedia.org/r/607466 (owner: 10Ckram) [11:01:22] (03CR) 10Ckram: "> Hi Kaushik Ram! Congratulations to your patch in Wikimedia Gerrit," [extensions/examples] - 10https://gerrit.wikimedia.org/r/607466 (owner: 10Ckram) [11:09:36] (03CR) 10Aklapper: "Thanks, Ckram! I was afraid so. :) We have asked the maintainers of tutorialspoint.com several times already to please stop that..." [extensions/examples] - 10https://gerrit.wikimedia.org/r/607466 (owner: 10Ckram) [11:52:10] 10Pywikibot, 10Pywikibot-Wikidata: Wikibase operations fail when -simulate enabled - https://phabricator.wikimedia.org/T76694 (10Xqt) Update traceback as follows: ` >>> import pwb, pywikibot >>> datasite = pywikibot.site.DataSite('test', 'wikidata', None) >>> item = pywikibot.page.ItemPage(datasite, 'Q68') >>>... [12:39:52] 10Pywikibot: windows unicode directory names fail on py2 - https://phabricator.wikimedia.org/T96127 (10Xqt) 05Open→03Declined Declined in favour of Python 3. Python 2 will be dropped at the end of this month. [12:39:54] 10Pywikibot: Pywikibot Python 2 compatibility (tracking) - https://phabricator.wikimedia.org/T243770 (10Xqt) [12:44:02] 10Pywikibot: Deprecation warning fails with UnicodeDecoreError - https://phabricator.wikimedia.org/T134254 (10Xqt) 05Open→03Declined Declined in favour of Python 3. Python 2 will be dropped at the end of this month. [12:44:04] 10Pywikibot: Pywikibot Python 2 compatibility (tracking) - https://phabricator.wikimedia.org/T243770 (10Xqt) [14:37:55] (03CR) 10Aron Manning: "Alternative using float layout:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605300 (https://phabricator.wikimedia.org/T248761) (owner: 10Aron Manning) [14:38:48] (03CR) 10Aron Manning: "This change is ready for review." [skins/Vector] - 10https://gerrit.wikimedia.org/r/607412 (https://phabricator.wikimedia.org/T248761) (owner: 10Aron Manning) [15:17:45] (03PS3) 10Aron Manning: Move indicators underneath firstHeading (float layout) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607412 (https://phabricator.wikimedia.org/T248761) [15:37:38] (03CR) 10D3r1ck01: [C: 03+2] [cleanup] Replace deprecated upload_image() by upload_file() [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606656 (owner: 10Xqt) [15:42:23] (03CR) 10D3r1ck01: [C: 03+2] [IMPR] derive ReplaceRobot from ExistingPageBot [pywikibot/core] - 10https://gerrit.wikimedia.org/r/589900 (owner: 10Xqt) [15:44:10] (03PS4) 10Nray: Move sidebar into header to improve tab order [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) [15:44:29] (03CR) 10Nray: Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [15:45:33] (03Merged) 10jenkins-bot: [IMPR] derive ReplaceRobot from ExistingPageBot [pywikibot/core] - 10https://gerrit.wikimedia.org/r/589900 (owner: 10Xqt) [16:15:51] (03CR) 10Aron Manning: [C: 03+1] "LGTM" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [16:23:53] (03PS7) 10Aron Manning: Simplify SkinVector::isLegacy(), add SkinVector::skinversion property. [skins/Vector] - 10https://gerrit.wikimedia.org/r/607024 (https://phabricator.wikimedia.org/T254378) [16:25:51] (03PS7) 10Aron Manning: [WIP] [CSS] Make source editor font-size relative to browser font-size [skins/Vector] - 10https://gerrit.wikimedia.org/r/605435 (https://phabricator.wikimedia.org/T245476) [16:25:53] (03PS3) 10Aron Manning: [WIP] [CSS] Serve .mw-editfont-* styles on all pages [skins/Vector] - 10https://gerrit.wikimedia.org/r/605443 (https://phabricator.wikimedia.org/T245476) [16:26:07] (03PS2) 10Aron Manning: Fix search jumplink [skins/Vector] - 10https://gerrit.wikimedia.org/r/607405 [16:41:03] (03PS1) 10Xqt: [cleanup] Replace deprecated upload_image() by upload_file() [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607555 [16:44:24] (03CR) 10Xqt: [C: 03+2] [cleanup] Replace deprecated upload_image() by upload_file() [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607555 (owner: 10Xqt) [16:54:18] (03PS2) 10Xqt: [cleanup] show a FutureWarning for deprecated debug and uploadByUrl parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606656 [17:58:14] (03PS5) 10Nray: Move sidebar into header to improve tab order [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) [18:00:35] (03Restored) 10Aron Manning: [Abandoned] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (owner: 10Aron Manning) [18:00:45] (03Abandoned) 10Aron Manning: [Abandoned] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/606307 (owner: 10Aron Manning) [18:58:33] (03PS19) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) [19:06:31] (03CR) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [19:18:10] (03CR) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers (034 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [19:40:37] (03CR) 10Jdlrobson: [C: 04-1] "Marking as WIP while core change is -1ed to get it out of my review queue. Please start review when you are ready for me to take another l" [skins/Vector] - 10https://gerrit.wikimedia.org/r/599611 (https://phabricator.wikimedia.org/T254195) (owner: 10VolkerE) [19:43:28] (03CR) 10Jdlrobson: "Piotr/Stephen: does this make sense? With Sam out I'm not too familiar with how we want to use SkinVersion and feature management." [skins/Vector] - 10https://gerrit.wikimedia.org/r/607024 (https://phabricator.wikimedia.org/T254378) (owner: 10Aron Manning) [19:48:03] (03CR) 10Jdlrobson: [C: 03+1] Move sidebar into header to improve tab order [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [19:55:49] (03CR) 10Jdlrobson: "If the goal is to ship new styles for modern, consider mirroring what we do with resources/skins.vector.styles/Sidebar.less" (034 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [19:57:48] (03CR) 10Jdlrobson: [C: 04-1] "nitpick" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605328 (owner: 10Aron Manning) [19:59:19] (03CR) 10Jdlrobson: "Since tasks is still in analysis marking as WIP. Thanks for looking into this Aron." [skins/Vector] - 10https://gerrit.wikimedia.org/r/607412 (https://phabricator.wikimedia.org/T248761) (owner: 10Aron Manning) [20:04:10] (03CR) 10Jdlrobson: [C: 03+1] "Only +1 because of the proposed name change in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/607077/" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607157 (https://phabricator.wikimedia.org/T256092) (owner: 10Aron Manning) [20:07:24] (03CR) 10Nray: Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [20:19:34] (03CR) 10Jdlrobson: [C: 03+1] Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [20:24:03] (03CR) 10Jdlrobson: [C: 04-1] [cleanup] Move Personal menu styles up to Header styles (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605328 (owner: 10Aron Manning) [20:41:53] (03CR) 10VolkerE: "An interesting idea! First reaction to consider here, is that we'd need to think if this change of behaviour might be a problem for for A" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607405 (owner: 10Aron Manning) [20:42:04] 10Pywikibot, 10MediaWiki-API, 10Pywikibot-Wikidata, 10Pywikibot-tests, 10Upstream: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10BPirkle) [20:43:01] (03CR) 10VolkerE: "Related to T240489" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607405 (owner: 10Aron Manning) [20:45:31] (03PS3) 10VolkerE: Make search jumplink's target the search input instead of the container [skins/Vector] - 10https://gerrit.wikimedia.org/r/607405 (owner: 10Aron Manning) [20:45:40] (03CR) 10VolkerE: [C: 03+2] Make search jumplink's target the search input instead of the container [skins/Vector] - 10https://gerrit.wikimedia.org/r/607405 (owner: 10Aron Manning) [20:59:12] (03CR) 10Aron Manning: Implement Page, Workspace, Content, and Article Toolbar Containers (036 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [21:08:56] (03Merged) 10jenkins-bot: Make search jumplink's target the search input instead of the container [skins/Vector] - 10https://gerrit.wikimedia.org/r/607405 (owner: 10Aron Manning) [21:15:00] (03CR) 10Aron Manning: Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [21:17:55] (03CR) 10Aron Manning: [C: 03+1] "IMO Focus style is non-blocking and worthy of some more discussion taking into account T245887." [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [21:20:56] (03PS16) 10Aron Manning: [modern] Handle SPACE and ENTER key on checkbox button (label) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T254851) [21:20:58] (03PS10) 10Aron Manning: [WIP] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) [21:21:17] (03CR) 10jerkins-bot: [V: 04-1] [modern] Handle SPACE and ENTER key on checkbox button (label) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T254851) (owner: 10Aron Manning) [21:21:26] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [21:28:55] (03CR) 10Aron Manning: "Ok, that will require 3 files:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [21:36:17] (03CR) 10Jdlrobson: Add a unique class to all menus (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605693 (owner: 10Jdlrobson) [21:36:43] (03PS3) 10Jdlrobson: Add a unique class to all menus [skins/Vector] - 10https://gerrit.wikimedia.org/r/605693 [21:41:53] (03CR) 10Jdlrobson: [C: 04-1] "As an alternative to https://gerrit.wikimedia.org/r/605693 I'm happy to go ahead with this and limit it to only the required menus provide" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605298 (owner: 10Aron Manning) [21:43:35] (03CR) 10Jdlrobson: "> How would you name the common file (including the path)? Is it ok in /common/ ?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [21:44:49] (03CR) 10Jdlrobson: "I think this helps Nick's work, so might be time to rebase and merge this? What do you all think?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (owner: 10Aron Manning) [21:54:34] (03CR) 10Nray: [C: 03+1] [modern] Vertically align the PersonalMenu with the Logo (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (owner: 10Aron Manning) [21:57:34] (03CR) 10jerkins-bot: [V: 04-1] Add a unique class to all menus [skins/Vector] - 10https://gerrit.wikimedia.org/r/605693 (owner: 10Jdlrobson) [22:08:51] (03CR) 10Aron Manning: "> If you find yourself needing different styles inside common for legacy/modern" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [22:22:11] (03CR) 10Aron Manning: "Thank you for the merge!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607405 (owner: 10Aron Manning) [22:23:58] (03CR) 10Aron Manning: [C: 03+1] Make search jumplink's target the search input instead of the container (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607405 (owner: 10Aron Manning) [22:39:52] (03PS30) 10Aron Manning: [modern] Vertically align the PersonalMenu with the Logo [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 [22:48:58] (03CR) 10Aron Manning: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [22:51:38] (03CR) 10VolkerE: Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [22:59:07] (03CR) 10Aron Manning: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T254851) (owner: 10Aron Manning) [23:03:56] (03CR) 10Aron Manning: "Rebased, RTM." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (owner: 10Aron Manning) [23:09:21] (03CR) 10VolkerE: Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:09:27] (03CR) 10VolkerE: [C: 04-1] Move sidebar into header to improve tab order [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:15:55] (03CR) 10Nray: Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:25:11] (03CR) 10Jdlrobson: "> No, I didn't mean to ask that. Correction:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [23:28:41] (03PS14) 10Aron Manning: Split SearchBox layout styles for legacy and modern [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) [23:39:59] (03PS4) 10Aron Manning: [modern] Fix broken rendering of `main` and `dialog` elements in IE9-11 [skins/Vector] - 10https://gerrit.wikimedia.org/r/607157 (https://phabricator.wikimedia.org/T256092) [23:40:19] (03CR) 10Aron Manning: "This change is ready for review." [skins/Vector] - 10https://gerrit.wikimedia.org/r/607157 (https://phabricator.wikimedia.org/T256092) (owner: 10Aron Manning) [23:43:34] (03CR) 10VolkerE: [C: 04-1] Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:44:27] (03CR) 10VolkerE: [C: 04-1] "Don't get this to work together with @nray's patch at the moment." [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T254851) (owner: 10Aron Manning) [23:46:01] (03CR) 10VolkerE: [C: 04-1] "Therefor and for better blaming I'd suggest to separate concerns in two different patches." [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:47:17] (03CR) 10jerkins-bot: [V: 04-1] Split SearchBox layout styles for legacy and modern [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning)