[00:17:46] (03CR) 10Aron Manning: "Works for me ;-)" [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T254851) (owner: 10Aron Manning) [00:32:03] (03PS2) 10VolkerE: Remove unused `mw-checkbox-hack-target` class [skins/Vector] - 10https://gerrit.wikimedia.org/r/604870 [00:32:32] (03CR) 10VolkerE: [C: 03+1] Remove unused `mw-checkbox-hack-target` class [skins/Vector] - 10https://gerrit.wikimedia.org/r/604870 (owner: 10VolkerE) [00:35:56] (03CR) 10Niedzielski: [C: 03+2] Remove unused `mw-checkbox-hack-target` class [skins/Vector] - 10https://gerrit.wikimedia.org/r/604870 (owner: 10VolkerE) [00:39:48] (03CR) 10Krinkle: [WIP] [modern] Persist sidebar collapsed state client-side (037 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [00:41:15] (03PS15) 10Aron Manning: Split SearchBox layout styles for legacy and modern [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) [00:46:57] (03CR) 10Aron Manning: Split SearchBox layout styles for legacy and modern (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [00:57:10] (03Merged) 10jenkins-bot: Remove unused `mw-checkbox-hack-target` class [skins/Vector] - 10https://gerrit.wikimedia.org/r/604870 (owner: 10VolkerE) [00:59:51] (03CR) 10Aron Manning: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T254851) (owner: 10Aron Manning) [01:16:55] (03CR) 10Aron Manning: "Thanks for the feedback, these are good ideas, WIP." (037 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) (owner: 10Aron Manning) [01:23:17] (03CR) 10Aron Manning: Split SearchBox layout styles for legacy and modern (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [01:24:58] (03CR) 10Aron Manning: "Ack, WIP." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605298 (owner: 10Aron Manning) [01:28:12] (03CR) 10Aron Manning: [cleanup] Move Personal menu styles up to Header styles (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605328 (owner: 10Aron Manning) [02:44:11] (03PS1) 10VolkerE: Put ARIA roles and attributes into context [skins/Vector] - 10https://gerrit.wikimedia.org/r/607651 (https://phabricator.wikimedia.org/T254851) [02:45:30] (03CR) 10VolkerE: [C: 04-1] "ARIA parts split out into Ife287fc8c6e0d2aee5facf42d5d4308dea918ee3" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [02:50:09] (03CR) 10VolkerE: Put ARIA roles and attributes into context (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607651 (https://phabricator.wikimedia.org/T254851) (owner: 10VolkerE) [03:08:30] (03CR) 10VolkerE: [C: 03+1] "Waiting for Jenkins to be happy." [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T254851) (owner: 10Aron Manning) [03:16:43] (03CR) 10VolkerE: [C: 04-2] "That's not good UX to customize scrollbars away from OS default. That belongs maximal on a personal website, but is in the wrong place for" [skins/Vector] - 10https://gerrit.wikimedia.org/r/579620 (https://phabricator.wikimedia.org/T245734) (owner: 10Aron Manning) [03:17:58] (03CR) 10VolkerE: [C: 04-2] "Interesting proof of concept, but not to be applied in a project like Wikipedia." [skins/Vector] - 10https://gerrit.wikimedia.org/r/579684 (owner: 10Aron Manning) [03:57:40] (03CR) 10VolkerE: Implement Page, Workspace, Content, and Article Toolbar Containers (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [05:08:34] (03CR) 10Aron Manning: Implement Page, Workspace, Content, and Article Toolbar Containers (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [06:07:17] (03CR) 10VolkerE: [C: 04-1] Implement Page, Workspace, Content, and Article Toolbar Containers (033 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [06:09:12] (03CR) 10VolkerE: [C: 04-1] Implement Page, Workspace, Content, and Article Toolbar Containers (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [06:12:12] 10Pywikibot, 10User-Ladsgroup, 10good first task: Add Shan Wiktionary to pywikibot - https://phabricator.wikimedia.org/T256014 (10Jayprakash12345) [08:40:16] (03CR) 10Matěj Suchánek: "Looks good." (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606654 (owner: 10Xqt) [09:16:58] 10Pywikibot, 10Core Platform Team, 10MediaWiki-API, 10Pywikibot-Wikidata, and 2 others: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10Dvorapa) >>! In T242083#5954453, @Xqt wrote: > if maxlag Timeout occurs the tests are skip... [09:18:30] 10Pywikibot, 10Core Platform Team, 10MediaWiki-API, 10Pywikibot-Wikidata, and 2 others: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10Dvorapa) Asking ws:it API for namespaces gives broken list when maxlag condition occurs. N... [10:44:26] (03PS1) 10Xqt: [cleanup] print a FutureWarning for deprecated tools [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607753 [10:48:25] (03PS1) 10Xqt: [doc] __cmp__ is old Python 2. Update doc therefore. [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607755 [10:59:47] (03CR) 10jerkins-bot: [V: 04-1] [doc] __cmp__ is old Python 2. Update doc therefore. [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607755 (owner: 10Xqt) [11:35:30] (03PS2) 10Xqt: [doc] __cmp__ is old Python 2. Update doc therefore. [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607755 [12:26:05] (03CR) 10Dvorapa: [C: 03+2] [doc] __cmp__ is old Python 2. Update doc therefore. [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607755 (owner: 10Xqt) [12:26:29] (03CR) 10Dvorapa: [C: 03+2] [cleanup] print a FutureWarning for deprecated tools [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607753 (owner: 10Xqt) [12:29:00] (03Merged) 10jenkins-bot: [doc] __cmp__ is old Python 2. Update doc therefore. [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607755 (owner: 10Xqt) [12:29:23] (03Merged) 10jenkins-bot: [cleanup] print a FutureWarning for deprecated tools [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607753 (owner: 10Xqt) [12:44:53] (03PS2) 10Xqt: [doc] Update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607317 [13:15:26] 10Pywikibot, 10Toolforge, 10cloud-services-team (Kanban): E-mails from noreply@pypi.org to tools.pywikibot@tools.wmflabs.org are not forwarded to certain recipients due to SPF - https://phabricator.wikimedia.org/T249114 (10aborrero) hey @Dvorapa I suspect this is fixed now.. I just introduced some changes i... [14:21:08] (03PS31) 10Aron Manning: [modern] Move the PersonalMenu into the Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256373) [14:21:10] (03PS16) 10Aron Manning: Split SearchBox layout styles for legacy and modern [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) [14:31:22] (03PS1) 10Yaron Koren: Re-add 'ext.cargo.main' as dependency to some RL modules [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/607803 [14:33:51] (03PS2) 10Yaron Koren: Re-add 'ext.cargo.main' as dependency to some RL modules [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/607803 [14:38:45] (03CR) 10Yaron Koren: [C: 03+2] Re-add 'ext.cargo.main' as dependency to some RL modules [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/607803 (owner: 10Yaron Koren) [14:42:56] (03PS32) 10Aron Manning: [modern] Move the PersonalMenu into the Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256373) [14:42:58] (03PS17) 10Aron Manning: Split SearchBox layout styles for legacy and modern [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) [14:56:35] (03Merged) 10jenkins-bot: Re-add 'ext.cargo.main' as dependency to some RL modules [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/607803 (owner: 10Yaron Koren) [15:00:56] (03PS1) 10Yaron Koren: Fix for a531174df2df - only use SidebarBeforeOutput hook for MW 1.35+ [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/607809 [15:05:52] (03PS2) 10Yaron Koren: Fix for a531174df2df - only use SidebarBeforeOutput hook for MW 1.35+ [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/607809 [15:07:55] (03CR) 10jerkins-bot: [V: 04-1] Fix for a531174df2df - only use SidebarBeforeOutput hook for MW 1.35+ [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/607809 (owner: 10Yaron Koren) [15:25:53] (03PS3) 10Yaron Koren: Fix for a531174df2df - only use SidebarBeforeOutput hook for MW 1.35+ [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/607809 [15:31:38] (03CR) 10Yaron Koren: [C: 03+2] Fix for a531174df2df - only use SidebarBeforeOutput hook for MW 1.35+ [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/607809 (owner: 10Yaron Koren) [15:46:59] (03Merged) 10jenkins-bot: Fix for a531174df2df - only use SidebarBeforeOutput hook for MW 1.35+ [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/607809 (owner: 10Yaron Koren) [16:00:52] (03CR) 10Nray: Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [16:02:26] (03CR) 10Nray: "> ARIA parts split out into Ife287fc8c6e0d2aee5facf42d5d4308dea918ee3" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [16:05:47] (03PS2) 10Xqt: [IMPR] Improvements for deprecated_args decorator [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606654 [16:06:01] (03CR) 10Xqt: [IMPR] Improvements for deprecated_args decorator (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606654 (owner: 10Xqt) [16:07:05] (03PS2) 10Xqt: [cleanup] show a FutureWarning for decode parameter in Page.title() [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606660 [16:08:54] (03PS3) 10Xqt: [cleanup] show a FutureWarning for deprecated debug and uploadByUrl parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/606656 [16:13:54] (03CR) 10Jdlrobson: Split SearchBox layout styles for legacy and modern (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [17:22:12] (03CR) 10Jdlrobson: Put ARIA roles and attributes into context (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607651 (https://phabricator.wikimedia.org/T254851) (owner: 10VolkerE) [17:27:38] (03CR) 10VolkerE: Put ARIA roles and attributes into context (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607651 (https://phabricator.wikimedia.org/T254851) (owner: 10VolkerE) [17:34:04] (03CR) 10Aron Manning: Split SearchBox layout styles for legacy and modern (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [17:35:05] (03CR) 10Aron Manning: Split SearchBox layout styles for legacy and modern (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [17:42:38] (03CR) 10Jdlrobson: [C: 03+2] "Blocked on the core change, but looking great in browserstack.com IE9." [skins/Vector] - 10https://gerrit.wikimedia.org/r/607157 (https://phabricator.wikimedia.org/T256092) (owner: 10Aron Manning) [17:43:46] (03PS5) 10Aron Manning: [modern] Fix broken rendering of `main` and `dialog` elements in IE9-11 [skins/Vector] - 10https://gerrit.wikimedia.org/r/607157 (https://phabricator.wikimedia.org/T256092) [17:52:49] (03CR) 10Jdlrobson: [C: 04-1] [cleanup] Move Personal menu styles up to Header styles (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605328 (owner: 10Aron Manning) [17:55:09] (03CR) 10VolkerE: "This goes alongside T243126" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607651 (https://phabricator.wikimedia.org/T254851) (owner: 10VolkerE) [17:57:07] (03CR) 10Aron Manning: [cleanup] Move Personal menu styles up to Header styles (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605328 (owner: 10Aron Manning) [17:57:49] (03CR) 10Aron Manning: [cleanup] Move Personal menu styles up to Header styles (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605328 (owner: 10Aron Manning) [18:07:04] (03CR) 10Aron Manning: "Now that the patches have been reordered, I could merge this cleanup patch with" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605328 (owner: 10Aron Manning) [18:07:24] (03CR) 10Nray: Put ARIA roles and attributes into context (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607651 (https://phabricator.wikimedia.org/T254851) (owner: 10VolkerE) [18:16:40] (03PS2) 10VolkerE: Put ARIA roles and attributes into context [skins/Vector] - 10https://gerrit.wikimedia.org/r/607651 (https://phabricator.wikimedia.org/T254851) [18:17:10] (03CR) 10VolkerE: Put ARIA roles and attributes into context (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607651 (https://phabricator.wikimedia.org/T254851) (owner: 10VolkerE) [18:17:13] (03CR) 10Aron Manning: [C: 03+1] Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [18:17:37] (03PS33) 10Aron Manning: [modern] Move the PersonalMenu into the Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256373) [18:17:39] (03PS18) 10Aron Manning: Split SearchBox layout styles for legacy and modern [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) [18:19:27] (03CR) 10Jdlrobson: [C: 04-1] [cleanup] Move Personal menu styles up to Header styles (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605328 (owner: 10Aron Manning) [18:20:02] (03PS5) 10Jdlrobson: [refactor] encapsulate footer data in single function [skins/Vector] - 10https://gerrit.wikimedia.org/r/605677 [18:21:38] (03PS4) 10Jdlrobson: [refactor] Drop form-id template property [skins/Vector] - 10https://gerrit.wikimedia.org/r/606231 [18:25:06] (03CR) 10Jdlrobson: [C: 04-1] "Keeping this in a separate patch makes sense but the commit message does need expanding." [skins/Vector] - 10https://gerrit.wikimedia.org/r/605328 (owner: 10Aron Manning) [18:32:44] (03CR) 10Aron Manning: "> Keeping this in a separate patch makes sense but the commit message does need expanding." [skins/Vector] - 10https://gerrit.wikimedia.org/r/605328 (owner: 10Aron Manning) [18:37:57] (03CR) 10Dvorapa: [C: 03+1] [doc] Update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607317 (owner: 10Xqt) [18:39:17] (03CR) 10Aron Manning: [WIP] [modern] Limit content width, remove background, gradient, article border (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/589774 (https://phabricator.wikimedia.org/T246420) (owner: 10Aron Manning) [18:40:17] (03PS13) 10Aron Manning: [POC][DNM] [modern] Limit content width, remove background, gradient, article border [skins/Vector] - 10https://gerrit.wikimedia.org/r/589774 [18:40:27] (03CR) 10jerkins-bot: [V: 04-1] [POC][DNM] [modern] Limit content width, remove background, gradient, article border [skins/Vector] - 10https://gerrit.wikimedia.org/r/589774 (owner: 10Aron Manning) [18:40:54] (03PS27) 10Aron Manning: [POC][DNM] [modern] Move SearchBox into Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585851 [18:41:07] (03CR) 10jerkins-bot: [V: 04-1] [POC][DNM] [modern] Move SearchBox into Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585851 (owner: 10Aron Manning) [18:42:29] (03CR) 10Nray: [C: 03+1] "LGTM, let me know when I can +2. Note: With this patch removing focus from the checkbox, there is now this obsolete CSS:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607651 (https://phabricator.wikimedia.org/T254851) (owner: 10VolkerE) [18:45:20] (03PS3) 10Jdlrobson: [less] Merge 'content.less' and 'typography.less' [skins/Vector] - 10https://gerrit.wikimedia.org/r/606044 (owner: 10VolkerE) [18:45:56] (03CR) 10Aron Manning: [C: 03+1] "Tested without screen reader: taborder is comfortable." [skins/Vector] - 10https://gerrit.wikimedia.org/r/607651 (https://phabricator.wikimedia.org/T254851) (owner: 10VolkerE) [18:48:11] (03CR) 10VolkerE: [C: 03+1] "@Nray I'd suggest to remove it in your patch. Let's keep this ARIA and tabindex specific." [skins/Vector] - 10https://gerrit.wikimedia.org/r/607651 (https://phabricator.wikimedia.org/T254851) (owner: 10VolkerE) [18:50:58] (03CR) 10Nray: [C: 03+2] Put ARIA roles and attributes into context [skins/Vector] - 10https://gerrit.wikimedia.org/r/607651 (https://phabricator.wikimedia.org/T254851) (owner: 10VolkerE) [18:55:09] (03CR) 10Jdlrobson: [C: 03+1] "Some small questions in typography.less. You can ignore my other comments." (038 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606044 (owner: 10VolkerE) [18:57:33] (03CR) 10Niedzielski: "Unfortunately, I cannot prioritize reviewing this work right now. Since I use Gerrit notifications to track my highest priority work, I am" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607024 (https://phabricator.wikimedia.org/T254378) (owner: 10Aron Manning) [18:57:45] (03CR) 10Niedzielski: "Unfortunately, I cannot prioritize reviewing this work right now. Since I use Gerrit notifications to track my highest priority work, I am" [skins/Vector] - 10https://gerrit.wikimedia.org/r/602847 (owner: 10Aron Manning) [18:57:54] (03CR) 10Niedzielski: "Unfortunately, I cannot prioritize reviewing this work right now. Since I use Gerrit notifications to track my highest priority work, I am" [skins/Vector] - 10https://gerrit.wikimedia.org/r/585625 (https://phabricator.wikimedia.org/T253669) (owner: 10Aron Manning) [18:58:03] (03CR) 10Niedzielski: "Unfortunately, I cannot prioritize reviewing this work right now. Since I use Gerrit notifications to track my highest priority work, I am" [skins/Vector] - 10https://gerrit.wikimedia.org/r/585626 (https://phabricator.wikimedia.org/T253669) (owner: 10Aron Manning) [18:58:56] (03CR) 10Niedzielski: "I did it again. Sorry, Aron. I meant to remove only myself." [skins/Vector] - 10https://gerrit.wikimedia.org/r/602847 (owner: 10Aron Manning) [18:59:33] (03CR) 10Niedzielski: "Unfortunately, I cannot prioritize reviewing this work right now. Since I use Gerrit notifications to track my highest priority work, I am" [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T254851) (owner: 10Aron Manning) [18:59:44] (03CR) 10Niedzielski: "Unfortunately, I cannot prioritize reviewing this work right now. Since I use Gerrit notifications to track my highest priority work, I am" [skins/Vector] - 10https://gerrit.wikimedia.org/r/579620 (https://phabricator.wikimedia.org/T245734) (owner: 10Aron Manning) [19:04:03] (03CR) 10Niedzielski: "Unfortunately, I cannot prioritize reviewing this work right now. Since I use Gerrit notifications to track my highest priority work, I am" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [19:05:10] (03CR) 10Jdlrobson: "Marking as low for now until Sam and/or Piotr are available. Right now not enough people available with understanding of this part of the " [skins/Vector] - 10https://gerrit.wikimedia.org/r/607024 (https://phabricator.wikimedia.org/T254378) (owner: 10Aron Manning) [19:09:10] (03PS6) 10Nray: Move sidebar into header to improve tab order [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) [19:13:22] (03CR) 10Jdlrobson: Split SearchBox layout styles for legacy and modern (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [19:13:31] (03CR) 10Jdlrobson: [C: 04-1] "-1 for the common folder usage" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [19:20:34] (03Merged) 10jenkins-bot: Put ARIA roles and attributes into context [skins/Vector] - 10https://gerrit.wikimedia.org/r/607651 (https://phabricator.wikimedia.org/T254851) (owner: 10VolkerE) [19:21:24] (03PS7) 10Nray: Move sidebar into header to improve tab order [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) [19:23:05] (03CR) 10Aron Manning: "> I think having this file in common is super confusing and goes against the current organization of files where components live in the ma" (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [19:24:59] (03PS34) 10Aron Manning: [modern] Move the PersonalMenu into the Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256373) [19:25:02] (03PS13) 10Aron Manning: [cleanup] Code style: emphasize style section headers [skins/Vector] - 10https://gerrit.wikimedia.org/r/605328 [19:25:06] (03PS19) 10Aron Manning: Split SearchBox layout styles for legacy and modern [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) [19:26:03] (03PS1) 10Xqt: [IMPR] use 'isinstance' in favour of 'is type()' [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607865 [19:27:52] (03CR) 10Aron Manning: "Note: the approach used for Sidebar.less:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [19:30:21] (03CR) 10VolkerE: [C: 04-1] [cleanup] Code style: emphasize style section headers (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605328 (owner: 10Aron Manning) [19:35:15] (03PS17) 10Aron Manning: [modern] Handle SPACE and ENTER key on checkbox button (label) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T254851) [19:35:17] (03PS11) 10Aron Manning: [WIP] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) [19:37:51] (03CR) 10VolkerE: [less] Merge 'content.less' and 'typography.less' (033 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606044 (owner: 10VolkerE) [19:55:22] (03CR) 10VolkerE: [C: 04-1] Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [19:56:35] (03CR) 10VolkerE: [C: 04-1] "Compare focus style treatment in any browser aside of Chrome/Edge before v81 to see the different output." [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [19:58:24] (03PS1) 10Xqt: [IMPR] Decrease nested try statements [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607870 [19:59:43] (03PS2) 10Xqt: [IMPR] Decrease nested try statements [pywikibot/core] - 10https://gerrit.wikimedia.org/r/607870 [20:05:22] (03CR) 10Jdlrobson: [C: 03+2] "merging on understanding that the links will be clarified." [skins/Vector] - 10https://gerrit.wikimedia.org/r/606044 (owner: 10VolkerE) [20:06:43] (03CR) 10Aron Manning: Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [20:15:20] (03CR) 10VolkerE: [C: 04-1] Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [20:29:18] (03Merged) 10jenkins-bot: [less] Merge 'content.less' and 'typography.less' [skins/Vector] - 10https://gerrit.wikimedia.org/r/606044 (owner: 10VolkerE) [20:43:42] (03CR) 10DannyS712: [C: 03+1] "LGTM" [skins/Vector] - 10https://gerrit.wikimedia.org/r/605677 (owner: 10Jdlrobson) [20:52:10] (03PS8) 10Nray: Move sidebar into header to improve tab order [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) [20:53:18] (03CR) 10Nray: Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [20:56:34] 10Pywikibot, 10Toolforge, 10Documentation, 10Pywikibot-Documentation, 10User-srodlund: Create a "my first Pywikibot bot" tutorial for Toolforge - https://phabricator.wikimedia.org/T134495 (10srodlund) a:05srodlund→03None [21:37:16] (03CR) 10Krinkle: [C: 03+2] Remove `ext.MassMessage.autocomplete` module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/599414 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [21:43:47] (03Merged) 10jenkins-bot: Remove `ext.MassMessage.autocomplete` module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/599414 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [21:50:10] (03PS1) 10DannyS712: ext.MassMessage.content.noedit module: Don't include the nojs.css [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607890 (https://phabricator.wikimedia.org/T235944) [21:50:29] (03PS2) 10DannyS712: ext.MassMessage.content.noedit module: Don't include the nojs.css [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607890 (https://phabricator.wikimedia.org/T235944) [21:58:08] (03PS1) 10DannyS712: Merge ext.MassMessage.content.nojs.css into content.css [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) [21:59:24] (03PS2) 10DannyS712: Merge ext.MassMessage.content.nojs.css into content.css [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) [22:03:04] (03PS3) 10DannyS712: Merge ext.MassMessage.content.nojs.css into content.css [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) [22:06:52] (03CR) 10Krinkle: [C: 04-1] "Note that merging files is not neccecary (it makes no difference for the modules, and usually not expected by maintainers as it changes th" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [22:07:41] (03CR) 10DannyS712: "> Note that merging files is not neccecary (it makes no difference" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [22:17:25] (03CR) 10Krinkle: [C: 04-1] "I see, but I'd recommend you focus on the module definition and module loading first. Combining or changing css/less files will need more " [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [22:33:13] (03PS4) 10DannyS712: Merge style-only modules into ext.MassMessage.styles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) [22:33:13] (03CR) 10VolkerE: "The sidebar position seems to jump for me before/after patch" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [22:33:13] (03PS5) 10DannyS712: Merge style-only modules into ext.MassMessage.styles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) [22:34:08] (03PS6) 10DannyS712: Merge style-only modules into ext.MassMessage.styles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) [22:35:52] (03PS7) 10DannyS712: Merge style-only modules into ext.MassMessage.styles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) [22:35:57] (03CR) 10jerkins-bot: [V: 04-1] Merge style-only modules into ext.MassMessage.styles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [23:00:08] (03PS9) 10Nray: Move sidebar into header to improve tab order [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) [23:02:33] (03CR) 10Nray: "> The sidebar position seems to jump for me before/after patch" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:17:01] (03PS3) 10Krinkle: ext.MassMessage.content.noedit module: Don't include the nojs.css [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607890 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [23:18:00] (03PS4) 10Krinkle: ext.MassMessage.content.noedit: Remove redundant nojs.css [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607890 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [23:18:03] (03CR) 10Krinkle: [C: 03+2] ext.MassMessage.content.noedit: Remove redundant nojs.css [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607890 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [23:18:16] (03PS8) 10Krinkle: Merge style-only modules into ext.MassMessage.styles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [23:23:01] (03CR) 10Aron Manning: "> it's due to the header top-margin which I've adjusted for in latest patch, but I think its worth revisiting if the header should use a t" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:24:15] (03Merged) 10jenkins-bot: ext.MassMessage.content.noedit: Remove redundant nojs.css [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607890 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [23:24:47] (03CR) 10Krinkle: Merge style-only modules into ext.MassMessage.styles (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [23:25:42] (03CR) 10Aron Manning: "> The PersonalMenu patch you've asked for resolves that too:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:30:37] (03PS9) 10DannyS712: Merge style-only modules into ext.MassMessage.styles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) [23:30:45] (03CR) 10DannyS712: Merge style-only modules into ext.MassMessage.styles (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/607892 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [23:41:56] (03PS1) 10Aron Manning: [less] TOC hide link follows the WMUI focus style [skins/Vector] - 10https://gerrit.wikimedia.org/r/607905 (https://phabricator.wikimedia.org/T245887) [23:41:59] (03PS1) 10Aron Manning: [less] "More" Menu follows the WMUI focus style [skins/Vector] - 10https://gerrit.wikimedia.org/r/607906 (https://phabricator.wikimedia.org/T245887) [23:47:24] (03PS4) 10VolkerE: [less] Rename 'variables.less' to 'vector.variables.less' and unify imports order [skins/Vector] - 10https://gerrit.wikimedia.org/r/603660 [23:50:15] (03PS5) 10VolkerE: [less] Rename 'variables.less' to 'vector.variables.less' and unify imports order [skins/Vector] - 10https://gerrit.wikimedia.org/r/603660 [23:50:20] (03PS18) 10Aron Manning: [modern] Handle SPACE and ENTER key on checkbox button (label) [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T254851) [23:50:22] (03PS12) 10Aron Manning: [WIP] [modern] Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T246427) [23:52:40] (03CR) 10VolkerE: [C: 04-2] [less] Rename 'variables.less' to 'vector.variables.less' and unify imports order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603660 (owner: 10VolkerE) [23:57:46] (03CR) 10Nray: [C: 04-1] "Thank you for rebasing and your work on this." (036 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256373) (owner: 10Aron Manning)