[00:17:01] (03CR) 10VolkerE: [C: 04-1] "We must not invent any style descripting classes. This is introducing one. We're not following Atomic CSS or Tailwind CSS philosophy." [skins/Vector] - 10https://gerrit.wikimedia.org/r/608159 (https://phabricator.wikimedia.org/T245887) (owner: 10Aron Manning) [00:39:09] (03PS1) 10VolkerE: [modern] Fix rendering of `main` element in IE10 & 11 [skins/Vector] - 10https://gerrit.wikimedia.org/r/608497 (https://phabricator.wikimedia.org/T256092) [00:52:28] (03CR) 10VolkerE: [C: 03+2] Update CheckboxHack interface for future placement of `aria-expanded` on label button [skins/Vector] - 10https://gerrit.wikimedia.org/r/608451 (owner: 10Nray) [01:13:44] (03Merged) 10jenkins-bot: Update CheckboxHack interface for future placement of `aria-expanded` on label button [skins/Vector] - 10https://gerrit.wikimedia.org/r/608451 (owner: 10Nray) [01:44:41] (03CR) 10Aron Manning: "Should be a mixin?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/608159 (https://phabricator.wikimedia.org/T245887) (owner: 10Aron Manning) [05:23:53] (03CR) 10Aron Manning: [C: 03+1] "LGTM. We've been there already." [skins/Vector] - 10https://gerrit.wikimedia.org/r/608497 (https://phabricator.wikimedia.org/T256092) (owner: 10VolkerE) [06:26:37] (03CR) 10VolkerE: "To clarify, we haven't! On a pure code level, but that's not what is decisive. A new RL module that goes into production would need to go " [skins/Vector] - 10https://gerrit.wikimedia.org/r/608497 (https://phabricator.wikimedia.org/T256092) (owner: 10VolkerE) [07:16:23] (03CR) 10Aron Manning: [C: 03+1] "> To clarify, we haven't! On a pure code level," [skins/Vector] - 10https://gerrit.wikimedia.org/r/608497 (https://phabricator.wikimedia.org/T256092) (owner: 10VolkerE) [09:09:48] 10Pywikibot, 10Pywikibot-Scripts, 10Pywikibot-Wikidata: newitem.py should ignore pages with {{Delete}} - https://phabricator.wikimedia.org/T256676 (10Xqt) p:05Triage→03Low [09:12:54] 10Pywikibot, 10Pywikibot-Scripts, 10Pywikibot-Wikidata: newitem.py should ignore pages with {{Delete}} - https://phabricator.wikimedia.org/T256676 (10Xqt) @JAnD: redirect pages are skipped already. Could you please explain your description change. [09:12:58] (03PS1) 10DannyS712: Convert ext.MassMessage.autocomplete.js to packageFiles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/608474 (https://phabricator.wikimedia.org/T235944) [09:23:57] (03PS2) 10DannyS712: Convert ext.MassMessage.autocomplete.js to packageFiles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/608474 (https://phabricator.wikimedia.org/T235944) [09:29:33] (03PS3) 10DannyS712: Convert ext.MassMessage.autocomplete.js to packageFiles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/608474 (https://phabricator.wikimedia.org/T235944) [09:33:37] (03PS4) 10DannyS712: Convert ext.MassMessage.autocomplete.js to packageFiles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/608474 (https://phabricator.wikimedia.org/T235944) [09:38:35] (03PS5) 10DannyS712: Convert ext.MassMessage.autocomplete.js to packageFiles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/608474 (https://phabricator.wikimedia.org/T235944) [09:42:03] (03PS6) 10DannyS712: Convert ext.MassMessage.autocomplete.js to packageFiles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/608474 (https://phabricator.wikimedia.org/T235944) [09:44:07] (03PS7) 10DannyS712: Convert modules to use packageFiles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/608474 (https://phabricator.wikimedia.org/T235944) [09:45:03] (03CR) 10DannyS712: "This change is ready for review." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/608474 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [09:49:25] (03CR) 10jerkins-bot: [V: 04-1] Convert modules to use packageFiles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/608474 (https://phabricator.wikimedia.org/T235944) (owner: 10DannyS712) [09:50:58] (03PS8) 10DannyS712: Convert modules to use packageFiles [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/608474 (https://phabricator.wikimedia.org/T235944) [10:07:50] 10Pywikibot, 10Patch-Needs-Improvement, 10Pywikibot-compat-to-core: User.isAnonymous() gives wrong result for IP ranges - https://phabricator.wikimedia.org/T135359 (10Aklapper) [10:08:07] 10Pywikibot, 10Patch-Needs-Improvement: checkimages.py incorrectly casts many command line arguments to str() - https://phabricator.wikimedia.org/T131614 (10Aklapper) [10:08:42] 10Pywikibot, 10Documentation, 10Patch-Needs-Improvement, 10Pywikibot-Documentation: -ref option for checkimages is not documented - https://phabricator.wikimedia.org/T131613 (10Aklapper) [10:09:00] 10Pywikibot, 10Patch-Needs-Improvement: -start option does not work for checkimages.py - https://phabricator.wikimedia.org/T131603 (10Aklapper) [10:09:20] 10Pywikibot, 10Patch-Needs-Improvement: Make QueryGenerator a subclass of APIGenerator - https://phabricator.wikimedia.org/T129010 (10Aklapper) [10:09:56] 10Pywikibot, 10Pywikibot-textlib.py, 10Patch-Needs-Improvement: Provide textlib.TimeStripper.timestripper to retrieve the first timestamp too - https://phabricator.wikimedia.org/T118724 (10Aklapper) [10:10:28] 10Pywikibot, 10Pywikibot-Commons, 10Patch-Needs-Improvement: Support different file names and file descriptions in batch uploads - https://phabricator.wikimedia.org/T86300 (10Aklapper) [10:11:03] 10Pywikibot, 10Patch-Needs-Improvement: argparse support for global & pagegen arguments - https://phabricator.wikimedia.org/T76429 (10Aklapper) [10:15:07] 10Pywikibot, 10Pywikibot-Scripts, 10Patch-Needs-Improvement: fixing_redirects.py uses lower case page title in certain usecases - https://phabricator.wikimedia.org/T123892 (10Aklapper) [11:47:43] (03PS1) 10D3r1ck01: Handle return value for SidebarBeforeOutput hook (non-abortable) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/608601 [11:48:38] (03PS2) 10D3r1ck01: Fix return value for SidebarBeforeOutput hook (non-abortable) handler [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/608601 [11:49:04] (03PS3) 10D3r1ck01: Fix return value of SidebarBeforeOutput hook (non-abortable) handler [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/608601 [11:50:59] (03CR) 10D3r1ck01: "recheck" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604012 (owner: 10D3r1ck01) [11:57:53] (03CR) 10jerkins-bot: [V: 04-1] Fix return value of SidebarBeforeOutput hook (non-abortable) handler [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/608601 (owner: 10D3r1ck01) [12:00:56] (03CR) 10jerkins-bot: [V: 04-1] tests: Add automated test for CargoFieldDescription::newFromString() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/604012 (owner: 10D3r1ck01) [12:02:18] (03PS4) 10D3r1ck01: Fix return value of SidebarBeforeOutput hook (non-abortable) handler [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/608601 [13:33:09] (03CR) 10Ammarpad: [C: 03+1] Fix return value of SidebarBeforeOutput hook (non-abortable) handler [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/608601 (owner: 10D3r1ck01) [13:53:05] (03PS1) 10Peter.ovchyn: Drop wgVectorResponsive support from modern Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/608625 (https://phabricator.wikimedia.org/T254378) [13:54:04] (03PS2) 10Peter.ovchyn: Drop wgVectorResponsive support from modern Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/608625 (https://phabricator.wikimedia.org/T254378) [14:18:55] (03CR) 10jerkins-bot: [V: 04-1] Drop wgVectorResponsive support from modern Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/608625 (https://phabricator.wikimedia.org/T254378) (owner: 10Peter.ovchyn) [14:19:57] (03PS3) 10Peter.ovchyn: Drop wgVectorResponsive support from modern Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/608625 (https://phabricator.wikimedia.org/T254378) [14:46:04] (03CR) 10jerkins-bot: [V: 04-1] Drop wgVectorResponsive support from modern Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/608625 (https://phabricator.wikimedia.org/T254378) (owner: 10Peter.ovchyn) [15:16:55] (03CR) 10Aron Manning: "@Nray I just got to looking at the DOM structure. The structure is very clean, class names self-descriptive and the documentation very hel" [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [15:59:16] (03PS1) 10Xqt: [IMPR] newitem.py: ignore pages with {{delete}} templates [pywikibot/core] - 10https://gerrit.wikimedia.org/r/608658 (https://phabricator.wikimedia.org/T256676) [15:59:37] 10Pywikibot, 10Pywikibot-Scripts, 10Patch-For-Review, 10Pywikibot-Wikidata: newitem.py should ignore pages with {{Delete}} - https://phabricator.wikimedia.org/T256676 (10Xqt) a:03Xqt [16:02:13] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] newitem.py: ignore pages with {{delete}} templates [pywikibot/core] - 10https://gerrit.wikimedia.org/r/608658 (https://phabricator.wikimedia.org/T256676) (owner: 10Xqt) [16:02:19] (03PS2) 10Xqt: [IMPR] newitem.py: ignore pages with {{delete}} templates [pywikibot/core] - 10https://gerrit.wikimedia.org/r/608658 (https://phabricator.wikimedia.org/T256676) [16:03:36] (03PS3) 10Xqt: [IMPR] newitem.py: ignore pages with {{delete}} templates [pywikibot/core] - 10https://gerrit.wikimedia.org/r/608658 (https://phabricator.wikimedia.org/T256676) [16:07:57] 10Pywikibot, 10Pywikibot-textlib.py, 10Patch-Needs-Improvement: Provide textlib.TimeStripper.timestripper to retrieve the first timestamp too - https://phabricator.wikimedia.org/T118724 (10Xqt) a:05Xqt→03None [16:43:57] 10Pywikibot: Python 2 Page representation (repr) returns non-ASCII bytes - https://phabricator.wikimedia.org/T66958 (10Xqt) 05Open→03Declined Declined because Python 2 has been dropped. [16:44:00] 10Pywikibot: Pywikibot Python 2 compatibility (tracking) - https://phabricator.wikimedia.org/T243770 (10Xqt) [16:51:35] (03CR) 10Matěj Suchánek: [IMPR] newitem.py: ignore pages with {{delete}} templates (034 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/608658 (https://phabricator.wikimedia.org/T256676) (owner: 10Xqt) [16:54:54] (03PS1) 10Xqt: [tests] Remove failing test_ASCII_compatible test [pywikibot/core] - 10https://gerrit.wikimedia.org/r/608690 (https://phabricator.wikimedia.org/T130919) [16:55:43] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: page_tests.TestPageRepr.test_ASCII_compatible erroneously doesn't fail unittest - https://phabricator.wikimedia.org/T130919 (10Xqt) 05Open→03Declined Python 2 has been dropped. [16:55:46] 10Pywikibot: Pywikibot Python 2 compatibility (tracking) - https://phabricator.wikimedia.org/T243770 (10Xqt) [16:55:48] 10Pywikibot, 10Pywikibot-tests: Usages of unittest.expectedFailure should be solved (goal) - https://phabricator.wikimedia.org/T129368 (10Xqt) [16:56:50] 10Pywikibot, 10Pywikibot-Scripts, 10Pywikibot-cosmetic-changes.py, 10Pywikibot-i18n, 10Pywikibot-tests: list(dict.keys()) is not deterministic - https://phabricator.wikimedia.org/T220099 (10Xqt) [16:56:51] 10Pywikibot: Pywikibot Python 2 compatibility (tracking) - https://phabricator.wikimedia.org/T243770 (10Xqt) [16:57:29] 10Pywikibot, 10Pywikibot-Scripts, 10Patch-For-Review, 10Pywikibot-Wikidata: newitem.py should ignore pages with {{Delete}} - https://phabricator.wikimedia.org/T256676 (10JAnD) [16:58:41] 10Pywikibot: config does differ between unicode and str - https://phabricator.wikimedia.org/T95810 (10Xqt) 05Open→03Declined Python 2 has been dropped [16:58:43] 10Pywikibot: Pywikibot Python 2 compatibility (tracking) - https://phabricator.wikimedia.org/T243770 (10Xqt) [16:58:46] 10Pywikibot, 10Patch-For-Review, 10User-D3r1ck01: Usage of unicode_literals from __future__ package - https://phabricator.wikimedia.org/T89589 (10Xqt) [17:03:20] 10Pywikibot, 10Pywikibot-tests: Action 'csrf' is not allowed for user Pywikibot-test on wikisource:zh and en:wiki - https://phabricator.wikimedia.org/T226942 (10Xqt) 05Open→03Resolved a:03Xqt Haven't seen it anymore neither at enwiki/zhwiki not at wowwiki. [17:03:22] 10Pywikibot: Pywikibot Python 2 compatibility (tracking) - https://phabricator.wikimedia.org/T243770 (10Xqt) [17:03:24] 10Pywikibot, 10Pywikibot-tests: CSRF token issues (tracking) - https://phabricator.wikimedia.org/T229364 (10Xqt) [17:03:27] 10Pywikibot, 10Goal, 10Pywikibot-tests: Make Travis and Appveyor pass again - https://phabricator.wikimedia.org/T225591 (10Xqt) [17:04:31] 10Pywikibot, 10TestMe: unicodeDecodeError in url2unicode() - https://phabricator.wikimedia.org/T60574 (10Xqt) 05Open→03Resolved a:03Xqt Seems this is solved already [17:04:33] 10Pywikibot: Pywikibot Python 2 compatibility (tracking) - https://phabricator.wikimedia.org/T243770 (10Xqt) [17:04:39] 10Pywikibot, 10Tracking-Neverending: Important tasks to be solved (tracking) - https://phabricator.wikimedia.org/T72936 (10Xqt) [17:05:23] 10Pywikibot: Pywikibot Python 2 compatibility (tracking) - https://phabricator.wikimedia.org/T243770 (10Xqt) 05Open→03Resolved a:03Xqt All subtask seems solved. And Python 2 has been dropped btw. [17:05:26] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-Announce: Drop support of Python 2.7 - https://phabricator.wikimedia.org/T213287 (10Xqt) [17:09:39] 10Pywikibot, 10Pywikibot-tests: Do not test Python 3-only scripts with Python 2 - https://phabricator.wikimedia.org/T252535 (10Xqt) 05Open→03Declined Python 2 will be dropped and no tests were made for it [17:09:43] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-Announce: Drop support of Python 2.7 - https://phabricator.wikimedia.org/T213287 (10Xqt) [17:14:15] 10Pywikibot, 10Goal, 10Pywikibot-tests: Make Travis and Appveyor pass again - https://phabricator.wikimedia.org/T225591 (10Xqt) 05Open→03Resolved a:03Xqt Both Travis and Appveyor passes with rPWBC832648e845. Therefor I close this task even some of the subtasks are still open. [17:14:17] 10Pywikibot, 10Patch-For-Review, 10Pywikibot-Announce: Drop support of Python 2.7 - https://phabricator.wikimedia.org/T213287 (10Xqt) [18:14:38] (03PS4) 10Xqt: [IMPR] newitem.py: ignore pages with {{delete}} templates [pywikibot/core] - 10https://gerrit.wikimedia.org/r/608658 (https://phabricator.wikimedia.org/T256676) [18:15:15] (03CR) 10Xqt: [IMPR] newitem.py: ignore pages with {{delete}} templates (034 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/608658 (https://phabricator.wikimedia.org/T256676) (owner: 10Xqt) [18:30:05] (03CR) 10Jdlrobson: [C: 04-1] "LGTM but minor phan error to take care of - "Catching undeclared class \Vector\NoSuchServiceException" source="PhanUndeclaredClassCatch"" [skins/Vector] - 10https://gerrit.wikimedia.org/r/608625 (https://phabricator.wikimedia.org/T254378) (owner: 10Peter.ovchyn) [18:48:56] (03PS22) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) [18:50:49] (03CR) 10DannyS712: [C: 03+1] "LGTM; just noting that there are other tests in the same file that are also only for python 2 that can be removed" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/608690 (https://phabricator.wikimedia.org/T130919) (owner: 10Xqt) [19:07:25] (03PS23) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) [19:55:55] (03CR) 10Nray: "> Patch Set 21:" (037 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [19:57:18] (03PS24) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) [20:11:03] (03CR) 10Nray: "This change is ready for review." [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [21:50:14] (03CR) 10Jdlrobson: [C: 03+1] "I need to check this on cached HTML before merging. I suspect its fine, but I want to be cautious." [skins/Vector] - 10https://gerrit.wikimedia.org/r/599611 (https://phabricator.wikimedia.org/T254195) (owner: 10VolkerE) [22:09:32] (03PS25) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) [22:25:21] (03CR) 10Jdlrobson: [C: 03+1] Fix return value of SidebarBeforeOutput hook (non-abortable) handler [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/608601 (owner: 10D3r1ck01) [22:29:44] (03CR) 10Krinkle: [C: 03+2] Fix return value of SidebarBeforeOutput hook (non-abortable) handler [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/608601 (owner: 10D3r1ck01) [22:46:52] (03Merged) 10jenkins-bot: Fix return value of SidebarBeforeOutput hook (non-abortable) handler [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/608601 (owner: 10D3r1ck01) [23:14:19] (03PS21) 10Aron Manning: [modern] checkboxHack: Use one-call simplified public API [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T254851) [23:35:53] (03CR) 10jerkins-bot: [V: 04-1] [modern] checkboxHack: Use one-call simplified public API [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T254851) (owner: 10Aron Manning) [23:36:04] (03PS26) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) [23:47:07] (03CR) 10Aron Manning: "Follow-up patch that uses the simplified public API of CheckboxHack, to avoid the need for cross-repo parallel patches in the future in ca" [skins/Vector] - 10https://gerrit.wikimedia.org/r/608451 (owner: 10Nray) [23:56:32] (03CR) 10Aron Manning: "PS21: I've rewritten the SPACE-ENTER patch in core to simplify the API between Vector and core." [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T254851) (owner: 10Aron Manning)