[00:09:09] (03CR) 10Nray: [C: 04-1] "-1 only for attention. Please mote this should be merged after the branch cut to allow ample QA time. I'll check with Olga tomorrow if the" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [00:09:46] (03PS1) 10Zhuyifei1999: setup.py: Hide irrelevant messages in get_version [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609868 (https://phabricator.wikimedia.org/T171886) [00:12:13] (03CR) 10Jdlrobson: [C: 04-1] "I think having this dropped from modern for at least a week is going to provide useful data from people using office.wikimedia.org so I'd " [skins/Vector] - 10https://gerrit.wikimedia.org/r/608976 (https://phabricator.wikimedia.org/T254195) (owner: 10VolkerE) [00:13:07] (03CR) 10jerkins-bot: [V: 04-1] setup.py: Hide irrelevant messages in get_version [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609868 (https://phabricator.wikimedia.org/T171886) (owner: 10Zhuyifei1999) [00:15:12] (03PS2) 10Zhuyifei1999: setup.py: Hide irrelevant messages in get_version [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609868 (https://phabricator.wikimedia.org/T171886) [00:17:05] (03CR) 10Jdlrobson: "This is on my radar, but the focus for this week is finishing up the 1.35 release and wrapping up the fix width work. This looks like the " [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [00:17:25] (03PS45) 10Jdlrobson: [modern] Move the PersonalMenu into the Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [00:36:18] (03CR) 10jerkins-bot: [V: 04-1] [modern] Move the PersonalMenu into the Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [00:37:28] (03CR) 10VolkerE: [modern] Move the PersonalMenu into the Header (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [00:37:34] (03CR) 10VolkerE: [C: 04-1] [modern] Move the PersonalMenu into the Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [00:40:19] (03CR) 10Aron Manning: "@JdlRobson please stop editing and breaking my patches." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [00:41:36] (03CR) 10VolkerE: "Good to be split out. Don't understand why we need to go the extra way of putting it into Vector instead of core immediately…?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/609801 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [00:45:58] (03CR) 10Jdlrobson: "(It would help in the mean time to cherry pick this to master)." [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [00:47:33] (03CR) 10Jdlrobson: [C: 04-1] "(we also should continue to import one stylesheet per component)" (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [00:52:37] (03CR) 10Jdlrobson: "Aron I clicked the rebase button in gerrit. Your patch is broken. Not my fault." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [00:57:18] (03PS2) 10Aron Manning: [less] Add mediawiki.mixins.flex-align.less [skins/Vector] - 10https://gerrit.wikimedia.org/r/609801 (https://phabricator.wikimedia.org/T256893) [00:57:22] (03PS46) 10Aron Manning: [modern] Move the PersonalMenu into the Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) [00:57:26] (03PS1) 10Aron Manning: [WIP] [modern] PersonalMenu layout cleanup [skins/Vector] - 10https://gerrit.wikimedia.org/r/609881 (https://phabricator.wikimedia.org/T256893) [00:57:30] (03PS1) 10Aron Manning: [modern] Move user page icon to pseudo-element for reliable layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/609882 (https://phabricator.wikimedia.org/T257144) [01:00:12] (03CR) 10Aron Manning: "> Your patch is broken. Not my fault." [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [01:05:40] (03CR) 10jerkins-bot: [V: 04-1] [modern] Move user page icon to pseudo-element for reliable layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/609882 (https://phabricator.wikimedia.org/T257144) (owner: 10Aron Manning) [01:13:36] (03PS4) 10Aron Manning: [modern] Simplify Logo layout rules: use inline-block instead of float and flex [skins/Vector] - 10https://gerrit.wikimedia.org/r/608255 (https://phabricator.wikimedia.org/T256895) [01:18:09] (03CR) 10Aron Manning: "I've restored the working version." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [01:22:14] (03CR) 10Aron Manning: "> Good to be split out. Don't understand why we need to go the extra way of putting it into Vector instead of core immediately…?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/609801 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [01:34:18] (03PS5) 10Aron Manning: [modern] Simplify Logo layout rules: use inline-block instead of float and flex [skins/Vector] - 10https://gerrit.wikimedia.org/r/608255 (https://phabricator.wikimedia.org/T256895) [02:12:40] (03CR) 10Aron Manning: "> (It would help in the mean time to cherry pick this to master)." (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [02:54:14] (03CR) 10Xqt: "Can’t we merge https://gerrit.wikimedia.org/r/c/pywikibot/core/+/409823 in favour of hiding this message?" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609868 (https://phabricator.wikimedia.org/T171886) (owner: 10Zhuyifei1999) [02:57:23] 10Pywikibot, 10Patch-For-Review: installing pywikibot with pip fails because the package isn't a git repository; setup.py is unable to find the version of pywikibot - https://phabricator.wikimedia.org/T171886 (10Xqt) >>! In T171886#6283942, @zhuyifei1999 wrote: > Also, see above, > >>>! In T171886#6279580, @X... [03:06:24] 10Pywikibot, 10Patch-For-Review: installing pywikibot with pip fails because the package isn't a git repository; setup.py is unable to find the version of pywikibot - https://phabricator.wikimedia.org/T171886 (10zhuyifei1999) >>! In T171886#6284149, @Xqt wrote: > Installation was done as I said That was respo... [03:07:02] (03CR) 10Zhuyifei1999: "> Patch Set 2:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609868 (https://phabricator.wikimedia.org/T171886) (owner: 10Zhuyifei1999) [03:11:57] (03PS1) 10VolkerE: [modern] Fix rendering of `main` element in IE10 & 11 [skins/Vector] - 10https://gerrit.wikimedia.org/r/609895 (https://phabricator.wikimedia.org/T256092) [03:14:00] (03PS2) 10VolkerE: [modern] Fix rendering of `main` element in IE10 & 11 again [skins/Vector] - 10https://gerrit.wikimedia.org/r/609895 (https://phabricator.wikimedia.org/T256092) [03:30:48] (03CR) 10Zhuyifei1999: "two nitpicks. otherwise lgtm." (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [04:24:04] (03PS1) 10VolkerE: [less] Remove normalize rules covered by mediawiki.skinning/normalize module [skins/Vector] - 10https://gerrit.wikimedia.org/r/609897 [04:34:39] (03CR) 10VolkerE: [C: 04-1] Implement Page, Workspace, Content, and Article Toolbar Containers (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [05:15:29] 10Pywikibot, 10Patch-For-Review: installing pywikibot with pip fails because the package isn't a git repository; setup.py is unable to find the version of pywikibot - https://phabricator.wikimedia.org/T171886 (10Seppl2013) Please reopen this issue - marking it invalid since it's not reproducible in the Wikime... [05:47:48] (03PS58) 10Xqt: [IMPR] Use one central point for framework version [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) [05:52:06] (03CR) 10Xqt: [IMPR] Use one central point for framework version (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [06:10:04] (03CR) 10VolkerE: [modern] Move the PersonalMenu into the Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [06:23:02] (03CR) 10Zhuyifei1999: [C: 03+2] "LGTM" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [06:24:16] (03Abandoned) 10Zhuyifei1999: setup.py: Hide irrelevant messages in get_version [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609868 (https://phabricator.wikimedia.org/T171886) (owner: 10Zhuyifei1999) [06:31:51] 10Pywikibot, 10Patch-For-Review: installing pywikibot with pip fails because the package isn't a git repository; setup.py is unable to find the version of pywikibot - https://phabricator.wikimedia.org/T171886 (10zhuyifei1999) >>! In T171886#6284238, @Seppl2013 wrote: > Please reopen this issue - marking it inv... [06:37:05] (03CR) 10Zhuyifei1999: [C: 03+2] [4.0] Remove Python 2 dependencies [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609486 (https://phabricator.wikimedia.org/T239542) (owner: 10Xqt) [06:38:58] (03Merged) 10jenkins-bot: [4.0] Remove Python 2 dependencies [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609486 (https://phabricator.wikimedia.org/T239542) (owner: 10Xqt) [06:39:02] (03Merged) 10jenkins-bot: [IMPR] Use one central point for framework version [pywikibot/core] - 10https://gerrit.wikimedia.org/r/409823 (https://phabricator.wikimedia.org/T106121) (owner: 10Xqt) [06:41:59] (03CR) 10VolkerE: [modern] Move the PersonalMenu into the Header (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [06:42:38] 10Pywikibot, 10Patch-For-Review: installing pywikibot with pip fails because the package isn't a git repository; setup.py is unable to find the version of pywikibot - https://phabricator.wikimedia.org/T171886 (10JJMC89) Yes, I know that It does install in my case, but it looks like the version doesn't match. (... [06:45:19] (03CR) 10Zhuyifei1999: [4.0] Prepare next release 4.0 (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609515 (owner: 10Xqt) [06:48:10] (03CR) 10Zhuyifei1999: [C: 03+1] "LGTM" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609497 (https://phabricator.wikimedia.org/T213287) (owner: 10Xqt) [06:59:46] 10Pywikibot, 10Pywikibot-tests: Python is killed by recent patch - https://phabricator.wikimedia.org/T228322 (10zhuyifei1999) {P11763} [07:07:45] 10Pywikibot, 10Pywikibot-tests: Python is killed by recent patch - https://phabricator.wikimedia.org/T228322 (10zhuyifei1999) >>! In T228322#5344565, @Xqt wrote: > lang property must be resolved from siteinfo whereas code property is already given when instantiating the site object. I think TestAPIMWException.... [08:59:25] (03PS1) 10Peter.ovchyn: Select initial side bar visibility depends on user login state and defaults. [skins/Vector] - 10https://gerrit.wikimedia.org/r/609979 (https://phabricator.wikimedia.org/T254230) [09:17:46] (03PS7) 10Ammarpad: Favor SkinTemplateNavigation::Universal [skins/Vector] - 10https://gerrit.wikimedia.org/r/605326 (https://phabricator.wikimedia.org/T255319) (owner: 10Jdlrobson) [09:39:18] (03PS2) 10Peter.ovchyn: Select initial side bar visibility depends on user login state and defaults [skins/Vector] - 10https://gerrit.wikimedia.org/r/609979 (https://phabricator.wikimedia.org/T254230) [09:40:11] (03CR) 10Ammarpad: [C: 04-1] "This seems to duplicate Jan Drewniak's work in Ib1ce934. Or are they different?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/609979 (https://phabricator.wikimedia.org/T254230) (owner: 10Peter.ovchyn) [09:49:15] (03CR) 10Ammarpad: [C: 03+1] Favor SkinTemplateNavigation::Universal [skins/Vector] - 10https://gerrit.wikimedia.org/r/605326 (https://phabricator.wikimedia.org/T255319) (owner: 10Jdlrobson) [09:51:03] (03CR) 10Peter.ovchyn: "> Patch Set 1: Code-Review-1" [skins/Vector] - 10https://gerrit.wikimedia.org/r/609979 (https://phabricator.wikimedia.org/T254230) (owner: 10Peter.ovchyn) [10:01:04] (03CR) 10jerkins-bot: [V: 04-1] Select initial side bar visibility depends on user login state and defaults [skins/Vector] - 10https://gerrit.wikimedia.org/r/609979 (https://phabricator.wikimedia.org/T254230) (owner: 10Peter.ovchyn) [10:18:05] (03PS2) 10Xqt: [doc] Update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609568 [10:18:59] (03CR) 10Xqt: [4.0] Prepare next release 4.0 (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609515 (owner: 10Xqt) [10:27:48] (03PS4) 10Xqt: [tests] Remove Python 2 parts from utils.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609499 (https://phabricator.wikimedia.org/T213287) [10:28:44] (03PS4) 10Xqt: [tests] Remove six dependency [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609507 [10:29:39] (03CR) 10jerkins-bot: [V: 04-1] [tests] Remove Python 2 parts from utils.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609499 (https://phabricator.wikimedia.org/T213287) (owner: 10Xqt) [10:30:50] (03CR) 10jerkins-bot: [V: 04-1] [tests] Remove six dependency [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609507 (owner: 10Xqt) [10:38:42] (03PS3) 10Peter.ovchyn: Select initial side bar visibility depends on user login state and defaults [skins/Vector] - 10https://gerrit.wikimedia.org/r/609979 (https://phabricator.wikimedia.org/T254230) [10:44:04] (03CR) 10Peter.ovchyn: "> Patch Set 2:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/609979 (https://phabricator.wikimedia.org/T254230) (owner: 10Peter.ovchyn) [10:45:34] (03PS5) 10Xqt: [tests] Remove Python 2 parts from utils.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609499 (https://phabricator.wikimedia.org/T213287) [10:46:32] (03PS5) 10Xqt: [tests] Remove six dependency [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609507 [10:47:31] (03PS4) 10Peter.ovchyn: Select initial side bar visibility depends on user login state and defaults [skins/Vector] - 10https://gerrit.wikimedia.org/r/609979 (https://phabricator.wikimedia.org/T254230) [10:52:20] (03PS3) 10Xqt: Deprecate pywikibot.__release__ [pywikibot/core] - 10https://gerrit.wikimedia.org/r/433972 [11:05:34] (03CR) 10Aron Manning: [modern] Fix rendering of `main` element in IE10 & 11 again (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/609895 (https://phabricator.wikimedia.org/T256092) (owner: 10VolkerE) [11:11:35] (03CR) 10Aron Manning: "Apparently I've missed the contradiction between 'modern' in the comment and 'legacy' in the .json" (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/608497 (https://phabricator.wikimedia.org/T256092) (owner: 10VolkerE) [11:46:50] (03CR) 10Aron Manning: [C: 04-1] [less] Rename 'variables.less' to 'vector.variables.less' and unify imports order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603660 (owner: 10VolkerE) [11:56:58] 10Pywikibot, 10Pywikibot-RfCs: [RfC] Figure out the version format - https://phabricator.wikimedia.org/T197936 (10Xqt) 05Open→03Resolved a:03Xqt [12:22:29] (03PS30) 10Aron Manning: [modern] checkboxHack: Use one-call simplified public API [skins/Vector] - 10https://gerrit.wikimedia.org/r/606541 (https://phabricator.wikimedia.org/T257075) [12:22:33] (03PS23) 10Aron Manning: [POC] [modern] checkboxHack: Persist sidebar collapsed state client-side [skins/Vector] - 10https://gerrit.wikimedia.org/r/607188 (https://phabricator.wikimedia.org/T257169) [12:36:10] (03CR) 10Aron Manning: Move sidebar into header to improve tab order (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/607311 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [13:38:28] (03PS1) 10Xqt: [4.0] Remove code duplication of pwb.py and setup.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/610062 (https://phabricator.wikimedia.org/T239542) [14:50:28] (03PS1) 10Xqt: [4.0] Update maintenance scripts to pwb4 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/610076 [15:45:24] (03PS3) 10Aron Manning: [less] Add mediawiki.mixins.flex-align.less [skins/Vector] - 10https://gerrit.wikimedia.org/r/609801 (https://phabricator.wikimedia.org/T256893) [15:45:28] (03PS47) 10Aron Manning: [modern] Move the PersonalMenu into the Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) [15:45:32] (03PS2) 10Aron Manning: [WIP] [modern] PersonalMenu layout cleanup [skins/Vector] - 10https://gerrit.wikimedia.org/r/609881 (https://phabricator.wikimedia.org/T256893) [15:45:36] (03PS2) 10Aron Manning: [modern] Move user page icon to pseudo-element for reliable layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/609882 (https://phabricator.wikimedia.org/T257144) [15:56:46] (03CR) 10jerkins-bot: [V: 04-1] [modern] Move user page icon to pseudo-element for reliable layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/609882 (https://phabricator.wikimedia.org/T257144) (owner: 10Aron Manning) [16:11:53] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [modern] PersonalMenu layout cleanup [skins/Vector] - 10https://gerrit.wikimedia.org/r/609881 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [16:31:51] (03PS39) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) [16:33:01] (03CR) 10Nray: [C: 04-1] "I think there's still one pending concern with the page container border Volker brought up" [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [16:34:03] (03CR) 10Nray: [C: 04-1] Implement Page, Workspace, Content, and Article Toolbar Containers (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [16:53:31] (03CR) 10Jdlrobson: [less] Remove normalize rules covered by mediawiki.skinning/normalize module (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/609897 (owner: 10VolkerE) [16:54:06] (03PS3) 10Jdlrobson: [modern] Fix rendering of `main` element in IE10 & 11 again [skins/Vector] - 10https://gerrit.wikimedia.org/r/609895 (https://phabricator.wikimedia.org/T256092) (owner: 10VolkerE) [16:55:56] (03CR) 10Jdlrobson: [modern] Fix rendering of `main` element in IE10 & 11 again (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/609895 (https://phabricator.wikimedia.org/T256092) (owner: 10VolkerE) [17:21:17] (03CR) 10Zhuyifei1999: [doc] Update ROADMAP.rst (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609568 (owner: 10Xqt) [17:55:33] (03CR) 10Jdlrobson: [C: 04-1] "Nitpick in VectorTemplate" (033 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/609979 (https://phabricator.wikimedia.org/T254230) (owner: 10Peter.ovchyn) [18:11:53] (03PS5) 10Peter.ovchyn: Select initial side bar visibility depends on user login state and defaults [skins/Vector] - 10https://gerrit.wikimedia.org/r/609979 (https://phabricator.wikimedia.org/T254230) [18:33:38] (03CR) 10Nray: "I could be wrong, but my impression from Volker's comment on the ticket is that we want the solid blue focus border (not the dotted outlin" [skins/Vector] - 10https://gerrit.wikimedia.org/r/608161 (https://phabricator.wikimedia.org/T246420) (owner: 10Aron Manning) [18:48:52] (03CR) 10Jdlrobson: [C: 03+2] "works great" [skins/Vector] - 10https://gerrit.wikimedia.org/r/609979 (https://phabricator.wikimedia.org/T254230) (owner: 10Peter.ovchyn) [18:51:08] (03PS3) 10Xqt: [doc] Update ROADMAP.rst [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609568 [18:51:46] (03CR) 10Xqt: [doc] Update ROADMAP.rst (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/609568 (owner: 10Xqt) [19:00:15] (03CR) 10VolkerE: [C: 04-1] [modern] Move the PersonalMenu into the Header (035 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [19:15:35] (03PS1) 10Jdlrobson: [Dev] Move Searchbox layout rules to layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/610143 [19:17:51] (03PS2) 10Jdlrobson: [Refactor] Move Searchbox layout rules to layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/610143 [19:38:11] (03Merged) 10jenkins-bot: Select initial side bar visibility depends on user login state and defaults [skins/Vector] - 10https://gerrit.wikimedia.org/r/609979 (https://phabricator.wikimedia.org/T254230) (owner: 10Peter.ovchyn) [19:43:09] (03PS40) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) [19:43:20] (03CR) 10jerkins-bot: [V: 04-1] Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [19:47:44] (03PS41) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) [19:52:13] (03CR) 10VolkerE: Implement Page, Workspace, Content, and Article Toolbar Containers (033 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [20:22:37] (03PS1) 10Jdlrobson: Logo shouldn't import layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/610154 [20:22:41] (03PS1) 10Jdlrobson: Fix print styles on Ctrl+p and ElectronPdf [skins/Vector] - 10https://gerrit.wikimedia.org/r/610155 (https://phabricator.wikimedia.org/T253842) [20:23:01] (03CR) 10VolkerE: [C: 04-1] Implement Page, Workspace, Content, and Article Toolbar Containers (036 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [20:44:09] 10Pywikibot, 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), 10Pywikibot-Wikidata, and 2 others: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10eprodromou) [20:47:24] 10Pywikibot, 10MediaWiki-API, 10Pywikibot-Wikidata, 10Pywikibot-tests, 10Upstream: test_page_from_repository fails with EntityTypeUnknownException on multiple sites - https://phabricator.wikimedia.org/T242083 (10eprodromou) What's the question that you're asking? Is there something we can do to help make... [20:52:46] (03PS42) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) [20:53:33] (03CR) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers (038 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [21:01:10] (03CR) 10VolkerE: Logo shouldn't import layout (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/610154 (owner: 10Jdlrobson) [21:03:02] (03PS2) 10Jdlrobson: Logo shouldn't import layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/610154 [21:15:13] (03CR) 10VolkerE: [modern] Fix rendering of `main` element in IE10 & 11 again (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/609895 (https://phabricator.wikimedia.org/T256092) (owner: 10VolkerE) [21:26:05] 10Pywikibot, 10Pywikibot-Scripts: transferbot.py script's appended text is creating interwiki links instead of wiki links - https://phabricator.wikimedia.org/T257376 (10Xaosflux) [21:28:10] (03PS4) 10VolkerE: [modern] Fix rendering of `main` element in IE10 & 11 (again) [skins/Vector] - 10https://gerrit.wikimedia.org/r/609895 (https://phabricator.wikimedia.org/T256092) [21:29:37] (03CR) 10Jdlrobson: [C: 03+2] "thanks for the clarifications!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/609895 (https://phabricator.wikimedia.org/T256092) (owner: 10VolkerE) [21:30:05] (03CR) 10VolkerE: [C: 03+2] Logo shouldn't import layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/610154 (owner: 10Jdlrobson) [21:45:32] (03CR) 10Aron Manning: [modern] Move the PersonalMenu into the Header (034 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [21:46:05] (03CR) 10Aron Manning: Implement Page, Workspace, Content, and Article Toolbar Containers (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [21:48:20] (03PS48) 10Aron Manning: [modern] Move the PersonalMenu into the Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) [21:48:24] (03PS3) 10Aron Manning: [modern] PersonalMenu layout cleanup [skins/Vector] - 10https://gerrit.wikimedia.org/r/609881 (https://phabricator.wikimedia.org/T256893) [21:48:28] (03PS3) 10Aron Manning: [modern] Move user page icon to pseudo-element for reliable layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/609882 (https://phabricator.wikimedia.org/T257144) [21:48:32] (03PS27) 10Aron Manning: Split SearchBox layout styles for legacy and modern [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) [21:48:36] (03PS27) 10Aron Manning: [WIP] [modern] Move SearchBox into Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/602848 (https://phabricator.wikimedia.org/T249363) [21:51:07] (03CR) 10VolkerE: [C: 04-1] "> Patch Set 4:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/608161 (https://phabricator.wikimedia.org/T246420) (owner: 10Aron Manning) [21:53:27] (03CR) 10Aron Manning: "> I could be wrong, but my impression from Volker's comment on the ticket is that we want the solid blue focus border (not the dotted outl" [skins/Vector] - 10https://gerrit.wikimedia.org/r/608161 (https://phabricator.wikimedia.org/T246420) (owner: 10Aron Manning) [21:54:19] (03Merged) 10jenkins-bot: [modern] Fix rendering of `main` element in IE10 & 11 (again) [skins/Vector] - 10https://gerrit.wikimedia.org/r/609895 (https://phabricator.wikimedia.org/T256092) (owner: 10VolkerE) [21:54:26] (03CR) 10Aron Manning: "> That is correct. It should follow the button default in all browsers." [skins/Vector] - 10https://gerrit.wikimedia.org/r/608161 (https://phabricator.wikimedia.org/T246420) (owner: 10Aron Manning) [22:10:40] (03CR) 10VolkerE: [modern] Move the PersonalMenu into the Header (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [22:12:18] (03CR) 10VolkerE: [C: 04-1] "> Patch Set 4:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/608161 (https://phabricator.wikimedia.org/T246420) (owner: 10Aron Manning) [22:14:06] (03CR) 10jerkins-bot: [V: 04-1] Split SearchBox layout styles for legacy and modern [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [22:14:49] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [modern] Move SearchBox into Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/602848 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [22:18:44] (03CR) 10Jdlrobson: Implement Page, Workspace, Content, and Article Toolbar Containers (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [22:18:57] (03CR) 10Aron Manning: "> It should follow the button default in all browsers." [skins/Vector] - 10https://gerrit.wikimedia.org/r/608161 (https://phabricator.wikimedia.org/T246420) (owner: 10Aron Manning) [22:22:27] (03PS3) 10Jdlrobson: Logo shouldn't import layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/610154 [22:22:31] (03CR) 10Jdlrobson: [C: 03+2] Logo shouldn't import layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/610154 (owner: 10Jdlrobson) [22:29:41] (03PS4) 10Aron Manning: [less] Add mediawiki.mixins.flex-align.less [skins/Vector] - 10https://gerrit.wikimedia.org/r/609801 (https://phabricator.wikimedia.org/T256893) [22:29:45] (03PS49) 10Aron Manning: [modern] Move the PersonalMenu into the Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) [22:29:49] (03PS4) 10Aron Manning: [modern] PersonalMenu layout cleanup [skins/Vector] - 10https://gerrit.wikimedia.org/r/609881 (https://phabricator.wikimedia.org/T256893) [22:30:07] (03PS26) 10Aron Manning: [cleanup] Distinguish `.vector-menu` and `.vector-menu-personal` [skins/Vector] - 10https://gerrit.wikimedia.org/r/602847 (https://phabricator.wikimedia.org/T256897) [22:35:54] (03PS3) 10Jdlrobson: [Refactor] Move Searchbox layout rules to layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/610143 [22:37:18] (03CR) 10Aron Manning: [modern] Move the PersonalMenu into the Header (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [22:46:30] (03Merged) 10jenkins-bot: Logo shouldn't import layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/610154 (owner: 10Jdlrobson) [22:54:47] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Distinguish `.vector-menu` and `.vector-menu-personal` [skins/Vector] - 10https://gerrit.wikimedia.org/r/602847 (https://phabricator.wikimedia.org/T256897) (owner: 10Aron Manning) [22:55:30] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [modern] Move SearchBox into Header [skins/Vector] - 10https://gerrit.wikimedia.org/r/602848 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [22:55:34] (03CR) 10jerkins-bot: [V: 04-1] Add unique '.menu-*' and '.sidebar-*' classes to all menus and portals [skins/Vector] - 10https://gerrit.wikimedia.org/r/605298 (https://phabricator.wikimedia.org/T256897) (owner: 10Aron Manning) [22:56:24] (03CR) 10jerkins-bot: [V: 04-1] Split SearchBox layout styles for legacy and modern [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [22:56:59] (03CR) 10Aron Manning: Implement Page, Workspace, Content, and Article Toolbar Containers (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:02:01] (03PS43) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) [23:02:47] (03CR) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:12:00] (03CR) 10VolkerE: [modern] Move the PersonalMenu into the Header (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585629 (https://phabricator.wikimedia.org/T256893) (owner: 10Aron Manning) [23:15:46] (03CR) 10jerkins-bot: [V: 04-1] Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:18:41] (03CR) 10Aron Manning: Implement Page, Workspace, Content, and Article Toolbar Containers (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:19:39] (03CR) 10Zhuyifei1999: "A lot of code has to execute correctly before pwb imports setup. I think we are assuming users won't run pwb.py with Py 2 right?" (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/610062 (https://phabricator.wikimedia.org/T239542) (owner: 10Xqt) [23:20:00] (03CR) 10VolkerE: [C: 04-1] "Previous comment remains" [skins/Vector] - 10https://gerrit.wikimedia.org/r/608160 (https://phabricator.wikimedia.org/T245887) (owner: 10Aron Manning) [23:24:11] (03PS4) 10Jdlrobson: [Refactor] Move Searchbox layout rules to layout [skins/Vector] - 10https://gerrit.wikimedia.org/r/610143 [23:24:15] (03PS1) 10Jdlrobson: Move personal tools and search into header [skins/Vector] - 10https://gerrit.wikimedia.org/r/610186 [23:24:19] (03PS1) 10Jdlrobson: Move the personal tools and search into header [skins/Vector] - 10https://gerrit.wikimedia.org/r/610187 (https://phabricator.wikimedia.org/T256893) [23:25:17] (03PS2) 10Jdlrobson: Move the personal tools and search into header [skins/Vector] - 10https://gerrit.wikimedia.org/r/610187 (https://phabricator.wikimedia.org/T256893) [23:25:58] (03PS3) 10Jdlrobson: Move the personal tools and search into header [skins/Vector] - 10https://gerrit.wikimedia.org/r/610187 (https://phabricator.wikimedia.org/T256893) [23:26:11] (03Abandoned) 10Jdlrobson: Move personal tools and search into header [skins/Vector] - 10https://gerrit.wikimedia.org/r/610186 (owner: 10Jdlrobson) [23:30:31] (03CR) 10Jdlrobson: [C: 04-1] "Honestly I think we can achieve this with zero changes to the search widget." [skins/Vector] - 10https://gerrit.wikimedia.org/r/605304 (https://phabricator.wikimedia.org/T249363) (owner: 10Aron Manning) [23:32:24] (03CR) 10jerkins-bot: [V: 04-1] Move the personal tools and search into header [skins/Vector] - 10https://gerrit.wikimedia.org/r/610187 (https://phabricator.wikimedia.org/T256893) (owner: 10Jdlrobson) [23:38:23] (03PS44) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) [23:40:08] (03CR) 10Nray: Implement Page, Workspace, Content, and Article Toolbar Containers (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:43:37] (03CR) 10Aron Manning: Implement Page, Workspace, Content, and Article Toolbar Containers (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray) [23:52:14] (03CR) 10jerkins-bot: [V: 04-1] Implement Page, Workspace, Content, and Article Toolbar Containers [skins/Vector] - 10https://gerrit.wikimedia.org/r/603606 (https://phabricator.wikimedia.org/T246420) (owner: 10Nray)