[00:05:57] (03CR) 10Jdlrobson: [C: 04-1] "Needs a rebase. Also want to give the ShoutAds maintainers some time to acknowledge/confirm the patch works for them." [skins/Vector] - 10https://gerrit.wikimedia.org/r/616188 (https://phabricator.wikimedia.org/T255214) (owner: 10Ammarpad) [00:11:28] (03PS5) 10Yaron Koren: Add support for new helper tables to hold Flex Diagrams data [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/616500 [00:16:33] (03CR) 10jerkins-bot: [V: 04-1] Add support for new helper tables to hold Flex Diagrams data [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/616500 (owner: 10Yaron Koren) [00:29:17] (03PS6) 10Yaron Koren: Add support for new helper tables to hold Flex Diagrams data [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/616500 [00:35:12] (03CR) 10Yaron Koren: [C: 03+2] Add support for new helper tables to hold Flex Diagrams data [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/616500 (owner: 10Yaron Koren) [00:42:24] (03Merged) 10jenkins-bot: Add support for new helper tables to hold Flex Diagrams data [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/616500 (owner: 10Yaron Koren) [00:54:18] (03PS12) 10Jdlrobson: WIP: Replace searchModule to be used for search [skins/Vector] - 10https://gerrit.wikimedia.org/r/612570 (https://phabricator.wikimedia.org/T250851) (owner: 10Peter.ovchyn) [00:57:06] (03PS13) 10Jdlrobson: WIP: Replace searchModule to be used for search [skins/Vector] - 10https://gerrit.wikimedia.org/r/612570 (https://phabricator.wikimedia.org/T250851) (owner: 10Peter.ovchyn) [00:57:49] (03CR) 10Jdlrobson: "So 2 proposed methods here" [skins/Vector] - 10https://gerrit.wikimedia.org/r/612570 (https://phabricator.wikimedia.org/T250851) (owner: 10Peter.ovchyn) [01:15:36] (03PS63) 10Jdlrobson: Merge SkinVector and VectorTemplate (step 1/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) [01:15:48] (03CR) 10jerkins-bot: [V: 04-1] Merge SkinVector and VectorTemplate (step 1/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [01:15:58] (03PS8) 10Jdlrobson: Merge SkinVector and VectorTemplate (step 2/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/610869 (https://phabricator.wikimedia.org/T251212) [01:16:14] (03CR) 10jerkins-bot: [V: 04-1] Merge SkinVector and VectorTemplate (step 2/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/610869 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [01:16:32] (03PS64) 10Jdlrobson: Begin merge of SkinVector and VectorTemplate (1/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) [01:16:36] (03PS9) 10Jdlrobson: Merge SkinVector and VectorTemplate (step 2/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/610869 (https://phabricator.wikimedia.org/T251212) [01:16:46] (03CR) 10Jdlrobson: "PS64 is a rebase." [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [01:17:10] (03CR) 10jerkins-bot: [V: 04-1] WIP: Replace searchModule to be used for search [skins/Vector] - 10https://gerrit.wikimedia.org/r/612570 (https://phabricator.wikimedia.org/T250851) (owner: 10Peter.ovchyn) [01:48:09] (03CR) 10VolkerE: [modern] Fix rendering of `main` element in IE10 & 11 (again) (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/609895 (https://phabricator.wikimedia.org/T256092) (owner: 10VolkerE) [02:55:58] (03CR) 10Krinkle: [C: 04-1] WIP: Replace searchModule to be used for search (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/612570 (https://phabricator.wikimedia.org/T250851) (owner: 10Peter.ovchyn) [04:26:03] (03CR) 10VolkerE: [C: 04-1] "Nitpick: Needs commit message update again." [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [04:30:45] (03CR) 10VolkerE: [C: 04-1] Begin merge of SkinVector and VectorTemplate (1/2) (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [05:05:52] (03PS9) 10Catrope: Implement mediawiki.skin.variables.less for Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/434214 (https://phabricator.wikimedia.org/T112747) (owner: 10Krinkle) [05:06:09] (03CR) 10jerkins-bot: [V: 04-1] Implement mediawiki.skin.variables.less for Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/434214 (https://phabricator.wikimedia.org/T112747) (owner: 10Krinkle) [05:47:02] (03PS10) 10Catrope: Implement mediawiki.skin.variables.less for Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/434214 (https://phabricator.wikimedia.org/T112747) (owner: 10Krinkle) [05:54:53] (03CR) 10jerkins-bot: [V: 04-1] Implement mediawiki.skin.variables.less for Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/434214 (https://phabricator.wikimedia.org/T112747) (owner: 10Krinkle) [06:10:20] (03PS11) 10Catrope: Implement mediawiki.skin.variables.less for Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/434214 (https://phabricator.wikimedia.org/T112747) (owner: 10Krinkle) [06:11:16] 10Pywikibot, 10Pywikibot-tests: test_unicode_method of .djvu_tests.TestDjVuFile fails with AttributeError - https://phabricator.wikimedia.org/T258998 (10Xqt) [06:11:30] 10Pywikibot, 10Pywikibot-tests: test_unicode_method of .djvu_tests.TestDjVuFile fails with AttributeError - https://phabricator.wikimedia.org/T258998 (10Xqt) p:05Triage→03High [06:28:42] (03PS1) 10Xqt: [bugfix] After UnicodeMixin has been dropped, remove the related test [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616698 (https://phabricator.wikimedia.org/T258998) [06:29:38] (03CR) 10jerkins-bot: [V: 04-1] Implement mediawiki.skin.variables.less for Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/434214 (https://phabricator.wikimedia.org/T112747) (owner: 10Krinkle) [06:30:11] (03PS1) 10Xqt: [4.0] Remove Python 2 code parts in logging.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616699 [07:29:04] (03PS2) 10Matěj Suchánek: [bugfix] Fix ShouldArchive type [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616546 [08:23:34] (03CR) 10Xqt: [C: 03+2] [bugfix] Fix ShouldArchive type [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616546 (owner: 10Matěj Suchánek) [08:25:39] (03Merged) 10jenkins-bot: [bugfix] Fix ShouldArchive type [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616546 (owner: 10Matěj Suchánek) [10:06:57] (03PS1) 10Matěj Suchánek: [IMPR] Reset counter when "era" changes [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616719 (https://phabricator.wikimedia.org/T215247) [10:08:53] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Reset counter when "era" changes [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616719 (https://phabricator.wikimedia.org/T215247) (owner: 10Matěj Suchánek) [10:08:55] 10Pywikibot, 10Pywikibot-archivebot.py, 10Regression: archivebot resets the numbering to 1 even for non-year archives - https://phabricator.wikimedia.org/T217107 (10matej_suchanek) 05Open→03Resolved Let's concentrate on the parent task. [10:08:57] 10Pywikibot, 10Pywikibot-archivebot.py, 10Patch-For-Review: archivebot should reset counter when changing a year - https://phabricator.wikimedia.org/T215247 (10matej_suchanek) [10:11:30] (03PS2) 10Matěj Suchánek: [IMPR] Reset counter when "era" changes [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616719 (https://phabricator.wikimedia.org/T215247) [10:13:11] 10Pywikibot, 10Pywikibot-archivebot.py, 10Patch-For-Review, 10User-notice: archivebot should reset counter when changing a year - https://phabricator.wikimedia.org/T215247 (10matej_suchanek) a:03matej_suchanek Whole Wikimedia depends on this functionality, needs careful review and maybe some testing. [10:21:33] (03CR) 10Matěj Suchánek: [C: 03+2] [bugfix] After UnicodeMixin has been dropped, remove the related test [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616698 (https://phabricator.wikimedia.org/T258998) (owner: 10Xqt) [10:23:39] (03Merged) 10jenkins-bot: [bugfix] After UnicodeMixin has been dropped, remove the related test [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616698 (https://phabricator.wikimedia.org/T258998) (owner: 10Xqt) [10:56:38] (03CR) 10Matěj Suchánek: [C: 03+2] [4.0] Remove Python 2 code parts in logging.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616699 (owner: 10Xqt) [10:58:38] (03Merged) 10jenkins-bot: [4.0] Remove Python 2 code parts in logging.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616699 (owner: 10Xqt) [14:43:55] 10Pywikibot, 10Pywikibot-tests: test_unicode_method of .djvu_tests.TestDjVuFile fails with AttributeError - https://phabricator.wikimedia.org/T258998 (10Xqt) 05Open→03Resolved [15:36:10] (03CR) 10Matěj Suchánek: [C: 03+2] [IMPR] Simplify Revision.sha1 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616342 (owner: 10Xqt) [15:38:09] (03Merged) 10jenkins-bot: [IMPR] Simplify Revision.sha1 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616342 (owner: 10Xqt) [16:08:22] (03PS1) 10Xqt: enable annotation check [pywikibot/bots/xqbot] - 10https://gerrit.wikimedia.org/r/616863 [16:14:35] (03CR) 10Xqt: [C: 03+2] enable annotation check [pywikibot/bots/xqbot] - 10https://gerrit.wikimedia.org/r/616863 (owner: 10Xqt) [16:52:31] (03CR) 10VolkerE: "ping" [skins/Vector] - 10https://gerrit.wikimedia.org/r/608976 (https://phabricator.wikimedia.org/T254195) (owner: 10VolkerE) [17:39:22] (03PS65) 10Jdlrobson: Merge SkinVector and VectorTemplate (step 1/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) [17:39:26] (03PS10) 10Jdlrobson: Merge SkinVector and VectorTemplate (step 2/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/610869 (https://phabricator.wikimedia.org/T251212) [17:40:22] (03PS66) 10Jdlrobson: Merge SkinVector and VectorTemplate (step 1/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) [17:40:26] (03PS11) 10Jdlrobson: Merge SkinVector and VectorTemplate (step 2/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/610869 (https://phabricator.wikimedia.org/T251212) [17:40:39] (03CR) 10Jdlrobson: Merge SkinVector and VectorTemplate (step 1/2) (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [17:42:09] (03CR) 10Jdlrobson: [C: 04-1] "> Patch Set 2:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/608976 (https://phabricator.wikimedia.org/T254195) (owner: 10VolkerE) [17:52:48] (03CR) 10VolkerE: [C: 03+2] Restrict image border to images in border [skins/Vector] - 10https://gerrit.wikimedia.org/r/615808 (https://phabricator.wikimedia.org/T253842) (owner: 10Jdlrobson) [18:01:30] (03PS5) 10Jdlrobson: Refactor: Replace PHP complexity with JS simplicity [skins/Vector] - 10https://gerrit.wikimedia.org/r/615316 [18:30:04] (03Merged) 10jenkins-bot: Restrict image border to images in border [skins/Vector] - 10https://gerrit.wikimedia.org/r/615808 (https://phabricator.wikimedia.org/T253842) (owner: 10Jdlrobson) [18:41:25] (03CR) 10Xqt: [C: 03+1] [IMPR] Reset counter when "era" changes [pywikibot/core] - 10https://gerrit.wikimedia.org/r/616719 (https://phabricator.wikimedia.org/T215247) (owner: 10Matěj Suchánek) [18:59:40] (03CR) 10VolkerE: [C: 03+1] Merge SkinVector and VectorTemplate (step 1/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [20:11:01] (03CR) 10Krinkle: Merge SkinVector and VectorTemplate (step 1/2) (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [20:12:19] (03CR) 10Krinkle: Merge SkinVector and VectorTemplate (step 1/2) (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [20:18:30] (03PS14) 10Jdlrobson: Vector manages search functionality and provides config flag [skins/Vector] - 10https://gerrit.wikimedia.org/r/612570 (https://phabricator.wikimedia.org/T257706) (owner: 10Peter.ovchyn) [20:18:34] (03CR) 10Krinkle: "See HTML diff at https://phabricator.wikimedia.org/P12098" [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [20:19:02] (03CR) 10jerkins-bot: [V: 04-1] Vector manages search functionality and provides config flag [skins/Vector] - 10https://gerrit.wikimedia.org/r/612570 (https://phabricator.wikimedia.org/T257706) (owner: 10Peter.ovchyn) [20:27:00] (03PS67) 10Jdlrobson: Merge SkinVector and VectorTemplate (step 1/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) [20:27:19] (03CR) 10Jdlrobson: "> Patch Set 66:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [20:27:49] (03CR) 10Krinkle: "What is the purpose of mw-html-debug-log on every page. Can we remove that?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [20:27:53] (03PS68) 10Jdlrobson: Merge SkinVector and VectorTemplate (step 1/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) [20:28:07] (03PS69) 10Jdlrobson: Merge SkinVector and VectorTemplate (step 1/2) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) [20:31:46] (03CR) 10Jdlrobson: "> Patch Set 67:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [21:12:25] (03CR) 10Jdlrobson: Fix print styles on Ctrl+p and ElectronPdf (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/610155 (https://phabricator.wikimedia.org/T253842) (owner: 10Jdlrobson) [22:26:27] (03CR) 10Jdlrobson: "Just wanted to note that how this works is a little intuitive to me to how I expected it to work. I thought theme variables and their over" (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/434214 (https://phabricator.wikimedia.org/T112747) (owner: 10Krinkle) [22:40:27] (03PS4) 10Jdlrobson: Remove VectorBeforeFooter hook [skins/Vector] - 10https://gerrit.wikimedia.org/r/616188 (https://phabricator.wikimedia.org/T255214) (owner: 10Ammarpad) [22:40:34] (03CR) 10Jdlrobson: [C: 03+1] Remove VectorBeforeFooter hook [skins/Vector] - 10https://gerrit.wikimedia.org/r/616188 (https://phabricator.wikimedia.org/T255214) (owner: 10Ammarpad) [22:41:01] (03PS15) 10Jdlrobson: Vector manages search functionality and provides config flag [skins/Vector] - 10https://gerrit.wikimedia.org/r/612570 (https://phabricator.wikimedia.org/T257706) (owner: 10Peter.ovchyn) [22:41:23] (03PS11) 10Jdlrobson: Fix print styles on Ctrl+p and ElectronPdf [skins/Vector] - 10https://gerrit.wikimedia.org/r/610155 (https://phabricator.wikimedia.org/T253842) [22:41:36] (03PS14) 10Jdlrobson: Move the personal tools and search into header [skins/Vector] - 10https://gerrit.wikimedia.org/r/610187 (https://phabricator.wikimedia.org/T249363) [22:44:05] (03CR) 10Krinkle: Implement mediawiki.skin.variables.less for Vector (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/434214 (https://phabricator.wikimedia.org/T112747) (owner: 10Krinkle) [22:50:08] (03PS15) 10Jdlrobson: Move the personal tools and search into header [skins/Vector] - 10https://gerrit.wikimedia.org/r/610187 (https://phabricator.wikimedia.org/T249363) [22:55:55] (03CR) 10jerkins-bot: [V: 04-1] Vector manages search functionality and provides config flag [skins/Vector] - 10https://gerrit.wikimedia.org/r/612570 (https://phabricator.wikimedia.org/T257706) (owner: 10Peter.ovchyn) [23:00:36] (03PS16) 10Jdlrobson: Move the personal tools and search into header [skins/Vector] - 10https://gerrit.wikimedia.org/r/610187 (https://phabricator.wikimedia.org/T249363) [23:14:49] (03CR) 10jerkins-bot: [V: 04-1] Move the personal tools and search into header [skins/Vector] - 10https://gerrit.wikimedia.org/r/610187 (https://phabricator.wikimedia.org/T249363) (owner: 10Jdlrobson) [23:44:55] (03CR) 10Jdlrobson: Implement mediawiki.skin.variables.less for Vector (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/434214 (https://phabricator.wikimedia.org/T112747) (owner: 10Krinkle)