[01:56:31] (03CR) 10Nray: [C: 03+1] "LGTM after merge conflicts are resolved" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/656966 (https://phabricator.wikimedia.org/T261647) (owner: 10Phuedx) [02:33:28] (03CR) 10Jdlrobson: [C: 03+2] Create .mw-body-header element for body content [skins/Vector] - 10https://gerrit.wikimedia.org/r/657891 (https://phabricator.wikimedia.org/T248761) (owner: 10Jdrewniak) [02:35:52] (03Abandoned) 10Jdlrobson: [less] Add clearfix mixin to modern `.mw-body-content` as well [skins/Vector] - 10https://gerrit.wikimedia.org/r/608976 (https://phabricator.wikimedia.org/T254195) (owner: 10VolkerE) [02:56:20] (03Merged) 10jenkins-bot: Create .mw-body-header element for body content [skins/Vector] - 10https://gerrit.wikimedia.org/r/657891 (https://phabricator.wikimedia.org/T248761) (owner: 10Jdrewniak) [05:29:34] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658222 (https://phabricator.wikimedia.org/T267801) (owner: 10Homeboy 445) [05:32:33] (03CR) 10jerkins-bot: [V: 04-1] Adopted use of Context Manager call for assertRaises/assertRaisesRegex [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658222 (https://phabricator.wikimedia.org/T267801) (owner: 10Homeboy 445) [05:38:42] 10Pywikibot: Pywikibot takes too long to give up on contacting the target of an interwikilink - https://phabricator.wikimedia.org/T272911 (10Xqt) [05:38:45] 10Pywikibot, 10Patch-For-Review: Deprecate comms.threadedhttp.HttpRequest in favour of direct requests response - https://phabricator.wikimedia.org/T265206 (10Xqt) [05:44:00] 10Pywikibot: Pywikibot takes too long to give up on contacting the target of an interwikilink - https://phabricator.wikimedia.org/T272911 (10Xqt) p:05Triage→03Medium The loop is made in api.Request._json_loads(). Let’s give up returning plain text with comms.request() first to have full access to requests.Re... [05:50:43] 10Pywikibot, 10Upstream: Pywikibot takes too long to give up on contacting the target of an interwikilink - https://phabricator.wikimedia.org/T272911 (10JJMC89) Some of my bot tasks cannot function correctly with this occurring, so I've cloned version 5.5 instead of using the shared stable on Toolforge. [05:50:47] 10Pywikibot, 10Upstream: Pywikibot takes too long to give up on contacting the target of an interwikilink - https://phabricator.wikimedia.org/T272911 (10Xqt) [07:02:05] (03PS1) 10Ladsgroup: Remove lrc from wikipedia wikis [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658499 [07:05:07] (03CR) 10jerkins-bot: [V: 04-1] Remove lrc from wikipedia wikis [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658499 (owner: 10Ladsgroup) [07:11:30] (03PS2) 10Ladsgroup: Remove lrc from wikipedia wikis [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658499 [07:21:53] (03CR) 10Homeboy 445: "How should I alter the string size so as to pass the tests in for example deprecation_tests.py ,line 616 ?" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658222 (https://phabricator.wikimedia.org/T267801) (owner: 10Homeboy 445) [08:12:50] (03CR) 10Xqt: [C: 03+2] Remove lrc from wikipedia wikis [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658499 (owner: 10Ladsgroup) [08:15:36] (03Merged) 10jenkins-bot: Remove lrc from wikipedia wikis [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658499 (owner: 10Ladsgroup) [08:20:39] (03CR) 10Xqt: Adopted use of Context Manager call for assertRaises/assertRaisesRegex (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658222 (https://phabricator.wikimedia.org/T267801) (owner: 10Homeboy 445) [08:25:31] 10Pywikibot, 10Patch-For-Review: Deprecate comms.threadedhttp.HttpRequest in favour of direct requests response - https://phabricator.wikimedia.org/T265206 (10Xqt) [08:46:55] (03PS5) 10Homeboy 445: Adopted use of Context Manager call for assertRaises/assertRaisesRegex [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658222 (https://phabricator.wikimedia.org/T267801) [08:47:50] 10Pywikibot, 10Upstream: Pywikibot takes too long to give up on contacting the target of an interwikilink - https://phabricator.wikimedia.org/T272911 (10Xqt) Seem that interwikiap does not always contains foreign MediaWiki sites but also other content like for phabricator/bugzilla or iarchive in this case. In... [08:48:16] (03CR) 10JJMC89: [C: 03+2] [IMPR] return requests.Response with http.request (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658058 (https://phabricator.wikimedia.org/T265206) (owner: 10Xqt) [08:50:05] (03CR) 10JJMC89: [C: 03+2] [cleanup] Remove unused threadedhttp.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658044 (https://phabricator.wikimedia.org/T265206) (owner: 10Xqt) [08:50:23] (03CR) 10JJMC89: [C: 03+2] [IMPR] Add requests.Response.headers to log when an API error occurs [pywikibot/core] - 10https://gerrit.wikimedia.org/r/657042 (https://phabricator.wikimedia.org/T272325) (owner: 10Xqt) [08:51:48] 10Pywikibot, 10Upstream: Pywikibot takes too long to give up on contacting the target of an interwikilink - https://phabricator.wikimedia.org/T272911 (10Xqt) p:05Medium→03High [08:53:22] (03Merged) 10jenkins-bot: [cleanup] Remove unused threadedhttp.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658044 (https://phabricator.wikimedia.org/T265206) (owner: 10Xqt) [08:53:25] (03Merged) 10jenkins-bot: [IMPR] return requests.Response with http.request [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658058 (https://phabricator.wikimedia.org/T265206) (owner: 10Xqt) [08:53:31] (03Merged) 10jenkins-bot: [IMPR] Add requests.Response.headers to log when an API error occurs [pywikibot/core] - 10https://gerrit.wikimedia.org/r/657042 (https://phabricator.wikimedia.org/T272325) (owner: 10Xqt) [09:02:39] (03CR) 10Xqt: [C: 03+2] [maintenance] Add a preload_sites.py script to preload site informations [pywikibot/core] - 10https://gerrit.wikimedia.org/r/656997 (https://phabricator.wikimedia.org/T226157) (owner: 10Xqt) [09:05:17] (03CR) 10Xqt: [IMPR] return requests.Response with http.request (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658058 (https://phabricator.wikimedia.org/T265206) (owner: 10Xqt) [09:05:29] (03Merged) 10jenkins-bot: [maintenance] Add a preload_sites.py script to preload site informations [pywikibot/core] - 10https://gerrit.wikimedia.org/r/656997 (https://phabricator.wikimedia.org/T226157) (owner: 10Xqt) [09:07:07] 10Pywikibot, 10Patch-For-Review: Deprecate comms.threadedhttp.HttpRequest in favour of direct requests response - https://phabricator.wikimedia.org/T265206 (10Xqt) [09:07:21] 10Pywikibot, 10Upstream: Pywikibot takes too long to give up on contacting the target of an interwikilink - https://phabricator.wikimedia.org/T272911 (10Xqt) [09:07:24] 10Pywikibot: Unify Http Exceptions across pywikibot? - https://phabricator.wikimedia.org/T270051 (10Xqt) [09:07:26] 10Pywikibot, 10Patch-For-Review: Deprecate comms.threadedhttp.HttpRequest in favour of direct requests response - https://phabricator.wikimedia.org/T265206 (10Xqt) 05Open→03Resolved a:03Xqt [09:08:28] 10Pywikibot, 10Patch-For-Review: Log response headers from MediaWiki API errors - https://phabricator.wikimedia.org/T272325 (10Xqt) 05Open→03Resolved [09:08:29] 10Pywikibot, 10Release: Pywikibot release 6.0 dependencies - https://phabricator.wikimedia.org/T269066 (10Xqt) [09:10:15] 10Pywikibot, 10Upstream: Pywikibot takes too long to give up on contacting the target of an interwikilink - https://phabricator.wikimedia.org/T272911 (10JJMC89) >>! In T272911#6776440, @Xqt wrote: > Seem that interwikiap does not always contains foreign MediaWiki sites but also other content like for phabricat... [09:18:04] 10Pywikibot, 10Pywikibot-Scripts, 10Pywikibot-RfCs: Create archive procedure for scripts - https://phabricator.wikimedia.org/T223826 (10JJMC89) I propose archiving all unmarked scripts and removing all already archived scripts for 6.0 ({T269066}). [09:21:27] (03PS1) 10Xqt: [bugfix] BaseSite does not have an _interwikimap attribute [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658559 [09:29:44] (03CR) 10Xqt: [C: 03+2] "code arrangement" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658559 (owner: 10Xqt) [09:32:49] (03Merged) 10jenkins-bot: [bugfix] BaseSite does not have an _interwikimap attribute [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658559 (owner: 10Xqt) [09:38:07] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658222 (https://phabricator.wikimedia.org/T267801) (owner: 10Homeboy 445) [10:09:19] 10Pywikibot, 10Release: Pywikibot release 6.0 dependencies - https://phabricator.wikimedia.org/T269066 (10Xqt) [10:09:25] 10Pywikibot, 10Pywikibot-Scripts, 10Pywikibot-RfCs: Create archive procedure for scripts - https://phabricator.wikimedia.org/T223826 (10Xqt) [10:17:32] 10Pywikibot, 10Upstream: Pywikibot takes too long to give up on contacting the target of an interwikilink - https://phabricator.wikimedia.org/T272911 (10Xqt) Setting `-max_retries:1` as global option or setting it in `user-config.py` will force giving up faster; but it does not solve the underlying problem. [10:27:17] 10Pywikibot, 10Upstream: Pywikibot takes too long to give up on contacting the target of an interwikilink - https://phabricator.wikimedia.org/T272911 (10Xqt) >>! In T272911#6776696, @Xqt wrote: > Setting `-max_retries:1` as global option or setting it in `user-config.py` will force giving up faster; but it doe... [10:42:18] (03PS1) 10Xqt: [cleanup] remove deprecated Family.known_families dict [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658563 (https://phabricator.wikimedia.org/T89451) [10:45:08] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] remove deprecated Family.known_families dict [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658563 (https://phabricator.wikimedia.org/T89451) (owner: 10Xqt) [10:46:51] (03CR) 10Xqt: [C: 03+2] "Looks good. Let's have a try with CI. Thanks a lot for your greatful work." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658222 (https://phabricator.wikimedia.org/T267801) (owner: 10Homeboy 445) [10:48:58] (03PS2) 10Xqt: [cleanup] remove deprecated Family.known_families dict [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658563 (https://phabricator.wikimedia.org/T89451) [10:50:01] (03Merged) 10jenkins-bot: Adopted use of Context Manager call for assertRaises/assertRaisesRegex [pywikibot/core] - 10https://gerrit.wikimedia.org/r/658222 (https://phabricator.wikimedia.org/T267801) (owner: 10Homeboy 445) [12:04:38] (03PS6) 10Phuedx: Add search widget treatment A/B test [skins/Vector] - 10https://gerrit.wikimedia.org/r/656966 (https://phabricator.wikimedia.org/T261647) [13:01:37] (03CR) 10Phuedx: "Done. Thanks, Nray!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/656966 (https://phabricator.wikimedia.org/T261647) (owner: 10Phuedx) [14:48:06] (03CR) 10Phuedx: [C: 04-1] "-1 for your attention only. This LGTM functionally but I think there are a couple of opportunities to make more tightly-focussed patches." (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/656504 (https://phabricator.wikimedia.org/T270202) (owner: 10Nray) [17:51:32] (03CR) 10Nray: [C: 04-1] Add search widget treatment A/B test (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/656966 (https://phabricator.wikimedia.org/T261647) (owner: 10Phuedx) [20:50:17] (03CR) 10Nray: [C: 03+2] "On second thought, since the change is small I'll merge now and make a follow up patch" [skins/Vector] - 10https://gerrit.wikimedia.org/r/656966 (https://phabricator.wikimedia.org/T261647) (owner: 10Phuedx) [21:01:18] (03PS1) 10Nray: Correct config comment [skins/Vector] - 10https://gerrit.wikimedia.org/r/658678 [21:11:38] (03CR) 10Jdlrobson: [C: 03+2] Correct config comment [skins/Vector] - 10https://gerrit.wikimedia.org/r/658678 (owner: 10Nray) [21:17:39] (03Merged) 10jenkins-bot: Add search widget treatment A/B test [skins/Vector] - 10https://gerrit.wikimedia.org/r/656966 (https://phabricator.wikimedia.org/T261647) (owner: 10Phuedx) [21:38:35] (03Merged) 10jenkins-bot: Correct config comment [skins/Vector] - 10https://gerrit.wikimedia.org/r/658678 (owner: 10Nray)