[07:44:17] 10Pywikibot, 10Pywikibot-tests, 10Release-Engineering-Team (Unit & Int & System Tooling): Lint test to match function signature and documentation - https://phabricator.wikimedia.org/T277396 (10Xqt) @Huji: I didn’t found a flake8 package for it but deep source can do it for us: https://deepsource.io/gh/ankitd... [07:44:30] 10Pywikibot, 10Pywikibot-tests, 10Release-Engineering-Team (Unit & Int & System Tooling): Lint test to match function signature and documentation - https://phabricator.wikimedia.org/T277396 (10Xqt) p:05Triage→03Medium [10:35:16] (03PS1) 10Xqt: [fix] remove useless super delegation in tools_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673451 [10:39:43] (03PS1) 10Xqt: [fix] use 'is' when comparing types [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673453 [10:48:32] (03PS1) 10Xqt: [fix] Simplify if-statement with bool result [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673456 [10:52:54] (03CR) 10jerkins-bot: [V: 04-1] [fix] Simplify if-statement with bool result [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673456 (owner: 10Xqt) [10:55:48] (03PS1) 10Xqt: [fix] KeyboardInterrupt exception raises immediately [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673458 [11:03:58] (03PS1) 10Xqt: [fix] Use items() to iterate over a dictionary if values are used [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673459 [11:23:28] (03PS1) 10Xqt: [bugfix] pymysql.Connection initializer has keyword only parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673462 [11:27:52] (03PS2) 10Xqt: [fix] Simplify if-statement with bool result [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673456 [11:31:01] (03PS2) 10Xqt: [bugfix] pymysql.Connection initializer has keyword only parameters [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673462 [11:43:26] (03PS1) 10Xqt: [fix] Simplify if-expression [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673466 [12:55:14] (03PS1) 10Xqt: [fix] Don't test Python's behaviour [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673474 [12:57:53] (03PS1) 10Xqt: [bugfix] fix reporting in welcome.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673476 [13:02:35] (03PS3) 10Xqt: [bugfix] Add support for PyMySQL 1.0.0+ [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673462 [14:29:38] (03CR) 10Xqt: "This change is ready for review." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673462 (owner: 10Xqt) [14:40:07] (03CR) 10Matěj Suchánek: [C: 03+2] [fix] Use items() to iterate over a dictionary if values are used [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673459 (owner: 10Xqt) [14:40:12] (03CR) 10Matěj Suchánek: [fix] Simplify if-expression (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673466 (owner: 10Xqt) [14:42:40] (03Merged) 10jenkins-bot: [fix] Use items() to iterate over a dictionary if values are used [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673459 (owner: 10Xqt) [14:43:01] (03CR) 10Matěj Suchánek: [C: 03+2] [fix] use 'is' when comparing types [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673453 (owner: 10Xqt) [14:46:00] (03Merged) 10jenkins-bot: [fix] use 'is' when comparing types [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673453 (owner: 10Xqt) [14:46:13] (03CR) 10Matěj Suchánek: [C: 03+2] [fix] remove useless super delegation in tools_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673451 (owner: 10Xqt) [14:46:30] (03PS2) 10Xqt: [fix] Simplify if-expression [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673466 [14:46:55] (03CR) 10Xqt: [fix] Simplify if-expression (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673466 (owner: 10Xqt) [14:48:55] (03CR) 10Matěj Suchánek: [C: 03+2] [fix] KeyboardInterrupt exception raises immediately [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673458 (owner: 10Xqt) [14:49:26] (03CR) 10Matěj Suchánek: [C: 03+2] [fix] Simplify if-statement with bool result [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673456 (owner: 10Xqt) [14:49:46] (03Merged) 10jenkins-bot: [fix] remove useless super delegation in tools_tests.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673451 (owner: 10Xqt) [14:50:58] (03CR) 10Matěj Suchánek: [C: 03+2] [fix] Simplify if-expression [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673466 (owner: 10Xqt) [14:51:27] (03Merged) 10jenkins-bot: [fix] KeyboardInterrupt exception raises immediately [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673458 (owner: 10Xqt) [14:52:53] (03Merged) 10jenkins-bot: [fix] Simplify if-statement with bool result [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673456 (owner: 10Xqt) [14:54:02] (03Merged) 10jenkins-bot: [fix] Simplify if-expression [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673466 (owner: 10Xqt) [14:59:30] (03PS1) 10Xqt: [code] Fix code quality issues [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673510 [15:02:21] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673510 (owner: 10Xqt) [15:04:03] (03PS2) 10Xqt: [code] Fix code quality issues [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673510 [15:04:49] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673510 (owner: 10Xqt) [15:07:21] (03CR) 10jerkins-bot: [V: 04-1] [code] Fix code quality issues [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673510 (owner: 10Xqt) [15:10:28] (03PS3) 10Xqt: [code] Fix code quality issues [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673510 [15:11:16] (03CR) 10Xqt: [C: 03+2] [code] Fix code quality issues [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673510 (owner: 10Xqt) [15:14:13] (03Merged) 10jenkins-bot: [code] Fix code quality issues [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673510 (owner: 10Xqt) [15:49:33] 10Pywikibot, 10Pywikibot-tests, 10Release-Engineering-Team (Unit & Int & System Tooling): Lint test to match function signature and documentation - https://phabricator.wikimedia.org/T277396 (10Xqt) Probably https://pypi.org/project/darglint/ would be appropriate for this [15:54:21] (03PS1) 10Xqt: [tests] Add darglint to flake8 tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673520 (https://phabricator.wikimedia.org/T277396) [15:56:57] (03CR) 10jerkins-bot: [V: 04-1] [tests] Add darglint to flake8 tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673520 (https://phabricator.wikimedia.org/T277396) (owner: 10Xqt) [16:00:23] (03PS2) 10Xqt: [tests] Add darglint to flake8 tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673520 (https://phabricator.wikimedia.org/T277396) [16:02:50] (03CR) 10jerkins-bot: [V: 04-1] [tests] Add darglint to flake8 tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673520 (https://phabricator.wikimedia.org/T277396) (owner: 10Xqt) [16:08:40] (03PS3) 10Xqt: [tests] Add darglint to flake8 tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673520 (https://phabricator.wikimedia.org/T277396) [16:12:01] (03CR) 10jerkins-bot: [V: 04-1] [tests] Add darglint to flake8 tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673520 (https://phabricator.wikimedia.org/T277396) (owner: 10Xqt) [16:16:21] (03PS4) 10Xqt: [tests] Add darglint to flake8 tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673520 (https://phabricator.wikimedia.org/T277396) [16:19:10] (03PS3) 10Jdrewniak: Hide languages-in-header button when no additional languages [skins/Vector] - 10https://gerrit.wikimedia.org/r/673249 (https://phabricator.wikimedia.org/T276950) [16:19:23] (03CR) 10jerkins-bot: [V: 04-1] [tests] Add darglint to flake8 tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673520 (https://phabricator.wikimedia.org/T277396) (owner: 10Xqt) [16:20:20] (03CR) 10Jdrewniak: Hide languages-in-header button when no additional languages (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/673249 (https://phabricator.wikimedia.org/T276950) (owner: 10Jdrewniak) [16:38:59] (03PS5) 10Xqt: [tests] Add darglint to flake8 tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673520 (https://phabricator.wikimedia.org/T277396) [16:42:26] (03CR) 10jerkins-bot: [V: 04-1] [tests] Add darglint to flake8 tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673520 (https://phabricator.wikimedia.org/T277396) (owner: 10Xqt) [16:47:20] (03CR) 10Phuedx: [C: 04-1] "-1 for your attention only." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/673151 (owner: 10Jdlrobson) [16:52:20] (03CR) 10jerkins-bot: [V: 04-1] Hide languages-in-header button when no additional languages [skins/Vector] - 10https://gerrit.wikimedia.org/r/673249 (https://phabricator.wikimedia.org/T276950) (owner: 10Jdrewniak) [16:52:36] (03CR) 10Jdlrobson: Inform anonymous A/B test by tracking time from DOM interactive (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/673151 (owner: 10Jdlrobson) [17:18:34] 10Pywikibot, 10good first task: Unnecessary else / elif used after return - https://phabricator.wikimedia.org/T277888 (10Xqt) [17:18:57] 10Pywikibot, 10good first task: Unnecessary else / elif used after return - https://phabricator.wikimedia.org/T277888 (10Xqt) p:05Triage→03Low [17:21:58] 10Pywikibot, 10good first task: Unnecessary else/elif used after raise - https://phabricator.wikimedia.org/T277890 (10Xqt) [17:22:06] 10Pywikibot, 10good first task: Unnecessary else/elif used after raise - https://phabricator.wikimedia.org/T277890 (10Xqt) p:05Triage→03Low [17:25:09] 10Pywikibot, 10User-Zabe, 10good first task: Unnecessary else / elif used after return - https://phabricator.wikimedia.org/T277888 (10Zabe) a:03Zabe [17:26:41] 10Pywikibot, 10good first task: Unnecessary elif / else block after continue or after break - https://phabricator.wikimedia.org/T277891 (10Xqt) [17:26:50] 10Pywikibot, 10good first task: Unnecessary elif / else block after continue or after break - https://phabricator.wikimedia.org/T277891 (10Xqt) p:05Triage→03Low [18:10:37] (03PS1) 10Xqt: [IMPR] use sys.exit() instead of exit() [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673555 [18:25:28] (03PS4) 10Jdrewniak: Hide languages-in-header button when no additional languages [skins/Vector] - 10https://gerrit.wikimedia.org/r/673249 (https://phabricator.wikimedia.org/T276950) [19:06:17] (03CR) 10JJMC89: [C: 03+2] Update example hostname for Wikimedia Cloud [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673559 (owner: 10JJMC89) [19:08:22] (03Merged) 10jenkins-bot: Update example hostname for Wikimedia Cloud [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673559 (owner: 10JJMC89) [19:36:16] (03PS1) 10Zabe: Removal of unnecessary else / elif usage after return [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673587 (https://phabricator.wikimedia.org/T277888) [19:38:58] (03PS2) 10Zabe: [cleanup] Removal of unnecessary else / elif usage after return [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673587 (https://phabricator.wikimedia.org/T277888) [19:41:21] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Removal of unnecessary else / elif usage after return [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673587 (https://phabricator.wikimedia.org/T277888) (owner: 10Zabe) [19:43:17] (03PS3) 10Zabe: [cleanup] Removal of unnecessary else / elif usage after return [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673587 (https://phabricator.wikimedia.org/T277888) [19:47:27] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Removal of unnecessary else / elif usage after return [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673587 (https://phabricator.wikimedia.org/T277888) (owner: 10Zabe) [21:04:47] (03PS4) 10Zabe: [cleanup] Removal of unnecessary else / elif usage after return [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673587 (https://phabricator.wikimedia.org/T277888) [21:08:12] (03CR) 10jerkins-bot: [V: 04-1] [cleanup] Removal of unnecessary else / elif usage after return [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673587 (https://phabricator.wikimedia.org/T277888) (owner: 10Zabe) [21:08:16] (03PS5) 10Zabe: [cleanup] Removal of unnecessary else / elif usage after return [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673587 (https://phabricator.wikimedia.org/T277888) [21:45:25] (03CR) 10Xqt: "check experimental" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673587 (https://phabricator.wikimedia.org/T277888) (owner: 10Zabe) [22:00:57] (03CR) 10Xqt: [C: 03+2] "Great. Thanks a lot." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673587 (https://phabricator.wikimedia.org/T277888) (owner: 10Zabe) [22:02:31] 10Pywikibot, 10Patch-For-Review, 10User-Zabe, 10good first task: Unnecessary else / elif used after return - https://phabricator.wikimedia.org/T277888 (10Xqt) 05Open→03Resolved [22:03:51] (03Merged) 10jenkins-bot: [cleanup] Removal of unnecessary else / elif usage after return [pywikibot/core] - 10https://gerrit.wikimedia.org/r/673587 (https://phabricator.wikimedia.org/T277888) (owner: 10Zabe)