[01:23:49] (03PS1) 10Krinkle: Revert "Use content-parser-output RL SkinModule feature" [skins/Vector] - 10https://gerrit.wikimedia.org/r/676954 (https://phabricator.wikimedia.org/T279008) [01:51:50] (03Abandoned) 10Krinkle: Revert "Use content-parser-output RL SkinModule feature" [skins/Vector] - 10https://gerrit.wikimedia.org/r/676954 (https://phabricator.wikimedia.org/T279008) (owner: 10Krinkle) [01:58:24] (03CR) 10Krinkle: [C: 03+2] [legacy] Restore old floating style inside Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/677038 (https://phabricator.wikimedia.org/T279008) (owner: 10Jdlrobson) [01:58:46] (03PS1) 10Krinkle: [legacy] Restore old floating style inside Vector [skins/Vector] (wmf/1.36.0-wmf.37) - 10https://gerrit.wikimedia.org/r/676955 [02:20:32] (03Merged) 10jenkins-bot: [legacy] Restore old floating style inside Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/677038 (https://phabricator.wikimedia.org/T279008) (owner: 10Jdlrobson) [04:12:09] (03CR) 10Xqt: [C: 04-1] "Submodule should never become part of a change. It should always be hidden. Using tortoisegit i18n submodule was never presented the last " [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677044 (owner: 10Damian) [04:20:28] (03CR) 10Xqt: "Good. Some remarks." (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677042 (owner: 10Damian) [04:23:27] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/676852 (https://phabricator.wikimedia.org/T279286) (owner: 10Damian) [04:25:43] (03CR) 10jerkins-bot: [V: 04-1] [tests] Skip when watchlist rights are unavailable [pywikibot/core] - 10https://gerrit.wikimedia.org/r/676852 (https://phabricator.wikimedia.org/T279286) (owner: 10Damian) [04:27:44] (03CR) 10Damian: "> Patch Set 1: Code-Review-1" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677044 (owner: 10Damian) [04:32:50] (03PS5) 10Damian: [tests] Skip when watchlist rights are unavailable [pywikibot/core] - 10https://gerrit.wikimedia.org/r/676852 (https://phabricator.wikimedia.org/T279286) [04:36:23] (03PS6) 10Damian: [tests] Skip when watchlist rights are unavailable [pywikibot/core] - 10https://gerrit.wikimedia.org/r/676852 (https://phabricator.wikimedia.org/T279286) [04:37:06] (03CR) 10Xqt: [C: 04-1] "> Patch Set 1:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677044 (owner: 10Damian) [04:49:37] (03PS3) 10Damian: [IMPR] Deprecate textlib.unescape [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677042 [04:57:50] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677042 (owner: 10Damian) [05:00:03] (03CR) 10jerkins-bot: [V: 04-1] [IMPR] Deprecate textlib.unescape [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677042 (owner: 10Damian) [05:07:07] (03CR) 10Xqt: [IMPR] Deprecate textlib.unescape (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677042 (owner: 10Damian) [05:41:04] (03PS4) 10Xqt: [IMPR] Improvements for patrol.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/676969 [05:44:48] (03CR) 10Xqt: [C: 04-1] "> > Hi Xqt. Apologies, but unsure I follow. Commits that change the submodule happen all the time [1]. Are you saying that dropping the ig" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677044 (owner: 10Damian) [05:46:31] (03PS5) 10Xqt: [IMPR] Improvements for patrol.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/676969 [05:49:16] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/676852 (https://phabricator.wikimedia.org/T279286) (owner: 10Damian) [05:52:40] (03CR) 10Xqt: [C: 03+2] "Thank you" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/676852 (https://phabricator.wikimedia.org/T279286) (owner: 10Damian) [05:55:36] (03Merged) 10jenkins-bot: [tests] Skip when watchlist rights are unavailable [pywikibot/core] - 10https://gerrit.wikimedia.org/r/676852 (https://phabricator.wikimedia.org/T279286) (owner: 10Damian) [06:29:57] 10Pywikibot, 10Proposal, 10Pywikibot-RfCs, 10Tracking-Neverending: RFC removing old code / code cleanup - https://phabricator.wikimedia.org/T106121 (10Xqt) [06:30:30] 10Pywikibot, 10Proposal, 10Pywikibot-RfCs, 10Tracking-Neverending: RFC removing old code / code cleanup - https://phabricator.wikimedia.org/T106121 (10Xqt) a:05Xqt→03None [06:41:46] (03PS4) 10Damian: [IMPR] Deprecate textlib.unescape [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677042 [06:43:30] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677042 (owner: 10Damian) [06:47:58] 10Pywikibot, 10Proposal, 10Pywikibot-RfCs, 10Tracking-Neverending: RFC removing old code / code cleanup - https://phabricator.wikimedia.org/T106121 (10Xqt) >>! In T106121#6967520, @Aklapper wrote: > @Xqt: Hi, all related patches in Gerrit have been merged. Can this task be resolved (via {nav name=Add Actio... [06:49:09] (03CR) 10Xqt: [C: 03+2] "Thanks a lot" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677042 (owner: 10Damian) [06:50:02] (03CR) 10Xqt: [C: 03+2] "> Patch Set 4: Code-Review+2" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677042 (owner: 10Damian) [06:51:33] (03Merged) 10jenkins-bot: [IMPR] Deprecate textlib.unescape [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677042 (owner: 10Damian) [07:01:51] (03PS1) 10Damian: Add myself to the credits file [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677095 [07:15:08] (03CR) 10Xqt: [C: 03+2] Add myself to the credits file [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677095 (owner: 10Damian) [07:17:55] (03Merged) 10jenkins-bot: Add myself to the credits file [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677095 (owner: 10Damian) [07:18:05] 10Pywikibot, 10Patch-Needs-Improvement: site.interwiki_prefix() method always fails - https://phabricator.wikimedia.org/T188179 (10Xqt) Now we have another but: ` >>> import pywikibot >>> s = pywikibot.Site() >>> x = s.interwiki_prefix(s) Traceback (most recent call last): File "", line 1, in (03PS1) 10Xqt: [bugfix] key, values pairs of dicts must be unpacked with items() [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677099 (https://phabricator.wikimedia.org/T188179) [07:48:36] (03PS2) 10Xqt: [bugfix] key, values pairs of dicts must be unpacked with items() [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677099 (https://phabricator.wikimedia.org/T188179) [07:50:47] (03CR) 10Xqt: [C: 03+2] [bugfix] key, values pairs of dicts must be unpacked with items() [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677099 (https://phabricator.wikimedia.org/T188179) (owner: 10Xqt) [07:53:22] (03Merged) 10jenkins-bot: [bugfix] key, values pairs of dicts must be unpacked with items() [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677099 (https://phabricator.wikimedia.org/T188179) (owner: 10Xqt) [08:43:06] 10Pywikibot, 10Proposal, 10Pywikibot-RfCs, 10Tracking-Neverending: RFC removing old code / code cleanup - https://phabricator.wikimedia.org/T106121 (10Ladsgroup) I'm not sure having a never ending task is a good idea. You can create a ticket for specific clean ups (python2) or you can use gerrit hashtags i... [11:15:04] 10Pywikibot, 10Proposal, 10Pywikibot-RfCs, 10Tracking-Neverending: RFC removing old code / code cleanup - https://phabricator.wikimedia.org/T106121 (10Xqt) >>! In T106121#6975274, @Ladsgroup wrote: > I'm not sure having a never ending task is a good idea. You can create a ticket for specific clean ups (pyt... [11:28:44] 10Pywikibot, 10Patch-For-Review: site.interwiki_prefix() method always fails - https://phabricator.wikimedia.org/T188179 (10Xqt) 05Open→03Resolved [11:28:47] 10Pywikibot, 10Patch-Needs-Improvement: Mediawiki.org interwiki is mw or mediawikiwiki, not mediawiki - https://phabricator.wikimedia.org/T188157 (10Xqt) [12:55:03] (03PS1) 10Xqt: [tests] add tests for interwikimap [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677241 [12:59:43] (03CR) 10jerkins-bot: [V: 04-1] [tests] add tests for interwikimap [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677241 (owner: 10Xqt) [13:57:20] (03PS2) 10Xqt: [tests] add tests for interwikimap [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677241 [13:59:46] (03CR) 10jerkins-bot: [V: 04-1] [tests] add tests for interwikimap [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677241 (owner: 10Xqt) [14:19:19] (03PS3) 10Xqt: [tests] add tests for interwikimap [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677241 [14:26:10] (03CR) 10Xqt: "check experimental" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677241 (owner: 10Xqt) [14:55:26] (03CR) 10Xqt: [C: 03+2] [tests] add tests for interwikimap [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677241 (owner: 10Xqt) [14:57:44] (03Merged) 10jenkins-bot: [tests] add tests for interwikimap [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677241 (owner: 10Xqt) [15:02:26] (03CR) 10Bernard Wang: [C: 03+2] Remove redundant mw-indicator styles from `layout-default.less` and `layout.less` [skins/Vector] - 10https://gerrit.wikimedia.org/r/676642 (https://phabricator.wikimedia.org/T278362) (owner: 10Bernard Wang) [15:32:16] (03CR) 10Krinkle: [C: 03+2] [legacy] Restore old floating style inside Vector [skins/Vector] (wmf/1.36.0-wmf.37) - 10https://gerrit.wikimedia.org/r/676955 (owner: 10Krinkle) [15:54:38] (03PS1) 10Xqt: [IMPR] Improvements for commonscat.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677295 [16:02:55] 10Pywikibot, 10Pywikibot-tests: SiteWatchlistRevsTestCase.test_watchlist_revs may fail with pywikibot.data.api.APIError: permissiondenied - https://phabricator.wikimedia.org/T279286 (10Xqt) 05Open→03Resolved [16:03:30] (03Merged) 10jenkins-bot: [legacy] Restore old floating style inside Vector [skins/Vector] (wmf/1.36.0-wmf.37) - 10https://gerrit.wikimedia.org/r/676955 (owner: 10Krinkle) [16:41:56] (03PS2) 10Yaron Koren: Set type of "named args" format param to boolean [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/676961 [16:45:56] (03CR) 10Phuedx: [C: 03+1] "This LGTM. Thanks for providing the screenshot!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/676642 (https://phabricator.wikimedia.org/T278362) (owner: 10Bernard Wang) [17:05:16] (03CR) 10Yaron Koren: [C: 03+2] Set type of "named args" format param to boolean [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/676961 (owner: 10Yaron Koren) [17:47:09] (03Merged) 10jenkins-bot: Set type of "named args" format param to boolean [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/676961 (owner: 10Yaron Koren) [19:44:56] (03PS1) 10Damian: Expand tox to include python 3.7 and 3.8 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677352 [19:45:21] (03PS2) 10Damian: [tests] Expand tox to include python 3.7 and 3.8 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/677352 [20:52:55] (03CR) 10Clare Ming: [C: 03+1] "lgtm!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/676642 (https://phabricator.wikimedia.org/T278362) (owner: 10Bernard Wang) [21:00:58] (03CR) 10Jdlrobson: [C: 03+2] "LGTM." [skins/Vector] - 10https://gerrit.wikimedia.org/r/676642 (https://phabricator.wikimedia.org/T278362) (owner: 10Bernard Wang) [21:25:05] (03Merged) 10jenkins-bot: Remove redundant mw-indicator styles from `layout-default.less` and `layout.less` [skins/Vector] - 10https://gerrit.wikimedia.org/r/676642 (https://phabricator.wikimedia.org/T278362) (owner: 10Bernard Wang) [21:33:05] (03CR) 10VolkerE: [C: 04-1] "There's a .legacy/layouts/default.less, but a .styles/layouts/layout.less and a layout-default.less in the same latter folder. That's conf" [skins/Vector] - 10https://gerrit.wikimedia.org/r/661116 (https://phabricator.wikimedia.org/T264309) (owner: 10Jdrewniak) [22:23:45] (03PS9) 10VolkerE: Reorganizing Less files to match resourceLoader conventions [skins/Vector] - 10https://gerrit.wikimedia.org/r/661116 (https://phabricator.wikimedia.org/T264309) (owner: 10Jdrewniak) [22:24:16] (03CR) 10VolkerE: Reorganizing Less files to match resourceLoader conventions (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/661116 (https://phabricator.wikimedia.org/T264309) (owner: 10Jdrewniak) [22:29:58] (03CR) 10VolkerE: "So the footer issue is due to weird overwriting within the skin itself going on. I think we should clarify (by help of Alex) which footer " [skins/Vector] - 10https://gerrit.wikimedia.org/r/661116 (https://phabricator.wikimedia.org/T264309) (owner: 10Jdrewniak) [22:43:45] (03CR) 10VolkerE: [C: 04-1] "Oh yes, and 'skins.vector.styles/legacy/MenuDropdown.less' still exists!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/661116 (https://phabricator.wikimedia.org/T264309) (owner: 10Jdrewniak) [22:46:51] (03CR) 10jerkins-bot: [V: 04-1] Reorganizing Less files to match resourceLoader conventions [skins/Vector] - 10https://gerrit.wikimedia.org/r/661116 (https://phabricator.wikimedia.org/T264309) (owner: 10Jdrewniak) [23:19:33] (03PS10) 10VolkerE: Reorganizing Less files to match ResourceLoader conventions [skins/Vector] - 10https://gerrit.wikimedia.org/r/661116 (https://phabricator.wikimedia.org/T264309) (owner: 10Jdrewniak) [23:24:01] (03PS11) 10VolkerE: Reorganizing Less files to match ResourceLoader conventions [skins/Vector] - 10https://gerrit.wikimedia.org/r/661116 (https://phabricator.wikimedia.org/T264309) (owner: 10Jdrewniak) [23:40:13] (03CR) 10Krinkle: Reorganizing Less files to match ResourceLoader conventions (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/661116 (https://phabricator.wikimedia.org/T264309) (owner: 10Jdrewniak) [23:51:43] (03CR) 10jerkins-bot: [V: 04-1] Reorganizing Less files to match ResourceLoader conventions [skins/Vector] - 10https://gerrit.wikimedia.org/r/661116 (https://phabricator.wikimedia.org/T264309) (owner: 10Jdrewniak)