[00:55:50] (03PS1) 10Nray: Create A/B test harness for Language in header feature [skins/Vector] - 10https://gerrit.wikimedia.org/r/683451 (https://phabricator.wikimedia.org/T280825) [03:22:25] 10Pywikibot, 10Patch-For-Review: Exception names does not follow PEP8 - https://phabricator.wikimedia.org/T280227 (10JJMC89) I still don't see a warning on PS6. I do get one if `NoPage` is imported from `pywikibot.exceptions`. [04:19:54] 10Pywikibot, 10Pywikibot-replace.py: Replace.py: -addcat - https://phabricator.wikimedia.org/T281323 (10Xqt) >>! In T281323#7043974, @Shalomori123 wrote: > The existence in the documentation in line 37. > On line 529: > @deprecated_args(acceptall='always', addedCat='addcat') > There is no warning, and that's... [04:35:27] 10Pywikibot: Page/__init__.py: WikibaseEntity - https://phabricator.wikimedia.org/T281389 (10Xqt) Cannot reproduce it: ` C:\pwb\GIT\core>pwb shell Welcome to the Pywikibot interactive shell! >>> s = pywikibot.Site('wikisource:he') >>> p = pywikibot.Page(s, 'קטגוריה:רבי אבא') >>> i = pywikibot.ItemPage.fromPage... [04:47:17] (03CR) 10Xqt: "> Patch Set 1:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/683102 (https://phabricator.wikimedia.org/T281200) (owner: 10Damian) [05:12:52] (03CR) 10Xqt: [cleanup] Deprecate regex classes (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/681194 (https://phabricator.wikimedia.org/T281200) (owner: 10Damian) [05:17:51] (03CR) 10Damian: "> There are a lot of issues in several parts of the framework but the fewest in those parts you try to remove. Probably they aren't used o" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/683102 (https://phabricator.wikimedia.org/T281200) (owner: 10Damian) [05:20:06] (03CR) 10Damian: [cleanup] Deprecate regex classes (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/681194 (https://phabricator.wikimedia.org/T281200) (owner: 10Damian) [05:23:55] (03PS5) 10Damian: [cleanup] Deprecate regex classes [pywikibot/core] - 10https://gerrit.wikimedia.org/r/681194 (https://phabricator.wikimedia.org/T281200) [05:26:22] (03CR) 10Xqt: [cleanup] Rename config2 (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/682781 (owner: 10Damian) [05:28:00] 10Pywikibot, 10Patch-For-Review: Exception names does not follow PEP8 - https://phabricator.wikimedia.org/T280227 (10atagar) That's odd. I do get it... ` % cat demo.py import pywikibot from pywikibot import NoPage # same behavior if imported from pywikibot.exceptions from pywikibot.exceptions import NoPageE... [05:30:41] (03CR) 10Damian: [cleanup] Rename config2 (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/682781 (owner: 10Damian) [05:39:52] (03CR) 10Xqt: [cleanup] Rename is_IP to is_ip_address (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/679046 (https://phabricator.wikimedia.org/T281200) (owner: 10Damian) [05:50:32] (03CR) 10Xqt: [cleanup] Revise MediaWikiVersion (033 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/681239 (https://phabricator.wikimedia.org/T281200) (owner: 10Damian) [05:54:04] 10Pywikibot, 10Patch-For-Review: Exception names does not follow PEP8 - https://phabricator.wikimedia.org/T280227 (10JJMC89) I get the warning with Python 3.7.3 but not with 3.5.3. [06:04:58] (03CR) 10Xqt: "This reverts f4271464cdb2936ebf101ff6a63317cd800c887b but" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/680772 (https://phabricator.wikimedia.org/T281200) (owner: 10Damian) [06:09:27] (03PS4) 10Damian: [cleanup] Rename config2 [pywikibot/core] - 10https://gerrit.wikimedia.org/r/682781 [06:12:23] 10Pywikibot, 10Patch-For-Review: Exception names does not follow PEP8 - https://phabricator.wikimedia.org/T280227 (10atagar) That's... really odd. I have Python 3.8 and unfortunately installing a deprecated 3.5 interpreter would be a pita. Do you have any idea what's going on or should I try to get one working? [06:24:14] (03CR) 10Damian: "> scripts should be as small as possible and use framework code parts" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/680772 (https://phabricator.wikimedia.org/T281200) (owner: 10Damian) [06:25:46] (03CR) 10Damian: "> makes our codebase messy hand harder for newcomers to understand (... speaking from experience)." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/680772 (https://phabricator.wikimedia.org/T281200) (owner: 10Damian) [06:32:34] (03PS11) 10Damian: [cleanup] Rename is_IP to is_ip_address [pywikibot/core] - 10https://gerrit.wikimedia.org/r/679046 (https://phabricator.wikimedia.org/T281200) [06:38:18] (03CR) 10Damian: [cleanup] Revise MediaWikiVersion (032 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/681239 (https://phabricator.wikimedia.org/T281200) (owner: 10Damian) [07:08:56] 10Pywikibot: Page/__init__.py: WikibaseEntity - https://phabricator.wikimedia.org/T281389 (10matej_suchanek) You are supposed to call `item.abc`, then it seems to fail. This should fail either, but the error message should rather be "there is nothing like abc" than "there is no getattr on super". Might be my mis... [07:19:37] 10Pywikibot, 10Patch-For-Review: Exception names does not follow PEP8 - https://phabricator.wikimedia.org/T280227 (10JJMC89) Not sure. It isn't just these new deprecations though. I also don't get a warning for pywikibot.MediaWikiVersion with Python 3.5.3 but do with 3.7.3. [07:39:29] (03CR) 10Matěj Suchánek: [C: 03+1] Replaced: use of Linker::link() with linkRenderer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/682313 (https://phabricator.wikimedia.org/T279333) (owner: 10Sahilgrewalhere) [08:34:51] 10Pywikibot, 10Patch-For-Review: Exception names does not follow PEP8 - https://phabricator.wikimedia.org/T280227 (10atagar) There seems to be a Python 3.5 issue regarding ModuleDeprecationWrapper. Would you like for me to install Python 3.5 to troubleshoot or should we continue with this? Personally I think... [11:19:32] 10Pywikibot: Page/__init__.py: WikibaseEntity - https://phabricator.wikimedia.org/T281389 (10Shalomori123) I think you tried to do something but it's not working. so if name not in self.DATA_ATTRIBUTES we need to raise an exception or warning, and delete the last line of the func... [11:28:09] 10Pywikibot, 10Pywikibot-replace.py: Replace.py: -addcat - https://phabricator.wikimedia.org/T281323 (10Shalomori123) 05Open→03Invalid Yes, my bad. But my mistake caused because it doesn't exists in the documentation in MW, so thought it's absolutely deprecated. [18:37:46] (03PS1) 10Catrope: search: Prevent double-escaping of messages passed to typeahead-search [skins/Vector] - 10https://gerrit.wikimedia.org/r/683696 [19:14:28] (03CR) 10Umherirrender: Fix PHPCS code style and many more small improvements (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/649670 (owner: 10Thiemo Kreuz (WMDE)) [19:48:01] (03PS1) 10Thiemo Kreuz (WMDE): Fix PHP notice in SpecialMassMessage because of short-circuit [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/683711 (https://phabricator.wikimedia.org/T281455) [19:48:55] (03PS1) 10Thiemo Kreuz (WMDE): Use actual namespace constants in the test [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/683712 [19:50:22] (03CR) 10Thiemo Kreuz (WMDE): Fix PHPCS code style and many more small improvements (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/649670 (owner: 10Thiemo Kreuz (WMDE)) [20:00:11] (03CR) 10Umherirrender: [C: 03+2] "It is a bit more than only the fix, but looks good" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/683711 (https://phabricator.wikimedia.org/T281455) (owner: 10Thiemo Kreuz (WMDE)) [20:08:11] (03Merged) 10jenkins-bot: Fix PHP notice in SpecialMassMessage because of short-circuit [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/683711 (https://phabricator.wikimedia.org/T281455) (owner: 10Thiemo Kreuz (WMDE)) [20:16:55] (03CR) 10Umherirrender: Use actual namespace constants in the test (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/683712 (owner: 10Thiemo Kreuz (WMDE)) [20:26:23] (03PS1) 10Umherirrender: Fix PHP notice in SpecialMassMessage because of short-circuit [extensions/MassMessage] (REL1_36) - 10https://gerrit.wikimedia.org/r/683632 (https://phabricator.wikimedia.org/T281455) [20:26:51] (03CR) 10Umherirrender: [C: 03+2] Fix PHP notice in SpecialMassMessage because of short-circuit [extensions/MassMessage] (REL1_36) - 10https://gerrit.wikimedia.org/r/683632 (https://phabricator.wikimedia.org/T281455) (owner: 10Umherirrender) [20:35:19] (03Merged) 10jenkins-bot: Fix PHP notice in SpecialMassMessage because of short-circuit [extensions/MassMessage] (REL1_36) - 10https://gerrit.wikimedia.org/r/683632 (https://phabricator.wikimedia.org/T281455) (owner: 10Umherirrender) [21:14:11] (03CR) 10Umherirrender: Replaced: use of Linker::link() with linkRenderer (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/682313 (https://phabricator.wikimedia.org/T279333) (owner: 10Sahilgrewalhere) [21:20:37] (03CR) 10Xqt: "recheck" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/682781 (owner: 10Damian) [21:20:50] (03CR) 10Xqt: "check experimental" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/682781 (owner: 10Damian) [21:24:50] (03CR) 10Jdlrobson: [C: 03+2] search: Prevent double-escaping of messages passed to typeahead-search [skins/Vector] - 10https://gerrit.wikimedia.org/r/683696 (owner: 10Catrope) [21:55:43] (03Merged) 10jenkins-bot: search: Prevent double-escaping of messages passed to typeahead-search [skins/Vector] - 10https://gerrit.wikimedia.org/r/683696 (owner: 10Catrope)