[03:37:48] 10Pywikibot: [dev] pre-commit for linting and code formatting - https://phabricator.wikimedia.org/T281633 (10JJMC89) [05:27:24] (03CR) 10Ngwebecky96: "This change is ready for review." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684066 (owner: 10Ngwebecky96) [05:30:37] (03CR) 10Ngwebecky96: "> Patch Set 1:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684066 (owner: 10Ngwebecky96) [05:31:57] (03CR) 10Damian: "Hi Ngwebecky96, are you sure this review is correctly created? Gerrit seems to indicate there aren't any code changes." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684066 (owner: 10Ngwebecky96) [05:58:09] (03PS1) 10Ngwebecky96: assertRaises with assertRaisesRegex and created the credentials to connect to the database, using if set db_connect_file = None [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684055 [05:58:11] (03PS1) 10Ngwebecky96: config file remains thesame [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684056 [05:58:14] (03PS1) 10Ngwebecky96: Merge branch 'master' of https://gerrit.wikimedia.org/r/pywikibot/core into T154281_and_T198428_bugfix [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684057 [06:04:56] (03CR) 10Ngwebecky96: "> Patch Set 1:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684066 (owner: 10Ngwebecky96) [06:07:07] (03CR) 10Ngwebecky96: "> Patch Set 1:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684066 (owner: 10Ngwebecky96) [07:20:27] (03PS1) 10Damian: [cleanup] Consistently use string's format() [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684061 [07:42:39] (03CR) 10JJMC89: [C: 03+2] [tests] remove isort from tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684017 (https://phabricator.wikimedia.org/T166950) (owner: 10Xqt) [07:45:02] (03Merged) 10jenkins-bot: [tests] remove isort from tests [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684017 (https://phabricator.wikimedia.org/T166950) (owner: 10Xqt) [07:45:04] (03Merged) 10jenkins-bot: [bugfix] Solve circular import if user-config.p is missing [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684014 (https://phabricator.wikimedia.org/T281551) (owner: 10Xqt) [08:06:38] (03CR) 10JJMC89: [C: 03+2] [fix] quote python version [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684062 (owner: 10JJMC89) [08:08:11] (03Abandoned) 10JJMC89: Merge branch 'master' of https://gerrit.wikimedia.org/r/pywikibot/core into T154281_and_T198428_bugfix [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684057 (owner: 10Ngwebecky96) [08:08:43] (03Merged) 10jenkins-bot: [fix] quote python version [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684062 (owner: 10JJMC89) [08:09:23] (03Abandoned) 10JJMC89: config file remains thesame [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684056 (owner: 10Ngwebecky96) [08:11:05] (03Abandoned) 10JJMC89: Replace assertRaises with assertRaisesRegex [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684066 (owner: 10Ngwebecky96) [08:18:02] 10Pywikibot, 10Pywikibot-tests: Travis CI tests failing due to missing user-config.py - https://phabricator.wikimedia.org/T281551 (10JJMC89) The patch didn't solve it. https://travis-ci.org/github/wikimedia/pywikibot/jobs/769205872 `lines=10 $ python pwb.py generate_family_file 'https://wiki.musicbrainz.org/'... [09:14:46] 10Pywikibot, 10Pywikibot-tests: Travis CI tests failing due to missing user-config.py - https://phabricator.wikimedia.org/T281551 (10Xqt) The patch solves the issue for Python 3.7+ but it still fails with Python 3.5/3.6 [09:20:22] (03PS1) 10Xqt: [bugfix] Import exceptions directly to solve circular imports in Python 3.6- [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684063 (https://phabricator.wikimedia.org/T281551) [09:24:06] (03CR) 10Xqt: "@Ngwebecky96: Your code base seems outdated. Please rebase your patch." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684055 (owner: 10Ngwebecky96) [09:28:35] (03CR) 10Xqt: assertRaises with assertRaisesRegex and created the credentials to connect to the database, using if set db_connect_file = None (034 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684055 (owner: 10Ngwebecky96) [09:32:04] (03CR) 10Xqt: "Please split such big patches into parts. I agree wiht this itention but this long pathc is really hard to review not only via mobile." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684061 (owner: 10Damian) [09:35:15] (03CR) 10Ngwebecky96: "> Patch Set 1:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684055 (owner: 10Ngwebecky96) [09:35:51] (03CR) 10Xqt: "recheck" (031 comment) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684023 (owner: 10Gerrit Patch Uploader) [09:37:58] (03CR) 10jerkins-bot: [V: 04-1] allow access to the Filters EdittimeFilterPageGenerator and UserEditFilterGenerator [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684023 (owner: 10Gerrit Patch Uploader) [10:00:34] (03CR) 10Damian: "> Please split such big patches into parts. I agree wiht this itention but this long pathc is really hard to review not only via mobile." [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684061 (owner: 10Damian) [10:41:14] (03Abandoned) 10Ngwebecky96: assertRaises with assertRaisesRegex and created the credentials to connect to the database, using if set db_connect_file = None [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684055 (owner: 10Ngwebecky96) [11:51:02] (03CR) 10Xqt: allow access to the Filters EdittimeFilterPageGenerator and UserEditFilterGenerator (038 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684023 (owner: 10Gerrit Patch Uploader) [11:57:19] (03CR) 10Xqt: "> Patch Set 1:" [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684061 (owner: 10Damian) [12:21:22] 10Pywikibot: [dev] pre-commit for linting and code formatting - https://phabricator.wikimedia.org/T281633 (10Xqt) Can you please introduce a bit more of your Approach. What does this mean for code styles, styles check, the code itself, ceviewers, coders, uploaders. [13:28:08] (03PS1) 10Xqt: [doc] Fix conf.pywikibot_epytext_to_sphinx() function [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684095 [13:30:48] (03CR) 10jerkins-bot: [V: 04-1] [doc] Fix conf.pywikibot_epytext_to_sphinx() function [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684095 (owner: 10Xqt) [13:41:18] (03PS2) 10Xqt: [doc] Fix conf.pywikibot_epytext_to_sphinx() function [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684095 [15:17:59] (03CR) 10Xqt: [cleanup] Consistently use string's format() (0348 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684061 (owner: 10Damian) [16:31:59] 10Pywikibot: Pywikibot: avoid double logging of output - https://phabricator.wikimedia.org/T281643 (10Inductiveload) [17:08:07] (03CR) 10JJMC89: [C: 03+2] [bugfix] Import exceptions directly to solve circular imports in Python 3.6- [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684063 (https://phabricator.wikimedia.org/T281551) (owner: 10Xqt) [17:10:17] (03Merged) 10jenkins-bot: [bugfix] Import exceptions directly to solve circular imports in Python 3.6- [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684063 (https://phabricator.wikimedia.org/T281551) (owner: 10Xqt) [18:14:19] 10Pywikibot, 10Pywikibot-replace.py: replace.py: uncaught exception - https://phabricator.wikimedia.org/T280043 (10Xqt) a:03Xqt [18:25:05] (03PS1) 10Xqt: [FEAT] skip InvalidPageError in replace.py and fixing_redirects.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684118 (https://phabricator.wikimedia.org/T280043) [18:27:39] (03PS2) 10Xqt: [FEAT] skip InvalidPageError in replace.py and fixing_redirects.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684118 (https://phabricator.wikimedia.org/T280043) [18:27:43] (03CR) 10jerkins-bot: [V: 04-1] [FEAT] skip InvalidPageError in replace.py and fixing_redirects.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684118 (https://phabricator.wikimedia.org/T280043) (owner: 10Xqt) [18:29:42] (03CR) 10jerkins-bot: [V: 04-1] [FEAT] skip InvalidPageError in replace.py and fixing_redirects.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684118 (https://phabricator.wikimedia.org/T280043) (owner: 10Xqt) [18:36:34] (03PS3) 10Xqt: [FEAT] skip InvalidPageError in replace.py and fixing_redirects.py [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684118 (https://phabricator.wikimedia.org/T280043) [18:46:09] 10Pywikibot: Pywikibot: avoid double logging of output - https://phabricator.wikimedia.org/T281643 (10Xqt) See also T264235 [18:46:24] 10Pywikibot: Pywikibot: avoid double logging of output - https://phabricator.wikimedia.org/T281643 (10Xqt) p:05Triage→03Medium [18:56:15] (03PS1) 10Xqt: [typing] plural.py: import Dict from backports [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684119 [18:58:44] (03CR) 10jerkins-bot: [V: 04-1] [typing] plural.py: import Dict from backports [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684119 (owner: 10Xqt) [19:00:19] (03PS2) 10Xqt: [typing] plural.py: import Dict from backports [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684119 [19:49:12] (03CR) 10Xqt: [cleanup] Consistently use string's format() (0313 comments) [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684061 (owner: 10Damian) [22:41:57] (03CR) 10JJMC89: [C: 03+2] [typing] plural.py: import Dict from backports [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684119 (owner: 10Xqt) [22:44:12] (03Merged) 10jenkins-bot: [typing] plural.py: import Dict from backports [pywikibot/core] - 10https://gerrit.wikimedia.org/r/684119 (owner: 10Xqt) [23:48:32] 10Pywikibot: [dev] pre-commit for linting and code formatting - https://phabricator.wikimedia.org/T281633 (10JJMC89) [23:49:44] 10Pywikibot: [dev] pre-commit for linting and code formatting - https://phabricator.wikimedia.org/T281633 (10JJMC89)