[00:05:11] (03CR) 10Aaron Schulz: "I agree with Alex. It should at least deal with those or it would seem to random." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Matmarex) [00:26:37] (03PS1) 10Shirayuki: Add a full-stop to the error message [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80322 [00:44:55] (03PS1) 10Mattflaschen: Cache a variable locally before it is reset on the instance [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80325 [01:23:56] (03PS1) 10Mollywhite: Bug 52310: Disallow empty JSON blocks (don't merge) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80326 [02:19:56] (03CR) 10MF-Warburg: "To copy my answer from meta:" [core] - 10https://gerrit.wikimedia.org/r/78504 (owner: 10Liangent) [02:20:12] (03PS1) 10Mattflaschen: Fix i18n description for some parameters. Add missing desc [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/80329 [02:56:09] (03CR) 10Spage: "(22 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [03:08:52] (03CR) 10Ori.livneh: "This needs a review from Roan, Trevor, or Timo before because it extends ResourceLoader and it's important to do that right. Please keep t" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [03:18:24] (03PS1) 10CSteipp: Use User Preference for logged-in HTTPS choice [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80331 [03:38:39] (03CR) 10Parent5446: [C: 031] "All looks good, although I think you need a rebase." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [03:40:10] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79761 (owner: 10MaxSem) [03:50:28] (03PS1) 10CSteipp: Setup cookies security based on user preference [core] - 10https://gerrit.wikimedia.org/r/80334 [04:57:39] Yippie, build fixed! [04:57:40] Project browsertests-en.wikipedia.org-linux-chrome build #266: FIXED in 3 min 40 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/266/ [05:02:13] Yippie, build fixed! [05:02:13] Project browsertests-en.wikipedia.org-linux-firefox build #252: FIXED in 4 min 33 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/252/ [05:04:15] (03PS1) 10Mattflaschen: Hide thank link when there is no JavaScript [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/80336 [05:07:07] (03PS2) 10Mattflaschen: Hide thank link when there is no JavaScript [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/80336 [05:07:20] Yippie, build fixed! [05:07:21] Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #125: FIXED in 5 min 6 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/125/ [05:17:08] Yippie, build fixed! [05:17:09] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #213: FIXED in 6 min 4 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/213/ [05:52:57] Yippie, build fixed! [05:52:57] Project browsertests-test2.wikipedia.org-linux-firefox build #509: FIXED in 26 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/509/ [06:54:38] (03PS1) 10Mattflaschen: Put 'use strict' at top of outermost function in all files [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/80342 [06:56:08] (03CR) 10Mattflaschen: "This is a follow-up to a comment on the OB6 patch. I don't have strong feelings about having this. But if we do, wee should be consisten" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/80342 (owner: 10Mattflaschen) [07:20:26] (03CR) 10Nikerabbit: "(2 comments)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80090 (owner: 10Mollywhite) [07:26:13] (03PS66) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [07:29:23] (03PS67) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [07:31:06] (03CR) 10Wikinaut: [C: 031 V: 031] "rebased." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [07:31:16] (03PD67) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [07:44:47] (03CR) 10Nikerabbit: [C: 032] Add a full-stop to the error message [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80322 (owner: 10Shirayuki) [08:07:25] Nikerabbit: needs submit [08:14:11] (03CR) 10Nikerabbit: [V: 032] Add a full-stop to the error message [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/80322 (owner: 10Shirayuki) [08:18:14] (03CR) 10Springle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79761 (owner: 10MaxSem) [08:20:28] hey springle [08:39:28] MaxSem, hi [08:43:27] springle, thnks for explaining this - I was going insane about my results mismatching the others [08:44:10] the explain rows? [08:44:24] yup [08:44:31] np [08:58:54] (03CR) 10Tpt: [C: 04-1] "(5 comments)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/74850 (owner: 10Rtdwivedi) [09:06:07] (03PS6) 10Mattflaschen: Towards OB6: show a popup CTA to test onboarders [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [09:07:28] (03CR) 10Mattflaschen: "(27 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/77087 (owner: 10Spage) [09:16:45] 27 comments! [09:20:28] (03CR) 10Hoo man: "Could someone verify that this works in screen readers so that we can have this merged?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/79639 (owner: 10Hoo man) [09:42:23] (03CR) 10Matthias Mullie: [C: 032] Only last 20 entries shown for non-default timezone settings [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/79940 (owner: 10Bsitu) [09:42:43] (03Merged) 10jenkins-bot: Only last 20 entries shown for non-default timezone settings [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/79940 (owner: 10Bsitu) [10:10:34] (03CR) 10Matmarex: "That's far from trivial – what to do if, in a stack of five edits, one of the middle ones was undid without anything being sighted? Tellin" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Matmarex) [10:15:26] If I got duplicate bugs, which one "wins" and which one should I RESOLVE DUPLICATE? [10:16:53] (03CR) 10Hoo man: [C: 04-1] "As we already have (working) mw-jump links we should consider completely removing the tabindex from the sidebar headings so that they'll g" [extensions/Vector] - 10https://gerrit.wikimedia.org/r/65115 (owner: 10Orenhe) [10:19:41] hoo: the one with most discussion on it [10:19:46] hoo: or the earliest one [10:20:03] mh, I have https://bugzilla.wikimedia.org/show_bug.cgi?id=29199 and https://bugzilla.wikimedia.org/show_bug.cgi?id=24581 [10:20:16] I already got confused about them myself :P [10:22:05] only one got the accessibility keyword set... [10:23:01] nobody cares about keywords [10:23:07] except for elsie adding "easy" [10:23:13] and krinkleadding "code-update-regresison" [10:23:23] MatmaRex: :P I keep searching accessibility bugs by keyword... [10:24:04] and sumana adding "design" [10:24:24] but "easy" is the only one that's actually used for something afaik [10:25:48] Mediawiki doesn't support using Redis instead of Memcached for caching? [10:57:36] MatmaRex: accessibility is used by people that care about a11y... [10:57:48] YuviPanda: {{SOFIXIT}} [10:58:28] NO YOU! [10:58:34] wmde even has hooman on contract working on a11y issues [10:58:38] afaik [10:59:12] p858snake|l: That's true ;) [10:59:25] YuviPanda: I will need 30KG of gummibears... a few reams of duct tape and some paper clips to fix it [10:59:41] sounds cheap [11:20:21] (03PS1) 10Nemo bis: Fix typo "one of the wiki" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80360 [11:21:21] (03PS2) 10Nemo bis: Fix typo "one of the wiki" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80360 [12:00:14] thedj: around? [12:00:32] thedj: did we break tablesorter again? https://pl.wikipedia.org/wiki/Wikipedysta:Mateusz.ns/brudnopis#Skok_w_dal try sorting this by "Wynik" [12:01:05] then trysorting by"Uwagi" and note that it actually sorts by "Wynik" [12:01:16] the colspan seems to be breaking shit [12:06:17] (03CR) 10Liangent: "MF-Warburg: There's already a message left there on https://zh-yue.wikipedia.org/w/index.php?title=Wikipedia:%E5%9F%8E%E5%B8%82%E8%AB%96%E" [core] - 10https://gerrit.wikimedia.org/r/78504 (owner: 10Liangent) [12:10:14] (03CR) 10Liangent: "On technical aspects: I need some Cantonese-native people to confirm that conversion table for Chinese also works well there (it's known t" [core] - 10https://gerrit.wikimedia.org/r/78504 (owner: 10Liangent) [12:11:23] http://www.reddit.com/r/netsec/comments/1ks1e6/wikipedia_will_shortly_enable_https_for_all/cbsxgzx?context=3 [12:11:23] sigh [12:16:57] Krenair: well, it's a perennial controversy [12:29:37] (03CR) 10Hoo man: [C: 032] "Trivial one... thanks for fixing" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80360 (owner: 10Nemo bis) [12:29:40] (03Merged) 10jenkins-bot: Fix typo "one of the wiki" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80360 (owner: 10Nemo bis) [12:35:20] thanks hoo|away and sorry for the mistake I introduced [12:37:01] hey, Krenair [12:37:19] Krenair: seen my reply on the echo/flaggedrevs stuff? [12:37:27] probably not [12:37:29] I've been busy today [12:37:36] got my GCSE results [12:37:59] ( https://gerrit.wikimedia.org/r/79775 ) [12:39:32] Hm. [12:39:36] I hadn't considered that problem. [12:40:06] how's the gcse? [12:40:29] A* Maths, A Religious Studies, rest are Bs and Cs. [12:40:51] No Ds or lower, in GCSE courses anyway. [12:41:12] :D [12:44:48] I understand the problem you have, but I still think we should at least attempt it before merging your commit. [12:45:06] I wonder what AaronSchulz thinks [12:46:32] AaronSchulz: *poke* [12:46:47] idle 12h, 56m, eh. [12:51:53] (03PS1) 10Mwjames: Register #ask/#show as closure, eliminate static render method and $GLOBALS [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80365 [13:11:40] (03PD1) 10Addshore: Uncomment tag_summary, valid_tag tables for mysql [core] - 10https://gerrit.wikimedia.org/r/80367 [13:12:46] (03CR) 10Daniel Werner: "(1 comment)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/79639 (owner: 10Hoo man) [13:21:29] (03CR) 10Reedy: [C: 032] update wikidata extension branches [tools/release] - 10https://gerrit.wikimedia.org/r/80217 (owner: 10Aude) [13:21:32] (03Merged) 10jenkins-bot: update wikidata extension branches [tools/release] - 10https://gerrit.wikimedia.org/r/80217 (owner: 10Aude) [13:57:46] (03PS1) 10VitaliyFilippov: Fix array to string conversion notice for 1.8.x / 1.9.x [extensions/SemanticMediaWiki] (1.8.x) - 10https://gerrit.wikimedia.org/r/80372 [14:17:44] (03PS1) 10Anomie: Fix possible fatal error [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/80376 [14:25:44] (03PS1) 10Reedy: Re-add OAuth as it wasn't added to make-wmf-branch [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80378 [14:25:57] (03CR) 10Reedy: [C: 032 V: 032] Re-add OAuth as it wasn't added to make-wmf-branch [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80378 (owner: 10Reedy) [14:27:26] (03PS1) 10Reedy: Add OAuth to make-wmf-branch [tools/release] - 10https://gerrit.wikimedia.org/r/80379 [14:27:33] (03PS1) 10Shirayuki: Use the long PHP tag [extensions/Josa] - 10https://gerrit.wikimedia.org/r/80380 [14:27:39] (03CR) 10Reedy: [C: 032] Add OAuth to make-wmf-branch [tools/release] - 10https://gerrit.wikimedia.org/r/80379 (owner: 10Reedy) [14:27:56] (03Merged) 10jenkins-bot: Add OAuth to make-wmf-branch [tools/release] - 10https://gerrit.wikimedia.org/r/80379 (owner: 10Reedy) [14:30:46] (03PS1) 10Reedy: Update populateHomeDB script to only update when home is null [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80381 [14:33:16] (03PS1) 10Mollywhite: Escape wfMessages in links [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80383 [14:33:47] (03CR) 10Mollywhite: [C: 032 V: 032] Escape wfMessages in links [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80383 (owner: 10Mollywhite) [14:35:05] (03PS1) 10Shirayuki: Use the long PHP tag [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/80384 [14:41:04] (03PS2) 10Mwjames: Register #ask/#show as closure, eliminate static render method and $GLOBALS [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80365 [14:48:33] (03PS2) 10Reedy: Update populateHomeDB script to only update when home is null [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80381 [14:53:29] (03CR) 10Parent5446: [C: 04-1] "This introduces an inconsistency in behavior. The idea behind the login form is that the protocol the user logs into should be the protoco" [core] - 10https://gerrit.wikimedia.org/r/80334 (owner: 10CSteipp) [14:56:24] (03CR) 10Krinkle: "UX regression (bug 53213). Please don't arbitrarily change things when moving from extension to core, especially with no rationale. This i" [core] - 10https://gerrit.wikimedia.org/r/54089 (owner: 10Matmarex) [14:58:55] (03CR) 10Parent5446: [C: 031] Uncomment tag_summary, valid_tag tables for mysql [core] - 10https://gerrit.wikimedia.org/r/80367 (owner: 10Addshore) [14:59:59] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79761 (owner: 10MaxSem) [15:00:43] (03PS1) 10Shirayuki: Use the long PHP tag [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/80387 [15:01:20] (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79761 (owner: 10MaxSem) [15:05:09] (03CR) 10Matmarex: "Won't this run the patch file three times? It should probably besplit." [core] - 10https://gerrit.wikimedia.org/r/80367 (owner: 10Addshore) [15:07:14] (03PS1) 10Nikerabbit: Two scenarios for ULS settings live preview feature [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80388 [15:08:54] (03CR) 10Reedy: [C: 04-1] "Seems to be a broken edge case where you only have the first table... Presumably they were all added together, so how would you get in tha" [core] - 10https://gerrit.wikimedia.org/r/80367 (owner: 10Addshore) [15:13:07] (03CR) 10TheDJ: "I agree that cols is pretty much useless, since it is at 100% for almost everyone these days, but rows still does have a significant effec" [core] - 10https://gerrit.wikimedia.org/r/80061 (owner: 10Demon) [15:16:45] (03CR) 10TheDJ: "Also, is cols 25 still a good default to begin with ? Screens are much larger these days, perhaps we should increase the height a bit ?" [core] - 10https://gerrit.wikimedia.org/r/80061 (owner: 10Demon) [15:21:33] MatmaRex: looks like it's the unsortable nature of the colspan.. [15:22:58] * MatmaRex barfs [15:23:10] thedj[work]: i fileda bug in the meantime btw [15:23:35] https://bugzilla.wikimedia.org/show_bug.cgi?id=53211 [15:26:40] well, those cases were never really supported to begin with until recently, let alone that unsortable really worked in such a case. [15:27:11] i'll add it to the huge stack of issue that i want to look at but am not getting around to :D [15:29:01] tablesorter has just gotta be the evilest part of our javascript [15:29:47] yeah, it's mostly a sideffect of doing a lot of wikitable interpretation. [15:30:49] and the parsers are somewhat crap. someone has create a tablesorter.org derivative with a gazillion new parser/sorter definitions that include testcases for them btw. [15:31:23] we should see if we can import some of them. Ours are from the earliest tablesorter.org 2.0 import, and they are kind of weak. [15:31:32] there's a bug about that [15:31:49] actually, about killing some of the parsers and implementing a "natural sorting" algorithm [15:31:51] (03CR) 10Anomie: "(1 comment)" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/63565 (owner: 10Anomie) [15:32:10] https://bugzilla.wikimedia.org/show_bug.cgi?id=45161 [15:32:19] (03CR) 10MaxSem: "Maybe, we should just adjust the textarea size with JS depending on viewable area size?" [core] - 10https://gerrit.wikimedia.org/r/80061 (owner: 10Demon) [15:32:24] that is on my list of things that i want to get around to. :P [15:32:52] (03CR) 10Matmarex: "Don't browsers aroundusers to resize textareas? My Opera 12 does, at least." [core] - 10https://gerrit.wikimedia.org/r/80061 (owner: 10Demon) [15:33:07] (03CR) 10Matmarex: "allow users*" [core] - 10https://gerrit.wikimedia.org/r/80061 (owner: 10Demon) [15:33:20] MatmaRex: good luck with finding support for that on en.wp :D [15:41:01] (03PS2) 10Anomie: Invalid data should cause an error, not a silent placeholder [php/luasandbox] - 10https://gerrit.wikimedia.org/r/63565 [15:41:13] (03PS3) 10Anomie: Invalid data should cause an error, not a silent placeholder [php/luasandbox] - 10https://gerrit.wikimedia.org/r/63565 [16:01:18] morning greg-g! [16:02:06] g'morning! [16:02:11] am I all free to explode CentralNotice? [16:02:24] well... if you put it that way...... [16:02:29] yes, go for it ;) [16:02:29] hehe :D [16:07:20] Remember we have 3 versions of MW today! [16:07:34] really? 12, 13, and? [16:07:37] 14? [16:07:46] Reedy, OMG THINK OF APC [16:07:54] yeah [16:08:02] 12 will go away in a couple of hours [16:08:22] (03PS1) 10Mwalker: Updating CentralNotice to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80395 [16:08:51] 14 isn't in use but is in situ, and you might not have to update CN manual [16:09:47] (03PS1) 10Mwalker: Updating CentralNotice to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80396 [16:10:51] anyone mind a review? should be an easy one: https://gerrit.wikimedia.org/r/#/c/79971/ [16:11:18] (03PS1) 10Mwalker: Updating CentralNotice to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80397 [16:11:52] (03CR) 10Reedy: [C: 04-1] "Looks like something went wrong" [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80397 (owner: 10Mwalker) [16:12:00] (03Abandoned) 10Mwalker: Updating CentralNotice to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80395 (owner: 10Mwalker) [16:12:02] (03CR) 10Reedy: [C: 04-1] "Looks like something went wrong" [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80396 (owner: 10Mwalker) [16:12:09] (03Abandoned) 10Mwalker: Updating CentralNotice to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80396 (owner: 10Mwalker) [16:12:15] (03Abandoned) 10Mwalker: Updating CentralNotice to master [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80397 (owner: 10Mwalker) [16:13:09] (03CR) 10Reedy: [C: 032] Add postgres support [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/79971 (owner: 10Ryan Lane) [16:13:17] Reedy: thanks! [16:13:28] (03Merged) 10jenkins-bot: Add postgres support [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/79971 (owner: 10Ryan Lane) [16:16:32] (03PS1) 10Mwalker: Update centralnotice to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80398 [16:21:14] (03PS1) 10Mwalker: Update CentralNotice to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80399 [16:24:21] (03CR) 10Mwalker: [C: 032] Update centralnotice to master [core] (wmf/1.22wmf12) - 10https://gerrit.wikimedia.org/r/80398 (owner: 10Mwalker) [16:24:36] (03CR) 10Mwalker: [C: 032] Update CentralNotice to master [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80399 (owner: 10Mwalker) [16:47:26] (03PS1) 10EBernhardson (WMF): Allow wikitext in the summary block [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80402 [17:02:17] (03PS1) 10Brian Wolff: Extension to screen scrape metadata out of commons [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/80403 [17:05:45] (03PS1) 10Demon: Default is not necessary for toggle fields [core] - 10https://gerrit.wikimedia.org/r/80405 [17:07:18] (03CR) 10Krinkle: "Don't use empty()." [core] - 10https://gerrit.wikimedia.org/r/80064 (owner: 10Aaron Schulz) [17:10:47] (03PS3) 10IAlex: Don't do special page cache updates if --list or --only parameters passed [core] - 10https://gerrit.wikimedia.org/r/79283 (owner: 10Reedy) [17:11:14] (03CR) 10IAlex: [C: 032] Don't do special page cache updates if --list or --only parameters passed [core] - 10https://gerrit.wikimedia.org/r/79283 (owner: 10Reedy) [17:13:00] greg-g: looks like I deployed successfully [17:13:28] mwalker: well done, sir [17:13:44] the only thing I encountered was that when things were forked for wmf14; the off repo bugfix for CN didn't go along with it [17:14:30] but I'm not sure if that was live yet or not [17:16:42] (03Merged) 10jenkins-bot: Don't do special page cache updates if --list or --only parameters passed [core] - 10https://gerrit.wikimedia.org/r/79283 (owner: 10Reedy) [17:20:03] (03PS2) 10IAlex: If --only and we've had a hit, no need to continue iteration over $wgQueryPages [core] - 10https://gerrit.wikimedia.org/r/79289 (owner: 10Reedy) [17:20:17] (03CR) 10IAlex: [C: 032] If --only and we've had a hit, no need to continue iteration over $wgQueryPages [core] - 10https://gerrit.wikimedia.org/r/79289 (owner: 10Reedy) [17:21:00] (03PS1) 10Umherirrender: Add class around diff-empty and add it as notice [core] - 10https://gerrit.wikimedia.org/r/80406 [17:25:10] (03Merged) 10jenkins-bot: If --only and we've had a hit, no need to continue iteration over $wgQueryPages [core] - 10https://gerrit.wikimedia.org/r/79289 (owner: 10Reedy) [17:27:26] whee [17:28:19] (03PS2) 10Ryan Lane: htmlform muliselect chosen: convert each list [core] - 10https://gerrit.wikimedia.org/r/78213 [17:28:20] (03CR) 10Bsitu: [C: 032] Fix i18n description for some parameters. Add missing desc [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/80329 (owner: 10Mattflaschen) [17:29:08] (03Merged) 10jenkins-bot: Fix i18n description for some parameters. Add missing desc [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/80329 (owner: 10Mattflaschen) [17:30:31] (03CR) 10Nikerabbit: [C: 032] Use the long PHP tag [extensions/Josa] - 10https://gerrit.wikimedia.org/r/80380 (owner: 10Shirayuki) [17:31:40] (03PS1) 10Mattflaschen: Remove comment saying code should add RL dependencies directly [core] - 10https://gerrit.wikimedia.org/r/80408 [17:31:48] (03CR) 10Nikerabbit: [C: 032] Use the long PHP tag [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/80384 (owner: 10Shirayuki) [17:32:23] (03Merged) 10jenkins-bot: Use the long PHP tag [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/80384 (owner: 10Shirayuki) [17:32:38] (03PS3) 10Reedy: action=edit API with section=new would fail if page didn't exist [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79950 [17:32:48] ori-l: https://gerrit.wikimedia.org/r/#/c/78213/ [17:33:01] (03CR) 10Reedy: [C: 032] action=edit API with section=new would fail if page didn't exist [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79950 (owner: 10Reedy) [17:33:11] * ori-l looks [17:33:47] parentnode.nodename is tbody/div. it's not really the right container [17:34:04] looking for div/tr on nodename works reliably, though [17:34:42] (03PS1) 10IAlex: Rebuild MessagesEn.php [core] - 10https://gerrit.wikimedia.org/r/80409 [17:35:07] (03CR) 10Nikerabbit: [V: 032] Use the long PHP tag [extensions/Josa] - 10https://gerrit.wikimedia.org/r/80380 (owner: 10Shirayuki) [17:35:59] Ryan_Lane: looks good. line 115 has an extra indent, if you fix that i'll +2 [17:36:19] isn't that supposed to be indented? [17:36:23] oh, no, it doesn't [17:36:26] yeah, it's fine [17:36:34] gerrit's tabs are just super-wide [17:36:40] so it looked off [17:36:57] (03CR) 10Ori.livneh: [C: 032] htmlform muliselect chosen: convert each list [core] - 10https://gerrit.wikimedia.org/r/78213 (owner: 10Ryan Lane) [17:37:51] ah, ok [17:37:53] thanks [17:37:57] now to rebase the other one [17:38:38] (03Merged) 10jenkins-bot: action=edit API with section=new would fail if page didn't exist [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/79950 (owner: 10Reedy) [17:40:43] (03PS2) 10Parent5446: Default is not necessary for toggle fields [core] - 10https://gerrit.wikimedia.org/r/80405 (owner: 10Demon) [17:41:07] (03CR) 10Parent5446: "If you rebase this on master, it can be merged, because it doesn't really depend on the columns patch." [core] - 10https://gerrit.wikimedia.org/r/80405 (owner: 10Demon) [17:42:21] (03Merged) 10jenkins-bot: htmlform muliselect chosen: convert each list [core] - 10https://gerrit.wikimedia.org/r/78213 (owner: 10Ryan Lane) [17:42:33] (03PS3) 10Demon: Default is not necessary for toggle fields [core] - 10https://gerrit.wikimedia.org/r/80405 [17:43:06] (03CR) 10Demon: "Rebased. Yeah, that was a stupid mistake on my part." [core] - 10https://gerrit.wikimedia.org/r/80405 (owner: 10Demon) [17:44:26] (03PS2) 10Aaron Schulz: Make thumb.php give http redirects if given a file redirect. [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff) [17:47:58] (03PS1) 10IAlex: Update Special:ChangePassword to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/80411 [17:48:08] (03PS2) 10Ryan Lane: htmlform multiselect chosen: Replace lists [core] - 10https://gerrit.wikimedia.org/r/78214 [17:48:43] ori-l: https://gerrit.wikimedia.org/r/#/c/78214/2 <-- just a rebase [17:49:49] (03PS4) 10Jdlrobson: Apply mobile typography lessons to Vector [core] - 10https://gerrit.wikimedia.org/r/79948 [17:50:33] (03PS2) 10Krinkle: Remove comment saying code should add RL dependencies directly [core] - 10https://gerrit.wikimedia.org/r/80408 (owner: 10Mattflaschen) [17:50:34] (03CR) 10Jdlrobson: [C: 04-1] "Could someone who knows the account creation/login form stuff better than me address the TODO in the commit message?" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [17:50:57] (03CR) 10Krinkle: [C: 032] Remove comment saying code should add RL dependencies directly [core] - 10https://gerrit.wikimedia.org/r/80408 (owner: 10Mattflaschen) [17:52:07] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78669 (owner: 10Ori.livneh) [17:52:36] (03PS2) 10Rjain: Added a tab to toggle visibility of annotations [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 [17:55:34] anyone mind a quick review? It's a really simply one: https://gerrit.wikimedia.org/r/#/c/76124/1 [17:57:12] Ryan_Lane: Shouldn't you set the fields type from password to text then? [17:57:59] (03Merged) 10jenkins-bot: Remove comment saying code should add RL dependencies directly [core] - 10https://gerrit.wikimedia.org/r/80408 (owner: 10Mattflaschen) [17:58:00] ah. yes [17:58:03] whoops [18:00:10] (03PS2) 10Ryan Lane: Don't mask token on input [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/76124 [18:00:17] hoo: ^^ [18:01:37] (03CR) 10Hoo man: [C: 032] "Given that tokens are useless after having been used this should be fine" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/76124 (owner: 10Ryan Lane) [18:01:41] (03Merged) 10jenkins-bot: Don't mask token on input [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/76124 (owner: 10Ryan Lane) [18:01:52] \o/ [18:01:52] thanks [18:02:05] (03CR) 10Aaron Schulz: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff) [18:02:19] ;) [18:02:19] (03PS1) 10Anomie: Allow ParserLimitReportFormat to change $value [core] - 10https://gerrit.wikimedia.org/r/80412 [18:03:12] Krenair: I think I've fixed your -1 issue on this: https://gerrit.wikimedia.org/r/#/c/68126/ [18:03:58] (03CR) 10Anomie: "(5 comments)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/53804 (owner: 10Anomie) [18:04:11] (03PS7) 10Anomie: Use the new limit report hooks [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/53804 [18:04:47] irc office hours with multimedia team happening now in #wikimedia-office [18:04:54] (03CR) 10Parent5446: [C: 032] Default is not necessary for toggle fields [core] - 10https://gerrit.wikimedia.org/r/80405 (owner: 10Demon) [18:05:23] (03CR) 10jenkins-bot: [V: 04-1] Use the new limit report hooks [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/53804 (owner: 10Anomie) [18:05:39] (03PS1) 10Krinkle: Add David Chan to test pipeline auth [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80413 [18:07:53] (03Merged) 10jenkins-bot: Default is not necessary for toggle fields [core] - 10https://gerrit.wikimedia.org/r/80405 (owner: 10Demon) [18:11:18] Reedy: 0cf496630 in LdapAuth is problematic :) [18:11:39] you've marked some functions as private that are used in OpenStackManager [18:11:52] I guess I should mark them explicitly as public [18:12:56] (03CR) 10Mwalker: [C: 032] Bug 51239: Draft JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 (owner: 10Mollywhite) [18:13:53] (03Merged) 10jenkins-bot: Bug 51239: Draft JSON editor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/78264 (owner: 10Mollywhite) [18:14:49] (03PS1) 10Ryan Lane: Mark getUserDN as it's used from OpenStackManager [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/80414 [18:16:40] (03CR) 10Parent5446: [C: 031] Update Special:ChangePassword to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [18:17:15] (03CR) 10Ryan Lane: [C: 032 V: 032] Mark getUserDN as it's used from OpenStackManager [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/80414 (owner: 10Ryan Lane) [18:17:18] (03CR) 10Jforrester: "(1 comment)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80413 (owner: 10Krinkle) [18:17:20] (03Abandoned) 10Parent5446: Changed temporary password system to use tokens. [core] - 10https://gerrit.wikimedia.org/r/27472 (owner: 10Parent5446) [18:17:55] (03Abandoned) 10Parent5446: Re-implemented Special:Userlogin using FormSpecialPage. [core] - 10https://gerrit.wikimedia.org/r/27022 (owner: 10Parent5446) [18:18:03] (03Abandoned) 10Parent5446: Notify user by email when password changed [core] - 10https://gerrit.wikimedia.org/r/48578 (owner: 10Parent5446) [18:18:21] (03PS1) 10Aaron Schulz: Simplified some tedious profiling code [core] - 10https://gerrit.wikimedia.org/r/80416 [18:25:55] (03PS7) 10Rjain: Added support for creating annotations by logged out users [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 [18:26:23] (03CR) 10jenkins-bot: [V: 04-1] Added support for creating annotations by logged out users [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [18:26:51] (03PS5) 10Mattflaschen: Apply mobile typography lessons to Vector [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [18:29:56] (03PS8) 10Rjain: Added support for creating annotations by logged out users [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 [18:30:57] who do I bug about a bug in Wikidata? There is no component on bugzilla [18:31:10] werdna: There is [18:31:15] what's it called? [18:31:20] MediaWiki extensions -> Wikidata client/repo [18:31:22] We see Wikidata Client and Wikidata repo [18:31:27] Yep [18:31:36] Where do you see the bug? [18:31:54] the particular bug is in Wikibase/client/WikibaseClient.hooks.php [18:31:56] so i suppose client :P [18:32:21] hey, quick question [18:32:26] related to bot detection [18:33:27] Can mediawiki have something attached to all its requests(like a header or a parameter) from people using browsers [18:33:47] ebernhardson: Yep [18:33:52] this would be cool in order to differentiate easily between bots/regular users [18:34:02] maybe something like this is already present ? [18:34:18] cookies? [18:34:41] aude: Poke? [18:34:41] bawolff: cookies would be cool too, but those aren't available in the squid logs [18:34:51] I mean, I'm sure it keeps cookies already [18:35:05] * aude hides [18:35:12] werdna: what's the issue? [18:35:15] might also be my mistake :D [18:35:16] aude: :) Can I ask you something about RC_EXTERNAL? [18:35:21] ok [18:35:26] * hoo runs away very fast [18:35:32] but bawolff what do you think ? [18:35:49] aude: It looks like it's supposed to be generally usable, but WikiData is full of assumptions that *all* RC_EXTERNAL entries are WikiData-related [18:36:07] That really depends on how you set up your logging. Cookies are literally an extra header some people are using [18:36:15] So I'm wondering if maybe I'm missing some way of making our RC_EXTERNAL not conflict with your RC_EXTERNAL [18:36:17] i am aware [18:36:24] bawolff: have you seen the squid logs ? [18:36:25] ok.... [18:36:40] Ah damn, that had to come up sooner or later [18:36:53] we even have a function which clears all RC entries which are RC_EXTERNAL I think :P [18:36:55] Or do we need to do some separation work ourselves? or? [18:37:03] hoo: yeah, we saw [18:37:07] love the ASCII art by the way [18:37:15] we need to figure out a way to distingish them efficiently [18:37:43] we do stuff things into rc_params [18:37:55] but that's not efficient for querying obviously [18:38:53] hoo: deleting all the data with RC_EXTERNAL was our first hint there was a problem :) [18:38:56] it could be change tags or something maybe [18:39:04] but not sure how that scales [18:39:30] what is your use case? [18:39:31] bawolff: I'm wondering if more details about the requests are logged somewhere other than squid logs [18:39:32] btw [18:39:59] aude: we are working on the Flow extension, Flow is its own independant db separate from the actual wikis [18:40:11] hmmmmm [18:40:12] ok [18:40:21] average: Are we talking about your use case, or Wikimedia's use case? [18:40:23] aude: within flow, rather than pages being first class objects we have the concept of a "Workflow", which at least initially updates to need to end up in RC/watchlists [18:40:24] that sounds weird... ok [18:40:46] hoo: its primarily done to allow cross-wiki interaction without insanity :) [18:40:48] bawolff: Wikimedia yes, I'm from the analytics team, so that's why I'm asking [18:40:48] maybe change tags is the right way [18:40:56] although it might need changes to scale [18:41:03] * aude open to other ideas [18:41:12] average: my apologies, I thought you were someone asking from a third party wiki [18:41:28] (03CR) 10Kaldari: [C: 04-1] "Personal toolbar font is too small. Footer font is too small." [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [18:41:40] In which case I was going to say something like you can set up your logging however you want [18:41:55] but for wikimedia, there's all sorts of constraints [18:42:10] aude: i dunno either, this wont be our final solution eventually flow will have its own subscriptions and handling for this, butfor the initial use case with flow only deployed to a few select wiki projects within the wiki we cant expect users to check a flow specific subscription board [18:42:24] slow gerrit is slow [18:42:38] ebernhardson: ok [18:42:55] * aude looks to see how big change tags table is [18:43:01] aude: rc_external_type would be the most sensible option [18:43:01] aude: How are change tags handled? Is that a varbinary field somehwere? [18:43:09] hoo: I wrote that code :p [18:43:28] (03PS1) 10Anomie: Clean up parser test's InterwikiLoadPrefix hook [core] - 10https://gerrit.wikimedia.org/r/80420 [18:43:29] change tags are a map from recentchanges to valid_tag [18:43:29] werdna: Thought about that as well... with an index together with rc_type [18:43:37] hoo: nod. [18:44:00] werdna: wait, why would RC_EXTERNAL be wikidata specific? [18:44:19] that would be sad, especially for a constant with such a name [18:44:29] AaronSchulz: not really intended to be specific [18:44:31] AaronSchulz: Wikibase assumes it's the only thing using rc_external atm [18:44:53] it's used to filter edits but could be called "external filter" [18:44:57] (03PS1) 10Aaron Schulz: Avoid profiler spam for numeric IN() clauses for each possible number of items [core] - 10https://gerrit.wikimedia.org/r/80421 [18:45:31] we also apply formatting to rc external, but then check rc params if it' sa wikidata change [18:48:14] aude: The watchlist code and such actually don't do that distinction... [18:48:16] AaronSchulz: what do you think of us using change tags to add rc external type [18:48:17] (03CR) 10Anomie: "This broke Scribunto's tests that use the same hook. I351a56ac39a44721d427e9c980eaf5fff246fb57" [core] - 10https://gerrit.wikimedia.org/r/64574 (owner: 10Hashar) [18:48:24] hoo: right, it's an external change filter [18:48:49] I don't like using change tags, it strikes me as abuse [18:49:15] werdna: then another column in recentchanges? [18:49:21] that would seem better [18:49:27] Yep, change tags aren't really designed for this... that will also require us to add another join... [18:49:42] yeah, I would add a column [18:49:45] i suppose the recentchanges tables are not so gigantic for such a change [18:49:46] ok [18:49:46] (03PS1) 10Jeroen De Dauw: Add files with no coverage at all to the coverage report as well [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/80424 [18:49:51] everybody loves schema changes on enormous tables [18:49:54] :) [18:50:11] schema changes are awesome yes [18:50:23] i remember them fondly [18:50:25] NEVER AGAIN [18:50:38] brion: you don't remember OSC [18:50:54] OSC? [18:51:23] (03PS1) 10Jeroen De Dauw: Add files with no coverage at all to the coverage report as well [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80428 [18:51:25] online schema changer [18:51:53] (03PS1) 10Jeroen De Dauw: Add files with no coverage at all to the coverage report as well [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80429 [18:52:11] https://bugzilla.wikimedia.org/53230 [18:52:14] (03PS2) 10Jeroen De Dauw: Add files with no coverage at all to the coverage report as well [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80428 [18:53:25] (03PS2) 10Jeroen De Dauw: Add files with no coverage at all to the coverage report as well [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/80424 [18:53:40] AaronSchulz, aude, hoo: So what *do* we think about adding an rc_external_type? [18:53:47] is that something we want to do? [18:53:54] Yep [18:54:01] seems fine to me [18:54:11] it's needed [18:54:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=53230 [18:54:32] (03CR) 10Jeroen De Dauw: [C: 032] Add files with no coverage at all to the coverage report as well [extensions/Validator] - 10https://gerrit.wikimedia.org/r/80429 (owner: 10Jeroen De Dauw) [18:54:37] (03CR) 10Jeroen De Dauw: [C: 032] Add files with no coverage at all to the coverage report as well [extensions/Maps] - 10https://gerrit.wikimedia.org/r/80428 (owner: 10Jeroen De Dauw) [18:55:20] (03PS1) 10Jeroen De Dauw: Add files with no coverage at all to the coverage report as well [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80430 [19:12:27] (03PS2) 10Mollywhite: Bug 52310: Disallow empty JSON blocks [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80326 [19:12:42] (03CR) 10Brian Wolff: "A major reason for this change, is in addition to the cache purging issues, commons folks have been complaining about how when they move a" [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff) [19:13:23] (03CR) 10Mattflaschen: "Especially given that the global Vector font commit is now moving along (https://gerrit.wikimedia.org/r/#/c/79948/), I don't think this sh" [core] - 10https://gerrit.wikimedia.org/r/78408 (owner: 10Matmarex) [19:37:20] Reedy: Hmm. When did you cut wmf14? https://gerrit.wikimedia.org/r/#/c/80080/ was merged at 02:50 UTC but doesn't show in your changelog… [19:37:47] Is it already deployed to wmf12/13? [19:38:06] Reedy: No, we deployed to wmf13 about 6 hours before it was merged. [19:38:29] Reedy: https://gerrit.wikimedia.org/r/#/c/80315/ is the top of wmf13. [19:38:38] Reedy: … of VEwmf13, for clarity. :-) [19:39:53] James_F: be careful with that! ;) [19:39:56] (03PS1) 10TheDJ: ToC: Use display:table, so that we can behave like a block element [core] - 10https://gerrit.wikimedia.org/r/80435 [19:40:00] greg-g: Yessir! ;-) [19:40:05] https://git.wikimedia.org/log/mediawiki%2Fcore.git/refs%2Fheads%2Fwmf%2F1.22wmf14 [19:40:14] Thursday, August 22, 2013 14:02 +0000 [19:40:24] "you want to do WHAT?! OK, for VE, but dang man..... ohhhhh! you meant something else" [20:10:08] (03CR) 10coren: [C: 032] "LGM" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/77854 (owner: 10Ryan Lane) [20:10:23] Reedy: So… it should have made it, but doesn't appear in your script's list of changes? [20:10:47] Reedy: "extensions/VisualEditor @ 97c03da" -> 97c03da Merge "Don't emit Surface changes back to the Surface" [20:11:07] hexmode: do you have a nick for duplicatebug? [20:11:50] jeremyb: don't think so, let me make sure [20:12:03] (03PS1) 10Rachel99: Headings test scenarios completed [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80483 [20:12:30] hexmode: the guy that filed https://bugzilla.wikimedia.org/53153 is asking in #-tech [20:12:38] (i haven't actually read the bug myself) [20:12:52] James_F: I honestly have no idea. The script does a new clean clone from master [20:12:55] he's not here and you're not there [20:13:30] <^demon|lunch> jeremyb: I don't think we know who duplicatebug is. [20:14:09] Reedy: Is it doing something silly like missing the top-most commit with HEAD^1 or something? [20:14:26] Reedy: Asking 'cos I've accidentally done that a few times. :-) [20:14:50] $this->runCmd( 'git', 'clone', '-q', "{$this->baseRepoPath}/extensions/{$ext}.git", $ext ); [20:15:51] (03CR) 10coren: [C: 032] "Federal regulations require me to warn you that this next changeset... is looking pretty good." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/73790 (owner: 10Ryan Lane) [20:16:08] (03Merged) 10jenkins-bot: Clean up service group interface [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/77854 (owner: 10Ryan Lane) [20:16:09] (03Merged) 10jenkins-bot: Add API for Service Group info and refactor project api [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/73790 (owner: 10Ryan Lane) [20:16:42] Reedy: Hmm. [20:18:17] Project browsertests-en.wikipedia.org-linux-chrome build #267: FAILURE in 3 min 54 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/267/ [20:18:53] (03CR) 10Rachel99: "All scenarios are working now, so this test can be merged." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80483 (owner: 10Rachel99) [20:19:48] (03Abandoned) 10Anomie: Add support for private sessions in extensions [core] - 10https://gerrit.wikimedia.org/r/78146 (owner: 10Anomie) [20:20:39] (03CR) 10TheDJ: "Testing:" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/79639 (owner: 10Hoo man) [20:22:38] (03CR) 10Mwjames: [C: 032] Add files with no coverage at all to the coverage report as well [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80430 (owner: 10Jeroen De Dauw) [20:24:23] (03Merged) 10jenkins-bot: Add files with no coverage at all to the coverage report as well [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80430 (owner: 10Jeroen De Dauw) [20:24:31] (03PS1) 10Cmcmahon: make steps not DRY to get around dumb ChromeDriver bug [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80486 [20:25:18] grrrit-wm: you've been added to my ignore list... noisy bot... :p [20:27:51] Boo... [20:28:02] jeremyb: no bot! [20:28:11] oh, where was i looking? [20:28:20] No idea... [20:31:11] greg-g: you were asking about the wmf-selenium-bot, ^^ [20:31:36] * chrismcmahon wonders what failed just now [20:32:42] yeah, saw it last night with "YIPPEE build fixed!" [20:32:56] let's make it have color ;) [20:33:15] just like greg-g [20:33:19] i mean, grrrit-wm :P [20:33:26] both [20:33:50] greg-g: is quite colorful... [20:37:37] Yippie, build fixed! [20:37:38] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #226: FIXED in 6 min 45 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/226/ [20:38:54] greg-g: build fixed ^^ [20:42:25] ori-l: can you +2? https://gerrit.wikimedia.org/r/#/c/78214/ just a rebase of one you already +2'd and I don't want to +2/merge my own :) [20:44:13] greg-g: Can VE have an LD this afternoon? We broke adding section edit links with wmf13, and only noticed today. Cherry-pick, VE-only, single commit. [20:44:51] James_F: word [20:45:03] greg-g: Thanks. [20:49:25] (03CR) 10BryanDavis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80421 (owner: 10Aaron Schulz) [20:50:15] (03CR) 10Matmarex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80409 (owner: 10IAlex) [20:50:54] (03PS3) 10Reedy: Update populateHomeDB script to only update when home is null [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80381 [20:52:06] (03PS2) 10Krinkle: Add David Chan to test pipeline auth [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80413 [20:52:22] (03CR) 10Krinkle: [C: 032] Add David Chan to test pipeline auth [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80413 (owner: 10Krinkle) [20:52:31] (03Merged) 10jenkins-bot: Add David Chan to test pipeline auth [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80413 (owner: 10Krinkle) [20:53:07] (03CR) 10Matmarex: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [20:55:16] ori-l: Can you please address the log bot issues with it treating every number as a change id? e.g. "bug 1234" becomes bug 1234 [20:55:25] https://wikitech.wikimedia.org/wiki/Server_admin_log/Archive_22#July_27 [20:55:38] also " Wed Jul 31 02:46:48 UTC 2013" [20:56:20] I suppose a 7-char minimum is reasonable (we do the same in the parser for bugzilla and gerrit comments) [20:56:54] that won't take care of bug 1234567, but we can fight that by putting the matcher for "bug \d+" higher [20:57:17] sorry if I'm asking the wrong person, not sure who changed it to cause this bug (it's been a few weeks). I thoguht it was you [20:59:37] (03PS1) 10Amire80: Force left-to-right on CAPTCHA [core] - 10https://gerrit.wikimedia.org/r/80492 [21:03:36] Krinkle: no, it's me. ill fix it [21:04:58] ori-l: btw, +1 on doing it in post instead of pre (e.g. {{SAL-line|text= ... }}, the bot would have to escape any non-matching | or }} to be safe though. It has the upside of being able to fix bugs like these. [21:05:45] The only downside is that, if and when we decide to change something that might introduce a new shortcut (that people in the past would not yet know about) it can cause strange results. That could be remidied with a version argument, though I'm not sure we need that. [21:08:05] (03PS3) 10Bsitu: Long text content should wrap in overlay footer links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80165 [21:11:39] (03CR) 10Yuvipanda: [C: 031] "hmm, alright. Add a comment on top of the commented out parts with an explanation, and I'll merge it? :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/78641 (owner: 10DMaggot) [21:11:40] (03PS6) 10Jdlrobson: Apply mobile typography lessons to Vector [core] - 10https://gerrit.wikimedia.org/r/79948 [21:14:34] (03CR) 10Adamw: [C: 032 V: 032] Throw MWException instead of Exception [extensions/timeline] - 10https://gerrit.wikimedia.org/r/78955 (owner: 10Matmarex) [21:17:06] Project browsertests-test2.wikipedia.org-linux-firefox build #510: FAILURE in 27 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/510/ [21:17:40] (03PS3) 10Mwjames: Register #ask/#show as closure, eliminate static render method and $GLOBALS [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80365 [21:19:10] (03CR) 10jenkins-bot: [V: 04-1] Register #ask/#show as closure, eliminate static render method and $GLOBALS [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80365 (owner: 10Mwjames) [21:22:22] (03CR) 10Mwjames: "This is good." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80365 (owner: 10Mwjames) [21:24:29] (03CR) 10MaxSem: "This results in an ugly being displayed on Special:Version." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80365 (owner: 10Mwjames) [21:31:13] (03CR) 10Mwjames: ">> This results in an ugly being displayed on Special:Version" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80365 (owner: 10Mwjames) [21:38:50] (03PS68) 10Wikinaut: (bug 44819) introducing array of $wgOpenIDProviders and $wgOpenIDForcedProvider [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 [21:44:32] (03PS1) 10Aaron Schulz: Further fix to profiling order for DBPerformance log [core] - 10https://gerrit.wikimedia.org/r/80495 [21:47:34] AaronSchulz: Did https://bugzilla.wikimedia.org/show_bug.cgi?id=48819 get resolved with the patch's merge? [21:47:46] (bawolff is marking it so now but you can reopen if no) [21:48:48] I *think* so [21:49:11] (03PS1) 10Brian Wolff: Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/80496 [21:53:15] (03PS1) 10Bsitu: Add replication delay handling if echo job queue is not enabled [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80497 [21:57:43] (03PS1) 10Aaron Schulz: The "masterPos" field in refreshLinks can be false so check for that [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80498 [21:58:15] (03PS1) 10Aaron Schulz: The "masterPos" field in refreshLinks can be false so check for that [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80499 [21:58:38] cherry-pick-to = OMG [21:59:27] (03Abandoned) 10Aaron Schulz: The "masterPos" field in refreshLinks can be false so check for that [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80499 (owner: 10Aaron Schulz) [21:59:51] (03CR) 10Aaron Schulz: [C: 032] The "masterPos" field in refreshLinks can be false so check for that [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80498 (owner: 10Aaron Schulz) [22:00:08] AaronSchulz: Are you dumping commits on all the branches? :) [22:00:42] it means I don't have to keep fetching/checking out my local wmf branches [22:11:04] GorillaWarfare: ping [22:11:28] (03Merged) 10jenkins-bot: The "masterPos" field in refreshLinks can be false so check for that [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80498 (owner: 10Aaron Schulz) [22:11:37] mwalker: Hi [22:12:19] regarding your empty json schema patch -- it works; but I'm wondering if what you really want to be doing is checking for 'mandatory' bits of metadata [22:12:35] e.g. is a book balid without a title? [22:12:51] It forces you to add a title too [22:12:59] The issue is that if there's _nothing_ to validate, it won't enforce that [22:13:02] Hence the new patch [22:13:46] kk [22:13:57] (03CR) 10Mwalker: [C: 032] Bug 52310: Disallow empty JSON blocks [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80326 (owner: 10Mollywhite) [22:14:06] in other news -- how's things? [22:14:12] Going well [22:14:28] Working on https://bugzilla.wikimedia.org/show_bug.cgi?id=53105 [22:14:31] (03Merged) 10jenkins-bot: Bug 52310: Disallow empty JSON blocks [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80326 (owner: 10Mollywhite) [22:15:18] yay [22:15:19] awesome [22:15:32] (03PS2) 10Bsitu: Add replication delay handling to page-link formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80497 [22:15:55] after that one; what else needs to be done before we can try using it for real? [22:16:18] aka; I'm wondering what else needs to happen before we push it to the cluster [22:16:56] (03PS1) 10Mattflaschen: Enable the Vector extension by default [vagrant] - 10https://gerrit.wikimedia.org/r/80500 [22:16:57] (03CR) 10jenkins-bot: [V: 04-1] Enable the Vector extension by default [vagrant] - 10https://gerrit.wikimedia.org/r/80500 (owner: 10Mattflaschen) [22:19:31] that's more of a question of when should I start trying to get part of chris steipp's time to do a security review of it [22:20:06] (03PS1) 10Jdlrobson: Enable Campaigns on mobile [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/80501 [22:20:14] (03PS1) 10Mwjames: \SMW\Subobject, SubobjectParserFunction use HashIdGenerator [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80502 [22:21:16] (03PS2) 10Mattflaschen: Enable the Vector extension by default [vagrant] - 10https://gerrit.wikimedia.org/r/80500 [22:22:06] (03PS3) 10Bsitu: Add replication delay handling to page-link formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80497 [22:25:17] mwalker: The bolded bugs on that page should be solved before a security review [22:26:52] GorillaWarfare: erm; what page? the coordination wiki page you and Raylton have going? [22:27:01] (which I have also apparently lost the link to) [22:27:15] (03CR) 10Tim Starling: [C: 032] Fix possible fatal error [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/80376 (owner: 10Anomie) [22:27:32] Oh, sorry, forgot I hadn't just linked you to it. https://meta.wikimedia.org/wiki/Book_management/Bug_priority [22:28:25] (03Merged) 10jenkins-bot: Fix possible fatal error [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/80376 (owner: 10Anomie) [22:29:57] (03CR) 10Mattflaschen: [C: 04-1] "This makes the "Join project" button (and the accompanying "Don't have an account?" label) also Georgia." [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [22:30:32] GorillaWarfare: awesome; I probably should bookmark this [22:30:35] and that's a lot of bolded bugs [22:30:50] how much time do you have left with us? [22:31:56] (03PS1) 10Brian Wolff: Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/80504 [22:32:09] Technically GSoC ends September 27 [22:33:29] ohhh that's why you're writing so much code [22:33:35] I feel less bad about being less productive than you now [22:34:00] GorillaWarfare: Don't you know, you're supposed to give a canned answer about how you'll contribute forever and ever even after gsoc ;) [22:34:10] werdna: Hee [22:34:47] bawolff: Well, to be fair, I probably will :P But not at my current rate [22:34:59] understandable [22:35:36] werdna: get off irc and be productive :P [22:35:51] I'm being productive in the top 2/3 of this scren [22:35:54] :) [22:39:16] dammit, I have to figure out this post-loading thing now [22:42:29] (03CR) 10MarkAHershberger: [C: 032] Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/80504 (owner: 10Brian Wolff) [22:43:08] (03PS2) 10Brian Wolff: Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/80496 [22:43:38] (03PS1) 10MarkAHershberger: Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/80508 [22:45:27] (03PS2) 10Brian Wolff: Follow-up 42333412833a - Fix behaviour $wgVerifyMimeType = false; [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/80504 [22:48:19] (03CR) 10Tim Starling: "Looks good. Any chance of a test case?" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/63565 (owner: 10Anomie) [22:48:46] (03CR) 10Mattflaschen: "I forgot to mention; that's because #mw-userloginlink is an h3." [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [22:59:43] (03PS1) 10Jforrester: Update VisualEditor with cherry-pick for wmf13 branch [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80510 [23:01:03] (03PS1) 10Jforrester: Update VisualEditor with cherry-pick for wmf14 branch [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80511 [23:01:53] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor with cherry-pick for wmf13 branch [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80510 (owner: 10Jforrester) [23:01:57] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor with cherry-pick for wmf14 branch [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80511 (owner: 10Jforrester) [23:16:09] (03PS1) 10Werdna: Flow: Implement initial notifications for edit/rename/reply/newtopic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80514 [23:16:20] (03PS1) 10Brian Wolff: Backport purge upstream caches when deleting file assets. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/80515 [23:17:06] (03PS2) 10Mattflaschen: Improve wording of toolbar. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/72868 [23:17:47] (03CR) 10Jdlrobson: "#mw-userloginlink shouldn't be an h3..? It seems weird that it is... it's not a heading for anything. It's a label." [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:18:48] marktraceur: if I wanted to make the CentralNotice JSLint test voting; where would I do that? [23:19:04] mwalker: In the zuul-config repository [23:19:27] integration/zuul-config.git should be it, IIRC [23:19:33] (03CR) 10Mattflaschen: "I know we're doing the A/B test soon." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/72868 (owner: 10Mattflaschen) [23:19:36] wtf, my enter key stopped working [23:19:40] (03CR) 10Mattflaschen: "(3 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/72868 (owner: 10Mattflaschen) [23:20:55] bawolff: that's sad [23:21:05] bawolff: Hah, so you have to click a "send" button? [23:21:17] just firefox. closing and reopening seemed to fix it [23:22:47] bawolff: Are you using webchat? [23:22:53] * marktraceur looks judgingly [23:22:56] No, I'm using chatzilla [23:22:59] Ahhh. [23:23:07] Slightly better. :) [23:23:07] It was enter in my web browser, not in irc [23:23:08] *zilla == evil [23:23:36] mwalker: The alternative being... [23:23:47] bitchx? [23:24:11] Does it do FTP? [23:24:22] OR web browsing? [23:24:26] mwalker: I use Iceweasel if that makes you feel better [23:24:58] bawolff: nah; firefox is actually pretty good -- I was mostly reflecting on my experience with almost any software product named *zilla [23:25:06] they like to be bloated and full of UX problems [23:25:18] (03CR) 10Brian Wolff: [C: 032] "self merging the backport. This is already backported to 1.19 and 1.21" [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/80515 (owner: 10Brian Wolff) [23:25:24] I've never used chatzilla though so I cant really judge it [23:25:34] And yet you were [23:25:38] Shaaaame [23:25:44] yep; I stereotype [23:25:56] software [23:25:58] on names [23:26:00] mwalker: I tried seamonkey, and I'd agree with your assesment [23:26:09] I'm using the chatzilla add on [23:26:14] to firefox [23:26:58] ChatZilla has its issues but it has nice things that make me not want to leave it [23:27:49] ChatZilla was the first one I tried (other than cgi::irc. shudder), its good enough I haven't tried anything else [23:27:58] (03Merged) 10jenkins-bot: Backport purge upstream caches when deleting file assets. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/80515 (owner: 10Brian Wolff) [23:31:20] (03CR) 10Mattflaschen: "Yeah, it may have been deliberate if whoever did that thought it was part of the hierarchy of the page." [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:32:59] (03CR) 10Swalling: [C: 031] "I think this is overall better than what's currently live in prod. It shouldn't have a negative impact on our ability to trust the next A" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/72868 (owner: 10Mattflaschen) [23:33:26] superm401: ^ [23:33:56] When that's merged I can test it on piramido along with OB6 changes. [23:34:04] StevenW, thanks. [23:37:15] (03Abandoned) 10Ryan Lane: mediawiki.htmlform: Set minimum size for field width [core] - 10https://gerrit.wikimedia.org/r/62100 (owner: 10Ryan Lane) [23:40:08] (03PS1) 10Ryan Lane: jquery.chosen: set default text width to auto [core] - 10https://gerrit.wikimedia.org/r/80517 [23:40:47] (03CR) 10Ryan Lane: "Also added upstream, but I'd prefer not to wait for them:" [core] - 10https://gerrit.wikimedia.org/r/80517 (owner: 10Ryan Lane) [23:41:51] (03CR) 10Swalling: [C: 04-1] "In the version I'm seeing on Labs (toro.wmflabs.org), section edit links are picking up the Georgia, serif style." [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:45:31] (03PS1) 10Mwalker: CentralNotice now passes JSLint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/80518 [23:46:55] (03PS7) 10Swalling: Apply mobile typography lessons to Vector [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:49:19] (03PS1) 10Jdlrobson: Update Collapsible Nav styling for Vector style refresh [extensions/Vector] - 10https://gerrit.wikimedia.org/r/80519 [23:49:21] (03PS8) 10Jdlrobson: Apply mobile typography lessons to Vector [core] - 10https://gerrit.wikimedia.org/r/79948 [23:49:28] (03PS1) 10Reedy: Fatal error: Call to a member function formatDuration() on a non-object in SpecialUserlogin.php on line 818 [core] - 10https://gerrit.wikimedia.org/r/80520 [23:49:46] (03PS1) 10Reedy: Fatal error: Call to a member function formatDuration() on a non-object in SpecialUserlogin.php on line 818 [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80521 [23:52:30] (03PS9) 10Swalling: Apply mobile typography lessons to Vector [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [23:54:29] marktraceur: if you have deploy rights on gallium I will give you a cookie if you deploy https://gerrit.wikimedia.org/r/80518 [23:54:39] A COOKIE!? [23:54:57] yep; they're slightly stale; but I can bring one in tomorrow [23:55:03] or you can trade up for the next time I make some [23:55:06] Hm [23:55:14] If it's not an immediate cookie I'm not so sure [23:55:29] I can give you an immediate reeses pieces? [23:55:39] One Reeses Piece? [23:55:41] hand delivered from the kitchen [23:55:45] That seems hardly fair [23:55:57] Plus I still have a bunch in my bag [23:56:11] why do you have them in your bag? [23:56:11] Actually I should probably dump candy in the kitchen [23:56:20] I was going to give YuviPanda a bunch of candy [23:56:23] reverse candy flow! [23:56:28] But he nibbled at the M&Ms and left them with me [23:56:52] note to self; YuviPanda is not a competitor for the limited candy supplies [23:57:03] Pretty much not [23:57:15] Anyway, I'm sure we can work something out [23:57:17] I'll review [23:57:19] I'll give you a cookie [23:57:24] http://tstarling.com/cookie.php [23:57:27] it's chocolate chip [23:58:32] Woo [23:58:53] TimStarling: It was delicious [23:59:02] I made it myself [23:59:06] I've wondered this before; but now I'm going to have to look up the etymology of cookies as bits of information to be gobbled by web servers [23:59:21] * marktraceur creates FF addon called Cookie Monster that makes eating noises whenever Set-Cookie: Chocolate chip [23:59:27] it was in X before it was in the web