[00:02:33] (03PS23) 10Alex Monk: Provide a JSON recent changes feed. [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [00:07:52] (03PS9) 10Mwjames: [DIC]: Support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 [00:08:21] (03PS10) 10Mwjames: [DIC]: Support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 [00:16:03] (03CR) 10jenkins-bot: [V: 04-1] More jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80945 (owner: 10MarkTraceur) [00:18:43] (03PS2) 10MarkTraceur: Add a .jshintrc file [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80524 [00:18:44] (03PS5) 10MarkTraceur: Loads of work on jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 [00:18:45] (03PS3) 10MarkTraceur: Put closures everywhere [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80122 [00:18:46] (03PS2) 10MarkTraceur: More jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80945 [00:23:26] Down to 370 jslint errors in UploadWizard! [00:23:29] Exciting times [00:32:54] heh, indeed marktraceur, indeed [00:33:04] marktraceur: are you doing this as one big change? [00:33:08] or multiple smaller ones? [00:33:10] No, there are at least four now [00:33:22] I put about 15 files in the second one [00:33:26] But the last one was only three [00:33:33] They were just huge [00:33:49] heh [00:34:06] marktraceur: next step is to clean up the architectural mess? [00:34:27] * YuviPanda is also working on an UW patch, but serverside stuff. Shouldn't conflict [00:34:51] Heh, yeah [00:35:01] YuviPanda: I have a tracking bug about "UW's code is total shit" [00:35:31] should be more aptly named 'UW's code looks like my code from 5 years ago'? :) [00:35:57] YuviPanda: Probably, but I don't see how that's relevant :) [00:36:05] heh [00:36:30] Mediawiki's API module system sortof sucks, btw. supremely unintuitive and unnecessarily stateful [00:36:33] * YuviPanda mumbles [00:37:07] Yup [00:42:16] (03PS7) 10Yuvipanda: Add API to query campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 [00:42:23] MaxSem: still on?! [00:42:38] MaxSem: if so, I've implemented continue to ^ :) do take a look when you can [00:47:46] :) [00:48:19] (03PS1) 10Yuvipanda: Fix phpcs errors [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80946 [00:49:46] (03PS2) 10Yuvipanda: Fix phpcs errors [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80946 [00:52:22] (03PS3) 10Yuvipanda: Fix phpcs errors [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80946 [00:55:52] marktraceur: I'm trying to make phpcs pass :) [00:55:57] (03PS4) 10Yuvipanda: Fix phpcs errors & warnings [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80946 [00:57:32] Great plan [00:57:38] Does it even *run* for us? [00:59:10] (03PS5) 10Yuvipanda: Fix phpcs errors & warnings [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80946 [00:59:41] marktraceur: succeded! [00:59:51] marktraceur: phpcs Success! [00:59:56] marktraceur: https://integration.wikimedia.org/ci/job/mwext-UploadWizard-phpcs-HEAD/358/console : SUCCESS in 1s (non-voting) [01:00:04] we can make that voting at some point [01:00:25] marktraceur: although, the PHP wasn't as bad as the JS [01:00:40] Cool [01:00:42] Yeahhhh [01:00:48] There's way more JS in UW than PHP [01:00:51] marktraceur: also perhaps because there is more JS than PHP [01:00:52] heh [01:00:53] yeah [01:01:09] also because phpcs sortof sucks, in that it does check only for the most trivial things now [01:03:12] Ah, good [01:03:20] Makes for an easier fix :P [01:04:09] marktraceur: heh, yeah. do merge when you can. also let me know when you want me to look at your jshint fixes [01:09:47] Sure [01:09:54] YuviPanda: They're all there now, you can look now [01:10:05] I think I have to respond to a few comments from Krinkle [01:12:14] marktraceur: is the .jshintrc the same as mediawiki/core's? [01:12:21] looks like that [01:12:35] Yeah [01:12:37] I cp'd it [01:12:58] (03CR) 10Yuvipanda: [C: 032] "Same as core." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80524 (owner: 10MarkTraceur) [01:13:02] (03Merged) 10jenkins-bot: Add a .jshintrc file [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80524 (owner: 10MarkTraceur) [01:14:01] (03CR) 10Yuvipanda: "Title should perhaps be 'enclose all code in per-file closures' or something?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80122 (owner: 10MarkTraceur) [01:15:21] Woot [01:15:51] (03PS4) 10MarkTraceur: Put closures everywhere [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80122 [01:16:07] {{done}} [01:16:14] YuviPanda: You still do commit updates wrong [01:17:23] marktraceur: can't help it, gerrit bug [01:17:23] next one should be right [01:17:33] marktraceur: the entire '_this' business makes my skin crawl [01:17:41] Yeah [01:17:51] That's one huge problem I'm fixing everywhere [01:18:17] hmm, UploadWizardDeed has mw introduced into it now [01:18:24] has it not been used before? [01:18:26] * YuviPanda checks [01:18:40] It's used, but it wasn't a local reference [01:18:46] lol, ok [01:20:50] (03PS1) 10MarkTraceur: Further jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80947 [01:20:55] YuviPanda, does phpcs succeed on all PHP files now? [01:21:13] (03CR) 10Yuvipanda: [C: 04-1] "Ordering of mw and jquery should be consistent" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80122 (owner: 10MarkTraceur) [01:21:19] 268 more [01:21:31] Oh, huh, I thought I did order it consistently [01:21:34] (03CR) 10Yuvipanda: "(3 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80122 (owner: 10MarkTraceur) [01:21:37] Easy fix [01:21:48] marktraceur: also, 'undefined'. why only at those two places? :P [01:21:58] Krenair: well, jenkins-bot says 'Success' :) [01:21:58] YuviPanda: I didn't put it there, but I didn't mess with it [01:22:05] marktraceur: let's get rid of it? [01:22:10] May as well [01:22:16] Krenair: so I am guessing it did for all files? [01:22:28] YuviPanda, no, only the ones you modified in that commit [01:22:38] according to https://integration.wikimedia.org/ci/job/mwext-UploadWizard-phpcs-HEAD/358/console [01:22:47] "phpcs -v -s UploadWizard.php UploadWizardHooks.php -[...]" [01:23:02] bleh [01:24:45] Krenair: thanks for catching that! fixing now [01:27:54] Krenair: hmm, do you know where I can get the config file for that? [01:29:14] (03PS5) 10MarkTraceur: Enclose every JS file in per-file closures [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80122 [01:29:16] (03CR) 10Jeroen De Dauw: [C: 032] "Oh, someone is running CodeSniffer. How wonderful. Now we still need to get it onto Jenkins :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80946 (owner: 10Yuvipanda) [01:29:24] (03Merged) 10jenkins-bot: Fix phpcs errors & warnings [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80946 (owner: 10Yuvipanda) [01:29:34] Heh [01:29:37] Krenair: heh, he merged it before I could fix the rest of them :P [01:29:51] YuviPanda, https://github.com/wikimedia/integration-zuul-config/blob/master/layout.yaml [01:29:52] JeroenDeDauw: Thanks! :) [01:29:56] JeroenDeDauw: it is running in Jenkins, but only for changed files. Lots more errors, but :) [01:30:07] Krenair: config file for phpcs, I mean :) [01:30:37] JeroenDeDauw: and yes, thanks :) I am trying to make all the things pass on phpcs [01:30:53] JeroenDeDauw: siebrand did similar things for a bunch of extensions a while ago, IIRC [01:32:09] YuviPanda, oh you want Jenkins' /var/lib/jenkins/tools/mwcodesniffer/MediaWiki ? [01:32:26] Oh hey, mooeypoo's on from the office IP! [01:32:26] Krenair: yes [01:32:30] Welcome to SF, mooeypoo! [01:32:40] yeah, now shoot him! :P [01:32:46] Her? [01:32:54] marktraceur: I was talking to her :P [01:32:57] Oh [01:33:01] ...I'm at home [01:33:10] logistical issues. [01:33:27] Probably not that hard actually [01:33:33] she's on her way [01:33:34] Considering that James_F knows where I live [01:33:42] Maybe I should like [01:33:42] YuviPanda, I'm guessing that's https://git.wikimedia.org/tree/mediawiki%2Ftools%2Fcodesniffer.git/HEAD/MediaWiki ? [01:33:44] Lock my doors [01:33:57] marktraceur: YuviPanda: I'd love to have some real code analysis run for the Wikidata stuff (and SMW) as well [01:34:01] * James_F grins. [01:34:15] I can neither confirm nor deny that mooeypoo is on her way to badger marktraceur. :-) [01:34:16] Would be awesome if Jenkins does -1 if someone adds a way to complex method [01:34:17] JeroenDeDauw: you can get those on jenkins... when hashar's back, I guess? :) [01:34:28] JeroenDeDauw: it can be set to voting, so then it will -1 [01:34:32] Or now, when Mark is back [01:34:46] which is https://github.com/wikimedia/mediawiki-tools-codesniffer/tree/master/MediaWiki [01:34:49] JeroenDeDauw: of course, someone needs to figure out what analysis exactly to run :) [01:34:53] Krenair: thanks! [01:35:01] JeroenDeDauw: If you can write the patch for Jenkins Job Builder, I can merge it and deploy [01:35:10] JeroenDeDauw: https://www.mediawiki.org/wiki/Continuous_integration/Jenkins_job_builder [01:35:36] If you need some tools on Gallium for this to work I may need to discuss it with Krinkle or hashar [01:35:59] Intersting [01:36:18] I'm first going to investigate this tool and alternatives a bit more before submitting any patch :) [01:36:28] Also probably first going to try it out on TravisCI [01:36:37] Or on a non critical project [01:37:17] JeroenDeDauw: btw, not sure if you peeked - but I think the older UploadCampaign code was all yours? I mostly rewrote it to use ContentHandler, do take a look when you can [01:39:29] --report-checkstyle=checkstyle-phpcs.xml [01:39:33] Where is that xml file located? [01:39:42] Or whatever thing that defines the rules currently run for UW? [01:40:06] YuviPanda: yes, that horrible code was written by me. I trust it is more sane now, even with the design issues CH has ;p [01:40:07] Dunno [01:40:28] It might be in the workspace somewhere [01:42:15] (03CR) 10Yuvipanda: [C: 04-1] "(4 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80122 (owner: 10MarkTraceur) [01:43:05] JeroenDeDauw: i think the rules are defined in https://github.com/wikimedia/mediawiki-tools-codesniffer [01:46:11] marktraceur: you missed a few :) [01:46:23] marktraceur: this is an annoying part about our CR process, is that if I touch even for those minor fixes, it becomes 'poisoned' and I can't merge it. [01:46:34] marktraceur: which is fine, since the idea is to catch issues. still annoying [01:48:23] (03PS6) 10MarkTraceur: Enclose every JS file in per-file closures [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80122 [01:48:24] Indeed [01:50:52] (03CR) 10Mwjames: [C: 032] "Most time spent here was on writing tests, I merge this know otherwise I write even more tests even though it has already a cc of 100%." [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 (owner: 10Mwjames) [01:51:35] (03CR) 10Yuvipanda: [C: 032] "LGTM, assuming no syntax error fails :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80122 (owner: 10MarkTraceur) [01:51:36] marktraceur: merged! [01:51:39] (03Merged) 10jenkins-bot: Enclose every JS file in per-file closures [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80122 (owner: 10MarkTraceur) [01:51:41] marktraceur: now I shall sleep. [01:52:01] Woot [01:52:04] Thanks so much YuviPanda [01:52:17] (03Merged) 10jenkins-bot: [DIC]: Support SCOPE_SINGLETON [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/80139 (owner: 10Mwjames) [01:52:42] marktraceur: btw, the next patchset in that series needs manual rebase [01:52:48] I believe it [01:53:49] (03CR) 10Yuvipanda: [C: 04-1] "(2 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 (owner: 10MarkTraceur) [01:54:03] (03CR) 10Yuvipanda: "(looked only at the first file)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 (owner: 10MarkTraceur) [01:54:34] Heh [01:54:42] YuviPanda: Krinkle already made those comments [01:54:51] marktraceur: there were new patchsets :P [01:55:09] I also think I really should go to sleep :P [01:55:25] marktraceur: but I'm peeling a not-really-an-orange [01:55:30] so need to finish that :P [01:59:33] (03PS6) 10MarkTraceur: Loads of work on jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 [01:59:39] * marktraceur rebased [02:02:30] (03PS7) 10MarkTraceur: Loads of work on jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 [02:02:57] (03CR) 10MarkTraceur: "(3 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 (owner: 10MarkTraceur) [10:15:55] Nikerabbit: will do [10:17:02] Nikerabbit, aharoni: should I also tag the uls_ime.feature file to run only at dev.translatewiki.net? [10:17:19] Nikerabbit, zeljkof: what's the problem? that the code is not merged yet? It should be merged Real Soon Now. [10:21:04] where should the code be merged? to wmflabs and sandbox.transatewiki? [10:24:26] zeljkof: the code that makes those tests pass is now merged to master branch of ULS [10:24:57] but that code is only on dev.translatewiki at the moment? [10:25:20] and soon it should be at sandox.translatewiki and wmf labs? [10:26:56] (03CR) 10Nikerabbit: [C: 032] Give grep a chance to find the usages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/80960 (owner: 10Shirayuki) [10:26:59] (03Merged) 10jenkins-bot: Give grep a chance to find the usages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/80960 (owner: 10Shirayuki) [10:27:17] zeljkof: it should be on labs any moment now [10:27:30] zeljkof: sandbox does not have automatic updates, but I can update it [10:28:08] Nikerabbit: I do not really care where the code runs, but I do care if it runs on a site where it is known to fail :) [10:28:27] zeljkof: well, try labs :) [10:28:40] I am fine with removing sanbox.translatewiki tag from the feature file, if the file should not run there any more [10:29:14] zeljkof: I see no problem running it in sandbox, though I do not see added benefit either [10:29:38] Nikerabbit: in that case I vote for removing that tag from the file [10:30:42] zeljkof: I do not know why the tag has been created, but I would imagine we would (only) run tests at sandbox.translatewiki.net for features that are not supported on labs [10:31:21] Nikerabbit: there was a time when the only environment where ULS was supported was translatewiki [10:31:54] Nikerabbit: all 4 scenarios fail at en.wikipedia.beta.wmflabs.org [10:32:02] should I run the tests somewhere else? [10:32:43] (03CR) 10Zfilipin: "$ export MEDIAWIKI_URL=http://en.wikipedia.beta.wmflabs.org/wiki/" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80209 (owner: 10Nikerabbit) [10:33:04] see the last comment at https://gerrit.wikimedia.org/r/#/c/80209/ [10:33:50] aha [10:33:56] aharoni: is working on it [10:34:15] Nikerabbit, aharoni: great [10:34:20] let me know when I can run the tests there [10:34:35] I will be around for the next 4-5 hours [11:30:21] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/67418 (owner: 10Hashar) [11:30:25] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/67418 [11:32:52] (03CR) 10Yuvipanda: "(2 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 (owner: 10Yuvipanda) [11:35:06] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/67418 (owner: 10Hashar) [11:36:39] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/80978 [11:39:13] (03PS1) 10Arrbee: GWT scenarios for checking consistency of webfont selection settings [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80980 [11:42:44] (03CR) 10Tobias Gritschacher: [C: 031] Add files with no coverage at all to the coverage report as well [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/80424 (owner: 10Jeroen De Dauw) [11:47:05] (03PS1) 10Hashar: test: run autoloader suite [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/80981 [11:53:00] (03CR) 10Hashar: [V: 031] "That does run the AutoLoaderTest tests which are even passing:" [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/80981 (owner: 10Hashar) [11:53:40] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/80978 (owner: 10Hashar) [12:02:29] (03PS10) 10Yuvipanda: Add API to query campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 [12:32:15] (03CR) 10Amire80: [C: 04-1] "(4 comments)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80980 (owner: 10Arrbee) [12:34:02] (03PS4) 10Zfilipin: Two scenarios for ULS settings live preview feature [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80388 (owner: 10Nikerabbit) [12:35:08] (03PS1) 10Hashar: beta: mw config update now refresh db cdb files [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/80984 [12:36:11] aharoni, Nikerabbit: any luck with getting https://gerrit.wikimedia.org/r/#/c/80209/ to work on en.wikipedia.beta.wmflabs.org? [12:36:52] zeljkof: I'm waiting for https://gerrit.wikimedia.org/r/#/c/80017/ to get merged. I think that it's OK, but Nikerabbit had some doubts about it. [12:37:29] (03CR) 10Hashar: [C: 032] beta: mw config update now refresh db cdb files [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/80984 (owner: 10Hashar) [12:37:51] (03Merged) 10jenkins-bot: beta: mw config update now refresh db cdb files [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/80984 (owner: 10Hashar) [12:37:54] aharoni, Nikerabbit: ok, let me know how it goes :) [12:41:14] (03PS1) 10Hashar: beta: db upgrade for arwiki [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/80985 [12:42:28] (03CR) 10Hashar: [C: 032] beta: db upgrade for arwiki [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/80985 (owner: 10Hashar) [12:42:49] (03Merged) 10jenkins-bot: beta: db upgrade for arwiki [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/80985 (owner: 10Hashar) [12:48:19] DanielK_WMDE: is wgDebugDBTransactions safe to enable on production site? [12:50:29] DanielK_WMDE: nevermind, it doesn't seem to be useful, it should use debug group instead [12:51:20] zeljkof: should work now on labs [12:51:41] Nikerabbit: thanks, will try in a minute [12:54:09] Nikerabbit: uh oh, still all tests fail on en.wikipedia.beta.wmflabs.org [12:55:04] (03CR) 10Zfilipin: "$ export MEDIAWIKI_URL=http://en.wikipedia.beta.wmflabs.org/wiki/" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80209 (owner: 10Nikerabbit) [12:55:18] take a look at the latest comment at https://gerrit.wikimedia.org/r/#/c/80209/ [12:55:23] that is what I get [12:59:08] zeljkof: aaa sorry sorry [12:59:35] zeljkof: that file should be ran against commons.wikimedia.beta because it depends on the ULS icon being on the personal toolbar [12:59:55] ok, will try [13:00:49] noo hold a moment [13:03:11] well, it works for me for commons, but I don't understand why [13:03:20] (03PS2) 10Arrbee: GWT scenarios for checking consistency of webfont selection settings [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80980 [13:03:35] aha [13:03:49] because enwiki has different configuration, that's it [13:04:10] still 2/4 failures at commons [13:04:19] really? it worked for me [13:04:46] oh well, expect the sticky input methods which was supposed to be marked pending [13:06:44] sorry, just one failure on commons now [13:06:46] will try again [13:06:55] and mark the last scenario as pending [13:07:59] hm, now 3/4 failed scenarios [13:08:05] something is flaky in the tests [13:09:25] (03PS6) 10Amire80: Add tests for language name display in ime menu [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80209 (owner: 10Nikerabbit) [13:09:26] zeljkof: hold on [13:09:30] zeljkof: can you try PS6 [13:09:41] PS6? [13:09:48] of https://gerrit.wikimedia.org/r/80209 [13:10:03] I see, patch set 6 :) [13:10:17] will do [13:11:09] as far as I can see, this is the only change [13:11:10] https://gerrit.wikimedia.org/r/#/c/80209/5..6/features/step_definitions/uls_ime_steps.rb [13:11:19] but it should do exactly the same thing [13:11:53] "link_element.click" should do exactly the same thing as just "link" [13:12:15] zeljkof: apparently, it didn't do a click. [13:13:05] aharoni: wow, it _does_ work on my machine now :) [13:13:17] c**l [13:14:08] aharoni, Nikerabbit: should I change the tags to make the file run only on commons? [13:14:24] or should it run on translate wiki and/or test2 too? [13:14:32] zeljkof: similarly foo.should == 'bar' is different form foo_element.text.should == 'bar' -- they should be the same [13:14:58] Nikerabbit: I will have to investigate that these days, they _should_ be the same [13:15:00] zeljkof: at least on beta-commons [13:15:22] Nikerabbit: yes, that is what I meant [13:15:46] again, I'm not sure if there is added value running them against other wikies [13:16:09] Nikerabbit: especially if the tests fail there :) [13:16:15] zeljkof: is it because beta english Wikipedia doesn't have IME enabled by default? [13:16:47] aharoni: yes [13:16:49] aharoni: I have no idea what the site configurations are, that is black magic for me, hashar should know [13:17:05] test2 should pass once it gets updated code [13:17:10] hey :) [13:17:12] beta enwiki is supposed to emulate enwiki, and ime's are disabled on enwiki [13:17:32] (03PS7) 10Zfilipin: Add tests for language name display in ime menu [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80209 (owner: 10Nikerabbit) [13:17:38] to make the enwiki community less pissed off at ULS [13:17:41] * aharoni hides [13:18:02] I am wondering why they are pissed off by it :-D [13:19:01] (03CR) 10Zfilipin: "Run the tests only at commons.wikimedia.beta.wmflabs.org, since that is the only place where they do not break at the moment." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80209 (owner: 10Nikerabbit) [13:20:08] (03CR) 10Zfilipin: [C: 032] Add tests for language name display in ime menu [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80209 (owner: 10Nikerabbit) [13:20:11] zeljkof: thanks for the reviews [13:20:23] Nikerabbit, aharoni: merged 80209 [13:20:32] Nikerabbit: no problem, that is what I do :) [13:20:45] \o/ [13:20:48] thanks zeljkof [13:21:13] zeljkof: do you have idea when we can move the tests to ULS repository? [13:21:23] yesterday :) [13:21:33] Nikerabbit: there is no reason not to move them now [13:22:12] you just have to decide where you want to put them, I can create a commit that will move everything needed to ULS repo [13:22:30] zeljkof: oh really? [13:22:39] nice :) [13:22:42] zeljkof: will there be docs how to run them there? [13:22:57] Nikerabbit: I can copy the readme file too :) [13:23:18] or we can add a readme file pointing to a wiki page on mw.org [13:23:27] and how about the automatic runs currently done? [13:23:42] Nikerabbit: I would create new jobs on our jenkins instance [13:23:55] we already have jobs for mobilefrontend and cirrussearch [13:23:56] anyway, tests/selenium or tests/cucumber I guess? Akin to tests/phpunit and tests/qunit [13:24:16] both is fine with me, and can be changed later [13:24:25] should I make the move now? [13:24:50] aharoni, arrbee: any reason not to move? [13:25:19] I can make the commit, feel free not to merge it, or to merge it when everybody is happy with the commit [13:25:20] it's a good idea, as long as the configuration of the tests is in sync [13:25:35] ruby gems, documentation, support libraries etc. [13:25:54] I am still far from being enough of a Ruby expert to know that it's find. [13:26:29] s/find/fine/ [13:26:48] well, if two projects are already using it, I guess it will be fine [13:26:55] I need 30 or so minutes to finish e-mail triage, and I can create the commit, sounds good? [13:26:56] and there are big benefits having them in the uls repo [13:27:05] zeljkof: yep [13:27:13] Nikerabbit: deal [13:27:21] Thanks zeljkof :) [13:27:39] arrbee: no problem :) [13:28:30] Nikerabbit: does that variable even work for SQL or not? the docs say not, should they be updated [13:29:04] Nemo_bis: it must work for SQL [13:29:42] !git operations/debs/ircd-ratbox [13:29:42] MediaWiki development is using git, a distributed source control manager, starting on March 21st, 2012; details: https://www.mediawiki.org/wiki/Git_happens Instructions for using it: https://www.mediawiki.org/wiki/Git/Workflow To get an account: https://www.mediawiki.org/wiki/Project:Labsconsole_accounts [13:29:46] !gerrit operations/debs/ircd-ratbox [13:29:46] https://gerrit.wikimedia.org/r/#q,operations/debs/ircd-ratbox,n,z [13:29:49] !gitweb operations/debs/ircd-ratbox [13:29:50] Don't use gitweb anymore, use gitblit: https://git.wikimedia.org/ [13:29:51] !gitblit operations/debs/ircd-ratbox [13:29:51] https://gerrit.wikimedia.org/r/plugins/gitblit/ [13:29:58] pfff [13:31:32] StevenW: you have questions on [[en:WP:WikiProject:Articles for creation/RfC Reviewer permission]] [13:31:36] @link [13:31:36] http://enwp.org/WP:WikiProject:Articles_for_creation/RfC_Reviewer_permission [13:31:51] Gr. [13:31:58] StevenW: you have questions on [[en:WP:WikiProject Articles for creation/RfC Reviewer permission]] [13:32:00] @link [13:32:00] http://enwp.org/WP:WikiProject_Articles_for_creation/RfC_Reviewer_permission [13:32:13] That one without the extra : [13:32:41] thanks for the bug [13:52:15] Nikerabbit: fwiw, Aaron added the TransactionIdle and PreCommit stuff, maybe he can help. [13:54:17] Nikerabbit: sorry, *MySQL [13:55:44] zeljkof: are you doing this tests directory split for ULS today? [13:59:21] aharoni: yes, right now [14:19:28] (03PS2) 10Manybubbles: Test to verify page weight considers redirects. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80244 [14:20:04] (03CR) 10Manybubbles: [C: 032] "Self +2 after rebasing changeset that Chad +2ed." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80244 (owner: 10Manybubbles) [14:20:07] (03Merged) 10jenkins-bot: Test to verify page weight considers redirects. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80244 (owner: 10Manybubbles) [14:30:36] (03PS1) 10Aude: Update Wikibase and DataValues [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80992 [14:38:53] hey [14:39:06] MatmaRex: hi [14:42:41] hello [14:45:15] MatmaRex: how does a revision look like when the page is deleted ? [14:46:26] um, i don't think i understand the question [14:46:36] the data is moved to the archive table, from the revision table [14:46:37] !db revision [14:46:37] See http://www.mediawiki.org/wiki/Manual:revision_table [14:46:39] !db archive [14:46:39] See http://www.mediawiki.org/wiki/Manual:archive_table [14:46:49] apart from that, mostly the same [15:02:14] wb, hashar :) [15:03:11] thx :) [15:06:46] MatmaRex: ok, I read most of what you gave me [15:06:58] MatmaRex: so there's multiple ways of deleting a page [15:07:07] I still don't know what happens to a page when it gets deleted ? [15:07:17] does it just mean that its latest revision has rev_deleted=1 ? [15:07:54] hey dan-nl [15:08:50] hey YuviPanda [15:09:13] dan-nl: how's the extension coming laong? [15:09:14] *along [15:09:40] dan-nl: Welcome back! Good vacation? :) [15:10:13] average: agh, i really don't know [15:10:17] YuviPanda: have a bit of feedback to address ;) have been sorting out my local environment in order to create a few branches to deal with the re-factoring [15:10:27] marktraceur: thanks. yes, good holiday :) [15:10:30] try vagrant if you could :) [15:10:32] it's pretty neat [15:10:42] https://www.mediawiki.org/wiki/MediaWiki-Vagrant [15:10:44] !vagrant [15:10:44] https://www.mediawiki.org/wiki/MediaWiki-Vagrant [15:11:32] YuviPanda: thanks. taking a look at the link now [15:15:19] YuviPanda: how's your work going? [15:16:22] dan-nl: not bad. UW's come a long way [15:16:33] for... some definition of 'a long way' [15:18:07] YuviPanda: have you been working with TemplateData? [15:19:02] YuviPanda: i sent out a query to nazmul about any progress. for example i want to be able to use it for the Artwork template, but haven't seen anything up on commons yet. http://commons.wikimedia.org/w/api.php?action=templatedata&titles=Template:Artwork [15:19:55] YuviPanda: will try an liaise with him on setting something up [15:22:28] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/80958 (owner: 10Ori.livneh) [15:29:33] (03CR) 10Anomie: [C: 032] wpUndidRevision should be passed along during 'preview' and 'diff' [core] - 10https://gerrit.wikimedia.org/r/80680 (owner: 10Bsitu) [15:32:44] (03Merged) 10jenkins-bot: wpUndidRevision should be passed along during 'preview' and 'diff' [core] - 10https://gerrit.wikimedia.org/r/80680 (owner: 10Bsitu) [15:37:54] damn, he left :( [15:39:09] (03PS5) 10Nikerabbit: Two scenarios for ULS settings live preview feature [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80388 [15:44:08] (03PS1) 10Jack Phoenix: Fixed syntax terror. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/81002 [15:44:40] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fixed syntax terror. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/81002 (owner: 10Jack Phoenix) [15:48:01] (03PS7) 10Nikerabbit: Enhanced RC: Add a "view changes since my last visit" link [core] - 10https://gerrit.wikimedia.org/r/75579 (owner: 10Matmarex) [15:48:07] (03CR) 10Nikerabbit: [C: 032] Enhanced RC: Add a "view changes since my last visit" link [core] - 10https://gerrit.wikimedia.org/r/75579 (owner: 10Matmarex) [15:48:53] (03CR) 10Daniel Kinzler: "(1 comment)" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man) [15:50:31] (03CR) 10Daniel Kinzler: [C: 031] "The approach seems fine, but I haven't tested this." [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man) [15:51:13] (03CR) 10Hoo man: "(1 comment)" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man) [15:52:50] (03Merged) 10jenkins-bot: Enhanced RC: Add a "view changes since my last visit" link [core] - 10https://gerrit.wikimedia.org/r/75579 (owner: 10Matmarex) [15:53:28] (03PS1) 10Hashar: pep8 / flake8 configuration [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81005 [15:57:30] (03PS1) 10Hashar: fix up harmless pep8 errors [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81006 [15:58:28] (03PS1) 10Emwiemaikel: fixed wrong version number in HISTORY [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/81007 [15:58:37] (03PS1) 10Hashar: homedirectorymanager: nicer comparison [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81008 [15:58:53] (03PS1) 10Hashar: puppetsigner: remove unused 'pwd' module [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81009 [15:59:51] (03CR) 10Anomie: "While currently popular programming languages are overwhelmingly Latin-script-based (and, for that matter, English-based), I see a number " [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/80707 (owner: 10Amire80) [16:07:40] (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80764 (owner: 10Burthsceh) [16:07:49] (03CR) 10Hashar: [C: 032] "That must have broken some extensions tests :/ Sorry." [core] - 10https://gerrit.wikimedia.org/r/80420 (owner: 10Anomie) [16:10:51] (03Merged) 10jenkins-bot: Clean up parser test's InterwikiLoadPrefix hook [core] - 10https://gerrit.wikimedia.org/r/80420 (owner: 10Anomie) [16:46:17] (03CR) 10Anomie: [C: 032] SpecialCentralAutoLogin: Inline JavaScript cleanup [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/74484 (owner: 10Matmarex) [16:46:22] (03Merged) 10jenkins-bot: SpecialCentralAutoLogin: Inline JavaScript cleanup [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/74484 (owner: 10Matmarex) [16:48:37] anyone got an idea about when Ryan Lane might be around? [16:52:51] hoo: Generally pre-10:30 PST, but I'll let you know [16:53:00] His desk is in nerf range [16:53:11] marktraceur: Thanks ... I need a new labs project to be approved :D [16:53:28] * marktraceur is aaaaalways a fan of new Labs projects [16:53:48] Wait, does csteipp have the power for that? He's in even *closer* nerf range. [16:53:59] marktraceur: is ryan the only person who approves? [16:54:02] csteipp: Do you? [16:54:06] cuz coren is labs person, but not in this channel as well [16:54:11] but he may be toollabs only [16:54:18] https://wikitech.wikimedia.org/wiki/New_Project_Request/accessibility-dev [16:54:29] I don't actually know, I'm just casting about [16:54:38] me either [16:54:53] but as the only ops person in office i felt the need to chime in even when adding no value. [16:55:05] if only to preemptively strike before being pinged [16:55:08] RobH: We understand your need to add no value :) [16:55:25] I'll remember that comment when you need bare metal ;] [16:55:58] (03PS13) 10Hoo man: Add extra accessibility labels to jump to citation (↑) links [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 [16:56:02] I'd much rather have BEAR METAL [16:57:16] Oh good a Coren. [16:57:21] hoo meet coren [16:57:24] damn, I shouldn't have used "strip trailing spaces" on a .i18n file :P [16:57:36] Coren works with Ryan in labs stuff [16:57:39] Noooooope [16:57:48] hey Coren, are you able to approve https://wikitech.wikimedia.org/wiki/New_Project_Request/accessibility-dev [16:58:04] marktraceur: ok, i added a very tiny amount of telephone game value [16:58:11] hoo: I could create that project for you, but unless you have stringent performance requirements, it might be simplest for you to join tools for this; getting a mw install is generally as easy as just cloning from git. [16:58:11] that means im done for today right? [16:58:46] anomie: hola [16:58:48] Coren: I don't care about anything, it just needs to be a running, custom MW installation... and it shouldn't be to slow [16:58:59] If I'm allowed to run that on labs that's ok for now [16:59:06] * tool labs [16:59:20] Coren: Aw, don't encourage him to run MW on toollabs [16:59:30] It's *allowed* but it's *slow* [16:59:31] hoo: You are, there are already 2-3 other users who do so exactly for the same reason you would (testing an extension in development) [16:59:58] I only need single patches actually, but still, ok :) [17:00:12] marktraceur: Yeah, we have a 'tool-labs-mw-in-a-box' project in the works, but it's going to take a while to get there -- in the meantime, we're tight on labs resources so we try to avoid new projects when possible. [17:00:36] At least until the new virt box gets onlined. [17:00:53] Coren: The thing is, I'm still yelling at GorillaWarfare and bawolff to quit doing that because it takes so gorram long to test their stuff on toollabs [17:01:12] Coren: do our apaches have APC? [17:01:18] (03CR) 10Hoo man: "This should now work bearable in all browsers with all (more or less) recent screen readers. It might be considered a bit hacky but I thin" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/79472 (owner: 10Hoo man) [17:01:33] marktraceur: ask them to setup redis for caching in mediawiki, should speed things up signficantly [17:01:47] YuviPanda: Why don't you [17:02:03] I mean, wait for bawolff to get online [17:02:16] marktraceur: there is the tiny problem of there being no documentation for that exact thing :P [17:02:17] hoo: would Vagrant serve your purpose? http://www.mediawiki.org/wiki/Vagrant [17:02:21] marktraceur: ori-l says that could be done, but... [17:02:24] marktraceur: Hm. Well, since the scenario is becoming increasingly common perhaps you can help convince Erik to up the priority on the mw-in-a-box project. :-) He okayed it in principle but it's on the "nice to have if we have time" low-priority list. :-) [17:02:27] YuviPanda: Well, then, god [17:02:30] Get it done [17:02:42] what, me? write documentation? you know that never ends well! [17:02:56] YuviPanda: Then talk to me tonight and I'll write it as your sockpuppet [17:02:58] chrismcmahon: I need to show the changes to users who aren't developers, so I just want to give them an URL to have a look. [17:03:13] And/or write a draft and I'll edit it [17:03:15] marktraceur: I don't even know how it works :P ori-l told me it does, so you need to be his [17:03:17] sockpuppet [17:03:22] marktraceur: I'd write docs if I knew! [17:03:28] ori-l: CC offer to be a sockpuppet [17:03:38] hrm? hello? [17:03:41] hoo: Tool labs will get you up and running in no time with low performance (atm). If that does the trick, it's simple and fast. [17:04:16] Coren: I guess I'll just do that then... I want to get something rather now than in a week :P [17:04:17] Coren: the important thing is not to collaborate with me at all; it's dangerous and should be avoided [17:04:43] hoo: Your wikitech username is TheDJ correct? [17:04:47] ori-l: Docs for redis caching [17:04:52] We should write them [17:05:01] aharoni: hi? [17:05:02] Coren: No, thedj is TheDJ, I'm hoo :P [17:05:16] he did the project proposal [17:06:27] So wait, hoo's on first? [17:06:48] marktraceur: if you run vagrant & run 'vagrant enable-role gettingstarted', you get a redis instance & phpredis along with the extension, but it's not set up as the default memcached [17:06:55] but it still takes you 90% of the way there [17:07:18] ori-l: I think he's trying to write docs for 'how to use it as default memcached replacement', which... don't seem to exist [17:07:18] ori-l: We're talking about "on toollabs", so vagrant probably isn't the best option [17:07:19] yet [17:07:38] marktraceur: well, you can look at what the puppet stuff is doing [17:07:43] just treat it as documentation [17:07:46] and try to replicate on tool labs [17:08:05] Berk [17:08:08] All right [17:08:11] tho IIRC it's not a whole lot more than apt-get install redis-server & phpredis [17:08:16] (03PS1) 10Raimond Spekking: Some consistency tweaks in preparation for adding extension to translatewiki.net [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/81015 [17:08:31] hoo: 'There is no user by the name "Hoo". Check your spelling.' [17:08:36] Arright, this goes on my mental volatile TODO list [17:08:43] Coren: lower case, it is [17:09:26] YuviPanda: Oh, did you see I finished ALL the jshint errors last night? [17:09:39] It was very exciting [17:09:43] hoo: MW usernames are not case significant on the first letter. Oh. That's your /shell/ account name. Your wikitech account is 'Hoo man' [17:09:43] marktraceur: good job! and no, I didn't :D [17:09:50] marktraceur: who do you have in mind for review? :D [17:09:56] Uh, well [17:10:00] You doin' anything? [17:10:00] Coren: Oh, you meant that one, sorry, yes [17:10:05] Oooh, or Krinkle [17:10:37] hoo: You're already a member of tools; just create a service group and you're all set -- the public_html in its home can hold a mw install. [17:11:13] Coren: I already cloned it into http://tools.wmflabs.org/hoo/core/ [17:11:29] hoo: Ask YuviPanda to document how to use reddis to cache. :-) [17:11:34] Redis* [17:11:48] redis* [17:11:54] http://tools.wmflabs.org/hoo/testWiki/ that's a more decent URL, I guess [17:12:25] Coren: hoo has a better chance of finding that himself, since I am not too familiar with core anyway :) [17:12:42] (03PS1) 10EBernhardson (WMF): first stab at recentchanges integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 [17:13:13] (03PS1) 10EBernhardson (WMF): Last modified timestamps with hover swap to full ts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81018 [17:14:19] (03PS8) 10MarkTraceur: Loads of work on jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 [17:14:52] Coren: What's the hostname of the MySQL/ MariaDB instance to use? [17:15:03] (03PS3) 10MarkTraceur: Final jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 [17:15:04] (03PS4) 10MarkTraceur: More jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80945 [17:15:05] (03PS3) 10MarkTraceur: Further jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80947 [17:15:08] Rebases!!!! [17:16:49] * Reedy waits for marktraceur to commit all of the jshint fixes [17:20:02] Coren: Got it ;) [17:21:40] gah, i hate flaggedrevs [17:21:42] seriously. [17:22:19] :D [17:22:40] "Final jshint fixes" -> "More jshint fixes" -> "Further jshint fixes" [17:22:42] (03PS4) 10MarkTraceur: Final jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80954 [17:22:43] (03PS9) 10MarkTraceur: Loads of work on jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 [17:22:44] (03PS5) 10MarkTraceur: More jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80945 [17:22:45] (03PS4) 10MarkTraceur: Further jshint fixes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80947 [17:22:45] ah, I know that so well [17:22:57] Reedy: Sorry, there were some tiny issues that I missed [17:23:10] Because I hadn't actually run the tool with the fixes [17:23:25] _always_ when write "final" it ends up no being final :D [17:24:01] lazowik: Well, it was the final jshint fix patch [17:24:12] It just happened to have some dependent patches that weren't perfect :) [17:24:20] mhm [17:24:26] OK, back to CSS hell [17:24:38] stupid php [17:24:38] * marktraceur trudges back to the mines [17:24:47] why would array_map and array_filter take arguments in different order [17:24:50] seriously [17:24:53] stab stab stab [17:25:03] implode [17:25:04] explode [17:25:25] your fault for not being on your guard against PHP :P [17:25:25] it's out to get you! [17:25:38] i specifically checked this before coding. [17:25:53] (03PS1) 10Manybubbles: Update the search index for linked pages. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81020 [17:25:56] anyway, php sucks [17:26:09] MatmaRex: What else is new [17:26:58] (03PS1) 10Manybubbles: Test updating linked pages. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81021 [17:27:56] Krinkle, YuviPanda, maybe even MatmaRex, those jshint fixes seem stable and done(ish) to me, if you want to run through them sometime [17:28:26] The first one is https://gerrit.wikimedia.org/r/80523 and the rest are a string of dependent commits [17:28:53] (though they could be split, since they all edit a specific set of files) [17:28:56] when i'm done wrestling with goddamn flaggedrevs [17:28:59] MatmaRex: array_rand sometimes returns an array and sometimes a single key.... [17:29:03] MatmaRex: Cool cool [17:29:43] Krenair: around? [17:30:05] manybubbles, lol. [17:30:30] could just cast the output to an array I guess [17:30:32] Krenair: i'm looking at your flaggedrevs-echo thing while wrestling with mine [17:30:34] at least it behaves randomly [17:30:34] !g I1b0213b229f665bdf05d52fe7859f410eecfc337 [17:30:35] https://gerrit.wikimedia.org/r/#q,I1b0213b229f665bdf05d52fe7859f410eecfc337,n,z [17:30:41] MatmaRex, hi [17:30:43] Krenair: I see why they did it, but jesus christ. [17:30:55] Krenair: are you checking for anonymous users anywhere in this? [17:31:14] hmm. I think Echo does that? [17:31:21] (or in other worse, (how) should i) [17:31:28] i dunno [17:32:30] Krenair: basically it seems like if there's an anon user, you just pass User::newFromId( 0 ) to the whole shebang [17:32:49] bsitu: around? [17:33:10] MatmaRex: yes, I am [17:33:19] great, please tell me [17:33:40] if it's kosher to add User::newFromId(0) to the $users array in the EchoGetDefaultNotifiedUsers hook [17:33:59] and also, if it's kosher to add one user multiple times [17:34:20] ah, okay, this doesn't matter, disregard the second quesiton [17:35:01] MatmaRex, see controller/NotificationController.php line 171 [17:35:07] you can, but anon user is skipped [17:36:15] okay, thanks [17:37:36] (03CR) 10Mwalker: [C: 032] Bug 53288: Use more descriptive link titles for read/edit in dropdowns [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80691 (owner: 10Mollywhite) [17:37:40] (03Merged) 10jenkins-bot: Bug 53288: Use more descriptive link titles for read/edit in dropdowns [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80691 (owner: 10Mollywhite) [17:40:07] (03CR) 10Jeroen De Dauw: [C: 032] Add files with no coverage at all to the coverage report as well [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/80424 (owner: 10Jeroen De Dauw) [17:40:09] (03Merged) 10jenkins-bot: Add files with no coverage at all to the coverage report as well [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/80424 (owner: 10Jeroen De Dauw) [17:40:10] (03CR) 10Mwalker: [C: 032] Bug 53289: Use more descriptive titles for prev/next links in navbar. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80692 (owner: 10Mollywhite) [17:40:11] (03CR) 10jenkins-bot: [V: 04-1] Bug 53289: Use more descriptive titles for prev/next links in navbar. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80692 (owner: 10Mollywhite) [17:40:18] woot. [17:40:50] heh, mwalker jenkins'd? :) [17:41:20] YuviPanda: apparently the patch cannot be rebased onto master [17:41:41] it's actually the fault of the i18n files I'm pretty sure [17:41:48] we *need* a better solution [17:41:55] but I have no idea what it would look like [17:42:07] for what, rebasing? [17:42:12] i recommend meld :) [17:42:22] svn? [17:42:41] Meld *is* a sexy bit of software [17:42:44] it is [17:42:53] but no; we need a solution to avoid having to rebase 40k line files [17:43:29] (03CR) 10Mwalker: [C: 032] Bug 53290: Add descriptive titles for edit/rename buttons in editor. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80693 (owner: 10Mollywhite) [17:43:32] (03Merged) 10jenkins-bot: Bug 53290: Add descriptive titles for edit/rename buttons in editor. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80693 (owner: 10Mollywhite) [17:43:40] chrismcmahon: it looks like I deployed a change that requires a reindex but I didn't reindex it. I'll have to be (much) more careful about this in the future. [17:44:33] thedj: http://tools.wmflabs.org/hoo/testWiki/index.php?title=CiteSample [17:48:35] (03PS5) 10EBernhardson (WMF): Paging for topics on TopicList objects. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79444 (owner: 10Werdna) [17:49:56] (03PS6) 10EBernhardson (WMF): Paging for topics on TopicList objects. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79444 (owner: 10Werdna) [17:50:11] (03CR) 10CSteipp: "Yeah, I think still requiring the url would be best. Maybe adding it as a hint, or we can just document that it exists." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80569 (owner: 10Anomie) [17:50:11] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Paging for topics on TopicList objects. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/79444 (owner: 10Werdna) [17:50:27] anomie: Hi again. I had a meeting. It's about https://gerrit.wikimedia.org/r/#/c/80707/ . [17:51:05] (03PS3) 10Matmarex: Fire Echo event when revision is approved [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 [17:51:07] YuviPanda, marktraceur, MatmaRex meld is, in fact, awesome, and "awesome" is not a word that I use lightly. [17:51:10] damned flaggedrevs. [17:51:15] AaronSchulz: ^^ [17:51:18] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Allow wikitext in the summary block [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80402 (owner: 10EBernhardson (WMF)) [17:51:21] I should try meld at some point, I guess [17:51:43] Parse error: syntax error, unexpected 'if' (T_IF) in /home/WWW/matmarex/WWW/testwiki/extensions/FlaggedRevs/business/RevisionReviewForm.php on line 489 [17:51:46] php sucks. [17:52:48] MatmaRex: http://phpsadness.com/sad/44 [17:53:02] AKA "you'll not be getting any work done this hour" [17:55:08] (03PS4) 10Matmarex: Fire Echo event when revision is approved [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 [17:56:39] ah, damn, the logic for reverts in this won't work [17:56:44] i hate flaggedrevs. [17:57:25] (03PS2) 10EBernhardson (WMF): Last modified timestamps with hover swap to full ts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81018 [17:57:39] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Last modified timestamps with hover swap to full ts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81018 (owner: 10EBernhardson (WMF)) [17:58:22] (03CR) 10Hoo man: "bump" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/72724 (owner: 10Hoo man) [17:59:52] (03CR) 10Jeroen De Dauw: [C: 031] Refactor AbuseFilterView::canEdit* functions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/72724 (owner: 10Hoo man) [18:00:11] (03CR) 10Matmarex: [C: 04-1] "Actually, this doesn't work at all, the logic for reverts is broken, and the notifications are broken as well (link to diff points to the " [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Matmarex) [18:01:34] (03PS2) 10EBernhardson (WMF): Content moderation for posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80303 [18:03:53] thedj_: Saw the link http://tools.wmflabs.org/hoo/testWiki/index.php?title=CiteSample [18:04:20] Nikerabbit: thanks for https://gerrit.wikimedia.org/r/#/c/75579/ :D [18:05:03] MatmaRex: so happy? [18:09:04] Nikerabbit: it's going to make my daily watchlist routine a few percent quicker ;) [18:11:18] MatmaRex: I was considering whether it is too much bloat [18:11:34] but then I thought it would be rude not to approve it since I started reviewing it [18:12:16] heh [18:12:36] i'm pretty sure the usefulness outweighs the bloat here [18:12:52] i also have a patch where i'm removing some stuff from there ;) [18:14:01] (03PS3) 10EBernhardson (WMF): Content moderation for posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80303 [18:14:24] MatmaRex: Add aud.e as reviewer to it, she's also interested in killing enhancing/ refactoring it [18:14:58] hoo: at least two people complained that they like that part of bloat ;) [18:15:35] :D after looking at enhanced changeslist's source for the first time, I wanted to kill it :D [18:15:41] But I guess people still use it... [18:16:15] I personally think the non-enhanced RC gives better output [18:16:27] bawolff: Yes, I prefer it as well [18:16:36] (03CR) 10Brion VIBBER: "looks workable will test at off I e" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 (owner: 10Yuvipanda) [18:17:10] * aude wants enhanced to be the default :D [18:17:14] well, some people want that [18:17:16] The only time I found it useful, when was I was playing with Special:Recentchangeslinked on commons with the uploaded by mobile category. Having all the upload log actions together was kind of useful [18:17:23] marktraceur / YuviPanda: https://www.mediawiki.org/wiki/Redis#Setup [18:17:31] Ah, grazie [18:17:36] CC GorillaWarfare bawolff [18:17:41] i just added it, feel free to expand. [18:17:48] aude: :P Still working on making it less evil? [18:17:54] Set up redis caching on yer toollabs instances so they aren't so fucking godawful slow [18:17:55] hoo: yes [18:18:07] marktraceur: it's not going to be faster than memcached, fwiw [18:18:08] What am I being cc'd on? [18:18:08] have to come up with small patches incrementally [18:18:22] bawolff: You're still using toollabs for beta stuff, right? Redis. [18:18:27] Or memcached, I guess [18:18:38] But I assume YuviPanda suggested redis for dogfooding purposes [18:18:45] I'm content with it just being horendously slow... ;) [18:18:49] hahah [18:18:59] especially now that people aren't really looking at it any more [18:19:09] * marktraceur begins melting into the floor [18:20:22] 886 Warning: in_array() expects parameter 2 to be array, null given in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 1125 [18:20:33] If I do something else that requires people to look at my tool labs wiki, I might look into that [18:20:35] if ( in_array( $country, $wmgHTTPSBlacklistCountries ) ) { [18:20:58] * bawolff should set up redis locally, just to become familar with it. Some point when I have extra time [18:20:59] * Reedy pokes ^d [18:21:13] <^d> ...hrm [18:21:26] ^d: $wmgHTTPSBlacklistCountries isn't going to work like you expect there [18:21:27] bawolff: redis is extremely easy to setup and configure [18:21:47] 'default' => array( 'CN', 'IR' ), [18:21:54] <^d> Ah, duh [18:21:55] Or probably just move it to CommonSettings.php [18:22:04] Hmm, Isarra loves my IP [18:22:13] aude: https://gerrit.wikimedia.org/r/79847 would you maybe test that? /me hides [18:22:39] marktraceur: no memcached in toollabs, but there is redis :) [18:23:01] Aha. [18:23:37] <^d> Reedy: https://gerrit.wikimedia.org/r/81024 [18:24:08] (03PS4) 10EBernhardson (WMF): Content moderation for posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80303 [18:24:21] >looks workable will test at off I e [18:24:21] bawolff: What, now? [18:24:23] hehe, brion [18:24:41] Isarra: I got logged out, and I had a new message from you, professing your love! [18:24:55] https://www.mediawiki.org/w/index.php?title=User_talk:96.53.239.112&diff=cur [18:25:00] (03CR) 10MarkTraceur: [C: 032] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80683 (owner: 10Brian Wolff) [18:25:27] And it wasn't you? [18:25:41] I find that oddly suspicious, since the world only has so many lovely people... [18:25:45] I think it was me [18:25:59] * Isarra huggles bawolff. [18:26:10] I haven't been in this location for about 8 months, surprised it still has same IP address [18:26:45] hmm, suspicious :P [18:26:47] MatmaRex: yes I was one of them [18:27:08] o.O [18:27:51] hi Isarra [18:28:22] (03Merged) 10jenkins-bot: [New gallery] ignore perrow option in this mode, as doesn't make sense. [core] - 10https://gerrit.wikimedia.org/r/80683 (owner: 10Brian Wolff) [18:28:45] Hello. [18:28:57] * YuviPanda pokes bawolff [18:29:07] * bawolff is poked [18:29:26] bawolff: thoughts on putting galleries of stuff on pages like commons.wikimedia.org/wiki/Campaign:wlm-nl? [18:29:32] rather than the current boring json structure [18:29:40] (03PS5) 10EBernhardson (WMF): Content moderation for posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80303 [18:29:57] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Content moderation for posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80303 (owner: 10EBernhardson (WMF)) [18:30:43] YuviPanda: like a gallery of stuff uploaded from that campaign? [18:30:47] yup [18:30:50] and a button saying 'upload more!' [18:31:17] (03PS1) 10Krinkle: Fixup coding style of a18d9856f7 [core] - 10https://gerrit.wikimedia.org/r/81025 [18:31:46] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80205 (owner: 10Platonides) [18:32:11] (03CR) 10Hoo man: [C: 032] Fixup coding style of a18d9856f7 [core] - 10https://gerrit.wikimedia.org/r/81025 (owner: 10Krinkle) [18:32:21] That does sound more inviting then the json. json should probably still be there somewhere (perhaps hidden in a collapsible section) [18:32:31] bawolff: perhaps. [18:32:43] bawolff: I'm thinking if I could automatically display a subpage, say /display or something [18:32:46] * marktraceur loads toollabs/bawolff [18:32:53] bawolff: and people could put automatic galleries [18:32:53] or something [18:32:54] Auogughugoheughhhhhghhghhghghghgh [18:32:55] in it [18:33:09] bawolff: but that sounds like a recipe for disaster, and it should probably be done in a better way [18:33:20] bawolff: thoughts on using the gallery code there? [18:33:39] gallery code is already used in a bunch of special pages, so it really shouldn't be an issue [18:33:39] bawolff: Oooh, you got some spam [18:33:54] marktraceur: yeah I noticed. I think account creation is disabled now [18:34:18] YuviPanda: For example Special:newfiles [18:34:43] If you have some way of getting out of the db which things were uploaded in the campaign, it should be pretty easy to show them in a gallery [18:35:05] bawolff: yeah, I added a tracking category for that :P [18:35:16] bawolff: how likely is it for me to bribe you into doing that? [18:35:52] (03Merged) 10jenkins-bot: Fixup coding style of a18d9856f7 [core] - 10https://gerrit.wikimedia.org/r/81025 (owner: 10Krinkle) [18:35:54] umm, probably not this week, already got quite a lot to do [18:36:16] but at some later date, you'd probably be sucesful [18:36:17] bawolff: hmm, point me to where the code has been reused? I could take a stab at it [18:36:31] (03PS2) 10EBernhardson (WMF): first stab at recentchanges integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 [18:36:34] bawolff: I don't see it in https://commons.wikimedia.org/wiki/Special:NewFiles [18:37:10] includes/specials/SpecialNewimages.php is the most obvious example [18:37:42] So far I'm waiting on community discussion before enabling it globally on commons [18:37:55] Its hidden behind a config variable at a moment [18:38:01] (03CR) 10Aude: [C: 031] "tested this and works fine with the keyboard (and touch/mobile)" [core] - 10https://gerrit.wikimedia.org/r/79847 (owner: 10Hoo man) [18:38:16] :) thx [18:38:24] easy to review [18:39:16] YuviPanda: includes/CategoryViewer.php also uses it. (Or will once $wgGalleryOptions['mode'] is changed) [18:39:31] hmm, okay! [18:39:43] bawolff: I don't think I'll have time to get to it soon, but I'll try to persuade you next week :) [18:39:55] :) [18:40:08] * bawolff goes get some lunch [18:40:47] (03CR) 10Amire80: "The practice is that we are currently using it in MediaWiki for Lua, JS and CSS. I agree that it may be useful to use it for qlb some day," [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/80707 (owner: 10Amire80) [18:41:17] (03PS2) 10Mollywhite: Bug 53289: Use more descriptive titles for prev/next links in navbar. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80692 [18:44:33] (03CR) 10Mollywhite: [C: 032] Bug 53289: Use more descriptive titles for prev/next links in navbar. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80692 (owner: 10Mollywhite) [18:44:35] (03Merged) 10jenkins-bot: Bug 53289: Use more descriptive titles for prev/next links in navbar. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/80692 (owner: 10Mollywhite) [18:47:18] bawolff: Now that you've turned off user creation, can you give me an account maybe? [18:59:22] (03PS1) 10Parent5446: Add wgRevisionId variable to ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/81032 [19:02:00] (03PS1) 10Hashar: configuration for pep8/flake8 [tools/release] - 10https://gerrit.wikimedia.org/r/81033 [19:02:01] (03PS1) 10Hashar: make-release: tweaks for pep8 [tools/release] - 10https://gerrit.wikimedia.org/r/81034 [19:02:02] (03PS1) 10Hashar: make-release: fix up python comparison [tools/release] - 10https://gerrit.wikimedia.org/r/81035 [19:02:03] (03PS1) 10Hashar: make-release: use space for indentation [tools/release] - 10https://gerrit.wikimedia.org/r/81036 [19:07:16] (03PS2) 10Krinkle: Add wgRevisionId variable to ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/81032 (owner: 10Parent5446) [19:10:23] (03CR) 10Raimond Spekking: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81018 (owner: 10EBernhardson (WMF)) [19:12:58] (03CR) 10Demon: [C: 032] Update the search index for linked pages. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81020 (owner: 10Manybubbles) [19:13:16] (03Merged) 10jenkins-bot: Update the search index for linked pages. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81020 (owner: 10Manybubbles) [19:13:33] (03CR) 10Spage: "(1 comment)" [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/80501 (owner: 10Jdlrobson) [19:13:38] (03CR) 10Krinkle: "Fixed summary to mention mw.config instead of ResourceLoader. ResourceLoader is the framework, it does not have any modules or content." [core] - 10https://gerrit.wikimedia.org/r/81032 (owner: 10Parent5446) [19:13:53] (03CR) 10Demon: [C: 032] Test updating linked pages. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81021 (owner: 10Manybubbles) [19:13:57] (03Merged) 10jenkins-bot: Test updating linked pages. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81021 (owner: 10Manybubbles) [19:18:43] (03CR) 10Krinkle: "(3 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 (owner: 10MarkTraceur) [19:20:14] (03CR) 10HappyDog: "It would have saved me about half an hour if this had been mentioned in the release notes!" [core] - 10https://gerrit.wikimedia.org/r/26845 (owner: 10Umherirrender) [19:21:59] (03Abandoned) 10Demon: Protect against non-arrays when fetching headers [core] - 10https://gerrit.wikimedia.org/r/80759 (owner: 10Demon) [19:22:14] (03Abandoned) 10Demon: Simplify return in XCFHandler::getXCFMetaData(), no need for assert() [core] - 10https://gerrit.wikimedia.org/r/76881 (owner: 10Demon) [19:23:06] (03CR) 10MarkTraceur: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 (owner: 10MarkTraceur) [19:26:50] (03PS2) 10Aude: Update Wikibase and DataValues [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80992 [19:27:30] (03CR) 10Parent5446: "@Demon, why was this abandoned? Seems like a reasonable change to me." [core] - 10https://gerrit.wikimedia.org/r/80759 (owner: 10Demon) [19:28:21] (03CR) 10Parent5446: "Same here. I probably could've merged this since it doesn't cause any problems." [core] - 10https://gerrit.wikimedia.org/r/76881 (owner: 10Demon) [19:36:53] (03CR) 10Reedy: [C: 032] Update Wikibase and DataValues [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80992 (owner: 10Aude) [19:41:03] (03PS1) 10EBernhardson (WMF): Insert flow definitions via maint script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81079 [19:41:21] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Insert flow definitions via maint script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81079 (owner: 10EBernhardson (WMF)) [19:44:10] (03PS2) 10Reedy: Update Wikibase (to enable url datatype for test.wikidata) [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80715 (owner: 10Aude) [19:44:17] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase (to enable url datatype for test.wikidata) [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80715 (owner: 10Aude) [19:44:26] (03PS3) 10Reedy: Update Wikibase and DataValues [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80992 (owner: 10Aude) [19:44:42] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase and DataValues [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/80992 (owner: 10Aude) [19:57:01] (03PS6) 10CSteipp: Refactor AbuseFilterView::canEdit* functions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/72724 (owner: 10Hoo man) [20:00:47] (03CR) 10CSteipp: [C: 032] "Seems to be working fine. Thanks!" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/72724 (owner: 10Hoo man) [20:01:20] (03Merged) 10jenkins-bot: Refactor AbuseFilterView::canEdit* functions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/72724 (owner: 10Hoo man) [20:06:17] (03CR) 10Krinkle: [C: 04-1] "(2 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 (owner: 10MarkTraceur) [20:07:21] (03CR) 10Krinkle: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 (owner: 10MarkTraceur) [20:10:41] (03CR) 10Krinkle: "(2 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80945 (owner: 10MarkTraceur) [20:13:11] Krinkle: See e.g. https://bugzilla.wikimedia.org/show_bug.cgi?id=53245 [20:18:38] Yippie, build fixed! [20:18:39] Project browsertests-en.wikipedia.org-linux-chrome build #275: FIXED in 3 min 33 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/275/ [20:25:03] (03PS1) 10Manybubbles: Fix typo in document update tests. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81113 [20:25:28] (03CR) 10Manybubbles: [C: 032] "Own +2ing to fix my annoying typo." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81113 (owner: 10Manybubbles) [20:25:30] (03Merged) 10jenkins-bot: Fix typo in document update tests. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81113 (owner: 10Manybubbles) [20:31:06] (03PS1) 10Manybubbles: Stop double counting redirects. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81115 [20:34:59] (03PS7) 10MarkTraceur: Use the new feature field [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 [20:39:57] (03CR) 10Demon: [C: 032] Stop double counting redirects. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81115 (owner: 10Manybubbles) [20:40:05] (03Merged) 10jenkins-bot: Stop double counting redirects. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81115 (owner: 10Manybubbles) [20:43:19] (03CR) 10MarkTraceur: [C: 032] "You might have used margin-left: auto; margin-right: auto; on the paragraph tag, but this works too." [core] - 10https://gerrit.wikimedia.org/r/80676 (owner: 10Brian Wolff) [20:45:20] (03CR) 10Brion VIBBER: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80783 (owner: 10Yuvipanda) [20:46:40] (03Merged) 10jenkins-bot: For new gallery, make nolines mode have caption centered. [core] - 10https://gerrit.wikimedia.org/r/80676 (owner: 10Brian Wolff) [20:47:00] (03CR) 10Ori.livneh: [C: 032] "anomie: the bug having been logged in Bugzilla, I think this is OK to merge." [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/80707 (owner: 10Amire80) [20:47:33] (03Merged) 10jenkins-bot: Explicit dir="ltr" for code [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/80707 (owner: 10Amire80) [20:48:44] thanks for the merge, ori-l [20:49:18] np [20:51:39] (03CR) 10Mattflaschen: [C: 04-1] "Looks good, confirmed locally on regular view, oldid (with and without title), diff next, diff prev, and diff with explicit id. For the d" [core] - 10https://gerrit.wikimedia.org/r/81032 (owner: 10Parent5446) [20:54:09] bawolff: How can I test https://gerrit.wikimedia.org/r/80232 ? [20:54:31] Also if you could look at the big patch to BetaFeatures, apparently Jared wants to get that out sooner rather than later -.- [20:55:28] marktraceur: You can test by adjusting the number of images, until you get something where the last row doesn't have enough images to fill it [20:55:54] (03PS1) 10Manybubbles: Merge redirect updates with title updates. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81126 [20:56:16] marktraceur: you mean https://gerrit.wikimedia.org/r/#/c/76198/ ? [20:56:22] Aha [20:56:24] Uhh [20:56:30] Yes [20:56:41] ok [20:56:46] (03CR) 10MarkTraceur: [C: 032] "Hawt" [core] - 10https://gerrit.wikimedia.org/r/80232 (owner: 10Brian Wolff) [20:57:10] (03PS11) 10Yuvipanda: Add API to query campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 [20:57:39] oh dear god [20:57:44] what a mess [20:57:45] There are some design followup things, but yeah [20:57:46] * YuviPanda goes to cleanup git [20:57:57] YuviPanda: What mess? [20:58:06] marktraceur: I amended things to the wrong commit [20:58:29] Hah [20:59:22] brion: fixed and repushing [20:59:24] (03PS7) 10Yuvipanda: Add an index to the campaign_enabled field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80783 [20:59:25] (03PS12) 10Yuvipanda: Add API to query campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 [20:59:32] marktraceur: however, git being awesome, it was trivially recoverable :D [20:59:37] with just more rebasing, editing, and what not [20:59:42] Woot [21:00:32] (03PS1) 10Aude: Update Wikibase with fix for get entities api module [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81127 [21:01:02] (03CR) 10Mattflaschen: "It might also make sense to set it to 0 when there's no valid revision ID for the current view, like 'wgCurRevisionId' and 'wgArticleId' a" [core] - 10https://gerrit.wikimedia.org/r/81032 (owner: 10Parent5446) [21:01:44] Ryan_Lane: can you comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=52058 please ? :D [21:02:05] (03PS2) 10Rachel99: WIP VE numbering, bullets, indent, outdent scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80664 [21:02:21] (03PS1) 10Ori.livneh: Rename '$wgStreamLoggers' => '$wgRCEngines' [core] - 10https://gerrit.wikimedia.org/r/81128 [21:02:48] (03CR) 10Brion VIBBER: "API output doesn't include the names of the campaigns, so it's going to be tough to use them. :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 (owner: 10Yuvipanda) [21:04:30] (03CR) 10Tychay: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/64620 (owner: 10Matthias Mullie) [21:05:00] andre__, if you have time can you please create https://bugzilla.wikimedia.org/show_bug.cgi?id=53371 ? I have some bug reports waiting. Thanks! [21:05:37] (03PS13) 10Yuvipanda: Add API to query campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 [21:05:47] (03CR) 10Brion VIBBER: [C: 04-1 V: 04-1] "Adding index uw_campaigns_enabled to table uw_campaigns ...A database query syntax error has occurred." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80783 (owner: 10Yuvipanda) [21:05:54] qgil, default CC? [21:06:26] you? [21:06:43] (03CR) 10EBernhardson (WMF): "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81018 (owner: 10EBernhardson (WMF)) [21:09:45] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase with fix for get entities api module [core] (wmf/1.22wmf14) - 10https://gerrit.wikimedia.org/r/81127 (owner: 10Aude) [21:10:58] andre__, acs@bitergia.com and myself [21:11:23] qgil, here you go. [21:11:31] andre__, thanks! [21:12:07] (03PS8) 10Yuvipanda: Add an index to the campaign_enabled field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80783 [21:12:08] (03PS14) 10Yuvipanda: Add API to query campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 [21:12:51] andre__, you also improved the Bugzilla metrics resolving FIXED less than 20 minutes after reporting ;) [21:13:15] qgil, hah! :D [21:13:23] (03CR) 10jenkins-bot: [V: 04-1] Add an index to the campaign_enabled field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80783 (owner: 10Yuvipanda) [21:13:39] jenkinsbot?! [21:13:52] (03PS9) 10Matthias Mullie: Make it slightly easier for extensions to hook into page protection. [core] - 10https://gerrit.wikimedia.org/r/64620 [21:14:00] Womp womp [21:14:04] (03CR) 10Matthias Mullie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/64620 (owner: 10Matthias Mullie) [21:14:56] (03Merged) 10jenkins-bot: Make last row of new gallery not be huge. [core] - 10https://gerrit.wikimedia.org/r/80232 (owner: 10Brian Wolff) [21:16:45] (03PS9) 10Yuvipanda: Add an index to the campaign_enabled field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80783 [21:16:46] (03PS15) 10Yuvipanda: Add API to query campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 [21:17:36] (03CR) 10Spage: [C: 032] "OK, I recreated centralauth and with this patch I get no errors following the SQL steps in https://www.mediawiki.org/wiki/Extension:Centra" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80325 (owner: 10Mattflaschen) [21:18:00] (03Merged) 10jenkins-bot: Cache a variable locally before it is reset on the instance [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/80325 (owner: 10Mattflaschen) [21:19:04] (03CR) 10Brion VIBBER: [C: 032] "Ok this version works :D" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80783 (owner: 10Yuvipanda) [21:19:04] (03Merged) 10jenkins-bot: Add an index to the campaign_enabled field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80783 (owner: 10Yuvipanda) [21:19:22] Yay! A YuviPatch! [21:20:25] (03PS2) 10Cmcmahon: Fix Cucumber/Watir/Cheezy locator for edit_ve [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80709 (owner: 10Spage) [21:22:23] (03CR) 10Cmcmahon: "What about if we use :title instead? It's less fragile than an indexed link under a parent element I think, and has the advantage of work" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80709 (owner: 10Spage) [21:30:42] (03PS3) 10Cmcmahon: Fix Cucumber/Watir/Cheezy locator for edit_ve [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80709 (owner: 10Spage) [21:45:11] (03PS2) 10Manybubbles: Merge redirect updates with title updates. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81126 [21:47:24] (03PS1) 10Manybubbles: Stop tests from poisoning subsequent runs. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81134 [21:47:37] (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80705 (owner: 10Rahul21) [21:48:53] (03PS1) 10Shirayuki: Rename message & Fix comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81135 [21:50:54] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] Rename message & Fix comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81135 (owner: 10Shirayuki) [21:51:42] (03CR) 10Shirayuki: "Thanks for quick response." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81135 (owner: 10Shirayuki) [21:53:11] (03CR) 10Ori.livneh: [C: 032] Removing dependancy on SpecialDisambiguations since it's being axed. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/74103 (owner: 10Kaldari) [21:53:23] (03Merged) 10jenkins-bot: Removing dependancy on SpecialDisambiguations since it's being axed. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/74103 (owner: 10Kaldari) [21:57:25] (03CR) 10MarkTraceur: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80705 (owner: 10Rahul21) [22:00:12] (03PS16) 10Yuvipanda: Add API to query campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 [22:03:16] (03Abandoned) 10Brian Wolff: Follow-up db51c53b8f. Fix already used variable name. [core] (wmf/1.22wmf13) - 10https://gerrit.wikimedia.org/r/80043 (owner: 10Brian Wolff) [22:03:18] (03CR) 10Tychay: [C: 032 V: 032] "LGTM. I'm not sure the value of the refactor, but doUpdateRestrictions() was impossibly wrong, so it's added to the readability." [core] - 10https://gerrit.wikimedia.org/r/64620 (owner: 10Matthias Mullie) [22:03:33] (03CR) 10Mattflaschen: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80705 (owner: 10Rahul21) [22:03:57] (03CR) 10Tychay: "I meant impossibly "long" not "wrong"… or perhaps that was a Freudian slip? :-)" [core] - 10https://gerrit.wikimedia.org/r/64620 (owner: 10Matthias Mullie) [22:05:29] (03CR) 10Matthias Mullie: "Removed -1, since the dependency in core has been merged." [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/64621 (owner: 10Matthias Mullie) [22:07:31] (03CR) 10MarkTraceur: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [22:09:49] chrismcmahon, did you see my email proposing September 18 for the workshop? Any comments? [22:10:07] qgil: I think that should be fine [22:10:30] chrismcmahon, announce or wait? [22:11:56] qgil: how about wait until after ECT tomorrow? [22:12:57] chrismcmahon, fine, just let me know [22:13:56] marktraceur: btw, in testing uploadwizard, it seems to depend on mediawiki.api.titleblacklist (which is not part of core) without mentioning that requirement on the extension page [22:15:06] bawolff: Does it? I don't think it's required... [22:15:19] * marktraceur checks [22:15:32] oh wait [22:15:43] It only enables it if titleblacklist is installed [22:15:48] Yeah [22:16:01] Scared me there :) [22:16:02] my copy of title blacklist was from before that module was created [22:16:13] so the check passed, even though the module wasn't registered [22:16:22] Ah. [22:16:26] * bawolff runs git pull on a couple of extensions [22:16:29] Maybe a version check or someething [22:16:33] sorry for the false alarm [22:17:00] bawolff: You've got a bunch o' merged patches now, and I'm gonna work on...hm. I guess fixing BF bugs. [22:17:13] (03CR) 10Mattflaschen: "Okay, Jared also has no problem with this. It looks like the consensus is it's okay to flip this back, even though individual pages may f" [core] - 10https://gerrit.wikimedia.org/r/78408 (owner: 10Matmarex) [22:17:16] Thanks for merging the patches [22:17:20] (03CR) 10Brion VIBBER: [C: 032] "Ok this seems to work... let's try it" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 (owner: 10Yuvipanda) [22:17:25] (03Merged) 10jenkins-bot: Add API to query campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80782 (owner: 10Yuvipanda) [22:30:20] (03CR) 10Cmcmahon: [C: 032 V: 032] Headings test scenarios completed [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80483 (owner: 10Rachel99) [22:31:54] (03CR) 10EBernhardson (WMF): [C: 031] "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80710 (owner: 10Legoktm) [22:32:48] Yippie, build fixed! [22:32:49] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #169: FIXED in 9 min 28 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/169/ [22:33:55] (03CR) 10Asher: [C: 04-1] "Given the worst case time of this parserfunction on larger wmf wikis, I'm opposed to adding it in the current form. Can we selectively en" [core] - 10https://gerrit.wikimedia.org/r/66003 (owner: 10Parent5446) [22:34:13] (03PS1) 10MarkTraceur: Fix bug in closure patch [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81140 [22:34:16] bawolff: ^^ [22:34:58] /whois is charge of download.wikimedia.org? [22:35:20] saper: I think apergos used to be. not sure if still is [22:35:26] marktraceur: testing [22:35:27] bawolff: thanks [22:36:11] apergos: would that be possible to ask for a dump of a small wiki (plwikimedia) do be done daily, not every few days (this is to fulfill some legal requirements related to Polish chapter donations) [22:36:51] greg-g: are you shepherding HTTPS? I think I found a bug, 53379 [22:37:10] marktraceur: confirmed, that patch fixes the issues I saw [22:37:26] (03CR) 10Demon: [C: 032] Merge redirect updates with title updates. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81126 (owner: 10Manybubbles) [22:37:27] Yup [22:37:28] (03Merged) 10jenkins-bot: Merge redirect updates with title updates. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81126 (owner: 10Manybubbles) [22:37:37] bawolff: I *knew* that was gonna cause trouble [22:37:45] bawolff: https://bugzilla.wikimedia.org/show_bug.cgi?id=47618 [22:37:49] djvu sucks btw [22:37:50] (03CR) 10Demon: [C: 032] Stop tests from poisoning subsequent runs. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81134 (owner: 10Manybubbles) [22:37:52] (03Merged) 10jenkins-bot: Stop tests from poisoning subsequent runs. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81134 (owner: 10Manybubbles) [22:37:59] YuviPanda asked me to reorder the closure arguments and boom, there it is [22:38:44] (03CR) 10EBernhardson (WMF): [C: 032 V: 032] When changing AFT visibility in action=protect, add to log [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/64621 (owner: 10Matthias Mullie) [22:38:45] (03CR) 10jenkins-bot: [V: 04-1] When changing AFT visibility in action=protect, add to log [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/64621 (owner: 10Matthias Mullie) [22:38:48] marktraceur: :P [22:39:39] it's all my fault [22:39:39] yes [22:39:59] (03CR) 10Brian Wolff: [C: 032] "I can confirm that upload wizard works again after this patch" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81140 (owner: 10MarkTraceur) [22:40:02] (03Merged) 10jenkins-bot: Fix bug in closure patch [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81140 (owner: 10MarkTraceur) [22:40:33] (03PS3) 10MarkTraceur: Add portlet link to Beta Features pref section [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/77074 [22:40:44] YuviPanda: It usually is [22:40:47] But we forgive you :) [22:40:59] and punish me with M&Ms? [22:41:27] (03CR) 10Cmcmahon: [C: 032] make steps not DRY to get around dumb ChromeDriver bug [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80486 (owner: 10Cmcmahon) [22:42:04] (03PS1) 10Mwjames: [DIC]: @var type-hinting, /dic/README.mediawiki -> /dic/README.md [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81141 [22:42:22] marktraceur: How come my only choice of language in upload wizard is "Boarisch"? [22:42:25] (03CR) 10Cmcmahon: [C: 032] WIP Refactor VE headings scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79794 (owner: 10Rachel99) [22:42:29] (03PS12) 10Matthias Mullie: When changing AFT visibility in action=protect, add to log [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/64621 [22:43:02] (03CR) 10Matthias Mullie: [C: 032] "Rebased" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/64621 (owner: 10Matthias Mullie) [22:43:05] (03Merged) 10jenkins-bot: When changing AFT visibility in action=protect, add to log [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/64621 (owner: 10Matthias Mullie) [22:43:32] Mostly it's easier for me to forgive YuviPanda than it is to forgive myself, hence, his fault [22:43:39] (03CR) 10Demon: "Needs a manual rebase, but otherwise ok." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/80021 (owner: 10Manybubbles) [22:43:52] bawolff: Probably because no other language templates exist on your wiki :) [22:44:18] Oh. yeah, that would make sense [22:44:25] I guess you have Template:Bar [22:44:39] Hilaaarious [22:44:40] That sounds likely [22:44:50] I added Template:En, I think [22:45:00] {{foo}} doesn't correspond to a language code? that's a shame [22:45:16] That would be nice [22:45:34] Maybe we can make it the ISO code for C or something [22:48:09] ^d: gerrit is giving me 503 [22:48:12] who killed gerrit? [22:48:21] <^d> I just !log'd it in -operations. [22:48:29] <^d> Had to restart. [22:48:33] kk [22:50:18] (03CR) 10EBernhardson (WMF): [C: 031] "I'm ok with it, but also not that familiar with frontend" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/77824 (owner: 10Matmarex) [22:51:07] (03Abandoned) 10Spage: Towards OB6: show a popup CTA to test onboarders [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/79976 (owner: 10Spage) [22:56:28] (03PS2) 10EBernhardson (WMF): Flow: Implement initial notifications for edit/rename/reply/newtopic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/80514 (owner: 10Werdna) [22:56:58] (03CR) 10Parent5446: [C: 032] Rename '$wgStreamLoggers' => '$wgRCEngines' [core] - 10https://gerrit.wikimedia.org/r/81128 (owner: 10Ori.livneh) [22:58:28] (03PS1) 10Cmcmahon: Merge "WIP Refactor VE headings scenarios" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81146 [23:01:05] (03Merged) 10jenkins-bot: Rename '$wgStreamLoggers' => '$wgRCEngines' [core] - 10https://gerrit.wikimedia.org/r/81128 (owner: 10Ori.livneh) [23:03:33] (03PS1) 10MarkTraceur: Throw errors if required fields missing [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/81147 [23:04:41] (03Abandoned) 10Cmcmahon: Merge "WIP Refactor VE headings scenarios" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81146 (owner: 10Cmcmahon) [23:09:43] (03CR) 10Mattflaschen: [C: 04-1] "(4 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [23:10:06] (03CR) 10Ryan Lane: "(4 comments)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/55287 (owner: 10Wikinaut) [23:11:46] (03CR) 10Mattflaschen: "You should use update.php (https://www.mediawiki.org/wiki/Manual:Update.php) when manually verifying. You might need to drop the column m" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [23:11:55] anyone know why the parser would start throwing magic word errors on a development host? http://i.imgur.com/QFoA1q7.png : Original exception: exception 'MWException' with message 'Error: invalid magic word 'int'' in /vagrant/mediawiki/includes/MagicWord.php:315 [23:11:58] (03CR) 10Brian Wolff: [C: 031] "I've tested this, and it does not appear to introduce any regressions. I've also looked it over, and it looks sane, but I'm really not a j" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80523 (owner: 10MarkTraceur) [23:12:10] bawolff: Thanks :) [23:12:11] i'm not working on anything in the parser, it just decided to start throwing up on me while owkring on something else :S [23:12:29] bawolff: If you'd like to look over the BetaFeatures business, that's probably more up your alley anyway :) [23:12:55] that's next on my list [23:13:03] (03Abandoned) 10Ryan Lane: puppetsigner: remove unused 'pwd' module [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81009 (owner: 10Hashar) [23:13:20] bawolff: If you have anything else, I've got time [23:13:47] sorry for the only +1, but I'm thinking I probably shouldn't be +2 ing javascript style changes when I'm really not that familar with the javascript side of things [23:14:38] I have some odds and ends like https://gerrit.wikimedia.org/r/#/c/78468/ [23:15:25] (03PS1) 10Ryan Lane: Remove scripts/config that are mainted in puppet [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81151 [23:15:28] (03PS1) 10Aaron Schulz: Avoid double-parse on edit regression due to content handler [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/81152 [23:15:56] oh, and https://gerrit.wikimedia.org/r/#/c/80678/ [23:16:03] (03Abandoned) 10Ryan Lane: homedirectorymanager: nicer comparison [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81008 (owner: 10Hashar) [23:16:21] (03Abandoned) 10Ryan Lane: fix up harmless pep8 errors [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81006 (owner: 10Hashar) [23:16:53] (03Abandoned) 10Ryan Lane: pep8 / flake8 configuration [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81005 (owner: 10Hashar) [23:16:57] and maybe https://gerrit.wikimedia.org/r/#/c/80311/ [23:17:21] (03Abandoned) 10Ryan Lane: Fix undefined $project [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/80565 (owner: 10Reedy) [23:17:37] (03Restored) 10Ryan Lane: Fix undefined $project [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/80565 (owner: 10Reedy) [23:19:46] (03CR) 10Ryan Lane: [C: 032] Fix undefined $project [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/80565 (owner: 10Reedy) [23:19:48] (03Merged) 10jenkins-bot: Fix undefined $project [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/80565 (owner: 10Reedy) [23:20:42] (03CR) 10Ryan Lane: [C: 032 V: 032] Fix variable typo $kewRow -> $keyRow [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/80564 (owner: 10Reedy) [23:20:48] (03CR) 10Brion VIBBER: "(7 comments)" [core] - 10https://gerrit.wikimedia.org/r/52922 (owner: 10Victor Vasiliev) [23:23:20] (03CR) 10Mattflaschen: "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [23:24:00] Augh, reviewing messages files [23:25:53] (03PS1) 10Yuvipanda: API output should give parsed config, not raw config [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81155 [23:26:02] brion: ^ [23:26:33] YuviPanda: looking [23:26:40] (03PS14) 10Brian Wolff: Allow listing old files in Special:ListFiles. Add Special:AllMyUploads [core] - 10https://gerrit.wikimedia.org/r/60088 [23:27:12] brion: is there a way to do uselang or something for the API, by default? [23:27:22] (03CR) 10Brian Wolff: "Whoo!" [core] - 10https://gerrit.wikimedia.org/r/60088 (owner: 10Brian Wolff) [23:27:30] YuviPanda: hmmm, uselang might actually work [23:27:40] but i'm not sure [23:28:05] (03CR) 10Brion VIBBER: [C: 032] API output should give parsed config, not raw config [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81155 (owner: 10Yuvipanda) [23:28:14] (03Merged) 10jenkins-bot: API output should give parsed config, not raw config [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81155 (owner: 10Yuvipanda) [23:29:12] YuviPanda: api requests should be language independent…. [23:29:39] legoktm: how does parse handle {{#int:}} ? [23:29:51] er, what do you mean? [23:30:19] you shouldn't really be using messages in api output [23:30:40] legoktm: hmm? [23:30:53] what were you thinking of using uselang for? [23:31:06] legoktm: Campaign metadata retreival. [23:31:12] legoktm: they use Mediawiki: messages for labels and such [23:31:53] do you have an example? isn't the API just returning the value of https://commons.wikimedia.org/w/index.php?title=Campaign:Wikimania2013&action=edit for example? [23:32:55] legoktm: right now it is, yes. [23:33:08] legoktm: that's the idea of a *parsed* api return value. [23:33:14] legoktm: which will parse the wikitext [23:33:28] parse it and return...what? [23:33:36] (03CR) 10MarkTraceur: [C: 032] "LGTM, seems like a helpful little feature, thanks bawolff" [core] - 10https://gerrit.wikimedia.org/r/78468 (owner: 10Brian Wolff) [23:33:55] legoktm: if you look at that page, you'll notice display.headerLabel [23:33:57] (03CR) 10jenkins-bot: [V: 04-1] Add optional message to define default description for Upload [core] - 10https://gerrit.wikimedia.org/r/78468 (owner: 10Brian Wolff) [23:33:59] legoktm: that's a piece of wikitext [23:34:10] yes. [23:34:11] legoktm: when parsed, it'll return the parsed content of that piece of wikitext, which will be in... HTML? [23:34:24] jenkins-bot is a real buzz kill :P [23:34:31] so display.headerLabel will be HTML in the parsed version, rather than raw wikitext [23:34:34] ohhhh [23:34:41] i see. [23:34:52] i suppose uselang would work then [23:34:56] marktraceur: I'm rebasing that [23:35:02] while some other things - such as autoAdd.wikitext, will be just wikitext [23:35:07] legoktm: :D, yeah [23:35:42] bawolff: K, no rush [23:35:51] (03PS4) 10Aaron Schulz: Make thumb.php give http redirects if given a file redirect [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff) [23:35:53] not sure if you can use uselang itself, maybe just do a uclanguage or something [23:36:10] legoktm: yeah, I was hoping there's something I can piggy back on [23:36:24] (03PS2) 10Brian Wolff: Add optional message to define default description for Upload [core] - 10https://gerrit.wikimedia.org/r/78468 [23:36:43] (03CR) 10MarkTraceur: [C: 032] "Looks good apart from my refactor senses beginning to tingle." [core] - 10https://gerrit.wikimedia.org/r/80678 (owner: 10Brian Wolff) [23:36:46] (03PS3) 10Parent5446: Add wgRevisionId variable to ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/81032 [23:36:55] * bawolff 's patches are just getting all sorts of love today [23:36:58] * marktraceur makes bawolff's life hard by piling up needs-rebase patches :) [23:37:11] bawolff: Good way to close out the summer! [23:38:06] marktraceur: which part specifically caused refactor tingleness? [23:38:37] The patch's two files both looked like they got the same changes [23:39:01] And they're both similar in nature..."view a group of images" seems like the sort of generalizable experience we could make a class for [23:39:23] (03CR) 10MarkTraceur: [C: 032] "Almost trivial, but helpful, thanks again bawolff" [core] - 10https://gerrit.wikimedia.org/r/80311 (owner: 10Brian Wolff) [23:39:25] hmm, true. I guess a method in image gallery that was more "use this mode or default if invalid" would make more sense [23:39:44] Maybe [23:39:58] (The language patch I thought was pretty pointless, but the translatewiki people told me to) [23:40:12] Though seriously it seems like "bunch of images on a page" is something we could refactor out a bit [23:40:14] Anyway [23:40:20] legoktm: lololol, uselang= works with the API [23:40:20] but [23:40:22] bawolff: I actually like it a lot better [23:40:27] I also get,
Unrecognized parameter: 'uselang'
[23:40:28] :D [23:40:32] heh, yeah. [23:40:38] also, eww xml :< [23:40:52] yeah, yeah yeah [23:41:45] YuviPanda: The uselang stuff gets set up before the api validates parameters [23:41:53] There's a couple modules that override the warning [23:42:03] it still wfm, so I'm going to let it be [23:42:16] my sense of 'eewww, this is not clean!' has been completely shot to death [23:42:17] I think I filed a bug once upon a time saying that the error should be less confusing on that point [23:42:19] by mediawiki API in general [23:42:20] so [23:42:21] (03Merged) 10jenkins-bot: Add url parameter to trigger autogenerated gallery type. [core] - 10https://gerrit.wikimedia.org/r/80678 (owner: 10Brian Wolff) [23:42:31] doesn't really bother me [23:42:50] I think it was at setIndexedTagname_internal that the sense of code cleanliness died [23:42:52] RIP [23:42:58] The disgusting part is, even the modules that support uselang, also support variant, but don't document it [23:43:18] YuviPanda: That's not cause for it dying, that's cause for you being mad as hell and not taking it anymore [23:43:44] YuviPanda: Come on, do it with me. Get up off the couch, go to the window, fling it open, and yell: I'm mad as hell, and I'm not going to take it anymore. [23:44:22] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff) [23:44:37] marktraceur: heh [23:44:52] marktraceur: all power to yurik to get us out of this mess? :) [23:44:56] (03CR) 10Aaron Schulz: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80135 (owner: 10Brian Wolff) [23:45:28] (03Merged) 10jenkins-bot: Change wording on message per feedback from translatewiki. [core] - 10https://gerrit.wikimedia.org/r/80311 (owner: 10Brian Wolff) [23:45:46] marktraceur: brion merged my last patch in under 3-4 mins, and it was just a single patchset. Not bad, I think :) [23:45:50] and it even actually works! [23:46:23] Wow! [23:46:31] (03PS1) 10Kaldari: Adding allunread param to API for retrieving all unread messages (up to $wgEchoMaxNotificationCount) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81157 [23:46:41] I would thank him, but alas, he not here [23:47:22] (03PS2) 10Ori.livneh: Add 'RedisPubSubFeedEngine' feed engine [core] - 10https://gerrit.wikimedia.org/r/80958 [23:47:31] (03CR) 10Brian Wolff: "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 (owner: 10MarkTraceur) [23:48:20] (03CR) 10Ori.livneh: "PS2 updates the patch to reflect the config var name changes introduced in I0d7b08e59." [core] - 10https://gerrit.wikimedia.org/r/80958 (owner: 10Ori.livneh) [23:56:28] (03PS8) 10MarkTraceur: Use the new feature field [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 [23:56:29] bawolff: Yes master [23:56:44] (03CR) 10Brian Wolff: "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 (owner: 10MarkTraceur) [23:57:35] bawolff: Are you doing one comment at a time? [23:58:10] marktraceur: I just missed that the first time around, that's the last comment [23:58:22] Ah, K [23:58:36] (03PS9) 10MarkTraceur: Use the new feature field [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 [23:58:40] {{done}}