[00:00:27] marktraceur: wazzup? [00:03:11] bd808: I read your Web site the other day. [00:03:15] I really liked it. [00:03:36] cool! bd808.com? [00:03:40] Yeah. [00:03:42] I'm a bad blogger [00:03:45] Not sure I looked at the blog. [00:03:46] Heh. [00:03:49] I liked the main page. [00:03:49] 1 post per year [00:04:04] (03PS1) 10Mattflaschen: Exclude upstream OKFN from jshint [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/81882 [00:04:23] Oh, actually, yes I did click this. [00:04:29] I liked the github.com/will link. [00:04:31] I starred it. [00:04:37] That's silly, but adorable. [00:05:04] https://github.com/will [00:05:27] His site is more amusing than yours. ;-) http://bitfission.com/ [00:05:35] hmm, is anything other than $wgProfiler['class'] = 'Profiler'; needed these days to get profiling info in debug log? [00:07:32] ha! I'd forgotten about his l33t 1997 homepage [00:07:56] I can't tell if the "please don't steal" line is ironic. [00:08:09] I've been thinking about it for a few minutes now. [00:08:21] I checked the page source for clues. [00:08:24] marktraceur: ping [00:08:31] marktraceur: thoughts on ways to make two divs equal height? [00:08:38] marktraceur: I could use JS... [00:08:50] marktraceur: or... http://stackoverflow.com/a/2997838/17865 [00:09:15] I also enjoyed https://github.com/will/redirect_blame [00:09:33] YuviPanda: I'd need to know...more [00:09:54] marktraceur: http://blue-dragon.wmflabs.org/wiki/Campaign:show-off-campaigns [00:10:14] marktraceur: i'm trying to make the CTA and the title/description same height, and next to each other [00:10:18] than put the CTA all the way to the rightr [00:12:19] YuviPanda: Do you mean "same height" or "on the same line"? [00:12:30] marktraceur: same height, next to each other? [00:12:43] marktraceur: oh dear, I also realized I'd want to make the button to be vertically centered. [00:12:55] * YuviPanda considers giving up on that [00:13:19] YuviPanda: They don't need to be the same height, their contents have different heights [00:13:43] marktraceur: idea is to make them as tall as the largest [00:13:46] err [00:13:48] tallest [00:14:13] Right, but that will happen automatically [00:14:25] marktraceur: hmm? [00:14:32] marktraceur: any idea how I could do that? [00:14:54] What's https://bugzilla.wikimedia.org/show_bug.cgi?id=49090 about? [00:15:19] YuviPanda: Can you *draw* what you mean, maybe? [00:17:01] (03CR) 10Parent5446: [C: 032] Exclude upstream OKFN from jshint [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/81882 (owner: 10Mattflaschen) [00:17:04] (03Merged) 10jenkins-bot: Exclude upstream OKFN from jshint [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/81882 (owner: 10Mattflaschen) [00:20:10] marktraceur: Thanks! it was nice to meet you. bye now. [00:24:10] yhager: Going somewhere? [00:25:17] marktraceur: ah, hmm. sorry, didn't see this, was lost in bugzilla drama. [00:25:25] marktraceur: maybe. let me try. [00:25:43] K [00:25:56] Trying to explain concepts of CSS isn't really simple with words [00:31:14] I find it helps to show people with a Web browser. [00:31:19] In Firefox, you can disable styles pretty easily. [00:31:30] Allowing people to see the HTML markup/content without CSS. [00:31:44] (03PS1) 10Krinkle: resourceloader: Support hashes as cache invalidation trigger [core] - 10https://gerrit.wikimedia.org/r/81884 [00:31:56] (03PS2) 10Krinkle: resourceloader: Support hashes as cache invalidation trigger [core] - 10https://gerrit.wikimedia.org/r/81884 [00:32:24] (03CR) 10Krinkle: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/81884 (owner: 10Krinkle) [00:32:42] RoanKattouw: ^ [00:33:05] (03CR) 10Krinkle: "Add "New feature" release notes before merging." [core] - 10https://gerrit.wikimedia.org/r/81884 (owner: 10Krinkle) [00:33:30] Elsie: Yeah, but we want to talk about how the CSS will look [00:33:36] Plus, YuviPanda isn't in this city, so [00:36:02] Yay :) [00:43:25] marktraceur: I thought you meant "explain concepts" to beginners. [00:43:38] I try to explain CSS to people occasionally. [00:43:50] It helps to have visual aids. [00:44:09] marktraceur: I tried to draw things and gave up. [00:44:56] (03CR) 10BryanDavis: [C: 032] Add portlet link to Beta Features pref section [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/77074 (owner: 10MarkTraceur) [00:49:22] YuviPanda: That's pretty crazy [00:49:37] marktraceur: i was trying to draw them on the computer [00:49:49] YuviPanda: Does that mean you had trouble putting it into a picture, or you weren't happy with how the drawings turned out? [00:49:50] (03PS2) 10Mollywhite: Bug 53431: Adjust so clicking "remove" on new sections removes them. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81411 [00:50:09] (03CR) 10BryanDavis: [C: 04-1] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/81147 (owner: 10MarkTraceur) [00:50:11] marktraceur: no, just that GIMP was frustrating and horrible? [00:51:10] ....damn, bd808, you got me thereu [00:51:25] YuviPanda: Well...damn, Jackie [00:51:56] I'm | | this close to going to dinner [00:52:10] || close now [00:52:11] BRB [00:52:30] marktraceur: ok! eat well! [00:54:22] (03PS3) 10Mollywhite: Bug 53431: Adjust so clicking "remove" on new sections removes them. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81411 [01:02:26] [01:23:23] (03CR) 10Yuvipanda: [C: 04-1] "Output I see in English is 'You can re-enable this tutorial in your user preferences, under Uploads → User interface'." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81675 (owner: 10Rillke) [01:26:06] [01:26:26] YuviPanda: Want to take another crack at explaining this problem to me? [01:27:08] marktraceur: http://stackoverflow.com/questions/1056212/how-do-i-achieve-equal-height-divs-with-html-css [01:27:16] marktraceur: i want the same thing [01:27:44] marktraceur: specifically, look at the screenshot at http://stackoverflow.com/a/1059435/17865 [01:28:27] YuviPanda: But you aren't styling both of the divs, and surely you don't want the CTA div to get huge if the campaign description does [01:28:43] marktraceur: hmm, that is a good point, yes. [01:28:51] marktraceur: but I don't like where the CTA is now (right) [01:29:11] marktraceur: this sounded like a good idea, but yes, descriptions are probably going to get a lot bigger... [01:30:22] YuviPanda: OK, where do you want it? [01:30:44] marktraceur: i... am not sure anymore :| [01:30:48] marktraceur: under the description, perhaps? [01:31:02] That sounds like it would look weird [01:31:14] Unless you centered both [01:31:20] Which I'm pretty sure you don't want to do [01:31:30] Maybe ask a designer? [01:31:43] Or did they give you feedback that led to you wanting to move the CTA?+ [01:31:44] Designers [01:31:44] Designers [01:31:45] Designers [01:31:46] Designers [01:31:46] Designers [01:32:25] marktraceur: well, I started a thread on the design list [01:32:42] marktraceur: it was Steven Walling's feedback to move it elsewhere. [01:32:52] marktraceur: and yes, it will look weird under teh description [01:33:06] marktraceur: Jared responded that the design team is overloaded and won't be able to help much, which I understand [01:33:22] Reedy: All UX designers, all UX designers...if you liked it then you should've used Helvetica, if you liked it then you should've used Helvetica [01:33:52] marktraceur: I'm knocking around to see if I could get design help elsewhere, let's see how that goes [01:34:52] YuviPanda: Well, where did StevenW suggest you move it? [01:35:16] marktraceur: equal height divs, right next to each other. [01:35:28] marktraceur: which is why I was trying to figure out equal height divs [01:35:38] but then you mentioned desc can be arbitrary heights [01:36:03] (03CR) 10Mattflaschen: [C: 04-1] "(11 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/79839 (owner: 10Rjain) [01:38:21] Yeah, that makes the concept a little silly [01:38:31] Maybe he'll respond at some point [01:38:50] marktraceur: probably. [01:39:19] marktraceur: i'm still investigating the Squid stuff, and the immense amount of energy Romaine spent in trying to get me to stop doing this patch seems to be working as well. [01:39:21] so meh. [01:39:42] marktraceur: do you have any thoughts on where to put it, but? [01:40:29] I think it's fine how it is [01:41:19] marktraceur: hmmm [01:42:27] marktraceur: yeah, if no new design pops up I'm fine with it as is, I guess [01:42:35] marktraceur: now to figure out squid... :) [01:43:37] marktraceur: btw, I'm reviewing https://gerrit.wikimedia.org/r/#/c/80058/ now [01:44:00] marktraceur: think you can rebase it? [01:44:06] (needs manual rebase) [01:46:33] * marktraceur grumbles loudly [01:46:37] YuviPanda: Will do [02:01:45] (03PS3) 10MarkTraceur: Stop using mw.msg [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80058 [02:01:53] YuviPanda: {{done}} [02:01:57] Mostly conflicts with jshint fixes [02:02:00] Which is...great [02:02:02] * YuviPanda re-downloads [02:03:07] * YuviPanda restarts reviewing [02:03:38] marktraceur: unrelated to the patch [02:03:39] but [02:03:39] - $container.append( $( '' + settings.buttontext + '' ) [02:03:46] href="javascript:" [02:03:49] ?! [02:03:51] (03PS1) 10Reedy: Use array_merge [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81887 [02:03:53] whhyyy [02:04:05] Ugh.. I agree YuviPanda [02:04:53] What's the issue...? [02:05:01] Apart from jshint complaining [02:05:16] I guess jshint complains for a reason [02:05:18] but nevermind [02:05:22] * YuviPanda goes back to CR [02:05:33] Well, I didn't know what else to put there [02:05:39] # seems a little stupid [02:07:04] Would someone like to CR/merge 81887? Relatively simple: php sucks [02:07:51] http://stackoverflow.com/questions/13497971/what-is-the-matter-with-script-targeted-urls [02:07:52] Reedy: looking [02:07:56] In order to execute the javascript: URL, the browser must fire up a JS parser and parse the text of the URL. [02:08:00] This is a slow and costly process. [02:08:02] OK, noted [02:08:12] apparently array() + array() doesn't do what you think it might [02:08:15] I will entertain that notion, and maybe fix it up [02:08:31] (03PS1) 10Bsitu: Jobs should be inserted to job queue on transactionIdle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81888 [02:09:55] Reedy: array() + array() actually does a merge, while array_merge is actually append [02:09:58] (not counting assoc arrays0 [02:09:59] ) [02:10:34] (03PS1) 10Physikerwelt: Merge: Expose LaTeXML Settings [extensions/Math] (LaTeXML) - 10https://gerrit.wikimedia.org/r/81889 [02:10:36] (03CR) 10jenkins-bot: [V: 04-1] Merge: Expose LaTeXML Settings [extensions/Math] (LaTeXML) - 10https://gerrit.wikimedia.org/r/81889 (owner: 10Physikerwelt) [02:10:45] (03PS2) 10Yuvipanda: Use array_merge [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81887 (owner: 10Reedy) [02:11:05] Reedy: it's a maintenance script, and it looks sane enough. [02:11:17] It's already running on the cluster ;) [02:11:28] (03CR) 10Yuvipanda: [C: 032] "Looks sane." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81887 (owner: 10Reedy) [02:11:30] (03Merged) 10jenkins-bot: Use array_merge [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81887 (owner: 10Reedy) [02:11:32] Reedy: yeah, figured :) [02:11:42] Reedy: done [02:11:53] Thanks [02:16:50] YuviPanda: I feel like...there's no review in my life [02:16:59] marktraceur: hmm? [02:17:22] i'm still looking at your patch, if that's what you meant. Gerrit sucks, plus I got distracted :P [02:20:57] (03CR) 10Yuvipanda: [C: 032] "Legit" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80058 (owner: 10MarkTraceur) [02:21:00] marktraceur: merged! [02:21:01] (03Merged) 10jenkins-bot: Stop using mw.msg [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/80058 (owner: 10MarkTraceur) [02:21:48] (03CR) 10Yuvipanda: "Needs manual rebasing." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 (owner: 10MarkTraceur) [02:27:47] YuviPanda: Curse you and your voice of reason [02:27:57] I will rebase it tomorrow [02:28:01] marktraceur: :P [02:28:04] I have karaoke to do in the very near future [02:28:07] marktraceur: yeah, yeah, it's fine [02:28:11] * marktraceur disappears for the evening [02:28:11] marktraceur: have fun! :) [02:28:14] Thankee! [02:39:17] (03PS2) 10Physikerwelt: Merge: Expose LaTeXML Settings [extensions/Math] (LaTeXML) - 10https://gerrit.wikimedia.org/r/81889 [02:40:05] (03CR) 10Physikerwelt: [C: 032] Merge: Expose LaTeXML Settings [extensions/Math] (LaTeXML) - 10https://gerrit.wikimedia.org/r/81889 (owner: 10Physikerwelt) [02:40:20] (03Merged) 10jenkins-bot: Merge: Expose LaTeXML Settings [extensions/Math] (LaTeXML) - 10https://gerrit.wikimedia.org/r/81889 (owner: 10Physikerwelt) [02:49:34] (03CR) 10Physikerwelt: "..mh" [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang) [02:51:43] (03PS1) 10Kaldari: Using protocol-relative URL for Flickr API [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81891 [02:52:20] (03CR) 10Yuvipanda: [C: 032] Using protocol-relative URL for Flickr API [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81891 (owner: 10Kaldari) [02:52:26] (03Merged) 10jenkins-bot: Using protocol-relative URL for Flickr API [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81891 (owner: 10Kaldari) [02:57:48] (03CR) 10AlephNull: "I'm not sure how this would slow down testing. The changes are very minimal, apply only to the MySQL subclass and address VIEWS." [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [03:21:44] What's the proper way to get a namespace name from id? I found MWNamespace::getCanonicalName but that only returns english... [03:22:04] I think its somewhere in the Language class [03:22:19] ok, ill look there. thanks! [03:23:12] $wgContLang->getNsText( $namespace ); [03:23:24] just found that :D [03:23:26] or possibly getGenderNsText [03:24:09] ok. getFormattedNsText looks like the right one for me [03:33:48] (03PS1) 10Physikerwelt: Merge master features [extensions/Math] (LaTeXML) - 10https://gerrit.wikimedia.org/r/81893 [03:35:37] (03CR) 10Physikerwelt: [V: 032] Merge master features [extensions/Math] (LaTeXML) - 10https://gerrit.wikimedia.org/r/81893 (owner: 10Physikerwelt) [03:35:57] (03CR) 10Physikerwelt: [C: 032] Merge master features [extensions/Math] (LaTeXML) - 10https://gerrit.wikimedia.org/r/81893 (owner: 10Physikerwelt) [03:41:16] (03PS1) 10Legoktm: [WIP] Display stats on preview of how many pages we are posting to [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81894 [03:41:27] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Display stats on preview of how many pages we are posting to [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81894 (owner: 10Legoktm) [03:42:42] (03CR) 10Legoktm: [C: 04-1] "Need a way to state that the list are namespaces, and that this is the delivery count." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81894 (owner: 10Legoktm) [03:43:13] (03PS2) 10Bsitu: Adding Echo jobs to deferred update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81888 [03:58:33] (03PS3) 10Mwjames: [DIC]: \SMW\JobBase implements \SMW\DependencyRequestor [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81449 [04:04:37] (03PS3) 10Bsitu: Adding Echo jobs to deferred update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81888 [04:04:51] (03CR) 10Bsitu: [C: 04-1] Adding Echo jobs to deferred update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81888 (owner: 10Bsitu) [04:05:31] (03CR) 10Bsitu: [C: 032] ext.echo.badge: Remove defunct CSS rule [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81502 (owner: 10Matmarex) [04:05:37] (03Merged) 10jenkins-bot: ext.echo.badge: Remove defunct CSS rule [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81502 (owner: 10Matmarex) [04:31:19] (03CR) 10Mattflaschen: [C: 04-1] "(8 comments)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/78251 (owner: 10Rjain) [05:23:42] Elsie: nice blame redirector :) [05:24:48] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #242: FAILURE in 5 min 12 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/242/ [05:47:57] (03CR) 10Mwalker: [C: 032] Bug 53431: Adjust so clicking "remove" on new sections removes them. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81411 (owner: 10Mollywhite) [05:48:08] (03Merged) 10jenkins-bot: Bug 53431: Adjust so clicking "remove" on new sections removes them. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/81411 (owner: 10Mollywhite) [05:59:57] Yippie, build fixed! [05:59:57] Project browsertests-test2.wikipedia.org-linux-firefox build #526: FIXED in 33 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/526/ [06:06:58] (03CR) 10Frédéric Wang: "I don't understand your problem. It seems that you haven't been able to make texvc work on your system and thus you are asking to not make" [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang) [06:15:31] (03CR) 10Frédéric Wang: "I haven't tested but that looks good to me. The only thing I wonder is whether there is some PHP library that allows to do the work of "se" [extensions/Math] - 10https://gerrit.wikimedia.org/r/75828 (owner: 10Physikerwelt) [06:19:49] (03CR) 10Frédéric Wang: "MathJax 2.3 is not released yet and I don't think that blocks that bug. Only STIX and TeX are available in MathJax v2.2, though. The next " [extensions/Math] - 10https://gerrit.wikimedia.org/r/64527 (owner: 10TheDJ) [06:21:01] (03CR) 10Aaron Schulz: [C: 032] Add frontier pattern (%f[set]) to ustring [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/63381 (owner: 10Anomie) [06:22:41] (03Merged) 10jenkins-bot: Add frontier pattern (%f[set]) to ustring [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/63381 (owner: 10Anomie) [06:40:14] (03PS8) 10Brian Wolff: Add "extended" file metadata to API to gather data from multiple sources [core] - 10https://gerrit.wikimedia.org/r/78926 [07:24:50] (03PS9) 10Rtdwivedi: Added the zoom library jquery-panzoom. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/79846 [07:24:51] (03PS30) 10Rtdwivedi: Display of page shifted to ProofreadPagePage class. [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/76891 [07:24:53] (03CR) 10Frédéric Wang: "I've opened an issue upstream:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang) [08:25:38] good morning [08:27:21] morning [08:28:17] heh [08:43:10] I am going to restart jenkins .. [08:43:50] (03CR) 10Rillke: "That's not my fault but https://bugzilla.wikimedia.org/show_bug.cgi?id=53576" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81675 (owner: 10Rillke) [08:51:29] hashar: is there another way to make jenkins re-check that submitting another patch set? [08:51:39] *than [08:51:45] it is restarting right ow [08:51:57] if you want to retry the lint checks you can post a comment saying 'recheck' [08:52:05] thanks [08:52:22] if there are unit tests being run, you got to send a new patchset, I usually do it by editing the commit summary [08:52:26] in the gerrit GUI [08:52:34] mhm [09:01:45] (03PS1) 10Rfaulk: add - git config docs. [sartoris] - 10https://gerrit.wikimedia.org/r/81900 [09:02:27] (03CR) 10Rfaulk: [C: 032 V: 032] add - git config docs. [sartoris] - 10https://gerrit.wikimedia.org/r/81900 (owner: 10Rfaulk) [10:10:23] Hello [10:10:31] Is someone already tried an installation of mediawiki with maintenance/install.php ? [10:10:40] When I execute install.php, nothing happens :( [10:12:53] nothing as...? [10:13:17] it should've created LocalSettings.php in current directory [10:14:14] Salazar: it definitely works, assuming you provide all the arguments [10:18:34] (03PS1) 10Wizardist: Fix be-tarask prepositional case [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/81903 [10:18:46] php maintenance/install.php --confpath '/var/www/html/wiki' --dbname 'wiki' --installdbuser 'root' --installdbpass 'test' --lang 'en' --scriptpath '/wiki' --pass 'test' 'Wiki Name' 'admin' [10:18:50] PHP 5.3.3 is installed. [10:19:14] and nothing happens: ( [10:19:36] LocalSettings is not generated [10:19:53] &and the database has not been populated [10:25:52] An idea MatmaRex or MaxSem ? :X [10:28:47] YuviPanda|away: any news on github-gerrit script? :) [10:34:41] dunno, sorry. [10:36:17] YuviPanda|away: code at github is crying because it does not know how to get to gerrit :) [11:11:45] (03CR) 10Zfilipin: "Chris, should be abandon this commit, or is it something that should be done these days?" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/50468 (owner: 10Cmcmahon) [11:13:39] zeljkof: getting to it now :) [11:14:04] YuviPanda: there is no rush, but we _do_ need to move code from github to gerrit :) [11:14:55] I know, I know :) [11:29:41] (03CR) 10PleaseStand: [C: 04-1] "QUnit tests are probably going to fail in PHP 5.3, for the same reason they did for I1987190f. I need to fix tests/qunit/data/load.mock.ph" [core] - 10https://gerrit.wikimedia.org/r/78941 (owner: 10PleaseStand) [11:47:34] (03PS1) 10Hashar: flake8/pep8 tox environnement [sartoris] - 10https://gerrit.wikimedia.org/r/81907 [11:48:35] (03PS1) 10Hashar: make-release had an unused local var 'length' [sartoris] - 10https://gerrit.wikimedia.org/r/81908 [11:56:48] (03PS1) 10TTO: Add Special:CreateAccount to Special:Specialpages [core] - 10https://gerrit.wikimedia.org/r/81909 [12:07:14] (03PS1) 10Shirayuki: Use the long PHP tag [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81911 [12:07:25] (03CR) 10Matmarex: [C: 031] "Looks okay to me, not tested." [core] - 10https://gerrit.wikimedia.org/r/81909 (owner: 10TTO) [12:11:20] (03CR) 10Yuvipanda: [C: 032] "Thank you for the patch!" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81911 (owner: 10Shirayuki) [12:11:22] (03Merged) 10jenkins-bot: Use the long PHP tag [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81911 (owner: 10Shirayuki) [12:13:01] (03CR) 10Wizardist: [C: 032 V: 032] "I guess it's fine." [extensions/NamespaceRelations] - 10https://gerrit.wikimedia.org/r/79050 (owner: 10Wizardist) [12:13:02] (03CR) 10Shirayuki: "Thanks for quick response." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/81911 (owner: 10Shirayuki) [12:23:47] (03PS1) 10Hashar: sphinx documentation [sartoris] - 10https://gerrit.wikimedia.org/r/81912 [12:23:50] (03CR) 10jenkins-bot: [V: 04-1] sphinx documentation [sartoris] - 10https://gerrit.wikimedia.org/r/81912 (owner: 10Hashar) [12:33:47] (03PS1) 10Shirayuki: Use the long PHP tag [extensions/SemanticWebBrowser] - 10https://gerrit.wikimedia.org/r/81913 [12:34:20] (03PS2) 10Hashar: flake8/pep8 tox environnement [sartoris] - 10https://gerrit.wikimedia.org/r/81907 [12:34:21] (03PS2) 10Hashar: sphinx documentation [sartoris] - 10https://gerrit.wikimedia.org/r/81912 [12:35:32] (03PS2) 10Hashar: make-release had an unused local var 'length' [sartoris] - 10https://gerrit.wikimedia.org/r/81908 [12:47:47] (03PS1) 10Shirayuki: Replace "e-mail" by "email" [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/81914 [12:48:27] (03PS1) 10Hashar: job to build sphinx documentation (python job) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81915 [12:48:57] (03CR) 10Hashar: [C: 032] job to build sphinx documentation (python job) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81915 (owner: 10Hashar) [12:49:15] (03Merged) 10jenkins-bot: job to build sphinx documentation (python job) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81915 (owner: 10Hashar) [12:52:08] (03PS1) 10Shirayuki: Replace "e-mail" by "email" [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/81916 [12:55:35] (03PS1) 10Shirayuki: Replace "e-mail" by "email" [extensions/SSLClientAuthentication] - 10https://gerrit.wikimedia.org/r/81917 [13:00:28] (03PS1) 10Shirayuki: Replace "e-mail" by "email" [extensions/SemanticSignup] - 10https://gerrit.wikimedia.org/r/81918 [13:05:29] (03PS1) 10Shirayuki: Replace "e-mail" by "email" [extensions/SemanticTasks] - 10https://gerrit.wikimedia.org/r/81919 [13:05:30] (03PS1) 10Hashar: trigger sartoris-sphinx-doc (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81920 [13:10:18] (03PS1) 10Shirayuki: Replace "e-mail" by "email" [extensions/SemanticWatchlist] - 10https://gerrit.wikimedia.org/r/81921 [13:16:51] (03CR) 10Hashar: [C: 032] trigger sartoris-sphinx-doc (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81920 (owner: 10Hashar) [13:16:56] (03Merged) 10jenkins-bot: trigger sartoris-sphinx-doc (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/81920 (owner: 10Hashar) [13:17:36] (03CR) 10Hashar: "recheck" [sartoris] - 10https://gerrit.wikimedia.org/r/81912 (owner: 10Hashar) [13:19:36] (03CR) 10Hashar: "trying out sphinx documentation building :-D" [sartoris] - 10https://gerrit.wikimedia.org/r/81912 (owner: 10Hashar) [13:19:44] (03CR) 10Hashar: "recheck" [sartoris] - 10https://gerrit.wikimedia.org/r/81912 (owner: 10Hashar) [13:25:48] (03CR) 10Njw: "Yes, VitaliyFilippov is correct, the javascript disabling is just an option. In some cases the small extra ui complexity of the ajax stuff" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/57041 (owner: 10Njw) [13:35:17] (03PS2) 10Zfilipin: Cucumber runs tests, not Rake [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79783 [13:48:06] (03Abandoned) 10Zfilipin: WIP script that checks how often NewPagesFeed page breaks [qa/browsertests] - 10https://gerrit.wikimedia.org/r/75093 (owner: 10Zfilipin) [13:52:04] (03PS1) 10Yuvipanda: Move mediawiki_password from secret.yml to an environment variable. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81927 [13:52:45] zeljkof: manually moved it for now. [13:53:01] YuviPanda: thanks [13:54:10] @notify multichill [13:54:10] I'll let you know when I see multichill around here [13:59:56] (03PS1) 10Zfilipin: Updating shared code to the latest version [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81929 [14:05:53] (03PS3) 10Zfilipin: Environment variabled determine where the test run [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79793 [14:13:16] (03Abandoned) 10Zfilipin: WIP VE numbering, bullets, indent, outdent scenarios [qa/browsertests] - 10https://gerrit.wikimedia.org/r/80664 (owner: 10Rachel99) [14:13:43] (03Abandoned) 10Zfilipin: mend [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81670 (owner: 10Rachel99) [14:16:54] (03PS1) 10Platonides: Add webs. Azerbaijan and Cameroon where missing from the list. [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/81931 [14:22:46] !b 52562 |James_F|Away [14:22:47] James_F|Away: https://bugzilla.wikimedia.org/52562 [14:25:32] (03CR) 10Anomie: [C: 031] "Code looks good, but it appears that ApiStabilize.php needs the same treatment (in two places). I'd fix both in one changeset, but if you " [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO) [14:29:05] thedj: Any further comments on https://gerrit.wikimedia.org/r/#/c/78523/ ? I'm inclined to merge it as it is. [14:41:19] (03PS1) 10Hashar: default use-remote-zuul for slaves [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81932 [14:41:58] (03PS1) 10Hashar: use-remote-zuul for integration-zuul-* jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81933 [14:45:27] (03CR) 10Hashar: [C: 032] default use-remote-zuul for slaves [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81932 (owner: 10Hashar) [14:45:46] (03Merged) 10jenkins-bot: default use-remote-zuul for slaves [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81932 (owner: 10Hashar) [14:45:51] (03CR) 10Hashar: [C: 032] use-remote-zuul for integration-zuul-* jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81933 (owner: 10Hashar) [14:46:10] (03Merged) 10jenkins-bot: use-remote-zuul for integration-zuul-* jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81933 (owner: 10Hashar) [14:51:47] (03CR) 10Parent5446: [C: 032] Replace "e-mail" by "email" [extensions/SSLClientAuthentication] - 10https://gerrit.wikimedia.org/r/81917 (owner: 10Shirayuki) [14:51:56] (03CR) 10Parent5446: [V: 032] Replace "e-mail" by "email" [extensions/SSLClientAuthentication] - 10https://gerrit.wikimedia.org/r/81917 (owner: 10Shirayuki) [14:55:13] (03PS1) 10Hashar: migrate python jobs to be runnable by slaves [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81936 [14:55:59] (03CR) 10Hashar: [C: 04-2] "I have applied this to the sartoris python jobs:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81936 (owner: 10Hashar) [15:12:06] (03PS1) 10Qgil: Removes portal-url, currentevents-url and helppage from default Sidebar portal-url ("Community portal"), currentevents-url ("Current events") and helppage ("Help") lead to empty pages in a fresh MediaWiki install, when most projects won't need these pages [core] - 10https://gerrit.wikimedia.org/r/81938 [15:12:47] (03CR) 10jenkins-bot: [V: 04-1] Removes portal-url, currentevents-url and helppage from default Sidebar portal-url ("Community portal"), currentevents-url ("Current events") and helppage ("Help") lead to empty pages in a fresh MediaWiki install, when most projects won't need these pages [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil) [15:13:03] ^^^ my first commit proposed for core! [15:16:49] qgil: yay, you broke jenkins with your first commit! [15:17:13] MatmaRex, :) I was trying to understand why. [15:17:34] qgil: all i can tell you is that this should not happen. :P [15:17:53] MatmaRex, so is it not me? [15:18:04] qgil: also, add a newline after the first line of commit message - paragraphs in com.mess. are supposed to be separated with newlines, like in wikicode [15:18:17] qgil: doesn't seem to be you :) [15:18:22] MatmaRex, ok, true [15:19:56] MatmaRex, I also should probably force new lines in the commit message, instead of expecting them to be automatically created, is that right? https://gerrit.wikimedia.org/r/#/c/81938/ [15:20:36] qgil: yeah. most code editors have some functionality to wrap lines for you [15:20:52] MatmaRex, not nano, apparently [15:21:03] qgil: heh, no, not nano [15:21:13] i meant real editors :D [15:22:25] MatmaRex, I stil need to see how to connect Gedit, I guess nano was the default. Or something. [15:22:33] but first things first [15:22:36] let me ammend this commit [15:22:37] in vim you can do "gq{" to wrap a paragraph [15:23:14] qgil: you mean as git's commit message editor? [15:23:46] qgil: git uses the "EDITOR" env variable, so you can just do "EDITOR=gedit git commit" to try it out [15:24:03] MatmaRex, ok thanks! [15:24:14] qgil: or do something to set that as default value, i dunno how to do that off-hand, though [15:25:34] (03PS2) 10Qgil: Removes portal-url, currentevents-url and helppage from default Sidebar [core] - 10https://gerrit.wikimedia.org/r/81938 [15:25:56] qgil: hashar is on the jenkins thing, see #wikimedia-operations [15:26:05] yeah that was my fault qgil, sorry [15:26:24] hashar, no worries, it made me feel... like... powerful! ;) [15:26:37] * MatmaRex disappears [15:28:34] * lazowik gets Tom Bombadil to look for MatmaRex [15:29:20] (03PS3) 10Hashar: migrate python jobs to be runnable by slaves [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/81936 [15:33:16] (03CR) 10MarkAHershberger: "bout to start a meeting, but something like this is def needed. Will look in a bit." [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil) [15:34:16] (03PS3) 10Anomie: Scribunto should error out sooner if lua isn't executable [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/75819 (owner: 10MarkAHershberger) [15:34:38] (03PS4) 10Anomie: Scribunto should error out sooner if lua isn't executable [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/75819 (owner: 10MarkAHershberger) [15:35:20] (03CR) 10Anomie: [C: 032] "PS4: Remove a Unixism in error message (other platforms don't necessarily have an "execute bit")" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/75819 (owner: 10MarkAHershberger) [15:39:10] (03Merged) 10jenkins-bot: Scribunto should error out sooner if lua isn't executable [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/75819 (owner: 10MarkAHershberger) [15:40:49] (03PS1) 10Cmcmahon: guided tour test is no longer required [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81940 [15:52:50] (03CR) 10Zfilipin: [C: 032] guided tour test is no longer required [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81940 (owner: 10Cmcmahon) [16:00:10] (03CR) 10Zfilipin: "Moved from https://github.com/wikimedia/qa-browsertests/pull/9/" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81927 (owner: 10Yuvipanda) [16:10:09] (03PS1) 10BryanDavis: Merge "Make MOTD banner fit in 80 chars." [vagrant] - 10https://gerrit.wikimedia.org/r/81943 [16:11:16] (03Abandoned) 10BryanDavis: Merge "Make MOTD banner fit in 80 chars." [vagrant] - 10https://gerrit.wikimedia.org/r/81943 (owner: 10BryanDavis) [16:13:04] (03PS1) 10LivingShadow: Use localisation [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/81944 [16:19:34] (03CR) 10LivingShadow: "If you have time, could you briefly look for major errors or bad design and things that should be done for an ordinary Mediawiki extension" [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/81944 (owner: 10LivingShadow) [16:21:45] (03PS1) 10BryanDavis: Add puppet role for BetaFeatures extension. [vagrant] - 10https://gerrit.wikimedia.org/r/81946 [16:26:47] (03CR) 10Yuvipanda: [C: 04-1] "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/81946 (owner: 10BryanDavis) [16:36:27] (03CR) 10Qgil: [C: 04-2] "Indeed, with https://gerrit.wikimedia.org/r/#/c/77557/ merged this patch can be safely abandoned." [core] - 10https://gerrit.wikimedia.org/r/67615 (owner: 10Bharaththiruveedula) [16:38:01] Is it normal that a user without -2 permissions (me, allegedly) can review a patch with a -2? [16:38:20] see https://gerrit.wikimedia.org/r/#/c/67615/ [16:38:45] (03PS1) 10Matthias Mullie: (bug 53506) Protection disables feedback even if nothing is touched [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/81950 [16:39:22] qgil: yes [16:39:42] bawolff, is it like a rethoical -2? [16:39:43] -2 doesn't affect the ability of yourself or others to review [16:39:56] rethorical [16:39:57] It just prevents the patch from being merged [16:40:36] -2 is like a -1 that doesn't go away [16:40:44] when people upload new patchsets [16:40:55] bawolff, I see. Ok, thanks! [16:41:26] bawolff, the "Abandon" button also shows up in my UI (I didn't dare to try it) so I was wondering whether there was something wrong wit my permissions [16:41:43] bawolff, since you are here I will click it and see what happens. Just curious. [16:41:45] You can abandon other people's patches [16:41:54] In this case, its probably appropriate [16:42:14] bawolff: so −1 == try again and −2 == you have to convince me that you've fixed this mess? [16:42:15] (03Abandoned) 10Qgil: Added 'Developers' link to footer link [core] - 10https://gerrit.wikimedia.org/r/67615 (owner: 10Bharaththiruveedula) [16:42:29] as a general rule, its considered rude unless the original author is ok with it, but in this case a different approach was taken [16:43:08] bd808: pretty much. In practise -2 is more used for "wtf are you doing, you should give up now" [16:43:10] bawolff, I see. Well, it's kind of dangerous. But reverting it's also easy... Anyway, happy to help cleaning the queue with an obvious case. [16:43:43] Most of the time I've seen things get -2'd, its because they were horrible ideas, but the original author didn't want to give up [16:43:52] bawolff, the author(s) were asked to abandon the change days ago, it's a clear case and nobody answered, so I hope it is fine. [16:44:09] bawolff, I was testing :) Will do -1 from now on. [16:44:30] qgil: I think its fine. That patch was by a newbie who I don't think is still here [16:44:37] (03CR) 10BryanDavis: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/81946 (owner: 10BryanDavis) [16:45:31] -2 is so rarely used, I don't think there's wide spread agreement about its "meaning" [16:46:07] * bd808 resolves to −2 all the things [16:46:26] * bd808 "no soup for you" [16:46:32] lol [16:46:45] It would cut down on regressions if we just stopped comitting code [16:46:52] Committing is fine [16:46:54] Submitting is not [16:50:18] hey bawolff [16:50:22] Hi [16:50:29] you pinged me y'day? [16:50:38] (03CR) 10Brian Wolff: "Very very superficial review:" [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/81944 (owner: 10LivingShadow) [16:51:00] yeah, I wanted to ask you about the drama involving Romaine [16:51:01] HOW DARE YOU BAWOLFF [16:51:19] bawolff: *shrug*. it's all been repeated four, five times n that bug / mailing list :) [16:51:20] Ahahaha [16:51:33] Reedy: Chill, I want to see this play out [16:51:51] marktraceur: btw, looks like we managed to get a designer interested! https://s3.amazonaws.com/f.cl.ly/items/1U240I3O2O0J3J3u431P/campaigns.png looks prettier [16:51:52] Reedy: I'm not afraid to ping nobody [16:52:23] YuviPanda: Whoooo? [16:52:47] bawolff: Well after he blinded you in that cave, it's probably good to ask him what's up [16:53:01] #greekmythologypun [16:53:27] marktraceur: I've asked the designer to turn up here. he's always on IRC, but only on -mobile [16:53:31] marktraceur: friend of mine from another city. [16:53:48] YuviPanda: Do you think there could be a compromise on it? Show the json formatted as a table to people with either a specific user right (since people with campaign editing ability need to see the config, and probably don't want to actually "contribute") or via pref? [16:53:53] Well, I'm in -mobile, who is it [16:54:36] bawolff: unnecessarily complicated, I must say. Besides, Romaine is the only person talking there (albeit using 'We', but that might be a language issue?) [16:55:10] We are not amused. [16:55:49] bawolff: Can you look at YuviPanda's link, thar? Is it possible to add a div to the gallery, maybe dynamically or so? [16:55:51] bawolff: so I'm pretty much against setting the JSON structure as that visible anywhere, really. Perhaps in the edit page itself. [16:56:11] marktraceur: Div for what? [16:56:20] bawolff: https://s3.amazonaws.com/f.cl.ly/items/1U240I3O2O0J3J3u431P/campaigns.png [16:56:27] bawolff: see the '+' thing [16:56:29] The CTA [16:56:43] oh, sorry i assumed that was an image [16:57:12] Umm, good question. [16:57:28] I guess you'd have a div there if you specified an invalid image. That's probably not what you want [16:58:26] bawolff: true. [16:59:05] bawolff: doing this in JS will probably mess up the layout algorithm [16:59:42] One could subclass the gallery, that might get complicated though. [16:59:58] auegheguh [17:01:03] * bawolff will be back in 10 minutes [17:01:06] bawolff: thoughts on how to do this? [17:01:09] bawolff: oh, okay [17:04:03] * bawolff back [17:04:09] bawolff: that wasn't 10 minutes :P [17:04:25] it was only the standup meeting [17:04:34] oh, right. I've one in 10 mins [17:13:53] (03PS1) 10Yuvipanda: Add php / imagemagic config to multimedia role [vagrant] - 10https://gerrit.wikimedia.org/r/81956 [17:13:55] (03CR) 10jenkins-bot: [V: 04-1] Add php / imagemagic config to multimedia role [vagrant] - 10https://gerrit.wikimedia.org/r/81956 (owner: 10Yuvipanda) [17:13:57] (03PS3) 10Cmcmahon: Cucumber runs tests, not Rake [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79783 (owner: 10Zfilipin) [17:14:14] bd808: ^ [17:14:30] (03CR) 10Cmcmahon: [C: 032] "remove references to Rake" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79783 (owner: 10Zfilipin) [17:14:52] (03PS4) 10Cmcmahon: Environment variabled determine where the test run [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79793 (owner: 10Zfilipin) [17:15:03] YuviPanda marktraceur o/ [17:15:07] hey prtksxna [17:15:25] prtksxna: What do you think about pulling the old "your image here" trick on that page? :) [17:15:43] YuviPanda: looking now [17:15:54] marktraceur: I was thinking about that, not sure if its a clear call to action though, so I refrained. [17:15:59] (03CR) 10Cmcmahon: [C: 032] "make run parameters ENV variables" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/79793 (owner: 10Zfilipin) [17:17:09] prtksxna: also I was talking to bawolff, and we're not sure how easy it would be to add the large + button to the gallery itself. [17:17:16] prtksxna: think there's somewhere else we can put those? [17:17:33] I really hope there's a way. /me still thinking on the problem [17:18:09] Oh! I'll think about it. [17:18:35] bawolff: Crack it, please :) [17:18:58] bawolff: Also, I asked on the mailing list, is the new gallery view responsive? [17:19:09] prtksxna: it is! [17:19:18] prtksxna: resize the window, it flows. [17:19:18] \o/ [17:19:43] Oh, well then, you should be able to "just" add the div to the gallery div with JavaScript [17:20:11] marktraceur: that's not too nice, since it'll perhaps upset the layout? [17:20:18] marktraceur: relayout, rather. [17:20:29] YuviPanda: Not that responsive, when you resize the window, it messes the layout a bit [17:20:33] marktraceur: bawolff is still thinking, and he knows the code better than I do :) [17:20:38] bawolff: pfft, better than before [17:20:55] YuviPanda: If you add an invalid image, that creates an empty box, which could then be replaced with js [17:21:45] bawolff: hacky. [17:21:56] bawolff: perhaps add a way to just add html? [17:23:42] (03PS13) 10MarkTraceur: Use the new feature field [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 [17:23:43] Well if you make a subclass of it, you can override the method that generates the html [17:24:09] (03CR) 10MarkTraceur: [V: 032] "Need to enable Jenkins here, but for the time being..." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76210 (owner: 10MarkTraceur) [17:24:50] YuviPanda: Oh btw - Do you need me to make responsive mock up too? [17:25:37] bawolff: I'd have to inherit the Packed subclass, and then it gets a bit eeky to actually change which type of gallery it is, no? [17:26:04] (03PS1) 10Aaron Schulz: Show authorize page on all wikis [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/81960 [17:26:31] Hmm. It should still be do-able, but maybe. I'll read through the code again and see if I see a better way [17:26:48] bawolff: okay! [17:26:51] but first, lunch [17:26:55] prtksxna: hmm, good question. [17:27:11] prtksxna: the mobile site is almost a rewritten version of all the code, so I don't know how useful that'd be. [17:27:56] YuviPanda: I like what you're up to with 81956 but worry that ori-l won't like the role bomb that it implies. [17:28:01] (03PS2) 10Cmcmahon: Updating shared code to the latest version [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81929 (owner: 10Zfilipin) [17:28:18] bd808: role bomb? [17:28:25] (03CR) 10Cmcmahon: [C: 032] "maintenance" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81929 (owner: 10Zfilipin) [17:28:32] YuviPanda: leads to one role per extension [17:28:47] (03PS1) 10Manybubbles: Search headings. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81961 [17:28:56] rather than a container of sort of related stuff [17:29:02] (03PS5) 10MarkTraceur: Add portlet link to Beta Features pref section [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/77074 [17:29:15] bd808: hmmm, right. But that's sortof already the case, right? [17:29:16] (03PS2) 10Manybubbles: Search headings. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81961 [17:29:30] bd808: almost all our roles are individual extensions [17:30:14] bd808: but yeah, role:: does sound a bit hacky [17:30:21] bd808: but I'm not sure how exactly to solve that. [17:30:22] I got the impression that ori-l wasn't in love with that when re rewrote my initial thumb.php role [17:30:49] (03PS1) 10Manybubbles: Tests for searching headings. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81962 [17:31:06] bd808: I think it sortof makes sense for vagrant as such, to have roles be extensions / extension bundles. [17:31:13] bd808: since its primary use case is testing [17:31:20] Ryan_Lane: hi [17:31:49] (03PS2) 10Manybubbles: Tests for searching headings. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81962 [17:31:53] Ryan_Lane: I am in need of your help for https://gerrit.wikimedia.org/r/#/c/81629/ [17:32:58] YuviPanda: Is that a no? [17:33:25] YuviPanda: there are a lot of ways to do it. I think they all have plusses and minuses. At this point I'm considering ori-l to be the BDFL of this so I guess I want his take. [17:33:25] Wikinaut: heh. well, the LoginForm is kind of a giant piece of crap [17:33:43] prtksxna: it is a 'you can make it, but I do not if it will be implemented on mobile web' [17:33:51] bd808: oh yes, completely agree there :) [17:34:07] YuviPanda: Ah! Alright, later then maybe? [17:34:33] prtksxna: yeah. if possible, think of some way to put that CTA somewhere else :) [17:34:41] * bd808 has said ori-l three times and he appeared in private chat. [17:34:47] bd808: lol [17:35:00] hrmmm [17:35:42] what's up? [17:36:01] * ori-l reads scroll-back [17:36:08] YuviPanda: I was initially going to put it near the number, but then this seemed better. Could try it there too (should we move this discussion elsewhere, or here is fine?) [17:36:18] prtksxna: here is totally fine [17:36:24] (03PS2) 10Wikinaut: Bug 46617: Allow account creation through OpenID when the wiki disallows for anons [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 [17:36:41] prtksxna: yeah, near the number doesn't sound bad. [17:37:16] when i first added the whole 'roles' thing the primary use-case i had in mind was the mobile web team [17:37:34] their setup involves a stack of extensions and a whole lot of specific configs [17:38:01] prtksxna: you should also put them up on mediawiki.org so we can attribute you properly :) [17:38:06] but i don't know how many projects like that there are; i tried pushing the multimedia thing in the same direction (i.e., having a team-oriented role rather than a git repo-oriented role) [17:38:07] YuviPanda: Or below the description text [17:38:27] it does seem like having 200 roles for 200 extensions would be noisy and gross [17:38:39] prtksxna: i was trying to do that yesterday, and I had no idea where to put it :D [17:38:44] prtksxna: can you modify the mock to show? [17:38:50] at the same time, if we move to a mediawiki::extensions class, you lose the ability to toggle them via the CLI [17:39:10] and CLI toggling is kind of a win [17:39:47] but maybe we do need a two-tiered hierarchy of things you can enable/disable via the CLI [17:39:53] 'components' & 'bundles' or something [17:40:02] I dunno, I don't think I have an elegant schema up my sleeve [17:40:24] need to think about it a bit more I guess [17:40:31] bd808 / YuviPanda - thoughts? [17:40:50] Reedy: can you grant prtksxna permissions to upload on mediawiki.org? [17:41:01] I'd be ok with cli only managing collections, but I do think that we need another layer of abstraction below [17:41:20] see https://bugzilla.wikimedia.org/show_bug.cgi?id=53222 for a reason [17:41:22] if we have CLI manage individual extensions, how do you do config for those extensions? [17:42:13] YuviPanda: most -- tho admittedly not all -- extensions have a default config you'd never have reason to tinker with [17:42:33] and if you're not happy with the defaults, you can override them in settings.d/ [17:42:57] settings.d/*.php files are loaded _after_ settings.d/puppet-managed/*.php to give you a chance to override puppet-set config vals. [17:43:01] right. [17:43:10] so enable on CLI, add a file if you want to override [17:43:27] * ori-l reads https://bugzilla.wikimedia.org/show_bug.cgi?id=53222 [17:44:54] anyone with admin on mediawiki.org? [17:50:42] ori-l: My current take is that we have 2 very distinct users for vagrant. [17:50:44] (03PS2) 10Yuvipanda: Add php / imagemagic config to multimedia role [vagrant] - 10https://gerrit.wikimedia.org/r/81956 [17:50:49] (just a rebase) [17:50:52] The first is the n00b who wants to get up and running with a dev environment. (me 4 weeks ago) [17:51:28] The second is the puppet-head control freak who wants to manage an active instance (me this week) [17:52:08] (03CR) 10Helder.wiki: "I don't know if this is relevant, but since MathJax uses a lot of JavaScript, maybe it is worth to check bug 29784?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/78466 (owner: 10Frédéric Wang) [17:52:14] There's probably a 3rd user in there somewhere too. The dedicated team member who just wants to work on code and review patches [17:52:16] multimedia-dragons is also a labs instance that's managed by vagrant, so maybe that's 2.5, bd808 :) [17:53:22] YuviPanda: yes. That's probably same/similar to my dedicated team user [17:53:30] where do we run into conflicts optimizing for one of these users? [17:53:46] (03Abandoned) 10Aaron Schulz: Changed some md5 calls to use sha1 instead. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/66145 (owner: 10Aaron Schulz) [17:53:57] ori-l: reminder about the redis patch. [17:54:10] marktraceur, I was talking to Rahul21 about the Blob thing. [17:54:16] YuviPanda: one thing at a time, have mercy [17:54:22] * YuviPanda has mercy. [17:54:36] Maybe in their primary config interface? [17:54:40] It seems like it should work since FormDataTransport.upload just calls append. [17:54:45] cli for n00b [17:54:59] something higher touch for power users [17:55:10] And that is supported for blobs. [17:55:19] bd808: well, you can just edit files in puppet/manifests/manifests.d to your heart's content [17:55:26] they're ignored by git and auto-loaded by site.pp [17:55:28] bd808, power users can make their own arbitrary settings files in settings.d [17:55:40] right, and settings.d for specific php stuff [17:55:58] i keep a puppet/manifests/manifests.d/extra.pp for random bits of puppet code [17:56:06] but I want to share too. I guess I could do that via github fork that I rebase a lot [17:56:19] wait, i'm not following [17:56:32] i think that if you want to share it makes sense to codify it as a role, no? [17:56:40] is the issue the conflicts you ran into? [17:56:42] marktraceur: https://s3.amazonaws.com/f.cl.ly/items/0B2l2I2K1L0W161k1V3Q/campaigns-2.png is without the gallery CTA thing. [17:56:59] well that's back to the "how many roles do we want" question [17:57:09] isn't it? [17:57:36] hey brion. [17:57:36] i see the concern about uncontrolled role proliferation, but i think we're still in "the more, the merrier" stage [17:57:54] and it sounds like we have tentative agreement to divide them into two tiers at some point if it gets to be much [17:57:55] hey hey [17:58:00] caught the bus \o/ [17:58:06] brion: are you in the bus? [17:58:12] at the office [17:58:17] ori-l: ok. that works for me. [17:58:17] brion: ah, right. [17:58:46] brion: so, for the new designs. we need to find number of contributions / contributors. [17:58:59] brion: first we can do by doing a count on categorylinks, and that should be fast [17:59:00] number of contribs is easy -- it'll be in the category table [17:59:09] brion: but the second needs a join between categorylinks and page and image [17:59:11] bd808: as for 53222, i think virtual resources are a partial solution [17:59:20] yeah the contributor count is harder [17:59:21] brion: but, but, image table doesn't have an index on img_name?! [17:59:25] YuviPanda: I think the BDFL has spoken and leans towards you're interpretation. [17:59:26] bd808: though superm401 has already pointed out that we may need a way to make roles mutually exclusive [17:59:27] might have to manage that manually [17:59:33] brion: *your :P [17:59:33] or…. just leave it out for now :) [18:00:13] brion: but why isn't there an index on img_name? that's sortof the primary key there, no? [18:00:22] YuviPanda: Oh, that's nice too [18:00:23] ori-l, not sure what you mean. [18:00:32] hm [18:00:39] prtksxna is kicking ass at this [18:00:40] YuviPanda: there should be an ibex... [18:00:42] *index [18:00:58] brion: nothing in tables.sql [18:01:07] YuviPanda: img_name varchar(255) binary NOT NULL default '' PRIMARY KEY, <- right there dude [18:01:12] it's the primary key [18:01:24] what, I only see img_name varchar(255) NOT NULL default '', [18:01:30] no PRIMARY KEY [18:01:34] YuviPanda, probably because the File namespace page is indexed. [18:01:39] well i'm cut-n-pasting from maintenance/tables.sql [18:01:53] brion: oh, call me a complete idiot. I was looking at maintenance/mssql/tables.sqlo [18:01:58] hah [18:02:00] mssql :PP [18:02:09] superm401: sure, but image table has img_user, which i want :) [18:02:22] Never mind, missed the PK too. :) [18:02:39] player killer!! [18:02:47] hehe :P [18:03:39] (03CR) 10Mglaser: "currentevents can certainly be removed. Having help and portal pages, however, seems to be good practise. So having those links in the nav" [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil) [18:03:43] ori-l: I just realized what the `@` thing is for. :) [18:04:50] but am now confused by it's use on all mediawiki::extension calls. What `realize`s them? [18:05:10] brion: okay, so let me add contributions count to this patch, and we can add contributors via a later one [18:05:56] whee [18:07:53] goddamn [18:07:53] it [18:07:55] i didn't mean that [18:07:58] can someone reset? [18:08:11] bd808: puppet/modules/mediawiki/init.pp, lines 140 & 141 [18:08:56] ori-l: ah. ok [18:08:59] I was trying to set the topic of another channel to '#wikimedia-dev is the channel you want' [18:09:04] but of course /topic doesn't like that [18:09:05] grrrrr [18:09:14] !logs [18:09:14] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://bots.wmflabs.org/~wm-bot/html/index.php?action=search&channel=%23mediawiki [18:09:50] brion: you just joined, do you have a copy of the channel topic in your backscroll? [18:10:09] MediaWiki and Wikimedia software development | Channel logs: https://bit.ly/11g3AEP | Report bug: http://wmbug.com/new | MediaWiki support: #mediawiki | Technical help for Wikimedia wikis: #wikimedia-tech | Wikimedia operations: #wikimedia-operations [18:10:11] bd808: hmm, should you rebase your change on top of mine? [18:10:15] nope it didn't show it in my log [18:10:17] just the change [18:10:22] thanks, ori-l [18:12:07] YuviPanda: I think so yes. And I'll drop the include all together [18:12:24] hmm, okay [18:13:02] betafeatures doesn't depend on multimedia as a config container [18:13:08] yeah, makes sense. [18:13:31] i haven't read https://gerrit.wikimedia.org/r/#/c/81946/ but it sounds like you guys are happy [18:13:56] I was going the other was with multimedia as a grouping related to the team [18:14:03] ori-l: yeah I think so [18:15:08] When we go out for beers week when I'm in SF we can discuss paint colors for the shed some more [18:15:12] i mean, i don't think that's always necessary, but 'thumb_404' as a role seemed extremely particular and highly unlikely to elicit participation [18:15:43] it didn't even map to a particular git repository [18:15:54] it was highly likely to make robla happy. :) that's what I was shooting for [18:16:08] oh, did i sabotage that? sorry [18:16:10] It's also got a problem I need to fix [18:16:27] oh no it was fine. he just wanted vagrant to do that magic somehow [18:16:38] mission accomplished [18:16:48] bd808: you're driving here with a truckload of chocolate and whisky? [18:17:01] umm… maybe? [18:17:03] * robla reads backlog to see what was to make me happy [18:17:17] vagrant roleplay [18:17:32] * ori-l rolls a saving throw [18:17:44] I'll bring my credit card and get the bribes locally [18:17:57] (03PS3) 10MarkTraceur: No need to use custom mw.log anymore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 [18:18:03] YuviPanda: ^^ [18:18:03] * bd808 casts +10 nerd aura on ori-l [18:18:17] bd808: He's already using IRC, it doesn't stack [18:18:24] marktraceur: will look after this patch. [18:18:29] Thankee [18:18:46] I think I needed to check for mw.warn. Sec. [18:19:33] YuviPanda: have you told bd808 about the evil nova plan? [18:19:43] ori-l: yes, he saw it too, I think. [18:19:50] good good [18:20:02] vagrant on labs instances? [18:20:19] ori-l: blue-dragon.wmflabs.org is now routing through my nginx+lua+redis proxy to the vagrant based labs instance :D [18:20:21] ori-l: the issue is just with the name of the role, not with the idea of putting WMF-style thumb handling as an option in vagrant, right? [18:20:21] wikimedia labs vagrant provisioner [18:20:55] robla: yeah, it's not really an issue, bd808 is trolling me a little :P [18:21:08] * bd808 denies that [18:21:33] robla: he has +2 and doesn't need my permission to do anything [18:22:08] bd808, no excuses now! mwaha. [18:22:11] I got my 80-column unicorn in so life is good [18:22:43] it's even on labs! :P [18:23:31] (03CR) 10Qgil: "So I went to http://wikiapiary.com/wiki/Youngest_websites and I took a couple of sambles of about 10 sites in languages that i could under" [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil) [18:24:20] hey multichill. [18:24:36] multichill: are the admin sections done on toollabs? [18:24:41] Hi yurik [18:24:43] crap [18:24:45] YuviPanda: [18:24:46] hehe :P [18:24:58] * yurik shoots YuviPanda & multichill [18:25:09] (03CR) 10Mglaser: [C: 031] "OK, agreed" [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil) [18:25:09] No, not yet, just finished work and about to go out to train [18:25:11] no shooting pandas [18:25:14] (03PS4) 10MarkTraceur: No need to use custom mw.log anymore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 [18:25:15] multichill: ah, okay. [18:25:19] There, much better [18:25:23] yurik, wait after WLM [18:25:52] I want to do it tomorrow YuviPanda [18:25:53] sigh, ok, will wait [18:26:03] multichill: hmm, okay. I just wanted to make sure it is not a bug in the app :) [18:26:04] Unless someone else beats me to it (doubt it) [18:26:10] multichill: also, what TZ are you in now? [18:26:44] Amsterdam is +2 right now [18:26:51] (03CR) 10BryanDavis: [C: 032] Add php / imagemagic config to multimedia role [vagrant] - 10https://gerrit.wikimedia.org/r/81956 (owner: 10Yuvipanda) [18:27:00] (03Merged) 10jenkins-bot: Add php / imagemagic config to multimedia role [vagrant] - 10https://gerrit.wikimedia.org/r/81956 (owner: 10Yuvipanda) [18:27:07] multichill: ah, okay [18:27:13] 20:27 [18:27:15] YuviPanda: ^^ +2'd [18:27:40] I'll fix mine after lunch [18:27:59] multichill: I'll try to get a final build of the app out today. [18:28:39] Hi, am I supposed to mark as verified my own patches that I have indeed verified? See https://gerrit.wikimedia.org/r/#/c/81938/ [18:29:11] qgil: Verified is mostly used by jenkins-bot [18:29:19] RoanKattouw, ok, thanks [18:29:45] One generally doesn't vote on one's own change anyway, because there's an unspoken assumption that if you submitted it, you approve of the way it's done (CR) and have tested it (V) [18:30:16] The exception to this is when you submit a work in progress, in which case you put [WIP] in the commit message and vote -2 on your own change [18:30:38] unless you are self merging and the repo is not setup for jenkins. [18:30:40] (rare) [18:30:51] (These are just the conventions that I use and have seen used, they're not hard and fast or well-documented AFAIK) [18:30:52] YuviPanda: Ok, that means I have to hurry. I'd rather have you push out after we get adminlevels to work [18:30:56] Got to run now [18:31:01] multichill: cya! [18:32:50] (03PS2) 10BryanDavis: Add puppet role for BetaFeatures extension. [vagrant] - 10https://gerrit.wikimedia.org/r/81946 [18:33:34] * bd808|LUNCH really leaves for lunch now [18:34:24] (03CR) 10Yuvipanda: [C: 04-1] "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/81946 (owner: 10BryanDavis) [18:36:32] (03PS3) 10BryanDavis: Add puppet role for BetaFeatures extension. [vagrant] - 10https://gerrit.wikimedia.org/r/81946 [18:37:11] (03CR) 10BryanDavis: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/81946 (owner: 10BryanDavis) [18:38:29] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #242: FAILURE in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/242/ [18:42:44] (03CR) 10Yuvipanda: [C: 032] Add puppet role for BetaFeatures extension. [vagrant] - 10https://gerrit.wikimedia.org/r/81946 (owner: 10BryanDavis) [18:42:47] (03Merged) 10jenkins-bot: Add puppet role for BetaFeatures extension. [vagrant] - 10https://gerrit.wikimedia.org/r/81946 (owner: 10BryanDavis) [18:42:54] done, bd808|LUNCH [18:43:45] Oh, cool! [18:43:50] * marktraceur wasn't paying attention [18:44:03] * marktraceur also apparently isn't hilighted on BetaFeatures yet [18:44:18] * YuviPanda rubs hands in an evil manner [18:44:45] YuviPanda: Seriously, you could annoy me just as much by using my nick [18:44:57] marktraceur: not the same, not the same [18:45:01] Heh. [18:45:24] YuviPanda: I guess you could write an autocompletion rule to replace "marktraceur" with "BetaFeatures" [18:45:27] That could be funny [18:46:09] :P [18:46:51] (03PS1) 10Platonides: Russia and Thailand were missing [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/81967 [18:49:30] Everytime I see the cloudbees.com links, I think of http://www.likelihoodofconfusion.com/wp-content/uploads/winnie-the-pooh-balloon-bees.jpg [19:06:59] (03CR) 10Catrope: [C: 031] "Looks good to me. Wanna put in the RELEASE-NOTES then, Krinkle?" [core] - 10https://gerrit.wikimedia.org/r/81884 (owner: 10Krinkle) [19:17:50] (03PS1) 10Aaron Schulz: Removed duplicate tests and easier to use TestOAuthConsumer script [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/81968 [19:18:12] (03CR) 10Aaron Schulz: [C: 032] "Seem to work" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80569 (owner: 10Anomie) [19:18:27] (03Merged) 10jenkins-bot: Allow for non-web-based consumers [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80569 (owner: 10Anomie) [19:25:01] quiddity: makes me think of https://www.youtube.com/watch?feature=player_detailpage&v=dTocBQXR05M#t=17 [19:25:28] quiddity: and of course, http://i.imgur.com/qrLEV.gif [19:28:57] ori-l, XD , and yup, best oprah gif. Also zim: https://www.youtube.com/watch?v=LZs39wggIW4 [19:30:01] (03CR) 10Nemo bis: "This looks good, however I wonder what of those messages makes sense to keep as possibly used somewhere else and what not." [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil) [19:33:59] (03CR) 10Matmarex: [C: 032] SpecialPrefixindex formatting methods are now protected [core] - 10https://gerrit.wikimedia.org/r/75569 (owner: 10Hashar) [19:34:05] (03CR) 10Qgil: "The corresponding messages and all their localizations are still available, and I see no reason to remove them." [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil) [19:40:34] (03PS1) 10Matmarex: SpecialPrefixindex: Try not to generate unclickable links [core] - 10https://gerrit.wikimedia.org/r/82029 [19:43:33] (03CR) 10Nemo bis: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81961 (owner: 10Manybubbles) [19:43:33] (03Merged) 10jenkins-bot: SpecialPrefixindex formatting methods are now protected [core] - 10https://gerrit.wikimedia.org/r/75569 (owner: 10Hashar) [19:44:55] (03CR) 10Platonides: "As sidebars links are always blue, they are probably not noticed too much. Perhaps the initial main page should link to them. «You can sta" [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil) [19:45:07] (03PS14) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 [19:46:39] brion: http://blue-dragon.wmflabs.org/ [19:46:43] Platonides, please respond to https://bugzilla.wikimedia.org/show_bug.cgi?id=47450#c4 [19:47:01] brion: http://blue-dragon.wmflabs.org/wiki/Campaign:show-off-campaigns [19:47:23] (03CR) 10Platonides: "Repeating my question from bug 53570#c42 why should the campaign page be a gallery?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda) [19:47:24] YuviPanda: niiiice [19:47:40] couple notes [19:47:46] Platonides: I think brion answered you on the bug. Please keep discussion about that on the bug. Thanks. [19:47:46] maybe avoid 'photographs' as they may be other media types [19:48:01] brion: hmm, yeah. but contributions sounds so... vague? [19:48:08] and 'media files' sounds lame [19:48:09] pretty [19:48:11] brion: also I need to work out the spacing a little better, I think [19:48:16] 18 MULTIMEDIA EXPERIENCES [19:48:19] (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81961 (owner: 10Manybubbles) [19:48:35] i'd also consider putting a 'View all' link under the giant number. or on the giant number itself *click* [19:49:33] brion: ooooh, nice. [19:49:38] brion: but then what to put at the bottom of the page? [19:49:41] ... perhaps nothing. [19:50:05] YuviPanda: For the patch with the getUploadedMediaCount() method, unless you're sure that the categories are relatively small (< roughly 1000 files), instead of count(*)'ing categorylinks, use the category table [19:50:08] INFINITE SCROLL [19:50:31] bawolff: looking at category table now. [19:50:37] (03CR) 10Brion VIBBER: "I've already answered that question on the bug, please keep discussion there rather than fragmenting it." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda) [19:50:39] bawolff: also, why so? it's indexed... [19:50:57] The category class has easy accessors to the data in the table [19:51:13] Counting things is still expensive if there's a lot of things, even with an index [19:51:37] bawolff: there's a category table? [19:51:42] or do oyu mean Category.php? [19:51:49] both actually [19:52:00] oh there is [19:52:03] YuviPanda: yes, use it :) [19:52:50] bawolff: do you know an easy way to find out 'number of users who have uploaded at least one file to this category'? :) [19:53:01] bawolff: i guess I'll have to join categorylinks + page + image [19:53:12] Category::newFromTitle( $title )->getFileCount() will give you number of files in the category [19:53:19] yeah, just modified the patch. [19:53:20] testing [19:53:30] bawolff: i'm looking for 'number of contributors' [19:53:43] umm, number of unique users might be hard to have a fast query that scales up [19:56:18] bawolff: we could agressively cache these things [19:57:21] bawolff: brion hmm, or we could make it 'number of contributors in last X days' [19:57:28] my recommendation if you want to make it scalable is to add a quickie table that counts users-per-campaign [19:57:28] that should be faster? [19:57:40] and maintains them similarly to the article counts [19:58:53] brion: that feels... messy? [19:59:09] welcome to efficiency hell [19:59:26] man, none of this would be a problem if we had just used mongodb from the start [19:59:28] it is webscale [19:59:30] YuviPanda: A lot of it depends on how many users you expect to get in a single campaign. less than say 10000 (number pulled totally out of a hat, could be wrong number), caching agressively may be good enough [19:59:57] bawolff: I don't think there's been any campaign that's crossed that number yet. [20:00:36] mongodb is an excellent database; it's not its fault that it attracted a lot of the early (and naive) nosql hype. and the "lol webscale" jokes are about as credible as the "lol mysql" jokes of yore. [20:00:57] MongoDB is web scale. [20:01:23] mysql is so shitty, too. as is PHP. JS too. [20:01:28] it doesn't magically make all problems dissolve, but if you need a reliable and scalable document store, i think it's the way to go. [20:01:52] YuviPanda: you're not settings your sights very high :P [20:02:21] ori-l: I think the joke is more about people who used mongodb for... everything? [20:02:22] COMPUTERS SUCK. [20:02:24] hammer, nail, etc. [20:02:27] csteipp, Reedy: Were the patches for bugs 45019 and 53320 applied when 1.22wmf15 was branched? [20:02:42] YuviPanda: The joke is more about people not understanding scalability. [20:02:51] And making silly claims about performance. [20:02:51] YuviPanda: yes, I guess these people don't know about redis :P [20:02:57] ori-l: well played :P [20:03:08] Redis, MongoDB, and shards. [20:03:10] LOTS OF SHARDS. [20:03:40] (03CR) 10Nemo bis: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81961 (owner: 10Manybubbles) [20:03:40] ori-l: reminds me, the redis vagrant patch? :P [20:03:48] YuviPanda: well-played :P [20:04:45] YuviPanda: ok, remind me again [20:04:51] ori-l: when? [20:04:52] why did we need to bundle the ops/puppet redis class for this? [20:04:57] now :) [20:05:00] ah :P [20:05:19] ori-l: well, because I liked the fact that it had defaults, and I didn't have to specify everything? [20:05:35] plus having multiple modules that do the same thing in two repos makes me feel eugh. [20:05:36] what needs to be specified? [20:05:47] that isn't currently? [20:06:02] the fact that all these things were currently specified was the bad part [20:06:10] plus there's the 'two modules doing the same thing!' bit. [20:06:11] i'm okay consolidating them, but i'd rather keep things atomic if the two goals (consolidating; redis as default object store) are orthogonal [20:06:29] esp. since i'm still nervous about the latter [20:06:52] ori-l: sure. want me to split that into two patches? [20:07:03] ori-l: with the redis puppet one first? :D [20:07:07] it'll have the same effect, but [20:07:28] well, that's what i'm pressing you on here -- what is the exact dependency? [20:07:32] what is that module setting that we're not? [20:07:41] that's good to know regardless of whether or not we use it [20:07:47] * ori-l shards Elsie. [20:07:54] I think the answer is mostly absolutely nothing. [20:08:05] mostly? [20:08:10] there isn't anything the module in ops/puppet does that can't be done with the previous one [20:08:16] s/mostly// [20:08:21] Now the other cheek. [20:08:32] "can't be done" is different from "is already doing", though [20:08:32] it is just clearer, IMO, to use the one in ops/puppet. [20:08:55] ori-l: the current module makes me specify all the properties I want to set in the puppet manifest. [20:09:05] ori-l: the one in ops sets a lot of them by default, from the template. [20:09:19] YuviPanda: from the template that shipped with 2.6 [20:09:23] plus some customizations [20:09:26] indeed. [20:09:32] that is wmf-specific in indeterminate ways [20:09:37] and is version-specific in determinate ways [20:09:59] http://techs.enovance.com/6006/manage-jenkins-jobs-with-yaml [20:10:00] you could check in the ready-made apache config files to puppet too and avoid having to have a parametrized class, but i don't think that that's necessarily a win [20:10:02] how so? [20:10:23] hm. no hashar around [20:10:33] the bare approach forces you to be explicitly mindful of all the configs you're setting [20:10:41] and is flexible enough to be updated for future versions of redis [20:10:48] http://ci.openstack.org/jenkins-job-builder/index.html [20:11:00] I want to set 'persist' => 'aof', and have the class figure out all the rest [20:11:02] the operations/puppet one has defaults from a specific version, plus comments, that are likely to be obsoleted sooner or later [20:11:22] sure, then we should fix the one in operations/puppet to be more recent. [20:11:32] I want a layer of abstraction between myself and the redis config file. [20:11:40] while you say there should be none [20:11:43] (03PS1) 10Zfilipin: Removed unused HTML Cucumber formatter [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82032 [20:11:45] is that an accurate description? [20:12:07] i think it should be thin, to allow for a consistent syntax for specifying all configs, and a centralized place to keep them [20:12:28] I disagree, but I think in the end this is a bikeshed. [20:12:37] i'm also OK with having, say, a puppet class that collects some params that go together [20:12:38] and I am okay with going your way because BDFL [20:12:56] well, i don't want to be a dick about it, and i respect your opinion, so i'm calling on you to challenge me :P [20:13:03] Yippie, build fixed! [20:13:04] Project browsertests-en.wikipedia.org-linux-chrome build #284: FIXED in 3 min 31 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/284/ [20:13:19] ori-l: oh, I think both approaches are valid, and it is a matter of personal preference :P [20:13:50] ori-l: but zooming out, the more important thing for me is to have redis the default cache, not the puppet manifest :P [20:14:01] I use too many smileys. [20:14:16] i think we should take the same approach in operations/puppet too, fwiw [20:14:18] ori-l: so no, no challenge. If you think having thin abstractions is the way to go, I'll respect that, and redo the patch. [20:14:38] ori-l: well, diverging ops/puppet and mediawiki-vagrant is a bad thing, I think. but I don't have a solution [20:15:28] ori-l: I'll redo the patch tomorrow? [20:15:59] sure [20:16:00] btw: https://dpaste.de/xLs9V/raw/ [20:16:21] that's a diff of redis.conf that ships w/2.8 and redis.conf.erb in operations/puppet [20:16:32] aside from configs that were added or changed, you can see for example that we set a different default timeout [20:16:39] Y U NO unified? [20:16:40] but it's hard-coded in the template, with no indication that this is something that we customized [20:17:00] (03PS1) 10Zfilipin: Removed unused Rake Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82033 [20:17:03] ori-l: well, fixable by a patch to ops/puppet :) [20:17:11] Krenair: I forgot 53320... let me deploy that [20:17:34] YuviPanda: unified https://dpaste.de/ZUkwR/raw/ [20:18:03] ori-l: I realized I had no idea how to read the previous format without looking it up [20:19:32] ori-l: hmm, having a consistent way of saying 'this was taken from X, and here are the modifications' would be nice [20:19:35] YuviPanda: even more revealing is the diff between the default that ships with 2.6 and our template [20:19:36] https://dpaste.de/mRP4F/raw/ [20:19:56] so what you're looking at (aside from some bits of erb syntax) are things that we customized but in a way that is mostly invisible to puppet [20:20:27] true, but that's a problem of 'not enough comments were added' [20:20:42] not an underlying problem with the 'modules should be self contained and not have you understand their config paramters' [20:21:57] but compare: https://dpaste.de/KDMxr/ [20:22:09] those are *exactly* the settings that get set [20:22:40] sure, but I've no idea wtf 'dir' is or 'save' is without knowing redis config [20:22:51] it is pretty much zero abstraction [20:23:03] Krenair: done [20:24:01] YuviPanda: it's the bottommost layer of an abstraction; from there you can have role::redis::persistent, role::redis::sessioncache, whatever [20:24:31] hmm, so the question is essentially if the bottommost layer should be a template that's modified from the default [20:24:38] or you hand setting everything and building on top of that [20:25:19] i think configs should be in .pp; if you have to look at templates all the time to understand what you're setting something went wrong [20:25:50] hmmm, I think that makes sense. [20:26:03] puppet at least gives you a single declarative syntax for expressing these configs [20:26:10] so you get some uniformity [20:26:29] but ultimately, it is upto the person writing it to document each of the declarations, and why they are there [20:26:29] if you're looking at erb files you're looking at erb syntax with ruby with the config syntax of foo app [20:26:33] wether they're in templates or in .pp [20:27:00] yes, no contest there, and the manifests in mwv could use better documentation [20:27:04] (03PS1) 10Zfilipin: Updated test configuration to the latest version [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82034 [20:28:37] YuviPanda: i think it'd make sense to recap this convo in a concise way and e-mail it to ops-l, and if people agree make that part of our standard [20:28:43] and if people disagree i'll reconsider [20:29:12] ori-l: +1 [20:29:35] ori-l: I think the core thing is to document stuff, and ERB vs .pp is a matter of style (and consistency?). [20:30:47] ori-l: but yes, looking forward to email. [20:37:04] cool, and yep, agreed [20:44:02] (03CR) 10Manybubbles: "Speaking from the perspective of CirrusSearch, I approve of this change." [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem) [20:49:07] brion: I'm thinking of keeping the 'photographs' phrasing for now. Major opposition? [20:49:34] Who wants to extend the CheckUser extension to allow self-checks? [20:50:35] (03PS15) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 [20:53:02] (03PS1) 10Manybubbles: Switch incategory to simple matching. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82037 [20:53:14] Ryan_Lane: ? [20:54:25] (03PS1) 10Manybubbles: Test for incategory as term query. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/82038 [20:55:23] (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81961 (owner: 10Manybubbles) [20:58:20] (03PS16) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 [21:00:24] brion: http://blue-dragon.wmflabs.org/wiki/Campaign:show-off-campaigns [21:01:36] (03PS1) 10Krinkle: Title: Add byte class to unicode class conversion for js [core] - 10https://gerrit.wikimedia.org/r/82040 [21:03:28] (03PS2) 10Divec: Title: Add byte class to unicode class conversion for js [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [21:03:38] Project browsertests-test2.wikipedia.org-linux-firefox build #527: FAILURE in 37 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/527/ [21:03:44] (03PS1) 10BryanDavis: Add vim modeline to *.pp files. [vagrant] - 10https://gerrit.wikimedia.org/r/82041 [21:05:50] (03CR) 10BryanDavis: "Feel free to tell me this is dumb." [vagrant] - 10https://gerrit.wikimedia.org/r/82041 (owner: 10BryanDavis) [21:06:18] bd808: it's dumb. [21:06:32] (I don't actually know what patch that was, just obliging your request) :P [21:06:41] aah, modeline [21:06:57] bd808: why not just ship a .vimrc in it? if you set your vim properly it'll make sure to read your config [21:06:59] that's what I use. [21:08:08] you read .vimrc files in project dirs? Or you changed ~/.vimrc? [21:08:13] bd808: set exrc [21:08:14] (03CR) 10Krinkle: [C: 04-1] "Needs release notes. Also wait for the dependent change that is going to use this in mw.Title so we can make sure it works properly." [core] - 10https://gerrit.wikimedia.org/r/82040 (owner: 10Krinkle) [21:08:32] bd808: so I have a .vimrc in ~/code, and all my stuff is under that. [21:08:41] bd808: i have overrides in ~/code/vagrant for mediawiki style stuff [21:08:56] bd808: can have a .vimrc inside ~/code/vagrant/puppet for the puppet stuff [21:09:20] hmm [21:09:30] i want a message that says "You are already logged in as " [21:09:30] ah. gotcha. [21:09:42] does it need any gender stuff? [21:09:48] what I really need to do is convert to the cult of 4-space-tabstop [21:09:53] i guess i could always add it [21:10:03] I'm a 2-spacer by default [21:10:38] 8 spaces forever [21:10:48] bd808: pfft, 4spaces [21:11:20] bd808: hard tabs suck, tho [21:11:24] YuviPanda: it's looking good :D [21:11:30] brion: it is, indeed :) [21:11:36] brion: I'm worried about squid though. [21:12:17] :( [21:12:45] YuviPanda: by default i think the page is going to get cached… what you need to do is force the page to get invalidated when new items get added to the category, i think [21:12:47] brion: don't want people seeing stale stuff [21:12:51] right [21:12:56] brion: yeah, and that doesn't seem super simple. [21:13:07] how are Category: pages handling it currently? [21:13:35] brion: I... think they're done from the File class? [21:13:37] probably not at all :D [21:13:37] let me check [21:13:46] MatmaRex might be right too [21:13:50] * bd808 tatoos "2 space hard indent" under "80x50 of life" on arm [21:14:03] *for life [21:14:53] YuviPanda: it's in LinksUpdate class: [21:14:54] # Invalidate all categories which were added, deleted or changed (set symmetric difference) [21:15:19] brion: I see no mention of squid there? [21:15:21] * YuviPanda reads more [21:15:30] brion: oooh, i think this just updates the database [21:15:31] YuviPanda: it's not squid-specific [21:15:38] * YuviPanda looks for hooks [21:15:44] it invalidates the page caches, which also triggers the squid purge [21:16:51] YuviPanda: LinksUpdateComplete might be the place to go [21:17:39] question: why do the funky messages that are actually configuration contain 
 tags?  is that just in case someone tried to spit them out or are they spat out on some page by default?
[21:17:53] 	 brion: That method doesn't appear to purge squids, only update page_latest
[21:18:01] 	 (03CR) 10CSteipp: [C: 032 V: 032] Made sanity code to prevent session use actually work [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/79912 (owner: 10Aaron Schulz)
[21:18:04] 	 gaaaah, QuickTemplate needs to die in a fire
[21:18:07] 	 really
[21:18:10] 	 although I'd call that a bug
[21:18:20] 	 MatmaRex: find a way to use Twig!
[21:18:23] 	 hmmmmm
[21:19:02] 	 (03Abandoned) 10BryanDavis: Add vim modeline to *.pp files. [vagrant] - 10https://gerrit.wikimedia.org/r/82041 (owner: 10BryanDavis)
[21:19:26] 	 manybubbles: which ones?
[21:19:30] 	 brion: hmm, so hook on to LinksUpdateComplete, figure out the categories that were changed, find out if our category is one, and then purge?
[21:19:31] 	 manybubbles: ah, i see.
[21:19:39] 	 manybubbles: probably to look prettier when you're viewing MediaWiki: pages to edit them
[21:20:01] 	 YuviPanda: i'm wresting with userlogin and usercreate templates
[21:20:04] 	 MatmaRex: ah.  maybe I'm missing it.  let me mess with it me.
[21:20:22] 	 YuviPanda: and i just had to write this atrocity:
[21:20:27] 	 getMsg( 'userlogin-loggedin' )->params( $this->data['loggedinuser'] )->parseAsBlock(); ?>
[21:20:29] 	 YuviPanda: yeah something like that
[21:20:36] 	 i am utterly appaled.
[21:20:45] 	 (03CR) 10CSteipp: [C: 032 V: 032] Show authorize page on all wikis [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/81960 (owner: 10Aaron Schulz)
[21:20:59] 	 MatmaRex: I think if you work long enough with Mediawiki, your sense of code smell dimnishes significantly, and you stop being apalled by stupid shit.
[21:21:16] 	 brion: that sounds insane. but I guess I'll do that.
[21:21:20] 	 MatmaRex: it kinda looks crazy any way:  http://solr-mw3.instance-proxy.wmflabs.org/wiki/MediaWiki:Spam-blacklist
[21:21:33] 	 brion: also, I'll need to setup squid now
[21:21:34] 	 YuviPanda: Start reading extensions made by third parties, your sense of smell will still be there
[21:21:48] 	 bawolff: in the sense third party extensions are *good*?!
[21:22:01] 	 (03CR) 10Platonides: "Brion, this was intended as a ping to Yuvi, not as trying to move the discussion. I saw your comment *later*." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 (owner: 10Yuvipanda)
[21:22:07] 	 No, in the sense they will scare you to death
[21:22:16] 	 (03PS2) 10Matmarex: Special:UserLogin UI improvements when user is logged in [core] - 10https://gerrit.wikimedia.org/r/80769 
[21:22:17] 	 (03PS1) 10Matmarex: mediawiki.special.vforms: Information boxes' styles [core] - 10https://gerrit.wikimedia.org/r/82045 
[21:22:24] 	 bawolff: hehe, yeah - I guess core is sortof 'better'
[21:22:41] 	 (03PS1) 10Zfilipin: Renamed :cloudbees environment to :saucelabs. Removed ENVIRONMENT environment variable from Jenkins. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82046 
[21:22:52] 	 (03CR) 10jenkins-bot: [V: 04-1] Special:UserLogin UI improvements when user is logged in [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Matmarex)
[21:23:00] 	 (03CR) 10Matmarex: "Redone per discussion on bugzilla." [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Matmarex)
[21:23:21] 	 the hell, jenkins.
[21:24:55] 	 (03CR) 10Qgil: "As sidebars links are always blue, the disapoint they create among users clicking them is bigger..." [core] - 10https://gerrit.wikimedia.org/r/81938 (owner: 10Qgil)
[21:25:29] 	 YuviPanda: so it sounds like there's actually no objection to pretty displays of pictures, but merely an objection to removing the pretty-printed JSON structure.
[21:25:42] 	 brion: I think that was just tacked on afterwards :P
[21:25:46] 	 heh
[21:26:07] 	 brion: the original opening email was 'I will do everything I can to prevent this from being deployed', and isn't that a wonderful way to begin a productive discussion
[21:26:09] 	 well it's hard to tell when Platonides is guessing at Romaine's objections rather than us knowing them directly ;)
[21:26:18] 	 yeah
[21:26:33] 	 you gotta…… deal with poor conversation openers sometimes in this business ;)
[21:26:49] 	 brion: I think there should be separate bugs for whatever actionable things we want. I don't really think that bug is actionable.
[21:27:50] 	 yeah, that's why i'm trying to figure out what folks actually want
[21:27:56] 	 and then we can open clearer bugs
[21:28:01] 	 sweet
[21:28:12] 	 talking with Romaine, it sounded like he wanted to stop your patch because he felt it was either your patch or pretty display of json
[21:28:25] 	 bawolff: yeah that's a false dichotomy
[21:28:28] 	 we can easily have both
[21:28:38] 	 bawolff: that's not how any of those comments came in. pretty display wasn't even mentioned until what, 30 down?
[21:28:48] 	 though personally i consider the pretty table and the JSON to be equivalent, they're just a different formatting
[21:29:04] 	 Brion: I don't disagree, but I don't think romaine saw things that way
[21:29:06] 	 I know for a fact that I really, really suck at taking part in heated discussions where people keep talking past each other, and hence tune out.
[21:29:34] 	 YuviPanda: feel free to escalate such things to me, i've been dealing with such things for a decade :)
[21:29:41] 	 brion: awesome! thank you :)
[21:29:52] 	 I'll probably get better at those... over time?
[21:30:02] 	 i might even wade back into the android icon issue ;)
[21:30:18] 	 brion: the person who did the android icon is also the person who did the new mockups :D
[21:30:20] 	 When I was chatting with romaine, he didn't sound too thrilled about the idea of having the json in a collapsible section (Something about having to have 100 campaign pages open at a time, and needing to compare them all)
[21:30:25] 	 YuviPanda: we'll have to run a "dealing with stubborn people" training at the office sometime
[21:30:48] 	 bawolff: *shrug* a gadget perhaps.
[21:31:05] 	 (03CR) 10Matmarex: "New screenshot: http://i.imgur.com/09OlYOW.png" [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Matmarex)
[21:31:10] 	 ^ hawt.
[21:32:39] 	 bawolff: best would be if we get a clear idea of what overall workflow he needs/wants
[21:33:01] 	 then we can make sure we either build it in a way that works for him, or provide a good alternative that simplifies it while keeping it the way we want for more typical users
[21:34:24] 	 (03CR) 10BryanDavis: [C: 032] "Let's get this show on the road." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/77074 (owner: 10MarkTraceur)
[21:35:28] 	 Woot
[21:35:51] 	 (03CR) 10MarkTraceur: [V: 032] "Jenkins is a bastard and doesn't run here yet" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/77074 (owner: 10MarkTraceur)
[21:36:02] * marktraceur  enables jenkins for BF and MV
[21:36:12] 	 (03PS3) 10Matmarex: Special:UserLogin UI improvements when user is logged in [core] - 10https://gerrit.wikimedia.org/r/80769 
[21:36:13] 	 (03PS2) 10Matmarex: mediawiki.special.vforms: Information boxes' styles [core] - 10https://gerrit.wikimedia.org/r/82045 
[21:36:50] 	 (03CR) 10CSteipp: [C: 032 V: 032] Removed duplicate tests and easier to use TestOAuthConsumer script [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/81968 (owner: 10Aaron Schulz)
[21:37:45] 	 marktraceur: will you have to rebase 76198 now or will that happen automagically?
[21:38:40] 	 Er
[21:38:45] 	 bd808: Try hitting the rebase button
[21:39:21] 	 (03CR) 10CSteipp: [C: 032 V: 032] Make sure the consumer is applicable to this wiki [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80163 (owner: 10Aaron Schulz)
[21:39:35] 	 marktraceur: no joy :( conflict notice
[21:39:39] 	 KK
[21:39:43] 	 I'll rebase it in a sec
[21:40:24] 	 "a sec" being a very relative term
[21:40:55] 	 want me to do it?
[21:40:59] 	 (03PS2) 10Zfilipin: Move mediawiki_password from secret.yml to an environment variable. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81927 (owner: 10Yuvipanda)
[21:41:09] 	 If you'd like and can, sure
[21:41:34] * bd808  sweeps up the floor so we can get on with things
[21:41:42] 	 (03CR) 10Matmarex: "Here's a badass color wheel mockup I spent way too much time stiching together: http://i.imgur.com/HAYc4Oe.png (using https://kuler.adobe." [core] - 10https://gerrit.wikimedia.org/r/82045 (owner: 10Matmarex)
[21:43:12] 	 bd808: The procedure nut in me says "But then you can't review it" but I'm willing to beat him senseless for the time being
[21:44:30] 	 (03CR) 10Swalling: [C: 031] "With the warning box, I think you can stick with "Create another account". Other than that tweak, looks good." [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Matmarex)
[21:44:36] 	 (03PS4) 10Matmarex: Special:UserLogin UI improvements when user is logged in [core] - 10https://gerrit.wikimedia.org/r/80769 
[21:45:03] 	 (03PS1) 10Aklapper: Resync some Bugzilla customization files with upstream [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/82048 
[21:45:23] 	 marktraceur: I looked at it. Conflicts are in BetaFeatures.i18n.php && BetaFeatures.php. Not sure I know how to resolve. Kinda messy.
[21:45:44] 	 Yeah
[21:45:51] 	 The translators did their thing
[21:45:53] 	 I can fix it
[21:46:21] 	 (03PS5) 10Matmarex: Special:UserLogin UI improvements when user is logged in [core] - 10https://gerrit.wikimedia.org/r/80769 
[21:47:22] 	 (03CR) 10Matmarex: "Done." [core] - 10https://gerrit.wikimedia.org/r/80769 (owner: 10Matmarex)
[21:48:25] 	 (03PS17) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 
[21:52:10] 	 (03PS1) 10Zfilipin: Documented how to set up required environment variables [qa/browsertests] - 10https://gerrit.wikimedia.org/r/82049 
[21:52:49] 	 (03CR) 10Swalling: [C: 031] "We probably should have added styles like these to begin with. We can let the designers argue about or tweak the colors later if they want" [core] - 10https://gerrit.wikimedia.org/r/82045 (owner: 10Matmarex)
[21:54:03] 	 brion: btw, Romaine is in #wikimedia-commons , and was quite friendly to talk to (at least last night)
[21:54:17] 	 (03CR) 10Zfilipin: [C: 032] Move mediawiki_password from secret.yml to an environment variable. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/81927 (owner: 10Yuvipanda)
[21:55:10] 	 bawolff: spiff, i'll seek him out there, preferably after he replies on bug :)
[21:58:34] 	 (03PS1) 10Aklapper: Saved searches with longer names shared by others in sidebar did not wrap [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/82052 
[21:59:54] 	 (03CR) 10Aklapper: [C: 031] "Found by reading the code. Tested on boogs.wmflabs.org and it indeed fixes the problem." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/82052 (owner: 10Aklapper)
[22:01:24] 	 (03CR) 10CSteipp: [C: 032 V: 032] Added some extra rights checks to access controllers [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/81407 (owner: 10Aaron Schulz)
[22:03:10] 	 (03CR) 10Aaron Schulz: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/66366 (owner: 10Parent5446)
[22:05:41] 	 (03PS3) 10Manybubbles: Search headings. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/81961 
[22:09:58] 	 (03PS3) 10Aaron Schulz: Make use of field-specific HTMLForm errors which already use styling and show an error right next to the bad input [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80150 
[22:09:59] 	 (03CR) 10jenkins-bot: [V: 04-1] Make use of field-specific HTMLForm errors [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80150 (owner: 10Aaron Schulz)
[22:11:41] 	 (03PS4) 10Aaron Schulz: Make use of field-specific HTMLForm errors [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80150 
[22:11:53] 	 (03CR) 10Aaron Schulz: "Rebased" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80150 (owner: 10Aaron Schulz)
[22:12:12] 	 greg-g, you say "== Monday == No deploys! US holiday! (Labor Day)", but https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap lists 1.22wmf15 phase 2 (non-wikipedia sites)
[22:12:58] 	 Krenair: gues which one is wrong :)
[22:12:59] 	 +s
[22:13:53] 	 fixed
[22:15:16] 	 Ryan_Lane: time for a chat ?
[22:15:36] 	 Wikinaut: I looked at the code, but don't really know what's wrong with it
[22:15:43] 	 I'll need to install it and test
[22:15:48] 	 then track down the bug
[22:15:52] 	 let me explain
[22:15:53] 	 I'll do so when I get a chance
[22:16:32] 	 as admin, you set the name and email for a new account. But then, instead of mailing this data, the wiki says "You are already logged in"
[22:16:44] 	 wrong "context" ?
[22:17:12] 	 simply try, and you will see.
[22:17:34] 	 let meknow then, as comment on the commit, what needs to be fixed. thx in advance
[22:19:21] 	 (03PS3) 10Wikinaut: Bug 46617: Allow account creation through OpenID when the wiki disallows for anons [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 
[22:19:42] 	 (03CR) 10CSteipp: [C: 032 V: 032] Make use of field-specific HTMLForm errors [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/80150 (owner: 10Aaron Schulz)
[22:20:45] 	 (03PS3) 10Mwjames: [DIC]: Support deferred object registration [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81537 
[22:23:03] 	 (03PS1) 10MarkTraceur: Add Multimedia extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/82056 
[22:23:25] 	 (03PS1) 10MarkTraceur: Add Multimedia extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82057 
[22:24:37] 	 brion: ping?
[22:24:54] 	 YuviPanda: yo
[22:25:21] 	 brion: linksupdate might be hard too, since, there isn't an easy way to look at the category and figure out which campaign it is 
[22:25:22] 	 :|
[22:25:36] 	 hmmm we'll have to store some kind of reverse lookup table maybe
[22:25:53] 	 brion: augh, eugh. 
[22:26:04] 	 yay data tables :D
[22:26:12] 	 maybe page props?
[22:26:23] 	 save a property on the campaign page for the tracking category...
[22:26:34] 	 hmmmm that probably isn't indexed right though
[22:26:39] 	 yeah, i don't think it is
[22:27:17] 	 yeah indexes are on (page, propname) and (propname, page)
[22:27:24] 	 we'd need (pp_propname, pp_value, pp_page)
[22:27:44] 	 YuviPanda: During the upload process, is there anything special on the server side that happens with a campaign?
[22:27:51] 	 bawolff: none at all.
[22:27:59] 	 oh, well there goes that
[22:28:01] 	 yeah
[22:28:19] 	 bawolff: basically UploadWizard adds some parameters to what it saves into the description page
[22:28:20] 	 I suppose you could ?action=purge the campaign page via ajax
[22:28:23] 	 no special processing on the upload itself
[22:28:24] 	 heh
[22:28:28] 	 not the worst idea :D
[22:32:39] 	 csteipp: btw, maybe you can CR https://gerrit.wikimedia.org/r/#/c/81578/ ?
[22:33:01] 	 (03PS4) 10Mwjames: [DIC]: Support deferred object registration [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81537 
[22:33:28] 	 brion: bawolff I don't know if there's a way to do this without touching core
[22:33:36] 	 YuviPanda: anything else you need from me right away? i think i'm going to go home and take some ibuprofen, my back's acting up. i'm an old man now :(
[22:33:38] 	 although I'm now very, *very* tempted by the action=purge :D
[22:33:41] 	 hehe
[22:34:07] 	 YuviPanda: Just do ?action=purge, its way easier
[22:34:09] 	 brion: awww, no, do go home.
[22:34:16] 	 bawolff: well, there'll be other clients. like the app.
[22:34:32] 	 aww, that's sad
[22:34:44] 	 spiff. if you don't find a solution to the page invalidation give me another ping and i'll see if i can find the best place to modify core :)
[22:35:14] 	 brion: sweet
[22:35:27] 	 (03CR) 10CSteipp: [C: 032] Push counter updates to transaction end to avoid contention [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81578 (owner: 10Aaron Schulz)
[22:35:37] 	 (03Merged) 10jenkins-bot: Push counter updates to transaction end to avoid contention [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81578 (owner: 10Aaron Schulz)
[22:35:56] 	 ok see y'all online in a bit
[22:36:55] 	 bawolff: thoughts on adding an 'extradata' param to https://www.mediawiki.org/wiki/API:Upload
[22:37:09] 	 bawolff: and having it available in UploadComplete, so we can do stuff there?
[22:37:16] 	 ugh, that sounds so ugly...
[22:37:29] 	 (03CR) 10Mwjames: [C: 032] "Code coverage is 100%" [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81537 (owner: 10Mwjames)
[22:37:43] 	 although it would be cool if we could also add to the log entry that the upload was part of a campaign
[22:38:13] 	 bawolff: we can't really directly extend the API, can we?
[22:38:39] 	 bawolff: we can extend it to action=uploadwithcampaign, which just inherits from the current code and adds stuff. but that sounds ugly
[22:38:43] 	 Krinkle: Do you know if there's wildcard support for JJB? Like deploying "mwext-BetaFeatures-*" or so?
[22:39:03] 	 (03Merged) 10jenkins-bot: [DIC]: Support deferred object registration [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81537 (owner: 10Mwjames)
[22:39:52] 	 marktraceur: I don't think so, but there's variable support
[22:39:54] 	 yeah
[22:40:00] 	 marktraceur: like {jobname}-qunit
[22:40:13] 	 marktraceur: where would you need that though?
[22:40:17] 	 maybe use job groups
[22:40:21] 	 Krinkle: I mean, when deploying
[22:40:25] 	 So you mean in zuul?
[22:40:31] 	 oh for the command line tool
[22:40:34] 	 e.g. jenkins-jobs --conf etc/jenkins_jobs.ini update config/ 'mediawiki-core-merge'
[22:40:35] 	 yeah, that won't work
[22:40:38] 	 Damn.
[22:40:45] 	 you can do glob expansion on the output/ directory and list those arguments
[22:40:45] * marktraceur  does it by hand
[22:40:46] 	 marktraceur: 
[22:40:46] 	 bawolff: thoughts on action=uploadwithcampaign?
[22:41:06] 	 if you write a bash utilility for that, please share :)
[22:41:11] 	 ugh, it sounds kind of icky
[22:41:19] 	 but I don't have better ideas
[22:41:34] 	 basically output/mediawiki-core-* but then have it strip output/ back out
[22:41:38] 	 You could add a hook to the upload action, and add an extra parameter
[22:41:47] 	 might be less ugly then duplicating the entire thing
[22:41:56] 	 bawolff: well, i'll just inherit, and override?
[22:41:58] 	 Krinkle: I don't think it's worth it :)
[22:42:19] 	 I mean duplication from a user prespective where there are two modules that do almost the exact same thing
[22:42:29] 	 hmm, that is correct
[22:42:45] 	 having a campaign= param is distinctly better, yes
[22:42:59] 	 We could just not cache things in squid ;)
[22:43:13] 	 bawolff: that is not a viable long term solution, but :P
[22:43:34] 	 bawolff: all staff is a week away, I'm sure *someone* will have my head on a pole if I pushed this to production without *any* caching what so ever
[22:44:12] 	 Add parser caching instead, that checks to see if the category has been modified + maybe some very short lived (like 20 minutes) squid caching
[22:44:19] * marktraceur  thinks it might be him
[22:44:39] 	 bawolff: parser caching means I've to do it per language.
[22:44:52] 	 bawolff: I guess squid does that automatically (vary by uselang?)
[22:44:52] 	 err, i mean memcache, not parser caching
[22:44:58] 	 bawolff: yeah, I assumed :)
[22:45:15] 	 Squid only applies to anons, so no lang preference
[22:45:27] 	 and it varies by the url, so ?uselang= triggers different urls
[22:45:32] 	 (03CR) 10MarkTraceur: [C: 032] "<3 automatic tests for this stuff." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/82056 (owner: 10MarkTraceur)
[22:45:33] 	 oh, right. good enough
[22:46:23] 	 bawolff: even with memecached, it will need a proper invalidation mechanism.
[22:47:07] 	 Maybe insead of invalidation, everytime its accessed do a cheap query of looking at max(cl_timestamp) of your category
[22:47:08] 	 (03CR) 10MarkTraceur: [C: 032] Add Multimedia extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82057 (owner: 10MarkTraceur)
[22:47:30] 	 ah, hmm.
[22:47:33] 	 if that changes, invalidate.
[22:47:36] 	 invalidate on read.
[22:47:38] 	 ah, 
[22:48:20] 	 max(cl_timestamp) should be read directly off the index, so it should be cheap as far as db queries go. Its still a db query on every read though
[22:48:47] 	 (03PS2) 10MarkTraceur: Add Multimedia extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82057 
[22:48:57] 	 (03CR) 10MarkTraceur: [C: 032] "Whine whine whine" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82057 (owner: 10MarkTraceur)
[22:49:06] 	 (03Merged) 10jenkins-bot: Add Multimedia extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/82057 (owner: 10MarkTraceur)
[22:50:16] 	 (03PS2) 10MarkTraceur: Add Multimedia extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/82056 
[22:50:25] 	 (03CR) 10MarkTraceur: [C: 032] "My god, gerrit is picky." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/82056 (owner: 10MarkTraceur)
[22:50:54] 	 (03Merged) 10jenkins-bot: Add Multimedia extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/82056 (owner: 10MarkTraceur)
[22:51:05] 	 (03PS1) 10Aaron Schulz: Made use of field-specific HTMLForm errors more [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/82060 
[22:51:10] 	 marktraceur: cherry-picky? :P
[22:51:34] * marktraceur  giggles
[22:51:37] 	 Hilaaarious
[22:51:40] 	 bawolff: hmm, so on every GET, read max(cl_timestamp), compare it to a cached one, and if it doesn't match, invalidate?
[22:51:49] 	 yeah
[22:51:51] 	 marktraceur: yeah, typical me :)
[22:52:25] 	 bawolff: still doesn't give us squid, though.
[22:52:27] 	 and maybe very short lived squid cache (like 10 minutes) just to be on the safe side
[22:52:45] 	 and hope people aren't bothered by pages being 10 minutes outdated
[22:52:45] 	 bawolff: hmm, right. 10 mins doesn't sound too bad, since anons
[22:52:56] 	 yeah, but eventually we need to fix this anyway.
[22:53:21] 	 bawolff: hmm, another option would be to render the galleries purely client side
[22:53:27] 	 bawolff: with API calls. 
[22:53:34] 	 bawolff: so no caching issues.
[22:53:41] 	 but then we'll hit the API hard(er?)
[22:53:45] 	 since there's no squid
[22:54:00] * YuviPanda  starts etherpad
[22:54:06] 	 API requests can get cached in squid if you set the smaxage url parameter
[22:54:13] 	 ah, hmm.
[22:54:28] 	 http://etherpad.wikimedia.org/p/uploadcampaigns-squids
[22:54:38] 	 but yeah, I think that'd be equivalent to just not having squid caching, in which case we might as well just disable squid caching for campaign pages
[22:54:56] 	 yeah
[22:55:34] 	 bawolff: hmm, I am thinking that the easiest course of action is to just have a short squid timeout (~15 mins?)
[22:55:45] 	 bawolff: and... that's it.
[22:56:41] 	 Hmm, I tend to agree. Its not like these pages will be super expensive to render
[22:56:51] 	 yeah, they're quick enough
[22:57:01] 	 (03PS4) 10Mwjames: [DIC]: \SMW\JobBase implements \SMW\DependencyRequestor [extensions/SemanticMediaWiki] - 10https://gerrit.wikimedia.org/r/81449 
[22:58:10] 	 So yeah, super short squid, and if performance becomes an issue, look into doing memcache caching with invalidation as a primary means of caching
[22:58:41] 	 bawolff: yup. I don't think it'll bring the servers melting.
[22:58:55] 	 (03PS14) 10MarkTraceur: Use the new feature field [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 
[22:59:24] 	 Failure !?
[22:59:32] * marktraceur  has words with himself over failing jslint
[22:59:57] 	 Oh, just need a jshintrc.
[23:00:17] 	 bd808: 76198 is now rebased and V+2'd
[23:00:30] 	 bawolff: hmm, and I'll make that a configurable parameter, so can be adjusted upwards if it ends up being a problem
[23:00:30] 	 Er, +1'd
[23:00:39] 	 I guess it'll get +2'd when you C+2
[23:00:42] 	 bawolff: and we can figure out squid stuff on the way
[23:01:42] 	 YuviPanda: btw, do you think that most people viewing campaign pages will be logged in or logged out?
[23:02:09] 	 bawolff: I'd say logged out, simply because most people who view pages in general are logged out, and hence by extension...
[23:02:28] 	 but people who upload images have to be logged in
[23:02:36] 	 of course.
[23:02:41] 	 and its not a stretch to imaging people who look at these pages will be uploading images
[23:02:50] 	 and some people will bounce out
[23:03:34] 	 bawolff: why, btw?
[23:04:22] 	 Just because if 90% of people are logged in, then squid won't be an effective cache anyways, so there would be no point worrying about it
[23:04:32] 	 hmm, yeah, we don't actually know
[23:04:48] 	 I think 1. add ~10 min squid cache and 2. wait and watch is a good solution
[23:05:19] 	 bawolff, unless it's linked from a news site for "See the cool images that are being uploaded"
[23:05:31] 	 which is a major use case, of sorts?
[23:05:42] 	 but 10 min squid cache should be enough, I'd think
[23:05:55] 	 Platonides: good point
[23:06:18] 	 and having a short lived squid cache should prevent a sudden unexpected influx from being a DOS
[23:08:35] * YuviPanda  modifies patch
[23:09:13] 	 YuviPanda: Probably a good idea to add wfProfileIn/wfProfileOut 's in various places in your code, just in case
[23:09:28] 	 good idea, bawolff
[23:09:29] 	 Yippie, build fixed!
[23:09:29] 	 Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #7: FIXED in 19 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/7/
[23:09:37] 	 let me add the configurable squid stuff first
[23:10:20] 	 YuviPanda, is trackingCategory configurable?
[23:10:29] 	 Platonides: it is, yeah.
[23:10:52] 	 Platonides: not on a per-campaign basis, but
[23:13:49] 	 (03PS18) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 
[23:13:50] 	 bawolff: squid stuff added. 
[23:18:10] 	 (03CR) 10Aaron Schulz: [C: 031] Replace germanism "sighted" in review levels with an equivalent [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/78647 (owner: 10Nemo bis)
[23:28:25] 	 (03CR) 10Dzahn: [C: 032] Saved searches with longer names shared by others in sidebar did not wrap [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/82052 (owner: 10Aklapper)
[23:28:32] 	 (03CR) 10Dzahn: [V: 032] Saved searches with longer names shared by others in sidebar did not wrap [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/82052 (owner: 10Aklapper)
[23:35:06] 	 (03CR) 10BryanDavis: [C: 032] "Boom goes the dynamite" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 (owner: 10MarkTraceur)
[23:35:09] 	 (03Merged) 10jenkins-bot: Use the new feature field [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/76198 (owner: 10MarkTraceur)
[23:35:19] 	 Woo
[23:35:38] * marktraceur  thinks there was one more that he needed to work on, plus edsanders had a patch
[23:35:51] 	 Also <3 jenkins
[23:38:35] 	 (03PS1) 10Platonides: gb uses article [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/82064 
[23:45:28] 	 (03PS4) 10BryanDavis: Throw errors if required fields missing [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/81147 (owner: 10MarkTraceur)
[23:49:46] 	 (03PS5) 10MarkTraceur: Throw errors if required fields missing [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/81147 
[23:49:52] 	 (03PS19) 10Yuvipanda: Show campaign info + last updated images + cta in Campaign: page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/81453 
[23:53:29] 	 marktraceur: CSS question?
[23:53:36] 	 YuviPanda: CSS answer
[23:53:39] 	 if you see http://blue-dragon.wmflabs.org/wiki/Campaign:show-off-campaigns, the long line in description doesn't wrap
[23:53:58] 	 Yes it does
[23:53:59] 	 if the desc is shorter, those two big numbers would be on the top right, rather than squished down
[23:54:02] 	 Oh
[23:54:05] 	 I see whatcha mean
[23:54:13] 	 I don't think 'wrap' was the word I needed, yes
[23:54:15] 	 YuviPanda: That's how floating works
[23:54:17] 	 but you see what I mean
[23:54:26] 	 marktraceur: yeah, but how do I make it not work that way? 
[23:54:27] * marktraceur  thinks
[23:54:32] 	 I... want to do columns, that's all, really
[23:54:36] * YuviPanda  misses bootstrap sorely
[23:54:57] 	 superm401: weren't you talking of adding a grid to mediawiki?
[23:55:00] 	 or is that someone else...
[23:55:17] 	 YuviPanda: You could use some nasty-ish conglomeration of absolute and relative positionings to do it, but I suspect you'll balk at that
[23:55:44] 	 are columns really that hard?
[23:55:48] 	 YuviPanda, Pau has been working on it.
[23:55:51] 	 But it's in very early stages.
[23:55:53] 	 ah, hmm
[23:55:55] 	 that'll be nice
[23:56:29] 	 I don't really know how easy it's going to be to integrate with existing content (which all have their own styles, some inline, some from Common.css).
[23:56:42] 	 And we still have a ways to go just rolling out mw.ui.
[23:56:49] 	 Buttons, text boxes, etc.
[23:57:41] 	 YuviPanda: You could set the widths dynamically with JS (also nasty)
[23:58:06] 	 marktraceur: yes.
[23:58:24] 	 But, it would also work
[23:58:30] 	 So there's that
[23:58:42] 	 YuviPanda, all you want to do is keep the numbers after the description?
[23:58:44] 	 i wonder what all those crazy grid systems use?
[23:58:47] 	 YuviPanda: I could whip up a funky example of what I mean about absolute/relative positioning if you wanted
[23:58:56] 	 superm401: i want the numbers in the top right
[23:59:04] 	 Oh wait. /me thinks
[23:59:13] 	 (03PS10) 10PleaseStand: Introducing JsonFallback [core] - 10https://gerrit.wikimedia.org/r/78941 
[23:59:13] 	 superm401: like https://s3.amazonaws.com/f.cl.ly/items/0B2l2I2K1L0W161k1V3Q/campaigns-2.png
[23:59:21] 	 Yeah, that would work probably