[00:03:40] (03CR) 10Parent5446: [C: 031] Remove 'Debug' hook from wfDebug and wfDebugLog [core] - 10https://gerrit.wikimedia.org/r/90453 (owner: 10EBernhardson) [00:06:57] (03CR) 10Parent5446: [C: 031] "Looks good, but gonna let somebody else do the merging." [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [00:52:08] (03CR) 10Parent5446: [C: 032] Remove 'Debug' hook from wfDebug and wfDebugLog [core] - 10https://gerrit.wikimedia.org/r/90453 (owner: 10EBernhardson) [00:54:58] (03Merged) 10jenkins-bot: Remove 'Debug' hook from wfDebug and wfDebugLog [core] - 10https://gerrit.wikimedia.org/r/90453 (owner: 10EBernhardson) [01:06:40] (03CR) 10Parent5446: "I like Umherirrender's idea of adding the assertions to the main module, that way it's available everywhere. Also I would consider adding " [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [01:07:33] (03CR) 10Parent5446: [C: 04-1] Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [01:12:48] (03PS4) 10Parent5446: Remove $wgBlockOpenProxies [core] - 10https://gerrit.wikimedia.org/r/87302 (owner: 10PleaseStand) [01:12:54] (03CR) 10Parent5446: [C: 032] Remove proxy check in EditPage.php [core] - 10https://gerrit.wikimedia.org/r/87302 (owner: 10PleaseStand) [01:15:24] (03CR) 10Parent5446: [C: 032] Make it possible for EditPage::getCopyrightWarning to return HTML [core] - 10https://gerrit.wikimedia.org/r/90289 (owner: 10Legoktm) [01:15:34] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [01:17:20] (03CR) 10Krinkle: "Quick note: Beware of the difference between javascript disabled (noscript) and javascript blacklisted (browsers not supporting our js-lev" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [01:17:28] (03PS4) 10Krinkle: Remove HTML back-compat styles from I5fe0543e [core] - 10https://gerrit.wikimedia.org/r/82102 (owner: 10Bartosz Dziewoński) [01:17:53] (03Merged) 10jenkins-bot: Remove proxy check in EditPage.php [core] - 10https://gerrit.wikimedia.org/r/87302 (owner: 10PleaseStand) [01:18:42] (03CR) 10Parent5446: [C: 032] Simplify boolean attribute handling for Html::input in templates [core] - 10https://gerrit.wikimedia.org/r/90155 (owner: 10Bartosz Dziewoński) [01:19:29] (03Merged) 10jenkins-bot: Make it possible for EditPage::getCopyrightWarning to return HTML [core] - 10https://gerrit.wikimedia.org/r/90289 (owner: 10Legoktm) [01:20:22] (03CR) 10Parent5446: [C: 031] Clean up old title on move before reset article id [core] - 10https://gerrit.wikimedia.org/r/89226 (owner: 10Umherirrender) [01:20:42] (03PS2) 10Parent5446: Fix default value of domain select box in templates [core] - 10https://gerrit.wikimedia.org/r/90156 (owner: 10Bartosz Dziewoński) [01:22:57] (03CR) 10Parent5446: [C: 031] Fix default value of domain select box in templates [core] - 10https://gerrit.wikimedia.org/r/90156 (owner: 10Bartosz Dziewoński) [01:24:29] (03Merged) 10jenkins-bot: Simplify boolean attribute handling for Html::input in templates [core] - 10https://gerrit.wikimedia.org/r/90155 (owner: 10Bartosz Dziewoński) [01:33:57] (03PS6) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [01:34:09] (03CR) 10Parent5446: "PS6: Removed them pesky evil tabs and spaces." [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [01:34:29] (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [02:00:57] (03PS2) 10Parent5446: Make autoblocks update with the parent block [core] - 10https://gerrit.wikimedia.org/r/66366 [02:00:58] (03PS1) 10Parent5446: Added DatabaseBase::startAtomic and endAtomic [core] - 10https://gerrit.wikimedia.org/r/90856 [02:02:19] (03PS7) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [02:23:45] (03PS1) 10Gnosygnu: v0.10.2.0 [xowa] - 10https://gerrit.wikimedia.org/r/90857 [02:24:07] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/90857 (owner: 10Gnosygnu) [03:34:20] (03PS1) 10Krinkle: installer: Make css error more discoverable [core] - 10https://gerrit.wikimedia.org/r/90858 [03:35:15] (03CR) 10Krinkle: [C: 04-1] "As Bartosz said already, use skinStyles. Module names should be generic and representative of something that can be loaded at any time. So" [core] - 10https://gerrit.wikimedia.org/r/87170 (owner: 10Jdlrobson) [03:35:47] (03PS2) 10Krinkle: installer: Make css error more discoverable [core] - 10https://gerrit.wikimedia.org/r/90858 [04:16:45] (03PS3) 10Legoktm: Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 [04:20:50] (03CR) 10Legoktm: "I moved all the code into ApiMain, which means it applies for all API modules." [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [04:29:03] (03CR) 10Krinkle: "+fixme: Release notes entry is incorrect. This commit includes a removal from hooks.txt, so it wasn't undocumented now was it?" [core] - 10https://gerrit.wikimedia.org/r/90453 (owner: 10EBernhardson) [04:29:53] (03PS3) 10Ori.livneh: Add method for inspecting module dependency relations [core] - 10https://gerrit.wikimedia.org/r/89608 [04:52:03] (03CR) 10Ori.livneh: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [05:07:39] (03PS8) 10Legoktm: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 [05:10:43] (03PS1) 10Legoktm: Use TitleCase for job names [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90864 [05:13:45] (03CR) 10Aaron Schulz: [C: 032] Use TitleCase for job names [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90864 (owner: 10Legoktm) [05:13:53] (03Merged) 10jenkins-bot: Use TitleCase for job names [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90864 (owner: 10Legoktm) [05:14:47] thanks :D [05:19:13] (03PS1) 10Legoktm: Add $wgAllowGlobalMessaging to the README [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90865 [05:27:17] (03PS1) 10Legoktm: Use EditPage::getCopyrightWarning directly for message [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90866 [06:04:34] (03CR) 10Krinkle: "@Ori: I'm not sure I understand. Are you saying modules (do now in master / should continue to) re-use the old timestamp if a change is ro" [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [06:07:12] (03CR) 10Ori.livneh: "Ping?" [core] - 10https://gerrit.wikimedia.org/r/80958 (owner: 10Ori.livneh) [06:09:24] (03CR) 10PleaseStand: "Removing -1. I really *don't* want to have to reimplement a substantial portion of ResourceLoader path logic." [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [06:12:56] (03PS3) 10Krinkle: Installer: Run the LESS compiler for screen.less [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [06:23:14] (03PS4) 10Krinkle: installer: Run the LESS compiler for screen.less [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [06:24:34] (03CR) 10Krinkle: [C: 04-1] "Merged I69b0ce7f40e86 into this and improved the error message by not outputting "Unable to read" when there is in fact a compilation erro" [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [06:24:47] (03Abandoned) 10Krinkle: installer: Prepend css errors to the top of the response output [core] - 10https://gerrit.wikimedia.org/r/90858 (owner: 10Krinkle) [06:52:21] (03PS6) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [06:57:00] (03CR) 10Physikerwelt: [V: 032] "I have verified the correctness of the code as described here" [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [07:04:41] (03PS5) 10PleaseStand: installer: Run the LESS compiler for screen.less [core] - 10https://gerrit.wikimedia.org/r/89610 [07:06:12] (03CR) 10PleaseStand: "Changed "screen.less" to "styles.less" to prevent the exception. Apparently this changed since I started working on this patch." [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [07:38:59] Krinkle: morning :-] [07:39:11] is that your late night or already your morning? :D [07:41:13] yo, hashar ! [07:41:29] i have hacked another module yesterday :) [07:42:35] \O/ [07:42:42] matanya: was it the gibson? [07:42:51] matanya: I guess you have more experience than me now :-] [07:42:52] no p858snake|l [07:43:27] no, i don't hashar. I still do stupid mistakes, any build flaky modules [07:44:43] on the bright side, my ssh module was merged :D [07:45:25] what is gibson p858snake|l ? [07:47:27] it was a movie reference from hackers [07:48:42] hashar: morning :) [07:59:45] I am going to upgrade Jenkins / restart it for a scheduled maintenance. Expected downtime: 1 hour starting now. [08:08:03] (03PS7) 10Siebrand: Update docs and declare visibility on class props [core] - 10https://gerrit.wikimedia.org/r/87556 [08:11:39] santhosh: around? [08:13:54] (03CR) 10Siebrand: "(11 comments)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [08:14:36] (03CR) 10Siebrand: "Ping?" [core] - 10https://gerrit.wikimedia.org/r/87510 (owner: 10Siebrand) [08:16:09] (03CR) 10Krinkle: [C: 031] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [08:22:19] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [08:24:47] (03PS2) 10Netbrain: Added #subpage functionality Given the subpages A/B/C [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/90536 [08:26:36] (03CR) 10Netbrain: "(1 comment)" [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/90536 (owner: 10Netbrain) [08:47:14] (03PS1) 10Addshore: Add @covers tags for more tests [core] - 10https://gerrit.wikimedia.org/r/90872 [08:51:45] (03PS1) 10Zfilipin: A few ULS Jenkins jobs are deleted and one is created [selenium] - 10https://gerrit.wikimedia.org/r/90875 [09:04:04] Jenkins should be back up now :-] [09:09:47] (03PS2) 10Addshore: Add @covers tags for more tests [core] - 10https://gerrit.wikimedia.org/r/90872 [09:11:32] (03Abandoned) 10Hashar: standalone phpunit for Ask and Diff [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/65467 (owner: 10Hashar) [09:16:11] (03CR) 10Matthias Mullie: [C: 031] New hook accomidates non-revision rc queries [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson) [09:16:30] addshore: reviewing your @covers change :] [09:17:06] addshore: are you sure we can add @covers ? [09:17:44] Do you mean are we sure we can add it and it will work or are you sure we should add it? :) [09:18:34] testing [09:18:41] if that works on ZipDirectoryReader [09:18:47] we might want to do the same for the Xml class [09:19:29] but with the Xml class you can see specifically which methods it is testing :) [09:19:55] marking a class as covered by a test call workes fine with coverage, currently in wikibase thats the level to which we mark our tests [09:20:51] (03PS3) 10Netbrain: Added #subpage functionality and fixed small js scope issue Given the subpages A/B/C [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/90536 [09:21:18] addshore: sorry I don't get it [09:21:43] @covers ZipDirectoryReader seems to produce proper coverage report [09:21:51] yup [09:21:52] what would fail if we do the same on the Xml test class ? [09:22:13] well, nothing would fail, but things might show as covered that are not actually covered [09:22:35] ah cause some XML methods can call other XML methods I guess [09:22:37] ie. if php passes over the code in a test but the test isnt actually testing that codes functionality [09:22:42] indeed :) [09:22:59] whereas the ZipDirectoryReaderTest is rather a broad test [09:23:11] broad ? [09:23:18] ahh [09:23:26] yeah more like an integration test [09:23:27] well, there is only 1 test method that seems to apparently test the whole thing ;p [09:23:31] yup [09:23:37] I want to eventually decouple unit and integration tests [09:23:52] that would be great :P [09:24:02] * Reedy pets hashar [09:24:47] addshore: will leave some notes [09:25:00] will probably spend an hour on a filght tomorrow doing more test cleanup [09:25:31] addshore: and have you tested we can enter two @covers messages ? [09:26:34] (03CR) 10Hashar: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90872 (owner: 10Addshore) [09:26:39] addshore: https://gerrit.wikimedia.org/r/#/c/90872/2/tests/phpunit/includes/ZipDirectoryReaderTest.php,unified [09:26:48] addshore: just add a comment in ZipDirectoryReaderTest [09:26:50] hashar: yes you can :) [09:27:34] amend and I +2 it :-] [09:29:17] (03PS3) 10Addshore: Add @covers tags for more tests [core] - 10https://gerrit.wikimedia.org/r/90872 [09:29:18] hashar: ^^ [09:29:24] easy [09:29:49] (03CR) 10Hashar: [C: 032] "Thank you." [core] - 10https://gerrit.wikimedia.org/r/90872 (owner: 10Addshore) [09:30:04] shame there is no graph on the coverage report showing coverage over time [09:30:14] we can potentially achieve that [09:30:24] would be nice to be able to see the progress [09:30:48] the job at https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/ [09:30:51] might be loading something [09:30:52] (or not) [09:31:12] (03PS2) 10Pastakhov: Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 [09:31:16] --coverage-clover Generate code coverage report in Clover XML format. [09:31:17] --coverage-html Generate code coverage report in HTML format. [09:31:17] hmm [09:31:24] maybe there is a plug to interpret clover XML [09:31:36] unless we just archive the old report before creating the new one? [09:31:53] well the report is fairly big [09:31:57] how big? :P [09:32:01] archiving them is going to eat disk space [09:32:21] * hashar looks at https://wiki.jenkins-ci.org/display/JENKINS/Clover+PHP+Plugin [09:32:52] hashar: that looks nice ;p [09:33:32] cd tests/phpunit; php phpunit.php --coverage-html /tmp/cover --coverage-clover /tmp/clover.xml includes/ZipDirectoryReaderTest.php [09:33:33] trying [09:34:13] I am not sure why there is a "Clover PHP Plugin" [09:34:16] AND a Clover plugin [09:34:21] (03Merged) 10jenkins-bot: Add @covers tags for more tests [core] - 10https://gerrit.wikimedia.org/r/90872 (owner: 10Addshore) [09:34:22] (03PS8) 10Siebrand: Update docs and declare visibility on class props [core] - 10https://gerrit.wikimedia.org/r/87556 [09:34:39] (03CR) 10Siebrand: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [09:39:12] hey the plugin can ever publish a HTML report [09:39:17] :D [09:42:00] but it is not supported by Jenkins Job Builder :] [09:45:54] hashar: so, what did you mean by "merge all jobs"? [09:45:58] heh, hashar turns out one failure Jeroen emailed you about has gone, but now the old one has reappeared [09:49:42] (03CR) 10Krinkle: "Causes bug 55963." [core] - 10https://gerrit.wikimedia.org/r/25838 (owner: 10Jarry1250) [09:50:48] (03CR) 10Pastakhov: [C: 032] Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 (owner: 10Pastakhov) [09:50:59] (03CR) 10jenkins-bot: [V: 04-1] Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 (owner: 10Pastakhov) [10:09:55] why tests don't passed by jenkins? [10:10:23] https://integration.wikimedia.org/ci/job/mwext-Foxway-testextensions-master/81/console [10:15:06] pastakhov: the errors are all listed in https://integration.wikimedia.org/ci/job/mwext-Foxway-testextensions-master/81/consoleFull [10:17:50] AzaToth: ah sorry, well instead of having -source -binaries -piuparts, there is now only a -debian-glue job [10:18:09] AzaToth: this way copying the proper artifacts is no more an issue :-] [10:18:33] AzaToth: I got some jobs deployed, I think pybal and wikistats are more or less building now (the later having lintian errors) [10:21:51] addshore: i realy need pass-by-reference in Compiler.php:269 and all constans is defined [10:22:58] addshore: all phpunit test passed locally [10:24:57] pastakhov: why? :O [10:29:11] addshore: i need link in array. I'll try rewrite code... [10:34:16] (03PS1) 10Hashar: fetch-mw-ext: show git bare dir being used [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90889 [10:34:28] (03CR) 10Hashar: [C: 032] fetch-mw-ext: show git bare dir being used [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90889 (owner: 10Hashar) [10:34:31] (03Merged) 10jenkins-bot: fetch-mw-ext: show git bare dir being used [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90889 (owner: 10Hashar) [10:35:51] (03PS3) 10Pastakhov: Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 [10:36:42] (03CR) 10Pastakhov: [C: 032] Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 (owner: 10Pastakhov) [10:36:48] (03CR) 10jenkins-bot: [V: 04-1] Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 (owner: 10Pastakhov) [10:40:34] zeljkof: Yay! One green light for ULS on https://wmf.ci.cloudbees.com/ [10:40:47] siebrand: :) [10:41:06] a small green light... [10:41:46] (03PS4) 10Pastakhov: Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 [10:42:17] (03CR) 10Pastakhov: [C: 032] Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 (owner: 10Pastakhov) [10:42:23] (03CR) 10jenkins-bot: [V: 04-1] Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 (owner: 10Pastakhov) [10:45:51] addshore: i can't rewrite all code. how to insert a variable by reference to the beginning of the array without using references? [10:46:51] addshore: i use function array_unshift($array, &$variable); [10:47:48] addshore: why is this not correct? [10:49:45] pastakhov: see http://php.net/manual/en/language.references.pass.php [10:49:53] Note: There is no reference sign on a function call - only on function definitions. Function definitions alone are enough to correctly pass the argument by reference. As of PHP 5.3.0, you will get a warning saying that "call-time pass-by-reference" is deprecated when you use & in foo(&$a);. And as of PHP 5.4.0, call-time pass-by-reference was removed, so [10:49:53] using it will raise a fatal error. [10:52:27] addshore: i use PHP 5.3.0 it don't saying "call-time pass-by-reference" [10:53:16] (03CR) 10Esanders: [C: 032] Shift divs about [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/87279 (owner: 10MarkTraceur) [10:53:22] (03Merged) 10jenkins-bot: Shift divs about [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/87279 (owner: 10MarkTraceur) [10:54:03] pastakhov: you are probably not displaying all errors / notices etc. http://php.net/manual/en/function.error-reporting.php [10:54:11] addshore: i can't rewrite php function array_unshift. i need insert variable by reference in array. how can I do it differently? [10:59:34] pastakhov: You could try array_splice($array, 0, 0, array(&$variable)) [11:03:21] addshore: i use "error_reporting: E_ALL | E_STRICT" in php.ini and do not get warnings [11:05:39] PleaseStand: yes, i can. but i need max speed. I do not understand why I can not use references in PHP function array_unshift [11:07:52] Sync to github is possibly broken. Changes merged since 6 hours ago are not in the Translate repo. [11:08:13] Correction: also changes made y'day are not synchronised. [11:08:43] YuviPanda: Do you know who to ping when there's no sync from gerrit to github? [11:09:33] gmorning all [11:09:34] hmm [11:09:40] that doesn't sound good [11:10:09] siebrand: I'd ping ^d but I'm sure he's not awake just yet [11:10:18] https://bugzilla.wikimedia.org/show_bug.cgi?id=55948 [11:10:18] not likely. [11:10:31] hell i shouldn't be awake, it's early :) [11:11:10] PleaseStand: Thanks. [11:11:18] Bug marked as a blocker for the past 10 houts. [11:11:21] hours. [11:11:22] :( [11:12:19] gerrit slow. Fix by using GitHub. No replication to github. Stuck. [11:16:02] addshore: i use PHP 5.3.17 and PHPUnit 3.7.24. locally all phpunit test is passed. may be a problem in PHP 5.3.10 is used by Jenkins? [11:17:57] (03CR) 10Nikerabbit: [C: 031] A few ULS Jenkins jobs are deleted and one is created [selenium] - 10https://gerrit.wikimedia.org/r/90875 (owner: 10Zfilipin) [11:31:27] (03PS1) 10Siebrand: Update formatting [extensions/cldr] - 10https://gerrit.wikimedia.org/r/90890 [11:32:02] (03CR) 10Liangent: "gwicke, you should have fixed the commit message before merging.." [core] - 10https://gerrit.wikimedia.org/r/83112 (owner: 10Liangent) [11:36:33] (03CR) 10Siebrand: "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/90291 (owner: 10Legoktm) [11:36:39] (03CR) 10Siebrand: [C: 031] Merge SimpleAntiSpam extension into core [core] - 10https://gerrit.wikimedia.org/r/90291 (owner: 10Legoktm) [11:42:30] (03Abandoned) 10Ebrahim: Native digits on 'articlefeedbackv5-article-feedback-link' [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/90349 (owner: 10Ebrahim) [11:45:55] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [11:46:02] (03CR) 10Siebrand: [C: 04-1] Install without XML support [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [11:54:16] (03CR) 10Bartosz Dziewoński: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90866 (owner: 10Legoktm) [11:56:21] (03PS7) 10Siebrand: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [11:58:05] (03CR) 10Reza: "it is ok" [core] - 10https://gerrit.wikimedia.org/r/88767 (owner: 10Ebrahim) [12:02:37] (03PS1) 10Siebrand: Use i18n instead of hardcoded brackets and spaces [core] - 10https://gerrit.wikimedia.org/r/90892 [12:08:19] (03PS8) 10Physikerwelt: Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 [12:13:18] (03PS2) 10Siebrand: Use i18n instead of hardcoded brackets and spaces [core] - 10https://gerrit.wikimedia.org/r/90892 [12:16:20] (03CR) 10Siebrand: [C: 04-1] "If this gets merged anytime soon, it should be 1.22, not 1.23. Deprecation needs release notes." [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [12:20:35] (03PS5) 10Hashar: Declare visibility on class properties [core] - 10https://gerrit.wikimedia.org/r/87510 (owner: 10Siebrand) [12:20:42] (03CR) 10Hashar: [C: 032] Declare visibility on class properties [core] - 10https://gerrit.wikimedia.org/r/87510 (owner: 10Siebrand) [12:25:11] (03Merged) 10jenkins-bot: Declare visibility on class properties [core] - 10https://gerrit.wikimedia.org/r/87510 (owner: 10Siebrand) [12:37:04] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83584 (owner: 10Reedy) [12:44:28] (03PS2) 10Zfilipin: Relevant links [selenium] - 10https://gerrit.wikimedia.org/r/90562 [12:48:07] (03CR) 10Siebrand: "The i18n is semantically wrong. See below." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [12:49:14] (03PS1) 10Jarry1250: Generalise filename-matching in mediawiki.Title.newFromImg() [core] - 10https://gerrit.wikimedia.org/r/90897 [12:50:38] (03PS1) 10Zfilipin: The gem homepage now points to Gerrit repository [selenium] - 10https://gerrit.wikimedia.org/r/90898 [12:59:33] (03CR) 10Matthias Mullie: "http://www.mediawiki.org/wiki/Localisation#.E2.80.A6on_numbers_via_PLURAL" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [13:01:14] (03CR) 10Cmcmahon: [C: 032] "maintenance" [selenium] - 10https://gerrit.wikimedia.org/r/90525 (owner: 10Zfilipin) [13:02:06] (03CR) 10Cmcmahon: [C: 032] "documentation" [selenium] - 10https://gerrit.wikimedia.org/r/90531 (owner: 10Zfilipin) [13:02:49] (03CR) 10Cmcmahon: [C: 032] Cleanup of gemspec file [selenium] - 10https://gerrit.wikimedia.org/r/90532 (owner: 10Zfilipin) [13:03:13] (03CR) 10Cmcmahon: [C: 032] "docs" [selenium] - 10https://gerrit.wikimedia.org/r/90535 (owner: 10Zfilipin) [13:03:36] (03PS3) 10Cmcmahon: Moving documenation to mediawiki/selenium repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/90534 (owner: 10Zfilipin) [13:03:52] (03CR) 10Cmcmahon: [C: 032] Moving documenation to mediawiki/selenium repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/90534 (owner: 10Zfilipin) [13:08:37] (03PS2) 10Zfilipin: Moving gems that all repositores need to the gem [selenium] - 10https://gerrit.wikimedia.org/r/90532 [13:12:47] (03PS6) 10Zfilipin: Moving code used in multiple repositores to a Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87125 [13:12:49] (03CR) 10jenkins-bot: [V: 04-1] Moving code used in multiple repositores to a Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87125 (owner: 10Zfilipin) [13:14:10] (03CR) 10Bene: [C: 031] "Looks good." [core] - 10https://gerrit.wikimedia.org/r/90892 (owner: 10Siebrand) [13:17:18] (03CR) 10Cmcmahon: [C: 032] "documentation" [selenium] - 10https://gerrit.wikimedia.org/r/90875 (owner: 10Zfilipin) [13:18:04] (03CR) 10Cmcmahon: [C: 032] "documentation" [selenium] - 10https://gerrit.wikimedia.org/r/90562 (owner: 10Zfilipin) [13:19:39] (03CR) 10Cmcmahon: [C: 032] "use production URL in gerrit" [selenium] - 10https://gerrit.wikimedia.org/r/90898 (owner: 10Zfilipin) [13:20:28] (03CR) 10Cmcmahon: "maintenance" [selenium] - 10https://gerrit.wikimedia.org/r/90525 (owner: 10Zfilipin) [13:20:37] (03PS7) 10Zfilipin: Moving code used in multiple repositores to a Ruby gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87125 [13:20:40] (03CR) 10Bartosz Dziewoński: "Might wanna add some more tests." [core] - 10https://gerrit.wikimedia.org/r/90897 (owner: 10Jarry1250) [13:21:54] (03CR) 10Cmcmahon: [C: 032] Moving gems that all repositores need to the gem [selenium] - 10https://gerrit.wikimedia.org/r/90532 (owner: 10Zfilipin) [13:22:11] (03PS2) 10Zfilipin: Deleted unused files [selenium] - 10https://gerrit.wikimedia.org/r/90525 [13:28:57] (03PS3) 10Zfilipin: Deleted unused files [selenium] - 10https://gerrit.wikimedia.org/r/90525 [13:30:10] (03PS1) 10Hashar: rename mediawiki-vagrant.yaml to mediawiki-misc.yaml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90900 [13:30:12] (03PS1) 10Hashar: mediawiki-selenium-ruby1.9.3lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90901 [13:30:31] (03CR) 10Hashar: [C: 032] rename mediawiki-vagrant.yaml to mediawiki-misc.yaml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90900 (owner: 10Hashar) [13:30:33] (03CR) 10Hashar: [C: 032] mediawiki-selenium-ruby1.9.3lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90901 (owner: 10Hashar) [13:30:37] (03PS1) 10Matthias Mullie: WIP - Add PostBlock (similar to TopicBlock) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90902 [13:30:43] (03CR) 10jenkins-bot: [V: 04-1] WIP - Add PostBlock (similar to TopicBlock) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90902 (owner: 10Matthias Mullie) [13:31:05] (03Merged) 10jenkins-bot: rename mediawiki-vagrant.yaml to mediawiki-misc.yaml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90900 (owner: 10Hashar) [13:31:07] (03CR) 10Siebrand: "You only need to special case 0 and 2 for English, as they need to override "other" (the second plural form). This format isn't being used" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [13:31:21] (03Merged) 10jenkins-bot: mediawiki-selenium-ruby1.9.3lint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90901 (owner: 10Hashar) [13:32:16] (03PS1) 10Hashar: trigger mediawiki-selenium-ruby1.9.3lint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/90903 [13:32:25] (03PS4) 10Zfilipin: Deleted unused files [selenium] - 10https://gerrit.wikimedia.org/r/90525 [13:32:55] (03CR) 10Hashar: [C: 032] trigger mediawiki-selenium-ruby1.9.3lint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/90903 (owner: 10Hashar) [13:33:04] (03Merged) 10jenkins-bot: trigger mediawiki-selenium-ruby1.9.3lint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/90903 (owner: 10Hashar) [13:33:58] (03CR) 10Hashar: [C: 032] "There were no job in Jenkins/Zuul. Lets see what happens." [selenium] - 10https://gerrit.wikimedia.org/r/90898 (owner: 10Zfilipin) [13:33:59] (03Merged) 10jenkins-bot: The gem homepage now points to Gerrit repository [selenium] - 10https://gerrit.wikimedia.org/r/90898 (owner: 10Zfilipin) [13:36:49] (03CR) 10Zfilipin: [C: 032] Deleted unused files [selenium] - 10https://gerrit.wikimedia.org/r/90525 (owner: 10Zfilipin) [13:36:51] (03Merged) 10jenkins-bot: Deleted unused files [selenium] - 10https://gerrit.wikimedia.org/r/90525 (owner: 10Zfilipin) [13:37:24] (03CR) 10Zfilipin: [C: 032] Moving gems that all repositores need to the gem [selenium] - 10https://gerrit.wikimedia.org/r/90532 (owner: 10Zfilipin) [13:37:25] (03CR) 10jenkins-bot: [V: 04-1] Moving gems that all repositores need to the gem [selenium] - 10https://gerrit.wikimedia.org/r/90532 (owner: 10Zfilipin) [13:37:58] (03PS2) 10Matthias Mullie: WIP - Add PostBlock (similar to TopicBlock) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90902 [13:38:09] (03CR) 10Zfilipin: [C: 032] A few ULS Jenkins jobs are deleted and one is created [selenium] - 10https://gerrit.wikimedia.org/r/90875 (owner: 10Zfilipin) [13:38:36] (03CR) 10Zfilipin: [C: 032] Upated todo with usage instructions [selenium] - 10https://gerrit.wikimedia.org/r/90531 (owner: 10Zfilipin) [13:38:38] (03CR) 10Gergő Tisza: [C: 04-1] "getIndependentMetaArray is now called getCommonMetaArray." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/67588 (owner: 10Brian Wolff) [13:38:39] (03Merged) 10jenkins-bot: Upated todo with usage instructions [selenium] - 10https://gerrit.wikimedia.org/r/90531 (owner: 10Zfilipin) [13:40:15] (03CR) 10Zfilipin: [C: 032] Relevant links [selenium] - 10https://gerrit.wikimedia.org/r/90562 (owner: 10Zfilipin) [13:40:17] (03Merged) 10jenkins-bot: Relevant links [selenium] - 10https://gerrit.wikimedia.org/r/90562 (owner: 10Zfilipin) [13:40:42] (03CR) 10Zfilipin: [C: 032] Moved documentation from qa/browsertests repository [selenium] - 10https://gerrit.wikimedia.org/r/90535 (owner: 10Zfilipin) [13:40:44] (03Merged) 10jenkins-bot: A few ULS Jenkins jobs are deleted and one is created [selenium] - 10https://gerrit.wikimedia.org/r/90875 (owner: 10Zfilipin) [13:40:45] (03Merged) 10jenkins-bot: Moved documentation from qa/browsertests repository [selenium] - 10https://gerrit.wikimedia.org/r/90535 (owner: 10Zfilipin) [13:42:31] (03PS3) 10Zfilipin: Moving gems that all repositores need to the gem [selenium] - 10https://gerrit.wikimedia.org/r/90532 [13:43:29] (03CR) 10Zfilipin: [C: 032] Moving gems that all repositores need to the gem [selenium] - 10https://gerrit.wikimedia.org/r/90532 (owner: 10Zfilipin) [13:43:31] (03Merged) 10jenkins-bot: Moving gems that all repositores need to the gem [selenium] - 10https://gerrit.wikimedia.org/r/90532 (owner: 10Zfilipin) [13:45:24] (03PS1) 10Matthias Mullie: Fix i18n introduced in cf47618cf3f9012596e0ecaf434f665ce944d542 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90904 [13:48:23] (03CR) 10Cmcmahon: [C: 032] "move code to shared gem" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87125 (owner: 10Zfilipin) [13:50:07] (03CR) 10Addshore: [C: 04-1] "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 (owner: 10Legoktm) [13:51:24] (03CR) 10Addshore: [C: 04-1] "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [13:52:18] (03CR) 10Zfilipin: "Nik, is there a reason you did not vote on this commit in the last two weeks? Do you have any questions?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/87552 (owner: 10Zfilipin) [13:53:30] (03CR) 10Matthias Mullie: "I've submitted https://gerrit.wikimedia.org/r/#/c/90904/, which should fix the message according to your suggestions." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [13:55:56] (03PS2) 10Matthias Mullie: Fix i18n introduced in cf47618cf3f9012596e0ecaf434f665ce944d542 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90904 [13:56:33] (03CR) 10Matthias Mullie: [C: 032] Click is no longer required to activate textarea [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90300 (owner: 10Matthias Mullie) [13:56:38] (03Merged) 10jenkins-bot: Click is no longer required to activate textarea [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90300 (owner: 10Matthias Mullie) [14:00:19] (03CR) 10Siebrand: [C: 031] "Looks good to me. Holding off on merging because I'm waiting for a confirmation of someone else on the LangEng team." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90904 (owner: 10Matthias Mullie) [14:05:19] (03PS1) 10Zfilipin: Bump patch version [selenium] - 10https://gerrit.wikimedia.org/r/90906 [14:07:29] (03PS2) 10Zfilipin: Bump patch version [selenium] - 10https://gerrit.wikimedia.org/r/90906 [14:18:55] (03PS5) 10Esanders: Compatibility filters for BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 [14:18:56] (03CR) 10jenkins-bot: [V: 04-1] Compatibility filters for BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders) [14:23:34] (03PS6) 10Esanders: Compatibility filters for BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 [14:26:35] (03PS7) 10Esanders: Compatibility filters for BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 [14:26:57] (03CR) 10Nikerabbit: "Looks okay. My only concern is that the behavior with languages which also have 2 as keyword form might be confusing for translators." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90904 (owner: 10Matthias Mullie) [14:28:06] (03CR) 10Esanders: "I've removed all the code which disables the checkbox, as these are only supposed to be warnings, and it avoids the situation where a warn" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders) [14:39:48] (03CR) 10Gergő Tisza: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/67047 (owner: 10Brian Wolff) [14:51:54] (03PS3) 10Zfilipin: Bump patch version [selenium] - 10https://gerrit.wikimedia.org/r/90906 [15:00:35] (03PS1) 10Zfilipin: Updated Ruby gems [qa/browsertests] - 10https://gerrit.wikimedia.org/r/90912 [15:02:02] (03CR) 10Cmcmahon: [C: 032] Updated Ruby gems [qa/browsertests] - 10https://gerrit.wikimedia.org/r/90912 (owner: 10Zfilipin) [15:05:14] hashar: ping [15:05:22] sorry [15:06:24] Krinkle: connecting [15:07:50] hashar: Don't suppose your going to the NL conference this year? [15:07:58] Reedy: most probably not [15:08:04] leaving for conf call with timo then I am out [15:10:02] (03CR) 10Gergő Tisza: "For PNG sometimes the value is an array (e.g. Software key in https://commons.wikimedia.org/wiki/File:MediaViewer_Sept9.png ), which cause" [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff) [15:11:47] (03CR) 10Siebrand: [C: 032] Fix i18n introduced in cf47618cf3f9012596e0ecaf434f665ce944d542 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90904 (owner: 10Matthias Mullie) [15:11:52] (03Merged) 10jenkins-bot: Fix i18n introduced in cf47618cf3f9012596e0ecaf434f665ce944d542 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90904 (owner: 10Matthias Mullie) [15:17:50] (03CR) 10Anomie: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/88889 (owner: 10MarkTraceur) [15:18:33] (03PS3) 10MaxSem: Port to express [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/90770 [15:19:10] Krinkle: Do you and the VE guys and/or other WMF staff etc got anything else planned for the NL conference weekend? [15:19:16] Trying to decide whether to escape for the weekend.. [15:19:17] plop [15:19:26] (03CR) 10MaxSem: [C: 032 V: 032] "Meh? Meh!" [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/90770 (owner: 10MaxSem) [15:20:54] I love forms where you can select both yes and no at the same time [15:28:20] Reedy: I'm going to be there, Ed Sanders and David Chan [15:28:22] as well [15:28:49] Yeah, I gleaned that much information from the programme page ;) [15:29:32] Need to also do a beer run, so potentially pretty well timed ;) [15:29:42] (03PS2) 10Jarry1250: Generalise filename-matching in mediawiki.Title.newFromImg() [core] - 10https://gerrit.wikimedia.org/r/90897 [15:36:43] (03CR) 10Anomie: "The code here seems to be in a decently sane state now. Haven't tested though." [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [15:39:03] Reedy: oh sorry, I missed what you were asking -_- [15:39:08] :D [15:39:21] Reedy: We're all going to be there for different number of days, but at least 1 day before and after. [15:39:32] Staying at a hotel in the centre of utrecht. [15:39:39] Hotels on the doorstep of the venue seem pretty reasonable value [15:41:35] greg-g: Are we going to have 1.22wmf23? I thought we were switching to 1.23wmf1 this week, but https://www.mediawiki.org/w/index.php?title=MediaWiki_1.22/Roadmap&diff=0&oldid=803998 says otherwise… [15:42:12] Should be to 24 AFAIK [15:42:21] well, here's a thought: [15:42:44] 1.22wmf rand() [15:42:45] M&M will probably branch on Thursday, so, it would seem logical for us to move to 1.23wmf1 on Thurs as well. [15:42:59] Reedy: Err. Currently-deployed is 21/22. Why 24? [15:43:06] I hadn't updated the roadmap since the email of the M&M strategy just was sent last week [15:43:18] greg-g: Yeah, that's why I was surprised it was changed by some IP to go against what I understood the plan was. :-) [15:43:21] but MJ has a trademark on 23 [15:43:45] MJ? [15:43:48] James_F: oh, I see (hadn't yet looked at the diff) ;) [15:43:55] Micheal Jordan [15:44:05] not Jackson [15:44:10] I don't know that developer? [15:44:20] haha [15:44:43] * greg-g is not sure if joking or James_F doesn't know US basketball legend [15:45:36] (03PS2) 10Legoktm: Use EditPage::getCopyrightWarning directly for message [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90866 [15:45:38] * James_F Googles. [15:45:45] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90866 (owner: 10Legoktm) [15:45:51] Oh. OK… [15:46:02] * James_F assumes that this is funny to an American. [15:46:38] it was :P [15:47:51] * Reedy frowns [15:49:40] greg-g, Reedy: https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap now exists. :-) [15:50:07] ohnoes [15:50:18] now we HAVE to do it [15:50:24] ?action=delete [15:50:25] * James_F cackles. [15:51:06] greg-g: If you're quick and use your shell access you can truncate the database and then purge it from squid [15:52:08] haha [15:52:54] * Reedy runs to tell ^d [15:53:04] <^d> Hrm? [16:08:45] (03PS1) 10Matthias Mullie: Hide mediawiki action tabs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90917 [16:15:22] (03PS4) 10Brian Wolff: Cache page content language in Title object. [core] - 10https://gerrit.wikimedia.org/r/90769 [16:20:32] (03PS1) 10Gergő Tisza: Return assessment level [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90919 [16:22:02] (03PS3) 10Dan-nl: second source field mapping dissapears [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 [16:22:46] (03CR) 10Dan-nl: "(22 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 (owner: 10Dan-nl) [16:25:27] (03CR) 10Krinkle: [C: 031] Generalise filename-matching in mediawiki.Title.newFromImg() [core] - 10https://gerrit.wikimedia.org/r/90897 (owner: 10Jarry1250) [16:26:34] (03PS7) 10Gergő Tisza: Add extmetadata to the ForeignAPIFile iiprops [core] - 10https://gerrit.wikimedia.org/r/88889 (owner: 10MarkTraceur) [16:26:49] (03PS3) 10Krinkle: Generalise filename-matching in mediawiki.Title.newFromImg() [core] - 10https://gerrit.wikimedia.org/r/90897 (owner: 10Jarry1250) [16:26:54] (03CR) 10Krinkle: [C: 032] mediawiki.Title: Generalise filename-matching in newFromImg [core] - 10https://gerrit.wikimedia.org/r/90897 (owner: 10Jarry1250) [16:27:55] (03CR) 10Krinkle: [C: 031] Update docs and declare visibility on class props [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [16:31:31] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.Title: Generalise filename-matching in newFromImg [core] - 10https://gerrit.wikimedia.org/r/90897 (owner: 10Jarry1250) [16:34:08] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [16:34:54] (03PS1) 10Esanders: Layout fixes to BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/90924 [16:35:00] (03CR) 10jenkins-bot: [V: 04-1] Layout fixes to BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/90924 (owner: 10Esanders) [16:35:18] (03CR) 10MarkAHershberger: "Thanks for suggesting this, Siebrand. I'll add it to the make-release script." [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [16:35:21] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [16:35:35] edsanders: Thanks for the merge, let's see if I can't return the favour here [16:35:53] (03CR) 10Krinkle: "mediawiki.Title - newFromImg...ERROR" [core] - 10https://gerrit.wikimedia.org/r/90897 (owner: 10Jarry1250) [16:36:26] Muahaha, tests. [16:36:32] didn't know you had any [16:36:55] edsanders: The security guard problem, I guess - if they're doing their job you don't notice it :) [16:39:01] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/90924 (owner: 10Esanders) [16:39:40] (03CR) 10Anomie: [C: 031] "Seems ok. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/88889 (owner: 10MarkTraceur) [16:45:51] (03CR) 10Siebrand: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/88889 (owner: 10MarkTraceur) [16:49:06] (03PS2) 10Esanders: Layout fixes to BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/90924 [16:53:34] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79852 (owner: 10Aaron Schulz) [17:00:06] (03CR) 10MarkTraceur: [C: 04-1] "Also, put it in an array on the backend so we don't have to add licenses in five separate places." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 (owner: 10MarkTraceur) [17:01:08] (03PS9) 10Physikerwelt: Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 [17:07:00] when would some be able to revert the change that causes this bug - https://bugzilla.wikimedia.org/show_bug.cgi?id=55501 ? (the bug was reported almost 2 weeks ago) [17:10:04] (03CR) 10Aaron Schulz: "@Nike: so there must also be DB changes that don't make it into the DB in addition to whatever the callback was. Any idea what started the" [core] - 10https://gerrit.wikimedia.org/r/79852 (owner: 10Aaron Schulz) [17:14:48] (03CR) 10MarkTraceur: [C: 031] "(2 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders) [17:15:36] (03PS3) 10Aaron Schulz: Added a few more trx sanity checks to DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/79852 [17:18:46] (03CR) 10Siebrand: [C: 032] Add missing parameters to message call [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/79201 (owner: 10Grunny) [17:19:16] (03Merged) 10jenkins-bot: Add missing parameters to message call [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/79201 (owner: 10Grunny) [17:20:24] (03PS1) 10Aaron Schulz: Added ceph comment [core] - 10https://gerrit.wikimedia.org/r/90927 [17:22:02] (03PS4) 10Yuvipanda: Add 'RedisPubSubFeedEngine' feed engine [core] - 10https://gerrit.wikimedia.org/r/80958 (owner: 10Ori.livneh) [17:26:08] (03CR) 10Siebrand: [C: 031] Layout fixes to BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/90924 (owner: 10Esanders) [17:26:30] (03CR) 10Aaron Schulz: [C: 032] Added ceph comment [core] - 10https://gerrit.wikimedia.org/r/90927 (owner: 10Aaron Schulz) [17:27:17] (03PS1) 10Krinkle: jquery.localize: Fix incorrect use of void tag for [core] - 10https://gerrit.wikimedia.org/r/90928 [17:29:24] (03PS1) 10Krinkle: Fix typo erronously -> erroneously [core] - 10https://gerrit.wikimedia.org/r/90929 [17:29:41] ori-l: the redis patch, I tested it, and it works. [17:29:47] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/33085 (owner: 10Daniel Kinzler) [17:29:56] (03CR) 10Bartosz Dziewoński: [C: 032] Use EditPage::getCopyrightWarning directly for message [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90866 (owner: 10Legoktm) [17:30:08] (03Merged) 10jenkins-bot: Added ceph comment [core] - 10https://gerrit.wikimedia.org/r/90927 (owner: 10Aaron Schulz) [17:30:14] ori-l: I guess with appropriately different names for different wikis, it won't cause issues in a wikifarm environment [17:31:07] (03CR) 10Yuvipanda: [C: 032] "Does what it says on the cover" [core] - 10https://gerrit.wikimedia.org/r/80958 (owner: 10Ori.livneh) [17:31:40] (03Merged) 10jenkins-bot: Use EditPage::getCopyrightWarning directly for message [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90866 (owner: 10Legoktm) [17:32:16] (03CR) 10Anomie: [C: 032] Fix typo erronously -> erroneously [core] - 10https://gerrit.wikimedia.org/r/90929 (owner: 10Krinkle) [17:32:32] ori-l: +2'd! [17:36:17] ori-l: now to enable it somewhere... [17:36:48] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90897 (owner: 10Jarry1250) [17:37:38] (03Merged) 10jenkins-bot: Add 'RedisPubSubFeedEngine' feed engine [core] - 10https://gerrit.wikimedia.org/r/80958 (owner: 10Ori.livneh) [17:39:14] (03Merged) 10jenkins-bot: Fix typo erronously -> erroneously [core] - 10https://gerrit.wikimedia.org/r/90929 (owner: 10Krinkle) [17:39:39] (03CR) 10Anomie: [C: 032] "Confirmed tests now pass in IE6-8 (in Browserstack)." [core] - 10https://gerrit.wikimedia.org/r/90928 (owner: 10Krinkle) [17:40:14] (03CR) 10Aaron Schulz: [C: 032] Clean up old title on move before reset article id [core] - 10https://gerrit.wikimedia.org/r/89226 (owner: 10Umherirrender) [17:43:39] (03Merged) 10jenkins-bot: jquery.localize: Fix incorrect use of void tag for [core] - 10https://gerrit.wikimedia.org/r/90928 (owner: 10Krinkle) [17:45:28] (03Merged) 10jenkins-bot: Clean up old title on move before reset article id [core] - 10https://gerrit.wikimedia.org/r/89226 (owner: 10Umherirrender) [17:45:48] DarTar: Shouldn't you revoke your -1 for https://gerrit.wikimedia.org/r/90073 now?+ [17:46:35] marktraceur: yes, let me do that [17:46:45] Thankee [17:46:58] You could even +2 if you felt so inclined [17:47:09] * marktraceur is hopeful [17:47:27] (03CR) 10Brian Wolff: "If the other change ever gets merged, I'll fix this one up. That method has already been renamed twice per various people's -1's, I wouldn" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/67588 (owner: 10Brian Wolff) [17:49:21] (03CR) 10DarTar: [C: 031] "Reviewed the schema and checked in with Mark: no rev_id or page_id is tracked. We should revisit any change in instrumentation from a priv" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90073 (owner: 10MarkTraceur) [17:50:26] (03CR) 10Brian Wolff: "Actually I think everything should be normalized to an array (Its not just PNG stuff that is in array, JPEG stuff can be to)" [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff) [17:56:58] (03CR) 10MarkTraceur: [C: 04-1] "-1 for changing the designs seemingly without discussion - if the designers were on Gerrit I would add them, but meh." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/90924 (owner: 10Esanders) [17:57:39] heh [17:57:47] (03CR) 10Alex Monk: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [17:57:58] They're not even on bloody IRC right now [17:58:08] Not that Jared is anyway [17:58:24] * marktraceur runs off flailing his arms and yelling I NEED DESIGN HELP [17:58:32] ...except not actually. [17:59:36] marktraceur: does design need to personally lift the -1? :D [18:02:37] (03PS1) 10Siebrand: Backport compatible message changes from master. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/90933 [18:03:22] YuviPanda: It would be a good way to motivate them to get on Gerrit [18:03:33] "Hey. This is your shit. Deal with it. I'm not merging it." [18:05:25] *crickets* [18:05:33] if i revert a change thats been +2 and merged, can new patchset be submitted and re-merged? [18:06:06] ebernhardson: I think not - delete the change-id and rebase onto latest master probably [18:06:34] marktraceur: ok [18:08:27] (03CR) 10Siebrand: [C: 032] Backport compatible message changes from master. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/90933 (owner: 10Siebrand) [18:10:11] (03CR) 10EBernhardson: "More just a comment on future functionality, it is intended that a single topic will be able to be attached to multiple topic_list's (and" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90474 (owner: 10Legoktm) [18:10:50] ebernhardson: Yeah, thats what I thought. How "future" are we talking about though? :P [18:11:06] gwicke: http://discuss.joelonsoftware.com/?joel.3.219431.12 is a funny read [18:11:39] lazyktm: not sure yet :P since the mvp release is only to a couple wikiprojects and not user talk pages we didn't think it was worth implementing in this set of sprints [18:12:58] (03Merged) 10jenkins-bot: Backport compatible message changes from master. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/90933 (owner: 10Siebrand) [18:15:26] .join #wikivoyage [18:18:08] (03PS6) 10MarkTraceur: Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 [18:27:03] (03PS1) 10Siebrand: Backport compatible message changes from master. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/90936 [18:28:47] (03CR) 10Siebrand: [C: 032] Backport compatible message changes from master. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/90936 (owner: 10Siebrand) [18:30:55] MatmaRex, check email about Architecture Summit, please reply whenever you have time. Thank you! [18:32:22] qgil: yes, yes, i remember, thanks [18:32:34] :) [18:33:02] i'm busy right now, will get around to it in a few hours :) [18:33:37] sorry for being slow [18:33:40] (03CR) 10Nikerabbit: "Not really. The only tips I have is that it seems to be related to spam bot activity and blocking code." [core] - 10https://gerrit.wikimedia.org/r/79852 (owner: 10Aaron Schulz) [18:33:45] (03Merged) 10jenkins-bot: Backport compatible message changes from master. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/90936 (owner: 10Siebrand) [18:39:38] [21-Oct-2013 18:34:12] Fatal error: Invalid host name (wikipedia). [18:39:38] at /usr/local/apache/common-local/multiversion/MWMultiVersion.php on line 370 [18:39:38] Server: mw1112 [18:39:38] Method: GET [18:39:38] URL: http://wikipedia/ [18:39:39] lol [18:40:53] lol [18:45:58] ori-l: i've been using xhprof for mw profiling, i started over the weekend on an xhprof module for mediawiki/vagrant. Mostly its just installing a pear package and configuring apache to serve up /usr/share/php/xhprof_html on /xhprof/ prefix, but i'm not sure where to put instructions about enabling xhprof for mediawiki(its a few lines in StartProfile.php) [18:46:24] s/pear/pecl/ [18:46:32] can the role do it automatically? [18:46:56] if you're not sure how to do it, feel free to submit what you have as a patch and i'll look it over [18:47:20] ori-l: hmm, we can write to the file but your probably dont want it enabled by default, i keep 'return;' as the begining of the file and remove it when i want profiling info [18:47:26] ori-l: seem reasonable? [18:47:47] otherwise, the same can be tweaked with mw variabels about profiling frequency [18:47:54] ebernhardson: yeah, query params are another way [18:48:22] ebernhardson: in fact, look at LocalSettings.php -- i set something up already [18:48:36] the main one in the vagrant repo root, lines 63-67 [18:49:52] (03CR) 10Amire80: [C: 031] Remove "Talk:" prefix from "You have new messages" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90500 (owner: 10Legoktm) [18:51:02] ori-l: ahha, i see. The thing is enabling it doesn't actually use a MW profiler class, xhprof kinda does everything but writing the profile somewhere on its own. This is the "enable" code: http://pastie.org/8419378 [18:51:16] i suppose proper would be to implement a Profiler class that does that, will look into it tonight [18:52:19] ebernhardson: ahh, that would be very cool. haven't thought about it deeply, but that sounds like the right idea. [18:52:22] ebernhardson: thanks for working on this! [18:52:29] and if you get stuck, please do submit a patch anyway [18:52:34] ori-l: kk [18:52:50] ori-l: thanks for fixing up the forwarded_port issue. I woke up and saw it was merged laready [18:53:07] YuviPanda: no problem :) [18:53:51] ori-l: so I guess next step for an xmpp broadcast thing is to have someone write a redis -> ejabberd deamon? [18:54:00] ori-l: or a xmpp subclass in mw itself? [18:54:15] YuviPanda: sounds like push notifications? [18:54:20] * ebernhardson wants push notifications :) [18:54:23] ori-l: feel free to respond later, i see you're in multiple channels [18:54:30] ebernhardson: coming to an app near you, hopefully in a few months :P [18:54:39] (03CR) 10Bartosz Dziewoński: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90500 (owner: 10Legoktm) [18:54:40] ebernhardson: this is, however, different. [18:54:49] ebernhardson: the RC feeds change, which is currently available only via... IRC [18:55:18] ebernhardson: for the app, my idea is to hook into Echo at the point where it goes 'oh, here is a message X for User Y', and then push it to the apps from there. [18:55:22] YuviPanda: i dont know if i should be happy or not:P Design really wants push notifications in flow so things like new posts while reading show up, but I've been assuming we would need to implement some push infrastructure for all of mw [18:55:31] (03PS1) 10Siebrand: Backport compatible message changes from master. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/90942 [18:55:32] should be as 'realtime' as Echo itself [18:55:36] YuviPanda: that, though Krinkle was making the case for going with WebSockets from the get-go, and you seem to have experience with nginx now (which is the standard thing to put in front of node/websockets), so maybe you could try that [18:55:43] YuviPanda: oh, so no websockets or long polling? [18:55:47] ebernhardson: ah, this, we're not sure, but is going to be app specific (GCM or whatever iOS uses) [18:55:50] ebernhardson: native apps :P [18:56:01] YuviPanda: though there are outstanding issues with the actual JSON data (i.e., which datapoints it encodes) [18:56:15] YuviPanda: you should check out brion's comments on the big pluggable RC engine patch [18:56:20] ori-l: okay, will do [18:56:21] and ping Krenair about it too [18:56:29] (03PS2) 10Legoktm: Remove "Talk:" prefix from "You have new messages" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90500 [18:56:36] (03CR) 10Legoktm: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90500 (owner: 10Legoktm) [18:58:38] i have comments on pluggable rc engine patch? i should probably reread them too :D [18:59:54] brion: https://gerrit.wikimedia.org/r/#/c/52922/ [19:00:03] ^ YuviPanda [19:04:32] (03CR) 10Siebrand: [C: 032] Backport compatible message changes from master. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/90942 (owner: 10Siebrand) [19:06:11] brion, ori-l: Ugh. I don't deal with comments after merge well. I keep forgetting about those. [19:06:37] * ori-l reverts and re-submits [19:06:39] j/k [19:06:46] brion: RE https://gerrit.wikimedia.org/r/#/c/52922/25/includes/rcfeed/IRCColourfulRCFeedFormatter.php - please remember most of this was just moved from another class/file [19:07:55] on the ['len']['old'] vs. ['old']['len'] thing - I'm not interested in changing that myself, but feel free to do it as I don't expect anyone to be really using this feature yet [19:08:26] (03Merged) 10jenkins-bot: Backport compatible message changes from master. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/90942 (owner: 10Siebrand) [19:13:39] (03PS1) 10Siebrand: Backport compatible message changes from master. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/90945 [19:13:57] (03CR) 10Siebrand: [C: 032] Backport compatible message changes from master. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/90945 (owner: 10Siebrand) [19:20:18] (03Merged) 10jenkins-bot: Backport compatible message changes from master. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/90945 (owner: 10Siebrand) [19:24:53] (03CR) 10Bartosz Dziewoński: [C: 032] Remove "Talk:" prefix from "You have new messages" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90500 (owner: 10Legoktm) [19:25:03] (03PS1) 10Siebrand: Backport compatible message changes from master. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/90958 [19:25:18] (03CR) 10Siebrand: [C: 032] Backport compatible message changes from master. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/90958 (owner: 10Siebrand) [19:25:41] (03Merged) 10jenkins-bot: Remove "Talk:" prefix from "You have new messages" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90500 (owner: 10Legoktm) [19:25:56] lazyktm: ^ [19:26:21] lazyktm: wanna do the one where you add a "(diff)" link there too? (not sure if it was a bug, but it should) [19:28:40] OH [19:28:44] sorry caps lock [19:28:51] MatmaRex: what one is that about? [19:30:13] lazyktm: well, the old orange bar included a diff link, and the new one doesn't [19:30:18] hm [19:30:24] can't you get that from the flyout? [19:30:38] yes, but that's like a WHOLE ANOTHER CLICK [19:30:38] You have new messages (diff) seems...weird. [19:30:40] :D [19:30:54] well, "show changes" or whatever. you know what i mean. [19:30:56] lazyktm: mobile's adding Special:History [19:31:04] which also acts as Special:RecentChanges [19:31:08] (03Merged) 10jenkins-bot: Backport compatible message changes from master. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/90958 (owner: 10Siebrand) [19:31:14] :o [19:31:30] lazyktm: in the long term, we should probably move action=history to Special:History [19:31:33] on both desktop and mobile [19:31:46] MatmaRex: i think that would be weird to have in the p tools menu [19:31:52] YuviPanda: there's an RfC for that! [19:31:56] lazyktm: oh! [19:32:16] https://www.mediawiki.org/wiki/Requests_for_comment/Drop_actions_in_favour_of_page_views_and_special_pages [19:40:48] (03PS4) 10Jarry1250: Generalise filename-matching in mediawiki.Title.newFromImg() [core] - 10https://gerrit.wikimedia.org/r/90897 [19:45:02] (03PS5) 10Jarry1250: Generalise filename-matching in mediawiki.Title.newFromImg() [core] - 10https://gerrit.wikimedia.org/r/90897 [19:49:43] (03PS1) 10Mattflaschen: Treat action=submit as 'alreadyediting' [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/91034 [20:06:01] (03PS1) 10Siebrand: Add missing entry to messages.inc [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/91037 [20:06:25] (03CR) 10Siebrand: [C: 032] Add missing entry to messages.inc [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/91037 (owner: 10Siebrand) [20:09:14] (03CR) 10Anomie: [C: 032] "Works as advertised, and changing non-Tidy output to more closely resemble the Tidy output is a win for this situation." [core] - 10https://gerrit.wikimedia.org/r/90696 (owner: 10Gerrit Patch Uploader) [20:09:33] ^demon|lunch: https://gerrit.wikimedia.org/r/#/c/79852/ just for you :) [20:11:12] (03CR) 10Chad: [C: 032] Added a few more trx sanity checks to DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/79852 (owner: 10Aaron Schulz) [20:13:04] (03Merged) 10jenkins-bot: Add missing entry to messages.inc [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/91037 (owner: 10Siebrand) [20:13:12] ^demon|lunch: http://rlv.zcache.com/tank_party_thank_you_card-r12f5b5e1bc604f1eba412a8b5ed7316f_xvua8_8byvr_512.jpg?bg=0xffffff [20:14:26] (03CR) 10Raimond Spekking: "Could you create https://www.mediawiki.org/wiki/Extension:Minifier please? I need it to create a proper i18n file. Thanks." [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/90770 (owner: 10MaxSem) [20:14:40] (03PS1) 10Siebrand: Add missing key to messages.inc [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/91039 [20:15:05] (03CR) 10Siebrand: [C: 032] Add missing key to messages.inc [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/91039 (owner: 10Siebrand) [20:20:23] (03CR) 10Bartosz Dziewoński: [C: 032] "Looks useful, works as advertised." [core] - 10https://gerrit.wikimedia.org/r/90742 (owner: 10Ori.livneh) [20:20:31] greg-g: I have one (possibly three) CN patches I'd love to push in today's LD window -- the one confirmed one is https://gerrit.wikimedia.org/r/#/c/90475/; depending on megan's response I may also push https://gerrit.wikimedia.org/r/#/c/90639/ which has some minor potential to break things [20:20:46] I couldn't get a definitive yes/no on if it'll break on beta because beta is itself broken [20:21:00] but; if it does break it'll be transparent to users [20:22:46] what, beta's broken? [20:22:58] <^demon|lunch> grrrit-wm: I'm shocked, shocked... [20:23:03] <^demon|lunch> *greg-g [20:23:06] <^demon|lunch> Damn tab-complete. [20:23:08] <^demon|lunch> Ruined my joke. [20:23:08] heh [20:23:14] :( [20:23:17] haha:D [20:23:23] grrr [20:23:29] greg-g: the HTTPS redirect thing [20:23:30] it [20:23:50] mwalker: oh, that's it? it seems to be taking forever for me to load over http right now [20:23:51] er, and in combination with mobile redirects [20:24:03] oh; I don't know if beta itself is down [20:24:24] (03Merged) 10jenkins-bot: Have list items occupy their own line [core] - 10https://gerrit.wikimedia.org/r/90696 (owner: 10Gerrit Patch Uploader) [20:24:36] but that patch requires 5 different domains to play nicely together with all the redirects; and I was having a hard time reproducing things [20:24:55] yuck [20:24:55] (03CR) 10Siebrand: [V: 032] "Bypassing Jenkins. Known good." [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/91039 (owner: 10Siebrand) [20:25:10] indeed [20:25:11] (03PS3) 10Esanders: Layout fixes to BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/90924 [20:25:15] (03PS1) 10Esanders: New icons [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 [20:25:47] but; the basic premise of it is that mobile URLs should be served to mobile clients -- and what I was attempting to test is that a) they were; and b) they weren't also getting served to desktop users [20:25:59] so worst case is we'll see a lot more traffic to the meta.m.wm.o domain [20:26:21] *with a 5 minute cache timeout [20:26:36] so if it really does go sour; I guess I could potentially take down the mobile site for about 10 minutes [20:27:36] weeee [20:27:41] who cares about mobile [20:28:22] YA! WHO! [20:28:25] alright, yeah, please add to calendar, ^demon|lunch is also going to do a search thingy, but it shouldn't interfere [20:28:44] <^demon|lunch> I sure don't :) [20:28:45] (03Merged) 10jenkins-bot: Added a few more trx sanity checks to DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/79852 (owner: 10Aaron Schulz) [20:30:31] (03CR) 10Parent5446: "Note: By "undocumented" I meant that the hook was never listed on [[mw:Manual:Hooks]] (although apparently a page was created for it). If " [core] - 10https://gerrit.wikimedia.org/r/90453 (owner: 10EBernhardson) [20:31:53] Reedy: e478c230f6d3f1b7638d4443682eff0df7650def is still in master, did you mean to revert that too? [20:32:32] It was reverted as https://gerrit.wikimedia.org/r/#/c/90273/ [20:32:39] Which you approved.. [20:33:14] Reedy: yeah, missing the skimming the logs...I thought you reverted it from branch [20:33:23] heh, no [20:33:27] I did it before [20:35:37] (03Merged) 10jenkins-bot: mediawiki.inspect: add CSS report [core] - 10https://gerrit.wikimedia.org/r/90742 (owner: 10Ori.livneh) [20:42:46] (03CR) 10MarkTraceur: [C: 032] "<3 thanks" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/90924 (owner: 10Esanders) [20:42:50] (03Merged) 10jenkins-bot: Layout fixes to BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/90924 (owner: 10Esanders) [20:45:25] hi , Are there any extention for Hindustani Musical notation as like "score"??? [20:50:51] (03CR) 10MarkTraceur: "I take it back, I'm already sort of doing that sort of" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 (owner: 10MarkTraceur) [20:58:49] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [20:59:15] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [21:08:32] Site appears to be back again after a db restart. [21:10:28] AaronSchulz: am looking for a better name for the storage service (currently storoid)- any ideas? [21:11:06] <^demon|lunch> storoid sounds like steroid :p [21:11:13] * AaronSchulz always has that thought [21:11:24] <^demon|lunch> But fits right in with your naming everything -oid ;-) [21:11:37] ^demon|lunch: yeah, it is a bit of a word play [21:12:56] hemorrhoid? [21:12:59] historoid :) it has revision history [21:13:12] ori-l: haha! [21:13:21] <^demon|lunch> How about we call it storageservice? [21:13:25] <^demon|lunch> I know, I'm boring. [21:13:27] boo [21:13:49] https://www.google.com/search?num=100&q=storageservice [21:14:00] gwicke: what are its distinguishing features / characteristics? [21:14:03] there seem to be a few of those already [21:14:39] ori-l: it stores stuff and provides a REST API [21:14:44] Revisionist? [21:14:55] some of the storage is revisioned, other parts might not be [21:15:00] * AaronSchulz tries to think of more bad names with several meanings [21:15:03] hehe [21:15:18] * gwicke likes revisionist [21:15:35] <^demon|lunch> How about Storagist? [21:15:40] the downside is that it is revision storage only [21:15:48] RESToroid? [21:15:49] howabout an acronym, WSS, Wiki Storage Service? [21:15:53] terrible puns [21:16:07] <^demon|lunch> ebernhardson: Last time we did acronyms we ended up with E2 and E3. [21:16:12] <^demon|lunch> :) [21:16:28] ^demon|lunch: we can do better! :) [21:16:46] E1 [21:17:00] The Wiki Storage System, please? [21:17:21] http://en.wiktionary.org/wiki/-ist vs. http://en.wiktionary.org/wiki/-oid [21:17:21] <^demon|lunch> PleaseFindAttachedStorage [21:17:25] * mwalker tries to think of something conflated around wikidata [21:17:30] my worry with the word storage though is people will stuff big blobs of binary data in it :P [21:17:45] (but maybe thats appropriate, i dunno) [21:18:02] Rashomon [21:18:16] 'The film is known for a plot device which involves various characters providing alternative versions of the same incident.' [21:18:27] also https://en.wikipedia.org/wiki/Rashomon_effect : 'The Rashomon effect is a term that has been used by a number of different scholars, journalists and film critics to refer to contradictory interpretations of the same events by different persons, a problem that arises in the process of uncovering truth.' [21:18:36] <^demon|lunch> ebernhardson: StorageForThingsThatArentBigBlobsOfBinaryData? :) [21:18:58] ASS - ^demon|lunch SFTTABBBD ? If you can rearrange it to be STABBED i mean be interested :) [21:19:06] s/mean/might/ [21:19:20] ASS - Another Storage Service [21:19:27] lol :) [21:19:28] ;) [21:19:37] well, *I* like rashomon [21:19:58] <^demon|lunch> ebernhardson: I developed a product once that had the acronym of RETARDS. [21:20:00] +1 for rashomon .. although copyright issues or not? [21:20:07] yass? ;) [21:20:42] +1 for WSS [21:20:45] subbu: it's apparently an alternate romanization of the name of one of the gates of the city of kyoto: https://en.wikipedia.org/wiki/Raj%C5%8Dmon [21:21:16] although, wss could get conflated with wss:// (websockets) [21:21:23] rashomon is clever [21:21:30] yes; +1 to rashomon [21:21:35] and -1 to WSS re lazyktm [21:21:38] For Accessing Basic Given and Licensed Information That's Totally Emitted RESTfully - FABGLITTER [21:21:42] :( [21:21:48] it also plays on the revisioning though [21:21:49] The LBGT movement has been too slow about adopting that. [21:22:07] as i was telling gwicke earlier, we could either pick literalist names or symbolic names .. and rashomon plays well on the latter. [21:22:15] although maybe it could also be interpreted to mean eventually consistent or 'lossy storage' ;) [21:22:55] it lets us change backends if cassandra doesn't live up to its potential. [21:23:24] ori-l, good to know about the romanization. [21:24:09] revisionist is a good alternative [21:24:41] I like that rashomon is less obviously connected to revisioning [21:24:47] (03PS2) 10Esanders: New icons [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 [21:24:48] (03PS1) 10Esanders: Fix border colours in BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91049 [21:28:02] if there are no objections I'll ask for a /services/rashomon repository then [21:29:34] https://www.mediawiki.org/w/index.php?title=Git%2FNew_repositories%2FRequests%2FEntries&diff=805687&oldid=805673 [21:30:20] (03PS1) 10Aaron Schulz: Hack to set a default ManageMyGrants form button [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91051 [21:30:26] ori-l: thanks for the name! [21:30:48] np, I'm flattered that you picked it [21:31:36] (03PS5) 10MarkTraceur: Fetch extended metadata from the API [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89103 [21:33:51] <^demon|lunch> services/*? [21:33:55] <^demon|lunch> Not sure I like the new top level. [21:34:20] (03PS3) 10Siebrand: Use i18n instead of hardcoded brackets and spaces [core] - 10https://gerrit.wikimedia.org/r/90892 [21:35:01] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [21:35:24] (03PS1) 10Hashar: Zuul status page: indicator learned waiting state [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 [21:35:26] (03CR) 10jenkins-bot: [V: 04-1] Use i18n instead of hardcoded brackets and spaces [core] - 10https://gerrit.wikimedia.org/r/90892 (owner: 10Siebrand) [21:36:11] (03CR) 10Hashar: "sorry Timo for the js soup :)" [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [21:37:54] (03CR) 10Krinkle: "(1 comment)" [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [21:38:02] (03PS7) 10MarkTraceur: Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 [21:38:25] (03PS4) 10Siebrand: Use i18n instead of hardcoded brackets and spaces [core] - 10https://gerrit.wikimedia.org/r/90892 [21:38:33] (03PS6) 10MarkTraceur: Add description to the DOM [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 [21:39:29] (03PS5) 10Siebrand: Use i18n instead of hardcoded brackets and spaces [core] - 10https://gerrit.wikimedia.org/r/90892 [21:39:44] (03PS6) 10Siebrand: Use i18n instead of hardcoded brackets and spaces [core] - 10https://gerrit.wikimedia.org/r/90892 [21:40:34] (03PS9) 10Siebrand: Update docs and declare visibility on class props [core] - 10https://gerrit.wikimedia.org/r/87556 [21:41:34] (03CR) 10Siebrand: "PS6 is PS1 rebased on master." [core] - 10https://gerrit.wikimedia.org/r/90892 (owner: 10Siebrand) [21:41:53] (03PS1) 10PleaseStand: Remove calls to wfDebugDieBacktrace [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/91059 [21:42:52] (03CR) 10Siebrand: "In PS9, all open comments should be addressed." [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [21:44:11] (03PS4) 10MarkTraceur: Add creation time to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90040 [21:44:29] (03CR) 10MarkTraceur: "Rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90040 (owner: 10MarkTraceur) [21:44:35] (03CR) 10MarkTraceur: "Rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 (owner: 10MarkTraceur) [21:44:41] (03CR) 10MarkTraceur: "Rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [21:47:32] (03CR) 10Chad: [V: 032] Remove calls to wfDebugDieBacktrace [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/91059 (owner: 10PleaseStand) [21:47:38] (03CR) 10Chad: [C: 032] Remove calls to wfDebugDieBacktrace [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/91059 (owner: 10PleaseStand) [21:47:57] (03CR) 10MarkTraceur: "OK, I can't exactly rebase this, I think I'm going to just leave it until some of this crap gets merged, and deal with it all then." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90425 (owner: 10MarkTraceur) [21:48:24] * marktraceur had his doctor prescribe Fukitol [21:48:28] Working wonders [21:48:31] heh [21:48:43] marktraceur: looks like I probably need some too [21:49:00] YuviPanda: Or you could help merge MultimediaViewer bullshit [21:49:09] It's getting out of hand [21:49:18] (03CR) 10Chad: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90653 (owner: 10Aaron Schulz) [21:49:36] marktraceur: heh, my velocity on the apps stuff has been decreasing because of the fact i'm writing code elsewhere. going to slow that down ab it [21:50:10] <^demon|lunch> We should just merge all open patches. [21:50:13] (03CR) 10MarkTraceur: "Cannot improve until *something* gets merged. The parent patch is a hacky bloody merge patch, so let's instead merge *one* of the parents " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 (owner: 10MarkTraceur) [21:50:14] <^demon|lunch> Then we'll be all caught up. [21:50:24] ^demon|lunch: I'm 49% in favour [21:51:00] <^demon|lunch> I'm 51% in favor. Together that's consensus, right? [21:51:41] (03CR) 10Jdlrobson: ""Changed "screen.less" to "styles.less" to prevent the exception. Apparently this changed since I started working on this patch."" [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [21:53:58] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [21:54:38] ^demon|lunch: That seems reasonable [21:56:49] (03CR) 10Krinkle: [C: 04-1] Zuul status page: indicator learned waiting state [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [22:05:44] (03PS1) 10MaxSem: MobileFrontend: pick dbdb687675e3408dd8833aa31558bd9d94a4d44c [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91068 [22:06:58] (03PS1) 10Adamw: Update CentralNotice submodule [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91069 [22:07:35] (03CR) 10Adamw: [C: 032 V: 032] "Missed this branch during last week's deployment." [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91069 (owner: 10Adamw) [22:08:36] ^ awight; for next time; don't push the change to the repo until you're ready to deploy -- otherwise someone might deploy it by accident [22:08:50] also; it's much preferable to allow Zuul to run the CI jobs and commit it for you [22:10:48] (03CR) 10MaxSem: [C: 032 V: 032] MobileFrontend: pick dbdb687675e3408dd8833aa31558bd9d94a4d44c [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91068 (owner: 10MaxSem) [22:12:30] (03CR) 10Jdlrobson: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [22:17:52] MaxSem: just a heads up -- we have a CentralNotice patch that made it's way into the deployment branch prematurely -- just don't git submodule update extensions/CentralNotice and you'll be good [22:18:23] mwalker, yeah I don't update submodules that aren't mine:) [22:18:47] ^demon|lunch: git fetch doesn't get me new changes that were merged today [22:18:57] <^demon|lunch> That's unfortunate. [22:20:52] ^demon|lunch: do you know who I should complain to, now that you don't care about gerrit? [22:21:07] <^demon|lunch> If I don't care, nobody does :) [22:21:11] right [22:21:42] <^demon|lunch> You're fetching from gerrit.wm.o, right? [22:21:46] ya [22:21:59] Fetch URL: ssh://gerrit.wikimedia.org:29418/apps/android/commons.git [22:22:10] they've also not gone through to https://github.com/wikimedia/apps-android-commons [22:22:22] <^demon|lunch> That's a little less surprising, I broke replication over the weekend. [22:22:26] <^demon|lunch> All might not have caught up. [22:22:44] (03PS5) 10Jdlrobson: Rewrite Vector's special.preferences.less with nesting [core] - 10https://gerrit.wikimedia.org/r/87171 [22:22:45] (03PS5) 10Jdlrobson: Move Vector's preferences css out of screen.less [core] - 10https://gerrit.wikimedia.org/r/87170 [22:22:45] ^demon|lunch: actually, nevermind. [22:22:53] ^demon|lunch: brion had +2'd them but forgot to hit submit [22:23:03] i just saw the +2 and grrrit-wm doesn't show people done submits [22:23:07] <^demon|lunch> Making me freak out. [22:23:13] heh [22:23:18] heh [22:23:54] brion: I don't see the submit button on https://gerrit.wikimedia.org/r/#/c/91035/ [22:24:15] ah, dependenceis [22:24:15] ok [22:24:20] (03PS2) 10Physikerwelt: startup script skeleton for upstart [extensions/Math] - 10https://gerrit.wikimedia.org/r/90731 [22:24:23] :D [22:24:43] (03PS1) 10EBernhardson: Display nested exception backtrace's [core] - 10https://gerrit.wikimedia.org/r/91073 [22:25:11] brion: okay, still don't see it onhttps://gerrit.wikimedia.org/r/#/c/91035/ [22:25:31] * ebernhardson never knows who to add to core patch's for review [22:26:15] YuviPanda: yeah i don't have a submit either [22:26:27] <^demon|lunch> I do. [22:26:34] aren't you special :D [22:26:52] okay figured it out [22:27:09] * ebernhardson just adds the last 3 names for the file in git log :P [22:27:25] <^demon|lunch> ebernhardson: Just add [22:27:31] brion: you need to V+2 that and hit 'submit' :P [22:27:35] <^demon|lunch> "mediawiki" and let it expand to all 50 users or so :) [22:27:39] ahh [22:27:44] i thought jenkins did the V+2? [22:27:45] (03PS1) 10Mwalker: Updating CentralNotice to master for LD window [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91074 [22:27:45] ^demon|lunch: heh [22:27:48] brion: no [22:27:57] baaaah [22:28:06] jenkins-bot 1:57 PM [22:28:07] Patch Set 1: Verified+2 [22:28:08] ^ ? [22:28:19] brion: you still need to hit submit? [22:28:38] * brion never knows when to push buttons and when not to [22:30:05] (03PS1) 10Mwalker: Updating CentralNotice to master for LD window [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91076 [22:30:50] (03PS2) 10EBernhardson: Display nested exception backtrace's [core] - 10https://gerrit.wikimedia.org/r/91073 [22:31:05] too bad i can't add random email address as Gerrit reviewers:) [22:31:14] need invite feature:) [22:40:59] (03PS1) 10Addshore: Add more @covers tags and test cleanup [core] - 10https://gerrit.wikimedia.org/r/91077 [22:41:45] (03PS1) 10PleaseStand: Remove calls to wfDebugDieBacktrace [extensions/OAI] - 10https://gerrit.wikimedia.org/r/91078 [22:43:32] (03CR) 10MarkTraceur: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [22:47:27] (03PS2) 10Jdlrobson: Don't save secondary coordinates equal to primary one [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/88903 (owner: 10MaxSem) [22:53:41] (03CR) 10Siebrand: [C: 032] Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/91080 (owner: 10L10n-bot) [22:55:52] (03CR) 10Siebrand: [C: 032] Localisation updates from http://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/91083 (owner: 10L10n-bot) [22:56:02] (03CR) 10Siebrand: [C: 032] Localisation updates from http://translatewiki.net. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/91082 (owner: 10L10n-bot) [22:56:08] (03CR) 10Siebrand: [C: 032] Localisation updates from http://translatewiki.net. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/91081 (owner: 10L10n-bot) [22:57:47] (03CR) 10Trevor Parscal: [C: 04-1] "I think these icons are better, but could use some adjustment. The originals used a gray color, these are black. There's also more refined" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 (owner: 10Esanders) [22:58:26] (03CR) 10Siebrand: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [22:59:11] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/91080 (owner: 10L10n-bot) [23:00:07] MaxSem: are you done with your deploy? [23:00:19] mwalker, yup [23:00:43] <^demon|lunch> mwalker: Ready for our simultaneous deploys? :) [23:00:47] oh yes [23:00:51] are you touching core? [23:01:00] <^demon|lunch> No, just InitialiseSettings. [23:01:07] (03CR) 10Mwalker: [C: 032] Updating CentralNotice to master for LD window [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91074 (owner: 10Mwalker) [23:01:12] (03CR) 10Mwalker: [C: 032] Updating CentralNotice to master for LD window [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91076 (owner: 10Mwalker) [23:01:18] cool [23:01:41] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/91083 (owner: 10L10n-bot) [23:02:04] (03PS1) 10Aaron Schulz: Tweaked some of the preferences language [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91087 [23:03:34] (03CR) 10Siebrand: "Needs RELEASE-NOTES updated before it is merged." [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [23:04:32] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/91082 (owner: 10L10n-bot) [23:05:30] (03PS1) 10Aaron Schulz: Added log excepts to ManageMyGrants page [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91089 [23:06:32] csteipp: bug 55718 seems maybe wontfix [23:07:42] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/91081 (owner: 10L10n-bot) [23:08:34] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91087 (owner: 10Aaron Schulz) [23:09:31] (03CR) 10Aaron Schulz: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91087 (owner: 10Aaron Schulz) [23:10:18] (03PS2) 10Aaron Schulz: Tweaked some of the preferences language [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91087 [23:14:00] (03CR) 10Siebrand: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91087 (owner: 10Aaron Schulz) [23:14:38] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91087 (owner: 10Aaron Schulz) [23:16:21] greg-g: well; we did start pushing mobile URLs to desktop users -- but on the plus side; it looks like the mobile varnish cache just took it in stride [23:17:41] (03PS1) 10Mwalker: Revert "Updating CentralNotice to master for LD window" [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91092 [23:17:57] (03PS1) 10Mwalker: Revert "Updating CentralNotice to master for LD window" [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91093 [23:19:17] (03CR) 10Mwalker: [C: 032] Revert "Updating CentralNotice to master for LD window" [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91093 (owner: 10Mwalker) [23:19:28] (03CR) 10Mwalker: [C: 032 V: 032] Revert "Updating CentralNotice to master for LD window" [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91092 (owner: 10Mwalker) [23:19:34] (03CR) 10Mwalker: [V: 032] Revert "Updating CentralNotice to master for LD window" [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91093 (owner: 10Mwalker) [23:29:04] greg-g: I wanna churn extensions/CentralNotice a bit more-- You know if no one else is deploying + the runway is clear for me? [23:32:27] (03PS1) 10Cmcmahon: add when_present clauses to reduce flaky test failures [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91096 [23:33:12] greg-g: basically; the mobile patch died an ugly death -- but I just reverted both patches; adam wants to deploy the one that did work [23:34:08] yes that is correct [23:41:29] aude: ping? [23:43:15] hi bd808 [23:43:22] Hi [23:43:35] * aude fixing a bug in wikibase [23:43:54] aude: you want to have a hangout tomorrow about scholarships? [23:45:12] sure [23:45:42] i poked at the code some during the weekend, although lots more is needed [23:45:46] and got your pull request [23:46:03] (03CR) 10CSteipp: [C: 032] Tweaked some of the preferences language [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91087 (owner: 10Aaron Schulz) [23:46:06] aude: Is there any time that's better or worse for you? Chad and I have a conf call at 2PM SF time but are open otherwise [23:46:09] (03Merged) 10jenkins-bot: Tweaked some of the preferences language [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91087 (owner: 10Aaron Schulz) [23:46:17] afternoon is better [23:46:25] maybe i can poke more and have a demo setup [23:46:35] or did you have luck with setting up a demo? [23:46:40] aude: I have one at http://scholarship-alpha.instance-proxy.wmflabs.org/ [23:46:44] k [23:47:01] I need to pull in the fixes you pushed this weekend [23:47:16] Put it seems to be functional [23:47:16] ok [23:47:22] s/put/but/ [23:48:02] aude: How about 3:30pm SF time for tomorrow? [23:48:07] (03CR) 10MZMcBride: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91051 (owner: 10Aaron Schulz) [23:48:13] should be fine [23:48:30] Awesome. I'll set a meeting. [23:48:36] great [23:48:44] i'll also talk to elsie some time [23:48:53] errr [23:49:04] ellie :) [23:49:19] * aude stabs Elsie for confusing me [23:52:14] aude: Invite should be in the mail. I think ^demon|lunch will be working from home tomorrow, so I didn't try to book a conference room for you to sit in. [23:52:37] (o: [23:52:53] <^demon|lunch> bd808: No, I'll be in. [23:52:59] <^demon|lunch> That's a usual tuesday thing, but not tomorrow. [23:53:47] ^demon|lunch: Oh great. I set the event to "guests can modify" if you want to reserve a room. [23:54:36] * gwicke realizes that both :Foo and _Foo are not valid page names in MW, so we have a choice between :private and _private for pseudo-resources that should not clash with page names [23:54:52] (03Abandoned) 10Werdna: Add Wiki ID variable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/90457 (owner: 10Werdna) [23:55:33] <^demon|lunch> bd808, aude: Added R31 to the event. [23:56:04] ^demon|lunch: thanks