[00:45:06] (03PS1) 10Jack Phoenix: SocialProfile: fixed JS on Special:GiveGift. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/92163 [00:45:47] (03CR) 10Jack Phoenix: [C: 032 V: 032] SocialProfile: fixed JS on Special:GiveGift. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/92163 (owner: 10Jack Phoenix) [00:58:43] (03PS1) 10Jack Phoenix: SocialProfile: fixed Special:ViewGift so that it actually works. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/92164 [00:59:29] (03CR) 10Jack Phoenix: [C: 032 V: 032] SocialProfile: fixed Special:ViewGift so that it actually works. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/92164 (owner: 10Jack Phoenix) [01:03:44] (03PS1) 10Jack Phoenix: SocialProfile: fixed Special:AddRelationship so that friending & foeing works again. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/92165 [01:04:07] (03CR) 10Jack Phoenix: [C: 032 V: 032] SocialProfile: fixed Special:AddRelationship so that friending & foeing works again. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/92165 (owner: 10Jack Phoenix) [01:56:57] (03PS1) 10Legoktm: Add API help url [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/92166 [02:51:22] (03PS1) 10Aude: Put get diff body cache key into own function [core] - 10https://gerrit.wikimedia.org/r/92167 [03:18:33] (03PS4) 10Legoktm: Only allow Thanks for public revisions [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88223 [03:18:39] (03CR) 10Legoktm: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88223 (owner: 10Legoktm) [03:47:44] (03PS7) 10Legoktm: Add API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/70749 (owner: 10Anomie) [03:48:54] (03CR) 10Legoktm: "Rebased, changed a few @since 1.22 tags to 1.23, and moved the RELEASE-NOTES entry to the 1.23 version." [core] - 10https://gerrit.wikimedia.org/r/70749 (owner: 10Anomie) [04:55:24] (03PS1) 10Legoktm: Tests for API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/92168 [04:56:43] (03CR) 10jenkins-bot: [V: 04-1] Tests for API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/92168 (owner: 10Legoktm) [04:56:47] :( [04:57:08] hrm. [04:58:44] (03CR) 10Legoktm: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/70749 (owner: 10Anomie) [05:00:30] (03CR) 10Parent5446: [C: 031] "Looks good, but can we *please* get https://gerrit.wikimedia.org/r/22167 merged in the future?" [core] - 10https://gerrit.wikimedia.org/r/92041 (owner: 10Yurik) [05:03:03] (03PS2) 10Legoktm: Tests for API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/92168 [05:04:22] (03CR) 10jenkins-bot: [V: 04-1] Tests for API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/92168 (owner: 10Legoktm) [05:04:46] i hate you. [05:05:47] (03PS3) 10Legoktm: Tests for API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/92168 [05:07:07] (03CR) 10jenkins-bot: [V: 04-1] Tests for API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/92168 (owner: 10Legoktm) [05:10:10] (03PS4) 10Legoktm: Tests for API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/92168 [05:11:57] (03CR) 10Parent5446: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [05:13:09] (03CR) 10jenkins-bot: [V: 04-1] Tests for API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/92168 (owner: 10Legoktm) [05:13:38] I give up. [05:17:33] (03PS1) 10PleaseStand: HistoryBlobCurStub: correct setting name in doc comment [core] - 10https://gerrit.wikimedia.org/r/92169 [06:13:29] (03PS1) 10Adamw: Minor optimization to the AutoLoader [core] - 10https://gerrit.wikimedia.org/r/92170 [06:15:01] (03CR) 10jenkins-bot: [V: 04-1] Minor optimization to the AutoLoader [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [06:34:40] (03PS8) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [06:35:13] (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [06:37:00] (03PS9) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [06:37:21] (03CR) 10Parent5446: "PS8: Fixed various issue and added more tests. One test fails. Will get to it tomorrow." [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [06:38:37] (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [06:39:18] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [06:40:37] (03CR) 10Parent5446: [C: 031] Add rc.unpatrolled to the recentchanges API [core] - 10https://gerrit.wikimedia.org/r/91844 (owner: 10Krinkle) [06:40:58] (03CR) 10Parent5446: [C: 031] Add show=unpatrolled to the recentchanges API [core] - 10https://gerrit.wikimedia.org/r/91845 (owner: 10Krinkle) [07:00:56] (03PS23) 10Parent5446: Added Uri class and Uri Query classes. [core] - 10https://gerrit.wikimedia.org/r/22167 [07:01:50] (03PS25) 10Parent5446: Added throttling framework. [core] - 10https://gerrit.wikimedia.org/r/34677 [07:03:49] (03PS5) 10Parent5446: Config for adding rel="noreferrer" to external links. [core] - 10https://gerrit.wikimedia.org/r/46790 [07:07:43] (03CR) 10jenkins-bot: [V: 04-1] Config for adding rel="noreferrer" to external links. [core] - 10https://gerrit.wikimedia.org/r/46790 (owner: 10Parent5446) [07:08:10] (03PS8) 10Parent5446: Send a cookie with autoblocks to prevent vandalism. [core] - 10https://gerrit.wikimedia.org/r/48029 [07:10:44] (03PS6) 10Parent5446: Config for adding rel="noreferrer" to external links. [core] - 10https://gerrit.wikimedia.org/r/46790 [07:15:28] (03CR) 10PleaseStand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [07:56:04] (03PS2) 10Bsitu: Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 [08:04:37] (03PS1) 10Dan-nl: SpecialGWTooset clean-up [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92171 [08:07:41] (03PS3) 10Bsitu: Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 [08:09:20] (03CR) 10Bsitu: [C: 032] Remove outdated comment [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91556 (owner: 10Legoktm) [08:09:23] (03Merged) 10jenkins-bot: Fix phpdoc [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91557 (owner: 10Legoktm) [08:09:24] (03Merged) 10jenkins-bot: Remove outdated comment [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91556 (owner: 10Legoktm) [08:40:50] (03PS15) 10Werdna: Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [08:40:52] (03CR) 10jenkins-bot: [V: 04-1] Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [08:44:07] (03CR) 10Werdna: "PS15 is the same as PS13: Benny said that he accidentally pushed PS14, so the idea was to "revert" PS14 by making a new patchset equal to " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [09:38:45] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [09:39:00] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [09:47:40] (03CR) 10Parent5446: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [10:04:42] (03CR) 10Parent5446: "(15 comments)" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [13:37:40] (03CR) 10Bartosz Dziewoński: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/85798 (owner: 10Krinkle) [14:04:52] (03PS1) 10saper: Allow robotic Users to determine their IP address [core] - 10https://gerrit.wikimedia.org/r/92179 [14:30:06] (03PS1) 10Bartosz Dziewoński: ext.echo.alert: Restore orange background on Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92181 [14:30:46] (03PS2) 10Bartosz Dziewoński: ext.echo.alert: Restore orange background on Monobook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92181 [14:31:00] (03CR) 10Bartosz Dziewoński: "Followup: https://gerrit.wikimedia.org/r/92181" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/85798 (owner: 10Krinkle) [14:34:09] (03CR) 10Bartosz Dziewoński: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79175 (owner: 10Shirayuki) [14:37:14] (03PS1) 10Bartosz Dziewoński: Remove full stop from 'echo-new-messages' message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92183 [14:37:35] (03CR) 10Bartosz Dziewoński: "Followup: https://gerrit.wikimedia.org/r/92183" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/79175 (owner: 10Shirayuki) [14:46:56] (03CR) 10Edokter: [C: 031] "Indeed. Agora != Vector. In fact, Agora is only a concept at this time. Obviously an error." [core] - 10https://gerrit.wikimedia.org/r/92065 (owner: 10Bartosz Dziewoński) [15:53:37] (03PS8) 10Bartosz Dziewoński: Correctly update wl_notificationtimestamp when viewing old revisions [core] - 10https://gerrit.wikimedia.org/r/84315 [15:54:36] (03PS9) 10Bartosz Dziewoński: Correctly update wl_notificationtimestamp when viewing old revisions [core] - 10https://gerrit.wikimedia.org/r/84315 [16:01:33] (03CR) 10MZMcBride: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [16:10:45] (03CR) 10Brian Wolff: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [16:10:55] (03CR) 10Brian Wolff: [C: 04-1] Correctly update wl_notificationtimestamp when viewing old revisions [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [16:12:10] bawolff: gah. [16:15:13] bawolff: about the newtalk thing – you think i should check if $oldid is latest the way i do in WatchedItem.php? [16:16:33] I'm leaning towards yes, but I'm not sure [16:18:26] okay, let's do it then, sounds like a good idea [16:21:28] That should probably be mentioned in release notes [16:21:49] yeah [16:22:35] (03CR) 10Bartosz Dziewoński: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [16:25:34] (03PS1) 10Umherirrender: API: Remove leading/trailing spaces from error and description text [core] - 10https://gerrit.wikimedia.org/r/92190 [16:25:36] interesting. $wgUseEnotif is only defined in Setup.php, not in DefaultSettings.php [16:27:05] "interesting" [16:27:25] (03PS10) 10Bartosz Dziewoński: Correctly update wl_notificationtimestamp when viewing old revisions [core] - 10https://gerrit.wikimedia.org/r/84315 [16:27:35] bawolff: ^ [16:27:43] (i did not test these changes yet) [16:32:17] (03CR) 10Siebrand: [C: 032] Remove full stop from 'echo-new-messages' message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92183 (owner: 10Bartosz Dziewoński) [16:32:24] (03Merged) 10jenkins-bot: Remove full stop from 'echo-new-messages' message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92183 (owner: 10Bartosz Dziewoński) [16:32:46] siebrand: i'll backport to REL1_22? [16:32:51] (thanks :) ) [16:33:08] MaxSem: for an extension? AFAIK that's rarely done. [16:33:16] MaxSem: oops, wrong nick. [16:33:21] siebrand: it has a REL1_22 branch [16:33:25] so i don't see why not [16:33:33] (it's not bundled or anything, though) [16:33:36] MatmaRex: can do. I would approve. [16:33:47] ok [16:34:01] hmm [16:34:09] when were all these branches actually created [16:34:18] (03PS1) 10Umherirrender: API: Add text for Unknown error: "permissiondenied" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92191 [16:34:38] maybe we should backport to REL1_20 and 21 too. or to none. [16:36:31] meh, no, the other branches are old [16:36:38] (03PS1) 10Bartosz Dziewoński: Remove full stop from 'echo-new-messages' message [extensions/Echo] (REL1_22) - 10https://gerrit.wikimedia.org/r/92192 [16:38:19] bawolff: hmmmm, that does weird stuff [16:38:33] It does? [16:39:08] bawolff: the last unseen revision for user's talk page is stored somewhere else too [16:39:16] bawolff: but actually setNewtalk() takes it as an optional argument [16:39:53] also, the orange bar is apparnently never displayed on user's talk page, regardless of everything else [16:40:20] * MatmaRex chokes the ones responsible for that [16:40:22] Hmm, maybe we should just keep this change simple, and stick with the original bug [16:41:01] no, that's be silly [16:41:01] watchlist and talk indicator would be inconsistent [16:41:09] but that looks like a reasonably simple fix [16:41:17] ten lines of code changed more, tops! [16:41:22] ok [16:42:11] andre__: Hi. I think Marco would be a good person to give editbugs rights to (See bug 52531 where he was very confused why he couldn't reopen the bug) [16:42:37] bawolff, yepp. I will do that tomorrow morning [16:43:08] gah, but there's that stupid hook [16:43:09] UserClearNewTalkNotification [16:43:18] can i add a new argument to a hook without its users exploding? [16:46:38] (03PS1) 10Umherirrender: API: Fix possible errors to avoid Unknown error [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/92193 [16:47:35] probably. they'd just treat it as if the latest thing was viewed, which is a pretty sane fallback [16:48:40] can PHP functions take more arguments than they declare? [16:48:43] (03PS2) 10Adamw: Minor optimization to the AutoLoader [core] - 10https://gerrit.wikimedia.org/r/92170 [16:48:45] actually, i guess they can [16:51:39] yeah [16:51:50] (03CR) 10Adamw: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [16:51:52] For example, all the message functions do [16:52:54] yeah, i though of that [16:52:55] hm [16:52:59] if ( !wfRunHooks( 'UserClearNewTalkNotification', array( &$this ) ) ) { [16:53:03] passing this by reference? [16:53:16] would PHP clone the object otherwise, or what? [16:53:32] i don't think it clones objects. just arrays [16:53:39] umm, not sure about that one. I didn't think it was needed for objects [16:53:49] it's not documented [16:53:50] How old is the hook? could be throwback to php4 [16:53:53] okay, not touching that [16:59:25] (03PS11) 10Bartosz Dziewoński: Correctly update wl_notificationtimestamp when viewing old revisions [core] - 10https://gerrit.wikimedia.org/r/84315 [16:59:27] right. [16:59:32] that's the dumbest interface ever. [16:59:39] it requires me to calculate the next revision [16:59:46] then it calculates the previous one from that [16:59:52] and takes only its timestamp anyway [17:01:54] bawolff: crap, it is just me or does it still not work? [17:02:09] Haven't tested yet [17:02:19] hmm [17:02:28] i should probably clear it before setting a new one [17:02:44] good thing the method is named updateNewtalk(), no potential for any confusion whatsoever! [17:08:20] (03PS12) 10Bartosz Dziewoński: Correctly update wl_notificationtimestamp when viewing old revisions [core] - 10https://gerrit.wikimedia.org/r/84315 [17:09:09] yess. works correctly now [17:09:14] thanks bawolff, you're the best [17:10:18] (03CR) 10Bartosz Dziewoński: "Fixed a bunch of issues related to the talk page indicator being separate from the notification timestamp." [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [17:12:30] man, i just love making rather minor changes which require fixed to eleven files [17:25:53] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92179 (owner: 10saper) [17:27:30] (03CR) 10Parent5446: [C: 031] Minor optimization to the AutoLoader [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [17:30:49] MatmaRex: That checkNewtalk bussiness is confusing [17:31:22] bawolff: hm? [17:31:35] mediawiki is confusing [17:31:36] php, too [17:31:36] Just the fact all the methods in user, have almost the same name [17:31:41] lol [17:31:53] damn computers, way to confusing [17:31:58] i'm glad they don't have typos, man [17:34:26] MatmaRex, man. [17:34:28] Man, MatmaRex. [17:35:57] Elsie: yeah, man. [17:35:58] dude. [17:36:05] MatmaRex: I'm not sure if the check in Skin.php for if its current page is important. It seems like user loads newtalk status from a slave, (sometimes), which might make that check important [17:38:30] (03CR) 10Siebrand: [C: 032] Remove full stop from 'echo-new-messages' message [extensions/Echo] (REL1_22) - 10https://gerrit.wikimedia.org/r/92192 (owner: 10Bartosz Dziewoński) [17:38:36] (03Merged) 10jenkins-bot: Remove full stop from 'echo-new-messages' message [extensions/Echo] (REL1_22) - 10https://gerrit.wikimedia.org/r/92192 (owner: 10Bartosz Dziewoński) [17:38:43] * MatmaRex throws his hands up in the air [17:39:06] (03CR) 10Siebrand: [C: 032] Add/remove full-stop [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92049 (owner: 10Shirayuki) [17:39:07] I'm not sure though, I'm still walking my way through the newtalk code [17:39:16] (03Merged) 10jenkins-bot: Add/remove full-stop [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92049 (owner: 10Shirayuki) [17:39:20] (03CR) 10Siebrand: [C: 032] Capitalize "Lightbox" [extensions/SectionDisqus] - 10https://gerrit.wikimedia.org/r/92046 (owner: 10Shirayuki) [17:40:29] hmmmmm [17:40:29] MatmaRex: Actually nevermind, in that case the user object should already be loaded, and the query shouldn't even hit the db [17:40:40] (03CR) 10Siebrand: [C: 032] Capitalize "Lightbox" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92040 (owner: 10Shirayuki) [17:40:44] (03Merged) 10jenkins-bot: Capitalize "Lightbox" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92040 (owner: 10Shirayuki) [17:40:50] maybe i should keep that check and restrict it to also check if oldid is latest? [17:40:50] since it should be cached in mNewtalk [17:41:05] or maybe we should keep it this way for now and see if anybody reports any issues, heh [17:41:13] lol, that is one approach [17:41:28] why do we even use user_newtalk for logged-in users when we have wl_notificationtimestamp D: [17:41:44] hm [17:41:51] okay, because technically you can unwatch your talk page [17:42:13] why can you unwatch your talk page? that's stupid [17:42:16] (03CR) 10Siebrand: "@devunt: Please provide some sources, because it doesn't seem like a valid reason to block this update." [core] - 10https://gerrit.wikimedia.org/r/84212 (owner: 10Ara) [17:42:50] I don't think its watched by default [17:43:00] so there's probably people who just never clicked watch [17:43:52] * bawolff 's talk page is unwatched on frwikipedia [17:43:54] …okay, that's even stupider [17:44:21] * MatmaRex files a bug [17:44:41] So $this->setNewtalk( false ); should definitely clear $wgUser->mNewtalk, which is what the other thing should look at [17:44:46] so i think this is safe [17:45:44] it's also silly how you can have multiple different newtalk notifications for one user [17:45:47] in that table [17:46:05] and i don't think anything prevents that in the PHP code either [17:46:14] hflkjhalksdnhfsadhflk [17:46:38] bawolff: if you hadn't noticed that, we'd both be happier people now :( [17:46:51] lol [17:46:56] probably [17:47:42] Anyhow, I'm merging this change [17:47:49] yay [17:47:55] (03PS13) 10Brian Wolff: Correctly update wl_notificationtimestamp when viewing old revisions [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [17:48:13] (03CR) 10Brian Wolff: [C: 032] "Tested, looks good" [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [17:49:08] bawolff: oh look, that bug is already filed [17:49:08] https://bugzilla.wikimedia.org/show_bug.cgi?id=49719 [17:52:47] (03Merged) 10jenkins-bot: Correctly update wl_notificationtimestamp when viewing old revisions [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [17:52:55] bawolff: <3 [17:53:13] :) [17:53:28] Now I feel like less of a free-loader for not reviewing things [18:07:44] @notify legoktm [18:07:45] This user is now online in #huggle. I'll let you know when they show some activity (talk, etc.) [18:08:17] wm-bot: he's online here, too, you dummy :) [18:08:17] Hi MatmaRex, there is some error, I am a stupid bot and I am not intelligent enough to hold a conversation with you :-) [18:09:43] (03PS2) 10Nikerabbit: Remove period from title for consistency [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92063 [18:09:56] (03Abandoned) 10Nikerabbit: Remove period from title for consistency [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92063 (owner: 10Nikerabbit) [18:33:40] (03PS2) 10Dan-nl: SpecialGWTooset clean-up & fix [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92171 [19:16:06] yes hello [19:33:46] (03CR) 10Bartosz Dziewoński: [C: 032] Add API help url [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/92166 (owner: 10Legoktm) [19:33:48] (03Merged) 10jenkins-bot: Add API help url [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/92166 (owner: 10Legoktm) [19:38:37] (03CR) 10Bartosz Dziewoński: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [19:41:38] MatmaRex: if i use Linker::link, do I have to use ->rawParam then? [19:41:51] brb [19:45:01] (03PS1) 10Bartosz Dziewoński: vector: Restore gray search input placeholder [core] - 10https://gerrit.wikimedia.org/r/92201 [19:45:41] legoktm: yeah, probably [19:45:41] rawParams* [19:47:26] (03CR) 10Bartosz Dziewoński: "This caused bug 54069, stupid me :( Fix in https://gerrit.wikimedia.org/r/#/c/92201/" [core] - 10https://gerrit.wikimedia.org/r/82099 (owner: 10Bartosz Dziewoński) [19:55:40] (03CR) 10Swalling: "Just noting: this change might have been intentional. I'd probably not assume either way. (I don't know actually, and didn't even notice i" [core] - 10https://gerrit.wikimedia.org/r/92065 (owner: 10Bartosz Dziewoński) [20:00:20] (03CR) 10Siebrand: [V: 032] Capitalize "Lightbox" [extensions/SectionDisqus] - 10https://gerrit.wikimedia.org/r/92046 (owner: 10Shirayuki) [20:02:31] "LightBox" [20:05:42] (03CR) 10Bartosz Dziewoński: "> If this was intentional, it should have been mentioned in the commit message." [core] - 10https://gerrit.wikimedia.org/r/92065 (owner: 10Bartosz Dziewoński) [20:07:57] (03PS3) 10Legoktm: Add Special:Thanks as a non-JS fallback [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 [20:08:09] (03CR) 10Legoktm: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [20:09:38] (03CR) 10Bartosz Dziewoński: [C: 032] API: Remove leading/trailing spaces from error and description text [core] - 10https://gerrit.wikimedia.org/r/92190 (owner: 10Umherirrender) [20:16:09] (03Merged) 10jenkins-bot: API: Remove leading/trailing spaces from error and description text [core] - 10https://gerrit.wikimedia.org/r/92190 (owner: 10Umherirrender) [20:16:46] (03CR) 10Bartosz Dziewoński: [C: 032] "Why do we even have two separate special pages for this…" [core] - 10https://gerrit.wikimedia.org/r/88785 (owner: 10Umherirrender) [20:18:11] (03CR) 10Bartosz Dziewoński: "Release notes please. Sounds like a good idea." [core] - 10https://gerrit.wikimedia.org/r/88773 (owner: 10Umherirrender) [20:19:18] (03PS1) 10Brian Wolff: Throw an error if calling parser recursively [core] - 10https://gerrit.wikimedia.org/r/92247 [20:20:44] (03Merged) 10jenkins-bot: Set relevant User on Special:Unblock [core] - 10https://gerrit.wikimedia.org/r/88785 (owner: 10Umherirrender) [20:21:18] (03CR) 10Bartosz Dziewoński: "Inspired by Liangent on https://bugzilla.wikimedia.org/show_bug.cgi?id=56167#c1" [core] - 10https://gerrit.wikimedia.org/r/92247 (owner: 10Brian Wolff) [20:21:25] (03PS1) 10Legoktm: [WIP] Add Redis backend [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92248 [20:21:44] bawolff: typos :( [20:21:57] bawolff: * Parser dies early if called recursively – missing full stop [20:22:09] bawolff: "Parser::Parse is not allowed to be called recursively" – parse [20:24:10] (03PS2) 10Brian Wolff: Throw an error if calling parser recursively [core] - 10https://gerrit.wikimedia.org/r/92247 [20:24:23] (03CR) 10Brian Wolff: "PS2: typo" [core] - 10https://gerrit.wikimedia.org/r/92247 (owner: 10Brian Wolff) [20:48:17] (03PS1) 10Aude: Improve wording of eauthentsent message for email confirmation [core] - 10https://gerrit.wikimedia.org/r/92249 [20:53:37] (03PS2) 10Umherirrender: Add wgRelevantUserName from skin as js variable [core] - 10https://gerrit.wikimedia.org/r/88773 [21:00:19] (03PS3) 10Umherirrender: Add wgRelevantUserName from skin as js variable [core] - 10https://gerrit.wikimedia.org/r/88773 [21:01:49] (03CR) 10Umherirrender: "Patch Set 3: Added release notes, feel free to rewrite text, if not that, what it should be ;-)" [core] - 10https://gerrit.wikimedia.org/r/88773 (owner: 10Umherirrender) [21:03:50] (03CR) 10saper: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92179 (owner: 10saper) [21:18:40] (03PS1) 10Aude: remove index.php from url in passwordremindertext and createaccount-text [core] - 10https://gerrit.wikimedia.org/r/92251 [21:28:13] (03CR) 10Bartosz Dziewoński: "I guess it might matter if you're running several wikis in subdirectories of one domain?" [core] - 10https://gerrit.wikimedia.org/r/92251 (owner: 10Aude) [21:38:01] (03PS1) 10saper: Introduce AbuseFilterUser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92252 [21:39:08] (03CR) 10Brian Wolff: [C: 04-1] "It would also matter if you're running the wiki in a subdirectory, and your main site has not much to do with your wiki install. (Probably" [core] - 10https://gerrit.wikimedia.org/r/92251 (owner: 10Aude) [21:39:59] (03PS2) 10saper: Introduce AbuseFilterUser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92252 [21:48:51] saper: heh, that's either a mad or a genius idea [21:51:34] (03CR) 10Legoktm: [C: 04-1] "(3 comments)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92252 (owner: 10saper) [21:51:45] I don't think its a good idea. [21:55:25] Another *User class? :/ [21:56:19] I heard you like Users, So I put a User in your User [21:58:17] so you can... getName while you getName? am I doing this right? [21:58:31] heh [22:02:37] (03PS1) 10Brian Wolff: Update Parser::mPreprocessor->parser reference when Parser is cloned [core] - 10https://gerrit.wikimedia.org/r/92253 [22:07:24] (03PS3) 10Brian Wolff: Throw an error if calling parser recursively [core] - 10https://gerrit.wikimedia.org/r/92247 [22:08:07] (03CR) 10Brian Wolff: "PS3: Fix case of if parser gets cloned in middle of parse" [core] - 10https://gerrit.wikimedia.org/r/92247 (owner: 10Brian Wolff) [22:14:50] (03PS1) 10saper: Don't expose blocked IP address in error message [core] - 10https://gerrit.wikimedia.org/r/92254 [22:27:03] (03PS2) 10Legoktm: [WIP] Add Redis backend [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92248 [22:57:59] hi TimStarling [22:58:09] TimStarling: you might enjoy https://gerrit.wikimedia.org/r/#/c/92247/ [22:58:42] interesting [23:00:21] SuggestBot for Gerrit? [23:00:46] "You reviewed X commit, maybe you'd be interested in commits Y and Z" [23:02:28] What. [23:02:42] heh [23:02:58] that's actually not a very bad idea, i guess. [23:03:05] * Elsie cages Reedy. [23:03:26] oh, Reedy, you might enjoy https://gerrit.wikimedia.org/r/#/c/92247/ [23:03:36] gah [23:03:37] https://gerrit.wikimedia.org/r/#/c/89603/ [23:04:03] (but the other one too, since you ops people will have to clean up if it breaks too many things :> ) [23:04:32] (03PS1) 10saper: Display parent block target in autoblock errors [core] - 10https://gerrit.wikimedia.org/r/92257 [23:12:50] (03CR) 10PleaseStand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92254 (owner: 10saper) [23:15:27] (03CR) 10Tim Starling: "Have you tested it with objects serialized by PHP 4?" [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [23:17:28] (03PS7) 10Brian Wolff: Cache page content language in Title object [core] - 10https://gerrit.wikimedia.org/r/90769 [23:20:03] (03CR) 10Tim Starling: [C: 04-1] "I think it would be better to use ScopedCallback rather than setting the variable before the return, so that the flag will be cleared if a" [core] - 10https://gerrit.wikimedia.org/r/92247 (owner: 10Brian Wolff) [23:20:25] (03CR) 10Brian Wolff: "Change it to just store the language code. Most of the time the page language = content language anyway, which is cheap to turn back into " [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [23:26:35] Reedy: suggestbot sounds like a fun project, but only if we have previous reviewer data [23:32:35] YuviPanda: See also: Gerrit [23:32:41] It's all ther [23:32:51] with a million API requests [23:32:54] NEED DUMPS! [23:33:08] Well, a dump won't be so much use to you [23:33:26] why not? [23:33:29] gerrit is moving away from storing stuff in database [23:33:33] (03CR) 10saper: "(1 comment)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92252 (owner: 10saper) [23:33:37] So you need the git repo is stores git repos in [23:33:50] Reedy: I've been hearing that for months [23:33:51] :P [23:33:59] still can't get list of comments / reviews via git [23:34:04] anyone to provide /lastlog with my nickname? irssi crashed :( [23:34:05] lol [23:45:07] (03CR) 10Brian Wolff: [C: 04-1] "D'oh. Also need to clone the preprocesser if im going to mess with its references." [core] - 10https://gerrit.wikimedia.org/r/92253 (owner: 10Brian Wolff) [23:57:40] (03CR) 10saper: "Ok, now more detailed:" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/92050 (owner: 10Legoktm)