[00:00:04] (03Merged) 10jenkins-bot: js-error-output [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98686 (owner: 10Dan-nl) [00:04:48] (03CR) 10CSteipp: [C: 031] original-post [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98846 (owner: 10Dan-nl) [00:06:32] (03PS2) 10BryanDavis: original-post [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98846 (owner: 10Dan-nl) [00:06:40] (03CR) 10BryanDavis: [C: 032] original-post [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98846 (owner: 10Dan-nl) [00:06:46] (03Merged) 10jenkins-bot: original-post [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98846 (owner: 10Dan-nl) [00:10:06] (03PS1) 10Chad: Clean up where conditions in sql query [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99277 [00:13:40] (03PS2) 10Bsitu: Timestamp in history page gets into show/hide loop on hoverOver [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98860 [00:14:23] (03PS3) 10Bsitu: Timestamp in history page gets into show/hide loop on hoverOver [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98860 [00:22:49] (03CR) 10Krinkle: [C: 031] "Untested, looks good. 'browsers' is bogus indeed, and $.client.test supports both .ltr/.rtl structures and unnested ones." [core] - 10https://gerrit.wikimedia.org/r/95870 (owner: 10Bartosz Dziewoński) [00:29:41] gwicke: I think you answered paravoid on this yesterday but I cant seem to find it in my backscroll; did you get anywhere with node 0.10 testing? [00:30:24] (03CR) 10EBernhardson: [C: 032] Timestamp in history page gets into show/hide loop on hoverOver [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98860 (owner: 10Bsitu) [00:30:36] (03Merged) 10jenkins-bot: Timestamp in history page gets into show/hide loop on hoverOver [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98860 (owner: 10Bsitu) [00:37:08] (03CR) 10Chad: [C: 032] Allow config loading from file [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98354 (owner: 10BryanDavis) [00:37:15] (03Merged) 10jenkins-bot: Allow config loading from file [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98354 (owner: 10BryanDavis) [00:38:06] (03PS1) 10EBernhardson: Remove unused SelectQueryBuilder class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99282 [00:42:43] (03PS1) 10EBernhardson: Return hex representation of UUID in __toString [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99285 [00:42:48] (03CR) 10jenkins-bot: [V: 04-1] Return hex representation of UUID in __toString [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99285 (owner: 10EBernhardson) [00:43:02] (03PS2) 10EBernhardson: Return hex representation of UUID in __toString [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99285 [00:43:50] ^d: I've been trying to call the "Misc" tab. It's actually gone from core, but two extensions are sticking preferences in there. [00:43:56] s/call/kill/ [00:44:34] <^d> What extensions? :p [00:44:48] Thanks and EducationProgram [00:44:56] I already filed bugs. ;-) [00:45:14] I'm looking at Special:Preferences again... the "Pending changes" tab is more weight than it's worth. [00:46:19] <^d> Wow, we've got some really bogus values in enwiki's preferences table. [00:46:25] <^d> Wonder how these got here. [00:46:29] Tim filed a bug about that. [00:47:03] https://bugzilla.wikimedia.org/show_bug.cgi?id=52777 [00:47:44] Elsie: Hey, isn't it about time for you to magically become another nick? [00:47:51] mwalker: sorry for the delay- I'm installing it now, but have been using it locally for months now [00:47:52] It may be! [00:48:04] I think we're 4 days off from the 6 month mark. [00:48:05] <^d> Elsie: We should...clean this up. [00:48:07] others on the team did the same, so I expect no issues [00:48:08] <^d> Tim's right :) [00:48:16] I think individual bugs would help. [00:48:24] Not that db's comments aren't helpful. [00:48:34] gwicke: *nods* any thoughts on when it might be available through wmf puppet? [00:48:39] marktraceur: It seems it is. I'll have to consult my list. [00:48:44] (03CR) 10Aaron Schulz: Fix fetching ParserOutput (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 (owner: 10Chad) [00:48:52] Woot. [00:49:06] * marktraceur may not effect great change, but he does effect some change. [00:49:10] mwalker: I think Faidon can just push it when he feels like it [00:49:26] meaning, won't break existing services when upgraded [00:49:28] ... sometime after you give the go ahead Im assuming [00:49:43] we'll have to coordinate the upgrade a bit as node_modules will need an upgrade too [00:49:54] at least if binary modules are involved [00:50:42] I'm pretty sure we are free of binary modules currently [00:50:57] heh [00:51:00] lucky you :p [00:51:07] we have them scattered all over [00:51:09] *I do [00:51:27] well; ish [00:51:30] we have four [00:51:33] mwalker: we should be ready to go for prod by Monday [00:51:33] 2 are optional [00:51:38] awesome [00:54:07] (03CR) 10EBernhardson: [C: 032] Remove redundant TitleIsAlwaysKnown() hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99275 (owner: 10Bsitu) [00:54:16] (03Merged) 10jenkins-bot: Remove redundant TitleIsAlwaysKnown() hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99275 (owner: 10Bsitu) [00:54:40] JeffHall: Hey, do you know if wgMaxShellMemory is set lower on beta than it is in production? [00:54:51] (cc James_F) [00:55:11] Isn't the config on noc? [00:55:16] Probably [00:55:33] <^d> What the hell? [00:55:38] <^d> | 250107 | searchNs4294967295 | [00:55:39] marktraceur: No, I don't know - haven't learned about environment configs yet :( [00:55:54] 'kay [00:56:00] (03PS1) 10Bsitu: username with ' breaks user mention in reply box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99287 [00:56:07] <^d> What is namespace 4294967295, and why do 250107 people search it? ;-) [00:56:54] Hm, I don't see any different settings. Weird. [00:58:23] <^d> Elsie: http://p.defau.lt/?I6qEcQNw8oB5CeKAabWGdQ. I think the format changed at some point. [00:58:30] <^d> I see a lot of instances of "negative" namespaces. [00:58:54] http://p.defau.lt/?I6qEcQNw8oB5CeKAabWGdQ [00:59:08] Hmmm, fun. [00:59:15] ^d: That's the maximum 32 bit integer, so it's probably a bug in an API client somewhere [00:59:15] (03CR) 10Kaldari: "If extra newlines are mandatory inside OutputPage::wrapWikiMsg(), which appears to be what you and Nikerabbit are suggesting, the newlines" [core] - 10https://gerrit.wikimedia.org/r/97914 (owner: 10Kaldari) [00:59:48] I think -1 actually means something [00:59:49] marktraceur: Not an API client. [01:00:14] (03CR) 10Aaron Schulz: [C: 032] Improve ApiQueryTestBase::assertResult [core] - 10https://gerrit.wikimedia.org/r/99156 (owner: 10Anomie) [01:00:30] -1 is Special: [01:00:32] -1 is a namespace. Special or Media. [01:00:39] (03PS1) 10Mwalker: Updating versions of dependencies [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99289 [01:00:40] Media must be -2, then. [01:00:58] (03CR) 10Mwalker: [C: 032 V: 032] Updating versions of dependencies [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99289 (owner: 10Mwalker) [01:01:19] (03CR) 10Bsitu: "Usually we only update the rev id in site configuration file and we don't update it in the extension file. In this context, the number is " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96902 (owner: 10Bsitu) [01:01:26] <^d> That's not it though. [01:01:32] <^d> I don't think :) [01:01:48] Lots of bugs, it seems like. [01:01:49] -0 is funny [01:01:54] <^d> That's my point. [01:01:54] And very little maintenance on the table. [01:02:04] * Elsie shrugs. [01:02:11] It's a dataset that few people have access to. [01:02:42] Elsie: Why not an API client? Maybe I misunderstand what this is supposed to be. [01:03:05] marktraceur: Perhaps an API client has a bug, but if these values are stored in user_properties, that's a MediaWiki bug. [01:03:05] mwalker: sadly the install failed as libv8 in the right version is missing [01:03:16] Ah. [01:03:20] (03PS4) 10Legoktm: Escape wikitext from the topic title in post history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99271 (owner: 10EBernhardson) [01:03:26] gwicke: :'( [01:03:30] Perhaps a resolved MediaWiki bug. [01:03:30] mwalker: will ask faidon to provide that too [01:03:32] (03CR) 10Legoktm: [C: 031] Escape wikitext from the topic title in post history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99271 (owner: 10EBernhardson) [01:03:46] in the worst case we can also use the deb from the ppa, which I'm using for rashomon testing [01:04:23] https://www.mediawiki.org/wiki/User:GWicke/Notes/Storage/Cassandra_testing#Rashomon_setup [01:04:25] (03PS1) 10Mwalker: Minor fixes from the test box [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/99291 [01:04:31] (03Merged) 10jenkins-bot: Improve ApiQueryTestBase::assertResult [core] - 10https://gerrit.wikimedia.org/r/99156 (owner: 10Anomie) [01:04:36] (03CR) 10Mwalker: [C: 032 V: 032] Minor fixes from the test box [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/99291 (owner: 10Mwalker) [01:06:08] marktraceur: Perhaps I'll use "Sumana" as my next nick. ;-) [01:06:44] * marktraceur can only encourage this. [01:08:25] <^d> I'm pretty sure -'s are all a bug. I can't find what bug though :) [01:08:27] <^d> Oh wellllll [01:11:46] (03PS1) 10EBernhardson: Properly escape $talkUrl as an html attribute [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99292 [01:13:28] (03PS4) 10Werdna: [WIP] Add Flow events to Special:Contributions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 [01:14:22] (03CR) 10Werdna: "I rescued getComparisonUUID from the depths of my git history." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna) [01:16:36] (03PS1) 10EBernhardson: Properly escape $class as html attribute [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99293 [01:18:58] (03CR) 10shinjiman: "Thanks Siebrand, I've got the busy days on reality before then I am just back to do some kind of changes as before. But needs some time to" [core] - 10https://gerrit.wikimedia.org/r/99086 (owner: 10shinjiman) [01:19:39] (03CR) 10Bsitu: [C: 032] Return hex representation of UUID in __toString [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99285 (owner: 10EBernhardson) [01:19:49] (03Merged) 10jenkins-bot: Return hex representation of UUID in __toString [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99285 (owner: 10EBernhardson) [01:24:29] in github, is there any way for me to see a list of open pull requests that I submitted? [01:25:10] <^d> Across all repos? [01:25:13] <^d> Or just for one repo? [01:25:27] preferably across all [01:25:43] you would think that would be a pretty basic feature [01:25:49] <^d> That I don't know. For a single repo, you can go to Pull Requests -> Mine. [01:25:55] like the top of gerrit's dashboard [01:25:58] <^d> Which gives you a url like https://github.com/demon/hhvm/pulls/demon [01:26:11] <^d> Oh, duh [01:26:12] <^d> https://github.com/dashboard/pulls [01:27:48] is there a link to that somewhere? [01:28:05] <^d> Yeah, "Pull reuqests" when you're on the homepage. [01:28:08] ah right, on github.com [01:28:32] yeah, I hadn't realised there was anything on the homepage [01:28:52] <^d> Sooo, I was looking at bug 52777. [01:29:07] <^d> I think the skin entries with "" as the value are due to an old bug if memory serves. [01:29:15] <^d> I think it was long-since fixed. [01:35:02] <^d> TimStarling: You can also drop another 769131 rows with ajaxsearch. [01:35:14] <^d> Doesn't exist anymore, can't remember when it was removed. [01:35:22] <^d> I'll mention on the bug. [01:35:37] thanks [01:36:00] I think that bug should be split out. [01:36:55] (03CR) 10Bsitu: Set a global cache time within Flow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 (owner: 10EBernhardson) [01:36:56] <^d> I wonder where the bogus entries that look like signatures came from. [01:37:01] <^d> There's no more than 1 of each of them. [01:37:46] Input validation is hard. [01:43:43] <^d> 1/3 of gadgets have 10 users or less, heh. [01:43:58] o.O [01:44:04] <^d> Roughly. [01:44:17] <^d> 37.7% [01:45:01] <^d> 39.8% have 1000 or more users. [01:45:12] <^d> Rest have from 10 - 1000, obviously. [01:45:33] ^d: Fewer [01:45:38] Express user checkout [01:45:53] (03PS1) 10Mwalker: Updating required packages [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99294 [01:45:55] <^d> UTC clock is 5th most popular gadget, heh. [01:45:59] <^d> I like that one too :) [01:46:06] (03CR) 10Mwalker: [C: 032 V: 032] Updating required packages [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99294 (owner: 10Mwalker) [01:46:38] (03PS1) 10Mwalker: Make status updates work again [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/99295 [01:46:50] (03CR) 10Mwalker: [C: 032 V: 032] Make status updates work again [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/99295 (owner: 10Mwalker) [01:48:37] mwalker: rt testing is now running 0.10.22 from the PPA [01:51:45] (03CR) 10Bsitu: [C: 032] Escape wikitext from the topic title in post history (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99271 (owner: 10EBernhardson) [01:52:04] (03Merged) 10jenkins-bot: Escape wikitext from the topic title in post history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99271 (owner: 10EBernhardson) [01:52:13] <^d> TimStarling: I think the negative sign...means something? Or was a bug? There's lots of preferences with extra -'s snuck in the key. [01:53:26] (03CR) 10Bsitu: Better GENDER support in moderation.js (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [01:53:39] <^d> (So I don't think searchNs-1 means NS_SPECIAL, actually) [01:55:33] (03PS1) 10Krinkle: grunt-qunit: Add option to pass file path [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99300 [02:05:13] (03CR) 10Krinkle: [C: 032] grunt-qunit: Add option to pass file path [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99300 (owner: 10Krinkle) [02:05:17] (03Merged) 10jenkins-bot: grunt-qunit: Add option to pass file path [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99300 (owner: 10Krinkle) [02:08:44] (03PS1) 10Krinkle: Create new "qunitfile" macro and use in oojs-core [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99304 [02:10:01] (03CR) 10Krinkle: "Pushed to Jenkins for testing: https://integration.wikimedia.org/ci/job/oojs-core-qunitfile" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99304 (owner: 10Krinkle) [02:10:39] (03PS1) 10Catrope: Add OOJS v1.0.5 to core [core] - 10https://gerrit.wikimedia.org/r/99305 [02:10:52] marktraceur: ^^^ [02:10:53] marktraceur: https://gerrit.wikimedia.org/r/#/c/99305/ [02:13:43] (03PS8) 10Catrope: Add OOJS UI v0.1.0-pre (f90c7bcce6) to core [core] - 10https://gerrit.wikimedia.org/r/98887 [02:14:41] (03CR) 10Jforrester: [C: 04-1] "Per Siebrand's previous review, not yet implemented." [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [02:22:29] (03PS2) 10Krinkle: Create new "qunitfile" macro and use in oojs-core [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99304 [02:41:18] (03CR) 10Krinkle: [C: 032] Add OOJS v1.0.5 to core [core] - 10https://gerrit.wikimedia.org/r/99305 (owner: 10Catrope) [02:44:35] (03Merged) 10jenkins-bot: Add OOJS v1.0.5 to core [core] - 10https://gerrit.wikimedia.org/r/99305 (owner: 10Catrope) [02:48:09] (03PS1) 10Jforrester: Add OOJS v1.0.5 to core [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99311 [02:54:01] (03CR) 10Krinkle: [C: 04-2] "Though the grunt script works as expected, holding off usage as this is intended for usage in oojs which has other issues that make this u" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99304 (owner: 10Krinkle) [03:07:13] (03CR) 10Catrope: "Please test code before merging it, and please do not self-merge." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [03:08:06] (03PS1) 10AndyRussG: Style deletion warning messages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/99316 [03:09:33] (03PS1) 10Catrope: Followup ec3d1d67c: fix fatals because of removed run() methods [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99317 [03:09:43] ragesoss: https://gerrit.wikimedia.org/r/#/c/99316/ [03:09:53] Ooops wrong channel [03:09:57] (03CR) 10Catrope: "Fix: https://gerrit.wikimedia.org/r/99317" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [03:11:22] manybubbles: Could you merge https://gerrit.wikimedia.org/r/#/c/99317/ lest CirrusSearch break VisualEditor in tomorrow's deployment? [03:13:43] (03CR) 10Mattflaschen: Add Special:Thanks as a non-JS fallback (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [03:20:48] (03CR) 10Mattflaschen: [C: 04-1] "Looks good, overall." (034 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [03:27:38] (03CR) 10Mattflaschen: "Bug ID (56572) got lost again in latest patch set (8)." [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [03:28:27] (03CR) 10AndyRussG: [C: 031 V: 031] Display correct interface message when adding duplicate institution [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98537 (owner: 10Ragesoss) [03:28:53] (03PS9) 10Jforrester: Add OOJS UI v0.1.0-pre (f90c7bcce6) to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [03:34:12] (03CR) 10Jforrester: [C: 04-1] "Per PS7." [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [03:42:56] ori-l, spagewmf, easy review if one of you have a moment: https://gerrit.wikimedia.org/r/#/c/99250/ [03:43:31] Can test at /w/api.php?action=help&modules=gettingstartedgetpages on your localhost. [03:43:36] (03CR) 10Legoktm: [C: 032] Fix method name so descriptions actually show up in help [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/99250 (owner: 10Mattflaschen) [03:43:40] (03Merged) 10jenkins-bot: Fix method name so descriptions actually show up in help [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/99250 (owner: 10Mattflaschen) [03:43:49] Thanks, legoktm [03:43:52] :D [03:58:17] (03PS5) 10EBernhardson: Set a global cache time within Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 [04:04:49] (03PS4) 1001tonythomas: Removed "Disable search suggestions" from Mediawiki Preference [core] - 10https://gerrit.wikimedia.org/r/99163 [04:17:02] (03CR) 10Mattflaschen: "I don't agree that we "abandoned the idea of skins"." [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [04:46:30] (03PS1) 10EBernhardson: Creating topic on empty flow page fails [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99321 [04:55:05] (03PS1) 1001tonythomas: Removed "Justify paragraphs" from MW user Preference. [core] - 10https://gerrit.wikimedia.org/r/99322 [05:01:15] Tony Thomas is great. [05:01:21] tonythomas01: You're great. [05:01:38] tonythomas01: You should be able to assign bugs to yourself. [05:01:43] E-mail Andre if you can't. [05:01:51] There's some permissions stupidity for newer Bugzilla accounts. [05:01:56] Elsie, Thanks. [05:02:07] Elsie, but I cant assign bugs to myself [05:02:22] tonythomas01: Right, you're missing the "editbugs" permission, I think. [05:02:29] Andre can add it to your account. [05:02:35] It's a stupid system. [05:03:14] Elsie, yeah. that would be great help [05:03:39] I'll ping him. [05:03:46] Elsie, Thanks [05:04:35] https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines [05:04:38] tonythomas01: Check that out. ^ [05:04:47] (03PS1) 10EBernhardson: Prevent blocked users from editing headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99323 [05:04:50] Your commit messages should be wrapped a bit tighter. [05:05:16] I find commit messages always trouble. Anyway will go through it [05:05:22] That page is pretty bad. [05:05:24] Hmm. [05:10:02] (03CR) 10Chad: [C: 032] Followup ec3d1d67c: fix fatals because of removed run() methods [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99317 (owner: 10Catrope) [05:10:06] (03Merged) 10jenkins-bot: Followup ec3d1d67c: fix fatals because of removed run() methods [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99317 (owner: 10Catrope) [05:16:55] (03PS1) 10Reedy: Fix Call to a member function getCacheTime() on a non-object in RefreshLinksJob.php [core] - 10https://gerrit.wikimedia.org/r/99324 [05:17:36] (03CR) 10Aaron Schulz: [C: 032] Fix Call to a member function getCacheTime() on a non-object in RefreshLinksJob.php [core] - 10https://gerrit.wikimedia.org/r/99324 (owner: 10Reedy) [05:19:37] Original exception: [44d5ac45] /DevWiki/core/index.php?title=Special:UserLogin&returnto=Gallery+page Exception from line 245 of E:\var\www\DevWiki\core\includes\resourceloader\ResourceLoader.php: ResourceLoader duplicate registration error. Another module has already been registered as oojs [05:19:49] RoanKattouw_away: rarr [05:19:58] (03PS10) 10Mattflaschen: mediawiki.api: Fix token with postWithToken, add test [core] - 10https://gerrit.wikimedia.org/r/83217 [05:20:02] Aaron|home: do you have beta features enabled? [05:20:24] Aaron|home: Roan tracked it down to the beta features extension having crudely duplicated the module [05:20:45] no [05:20:45] (03CR) 10Mattflaschen: "As of patch set 10, it's also testing that the token is sent, rather than just that it handles a successful server response correctly." [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [05:20:51] (03CR) 10Mattflaschen: mediawiki.api: Fix token with postWithToken, add test (031 comment) [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [05:21:27] Aaron|home: btw, it was the weird dependency relationship, role::elasticsearch extending role::elasticsearch::config, that was causing the issue [05:21:52] i renamed role::elasticsearch to role::elasticsearch::server so that they're hierarchical siblings [05:22:02] (03Merged) 10jenkins-bot: Fix Call to a member function getCacheTime() on a non-object in RefreshLinksJob.php [core] - 10https://gerrit.wikimedia.org/r/99324 (owner: 10Reedy) [05:22:11] and now puppet works [05:22:15] so elastic got provisioned [05:23:26] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: Fix token with postWithToken, add test [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [05:27:30] (03PS1) 10EBernhardson: Indent and pad reply form to look more like a post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99325 [05:27:53] (03PS2) 10EBernhardson: Indent and pad reply form to look more like a post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99325 [05:31:41] ahh [05:37:23] https://bugzilla.wikimedia.org/show_bug.cgi?id=47812 [05:37:28] Does anyone have thoughts about this? [05:37:35] I can't see any good reason to have -autoconfirmed, but not -user. [05:45:33] (03PS11) 10Mattflaschen: mediawiki.api: Fix token with postWithToken, add test [core] - 10https://gerrit.wikimedia.org/r/83217 [06:24:37] I cleaned up https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines [06:33:07] (03CR) 10Jack Phoenix: [C: 032 V: 032] {{NUMBEROFCOMMENTSPAGE}} magic word/parser funct [extensions/Comments] - 10https://gerrit.wikimedia.org/r/98375 (owner: 10UltrasonicNXT) [06:39:26] (03CR) 10MZMcBride: "Brian: has some stats." [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas) [06:41:41] (03CR) 10Ori.livneh: [C: 032] Add udp2log compatible log handler [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99181 (owner: 10BryanDavis) [06:41:46] (03Merged) 10jenkins-bot: Add udp2log compatible log handler [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99181 (owner: 10BryanDavis) [06:47:36] (03CR) 10Ori.livneh: [C: 032] Add configuration setting for SMTP host [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98960 (owner: 10BryanDavis) [06:47:40] (03Merged) 10jenkins-bot: Add configuration setting for SMTP host [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98960 (owner: 10BryanDavis) [07:02:50] (03PS2) 10Siebrand: Change line breaks in LocalFile::recordUpload2() [core] - 10https://gerrit.wikimedia.org/r/99147 [07:30:50] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/99322 (owner: 1001tonythomas) [07:37:14] (03CR) 10Robert Vogel: [C: 032 V: 032] "Thanks. Those are pretty old scripts we used at out customers. They really need some makeover." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/97551 (owner: 10Chad) [07:37:31] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/99163 (owner: 1001tonythomas) [07:38:22] (03CR) 10Siebrand: "Attempt to close the open talk points. Will follow-up with an email." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/99136 (owner: 10Siebrand) [07:47:49] (03CR) 10Siebrand: [C: 04-1] Add OOJS UI v0.1.0-pre (f90c7bcce6) to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [07:53:26] (03CR) 10Siebrand: "Doesn't have to happen today :). If you need help, please join the #mediawiki-i18n IRC channel. We'd be happy to help you get on the train" [core] - 10https://gerrit.wikimedia.org/r/99086 (owner: 10shinjiman) [07:54:38] siebrand: Huh, I didn't know the rebase + changes rule. A bit of a trap. :-) [07:55:27] I also learned this evening that we have a definitive rule about periods. [07:55:36] Elsie: with rebase+changes, the diffs become unreadable. [07:56:07] Elsie: that is, the diffs between patch sets, which make it very convenient to review incrementally. [07:56:07] * Elsie nods. [07:56:17] It makes sense, it just feels counter-intuitive off-hand. [07:56:33] siebrand, but, before we submit the patch into gerrit, we need to git pull and rebase right ? [07:56:37] Because I think most devs would try to reduce the number of commits. [07:56:46] You can do "git pull --rebase". [07:56:50] I think. [07:56:54] oh [07:56:56] tonythomas01 / Elsie : If you use git-review, you can have it all done for you. [07:57:28] I need https://www.mediawiki.org/wiki/Gerrit/Getting_started tattooed on my body. [07:57:33] I am using git review. but there too, we need to do git pull origin master and later git rebase origin/master right ? [07:57:33] Looking up a link that just got communicated in our daily... [07:57:47] Will paste once someone can reproduce it for me... [07:57:59] tonythomas01: I don't think you should be rebasing. [07:58:19] tonythomas01: Are you a wiki editor? Like Wikipedia? [07:59:09] Elsie, Nope. I just roam around with mediawiki bugs [07:59:13] Elsie, thats all [07:59:25] Fair enough. [07:59:27] tonythomas01 / Elsie : This is the one to put under your pillow: https://www.mediawiki.org/wiki/Git/TLDR [07:59:29] It's wonderful to have you around. :-) [07:59:45] I'm excited about possibly getting user preferences de-cluttered/modernized. [08:00:01] We'll see how much resistance there is to change. [08:00:05] it's a usability initiative [08:00:11] Heh. [08:00:14] Lowercase U. [08:00:17] More like you. [08:00:31] yeah. I am working on that. Thanks for that. ofcourse there is a lot of resistance. [08:00:43] siebrand: Ah, yes, that's a redirect to the page I just linked about getting tattooed. ;-) [08:01:03] tonythomas01: We'll see. Stats will help our cause, I think. [08:02:10] Elsie, yeah. and earlier when I git-review 'ed without git rebase, I get this from jenkins bot - This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset. [08:02:43] Hmm. [08:03:03] Hi [08:03:08] hi [08:03:53] can anybody tell me how to add new tasks to GOogle Code in Site [08:03:55] ? [08:04:12] Elsie, Now I understood ! I used to push it with git review -R , I should've given git review --no-rebase [08:04:21] and used git pull --rebase earlier [08:04:42] legoktm: You around? [08:05:08] Harsh_: andre__ or qgil or MatmaRex or legoktm would know. [08:05:12] But it's a bit late right now. [08:05:41] superm401 might know. [08:05:53] @Elsie anyone else? [08:05:58] I know the Bugzilla side is pretty much a keyword (gci2013) or something. [08:06:10] But to make a GCI entry, I assume you need to have an account on Google, I guess? [08:06:14] Not really sure. [08:06:30] Sorry, Harsh_. I'm not involved in Google Code In, so I'm not sure. [08:06:52] Ah, I thought I'd seen e-mails from you about it, sorry. [08:07:48] Harsh_: https://www.mediawiki.org/wiki/GCI might help. [08:08:28] mails about? [08:08:59] Google Code-In. [08:09:02] On the wikitech-l mailing list. [08:09:11] Quim was looking for additional project ideas, I think. [08:13:31] yes @Elsie [08:21:33] (03PS3) 10Mattflaschen: Move in required gettingstarted tour messages from GuidedTour [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/94369 (owner: 10Phuedx) [08:23:51] (03PS4) 10Mattflaschen: Move in required gettingstarted tour messages from GuidedTour [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/94369 (owner: 10Phuedx) [08:25:07] (03CR) 10Mattflaschen: "I verified locally that all three tours work." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/94369 (owner: 10Phuedx) [08:34:11] (03CR) 10Siebrand: [C: 032] Move in required gettingstarted tour messages from GuidedTour [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/94369 (owner: 10Phuedx) [08:34:13] (03Merged) 10jenkins-bot: Move in required gettingstarted tour messages from GuidedTour [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/94369 (owner: 10Phuedx) [08:58:40] (03PS1) 10Liangent: Do title conversion on &action=edit if &redlink=1 exists [core] - 10https://gerrit.wikimedia.org/r/99335 [09:04:49] (03CR) 10Nikerabbit: Escape wikitext from the topic title in post history (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99271 (owner: 10EBernhardson) [09:13:53] (03PS1) 10Siebrand: Add more type hints in comments for static code analysis [core] - 10https://gerrit.wikimedia.org/r/99336 [09:17:13] (03PS1) 10Mattflaschen: Bump GettingStarted to import required messages [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99338 [09:19:46] Are the Gerrit show/hide line links (e.g. "10" in "skipped 10 common lines") broken for anyone else? [09:20:36] (03CR) 10Siebrand: "This was based on an email conversation I had with Tyler." [core] - 10https://gerrit.wikimedia.org/r/99336 (owner: 10Siebrand) [09:36:21] YuGin: hi! did you see that I marked your page for translation yesterday? [09:38:14] (03CR) 10saper: "Very nice change. It also fixed bug 57976 for me. Was that expected?" [core] - 10https://gerrit.wikimedia.org/r/99156 (owner: 10Anomie) [09:43:21] ah, yes, you edited one of the page [09:45:05] YuGin: now you have to copy the old translations, e.g. https://www.mediawiki.org/w/index.php?title=Help:Sysop_deleting_and_undeleting/id&action=edit&oldid=718595 (found in page history) -> https://www.mediawiki.org/w/index.php?title=Special:Translate&group=page-Help%3ASysop+deleting+and+undeleting&action=page&filter=&language=id (translate tab) [09:50:36] (03PS1) 10saper: Remove mergeExpected and assertResultRecursive [core] - 10https://gerrit.wikimedia.org/r/99340 [09:52:32] (03PS2) 10saper: Remove mergeExpected and assertResultRecursive [core] - 10https://gerrit.wikimedia.org/r/99340 [09:53:10] (03PS3) 10saper: Remove mergeExpected and assertResultRecursive [core] - 10https://gerrit.wikimedia.org/r/99340 [09:53:39] (03PS1) 10Hashar: browsertests: remove ~@phantomjs-bug [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99341 [09:53:50] (03CR) 10Hashar: [C: 032] browsertests: remove ~@phantomjs-bug [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99341 (owner: 10Hashar) [09:54:49] (03Merged) 10jenkins-bot: browsertests: remove ~@phantomjs-bug [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99341 (owner: 10Hashar) [09:57:28] (03CR) 10saper: "This code needs to be revisited after 946c575fe6993196eb88e96c0bb7d159fc96c99b (API response matching has been simplified)" [core] - 10https://gerrit.wikimedia.org/r/48098 (owner: 10Yurik) [10:05:38] (03PS1) 10Siebrand: Update formatting for media related classes [core] - 10https://gerrit.wikimedia.org/r/99344 [10:06:14] (03CR) 10Pginer: [C: 04-1] "The star disappears once I click on it. It seems to be a mismatch between the names used on the Less file and the name of the graphical as" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx) [10:25:21] (03CR) 10Siebrand: [C: 032] Changed ZeroRatedMobileAccess to Zero [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/99158 (owner: 10Yurik) [10:25:22] (03CR) 10jenkins-bot: [V: 04-1] Changed ZeroRatedMobileAccess to Zero [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/99158 (owner: 10Yurik) [10:25:50] (03CR) 10Siebrand: "Needs manual rebase." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/99158 (owner: 10Yurik) [10:29:52] (03CR) 10Siebrand: [C: 031] "Nice. +1 on the concept. I added Krinkle for JS review." [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [10:40:08] (03PS1) 10saper: Don't testHumanTimestamp until expectations known [core] - 10https://gerrit.wikimedia.org/r/99349 [10:51:15] (03CR) 10saper: "I believe that proper discussion how to introduce this should be carried out in the original change, not here. Currently master does not i" [core] - 10https://gerrit.wikimedia.org/r/99068 (owner: 10saper) [11:06:26] (03PS2) 10Yurik: Changed ZeroRatedMobileAccess to Zero [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/99158 [11:27:02] (03CR) 10Nikerabbit: [C: 031] mediawiki.api: Fix token with postWithToken, add test [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [11:38:31] (03PS1) 10Siebrand: Remove PHP4 style constructor [core] - 10https://gerrit.wikimedia.org/r/99354 [11:38:32] (03PS1) 10Siebrand: Break long lines in media related classes [core] - 10https://gerrit.wikimedia.org/r/99355 [11:38:33] (03PS1) 10Siebrand: Remove function calls from for loop test part in media classes [core] - 10https://gerrit.wikimedia.org/r/99356 [11:38:34] (03PS1) 10Siebrand: Ignore CodeSniffer warning where unavoidable in media classes [core] - 10https://gerrit.wikimedia.org/r/99357 [11:44:31] (03PS2) 10M4tx: Add an SVG version of watch icon [core] - 10https://gerrit.wikimedia.org/r/99258 [11:48:03] (03CR) 10M4tx: "Yeah, that was really stupid mistake. Fixed already." [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx) [11:52:14] (03CR) 10Aude: [C: 04-1] "in test setUp() we could set $wgHooks global to empty. (using setMwGlobals)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [11:52:59] Hey, I am working on the bug 56121 https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 , The changes are to be made in the Multimediaviewer.118n.php file, can anyone please help me with it? [12:02:32] (03PS1) 10Aude: Whitelist saper [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/99364 [12:06:31] Hello [12:08:20] (03CR) 10saper: "No, I don't think so... having extensions and hooks enabled allows us to find interesting breakage at times (though this is not strictly a" [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [12:13:04] (03CR) 10saper: [C: 031] "I feel honored! Thanks!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/99364 (owner: 10Aude) [12:20:11] (03CR) 10Aude: "then maybe clearing hooks should be done on a per test basis? for unit tests like this, they should be cleared. for integration tests, p" [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [12:26:52] (03CR) 10Manybubbles: Fix fetching ParserOutput (034 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 (owner: 10Chad) [12:27:03] (03PS1) 10Zfilipin: Revert "Revert "Prefer double-quoted strings in Ruby code"" [selenium] - 10https://gerrit.wikimedia.org/r/99372 [12:29:45] (03CR) 10Zfilipin: [C: 032] Revert "Revert "Prefer double-quoted strings in Ruby code"" [selenium] - 10https://gerrit.wikimedia.org/r/99372 (owner: 10Zfilipin) [12:29:47] (03Merged) 10jenkins-bot: Revert "Revert "Prefer double-quoted strings in Ruby code"" [selenium] - 10https://gerrit.wikimedia.org/r/99372 (owner: 10Zfilipin) [12:30:55] (03CR) 10saper: "Maybe, yes. I am not sure I am still happy with what a human friendly timestamp should be. Is the definition of it to be "like in Facebook" [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [12:33:24] (03PS1) 10Tpt: Fix error with extension tags for automatic header and footer [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99373 [12:34:13] (03CR) 10Aude: "perhaps the definition of "human timestamp" can be clarified, and I'm not quite sure how best to do that." [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [12:36:48] (03PS2) 10Tpt: Improve ProofreadIndexPage parser management [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97941 [12:53:28] (03PS1) 10Siebrand: Declare visibility for class properties of PNGMetadataExtractor [core] - 10https://gerrit.wikimedia.org/r/99376 [12:55:29] (03PS1) 10Siebrand: Do not access MediaTransformOutput->url directly in Linker [core] - 10https://gerrit.wikimedia.org/r/99377 [12:58:42] (03PS3) 10Hashar: Update ProofreadPage to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99042 (owner: 10Tpt) [13:03:03] (03PS1) 10Tpt: Let contentHandler system add change of level tags in edit summaries [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99379 [13:03:05] (03CR) 10Hashar: [C: 032] Update ProofreadPage to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99042 (owner: 10Tpt) [13:03:19] wish me luck, my first time deploying an extension [13:04:41] (03PS3) 10Tpt: Improve ProofreadIndexPage parser management [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97941 [13:04:51] (03PS2) 10Tpt: Fix error with extension tags for automatic header and footer [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99373 [13:05:04] (03PS3) 10Tpt: Fix error with extension tags for automatic header and footer [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99373 [13:06:27] and now updating l10n cache [13:07:45] hey hashar, when you have a moment. would you be able to approve this pending change? http://www.mediawiki.org/w/index.php?title=Manual:PHP_unit_testing/Writing_unit_tests_for_extensions&stable=0&redirect=no [13:08:48] ahhh l10n cache is a mess [13:09:11] (03PS2) 10saper: Uninstall GetHumanTimstamp hook for testing core [core] - 10https://gerrit.wikimedia.org/r/99349 [13:09:15] dan-nl: yeah no clue how to receive notifications for pending changes [13:09:35] who usually approves those? [13:09:40] no idea [13:09:47] k [13:10:03] (03PS1) 10Siebrand: Declare visibility on class props of MediaTransformOutput and MediaTransformError [core] - 10https://gerrit.wikimedia.org/r/99383 [13:10:19] dan-nl: I think I approved them, can you check ? [13:10:46] yep that took care of it [13:10:51] what did you have to do? [13:10:54] (03CR) 10saper: "This patch adds some MediaWikiTestCase::uninstallHook to get rid of GetHumanTimestamp for this test." [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [13:10:58] no idea [13:11:01] I clicked everywhere [13:11:19] eventually got shown a diff of the pending changes with a button to accept the revisions :D [13:11:19] ha! lol [13:11:39] thanks [13:11:51] ahhhgg [13:11:55] DIRECTORY_SEPARATOR [13:11:58] do you really need that ? [13:12:48] no, it looks like php is fine with / for both windows and other os's [13:13:22] might want to get rid of it so [13:13:48] I should one day make the mediawiki/core ExtensionSuite to look for tests under extensions/*/tests [13:13:59] aka make the UnitTestList registration optional [13:14:12] so [13:14:32] so [13:14:37] sync-l10nupdate-1 1.23wmf5 takes a loooong time [13:15:06] k, i'll make the change [13:15:48] why when I install mediawiki viewer I see (Closure) at Extension functions [13:16:05] how do you see that ? :D [13:16:13] ahh [13:16:20] Special:Version page [13:16:26] maybe an extension function got registered using something like = function() { … } [13:16:31] which is a Closure iirc [13:16:42] also the extension doesn't work [13:17:32] hashar: how can I resolve this ? [13:17:40] (03PS3) 10saper: Uninstall GetHumanTimestamp hook for testing core [core] - 10https://gerrit.wikimedia.org/r/99349 [13:17:44] i don't even know what mediawiki viewer is [13:17:50] vandrew: that is likely fixed in 1.22 [13:17:55] maybe it is too old to work on your wiki [13:18:01] or too recent expecting a recent mw [13:18:21] it does work on mark wiki... [13:18:53] Nikerabbit: so I should download 1.22 version yes ? [13:18:55] Nikerabbit: any idea how long it usually take for `sync-l10nupdate-1 1.23wmf5` to run ? [13:19:38] hashar: I would guess ~15-20 minutes when I last used it [13:19:42] ah [13:19:45] but there has been changes since [13:19:53] where can I find the 1.22 ? [13:19:54] so definitely not a few seconds [13:20:09] vandrew: not released yet [13:20:32] hashar: any other way to test this extension ? [13:20:38] vandrew: it should be released soon. We have a release candidate though http://download.wikimedia.org/mediawiki/1.22/mediawiki-1.22.0rc3.tar.gz [13:20:49] might be enough to get the multimedia viewer tested [13:21:04] thx [13:21:06] make sure to backup your database, review the changes in RELEASE-NOTES and double read UPGRADE :D [13:21:09] (03PS4) 10saper: Uninstall GetHumanTimestamp hook for testing core [core] - 10https://gerrit.wikimedia.org/r/99349 [13:21:16] and backup your database! [13:21:32] vandrew: if you want to test the extension, it might be enable on some Wikimedia wiki already [13:22:51] (03PS5) 10saper: Uninstall GetHumanTimestamp hook for testing core [core] - 10https://gerrit.wikimedia.org/r/99349 [13:24:06] vandrew: I have to resolve a bug regarding the extension [13:24:08] hashar: got rid of the DIRECTORY_SEPARATOR https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests_for_extensions#Register_your_tests_with_UnitTestsList [13:25:49] (03PS1) 10Siebrand: Declare visibility on class property of MediaHandler [core] - 10https://gerrit.wikimedia.org/r/99384 [13:27:14] dan-nl: nice [13:27:57] (03CR) 10saper: "Sorry for typos!" [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [13:28:23] Tpt_: deploying your update [13:28:34] hashar: Thanks :-) [13:28:40] Tpt_: should be live now [13:29:07] gotta check the bug report Phe opened [13:29:13] he pointed an URL that caused some fatal error [13:31:26] Tpt_: still fataling https://fr.wikisource.org/w/index.php?title=Page:Stendhal_-_Vie_de_Napoléon.djvu/342&action=edit :D [13:31:47] :-( [13:31:51] (03PS6) 10Aude: Uninstall GetHumanTimestamp hook for testing core [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [13:32:41] (03CR) 10Aude: [C: 031] "looks good and finally allows the timestamp tests to pass for me! :) Thanks saper!" [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [13:34:08] * aude needs someone else to +2 [13:34:48] (03CR) 10Hashar: [C: 032] ":-]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/99364 (owner: 10Aude) [13:34:58] (03Merged) 10jenkins-bot: Whitelist saper [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/99364 (owner: 10Aude) [13:35:36] (03CR) 10Hashar: "deployed!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/99364 (owner: 10Aude) [13:37:39] (03PS1) 10Tpt: Fix fatal error in ProofreadPageLevel [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99386 [13:38:22] Tpt_: is that for the bug Phe is experiencing ? aka https://bugzilla.wikimedia.org/show_bug.cgi?id=57984 [13:39:03] thanks hashar [13:39:05] hashar: Yes, but the comment last failure isn't the same as the first one [13:39:10] Tpt_: if so you want to add in the commit message: bug: 57984 [13:39:16] aude: :-) [13:39:19] (03PS2) 10Tpt: Fix fatal error in ProofreadPageLevel [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99386 [13:39:27] aude: when are you guys getting access on wikimedia cluster ? :-] [13:39:34] hashar: I have just done it ;-) [13:39:35] (03PS1) 10Dan-nl: filebackend-user-access [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99387 [13:39:42] hashar: no idea [13:39:45] * aude has to ask [13:45:35] (03PS1) 10Siebrand: Declare visibility on class properties of GIFMetadataExtractor [core] - 10https://gerrit.wikimedia.org/r/99390 [13:48:20] (03PS3) 10Hashar: Fix fatal error in ProofreadPageLevel [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99386 (owner: 10Tpt) [13:48:46] Tpt_: I have no clue what this patch is doing though :/ [13:51:12] hashar: When the last proofreader is unknown it assume that the last proofreader is the current one (it's the assumption that make sense because it force that the page have been normaly tagged as "proofread" before being tagged as validated) [13:51:37] Tpt_: well if you are sure it is not going to break it we can deploy it :-] [13:52:09] * siebrand moos. [13:52:33] hashar: I would prefer to wait a little because there are some remaining bug fix on review [13:52:43] ookkk [13:53:11] Tpt_: so I guess that will be updated during next wmf branch update [13:53:22] yes [13:53:45] aka tonight for Mediawiki.org [13:53:55] and tuesday for the non wikipedia sites [13:54:13] hashar: yes [14:25:03] (03CR) 10Ragesoss: On Special:Contributions, mention EP roles (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98183 (owner: 10AndyRussG) [14:29:12] (03PS1) 10Siebrand: Declare visibility on class property of FormatExif [core] - 10https://gerrit.wikimedia.org/r/99397 [14:29:13] (03PS1) 10Siebrand: Declare visibility on class properties of Exif [core] - 10https://gerrit.wikimedia.org/r/99398 [14:31:25] (03PS4) 10Tpt: Fix error with extension tags for automatic header and footer [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99373 [14:34:43] zomg.. [14:35:02] not even the number parser is working in tablesorter... [14:35:14] ++ for testcases :D [14:40:28] (03CR) 10Anomie: [C: 032] Show tags on deleted edits through the API [core] - 10https://gerrit.wikimedia.org/r/98996 (owner: 10Jackmcbarn) [14:43:51] (03Merged) 10jenkins-bot: Show tags on deleted edits through the API [core] - 10https://gerrit.wikimedia.org/r/98996 (owner: 10Jackmcbarn) [14:44:24] andre__: re: https://bugzilla.wikimedia.org/show_bug.cgi?id=58014 - fwiw, the app is not in production anywhere, and it's a few months before it's 'released'. Not sure how 'critical' is used [14:45:34] (03PS7) 10Hashar: Uninstall GetHumanTimestamp hook for testing core [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [14:47:31] (03CR) 10Phe: [C: 031] Fix fatal error in ProofreadPageLevel [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99386 (owner: 10Tpt) [14:48:55] YuviPanda, critical is a crash. [14:49:09] http://www.mediawiki.org/wiki/Bugzilla/Fields#Severity [14:49:27] andre__: right. I don't really use them myself, but just thought I should let you know about the state of the app :) [14:51:17] (03CR) 10Anomie: [C: 04-1] "Patch looks good, but the commit message is wrong. assertResultRecursive isn't in what you're removing (assertQueryResults is), and mergeE" [core] - 10https://gerrit.wikimedia.org/r/99340 (owner: 10saper) [14:55:53] (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99386 (owner: 10Tpt) [14:56:00] (03Merged) 10jenkins-bot: Fix fatal error in ProofreadPageLevel [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99386 (owner: 10Tpt) [14:59:50] (03CR) 10Nikerabbit: [C: 032] Corrected the spelling of language name 'cu' [core] - 10https://gerrit.wikimedia.org/r/98855 (owner: 10Amire80) [15:00:31] (03CR) 10Hashar: "PS7: tweaked the Bug: field to trigger the change in bugzilla." [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [15:02:37] (03PS1) 10Tpt: Make Page: pages unserializer more comprehensive [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99406 [15:02:46] (03PS1) 10TheDJ: [WIP] tablesorter: testcases for the parsers [core] - 10https://gerrit.wikimedia.org/r/99407 [15:03:27] (03Merged) 10jenkins-bot: Corrected the spelling of language name 'cu' [core] - 10https://gerrit.wikimedia.org/r/98855 (owner: 10Amire80) [15:06:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] tablesorter: testcases for the parsers [core] - 10https://gerrit.wikimedia.org/r/99407 (owner: 10TheDJ) [15:18:11] (03PS2) 10Tpt: Make Page: pages unserializer more comprehensive [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99406 [15:20:48] (03CR) 10Phe: [C: 031] Make Page: pages unserializer more comprehensive [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99406 (owner: 10Tpt) [15:21:36] (03CR) 10Chad: "It wasn't a self merge if you look at the author :)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [15:22:12] (03PS3) 10Matthias Mullie: Introduce tipsy [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98820 [15:25:22] (03CR) 10Aude: "i think it's useful to be able to test the method, controlling for the alteration and not simply skipping it (although also an option)" [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [15:25:31] (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99406 (owner: 10Tpt) [15:25:37] (03Merged) 10jenkins-bot: Make Page: pages unserializer more comprehensive [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99406 (owner: 10Tpt) [15:30:58] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98183 (owner: 10AndyRussG) [15:36:19] (03CR) 10Siebrand: [C: 04-1] "The English message does not use the parameter. Hidden parameters are not discoverable. I don't support adding them, so please add it in t" [core] - 10https://gerrit.wikimedia.org/r/99265 (owner: 10MegaAlex) [15:37:09] (03CR) 10Matthias Mullie: [C: 032] 'view' action is implicit in urls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99262 (owner: 10EBernhardson) [15:37:13] (03CR) 10Phe: [C: 031] Fix error with extension tags for automatic header and footer [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99373 (owner: 10Tpt) [15:37:19] (03Merged) 10jenkins-bot: 'view' action is implicit in urls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99262 (owner: 10EBernhardson) [15:37:35] (03PS4) 10Tpt: Improve ProofreadIndexPage parser management [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97941 [15:37:36] (03PS5) 10Tpt: Fix error with extension tags for automatic header and footer [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99373 [15:37:37] (03PS1) 10Tpt: Use default header and footer defined in system messages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99412 [15:38:12] (03PS2) 10Siebrand: filebackend-user-access [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99387 (owner: 10Dan-nl) [15:38:29] (03CR) 10Matthias Mullie: [C: 032] Remove unused SelectQueryBuilder class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99282 (owner: 10EBernhardson) [15:38:39] (03Merged) 10jenkins-bot: Remove unused SelectQueryBuilder class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99282 (owner: 10EBernhardson) [15:40:11] (03CR) 10Matthias Mullie: [C: 032] username with ' breaks user mention in reply box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99287 (owner: 10Bsitu) [15:40:21] (03Merged) 10jenkins-bot: username with ' breaks user mention in reply box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99287 (owner: 10Bsitu) [15:40:49] (03CR) 10Siebrand: [C: 031] "i18n/L10n is okay." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99387 (owner: 10Dan-nl) [15:42:19] (03CR) 10Matthias Mullie: [C: 032] Properly escape $talkUrl as an html attribute [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99292 (owner: 10EBernhardson) [15:42:31] (03Merged) 10jenkins-bot: Properly escape $talkUrl as an html attribute [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99292 (owner: 10EBernhardson) [15:43:33] (03CR) 10Matthias Mullie: [C: 032] Properly escape $class as html attribute [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99293 (owner: 10EBernhardson) [15:43:43] (03Merged) 10jenkins-bot: Properly escape $class as html attribute [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99293 (owner: 10EBernhardson) [15:44:17] (03CR) 10Phe: [C: 031] Improve ProofreadIndexPage parser management [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97941 (owner: 10Tpt) [15:46:10] (03CR) 10Phe: [C: 031] Use default header and footer defined in system messages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99412 (owner: 10Tpt) [15:48:03] (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97941 (owner: 10Tpt) [15:48:10] (03Merged) 10jenkins-bot: Improve ProofreadIndexPage parser management [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97941 (owner: 10Tpt) [15:50:35] (03PS1) 10Tpt: no message [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99413 [15:51:13] (03Abandoned) 10Tpt: no message [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99413 (owner: 10Tpt) [15:51:47] (03CR) 10Matthias Mullie: [C: 031] Set a global cache time within Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 (owner: 10EBernhardson) [15:52:21] (03PS6) 10Tpt: Fix error with extension tags for automatic header and footer [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99373 [15:53:41] (03CR) 10Tpt: [C: 032] "Reviewed by Phe (PS 5-6 are a rebase)" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99373 (owner: 10Tpt) [15:53:48] (03Merged) 10jenkins-bot: Fix error with extension tags for automatic header and footer [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99373 (owner: 10Tpt) [15:54:04] (03PS2) 10Tpt: Use default header and footer defined in system messages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99412 [15:54:15] (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99412 (owner: 10Tpt) [15:54:20] (03Merged) 10jenkins-bot: Use default header and footer defined in system messages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99412 (owner: 10Tpt) [15:58:25] (03CR) 10Matthias Mullie: [C: 032] Creating topic on empty flow page fails [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99321 (owner: 10EBernhardson) [15:58:35] (03Merged) 10jenkins-bot: Creating topic on empty flow page fails [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99321 (owner: 10EBernhardson) [15:59:26] (03CR) 10Ragesoss: [C: 031 V: 031] "I tested it, and it does not seem to break the relevant messages in English." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98567 (owner: 10Siebrand) [15:59:41] (03PS1) 10Tpt: Fix link to not existing thumb for mono page files [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99414 [16:05:22] (03CR) 10Ragesoss: [C: 031 V: 031] "Tested in English, and it doesn't seem to break the relevant messages." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [16:08:46] (03PS1) 10Tpt: Improve text areas [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99415 [16:10:02] (03PS2) 10Tpt: Improve text areas [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99415 [16:12:59] * siebrand greets qgil  [16:13:12] hi siebrand ! [16:13:43] siebrand, I'm taking the liberty of adding ou to some Gerrit patches related to i18n/L10n. Thank you for your help reviewing Google Code-in related patches! [16:15:01] qgil: I reviewed some. I really don'y want to review the one on the orange bar. [16:15:14] qgil: That is a bad task for a novice. [16:15:24] ? which one? [16:15:56] qgil: https://gerrit.wikimedia.org/r/#/c/99000/ [16:16:38] qgil: I'm almost certain I had a long conversation about something a lot like that on another patch set. I think Matma Rex handled that eventually. [16:16:54] I think it was Matmarex or Nemo_bis 's idea [16:17:17] sure siebrand , you are invited o review, but you don't have to :) [16:17:42] qgil: I've removed my name from the reviewers list once already. [16:17:54] qgil: regardin my task [16:17:56] siebrand, ah sorry, didn't know [16:17:57] qgil: I'll probably choose to remain quiet. [16:18:08] (03CR) 10Nemo bis: [C: 04-1] "Thanks for the patch. I think the commit message and qqq are wrong: you are passing the number to showCreateLink, so not only to searchmen" [core] - 10https://gerrit.wikimedia.org/r/99265 (owner: 10MegaAlex) [16:18:24] it seems that there are still some problems regarding the link when it is on a localhost [16:18:53] hi vandrew can you share URLs, please? [16:19:02] https://gerrit.wikimedia.org/r/#/c/98180/ [16:19:07] vandrew, I mean to the GCI task or the Gerrit changeset :) [16:19:32] ah yes [16:20:21] vandrew, Getting MediaWiki from Git is the minimum step to contribute meaningful patches that you can test in your system... [16:20:50] vandrew, otherwise you are submitting changes blindly, and reviewers get tired of applying pathces only to find obvious mistakes [16:21:42] vandrew, mistakes... that you would have seen yourself in a moment if you would have a test environment in place [16:22:41] qgil:yes, I thought that it was something else since the extension was not working on my system [16:23:17] qgil: now it should be easier for me to resolve the problem [16:26:16] good vandrew [16:27:24] (03CR) 10Matthias Mullie: [C: 032] "It should also use PostActionPermissions, but this'll do for now; I'll work on making PostActionPermissions work with header." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99323 (owner: 10EBernhardson) [16:27:34] (03Merged) 10jenkins-bot: Prevent blocked users from editing headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99323 (owner: 10EBernhardson) [16:28:05] qgil: also the initial bug was resolved, now I have to resolve the other bugs created by my commit [16:28:15] I hope that I'll finish it today [16:28:32] (03PS1) 10Matthias Mullie: Make header use *ActionPermissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99416 [16:28:34] (03CR) 10jenkins-bot: [V: 04-1] Make header use *ActionPermissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99416 (owner: 10Matthias Mullie) [16:29:49] (03CR) 10Matthias Mullie: [C: 032] Indent and pad reply form to look more like a post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99325 (owner: 10EBernhardson) [16:30:00] (03Merged) 10jenkins-bot: Indent and pad reply form to look more like a post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99325 (owner: 10EBernhardson) [16:31:51] (03PS2) 10Matthias Mullie: Make header use *ActionPermissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99416 [16:32:23] (03CR) 10Chad: Fix fetching ParserOutput (034 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 (owner: 10Chad) [16:32:48] (03PS2) 10AndyRussG: Style deletion warning messages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/99316 [16:33:26] (03PS4) 10Sharihareswara: MySQL db access for Wikimedia Labs [tools/missing-from-wikipedia] - 10https://gerrit.wikimedia.org/r/98962 [16:33:35] (03Abandoned) 10Chad: Deprecate calling 3 functions without a Title [core] - 10https://gerrit.wikimedia.org/r/95743 (owner: 10Chad) [16:35:38] vandrew, good, thank you [16:35:51] (03CR) 10Matthias Mullie: [C: 031] Ensure non-binary cache keys [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98993 (owner: 10EBernhardson) [16:37:55] (03PS5) 10Sharihareswara: MySQL db access for Wikimedia Labs + tests [tools/missing-from-wikipedia] - 10https://gerrit.wikimedia.org/r/98962 [16:37:56] (03CR) 10Ragesoss: [V: 031] "Works for me, on both popups and deletion page." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/99316 (owner: 10AndyRussG) [16:38:03] when does ori-l usually get here? [16:38:11] I've some questions about Vagrant [16:38:35] <^d> He usually shows up sometime late morning SF time. [16:38:51] hexmode: Are they super in-depth questions? [16:38:53] (03CR) 10Matthias Mullie: Refine paranoid SQL handling (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99034 (owner: 10Werdna) [16:39:20] marktraceur: probably not. I have a windows host and am running into some path issues [16:39:29] <^d> hexmode: Would you mind looking at a couple of random extension changes? They're pretty easy code cleanup type things, but don't really have an owner. [16:40:01] sure, ^d.. might not have time today, but I could tmw for sure [16:40:23] hexmode: I would volunteer, but a shower is calling my name - YuviPanda may be able to help [16:40:29] <^d> Thanks :) https://gerrit.wikimedia.org/r/#/q/owner:%22Chad+%253Cchadh%2540wikimedia.org%253E%22+is:open+mediawiki/extensions+-Cirrus,n,z - open extension changes by me, minus Cirrus [16:40:37] In general, !ask [16:40:42] marktraceur: https://gerrit.wikimedia.org/r/#/q/owner:%22Chad+%253Cchadh%2540wikimedia.org%253E%22+is:open+med\ [16:40:42] pii3: is it for me? [07:26] |iawiki/extensions+-Cirrus,n,z [16:40:47] oops [16:40:54] crazy windows + putty [16:41:05] Craaaaaazy putty [16:41:28] <^d> Silly putty? [16:41:59] We're rebranding to market in Mexico [16:48:43] hexmode: hi! would it be possible to backport https://gerrit.wikimedia.org/r/#/c/96703/ to the upcoming MW 1.22 release? it's a rather simple change that'd ease the lives of extension developers a bit and it certainly shouldn't make anything blow up ;-) [16:49:19] (03PS3) 10Nemo bis: Add {{PLURAL: support for youhavenewmessagesfromusers and youhavenewmessages [core] - 10https://gerrit.wikimedia.org/r/99000 (owner: 10MegaAlex) [16:49:28] (03CR) 10Matthias Mullie: "BoardHistoryStorage still implements WritableObjectStorage instead of new DbStorage, probably want to change that one too" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99035 (owner: 10Werdna) [16:50:06] (03CR) 10Cmcmahon: [C: 032] "+3" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/97849 (owner: 10Mayankmadan) [16:50:28] ashley: I really would like to put out 1.22.0 tomorrow, based on the RC Final. Still, you and saper have now asked for things to be added. Maybe we can do a point release soon. [16:51:16] ashley: that looks like a new feature more than a regression or something, not really in scope for a backport I suspect? [16:51:57] (03Merged) 10jenkins-bot: Prefer double-quoted strings in Ruby code [qa/browsertests] - 10https://gerrit.wikimedia.org/r/97849 (owner: 10Mayankmadan) [16:52:15] well, it'd be nice to write extensions using it and have said extensions to be compatible with the latest stable as opposed to either 1) using it and telling users, "sorry, use 1.23alpha" or 2) not using it and having to copy+paste a certain code snippet all over the place [16:52:26] "ease the lives of extension developers a bit" makes bells ring and sing "+1! +2! +3!" but the commit doesn't really help much [16:52:46] * hexmode goes to look at the commit [16:52:49] that's true of everything :) [16:54:22] marktraceur: here is what I get when running the extension on localhost //commons.wikimedia.org/ [16:55:40] (03CR) 10MarkAHershberger: "release notes, please. It would be nice to have a clear, concise explanation of why this is such a good thing. Maybe point to something " [core] - 10https://gerrit.wikimedia.org/r/96703 (owner: 10Jack Phoenix) [17:00:30] (03PS1) 1001tonythomas: Removed 'Enable simplified search bar (Vector skin only)' from MW user Preference [core] - 10https://gerrit.wikimedia.org/r/99422 [17:01:27] (03PS2) 1001tonythomas: Removed 'Enable simplified search bar (Vector skin only)' from MW user Preference [core] - 10https://gerrit.wikimedia.org/r/99422 [17:01:28] (03PS1) 10Yaron Koren: New version: 0.9.3 [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/99423 [17:02:17] (03PS4) 10Matthias Mullie: Collapse topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [17:02:32] (03CR) 10Yaron Koren: [C: 032 V: 032] New version: 0.9.3 [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/99423 (owner: 10Yaron Koren) [17:03:36] (03PS4) 10Nemo bis: Add PLURAL support to youhavenewmessages* [core] - 10https://gerrit.wikimedia.org/r/99000 (owner: 10MegaAlex) [17:04:26] (03CR) 10Matthias Mullie: [C: 04-1] "I just fixed a small issue that adding new topics would push down the collapser icons." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [17:05:38] (03CR) 1001tonythomas: "No further reviews?" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/93740 (owner: 1001tonythomas) [17:05:42] (03CR) 10Rtdwivedi: [C: 031] Use the default dimensions for body editing area [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99415 (owner: 10Tpt) [17:06:36] ca.wiki editors report pages being rendered incorrectly on a "random" basis, with content overlapping the left column http://s2.subirimagenes.com/imagen/previo/thump_8723940merda.png andre__ greg-g have you heard anything? [17:06:45] (sorry for the small screenshot, not mine) [17:06:45] marktraceur: if I understand correctly,I should check if the link is something like // I should add wgserver ? [17:07:27] qgil: have them report a bug please :) cc me on it. [17:07:34] greg-g, ok [17:07:39] (03CR) 10Rtdwivedi: [C: 031] Fix link to not existing thumb for mono page files [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99414 (owner: 10Tpt) [17:07:43] qgil: thanks! [17:13:31] (03CR) 10Rtdwivedi: [C: 031] Let contentHandler system add change of level tags in edit summaries [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99379 (owner: 10Tpt) [17:13:37] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99414 (owner: 10Tpt) [17:13:44] (03Merged) 10jenkins-bot: Fix link to not existing thumb for mono page files [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99414 (owner: 10Tpt) [17:14:13] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99415 (owner: 10Tpt) [17:14:17] vandrew: No, if the link is like "//commons.wikimedia.org" it's remote [17:14:19] (03Merged) 10jenkins-bot: Use the default dimensions for body editing area [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99415 (owner: 10Tpt) [17:14:27] You should never need to add anything to it [17:14:50] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99379 (owner: 10Tpt) [17:15:00] (03Merged) 10jenkins-bot: Let contentHandler system add change of level tags in edit summaries [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99379 (owner: 10Tpt) [17:16:04] (03CR) 10Nemo bis: [C: 04-1] "I changed the commit message because it didn't wrap well and wasn't clear to me." [core] - 10https://gerrit.wikimedia.org/r/99000 (owner: 10MegaAlex) [17:18:28] marktraceur: something like this finalLink = link.charAt(0) == '/' ? linkPrefix +link: link; ? [17:23:43] (03PS5) 10Andrew Bogott: Add the 'NovaResources' special page. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/96323 [17:24:03] (03PS1) 10Catrope: Update VisualEditor to wmf5 branch for cherry-pick [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99424 [17:24:04] (03PS1) 10Catrope: Update MultimediaViewer to wmf5 for cherry-pick [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99425 [17:24:25] (03CR) 10Catrope: [C: 032 V: 032] Update MultimediaViewer to wmf5 for cherry-pick [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99425 (owner: 10Catrope) [17:24:33] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf5 branch for cherry-pick [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99424 (owner: 10Catrope) [17:25:05] (03CR) 10Andrew Bogott: [C: 032] Add the 'NovaResources' special page. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/96323 (owner: 10Andrew Bogott) [17:25:12] (03CR) 10Andrew Bogott: [V: 032] Add the 'NovaResources' special page. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/96323 (owner: 10Andrew Bogott) [17:25:57] (03CR) 10Catrope: [C: 032 V: 032] Add OOJS v1.0.5 to core [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99311 (owner: 10Jforrester) [17:28:13] (03CR) 10Rtdwivedi: [C: 031] Load page module when the navigation is displayed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97924 (owner: 10Tpt) [17:29:53] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97924 (owner: 10Tpt) [17:30:00] marktraceur: when used on localhost I get http://localhost/index.php/... [17:30:05] is it good ? [17:32:21] (03CR) 10Aaron Schulz: [C: 032] Remove unused local variable [core] - 10https://gerrit.wikimedia.org/r/99056 (owner: 10Siebrand) [17:32:31] (03PS1) 10BryanDavis: Add support for HTTP_X_FORWARDED_PROTO [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99426 [17:32:34] marktraceur: Deployed oojs fix, thanks for working on that yseterday [17:33:01] Unfortunately the fixes were interdependent and I deployed them in the worst order possible, so for 1 minute I broke the site with duplicate registration exceptions [17:33:14] (03Merged) 10jenkins-bot: Load page module when the navigation is displayed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97924 (owner: 10Tpt) [17:33:21] (03CR) 10Nemo bis: "Pau, can you please check if those two lines of CSS achieve the stated scope i.e. highlighting? LQT doesn't follow any standard and its co" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/93740 (owner: 1001tonythomas) [17:35:33] (03PS2) 10Cmcmahon: Merging the readme files of other repositories with this one. [selenium] - 10https://gerrit.wikimedia.org/r/98577 (owner: 10Mayankmadan) [17:36:22] (03CR) 10Cmcmahon: [C: 032] "documentation" [selenium] - 10https://gerrit.wikimedia.org/r/98577 (owner: 10Mayankmadan) [17:37:00] (03Merged) 10jenkins-bot: Remove unused local variable [core] - 10https://gerrit.wikimedia.org/r/99056 (owner: 10Siebrand) [17:37:56] (03CR) 10Chad: [C: 031] Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [17:38:36] !seen matanya [17:38:36] Did you mean @seen matanya? [17:38:39] (03CR) 10Rtdwivedi: [C: 031] Remove an unneeded property [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97785 (owner: 10Tpt) [17:38:41] maybe [17:38:46] @seen matanya [17:38:46] Nikerabbit: Last time I saw matanya they were quitting the network with reason: Quit: Ex-Chat N/A at 12/5/2013 4:44:05 PM (54m41s ago) [17:39:57] (03CR) 10Siebrand: "Was merged with code maintenance and i18n issues." (035 comments) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/96323 (owner: 10Andrew Bogott) [17:40:40] (03PS2) 10BryanDavis: Add support for HTTP_X_FORWARDED_PROTO [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99426 [17:41:29] (03CR) 10Chad: [C: 032] Add support for HTTP_X_FORWARDED_PROTO [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99426 (owner: 10BryanDavis) [17:41:32] (03Merged) 10jenkins-bot: Add support for HTTP_X_FORWARDED_PROTO [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99426 (owner: 10BryanDavis) [17:41:39] (03PS1) 10Cscott: Set language- and script-specific fonts. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99427 [17:42:08] (03CR) 10Rtdwivedi: [C: 031] Remove unneeded use of global variables [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97294 (owner: 10Tpt) [17:42:14] (03CR) 10Andrew Bogott: "Thanks, Siebrand, I will catch up with your comments." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/96323 (owner: 10Andrew Bogott) [17:44:46] (03CR) 10Kaldari: "I didn't mean that we had given up on the idea of skins as a technology, I meant we've largely abandoned the idea of maintaining different" [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [17:44:52] (03PS2) 10Cscott: Set language- and script-specific fonts. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99427 [17:45:57] (03CR) 10Siebrand: [C: 04-1] Collapse topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [17:47:57] (03CR) 10Siebrand: "Feel free to add me as a reviewer. I try to keep an eye on all changes that add/remove/change messages, but apparently I missed this one. " [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/96323 (owner: 10Andrew Bogott) [17:49:00] ok, so I was kinda stupid with vagrant before. now I need to figure out how to tell it to use a proxy from inside this corp net [17:49:43] marktraceur: know anything about setting env vars like http_proxy for vagrant's box? [17:50:40] hexmode: i've never had to do it, but it should work [17:51:28] (03PS1) 10Tpt: Adds the capacity to zoom by mouse wheel [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99428 [17:51:53] (03CR) 10Rtdwivedi: [C: 031] Add @covers annotation [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97234 (owner: 10Tpt) [17:53:46] (03PS5) 10Cmcmahon: added test for block/hide/delete/suppress controls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99260 [17:53:59] (03CR) 10Cmcmahon: [C: 032] "merging for the daily Jenkins run" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99260 (owner: 10Cmcmahon) [17:55:07] (03Merged) 10jenkins-bot: added test for block/hide/delete/suppress controls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99260 (owner: 10Cmcmahon) [17:57:41] (03PS1) 10Siebrand: Make visibleMetadataField protected [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/99429 [17:57:59] Nemo_bis: I don't understand the part of your comment about the changed logic or https://gerrit.wikimedia.org/r/99000 [17:58:47] (03CR) 10Krinkle: [C: 031] Add 'mediawiki.ui.button' CSS module [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [17:58:48] awight: hey, was just looking for you [17:59:00] MegaAlex: you changed the conditions of that if else [17:59:08] ori-l: so, just 'http_proxy=xxx vagrant provision'?? [17:59:17] (03PS1) 1001tonythomas: Removed "Show table of contents (for pages with more than 3 headings)" from MW user preference [core] - 10https://gerrit.wikimedia.org/r/99430 [17:59:36] MegaAlex: I have no idea what you did and why, so if you explained that it would already be an improvement :) or you can wait for someone that understands what you're trying to do [17:59:56] hexmode: oh, i see what you're asking [18:00:01] hexmode: sec [18:00:22] Nemo_bis: are you an itwiki admin? can you add the if() i specified in the email in reply to Gerard? [18:00:33] no, no [18:00:46] Nemo_bis: k, thanks anyway [18:00:50] (03PS1) 10Anomie: Improve TestUser group handling [core] - 10https://gerrit.wikimedia.org/r/99432 [18:01:05] i told him it was an issue but he decided to go ahead anyway [18:01:19] gerard didn't do anything :) [18:02:45] hexmode: http://tmatilai.github.io/vagrant-proxyconf/ looks promising [18:02:52] I think the best place to discuss this is https://en.wikipedia.org/wiki/MediaWiki_talk:Wdsearch.js , there is already some discussion along those lines [18:04:34] (03PS2) 10Cmcmahon: Changing readme so it points to mediawiki-selenium [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98770 (owner: 10Mayankmadan) [18:04:44] (03CR) 10Cmcmahon: [C: 032] "documentation" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98770 (owner: 10Mayankmadan) [18:06:27] Nemo_bis: i would really like to see a code-review model for javascript in the mw namespace [18:06:41] Nemo_bis: might be useful to start doing some requirement-gathering [18:06:54] sounds like a red herring [18:07:27] (03Merged) 10jenkins-bot: Changing readme so it points to mediawiki-selenium [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98770 (owner: 10Mayankmadan) [18:07:52] (03PS1) 10Scimonster: Add group-user-css/js messages. [core] - 10https://gerrit.wikimedia.org/r/99434 [18:09:18] Nemo_bis: I see what you mean now.. I have messed it up.. thanks for the comment [18:09:19] Nemo_bis: herrings don't make sounds! [18:10:14] ori-l: prove it! [18:11:03] * Herring makes sounds [18:11:13] Nemo_bis: you were right! ^ [18:11:15] haha [18:11:18] :D [18:11:25] sometimes it happens [18:11:28] * ori-l takes off his hat. [18:11:59] :D [18:13:47] (03CR) 10Bartosz Dziewoński: [WIP] tablesorter: testcases for the parsers (032 comments) [core] - 10https://gerrit.wikimedia.org/r/99407 (owner: 10TheDJ) [18:13:59] (03CR) 10Anomie: [C: 032] "Brian Wolff's comment was addressed and the code looks good." [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97659 (owner: 10Aaron Schulz) [18:14:01] (03Merged) 10jenkins-bot: Added support for purging backlinks in the wiki farm [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97659 (owner: 10Aaron Schulz) [18:14:36] Woo. I was just thinking I should do that [18:15:17] (03PS2) 10Krinkle: Capitalization: 'jQuery', not 'jquery', and 'MediaWiki', not 'mediawiki' [core] - 10https://gerrit.wikimedia.org/r/99273 (owner: 10Ori.livneh) [18:16:47] (03CR) 10Krinkle: [C: 031] Capitalization: 'jQuery', not 'jquery', and 'MediaWiki', not 'mediawiki' [core] - 10https://gerrit.wikimedia.org/r/99273 (owner: 10Ori.livneh) [18:16:56] ori-l: proxyconf installed, tyvm [18:17:28] ori-l: sorry I missed your ping, what's on yr mind? [18:18:07] greg-g, andre__ a ca.wiki editor filed the bug I mentioned before: https://bugzilla.wikimedia.org/show_bug.cgi?id=58042 [18:18:16] hexmode: cool [18:18:33] awight: just wanted to apologize for dropping the vagrant patches, will try to review them asap [18:19:08] ori-l: oh no way, it's not an issue of any magnitude... I'm the only FR person using it, so there is no rush [18:19:38] (03CR) 10Rtdwivedi: [C: 031] Adds the capacity to zoom by mouse wheel [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99428 (owner: 10Tpt) [18:19:58] (03PS1) 10Njw: Simplify and rename the HTML & CSS [skins/erudite] - 10https://gerrit.wikimedia.org/r/99436 [18:21:33] qgil: thanks, commented [18:23:31] ori-l: One thing I wanted to chat about wrt vagrant-- do you think there's any value in making the development puppet work both under vagrant, and at the host-level on labs boxen? [18:23:38] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I'd rather not remove this particular option until we make the default behavior a little better (see https://gerrit.wikimedia.org/r/48252 " [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [18:23:49] YuviPanda: that's your cue [18:24:03] hmm, what? [18:24:04] oh [18:24:23] awight: https://wikitech.wikimedia.org/wiki/Labs-vagrant [18:24:31] bhwooohahaha! [18:24:35] (03PS3) 10Chad: Allow splitting of single namespaces into their own indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 [18:24:43] awight: :) [18:24:45] YuviPanda: many steps aheadda me, thanks! [18:24:50] :) [18:25:17] <^d> manybubbles: 97767 is cool now :D [18:25:43] sweet! I'm down a rabbit whole. I think I'll climb out in a bit and do reviews.... [18:26:05] <^d> Don't bother looking at the diff between patchsets, I basically rewrote the whole thing and it had to be rebased too. [18:26:14] <^d> So just look at the latest patch against head :) [18:26:35] (03CR) 10Bartosz Dziewoński: [C: 032] "Either way sounds fine to me, if this one sounds finer to you, let's do this. :)" [core] - 10https://gerrit.wikimedia.org/r/99273 (owner: 10Ori.livneh) [18:27:25] Can you please browse to https://ca.wikipedia.org/wiki/Viquip%C3%A8dia:La_taverna and say if you see something wrong? greg-g [18:27:27] marktraceur: when you have time let me know, I need to ask you if I am on the right track. [18:27:34] greg-g, I can reproduce now logged in with Firefox and Chrome [18:28:30] qgil: I see the issue there, yes [18:28:37] ok, good [18:29:33] * bawolff feels left out, I can't see the brokeness... [18:30:10] bawolff: https://gerrit.wikimedia.org/r/#/c/97993/ [18:30:29] (03CR) 10Brian Wolff: [C: 032] "looks good" [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [18:30:33] :) [18:31:00] Aaron|home: I actually had it open in another tab, and had the bitton all ready to click [18:31:17] <^d> manybubbles: Testing would've been good. Don't bother with that change yet :p [18:31:22] (03Merged) 10jenkins-bot: Capitalization: 'jQuery', not 'jquery', and 'MediaWiki', not 'mediawiki' [core] - 10https://gerrit.wikimedia.org/r/99273 (owner: 10Ori.livneh) [18:32:31] <^d> User error, it's fine. [18:32:40] <^d> Helps to start elasticsearch on my localhost :p [18:34:18] (03PS2) 10Reedy: Bump GettingStarted to import required messages [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99338 (owner: 10Mattflaschen) [18:34:25] (03CR) 10Reedy: [C: 032 V: 032] Bump GettingStarted to import required messages [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99338 (owner: 10Mattflaschen) [18:35:00] (03Merged) 10jenkins-bot: Optimized LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [18:35:02] (03CR) 10Greg Grossmeier: [C: 04-1] "Why are we deviating from the standard (both from the FSF and on MW Core) way of showing license info. It can't possibly be because of fil" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [18:35:05] (03PS1) 10PleaseStand: Remove 6 unused revdelete messages [core] - 10https://gerrit.wikimedia.org/r/99437 [18:35:33] greg-g: Interesting, I only got the issue when I was logged out [18:36:11] (03PS1) 10PleaseStand: Remove 9 unused search messages [core] - 10https://gerrit.wikimedia.org/r/99438 [18:36:35] (03PS1) 10PleaseStand: Remove unused messages 'resetprefs' and 'timezoneoffset' [core] - 10https://gerrit.wikimedia.org/r/99439 [18:36:51] (03PS1) 10PleaseStand: Remove unused messages 'protectedpagestext' and 'protectedtitlestext' [core] - 10https://gerrit.wikimedia.org/r/99440 [18:38:03] huh [18:38:26] PleaseStand: do you have some wonderful script to find those? or is it all hard manual work? :) [18:41:32] (03PS5) 10MegaAlex: Add PLURAL support to youhavenewmessages* [core] - 10https://gerrit.wikimedia.org/r/99000 [18:42:29] (03PS4) 10Chad: Allow splitting of single namespaces into their own indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 [18:43:23] MatmaRex: A script. It's a bit ugly right now (and by no means perfect), though I'll try to get it committed soon. [18:44:05] PleaseStand: awesome :D [18:44:34] we should totally have it ran by jenkins [18:44:53] (03CR) 10Krinkle: [C: 04-1] "Since you own the upstream, could you create a git tag for the version you submitted here? I'd prefer not to ship versions of upstream lib" [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [18:50:50] (03PS1) 10Katie Horn: Adding a special form definition for VN. This form will only allow USD in VN, until Globalcollect sorts out VND. [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/99442 [18:51:40] (03CR) 10Bsitu: [C: 032] Set a global cache time within Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 (owner: 10EBernhardson) [18:51:51] (03Merged) 10jenkins-bot: Set a global cache time within Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 (owner: 10EBernhardson) [18:51:58] (03CR) 10Siebrand: "Most excellent!" [core] - 10https://gerrit.wikimedia.org/r/99438 (owner: 10PleaseStand) [18:52:05] (03CR) 10Siebrand: [C: 032] Remove 9 unused search messages [core] - 10https://gerrit.wikimedia.org/r/99438 (owner: 10PleaseStand) [18:57:28] (03Merged) 10jenkins-bot: Remove 9 unused search messages [core] - 10https://gerrit.wikimedia.org/r/99438 (owner: 10PleaseStand) [18:59:44] (03PS1) 10EBernhardson: history i18n message needs wikitext parsing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99443 [19:00:41] (03CR) 10Bsitu: [C: 032] history i18n message needs wikitext parsing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99443 (owner: 10EBernhardson) [19:00:51] (03Merged) 10jenkins-bot: history i18n message needs wikitext parsing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99443 (owner: 10EBernhardson) [19:01:37] <^d> AaronSchulz: I was comparing refreshLinksJob to what I'm gonna do in CirrusSearchUpdater with the pcache. Do you think we should use canonical popts or the one of the last editor? [19:01:48] <^d> I know we talked about the latter in person, but you do the former in refreshLinks [19:05:07] <^d> Eh, I'll go with canonical. [19:05:13] <^d> Less chance for surprise :) [19:06:07] (03PS2) 10Chad: Fix fetching ParserOutput [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 [19:06:24] (03CR) 10Krinkle: "The library is imho in need of a few improvements first so that we have a more stable API that other modules can depend on in the future. " [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [19:09:57] (03PS1) 10Siebrand: Update some type hints in comments for Database classes [core] - 10https://gerrit.wikimedia.org/r/99445 [19:09:58] (03PS1) 10Siebrand: Update documentation for File::getMetadata() [core] - 10https://gerrit.wikimedia.org/r/99446 [19:12:47] (03CR) 10Siebrand: [C: 032] Remove unused messages 'protectedpagestext' and 'protectedtitlestext' [core] - 10https://gerrit.wikimedia.org/r/99440 (owner: 10PleaseStand) [19:15:55] (03CR) 10Siebrand: [C: 032] Remove unused messages 'resetprefs' and 'timezoneoffset' [core] - 10https://gerrit.wikimedia.org/r/99439 (owner: 10PleaseStand) [19:16:49] marktraceur: I have resolved the problem you have reported in your comment with yum provides "*/libjpeg.so*" , here is the final link, the one I will output, it works fine on my machine too, let me know if I what you think and if I should do the commit [19:16:56] (03Merged) 10jenkins-bot: Remove unused messages 'protectedpagestext' and 'protectedtitlestext' [core] - 10https://gerrit.wikimedia.org/r/99440 (owner: 10PleaseStand) [19:17:12] ...what [19:17:26] oh [19:17:27] wait [19:17:29] wrong pase [19:17:31] Hah [19:17:40] finalLink = link.charAt(0) == '/' ? linkPrefix +link: link; [19:17:54] OK no [19:18:00] vandrew: I gave you a regex to use for a reason [19:18:13] You need to use the regex or you'll get false positives [19:19:08] (03Merged) 10jenkins-bot: Remove unused messages 'resetprefs' and 'timezoneoffset' [core] - 10https://gerrit.wikimedia.org/r/99439 (owner: 10PleaseStand) [19:26:55] marktraceur: wait...what regex ? should I use link.match('//') ? or something like var re = new RegExp("//");? Whe can I see the regex you gave me ? [19:27:15] I forget, but it's not complicated [19:27:42] vandrew: /^\/[^\/]/ will match any relative links, to which you need to prepend wgServer [19:27:52] (03PS1) 10Siebrand: Update documentation for media related classes [core] - 10https://gerrit.wikimedia.org/r/99450 [19:32:08] (03CR) 10Bartosz Dziewoński: Site logo loaded using ResourceLoaderSiteModule instead of inline (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [19:33:01] (03PS1) 10Siebrand: Remove unneeded uses of else {} in media classes [core] - 10https://gerrit.wikimedia.org/r/99451 [19:35:01] (03CR) 10Brian Wolff: [C: 04-1] "I think it should be up to the maintainers of each extension how they want to display the license on the code." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [19:35:06] (03PS1) 10Siebrand: Simplify ternary construction [core] - 10https://gerrit.wikimedia.org/r/99452 [19:36:27] (03CR) 10MarkTraceur: "In fairness, bawolff, the VE team will be maintaining this extension in the near term." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [19:37:48] marktraceur: oh ok, I'll go back to not caring :) [19:38:07] Bahaha [19:38:32] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Comment inline. Also, per Krinkle, this depends on https://gerrit.wikimedia.org/r/#/c/95463/ (I'll mark the GCI task as completed regardle" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [19:39:36] (03PS1) 10Siebrand: Remove function call from for loop test part in GIFMetadataExtractor::readGCT() [core] - 10https://gerrit.wikimedia.org/r/99454 [19:40:04] marktraceur: here : patttern = new RegExp("/^\/[^\/]/"), finalLink = patttern.test(link) ? linkPrefix +link: link, [19:40:24] (03CR) 10Bartosz Dziewoński: [C: 032] Simplify ternary construction [core] - 10https://gerrit.wikimedia.org/r/99452 (owner: 10Siebrand) [19:41:02] No no no [19:41:10] vandrew: Regexes are a native type in JavaScript [19:41:11] (03PS1) 10Siebrand: Make visibleMetadataField protected [core] - 10https://gerrit.wikimedia.org/r/99455 [19:41:15] (03CR) 10Bartosz Dziewoński: [C: 032] Remove function call from for loop test part in GIFMetadataExtractor::readGCT() [core] - 10https://gerrit.wikimedia.org/r/99454 (owner: 10Siebrand) [19:41:54] vandrew: pattern = /^\/[^\/]/, finalLink = pattern.test( link ) ? linkPrefix + link : link, [19:42:34] oh, nice, I'll test it now [19:42:50] hey csteipp, just wanted to check-in and see how we're doing on the overall security review. thanks for approving all of those outstanding commits. i see bd808 was able to merge them early this morning - thanks bd808. [19:42:52] csteipp, there's one more commit i made to gerrit based on out irc chat with AaronSchulz earlier this morning, https://gerrit.wikimedia.org/r/#/c/99387/. i'm hoping this will close out the security review unless you find something else. if we can get this merged today or tomorrow we'll be on target for a beta cluster release on monday. please let me know if you have any questions. [19:44:06] (03CR) 10Gergő Tisza: "Also related to bug 57297. As mentioned there, a function to check for support and another one to check for current mode would be nice." [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [19:44:24] dan-nl: Yeah, I'll be getting back on it today. Just finished flow. I think with the changes you made, there shouldn't be too many more issues [19:44:52] csteipp: cool, thanks. i really appreciate your quick work on it [19:45:31] (03CR) 10Bartosz Dziewoński: "I'd suggest explicitly mentioning "registered users" instead of just "users" in messages. Looks good otherwise, but I did not test." [core] - 10https://gerrit.wikimedia.org/r/99434 (owner: 10Scimonster) [19:46:47] DarTar: When you have a sec, https://meta.wikimedia.org/wiki/Schema:MediaViewerPerf could use a second pair of eyes [19:47:05] marktraceur: looking [19:47:09] Thanks [19:48:59] marktraceur: lgtm, these are client-side times relative to some initial event? [19:49:05] Yeah [19:49:20] DarTar: They'll be client-side durations of actions, really [19:49:21] and that event is...? [19:49:49] "The image load took n milliseconds", "The image resize took n milliseconds", "Fetching the metadata took n milliseconds" etc. [19:50:00] We're trying to get a picture of how long loading images is taking [19:50:01] since the click [19:50:04] ? [19:50:27] (03PS2) 10Scimonster: Add group-user-css/js messages. [core] - 10https://gerrit.wikimedia.org/r/99434 [19:50:31] (03CR) 10Brian Wolff: [C: 032] Update documentation for File::getMetadata() [core] - 10https://gerrit.wikimedia.org/r/99446 (owner: 10Siebrand) [19:51:05] bawolff: It's a pretty long stream of changes. Would be great if you could start at the beginning :) [19:51:20] also, does it matter what browser/OS users are using? [19:51:21] bawolff: thanks in advance for any reviews :) [19:51:29] marktraceur ^ [19:51:29] siebrand: Yeah, I realized that when after I hit submit gerrit didn't do anything [19:51:41] DarTar: It might be good to have that [19:52:04] ok maybe a UA field is in order then [19:52:06] DarTar: I'll do timing in a sane way, e.g. "we're making the request, start the clock; we've loaded the image, stop the clock" [19:52:24] bawolff: It starts of with non-code changes at https://gerrit.wikimedia.org/r/#/c/99344/1 [19:52:59] marktraceur: you may want to ask ori-l to review the timing log specs [19:53:05] 'kay [19:53:13] re: UA, I keep pointing people to this: [19:53:38] https://bugzilla.wikimedia.org/show_bug.cgi?id=52295 [19:53:50] siebrand: thanks, I'll start there [19:53:53] Heh, that would be nice [19:54:10] in one week, I've heard of 3 different teams asking for this data [19:55:12] Hah [19:55:40] DarTar: What's our forecast for a dashboard type thing for MMV or BetaFeatures or something? :) [19:55:41] spagewmf, marktraceur, jdlrobson: could we pool some resources to solve this once and for all? https://bugzilla.wikimedia.org/show_bug.cgi?id=52295 [19:55:57] (03CR) 10Bartosz Dziewoński: [C: 032] Remove PHP4 style constructor [core] - 10https://gerrit.wikimedia.org/r/99354 (owner: 10Siebrand) [19:56:01] marktraceur: tested and here is what I get now: //commons.wikimedia.org/wiki/... and http://localhost/index.php/File:... [19:56:19] That's good [19:56:31] vandrew: Push it and let's see what I get [19:56:36] Maybe I'm configured wrong or something [19:56:48] marktraceur: it got overridden by other priorities, I'm afraid. Is the MMV data coming through as expected? [19:56:49] ok [19:56:58] I have very little idea [19:57:09] I keep meaning to log in to the stats servers but failing [19:57:20] Not because of errors, just because of lazy [19:58:39] (03CR) 10Tholam: Site logo loaded using ResourceLoaderSiteModule instead of inline (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [19:59:34] marktraceur: done [19:59:46] (03CR) 10Bartosz Dziewoński: "Is there no better way to do this? With less duplication? :(" [core] - 10https://gerrit.wikimedia.org/r/99336 (owner: 10Siebrand) [20:00:04] marktraceur: I have to rebase my changes, how was that command ? [20:00:06] marktraceur: https://office.wikimedia.org/wiki/Editor_Engagement_Experiments/Data_analysis#Event_logging has some useful advice for really basic EL stats analysis from 9 months ago [20:00:39] (03CR) 10Tholam: Site logo loaded using ResourceLoaderSiteModule instead of inline (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [20:00:56] git rebase origin/master yes ? [20:01:13] DarTar can we just log the straight UA (as a few extensions have done), and later bucket into the top 100? [20:01:24] vandrew: git fetch --all && git rebase origin/master [20:01:26] (03CR) 10Siebrand: "There would be if ObjectType[] documentation were allowed. Then foreignRepos could be documented as:" [core] - 10https://gerrit.wikimedia.org/r/99336 (owner: 10Siebrand) [20:01:28] Or something [20:03:11] spagewmf: I'd rather wait until we have a clean solution, we're discussing with Legal a data retention proposal for private data which adds some provisions on EL data, the less data we collect the easier its going to be to use it without having to prune it/sanitize it later [20:04:19] marktraceur: I added the multimedia use case to bz:52295 [20:04:58] I'd really need to have this for SSAccountCreations to, to answer some questions James_F brought up [20:05:12] (03CR) 10Dan-nl: "siebrand, you can contact david haskiya regarding the copy in the i18n file. i'll email the two of you separately to make sure you have ea" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99387 (owner: 10Dan-nl) [20:05:27] dan-nl: Oh, great. [20:07:36] marktraceur: ok this time it worked [20:10:06] (03CR) 10Manybubbles: Fix fetching ParserOutput (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 (owner: 10Chad) [20:11:36] (03CR) 10Manybubbles: [C: 032] Clean up where conditions in sql query [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99277 (owner: 10Chad) [20:11:41] (03Merged) 10jenkins-bot: Clean up where conditions in sql query [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99277 (owner: 10Chad) [20:16:10] (03CR) 10Tpt: "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97785 (owner: 10Tpt) [20:16:15] (03CR) 10Tpt: [C: 032] Remove an unneeded property [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97785 (owner: 10Tpt) [20:16:23] (03Merged) 10jenkins-bot: Remove an unneeded property [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97785 (owner: 10Tpt) [20:17:05] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97234 (owner: 10Tpt) [20:17:18] (03Merged) 10jenkins-bot: Add @covers annotation [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97234 (owner: 10Tpt) [20:20:53] DarTar OK well I have no idea how to do a rolling re-bucket of top 100 browsers + other, seems you'd have to have a separate secret table counting every distinct UA in last 24 hours and then use it to get new top 100 for the official stats. sounds like a computer science problem. [20:20:54] (03PS1) 10Cscott: Catch silent errors. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99460 [20:20:56] (03PS1) 10Cscott: Slightly improve status reporting. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99461 [20:21:03] (03CR) 10Brian Wolff: [C: 04-1] "-1 for my comment on XMPInfo.php (The other comment is more an aside, I don't overly care that much one way or another)." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/99344 (owner: 10Siebrand) [20:22:22] spagewmf: what is that for? do we really expect the UA share to change every 24h? [20:23:29] spagewmf: if it's bz:52295 I believe someone already wrote code to do that [20:23:40] it's in the ticket history, I believe [20:24:16] (03CR) 10Manybubbles: [C: 04-1] "Comments include a minor documentation tweak, a small redesign that I think will make things much cleaner, and random musing about deletes" (038 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [20:26:31] (03PS2) 10Foxtrott: introduce XML structure description; add NavHead [skins/chameleon] - 10https://gerrit.wikimedia.org/r/99261 [20:41:24] (03CR) 10Esanders: "@Greg as Krinkle said it's simply a case of reducing unnecessary duplication. As an extreme having a license header on each line would cle" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [20:43:03] (03CR) 10Krinkle: [C: 031] Standardise and minimise licence headers [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [20:45:28] marktraceur: what do you think ? should I mark the task as complete now ? [20:47:13] Sigh [20:47:15] I haven't tested [20:47:18] One sec, vandrew [20:47:23] take your time [20:50:37] (03CR) 10Nemo bis: [C: 031] Add PLURAL support to youhavenewmessages* [core] - 10https://gerrit.wikimedia.org/r/99000 (owner: 10MegaAlex) [20:52:24] vandrew: OK, I'll actually merge this now. :) [20:52:56] (03CR) 10Siebrand: "Yes, please merge. I've got a stashed patch locally, but it doesn't want to submit. I'll definitely follow up." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/99344 (owner: 10Siebrand) [20:53:16] (03PS1) 10Andrew Bogott: Fix zero/single/plural cases for section headers. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/99467 [20:53:48] cool [20:53:56] *now* you can mark it done. [20:54:07] (03CR) 10Brian Wolff: [C: 032] "Sounds good." [core] - 10https://gerrit.wikimedia.org/r/99344 (owner: 10Siebrand) [20:54:08] (03Merged) 10jenkins-bot: Remove PHP4 style constructor [core] - 10https://gerrit.wikimedia.org/r/99354 (owner: 10Siebrand) [20:54:16] thank you very much for yyour patience and help [20:54:45] vandrew: Thanks for sticking with it :) [20:56:25] ori-l, have you seen Profiler has RAII now (ProfilerSection)? [20:56:25] (03PS1) 10Siebrand: Some more formatting fixes for media classes [core] - 10https://gerrit.wikimedia.org/r/99468 [20:56:38] (03CR) 10Siebrand: "https://gerrit.wikimedia.org/r/99468" [core] - 10https://gerrit.wikimedia.org/r/99344 (owner: 10Siebrand) [20:56:47] superm401: no! cool! [20:56:59] Yeah! I thought it was really sweet the first time I saw it. [20:57:37] how do i use it? [20:58:04] $section = new ProfileSection( __METHOD__ ); [20:58:07] There's examples strewn about FileBackend [20:58:07] at the top of the method. [21:01:07] (03CR) 10Foxtrott: [C: 032 V: 032] introduce XML structure description; add NavHead [skins/chameleon] - 10https://gerrit.wikimedia.org/r/99261 (owner: 10Foxtrott) [21:01:59] (03CR) 10Siebrand: [C: 04-1] "Nice. Two inline comments. The message documentation must be updated." (032 comments) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/99467 (owner: 10Andrew Bogott) [21:03:05] (03CR) 10MarkTraceur: "> @Greg as Krinkle said it's simply a case of reducing unnecessary duplication." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [21:03:07] (03CR) 10Legoktm: Add group-user-css/js messages. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99434 (owner: 10Scimonster) [21:05:31] (03CR) 10Krinkle: [C: 04-1] "Per Legoktm, use a plain comparison, no longer need an in_array call." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/99434 (owner: 10Scimonster) [21:06:25] (03CR) 10Krinkle: Add group-user-css/js messages. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99434 (owner: 10Scimonster) [21:08:07] (03CR) 10Shirayuki: [C: 04-1] "$2 should not be null for backward compatibility." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [21:08:26] (03CR) 10Esanders: "> Minor inconvenience is *not* a compelling enough reason to ignore the advice of the license authours *and* deviate from the status quo." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [21:12:29] (03PS2) 10Andrew Bogott: Fix zero/single/plural cases for section headers. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/99467 [21:12:30] (03PS1) 10Andrew Bogott: Declare visibility for a few class members. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/99472 [21:14:09] (03PS3) 10Andrew Bogott: Fix zero/single/plural cases for section headers. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/99467 [21:15:32] (03CR) 10Siebrand: [C: 032] Declare visibility for a few class members. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/99472 (owner: 10Andrew Bogott) [21:16:14] (03Merged) 10jenkins-bot: Declare visibility for a few class members. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/99472 (owner: 10Andrew Bogott) [21:16:36] (03PS3) 10Krinkle: Added CSS to properly color links [core] - 10https://gerrit.wikimedia.org/r/70589 (owner: 10Nischayn22) [21:16:37] (03CR) 10Siebrand: [C: 032] Fix zero/single/plural cases for section headers. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/99467 (owner: 10Andrew Bogott) [21:18:50] (03Merged) 10jenkins-bot: Fix zero/single/plural cases for section headers. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/99467 (owner: 10Andrew Bogott) [21:18:51] (03CR) 10Krinkle: "jQuery UI has to override the generic link colors in buttons because it uses inside a
that is made to look like a button, but th" [core] - 10https://gerrit.wikimedia.org/r/70589 (owner: 10Nischayn22) [21:21:37] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/99506 (owner: 10L10n-bot) [21:23:15] (03CR) 10Cscott: [C: 032] Set language- and script-specific fonts. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99427 (owner: 10Cscott) [21:23:31] (03CR) 10Cscott: [C: 032] Catch silent errors. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99460 (owner: 10Cscott) [21:23:39] (03CR) 10Cscott: [C: 032] Slightly improve status reporting. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99461 (owner: 10Cscott) [21:23:44] (03PS4) 10Krinkle: getHumanTimestamp() now also returns time for timestamps in same year [core] - 10https://gerrit.wikimedia.org/r/70763 (owner: 10Se4598) [21:23:58] (03PS1) 10Tpt: Add validation of the content model edited by EditPage [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99518 [21:24:02] (03PS5) 10Krinkle: Include clock time for same-year timestamps in getHumanTimestamp() [core] - 10https://gerrit.wikimedia.org/r/70763 (owner: 10Se4598) [21:24:34] (03PS4) 10Krinkle: (bug 46766) Tests to exercise a language bug in DerivativeContext [core] - 10https://gerrit.wikimedia.org/r/57018 (owner: 10Adamw) [21:24:53] (03PS6) 10Krinkle: Add tests to exercise a language bug in DerivativeContext [core] - 10https://gerrit.wikimedia.org/r/57018 (owner: 10Adamw) [21:25:48] (03PS2) 10Tpt: Add validation of the content model edited by EditPage [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99518 [21:26:16] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/99506 (owner: 10L10n-bot) [21:27:36] (03PS1) 10Tpt: Add validation of the content model edited by EditPage [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99519 [21:27:48] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/99506 (owner: 10L10n-bot) [21:27:52] (03PS1) 10EBernhardson: Crib some css from VE for empty external links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99520 [21:28:18] (03PS2) 10EBernhardson: Crib some css from VE for empty external links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99520 [21:28:58] (03Merged) 10jenkins-bot: Set language- and script-specific fonts. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99427 (owner: 10Cscott) [21:28:59] (03CR) 10GWicke: [C: 04-2] Stop prepending newlines to templates starting with *#;: (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99133 (owner: 10Bartosz Dziewoński) [21:29:13] (03CR) 10MarkTraceur: "That's wonderful for you. But things that will also not happen in BetaFeatures include MIT licensing and icons not conforming to general d" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [21:29:50] (03Merged) 10jenkins-bot: Catch silent errors. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99460 (owner: 10Cscott) [21:30:03] (03CR) 10jenkins-bot: [V: 04-1] Include clock time for same-year timestamps in getHumanTimestamp() [core] - 10https://gerrit.wikimedia.org/r/70763 (owner: 10Se4598) [21:30:12] (03Merged) 10jenkins-bot: Slightly improve status reporting. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99461 (owner: 10Cscott) [21:31:35] (03PS1) 10Tpt: Backport bug fixed in ProofreadPage [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99522 [21:31:45] (03CR) 10jenkins-bot: [V: 04-1] Include clock time for same-year timestamps in getHumanTimestamp() [core] - 10https://gerrit.wikimedia.org/r/70763 (owner: 10Se4598) [21:34:13] (03PS1) 10Jdlrobson: WIP: Move all VectorBeta RL modules from core. [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99523 [21:34:26] (03PS2) 10Tpt: Backport bug fixed in ProofreadPage [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99522 [21:34:28] (03CR) 10Jdlrobson: [C: 04-2] "Doesn't quite work." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99523 (owner: 10Jdlrobson) [21:34:30] (03PS1) 10Jdlrobson: WIP: Move VectorBeta modules to VectorBeta extension. [core] - 10https://gerrit.wikimedia.org/r/99524 [21:34:42] (03CR) 10jenkins-bot: [V: 04-1] Add tests to exercise a language bug in DerivativeContext [core] - 10https://gerrit.wikimedia.org/r/57018 (owner: 10Adamw) [21:34:48] (03CR) 10Jdlrobson: [C: 04-2] "Doesn't quite work. Need to think how LESS can help us retain image urls." [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson) [21:35:30] (03CR) 10jenkins-bot: [V: 04-1] Add validation of the content model edited by EditPage [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99518 (owner: 10Tpt) [21:38:47] (03CR) 10Tpt: [C: 032] "Minor change" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97837 (owner: 10Tpt) [21:40:36] (03CR) 10Krinkle: "I think the problem is that ResourceLoader does take them into account (as it should) and therefor breaks the extension because it cannot " [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson) [21:40:36] (03PS1) 10Aaron Schulz: Added a TIME_ONLY option to FileRepo::findFiles to use less RAM [core] - 10https://gerrit.wikimedia.org/r/99526 [21:41:28] (03PS1) 10Aaron Schulz: Use FileRepo::findFiles() to avoid a bunch of queries [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/99527 [21:41:36] (03CR) 10Krinkle: "(btw, this also enforces that modules are standalone and not rely on parts of other extensions or core, e.g. module names are a public API" [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson) [21:41:40] (03CR) 10Aaron Schulz: "Depends on https://gerrit.wikimedia.org/r/#/c/99526/" [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/99527 (owner: 10Aaron Schulz) [21:41:58] jdlrobson: your map of wikipedia is awesome [21:44:26] ori-l: if/what can we do to invalidate local storage cache for users? [21:44:43] e.g. when deploying new code [21:44:49] it'll update automatically [21:44:57] (03CR) 10Krinkle: "Though I rejected part of the use case mentioned above, both that use case and the others that I did support are already possible by using" [core] - 10https://gerrit.wikimedia.org/r/69471 (owner: 10Daniel Kinzler) [21:45:07] really? [21:45:08] when? [21:46:03] as soon as the version changes in the startup module [21:46:09] (03Abandoned) 10Krinkle: Register ResourceLoaderModule via callback. [core] - 10https://gerrit.wikimedia.org/r/69471 (owner: 10Daniel Kinzler) [21:46:35] hmmmm [21:46:46] o hi ori-l [21:46:47] (03CR) 10Aaron Schulz: [C: 032] Removed "Disable search suggestions" from Mediawiki Preference [core] - 10https://gerrit.wikimedia.org/r/99163 (owner: 1001tonythomas) [21:46:51] (03PS3) 10Tpt: Add validation of the content model edited by EditPage [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99518 [21:46:54] ori-l: https://www.mediawiki.org/wiki/Special:Watchlist?uselang=en is missing messages [21:47:00] i had to manually clear my local storage for test.wikidata [21:47:07] that fixed the javascript [21:47:07] (three in english, apparently only one in other languages) [21:47:18] ori-l: can you unbreak that? [21:47:18] now i can't reproduce the issue, obviously [21:47:22] aude: The same way things update without localStorage, we've been statically caching module responses server-side for a while now. This is essentially just an extension of that. [21:47:46] Of course bugs can occur, yikes. [21:48:27] (03Merged) 10jenkins-bot: Use new validation system of the content model in EditPage [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97837 (owner: 10Tpt) [21:49:37] marktraceur, "Bug 56477 - Pluginize fullscreen handling" was supposed to be easy. The GCI student has been requested to create an upstream library in GitHub, provide proper versioning for downstreaming, and now he is getting requests for improvements in the library, left by Krinkle at https://github.com/theopolisme/jquery-fullscreen/commit/050b6bfea7d12953faeabbb5883d431fd9d5efe9 [21:49:57] Hm [21:50:04] qgil: It was supposed to be easier than that I think [21:50:07] marktraceur, Krinkle All this is great! But do you think the student has done enough to complete the task? [21:50:16] I'd vote yes, he did a great job [21:50:17] (03PS1) 10Cscott: Fix image download status reporting. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99528 [21:50:18] (03PS1) 10Cscott: Allow overriding maximum image resolution on the command line. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99529 [21:50:19] (03PS1) 10Cscott: Add a multiwiki test case; keep image sizes small during tests. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99530 [21:50:33] I would have been happy to have seen the plugin in the MMV repo [21:50:35] TypeError: Cannot read property 'wikiUrlencode' of undefined [21:50:35] TypeError [21:50:35] But great stuff [21:50:36] qgil: I wasn't aware this was a GCI student btw [21:50:50] (03PS1) 10EBernhardson: Page title does not display corectly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99531 [21:51:01] Was making the library maintained primary on his github account on purpose? [21:51:01] (03CR) 10Cscott: [C: 032] Fix image download status reporting. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99528 (owner: 10Cscott) [21:51:05] marktraceur, Krinkle so far he has been performing very well in other GCI tasks. I believe that he will still take your feedback and make improvements, but by closing the task we free them to take another one. [21:51:10] (03CR) 10Cscott: [C: 032] Allow overriding maximum image resolution on the command line. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99529 (owner: 10Cscott) [21:51:10] we should totally get theo to be a mentor next year. :P [21:51:18] (03CR) 10Cscott: [C: 032] Add a multiwiki test case; keep image sizes small during tests. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99530 (owner: 10Cscott) [21:51:20] Krinkle, your comment shows that he is good GCI student! :) [21:51:35] qgil: Sorry, but that's not what I meant. [21:51:54] Krinkle, sorry me, then. :) [21:52:12] He's not bad, not at all. But I think I've seen too little at this point to judge him. [21:52:26] s/judge/assess/ [21:52:31] (03CR) 10Aaron Schulz: [C: 032] Define 'MW_UPDATER' when running update.php [core] - 10https://gerrit.wikimedia.org/r/96676 (owner: 10Legoktm) [21:53:02] Ok, in any case I will proceed closing this task, asking him to please continue with his new duties as upstream maintainer. :) [21:53:05] he apparently did more than just what I happen to come accross, so ignore me :) [21:53:59] (03CR) 10Parent5446: [C: 04-1] "I'm really not a big fan of having the return value type be altered based on a parameter. It makes static analysis go crazy." [core] - 10https://gerrit.wikimedia.org/r/99526 (owner: 10Aaron Schulz) [21:54:40] dan-nl: do you have an example xml upload I can play with? [21:54:56] sure, will email one now [21:55:02] I can't tell if the errors I'm getting are my xml or my dev install... thanks! [21:55:24] (03Merged) 10jenkins-bot: Removed "Disable search suggestions" from Mediawiki Preference [core] - 10https://gerrit.wikimedia.org/r/99163 (owner: 1001tonythomas) [21:55:58] marktraceur, about the plugin being in GitHub and not WM servers, I believe he just followed the advice of someone in the bug report or a Gerrit comment -- can't remember. [21:56:09] MatmaRex: i can't deploy or sync now sorry [21:56:31] (03CR) 10Chad: "All good comments, will amend again. Responded inline re: deletes." (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [21:56:47] Huh [21:57:30] csteipp: just sent a few over [21:57:33] thanks legoktm :) [21:57:56] (03CR) 10Parent5446: [C: 032] Break long lines in media related classes [core] - 10https://gerrit.wikimedia.org/r/99355 (owner: 10Siebrand) [21:58:33] (03CR) 10Parent5446: [C: 032] Remove function calls from for loop test part in media classes [core] - 10https://gerrit.wikimedia.org/r/99356 (owner: 10Siebrand) [21:58:49] Krinkle: can you remind me why we disqualified the site module from localstorage? [21:59:16] ori-l: Because it is already loaded from the html directly [21:59:16] (03CR) 10Parent5446: [C: 032] Ignore CodeSniffer warning where unavoidable in media classes [core] - 10https://gerrit.wikimedia.org/r/99357 (owner: 10Siebrand) [21:59:21] it isn't in the regular load queue [21:59:33] (03Merged) 10jenkins-bot: Define 'MW_UPDATER' when running update.php [core] - 10https://gerrit.wikimedia.org/r/96676 (owner: 10Legoktm) [21:59:37] ah, right [21:59:38] although I don't recall saying that before [21:59:44] DarTar, I spaced out during metrics, did you have a solution for UA that I should wait for? [21:59:46] ori-l: we did talk about excluding the user modules [21:59:51] Er, after metrics? [22:00:07] csteipp: if none of those work, let me know what errors you're getting [22:00:18] That sounds more right [22:00:19] (03Merged) 10jenkins-bot: Fix image download status reporting. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99528 (owner: 10Cscott) [22:00:50] (03PS5) 10Bsitu: Collapse topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [22:01:08] (03CR) 10Parent5446: [C: 032] Declare visibility for class properties of PNGMetadataExtractor [core] - 10https://gerrit.wikimedia.org/r/99376 (owner: 10Siebrand) [22:01:11] (03CR) 10EBernhardson: [C: 032] Refine paranoid SQL handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99034 (owner: 10Werdna) [22:01:25] (03Merged) 10jenkins-bot: Allow overriding maximum image resolution on the command line. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99529 (owner: 10Cscott) [22:01:47] (03CR) 10Bsitu: [C: 04-1] "Addressed the feedback in i18n and css, still need to resolve the view in 'load more'" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [22:02:03] Krinkle: it looks like top-loading modules never make it to localstorage [22:02:31] on enwiki, even with a full prime localstorage, i still end up fetching https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131205T024957Z [22:02:47] marktraceur: not really, just hoping that someone could take up that ticket and avoid solving it on an ad-hoc basis for each team [22:03:01] Krinkle: i think it's because top modules just cal load() directly rather than work(), not sure [22:03:03] Ah. [22:03:30] DarTar: Sadly I'll join the I'd Love To But club on this one for now [22:03:47] (03Merged) 10jenkins-bot: Add a multiwiki test case; keep image sizes small during tests. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99530 (owner: 10Cscott) [22:03:47] But I'll check with Fabrice first, I guess [22:03:53] He may have a thought about it [22:05:06] (03Merged) 10jenkins-bot: Break long lines in media related classes [core] - 10https://gerrit.wikimedia.org/r/99355 (owner: 10Siebrand) [22:05:11] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [22:06:12] (03CR) 10Parent5446: [C: 032] Do not access MediaTransformOutput->url directly in Linker [core] - 10https://gerrit.wikimedia.org/r/99377 (owner: 10Siebrand) [22:06:36] (03Merged) 10jenkins-bot: Remove function calls from for loop test part in media classes [core] - 10https://gerrit.wikimedia.org/r/99356 (owner: 10Siebrand) [22:07:10] (03CR) 10Parent5446: [C: 031] "Are there any extensions that use these? I don't have all extensions cloned at the moment so I can't check." [core] - 10https://gerrit.wikimedia.org/r/99383 (owner: 10Siebrand) [22:07:53] (03CR) 10Siebrand: "Used by extensions, but none access the class properties." [core] - 10https://gerrit.wikimedia.org/r/99383 (owner: 10Siebrand) [22:07:56] (03CR) 10Parent5446: [C: 031] "Are there any extensions that use these? I don't have all extensions cloned at the moment so I can't check." [core] - 10https://gerrit.wikimedia.org/r/99384 (owner: 10Siebrand) [22:08:13] (03Merged) 10jenkins-bot: Ignore CodeSniffer warning where unavoidable in media classes [core] - 10https://gerrit.wikimedia.org/r/99357 (owner: 10Siebrand) [22:08:16] (03CR) 10Parent5446: [C: 032] Declare visibility on class properties of GIFMetadataExtractor [core] - 10https://gerrit.wikimedia.org/r/99390 (owner: 10Siebrand) [22:08:17] (03CR) 10Siebrand: "Used by extensions, but none access the class properties." [core] - 10https://gerrit.wikimedia.org/r/99384 (owner: 10Siebrand) [22:08:22] ori-l: Hm.. not sure I follow. We never call work() directly. [22:08:43] (03CR) 10Parent5446: [C: 031] "Are there any extensions that use these? I don't have all extensions cloned at the moment so I can't check." [core] - 10https://gerrit.wikimedia.org/r/99397 (owner: 10Siebrand) [22:09:22] ori-l: https://bits.wikimedia.org/test.wikidata.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131205T204540Z [22:09:36] that's what deosn't work [22:10:05] (03Merged) 10jenkins-bot: Refine paranoid SQL handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99034 (owner: 10Werdna) [22:10:10] (03CR) 10Parent5446: [C: 04-1] Update some type hints in comments for Database classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99445 (owner: 10Siebrand) [22:10:25] (03CR) 10Siebrand: "I check all the extensions I have local clones of. ~610 at the moment. I'll update the missing ones soonish, but confident I haven't misse" [core] - 10https://gerrit.wikimedia.org/r/99397 (owner: 10Siebrand) [22:10:55] then i get an error with wikibase [22:11:02] and no js [22:11:06] (03CR) 10Siebrand: Update some type hints in comments for Database classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99445 (owner: 10Siebrand) [22:11:28] (03PS2) 10EBernhardson: Abstract out DbStorage superclass from BasicDbStorage and RevisionStorage. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99035 (owner: 10Werdna) [22:11:41] (03CR) 10Brian Wolff: [C: 032] "No extensions use it (Only PagedTiffHandler calls this class, and it only uses public methods)." [core] - 10https://gerrit.wikimedia.org/r/99397 (owner: 10Siebrand) [22:12:12] csteipp: you can copy this mapping for the rijksmuseum xml … i think it has most of the mappings you'd need http://gwtoolset.wmflabs.org/wiki/GWToolset:Metadata_Mappings/Dan-nl/rijksmuseum.json [22:12:27] (03CR) 10EBernhardson: [C: 032] "PS2: utilize the abstract DbStorage class from BoardHistoryStorage, and update phpdoc" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99035 (owner: 10Werdna) [22:12:39] (03Merged) 10jenkins-bot: Declare visibility for class properties of PNGMetadataExtractor [core] - 10https://gerrit.wikimedia.org/r/99376 (owner: 10Siebrand) [22:13:19] (03CR) 10EBernhardson: "I think this can be abandonded and the dependant patch cherry-picked ontop of master?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99036 (owner: 10Werdna) [22:14:37] (03PS1) 10BryanDavis: Check for missing application [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99536 [22:14:40] (03PS2) 10Siebrand: Update documentation for File::getMetadata() [core] - 10https://gerrit.wikimedia.org/r/99446 [22:14:51] (03CR) 10Siebrand: [C: 032] "Per Brian's earlier +2." [core] - 10https://gerrit.wikimedia.org/r/99446 (owner: 10Siebrand) [22:15:12] (03PS2) 10Siebrand: Update some type hints in comments for Database classes [core] - 10https://gerrit.wikimedia.org/r/99445 [22:15:26] (03CR) 10Siebrand: "Rebased on master." [core] - 10https://gerrit.wikimedia.org/r/99445 (owner: 10Siebrand) [22:15:34] (03CR) 10Aaron Schulz: [C: 032] Remove 6 unused revdelete messages [core] - 10https://gerrit.wikimedia.org/r/99437 (owner: 10PleaseStand) [22:15:55] (03PS3) 10Bartosz Dziewoński: Update documentation for File::getMetadata() [core] - 10https://gerrit.wikimedia.org/r/99446 (owner: 10Siebrand) [22:16:14] (03Merged) 10jenkins-bot: Do not access MediaTransformOutput->url directly in Linker [core] - 10https://gerrit.wikimedia.org/r/99377 (owner: 10Siebrand) [22:16:23] (03CR) 10Aaron Schulz: [C: 032] Update documentation for File::getMetadata() [core] - 10https://gerrit.wikimedia.org/r/99446 (owner: 10Siebrand) [22:16:34] (03CR) 10Bartosz Dziewoński: [C: 032] "Removed silly info about being cherry-picked from self. The sha1 it referenced is not going to get into git itself (it's the previous patc" [core] - 10https://gerrit.wikimedia.org/r/99446 (owner: 10Siebrand) [22:18:56] (03Merged) 10jenkins-bot: Abstract out DbStorage superclass from BasicDbStorage and RevisionStorage. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99035 (owner: 10Werdna) [22:20:57] (03CR) 10Bartosz Dziewoński: "Well, who disallowed it? :P Would doing that break some tools/docs/whatever?" [core] - 10https://gerrit.wikimedia.org/r/99336 (owner: 10Siebrand) [22:21:41] *sigh* proofread page [22:22:09] (03CR) 10Aaron Schulz: Change line breaks in LocalFile::recordUpload2() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99147 (owner: 10Siebrand) [22:22:22] (03PS6) 10EBernhardson: Collapse topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 [22:24:01] (03CR) 10EBernhardson: "Loading paginated topics now keep the collapsed state that is currently selected. I did not change the 'new topic' behavior, i think the " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [22:25:02] (03PS3) 10Siebrand: Update some type hints in comments for Database classes [core] - 10https://gerrit.wikimedia.org/r/99445 [22:26:08] (03PS8) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [22:26:16] (03CR) 10Chad: Allow splitting of single namespaces into their own indexes (037 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [22:26:32] (03CR) 10EBernhardson: "Replaced [WIP] with [SCHEMA CHANGE]. This is ready for merge afaict" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [22:26:41] (03CR) 10Siebrand: [C: 04-1] "I've amended, but can't yet find truth in your claims. I'd like to wait with continuing this patch set until my other patch sets for inclu" [core] - 10https://gerrit.wikimedia.org/r/99445 (owner: 10Siebrand) [22:27:41] (03PS9) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [22:27:43] (03PS4) 10EBernhardson: Ensure non-binary cache keys [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98993 [22:27:55] (03PS5) 10Chad: Allow splitting of single namespaces into their own indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 [22:28:30] (03PS5) 10MarkTraceur: Standardise and minimise licence headers [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [22:28:42] (03PS3) 10Siebrand: Change line breaks in LocalFile::recordUpload2() [core] - 10https://gerrit.wikimedia.org/r/99147 [22:29:36] (03CR) 10Bartosz Dziewoński: "I'd just copy over the files. It's not like they change in core here often (I think we already SVG-ized just about everything), and it wou" [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson) [22:30:34] (03Merged) 10jenkins-bot: Remove 6 unused revdelete messages [core] - 10https://gerrit.wikimedia.org/r/99437 (owner: 10PleaseStand) [22:30:36] csteipp: sorry that mapping needed updating, just did it in case you still need it http://gwtoolset.wmflabs.org/wiki/GWToolset:Metadata_Mappings/Dan-nl/rijksmuseum.json [22:31:14] dan-nl: No problem. Thanks [22:31:43] (03CR) 10Jdlrobson: "I'm still on the fence about copying over files - as this imports LESS files from core which could potentially change (the fact they don't" [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson) [22:33:02] (03CR) 10Siebrand: Change line breaks in LocalFile::recordUpload2() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99147 (owner: 10Siebrand) [22:33:06] (03PS4) 10Siebrand: Change line breaks in LocalFile::recordUpload2() [core] - 10https://gerrit.wikimedia.org/r/99147 [22:34:31] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [22:34:34] (03Merged) 10jenkins-bot: Update documentation for File::getMetadata() [core] - 10https://gerrit.wikimedia.org/r/99446 (owner: 10Siebrand) [22:37:19] (03PS10) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [22:37:43] (03CR) 10EBernhardson: "PS10: cherry-pick so this depends on master, rather than an unmerged patch(wasn't necessary)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [22:38:21] (03PS6) 10Jdlrobson: Rewrite CSS for vectorTabs and #p-personal with nesting [core] - 10https://gerrit.wikimedia.org/r/90171 [22:38:26] (03PS5) 10Jdlrobson: Hygiene: Cleanup IE6 specific rules by using * hack [core] - 10https://gerrit.wikimedia.org/r/94163 [22:38:28] (03PS1) 10MaxSem: Update .gitreview - the repo has been renamed [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99539 [22:38:45] (03CR) 10Legoktm: [C: 032] Update .gitreview - the repo has been renamed [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99539 (owner: 10MaxSem) [22:39:14] is there jenkins on that repo? [22:39:34] (03CR) 10Siebrand: "AFAIK our source code comments to HTML docs thingie can't make nice HTML out of that." [core] - 10https://gerrit.wikimedia.org/r/99336 (owner: 10Siebrand) [22:39:42] (03CR) 10MaxSem: [C: 032 V: 032] Update .gitreview - the repo has been renamed [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99539 (owner: 10MaxSem) [22:39:58] shouldn't be - nobody touches it anyway [22:40:08] but that's gonna change;) [22:40:31] (03PS6) 10MarkTraceur: Standardise license tags in each file [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [22:41:15] (03PS1) 10Sharihareswara: performance improvements for dbaccess version [tools/missing-from-wikipedia] - 10https://gerrit.wikimedia.org/r/99540 [22:42:21] (03CR) 10Chad: [C: 032] Check for missing application [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99536 (owner: 10BryanDavis) [22:42:42] ^d: Thanks for the quick reviews today [22:42:59] <^d> Wham, bam, code review man! :D [22:43:03] :D [22:43:57] <^d> manybubbles: 97767 is nicer now, you were right about moving the isContent() check :) [22:43:58] s/:/\^/ [22:44:15] (03PS1) 10MaxSem: WIP: add new one-column diff mode [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99541 [22:44:50] (03CR) 10Jforrester: [C: 032] "Even if you can't spell licence. :-)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [22:45:02] MaxSem: woot. [22:45:08] scary [22:45:20] scared? run! [22:45:21] is that the stuff you had on Special:MobileDiff? [22:45:24] ;) :P [22:45:27] <^d> marktraceur: ASCII should've used :D instead ;-) [22:45:29] (i liked that stuff) [22:45:30] yep [22:47:10] (03Merged) 10jenkins-bot: Check for missing application [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99536 (owner: 10BryanDavis) [22:47:19] (03CR) 10Chad: Fix fetching ParserOutput (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 (owner: 10Chad) [22:47:31] (03Merged) 10jenkins-bot: Standardise license tags in each file [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [22:51:21] bawolff: can you look at https://gerrit.wikimedia.org/r/#/c/98067/ ? [22:51:41] will do [22:52:38] (03PS1) 10Brian Wolff: Make DjVu metadata be stored as serialized PHP array. [core] - 10https://gerrit.wikimedia.org/r/99544 [22:53:45] (03CR) 10Chad: [C: 032] Updates for Interwiki.php [core] - 10https://gerrit.wikimedia.org/r/97508 (owner: 10Siebrand) [22:54:27] (03CR) 10Manybubbles: Fix fetching ParserOutput (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 (owner: 10Chad) [22:57:57] (03Merged) 10jenkins-bot: Updates for Interwiki.php [core] - 10https://gerrit.wikimedia.org/r/97508 (owner: 10Siebrand) [23:02:24] (03CR) 10Chad: [C: 04-1] "Looks good, other than the stdClass/array mixups I noted. Fix those and I think we can merge." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/98859 (owner: 10Siebrand) [23:05:43] (03PS1) 10BryanDavis: Add missing Apply::updateNotes() function [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99546 [23:06:08] (03PS1) 10Ori.livneh: mediawiki.js: add `mw.track`, imported from VisualEditor [core] - 10https://gerrit.wikimedia.org/r/99547 [23:06:42] ^ RoanKattouw: flagging that for your queue :) [23:07:29] (03CR) 10Chad: Fix fetching ParserOutput (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 (owner: 10Chad) [23:07:30] (03PS3) 10Siebrand: Update documentation for log related classes [core] - 10https://gerrit.wikimedia.org/r/98859 [23:07:35] (03CR) 10Siebrand: "Thanks for the review. All updated in the next PS." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/98859 (owner: 10Siebrand) [23:07:43] (03PS2) 10Siebrand: Declare visibility on log class related properties [core] - 10https://gerrit.wikimedia.org/r/98969 [23:08:07] my, mediawiki.js is getting large. [23:08:22] MatmaRex: those 66 lines are mostly ponderous comment headers [23:09:20] no, the 66 lines is very little anyway [23:09:28] the file is 2188 lines long… [23:09:44] it's not very well-factored, no [23:09:55] (03CR) 10BryanDavis: "I wish I could say I just wanted to get my patch count up, but the truth is that I just haven't spent enough time doing the proper smoke t" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99546 (owner: 10BryanDavis) [23:09:58] lol at happy-melon's mailing list post -- signpost is enwiki specific, but en-wiki are the only one's who complain anyhow [23:10:06] it should totally be split [23:10:09] my favorite is the 'work' method, which is a great code smell [23:10:10] but that's BORING [23:10:13] heh [23:10:14] doStuff() [23:10:29] It could be worse [23:10:40] See e.g. Minetest's game() function [23:11:14] bawolff, +1 ref lol at happy-melon's mailing list post [23:11:17] i'm going to do some light refactoring which i hope will make it possible to cache top-loading modules in localStorage [23:12:51] Sweet [23:12:54] !class ORMTable [23:12:55] See https://doc.wikimedia.org/mediawiki-core/master/php/html/classORMTable.html [23:14:54] (03CR) 10Siebrand: [C: 032] Changed ZeroRatedMobileAccess to Zero [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/99158 (owner: 10Yurik) [23:14:55] (03CR) 10jenkins-bot: [V: 04-1] Changed ZeroRatedMobileAccess to Zero [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/99158 (owner: 10Yurik) [23:15:55] (03PS4) 10saper: Remove mergeExpected and assertResultRecursive [core] - 10https://gerrit.wikimedia.org/r/99340 [23:16:09] (03CR) 10Siebrand: "@yurik: More merge conflicts. This is why it's recommended to only change English. Please feel free to +2 yourself after rebasing." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/99158 (owner: 10Yurik) [23:16:19] (03CR) 10saper: "Right, thanks for pointing this." [core] - 10https://gerrit.wikimedia.org/r/99340 (owner: 10saper) [23:17:24] (03CR) 10Siebrand: [C: 032 V: 032] "Merged. Please have a look at the comments." [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/89625 (owner: 10leucosticte) [23:17:50] (03CR) 10Bartosz Dziewoński: "There are some usages in core already, e.g. ORMTable#__construct https://doc.wikimedia.org/mediawiki-core/master/php/html/classORMTable.ht" [core] - 10https://gerrit.wikimedia.org/r/99336 (owner: 10Siebrand) [23:18:25] (03CR) 10Siebrand: "That makes me happy. I'll make one more update before going to sleep :)." [core] - 10https://gerrit.wikimedia.org/r/99336 (owner: 10Siebrand) [23:18:37] (03PS2) 10Siebrand: Add more type hints in comments for static code analysis [core] - 10https://gerrit.wikimedia.org/r/99336 [23:21:01] (03CR) 10Brian Wolff: "I've submitted an alternate approach at https://gerrit.wikimedia.org/r/99544" [core] - 10https://gerrit.wikimedia.org/r/24660 (owner: 10Tpt) [23:22:40] (03CR) 10Chad: Fix fetching ParserOutput (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 (owner: 10Chad) [23:23:00] (03PS3) 10Chad: Fix fetching ParserOutput [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 [23:23:25] (03PS3) 10Siebrand: Add more type hints in comments for static code analysis [core] - 10https://gerrit.wikimedia.org/r/99336 [23:24:01] (03CR) 10Siebrand: "Best thing possible." [core] - 10https://gerrit.wikimedia.org/r/99336 (owner: 10Siebrand) [23:24:20] (03CR) 10Chad: [C: 032] Set saner default for parameters of LogEventsList::showOptions() [core] - 10https://gerrit.wikimedia.org/r/98974 (owner: 10Siebrand) [23:26:42] (03CR) 10Chad: [C: 032] Declare visibility on class props of MediaTransformOutput and MediaTransformError [core] - 10https://gerrit.wikimedia.org/r/99383 (owner: 10Siebrand) [23:27:16] (03CR) 10Chad: [C: 032] Declare visibility on class property of MediaHandler [core] - 10https://gerrit.wikimedia.org/r/99384 (owner: 10Siebrand) [23:28:54] (03CR) 10Esanders: "Sorry, I didn't mean to hold you up, I was assuming you were going to abandon this." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [23:29:27] (03Merged) 10jenkins-bot: Set saner default for parameters of LogEventsList::showOptions() [core] - 10https://gerrit.wikimedia.org/r/98974 (owner: 10Siebrand) [23:29:59] (03CR) 10Aaron Schulz: Fix fetching ParserOutput (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 (owner: 10Chad) [23:32:20] (03Merged) 10jenkins-bot: Declare visibility on class props of MediaTransformOutput and MediaTransformError [core] - 10https://gerrit.wikimedia.org/r/99383 (owner: 10Siebrand) [23:34:10] (03Merged) 10jenkins-bot: Declare visibility on class properties of GIFMetadataExtractor [core] - 10https://gerrit.wikimedia.org/r/99390 (owner: 10Siebrand) [23:34:11] (03Merged) 10jenkins-bot: Declare visibility on class property of FormatExif [core] - 10https://gerrit.wikimedia.org/r/99397 (owner: 10Siebrand) [23:34:12] (03Merged) 10jenkins-bot: Declare visibility on class property of MediaHandler [core] - 10https://gerrit.wikimedia.org/r/99384 (owner: 10Siebrand) [23:35:58] (03CR) 10Aaron Schulz: [C: 04-1] Add no-dimensions option to MediaTransformOutput::toHtml (031 comment) [core] - 10https://gerrit.wikimedia.org/r/90679 (owner: 10JGonera) [23:37:07] (03CR) 10Aaron Schulz: [C: 04-1] Add more type hints in comments for static code analysis (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99336 (owner: 10Siebrand) [23:37:55] (03Abandoned) 10Mwalker: Update to latest bundler and latexer; rename their binaries. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/99008 (owner: 10Cscott) [23:38:32] (03CR) 10Mwalker: [C: 032] Adding a special form definition for VN. This form will only allow USD in VN, until Globalcollect sorts out VND. [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/99442 (owner: 10Katie Horn) [23:40:22] (03CR) 10Bartosz Dziewoński: [C: 032] "If this makes whatever tools you're using for the static code analysis happy, then it makes me happy as well. :)" [core] - 10https://gerrit.wikimedia.org/r/99336 (owner: 10Siebrand) [23:43:02] rmoen ve on mobile doesn't seem to be working on beta labs.. http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=0.31074819690008837&mobileaction=alpha yet? [23:43:07] just hangs.. [23:43:26] I wonder if the latest VE code is not running on betalabs [23:44:08] (03PS1) 10EBernhardson: Group revision by the type(header or post id) in RevisionStorage::findMostRecent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99559 [23:46:48] csteipp: about to shutdown for the eve … anything else i might be able to answer before i go? [23:47:12] jdlrobson: ahh there is some new unknown dependency ext.wikimediaEvents.ve [23:47:20] :( [23:47:36] jdlrobson: looking into this [23:49:14] (03Merged) 10jenkins-bot: Add more type hints in comments for static code analysis [core] - 10https://gerrit.wikimedia.org/r/99336 (owner: 10Siebrand) [23:50:15] (03PS1) 10MaxSem: Update MobileFrontend to wmf6 tip [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99560 [23:51:01] (03PS1) 10EBernhardson: Properly escape button content and document that safe html must be passed in [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99561 [23:52:31] jdlrobson: so i'm not sure what is depending on ext.wikimediaEvents.ve as its not in our code base or yours [23:52:47] jdlrobson: I'm guessing an issue with wikimediaEvents? [23:53:23] jdlrobson: I'll pull the extension and check it out [23:53:42] mm that's odd [23:53:53] jdlrobson: indeed [23:57:56] (03PS1) 10EBernhardson: Document return value of HistoryRenderer::getTimespans [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99562