[00:00:25] (03CR) 10Jdlrobson: [C: 032] "*shrug*" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148983 (owner: 10SG) [00:01:02] (03Merged) 10jenkins-bot: Add onbeforeunload handler when navigating away from unsubmitted changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148983 (owner: 10SG) [00:01:43] (03PS19) 10Cscott: Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 (owner: 10Mwalker) [00:02:59] (03CR) 10Dzahn: [C: 032] Add .gitreview [wikimedia/bots/jouncebot] - 10https://gerrit.wikimedia.org/r/149194 (owner: 10Reedy) [00:03:07] (03CR) 10Dzahn: [V: 032] Add .gitreview [wikimedia/bots/jouncebot] - 10https://gerrit.wikimedia.org/r/149194 (owner: 10Reedy) [00:06:42] (03CR) 10Jdlrobson: [C: 032] Replying to a topic visually updates watch star on topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147346 (owner: 10Werdna) [00:07:16] (03Merged) 10jenkins-bot: Replying to a topic visually updates watch star on topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147346 (owner: 10Werdna) [00:10:04] (03CR) 10Hoo man: "mh... probably the special page registration (and maybe the class registration) needed for global rename should also be in the if class_ex" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/149193 (owner: 10BryanDavis) [00:10:27] 3MediaWiki skins / 3Vector: Grey content text in Vector impairs legibility - 10https://bugzilla.wikimedia.org/66021#c7 (10Isarra) (In reply to Bawolff (Brian Wolff) from comment #5) > Created attachment 16032 [details] > Screenshot with a gamma adjustment of 3.0 to simulate what a crappy monitor > would look... [00:10:49] (03PS1) 10Dzahn: initial commit - import from github [wikimedia/bots/jouncebot] - 10https://gerrit.wikimedia.org/r/149195 [00:11:15] (03PS1) 10Jack Phoenix: Design fixes and tweaks, especially for headers and some minor color changes. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/149196 [00:11:44] (03CR) 10Jack Phoenix: [C: 032 V: 032] Design fixes and tweaks, especially for headers and some minor color changes. [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/149196 (owner: 10Jack Phoenix) [00:13:25] (03PS1) 10MSyed: Content and Style changes [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/149199 [00:13:44] (03CR) 10Dzahn: [C: 032] initial commit - import from github [wikimedia/bots/jouncebot] - 10https://gerrit.wikimedia.org/r/149195 (owner: 10Dzahn) [00:13:56] (03CR) 10Dzahn: [V: 032] initial commit - import from github [wikimedia/bots/jouncebot] - 10https://gerrit.wikimedia.org/r/149195 (owner: 10Dzahn) [00:14:37] (03CR) 10Cscott: "@mwalker: i made some tweaks, they'll probably require some minor changes to the renderer. i'll do that next." [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 (owner: 10Mwalker) [00:15:24] (03CR) 10Legoktm: [C: 031] Add Renameuser and UserMerge roles [vagrant] - 10https://gerrit.wikimedia.org/r/149192 (owner: 10BryanDavis) [00:15:29] 3MediaWiki / 3JavaScript: Log JavaScript errors with onerror - 10https://bugzilla.wikimedia.org/51857#c2 (10Matthew Flaschen) Gergő Tisza (Tgr) also started an RFC at https://www.mediawiki.org/wiki/Requests_for_comment/Server-side_Javascript_error_logging in case anyone missed the URL field change. [00:18:28] (03PS1) 10MaxSem: Add SQLite support to make Jenkins happy [extensions/OAI] - 10https://gerrit.wikimedia.org/r/149200 (https://bugzilla.wikimedia.org/65895) [00:19:43] 3MediaWiki extensions / 3Math: Math tests dies when run with the Echo extensions - 10https://bugzilla.wikimedia.org/67148#c9 (10Max Semenik) Antoine, is it fine for you now? [00:19:47] (03PS1) 10Dzahn: add jouncebot changes to -operations channel [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/149201 [00:20:47] (03CR) 10Mwalker: [C: 032] add jouncebot changes to -operations channel [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/149201 (owner: 10Dzahn) [00:20:50] (03Merged) 10jenkins-bot: add jouncebot changes to -operations channel [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/149201 (owner: 10Dzahn) [00:22:44] MaxSem: lol. Why are you bothering with Extension:OAI? :P [00:23:04] because there's a bug for it [00:23:22] [00:24:34] (03PS1) 10Dzahn: gender-neutral language, Dear anthropoid.. [wikimedia/bots/jouncebot] - 10https://gerrit.wikimedia.org/r/149202 [00:25:00] (03CR) 10Reedy: [C: 032] Refactoring [extensions/OAI] - 10https://gerrit.wikimedia.org/r/149189 (owner: 10MaxSem) [00:25:03] (03Merged) 10jenkins-bot: Refactoring [extensions/OAI] - 10https://gerrit.wikimedia.org/r/149189 (owner: 10MaxSem) [00:25:07] (03CR) 10Reedy: [C: 032] Update file location per I62b03905fb813225de67c3426f97c181e23fd7c0 [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/149190 (owner: 10MaxSem) [00:25:11] (03Merged) 10jenkins-bot: Update file location per I62b03905fb813225de67c3426f97c181e23fd7c0 [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/149190 (owner: 10MaxSem) [00:25:16] (03PS4) 10Jdlrobson: Hygiene: Add suitable default styles for ul elements in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148530 [00:25:19] (03PS1) 10Jdlrobson: Remove undocumented css [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149203 (https://bugzilla.wikimedia.org/67833) [00:26:07] (03CR) 10Dzahn: [C: 031] "http://en.wiktionary.org/wiki/anthropoid" [wikimedia/bots/jouncebot] - 10https://gerrit.wikimedia.org/r/149202 (owner: 10Dzahn) [00:28:54] errggghh [00:29:33] https://integration.wikimedia.org/ci/job/mwext-OAI-testextensions-master/8/console <- $updater->getDB()->getType() somehow returns something other than sqlite [00:29:38] o_0 [00:29:43] but then file gets executed by sqlite [00:30:02] brillant PaulaBean [00:31:18] (03PS2) 10MaxSem: Add SQLite support to make Jenkins happy [extensions/OAI] - 10https://gerrit.wikimedia.org/r/149200 (https://bugzilla.wikimedia.org/65895) [00:31:20] (03CR) 10jenkins-bot: [V: 04-1] Add SQLite support to make Jenkins happy [extensions/OAI] - 10https://gerrit.wikimedia.org/r/149200 (https://bugzilla.wikimedia.org/65895) (owner: 10MaxSem) [00:31:26] lol [00:31:30] denied [00:31:41] well, I added a var_dump to it [00:32:28] (03PS3) 10MaxSem: Add SQLite support to make Jenkins happy [extensions/OAI] - 10https://gerrit.wikimedia.org/r/149200 (https://bugzilla.wikimedia.org/65895) [00:34:26] rebase fixed it? [00:34:33] (03PS4) 10Jdlrobson: Watchstar should use mediawiki ui styles not flow ui for buttons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148724 (https://bugzilla.wikimedia.org/68456) [00:34:46] 3MediaWiki extensions / 3GlobalUserPage: Add a template message at the transcluded locations, to indicate the source - 10https://bugzilla.wikimedia.org/66931#c1 (10Isarra) Sounds like a good idea to me. [00:34:58] (03PS4) 10MaxSem: Add SQLite support to make Jenkins happy [extensions/OAI] - 10https://gerrit.wikimedia.org/r/149200 (https://bugzilla.wikimedia.org/65895) [00:40:22] dafuuuuuu [00:44:14] 3MediaWiki extensions / 3Scribunto: Lua error in an unprotected function can cause a longjmp to unwind HHVM's stack - 10https://bugzilla.wikimedia.org/68196#c17 (10Ori Livneh) 5PATC>3RESO/FIX (In reply to Bryan Davis from comment #16) > Cross post from https://bugzilla.wikimedia.org/show_bug.cgi?id=68413... [00:45:02] (03PS9) 10BryanDavis: Allow login with pre-rename username and password [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/147020 (https://bugzilla.wikimedia.org/67995) [00:45:04] (03PS2) 10BryanDavis: [WIP] Interstitial notification page for renamed users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) [00:46:00] 3MediaWiki extensions / 3GlobalCssJs: Global CSS and JS should not be loaded on [[Special:Preferences]] and [[Special:UserLogin]] - 10https://bugzilla.wikimedia.org/68521 (10Kunal Mehta (Legoktm)) [00:46:09] (03PS1) 10Jdlrobson: Fix styling of more menu [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149205 (https://bugzilla.wikimedia.org/68262) [00:46:14] 3Wikimedia / 3Extension setup: Review and deploy GlobalCssJs extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/57891 (10Kunal Mehta (Legoktm)) [00:47:40] (03PS1) 10Mwalker: Adding test support for wikimedia/bots/jouncebot [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/149206 [00:47:46] (03CR) 10BryanDavis: [WIP] Interstitial notification page for renamed users (033 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [00:48:07] (03PS1) 10Mwalker: Adding test support for wikimedia/bots/jouncebot [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/149207 [00:48:13] marktraceur, how nice are you feeling today? [00:49:58] 3MediaWiki extensions / 3MassMessage: MassMessage: Please include an easy way to add a timestamp at the end of the message - 10https://bugzilla.wikimedia.org/68513#c1 (10MZMcBride) I'm not sure I understand why MassMessage needs modification here. This seems like a purely content issue. Is "~~~~~" inadequat... [00:50:16] 3Wikimedia / 3Extension setup: Review and deploy GlobalCssJs extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/57891 (10Kunal Mehta (Legoktm)) [00:50:19] 3MediaWiki extensions / 3GlobalCssJs: User:Foo/global.css will not be loaded if the user has JavaScript disabled - 10https://bugzilla.wikimedia.org/68547 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None We're currently loading both in the same request, which requires JS to function. Some d... [00:53:28] 3MediaWiki extensions / 3MassMessage: MassMessage: Please include an easy way to mark the language (and language direction: LTR vs RTL) for a message - 10https://bugzilla.wikimedia.org/68512#c1 (10MZMcBride) This seems like feature-creep. We tried to keep the input form as simple as possible. This is a cont... [00:54:45] 3Wikimedia / 3Bugzilla: Create a component for Jouncebot - 10https://bugzilla.wikimedia.org/68548 (10Matt Walker) 3NEW p:3Unprio s:3normal a:3None Jouncebot is an IRC bot that lives in gerrit at wikimedia/bots/jouncebot. We should have a bug tracker for it, and I think it should live as a component '... [00:54:46] (03PS5) 10MaxSem: Add SQLite support to make Jenkins happy [extensions/OAI] - 10https://gerrit.wikimedia.org/r/149200 (https://bugzilla.wikimedia.org/65895) [00:55:47] Reedy, works now ^^^ :P [00:56:02] 3Wikimedia / 3Bugzilla: add component for jouncebot - 10https://bugzilla.wikimedia.org/68549 (10Daniel Zahn) 3NEW p:3Unprio s:3normal a:3None please add a BZ component for jouncebot, we imported it into gerrit from github today as well. Project wikimedia/bots/jouncebot https://wikitech.wikimedia.or... [00:57:15] 3Wikimedia / 3Bugzilla: Create a component for Jouncebot - 10https://bugzilla.wikimedia.org/68548#c1 (10Matt Walker) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68549 *** [00:57:15] 3Wikimedia / 3Bugzilla: add component for jouncebot - 10https://bugzilla.wikimedia.org/68549#c1 (10Matt Walker) *** Bug 68548 has been marked as a duplicate of this bug. *** [00:57:23] (03CR) 10Jdlrobson: "line-height seems wrong?" [core] - 10https://gerrit.wikimedia.org/r/146979 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [00:57:54] (03PS1) 10Bsitu: Fix incorrect varaible name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149208 [00:59:29] 3Wikimedia / 3Bugzilla: add component for jouncebot - 10https://bugzilla.wikimedia.org/68549#c2 (10Matt Walker) Actually; it seems the convention is to put this under the 'Tool labs tools' product [01:01:13] (03PS5) 10Cscott: Some commands should require arguments in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/149097 [01:01:15] (03PS8) 10Cscott: Regularize spacing in `texvc` and `texvccheck` [extensions/Math] - 10https://gerrit.wikimedia.org/r/148677 [01:02:24] (03PS1) 10Werdna: Only generate board HTML if generateHtml is true. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149209 [01:03:48] (03CR) 10Bsitu: "The consequence of this is that diff link in a bundled talk page notification wouldn't show the diff of all changes in that bundled messag" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149208 (owner: 10Bsitu) [01:04:38] (03PS13) 10Werdna: WIP: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 [01:04:41] (03PS1) 10Werdna: WIP: Move watch star for boards next to the header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 [01:08:59] (03PS2) 10Alex Monk: Fix incorrect variable name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149208 (owner: 10Bsitu) [01:16:17] 3Wikimedia / 3Bugzilla: add component for jouncebot - 10https://bugzilla.wikimedia.org/68549 (10Tyler Romeo) 5NEW>3ASSI p:5Unprio>3Normal a:3Tyler Romeo [01:16:45] (03CR) 10MaxSem: [C: 032] Fix use of undefined const NS_TIMEDTEXT [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149046 (owner: 10Ori.livneh) [01:16:56] (03Merged) 10jenkins-bot: Fix use of undefined const NS_TIMEDTEXT [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/149046 (owner: 10Ori.livneh) [01:18:18] 3Wikimedia / 3Bugzilla: add component for jouncebot - 10https://bugzilla.wikimedia.org/68549#c3 (10Tyler Romeo) Who should be the default CCes (also, if you want, a default assignee other than wikibugs)? [01:27:28] 3MediaWiki extensions / 3MassMessage: MassMessage: Please include an easy way to add a timestamp at the end of the message - 10https://bugzilla.wikimedia.org/68513#c2 (10WhatamIdoing) "~~~~~" is inadequate when people forget to add it, or when they sign the message and then add a "P.S." or other content aft... [01:28:42] (03CR) 10MaxSem: [C: 032] "I'd rather prefer to see if ( !$res ) but meh..." [core] - 10https://gerrit.wikimedia.org/r/141619 (owner: 10Ori.livneh) [01:30:36] (03CR) 10MaxSem: [C: 032] Add Renameuser and UserMerge roles [vagrant] - 10https://gerrit.wikimedia.org/r/149192 (owner: 10BryanDavis) [01:30:53] (03Merged) 10jenkins-bot: Add Renameuser and UserMerge roles [vagrant] - 10https://gerrit.wikimedia.org/r/149192 (owner: 10BryanDavis) [01:31:58] (03Merged) 10jenkins-bot: Check for boolean false result from database query in SqlBagOStuff [core] - 10https://gerrit.wikimedia.org/r/141619 (owner: 10Ori.livneh) [01:32:14] 3MediaWiki extensions / 3MassMessage: MassMessage: Please include an easy way to mark the language (and language direction: LTR vs RTL) for a message - 10https://bugzilla.wikimedia.org/68512#c2 (10WhatamIdoing) Most people do not believe that adding complicated HTML codes like
(03PS2) 10Legoktm: Revert "Generalize Installer::showStatusMessage()" [core] - 10https://gerrit.wikimedia.org/r/148026 [01:38:17] (03CR) 10Legoktm: [C: 032] Revert "Generalize Installer::showStatusMessage()" [core] - 10https://gerrit.wikimedia.org/r/148026 (owner: 10Legoktm) [01:41:22] (03Merged) 10jenkins-bot: Revert "Generalize Installer::showStatusMessage()" [core] - 10https://gerrit.wikimedia.org/r/148026 (owner: 10Legoktm) [01:42:12] (03CR) 10Legoktm: [C: 031] "Special:GlobalRenameUser guards with a class_exists, I don't think the progress page does. I don't think we really need to conditionally a" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/149193 (owner: 10BryanDavis) [01:43:01] (03PS3) 10BearND: [WIP] Add flag icon for article/page issues links [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148866 [01:43:55] (03PS8) 10Legoktm: Make profile icon gender neutral and remove from login link in Vector [core] - 10https://gerrit.wikimedia.org/r/146979 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [01:49:42] (03PS4) 10Cscott: Latexer should not die on a bad image [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148614 (owner: 10Mwalker) [01:57:23] (03CR) 10Ebe123: Create preferences to watchlist pages after rollbacking and undoing (033 comments) [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) (owner: 10Ebe123) [01:57:27] (03PS1) 10Cscott: Skip math content if `teubner`, `cancel`, or `euro` packages are required. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149214 [02:00:34] (03CR) 10BryanDavis: "You can test using MediaWiki-Vagrant and the newly updated centralauth role which now loads Renameuser." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/149193 (owner: 10BryanDavis) [02:03:59] (03CR) 10Cscott: "I'm not convinced that --builddir is needed; the system already honors TMPDIR if set, since the `tmp` package uses os.tmpdir():" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148970 (owner: 10Mwalker) [02:13:30] 3MediaWiki extensions / 3MassMessage: MassMessage: Please include an easy way to add a timestamp at the end of the message - 10https://bugzilla.wikimedia.org/68513#c3 (10Kunal Mehta (Legoktm)) (In reply to WhatamIdoing from comment #2) > "~~~~~" is inadequate when people forget to add it, or when they sign... [02:15:44] 3MediaWiki / 3ResourceLoader: mw.loader.store should not occupy all of localStorage for itself - 10https://bugzilla.wikimedia.org/64721#c5 (10Matthew Flaschen) (In reply to Krinkle from comment #4) > mw.loader.store falls back to fetching from the server. However other > features that actually use localStora... [02:21:19] (03PS3) 10Bsitu: Fix incorrect variable name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149208 (https://bugzilla.wikimedia.org/68552) [02:25:22] (03CR) 10Legoktm: "How many users do we expect (rough estimate) to use this feature?" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/53918 (owner: 10Parent5446) [02:26:00] (03CR) 10Mattflaschen: "For what it's worth, I don't necessarily agree with "Stop thinking in terms of skins" (depends what you mean)." [core] - 10https://gerrit.wikimedia.org/r/145699 (owner: 10Jdlrobson) [02:31:03] (03PS1) 10Aaron Schulz: [WIP] Factored out JobRunnerPipeline and added curl dispatcher support [services/jobrunner] - 10https://gerrit.wikimedia.org/r/149216 [02:37:50] 3MediaWiki extensions / 3ExtensionDistributor: Include git submodules, by default, or optionally - 10https://bugzilla.wikimedia.org/44022#c6 (10Matthew Flaschen) (In reply to Kunal Mehta (Legoktm) from comment #3) > I've set up an API endpoint for VisualEditor on labs: > http://tools.wmflabs.org/extdist/?ver... [02:41:13] 3MediaWiki-Vagrant: 503 error with HHVM (default) enabled - 10https://bugzilla.wikimedia.org/68002#c3 (10Matthew Flaschen) 5NEW>3RESO/WOR It might have just been an out-of-memory. I'm going to mark WORKSFORME. I'm currently using HHVM successfully. But if I hit it again, I'll debug using those files a... [02:46:14] 3MediaWiki-Vagrant: MediaWiki vagrant doesn't work with VMWare Fusion provider - 10https://bugzilla.wikimedia.org/59904#c26 (10Bryan Davis) 5PATC>3RESO/FIX Re-closing after gerrit reopened for a related commit. Feel free to reopen if we have additional outstanding issues I'm not aware of. [02:46:30] (03PS1) 10Cscott: Allow rendering from unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149220 [02:47:07] (03CR) 10Cscott: "See https://gerrit.wikimedia.org/r/149220 for an alternative way to do this." [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148970 (owner: 10Mwalker) [02:48:47] (03CR) 10jenkins-bot: [V: 04-1] Allow rendering from unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149220 (owner: 10Cscott) [02:52:13] 3MediaWiki-Vagrant: Support newer puppet (3.6.x) - 10https://bugzilla.wikimedia.org/67214 (10Bryan Davis) p:5Unprio>3Low s:5normal>3enhanc [02:54:55] (03PS5) 10Cscott: Latexer should not die on a bad image [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148614 (owner: 10Mwalker) [02:55:14] (03CR) 10Cscott: [C: 032] Latexer should not die on a bad image [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148614 (owner: 10Mwalker) [02:56:01] (03CR) 10Cscott: [C: 032] Skip math content if `teubner`, `cancel`, or `euro` packages are required. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149214 (owner: 10Cscott) [02:57:08] (03Merged) 10jenkins-bot: Latexer should not die on a bad image [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148614 (owner: 10Mwalker) [02:58:20] (03PS2) 10Cscott: Allow rendering from unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149220 [02:58:33] (03Merged) 10jenkins-bot: Skip math content if `teubner`, `cancel`, or `euro` packages are required. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149214 (owner: 10Cscott) [03:01:05] (03PS6) 10Cscott: Use `jpegtran` to purge EXIF data from jpegs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138149 [03:04:34] (03CR) 10Mattflaschen: [C: 04-1] "First, I really like the idea of an icon font, and specifically how it will hopefully lead to a consistent icon palette and fewer one-offs" [core] - 10https://gerrit.wikimedia.org/r/137888 (https://bugzilla.wikimedia.org/66138) (owner: 10Prtksxna) [03:16:35] 3Wikimedia / 3Mailing lists: Wrong cert on mail.wikipedia.org (as it redirects to lists.wikimedia.org) - 10https://bugzilla.wikimedia.org/44731#c11 (10Matthew Flaschen) (In reply to Jan Zerebecki from comment #10) > Maybe the link doesn't get updated because robots.txt has Disallow: > /pipermail/ . Perhaps m... [03:19:00] 3Wikimedia / 3Mailing lists: Wrong cert on mail.wikipedia.org (as it redirects to lists.wikimedia.org) - 10https://bugzilla.wikimedia.org/44731#c12 (10Matthew Flaschen) (In reply to Matthew Flaschen from comment #11) > (In reply to Jan Zerebecki from comment #10) > > Maybe the link doesn't get updated becaus... [03:21:17] (03PS7) 10Cscott: Use `jpegtran` to purge EXIF data from jpegs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138149 [03:24:45] 3Wikimedia / 3SSL related: https://lists.wikimedia.org/pipermail/somelist/ redirects to http://lists.wikimedia.org/pipermail/somelist/ - 10https://bugzilla.wikimedia.org/68553 (10Matthew Flaschen) 3NEW p:3Unprio s:3normal a:3None https://lists.wikimedia.org/pipermail/wikitech-l/ redirects to http://l... [03:24:59] 3Wikimedia / 3SSL related: https://lists.wikimedia.org/pipermail/somelist/ redirects to http://lists.wikimedia.org/pipermail/somelist/ - 10https://bugzilla.wikimedia.org/68553 (10Matthew Flaschen) [03:24:59] 3Wikimedia / 3Apache configuration: Non-canonical HTTPS URLs quietly redirect to HTTP - 10https://bugzilla.wikimedia.org/31369 (10Matthew Flaschen) [03:25:16] 3MediaWiki extensions / 3Scribunto: LuaSandbox's profiler crashes under HHVM - 10https://bugzilla.wikimedia.org/68413 (10Ori Livneh) [03:25:16] 3Wikimedia / 3Mailing lists: Wrong cert on mail.wikipedia.org (as it redirects to lists.wikimedia.org) - 10https://bugzilla.wikimedia.org/44731 (10Matthew Flaschen) [03:26:17] (03PS4) 10Cscott: Use proper page of any PDF figure. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/143564 [03:29:39] (03PS4) 10Cscott: Handle tables which are used only to align a row of images. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/143565 [03:29:41] (03PS4) 10Cscott: Hack to render [[meta:Wikimedia_Foundation_Report,_May_2014]] better. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/143566 [03:29:43] (03PS4) 10Cscott: Hack table support to improve [[meta:Wikimedia_Foundation_Report,_May_2014]] [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/143567 [03:29:45] (03PS10) 10Cscott: Basic table support. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107587 [03:30:54] (03PS3) 10Cscott: Render attribution page [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148611 (owner: 10Mwalker) [03:47:07] cscott, oooh; table support :) [03:47:32] 3MediaWiki-Vagrant: HHVM Failed Assertion: assertion `false && "Unsupported DataType"' failed. - 10https://bugzilla.wikimedia.org/68491#c1 (10Brett Simmers) Someone else on my team figured this out earlier today. The fix is up for review and should go out tomorrow. [03:47:57] mwalker: not really ready for prime time yet. but not killing jenkins, either. [03:48:21] sooo... we have competing patches for unzipped bundles [03:48:28] I don't know which one is better [03:48:34] i like mine ;) [03:48:53] but; I like mine! :p [03:49:07] clearly we should let jenkins decide [03:49:19] actually though -- why hard links? symlink is faster to create [03:49:26] and we dont lose much overhead resolving the path [03:49:58] because we actually munge the contents of the directory [03:50:14] hard links means that we are protected from doing any damage to the original input dir [03:50:57] not really; if you modify a hardlinked file you modify it in both places [03:51:09] only if you add something new does it protect you [03:51:19] and I thought thats why you had a latex dir as well as a bundle dir [03:51:23] yes, so we shouldn't modify things in place. i don't *think* we do that. [03:51:55] yes, it would be why latex and bundle are separate... however latex's graphicx package will only take input files from a single directory. [03:52:09] that is... dumb [03:52:15] so we point it at bundle/images, and occasionally munge things in there. [03:52:28] hmm [03:52:30] ok... [03:52:32] i could probably refactor around that, but then i'd be copying the largish images around, unnecessarily in most cases [03:52:46] or i could use hardlinks there... but then we're back to where we started from. [03:52:49] second point; pleasepleaseplease dont make me use an environment variable for the tempdir [03:53:14] i was trying to find some standard option convention for specifying tmpdir. but TMPDIR=xxx seems to be the accepted posix convention. [03:54:31] oh, sort(1) uses -T, --temporary-directory=DIR. (In addition to $TMPDIR, natch.) I guess I could call that standard, then. [03:57:21] it looks like I can pass in custom environment variables via child_process.spawn -- it's just unlike how I pass the rest of the options [03:58:48] i can add a -T option for you. [03:59:04] :D [03:59:28] 3MediaWiki-Vagrant: Standalone jobrunner does not start - 10https://bugzilla.wikimedia.org/68525#c1 (10Ori Livneh) (In reply to Matthew Flaschen from comment #0) > Running it manually gives [...] Could you try it with sudo? [04:00:40] cscott, actually; another reason to want to specify the tempdir for me is so that if your process crashes I can remove the files (and possibly move them to a 'postmortem' directory to look at) [04:01:07] so it's useful for the outer process to know where you're doing your work for a given metabook [04:03:40] hm, well -T usually specifies the *parent* dir, not the build dir necessarily. [04:04:38] *nods* but I can give each child a different one :p [04:04:42] it's an ugly hack [04:04:42] ok [04:07:21] the [[United States]] article has 20+ pages of author and image credits. (!) [04:07:38] and the 'content license' section seems to be blank. [04:13:49] hmm... normally I expect that information in the metabook from the collection extension [04:14:15] because it's not easy to get that information out of MediaWiki in a consistent manner [04:14:46] hm, well the last few characters of attribution.wt are "|}}" so i guess we're not getting it from the collection extension [04:14:59] and/or i shouldn't be asking enwiki for this stuff yet [04:16:05] did you make the US metabook using the bundler itself? [04:17:31] (03PS1) 10BryanDavis: Add role::php5vhost [vagrant] - 10https://gerrit.wikimedia.org/r/149243 (https://bugzilla.wikimedia.org/67517) [04:19:07] yes, this is a newly made US bundle, with the attribution patches, so i can test things. [04:19:42] right; so that's expected then that you wouldn't have license information -- get it to where you're happy without that and then we can do a follow up to get it license information when it doesn't have it [04:19:51] because I suspect I'm going to have to patch mediawiki [04:20:08] ok [04:20:38] at the moment the renderer is choking on some right-to-left text in the attributions for [[United States]]. working on it... [04:20:56] someone with an RtL username? [04:21:03] yes, apparently. [04:21:42] also we switch to \textsmall halfway through the image attributions. don't know why that's happening. [04:21:53] (03CR) 1020after4: "It's possible to manage host keys from puppet in such a way that each machine will always have an up to date known_hosts file populated by" [tools/scap] - 10https://gerrit.wikimedia.org/r/148112 (owner: 10BryanDavis) [04:22:41] cscott, is there a way to sandbox things in latex? (e.g. to have it reset all styles to the parent on exit of the node?) [04:22:50] because there's going to be a lot of that I fear [04:24:04] it should be sandboxed already. perhaps \textsmall doesn't work the way I think it does, though. [04:25:32] 3MediaWiki-Vagrant: simple_performant file permission problem with NFS - 10https://bugzilla.wikimedia.org/66061#c1 (10Bryan Davis) 5NEW>3RESO/FIX Fixed in I3547698be994d493db74f853d9a14fad85523e82 by removing the unnecessary owner and group settings. [04:27:08] (03PS4) 10Cscott: Render attribution page [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148611 (owner: 10Mwalker) [04:44:59] cscott, Eloquence wants to know what things are left? all I've got on my list is finish up some redis garbage collection, and integrate with the temp dir stuff that we're currently playing with [04:45:52] do we need to do any performance work? did the load test knock anything over? [04:46:15] it'll help, but we have enough horsepower that we should be OK [04:46:24] there's still the 30% reject rate to worry about I guess [04:46:28] still haven't looked at that [04:46:49] then the only thing on my list (after getting patches through gerrit) is fixing rendering issues. which is probably part of that 30% reject rate? [04:46:57] *nods* [04:48:22] (03PS5) 10Cscott: Render attribution page [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148611 (owner: 10Mwalker) [04:55:21] (03CR) 10Cscott: [C: 04-2] "Don't merge this until I've improved handling of infoboxen, etc. Otherwise this gives a net decrease in output quality." [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107587 (owner: 10Cscott) [04:57:04] (03CR) 10Cscott: [C: 04-2] "There's a problem with \RLE in the attribution section (caused by right-to-left usernames). Don't merge until I track this down. (Jenkin" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148611 (owner: 10Mwalker) [05:04:33] (03PS1) 10Cscott: Add -T option to CLI to specify a temporary directory. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149251 [05:07:18] 3Wikimedia / 3SSL related: https://planet.wikimedia.org redirects to http://meta.wikimedia.org/wiki/Planet_Wikimedia - 10https://bugzilla.wikimedia.org/68554 (10chmarkine) 3UNCO p:3Unprio s:3normal a:3None https://planet.wikimedia.org redirects to http://meta.wikimedia.org/wiki/Planet_Wikimedia, rath... [05:08:15] 3Wikimedia / 3SSL related: https://planet.wikimedia.org redirects to http://meta.wikimedia.org/wiki/Planet_Wikimedia - 10https://bugzilla.wikimedia.org/68554 (10chmarkine) [05:09:13] 3Wikimedia / 3Apache configuration: Non-canonical HTTPS URLs quietly redirect to HTTP - 10https://bugzilla.wikimedia.org/31369#c79 (10chmarkine) See Also: https://bugzilla.wikimedia.org/show_bug.cgi?id=68554 [05:18:24] (03CR) 10Florianschmidtwelzow: [C: 04-1] Create preferences to watchlist pages after rollbacking and undoing (031 comment) [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) (owner: 10Ebe123) [05:20:08] (03PS1) 10Cscott: Update test cases with attribution information in the bundle. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149252 [05:25:37] (03PS2) 10Vikassy: WIP: Language screenshot runs only for language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149045 (https://bugzilla.wikimedia.org/68467) [05:32:58] superm401: hey o/ [05:34:55] (03PS9) 10Frédéric Wang: Add default display options [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 (owner: 10Physikerwelt) [05:37:50] (03CR) 10Frédéric Wang: "So I did the changes I mentioned and that works for me on Chrome, Opera Presto (SVG) and Firefox (MathML). I haven't tried on IE, but if t" [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 (owner: 10Physikerwelt) [05:44:36] (03Abandoned) 10Mwalker: Allow unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/148970 (owner: 10Mwalker) [05:45:48] (03CR) 10Mwalker: [C: 032] Allow rendering from unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149220 (owner: 10Cscott) [05:46:13] (03CR) 10Mwalker: [C: 032] Add -T option to CLI to specify a temporary directory. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149251 (owner: 10Cscott) [05:48:45] (03CR) 10Frédéric Wang: "Can you explain more why this is necessary?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/148535 (owner: 10Physikerwelt) [05:50:10] (03CR) 10Frédéric Wang: "Perhaps we want to move the @namespace at the top in this commit, in case this is causing CSS misinterpretation by browsers." [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 (owner: 10Physikerwelt) [05:53:28] (03CR) 10AndyRussG: [C: 04-1] "First of all, congratulations on this feature, that's really sweet!! At first glance the code in this change looks quite clean. Just getti" (033 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/140086 (owner: 10Prtksxna) [05:58:28] (03CR) 10Robert Vogel: [C: 031 V: 031] Implemented changes for translatewiki [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/149027 (owner: 10Smuggli) [06:09:48] (03Abandoned) 10PleaseStand: Fix Installer::showStatusMessage() [core] - 10https://gerrit.wikimedia.org/r/146376 (owner: 10PleaseStand) [06:15:53] (03CR) 10jenkins-bot: [V: 04-1] Allow rendering from unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149220 (owner: 10Cscott) [06:15:55] (03CR) 10jenkins-bot: [V: 04-1] Add -T option to CLI to specify a temporary directory. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149251 (owner: 10Cscott) [06:17:02] (03PS3) 10Mwalker: Allow rendering from unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149220 (owner: 10Cscott) [06:31:45] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c16 (10Matthias Becker) According to comment # 15. Why not make "border" part of "thumb" and introduce "noborder" for explicitely removing all borders on images, where a border... [06:40:43] (03PS1) 10Ori.livneh: run apt-get update at most once every hour [vagrant] - 10https://gerrit.wikimedia.org/r/149254 [06:47:04] (03CR) 10jenkins-bot: [V: 04-1] Allow rendering from unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149220 (owner: 10Cscott) [06:55:21] (03PS1) 10Mwalker: Add a garbage collector to OCG [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149256 [06:55:36] (03CR) 10jenkins-bot: [V: 04-1] Add a garbage collector to OCG [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149256 (owner: 10Mwalker) [06:56:13] (03PS2) 10Mwalker: Add a garbage collector to OCG [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149256 [06:56:42] (03CR) 10Mwalker: [C: 032] Add a garbage collector to OCG [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149256 (owner: 10Mwalker) [06:56:56] (03Merged) 10jenkins-bot: Add a garbage collector to OCG [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149256 (owner: 10Mwalker) [07:00:40] (03CR) 10Legoktm: [C: 032] Differentiate invalid title and invalid site [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148950 (owner: 10Wctaiwan) [07:00:52] (03Merged) 10jenkins-bot: Differentiate invalid title and invalid site [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/148950 (owner: 10Wctaiwan) [07:03:59] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c17 (10Steven Walling) (In reply to Matthias Becker from comment #16) > According to comment # 15. Why not make "border" part of "thumb" and > introduce "noborder" for explicit... [07:04:41] (03PS1) 10Mwalker: Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/149257 [07:05:18] (03CR) 10Mwalker: [C: 032 V: 032] Updating to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/149257 (owner: 10Mwalker) [07:06:45] (03CR) 10Umherirrender: Cleanup some docs (languages, maintenance, tests) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148991 (owner: 10Umherirrender) [07:07:11] (03PS2) 10Divec: Fix socket errors: buffer apertium stdout [services/cxserver] - 10https://gerrit.wikimedia.org/r/148968 [07:07:16] (03CR) 10jenkins-bot: [V: 04-1] Fix socket errors: buffer apertium stdout [services/cxserver] - 10https://gerrit.wikimedia.org/r/148968 (owner: 10Divec) [07:08:40] (03PS1) 10Mwalker: Merge remote-tracking branch 'origin/master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/149258 [07:08:42] (03PS1) 10Mwalker: Updating node_modules [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/149259 [07:08:55] (03CR) 10Mwalker: [C: 032 V: 032] Merge remote-tracking branch 'origin/master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/149258 (owner: 10Mwalker) [07:09:02] (03CR) 10Mwalker: [C: 032 V: 032] Updating node_modules [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/149259 (owner: 10Mwalker) [07:16:11] (03PS1) 10Mwalker: Helps to define the thread type [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149260 [07:16:48] (03CR) 10Mwalker: [C: 032] Helps to define the thread type [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149260 (owner: 10Mwalker) [07:17:11] (03PS1) 10Mwalker: Updating service [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/149261 [07:17:22] (03CR) 10Mwalker: [C: 032 V: 032] Updating service [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/149261 (owner: 10Mwalker) [07:17:56] (03PS1) 10Mwalker: Merge remote-tracking branch 'origin/master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/149262 [07:18:08] (03CR) 10Mwalker: [C: 032 V: 032] Merge remote-tracking branch 'origin/master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/149262 (owner: 10Mwalker) [07:18:30] 3Wikimedia / 3Bugzilla: Add "contenthandler" version to MassMessage component - 10https://bugzilla.wikimedia.org/68555 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Hi, For GSoC, wctaiwan is working on MassMessage in a "contenthandler" branch. Could we have a "contenthandler" version be... [07:19:15] (03CR) 10Umherirrender: "Seems a left over from the old QueryPage before the rewrite in r78786" [core] - 10https://gerrit.wikimedia.org/r/147989 (owner: 10Umherirrender) [07:19:57] 3Wikimedia / 3Mailing lists: Wrong cert on mail.wikipedia.org (as it redirects to lists.wikimedia.org) - 10https://bugzilla.wikimedia.org/44731#c13 (10John Mark Vandenberg) (In reply to Matthew Flaschen from comment #9) > (In reply to Matthew Flaschen from comment #8) > > I'm not sure of GoogleBot's behavior... [07:20:20] (03PS3) 10Divec: Fix socket errors: buffer apertium stdout [services/cxserver] - 10https://gerrit.wikimedia.org/r/148968 [07:20:45] (03CR) 10jenkins-bot: [V: 04-1] Fix socket errors: buffer apertium stdout [services/cxserver] - 10https://gerrit.wikimedia.org/r/148968 (owner: 10Divec) [07:23:55] (03PS5) 10Umherirrender: Add plural to message 'rcnotefrom' [core] - 10https://gerrit.wikimedia.org/r/146053 [07:24:29] (03CR) 10Umherirrender: "Patch Set 5: Rebased and resolved conflict" [core] - 10https://gerrit.wikimedia.org/r/146053 (owner: 10Umherirrender) [07:26:22] (03PS6) 10Umherirrender: Sanitizer::escapeId: Decode entity before replacing spaces [core] - 10https://gerrit.wikimedia.org/r/143477 [07:26:25] (03PS3) 10Pwirth: TopMenuBarCustomizer: Refactoring [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148638 [07:27:17] (03PS6) 10Umherirrender: Fix title handling in User::getCanonicalName [core] - 10https://gerrit.wikimedia.org/r/132610 [07:33:56] (03PS1) 10Aude: Split code for making test RecentChange objects into own class [core] - 10https://gerrit.wikimedia.org/r/149263 [07:34:29] 3Wikimedia / 3Bugzilla: new components for Pywikibot - 10https://bugzilla.wikimedia.org/68514 (10John Mark Vandenberg) [07:34:30] 3Wikimedia / 3Bugzilla: Add pywikibot component(s) for other scripts - 10https://bugzilla.wikimedia.org/68542#c1 (10John Mark Vandenberg) I see a similar request (bug 68514) resulted from a mailing list discussion on pywikipedia-l, but that appears to be a very small subset. [07:35:51] (03PS2) 10Aude: Split code for making test RecentChange objects into own class [core] - 10https://gerrit.wikimedia.org/r/149263 [07:37:52] (03PS1) 10Aude: Remove unused param in RCCacheEntryFactoryTest [core] - 10https://gerrit.wikimedia.org/r/149264 [07:50:19] (03PS2) 10Robert Vogel: [WIP] Moving upload panel/dialog to BSF [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148956 [07:52:14] (03PS2) 10Robert Vogel: [WIP] Moving upload panel/dialog to BSF (Part 2) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148957 [07:52:14] 3MediaWiki extensions / 3Math: Math tests dies when run with the Echo extensions - 10https://bugzilla.wikimedia.org/67148#c10 (10Antoine "hashar" Musso) 5PATC>3NEW Still the same error with latest master of Math Echo and core: not ok 588 - Error: MathDatabaseTest::testCreateTable A database query error... [07:59:43] (03CR) 10PleaseStand: "Note for anyone who might happen to come across this change:" [core] - 10https://gerrit.wikimedia.org/r/148026 (owner: 10Legoktm) [08:10:07] (03PS1) 10Mwalker: Fix is cached template and rerender handling [extensions/Collection] - 10https://gerrit.wikimedia.org/r/149265 [08:12:12] (03PS1) 10Mwalker: Make file moving play nicely [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149266 [08:24:53] (03PS20) 10Eranroz: Add pagination support to watchlist editor [core] - 10https://gerrit.wikimedia.org/r/53968 (https://bugzilla.wikimedia.org/20483) [08:25:44] (03CR) 10Eranroz: Add pagination support to watchlist editor (034 comments) [core] - 10https://gerrit.wikimedia.org/r/53968 (https://bugzilla.wikimedia.org/20483) (owner: 10Eranroz) [08:28:08] (03PS1) 10Rohan013: A more cleaner Special:Watchlist options form [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) [08:28:56] (03PS1) 10Mwalker: Support rerendering a cached job [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149269 [08:29:35] (03CR) 10Mwalker: [C: 032] Make file moving play nicely [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149266 (owner: 10Mwalker) [08:29:41] (03CR) 10Mwalker: [C: 032] Support rerendering a cached job [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149269 (owner: 10Mwalker) [08:29:55] (03Merged) 10jenkins-bot: Make file moving play nicely [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149266 (owner: 10Mwalker) [08:29:57] (03Merged) 10jenkins-bot: Support rerendering a cached job [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149269 (owner: 10Mwalker) [08:30:53] (03PS1) 10Mwalker: Updating with bugfixes [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/149270 [08:31:11] (03CR) 10Mwalker: [C: 032 V: 032] Updating with bugfixes [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/149270 (owner: 10Mwalker) [08:31:23] (03PS1) 10Mwalker: Updating with bugfixes [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/149271 [08:31:31] (03CR) 10Mwalker: [C: 032 V: 032] Updating with bugfixes [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/149271 (owner: 10Mwalker) [08:34:14] 3Wikimedia / 3Site requests: Create new user group on Portuguese Wikipedia of good faith new users - 10https://bugzilla.wikimedia.org/68338#c7 (10rschen7754.wiki) In my opinion, a better solution would be resolving the issues with the overreacting patrollers. I agree with the concerns about having such low p... [08:50:47] (03PS1) 10Smuggli: Implemented changes for translatewiki [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/149272 [08:53:14] (03PS1) 10Wctaiwan: Replace list with (Empty) when all items are removed [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149273 [08:53:23] (03CR) 10jenkins-bot: [V: 04-1] Replace list with (Empty) when all items are removed [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149273 (owner: 10Wctaiwan) [08:54:19] (03PS2) 10Wctaiwan: Replace list with (Empty) when all items are removed [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149273 [08:57:31] 3MediaWiki extensions / 3CodeEditor: [Regression] Disabled CodeEditor prevents toolbar functions to work - 10https://bugzilla.wikimedia.org/68556 (10Michael M.) 3NEW p:3Unprio s:3major a:3None Steps to reproduce: 1. Open any page CodeEditor works on for editing, e.g. https://de.wikipedia.org/w/index.... [09:01:31] 3MediaWiki extensions / 3WikidataRepo: Special:MergeHistory does not work for Wikidata items - 10https://bugzilla.wikimedia.org/68533#c1 (10Aude) /w/index.php?title=Special:MergeHistory&action=submit Exception from line 245 of /usr/local/apache/common-local/php-1.24wmf14/extensions/Wikidata/extensions/Wiki... [09:01:44] 3MediaWiki extensions / 3WikidataRepo: Exception from line 245 in EntityHandler.php: EntityContent does not support plain title based redirects - 10https://bugzilla.wikimedia.org/68517#c1 (10Aude) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68533 *** [09:01:44] 3MediaWiki extensions / 3WikidataRepo: Special:MergeHistory does not work for Wikidata items - 10https://bugzilla.wikimedia.org/68533#c2 (10Aude) *** Bug 68517 has been marked as a duplicate of this bug. *** [09:02:01] 3MediaWiki extensions / 3CodeEditor: Disabling CodeEditor while not logged in throws JavaScript error - 10https://bugzilla.wikimedia.org/68557 (10Michael M.) 3NEW p:3Unprio s:3minor a:3None Steps to reproduce: 1. Log out, open a page CodeEditor works on for editing. 2. Click the CodeEditor icon to di... [09:04:38] (03PS3) 10Wctaiwan: Replace list with (None) when all items are removed [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149273 [09:09:15] 3MediaWiki extensions / 3CirrusSearch: Call to a member function isRedirect() on a non-object in Updater.php - 10https://bugzilla.wikimedia.org/68558 (10Aude) 3NEW p:3Unprio s:3normal a:3None spotted in the logs: Fatal error: Call to a member function isRedirect() on a non-object at /usr/local/apach... [09:10:45] (03PS3) 10Vikassy: Language screenshot runs only for language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149045 (https://bugzilla.wikimedia.org/68467) [09:14:33] 3MediaWiki / 3General/Unknown: Can not clear watch list - 10https://bugzilla.wikimedia.org/68559 (10Dalba) 3UNCO p:3Unprio s:3normal a:3None My bot has nearly 45,000 pages in its watch list. Now that I want to clear/edit my watch list I get the following error: ``` Wikimedia Foundation Error Our se... [09:21:45] (03PS1) 10Robert Vogel: ExtendedSearch: Autocomplete white background [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/149278 [09:24:42] 3MediaWiki extensions / 3WikidataRepo: Special:MergeHistory does not work for Wikidata items - 10https://bugzilla.wikimedia.org/68533#c3 (10Daniel Kinzler) Seems like Special:MergeHistory is trying to create a redirect, but we don't support "plain" redirects for Wikibase entities (and can't, really). Some ki... [09:41:53] (03CR) 10Nikerabbit: Refactored duplicated code into JobRunner.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149175 (owner: 10Aaron Schulz) [09:53:48] (03CR) 10Nikerabbit: "Just FYI I think CACHE_ANYTHING is inadequate to support all the various use cases. Some want to have permanent storage and are less inter" [core] - 10https://gerrit.wikimedia.org/r/117091 (owner: 10MaxSem) [10:01:10] (03CR) 10Nemo bis: A more cleaner Special:Watchlist options form (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) (owner: 10Rohan013) [10:01:33] (03PS2) 10Nemo bis: Cleaner Special:Watchlist options form [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) (owner: 10Rohan013) [10:02:24] (03CR) 10Nemo bis: "Release notes?" [core] - 10https://gerrit.wikimedia.org/r/149175 (owner: 10Aaron Schulz) [10:08:20] (03PS3) 10Nemo bis: Default $wgMainCacheType to CACHE_ANYTHING [core] - 10https://gerrit.wikimedia.org/r/117091 (owner: 10MaxSem) [10:10:06] (03PS31) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [10:10:24] (03PS32) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [10:17:48] (03PS1) 10Mwalker: More friendly redis names [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149284 [10:17:50] (03PS1) 10Mwalker: Timing breakdowns for backend [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149285 [10:18:12] (03CR) 10Mwalker: [C: 032] More friendly redis names [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149284 (owner: 10Mwalker) [10:18:21] (03PS25) 10Paladox: Update jquery.mockjax.js to v1.5.3 [core] - 10https://gerrit.wikimedia.org/r/139693 [10:18:26] (03Merged) 10jenkins-bot: More friendly redis names [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149284 (owner: 10Mwalker) [10:18:28] (03CR) 10Mwalker: [C: 032] Timing breakdowns for backend [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149285 (owner: 10Mwalker) [10:18:55] (03PS23) 10Paladox: Update jquery.form.js [core] - 10https://gerrit.wikimedia.org/r/139688 [10:18:57] (03Merged) 10jenkins-bot: Timing breakdowns for backend [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149285 (owner: 10Mwalker) [10:20:45] (03PS28) 10Paladox: Update jQuery.appear.js [core] - 10https://gerrit.wikimedia.org/r/139470 [10:23:49] (03CR) 10Nemo bis: "The meeting in question was https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-03-05 ; it only has a couple lines on the" [core] - 10https://gerrit.wikimedia.org/r/117091 (owner: 10MaxSem) [10:26:16] 3Wikimedia / 3General/Unknown: Add export-0.8 to http://www.mediawiki.org/xml/ - 10https://bugzilla.wikimedia.org/68561 (10This, that and the other) 3NEW p:3Unprio s:3normal a:3None export-0.8 has existed for a while now, just needs an entry in the index page. I would write a patch but I don't know w... [10:50:17] (03CR) 10Zfilipin: [C: 032] Run language screenshot job manually [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149012 (owner: 10Vikassy) [10:50:29] 3MediaWiki extensions / 3CodeEditor: [Regression] Disabled CodeEditor prevents toolbar functions to work - 10https://bugzilla.wikimedia.org/68556#c1 (10Derk-Jan Hartman) Are we sure that that is a regression ? Because if a take a peek at textSelection, it seems like it would have done that in the past as wel... [10:51:43] (03Merged) 10jenkins-bot: Run language screenshot job manually [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149012 (owner: 10Vikassy) [10:57:51] (03PS4) 10Zfilipin: Language screenshot runs only for language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149045 (https://bugzilla.wikimedia.org/68467) (owner: 10Vikassy) [10:59:19] (03PS1) 10Hashar: Remove some duplicate newlines in wfDebug() [core] - 10https://gerrit.wikimedia.org/r/149288 [11:10:37] (03PS2) 10Rillke: Remove some duplicate newlines in call to wfDebug() [core] - 10https://gerrit.wikimedia.org/r/149288 (owner: 10Hashar) [11:12:06] (03PS20) 10Paladox: Update jQuery Cookie to v1.3.1 [core] - 10https://gerrit.wikimedia.org/r/145884 [11:12:18] (03PS21) 10Paladox: Update jQuery Cookie to v1.3.1 [core] - 10https://gerrit.wikimedia.org/r/145884 [11:12:26] (03PS22) 10Paladox: Update jQuery Cookie to v1.3.1 [core] - 10https://gerrit.wikimedia.org/r/145884 [11:13:13] (03CR) 10Paladox: "Remove release notes for 1.24 so that when 1.25 is ready it can be added to 1.25 release notes." [core] - 10https://gerrit.wikimedia.org/r/145884 (owner: 10Paladox) [11:13:32] 3MediaWiki extensions / 3CodeEditor: Disabling CodeEditor while not logged in throws JavaScript error - 10https://bugzilla.wikimedia.org/68557 (10Derk-Jan Hartman) a:3Derk-Jan Hartman [11:13:50] (03CR) 10Bartosz Dziewoński: "I never said "spectacularly explode", I said "cause very weird, hard-to-debug rendering quirks". Also, people are going to hate you for do" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148529 (owner: 10Jdlrobson) [11:14:57] 3MediaWiki extensions / 3Extensions requests: Pre-packaged templates for new MediaWiki installs - 10https://bugzilla.wikimedia.org/56388#c18 (10Rob Kam) See bug 50329 - We need a common repository for Scribunto modules and templates instead. [11:19:21] (03CR) 10Smuggli: [C: 032 V: 032] ExtendedSearch: Autocomplete white background [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/149278 (owner: 10Robert Vogel) [11:20:14] (03PS67) 10Paladox: Update jquery.hoverIntent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [11:20:34] (03PS68) 10Paladox: Update jquery.hoverIntent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [11:20:44] (03PS69) 10Paladox: Update jquery.hoverIntent to 1.8.0 [core] - 10https://gerrit.wikimedia.org/r/139687 [11:22:01] 3MediaWiki / 3Export/Import: Namespace name of source automatically converted to that of destination in import log - 10https://bugzilla.wikimedia.org/62821#c5 (10This, that and the other) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 40192 *** [11:22:01] 3MediaWiki / 3Export/Import: Transwiki import summary link uses local namespace name which may not be defined on source wiki - 10https://bugzilla.wikimedia.org/40192#c3 (10This, that and the other) *** Bug 62821 has been marked as a duplicate of this bug. *** [11:22:15] (03PS26) 10Paladox: Update jquery.chosen folder and files [core] - 10https://gerrit.wikimedia.org/r/139699 [11:24:58] 3Wikimedia / 3General/Unknown: Add export-0.8 to http://www.mediawiki.org/xml/ - 10https://bugzilla.wikimedia.org/68561#c1 (10Sam Reed (reedy)) p:5Unprio>3Normal s:5normal>3enhanc https://github.com/wikimedia/operations-mediawiki-config/tree/master/docroot/mediawiki/xml It's already there, but not o... [11:27:12] (03CR) 10Zfilipin: [C: 04-1] Language screenshot runs only for language screenshot job (032 comments) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149045 (https://bugzilla.wikimedia.org/68467) (owner: 10Vikassy) [11:28:03] 3Wikimedia / 3General/Unknown: Add export-0.8 to http://www.mediawiki.org/xml/ - 10https://bugzilla.wikimedia.org/68561 (10Sam Reed (reedy)) 5PATC>3RESO/FIX a:3Sam Reed (reedy) [11:28:34] (03PS1) 10Smuggli: Added new sections to credits [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/149290 [11:30:28] 3MediaWiki / 3Export/Import: Special:Import displays wrong links to imported articles - 10https://bugzilla.wikimedia.org/11344#c3 (10This, that and the other) 5NEW>3RESO/FIX Import of such pages (wikipedia:Foo etc) would now be disallowed as an invalid title, unless you specify a target namespace or root... [11:32:31] 3MediaWiki / 3Export/Import: Special:Import displays wrong links to imported articles - 10https://bugzilla.wikimedia.org/11344#c4 (10This, that and the other) *** Bug 15918 has been marked as a duplicate of this bug. *** [11:32:31] 3MediaWiki / 3Export/Import: Import may link to the wrong location - 10https://bugzilla.wikimedia.org/15918#c4 (10This, that and the other) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 11344 *** [11:34:55] (03PS5) 10Vikassy: Language screenshot runs only for language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149045 (https://bugzilla.wikimedia.org/68467) [11:37:20] (03PS6) 10Vikassy: Language screenshot runs only for language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149045 (https://bugzilla.wikimedia.org/68467) [11:37:34] (03CR) 10Hashar: "Bryan wrote:" [tools/scap] - 10https://gerrit.wikimedia.org/r/148112 (owner: 10BryanDavis) [11:40:23] (03PS7) 10Vikassy: Language screenshot runs only for language screenshot job [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149045 (https://bugzilla.wikimedia.org/68467) [11:42:15] (03PS3) 10Rohan013: Cleaner Special:Watchlist options form [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) [11:42:28] 3Wikimedia / 3General/Unknown: Add export-0.8 to http://www.mediawiki.org/xml/ - 10https://bugzilla.wikimedia.org/68561#c4 (10This, that and the other) Thanks :) [11:43:16] (03CR) 10Rohan013: "Fixed ':' i18n/l10n issue" [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) (owner: 10Rohan013) [11:47:35] (03CR) 10Qgil: "This is a very old patch that got a +1 more than a year ago. Does it look like good to merge?" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/47902 (owner: 10MaxSem) [11:50:59] 3MediaWiki extensions / 3WikidataRepo: Implement wbcreateredirect API module - 10https://bugzilla.wikimedia.org/65584 (10tobias.gritschacher) 5PATC>3RESO/FIX [11:53:21] (03CR) 10Qgil: ""I'm only doing the 2 most critical fixes from bug 25619 for now so that they can be quickly reviewed and merged." -- yet this (now old) p" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/97304 (https://bugzilla.wikimedia.org/25619) (owner: 10Kaldari) [11:54:36] (03CR) 10Rillke: Cleaner Special:Watchlist options form (036 comments) [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) (owner: 10Rohan013) [11:55:29] 3MediaWiki extensions / 3AntiSpoof: Add more characters to ccnorm - 10https://bugzilla.wikimedia.org/25619#c16 (10Quim Gil) Both patches are still open. The first one got some reviews and now it looks like is waiting for a new upload from Kaldari. The second one with the simpler version got no reviews at all. [11:56:37] (03CR) 10Rillke: [C: 04-1] "Per remaining comments in PS 2." [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) (owner: 10Rohan013) [11:58:14] (03CR) 10Rillke: Cleaner Special:Watchlist options form (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) (owner: 10Rohan013) [12:00:33] (03PS2) 10Joeytje50: Version 1.1: Add Android Browser support [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/145559 [12:07:43] (03CR) 10Nemo bis: "Yes, it would be better to keep the link bookmarkable. And it's absolutely necessary for the switches without a corresponding preference. " [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) (owner: 10Rohan013) [12:10:34] (03CR) 10Calak: [C: 031] Add Simple English translation to Persian [extensions/cldr] - 10https://gerrit.wikimedia.org/r/148971 (owner: 10Reza) [12:13:26] (03PS7) 10Rillke: Sanitizer::escapeId: Decode entity before replacing spaces [core] - 10https://gerrit.wikimedia.org/r/143477 (owner: 10Umherirrender) [12:13:32] (03PS2) 10Smuggli: Added new sections to credits [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/149290 [12:14:44] (03PS3) 10Smuggli: Added new sections to credits [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/149290 [12:16:05] 3MediaWiki extensions / 3WikidataRepo: SnakUnserializer must not fail on mismatching hashes - 10https://bugzilla.wikimedia.org/68565 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs SnakUnserializer will check the hash of the unserialized snak against the snak field in the serialization,... [12:16:23] (03PS2) 10Zfilipin: No longer running Ruby linter for Wikibase [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148988 [12:17:30] (03PS2) 10Zfilipin: WIP Moved the first Wikidata job from WMDE Jenkins [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147093 [12:19:10] (03PS2) 10TTO: Remove unused XMLReader2 class [core] - 10https://gerrit.wikimedia.org/r/148958 [12:19:12] (03PS1) 10TTO: Add word "imported" to history/log summary during import [core] - 10https://gerrit.wikimedia.org/r/149292 [12:19:14] (03PS1) 10TTO: Proper namespace handling for WikiImporter [core] - 10https://gerrit.wikimedia.org/r/149293 (https://bugzilla.wikimedia.org/30723) [12:22:17] 3MediaWiki extensions / 3WikidataRepo: SnakUnserializer must not fail on mismatching hashes - 10https://bugzilla.wikimedia.org/68565#c1 (10Daniel Kinzler) p:5Unprio>3High s:5normal>3critic Setting to "critical", because it blocks the switch to the new data model. [12:25:00] (03CR) 10TTO: "Will need release notes for the hook change, although I'd like to do thatin a follow-up - I waste too much of my life rebasing release not" [core] - 10https://gerrit.wikimedia.org/r/149293 (https://bugzilla.wikimedia.org/30723) (owner: 10TTO) [12:25:48] 3MediaWiki / 3Maintenance scripts: deleteOldRevisions.php delete content date - 10https://bugzilla.wikimedia.org/66615#c7 (10sen) (In reply to Jesús Martínez Novo (Ciencia Al Poder) from comment #6) > JavaScript error console has nothing to do here IMHO > > When you move a page, it creates a new revision, b... [12:28:33] (03Abandoned) 10TTO: Make the link in import log entry always use canonical namespace [core] - 10https://gerrit.wikimedia.org/r/84197 (https://bugzilla.wikimedia.org/40192) (owner: 10TTO) [12:31:42] 3MediaWiki / 3Export/Import: Indicate if an import failed due to revision limit on export - 10https://bugzilla.wikimedia.org/6646#c7 (10This, that and the other) For reference, this seems to be talking about transwiki import (not XML-upload) hitting the revision limit on the export side, and this fact not be... [12:32:12] (03CR) 10Rillke: "Why isn't this merged, yet?" [core] - 10https://gerrit.wikimedia.org/r/149065 (owner: 10Umherirrender) [12:32:18] 3MediaWiki / 3Revision deletion: Give sysops deleterevision rights by default - 10https://bugzilla.wikimedia.org/68298#c4 (10Vogone) (In reply to Nathan Larson from comment #3) > (In reply to Vogone from comment #2) > > I'd prefer that it be dealt with as a separate bug. I think that sysops will > have more... [12:33:19] (03CR) 10Rillke: "missed the dependency..." [core] - 10https://gerrit.wikimedia.org/r/149065 (owner: 10Umherirrender) [12:36:10] (03CR) 10Smuggli: [C: 04-1] TopMenuBarCustomizer: Refactoring (033 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148638 (owner: 10Pwirth) [12:40:34] 3MediaWiki extensions / 3CirrusSearch: Call to a member function isRedirect() on a non-object in Updater.php - 10https://bugzilla.wikimedia.org/68558 (10Nik Everett) 5NEW>3ASSI p:5Unprio>3Highes a:3Nik Everett [12:41:40] (03CR) 10Phuedx: [C: 031] "PS7 fixes the Firefox issue for me. Retested in Chrome (36.0.1985.125), Firefox (31.0), Safari (7.0.5), and IE8/9." [core] - 10https://gerrit.wikimedia.org/r/146979 (https://bugzilla.wikimedia.org/41484) (owner: 10Robmoen) [12:48:32] 3MediaWiki extensions / 3WikidataRepo: SnakUnserializer must not fail on mismatching hashes - 10https://bugzilla.wikimedia.org/68565 (10Lydia Pintscher) [12:49:56] (03PS4) 10Rohan013: Cleaner Special:Watchlist options form [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) [12:54:03] (03PS1) 10Manybubbles: Stop tracing redirects on invalid content [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/149297 (https://bugzilla.wikimedia.org/68558) [12:54:42] (03CR) 10Manybubbles: "I'd love to add an integration test for this but I imagine its not possible to make data that broken with MediaWiki as it stands now." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/149297 (https://bugzilla.wikimedia.org/68558) (owner: 10Manybubbles) [12:58:10] (03CR) 10Rillke: SpecialVersion: Handle Closures in $wgHooks nicer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148922 (owner: 10Legoktm) [12:58:59] 3MediaWiki extensions / 3WikidataRepo: Allow redirects to be detected/resolved in bulk via the EntityInfoBuilder class - 10https://bugzilla.wikimedia.org/66972 (10Daniel Kinzler) 5ASSI>3RESO/FIX [13:00:59] 3MediaWiki extensions / 3ContactPage: Integration with the ConfirmEdit extension no longer works since version 2.x - 10https://bugzilla.wikimedia.org/66811#c1 (10Sam Reed (reedy)) I "removed" it when re-writing it https://github.com/wikimedia/mediawiki-extensions-ContactPage/commit/a92f78ebcd60d2b9f97f145aac... [13:01:03] (03PS3) 10Zfilipin: WIP Moved the first Wikidata job from WMDE Jenkins [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147093 [13:01:58] (03PS2) 10Rohan013: Show Page moves on Special:Newpages [core] - 10https://gerrit.wikimedia.org/r/148322 (https://bugzilla.wikimedia.org/12363) [13:05:16] 3MediaWiki / 3Revision deletion: Fatal error: Call to a member function getBits() on a non-object in SpecialRevisiondelete.php on line 166 - 10https://bugzilla.wikimedia.org/68566 (10Aude) 3NEW p:3Unprio s:3normal a:3None happens on test.wikidata, but presumably not on wikipedia / wikidata yet. Fata... [13:06:40] (03PS3) 10Rohan013: Show Page moves on Special:Newpages [core] - 10https://gerrit.wikimedia.org/r/148322 (https://bugzilla.wikimedia.org/12363) [13:08:30] 3MediaWiki extensions / 3WikidataRepo: Make EntityView UI aware of redirects - 10https://bugzilla.wikimedia.org/68567 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Redirects should be marked as such in the EntityView. Broken redirects must also be considered. We may also want a "resol... [13:08:46] 3MediaWiki extensions / 3WikidataRepo: Make EntityView UI aware of redirects - 10https://bugzilla.wikimedia.org/68567 (10Daniel Kinzler) [13:08:46] 3MediaWiki extensions / 3WikidataRepo: Don't treat referenced entities that are redirects as deleted in the UI - 10https://bugzilla.wikimedia.org/66971#c3 (10Daniel Kinzler) 5PATC>3RESO/FIX verified locally [13:08:46] 3MediaWiki extensions / 3WikidataRepo: Support Redirects between Items (tracking) - 10https://bugzilla.wikimedia.org/66067 (10Daniel Kinzler) [13:08:49] (03PS1) 10Aude: Improvements to RCCacheEntryFactoryTest and helper class [core] - 10https://gerrit.wikimedia.org/r/149304 [13:08:51] (03PS1) 10Aude: Add some tests for OldChangesList [core] - 10https://gerrit.wikimedia.org/r/149305 [13:09:42] 3MediaWiki / 3Revision deletion: Fatal error: Call to a member function getBits() on a non-object in SpecialRevisiondelete.php on line 166 - 10https://bugzilla.wikimedia.org/68566#c1 (10Sam Reed (reedy)) Line 166: $bitfield = $list->current()->getBits(); /** * Get the current list item, or... [13:11:04] https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:master+topic:changes,n,z [13:11:17] hoo: DanielK_WMDE_ if you want to do code review ^ [13:11:35] * aude adding more test coverage before further poking here [13:12:40] (03CR) 10Rillke: Cleaner Special:Watchlist options form (033 comments) [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) (owner: 10Rohan013) [13:13:06] (03CR) 10Rillke: [C: 031] Cleaner Special:Watchlist options form (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) (owner: 10Rohan013) [13:14:15] aude: Is that about the core bug you mentioned earlier? [13:14:21] hoo: no [13:14:24] but that's how i found it [13:14:38] ah, I see [13:16:17] we shouldn't use assertTag anymore so i'm using assertRegExp instead [13:16:35] assertTag is being removed soon in phpunit [13:17:27] yikes [13:17:33] yeah [13:17:44] so i have to rework the RCCacheEntry thing [13:17:55] and then want to add tests for other things [13:18:01] Wikibase]$ grep -r assertTag\( | wc -l [13:18:01] 26 [13:18:08] yep [13:18:35] mostly in special pages tests and changes formatting [13:23:49] (03CR) 10Yurik: "i think it was used for debugging and I forgot to remove it later. At some point should probably recheck that expected counts still work a" [core] - 10https://gerrit.wikimedia.org/r/50930 (owner: 10Yurik) [13:24:12] (03PS4) 10Zfilipin: WIP Moved the first Wikidata job from WMDE Jenkins [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/147093 [13:26:44] 3MediaWiki / 3Revision deletion: Fatal error: Call to a member function getBits() on a non-object in SpecialRevisiondelete.php on line 166 - 10https://bugzilla.wikimedia.org/68566#c2 (10Aude) https://gerrit.wikimedia.org/r/#/c/139277/ appears to be where this broke [13:28:08] (03CR) 10Hoo man: Remove @todo in SpecialPage for making it into ContextSource (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148996 (owner: 10Aude) [13:28:30] (03PS11) 10Ebe123: Create preferences to watchlist pages after rollbacking and undoing [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) [13:31:16] (03CR) 10Zfilipin: [C: 04-1] Language screenshot runs only for language screenshot job (031 comment) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149045 (https://bugzilla.wikimedia.org/68467) (owner: 10Vikassy) [13:55:35] (03CR) 10Cscott: "recheck" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149220 (owner: 10Cscott) [14:00:59] (03PS2) 10Cscott: Add -T option to CLI to specify a temporary directory. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149251 [14:08:45] 3MediaWiki / 3Revision deletion: Fatal error: Call to a member function getBits() on a non-object in SpecialRevisiondelete.php on line 166 - 10https://bugzilla.wikimedia.org/68566#c3 (10Aude) the query for the revision is looking in the archive table while the revision is not there (it's in the revision table) [14:13:52] Reedy: probably csteipp or vogone should fix https://bugzilla.wikimedia.org/show_bug.cgi?id=68566 [14:13:58] or can do revert then fix [14:14:13] * aude finds the code slightly confusing [14:14:34] commented in the bug [14:14:49] legoktm: https://gerrit.wikimedia.org/r/144656 [14:14:58] please be more careful when doing code review [14:15:09] you let people follow wrong paths there... [14:15:23] using an API module class as a static pile of code is not nice at all [14:15:29] you should have pointed that out, at least [14:20:52] (03CR) 10Daniel Kinzler: [C: 032] Add some tests for OldChangesList [core] - 10https://gerrit.wikimedia.org/r/149305 (owner: 10Aude) [14:24:03] (03CR) 10Cscott: [C: 032] "Poke jenkins to get it to resubmit." [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149220 (owner: 10Cscott) [14:26:15] (03Merged) 10jenkins-bot: Allow rendering from unzipped bundle [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149220 (owner: 10Cscott) [14:26:17] (03Merged) 10jenkins-bot: Add -T option to CLI to specify a temporary directory. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149251 (owner: 10Cscott) [14:28:42] 3Wikimedia / 3Bugzilla: add component for jouncebot - 10https://bugzilla.wikimedia.org/68549#c4 (10Andre Klapper) For future reference: https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_project_or_component [14:31:16] (03CR) 10Ebe123: Create preferences to watchlist pages after rollbacking and undoing (031 comment) [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) (owner: 10Ebe123) [14:36:49] (03CR) 10Daniel Kinzler: [C: 032] Improvements to RCCacheEntryFactoryTest and helper class [core] - 10https://gerrit.wikimedia.org/r/149304 (owner: 10Aude) [14:39:08] (03CR) 10Cscott: [C: 04-1] Create attribution page (031 comment) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 (owner: 10Mwalker) [14:39:41] (03PS20) 10Cscott: Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 (owner: 10Mwalker) [14:41:31] 3MediaWiki / 3Revision deletion: Fatal error: Call to a member function getBits() on a non-object in SpecialRevisiondelete.php on line 166 - 10https://bugzilla.wikimedia.org/68566#c4 (10Aude) looked again and for querying the revision table, it's doing: SELECT rev_id,rev_page,rev_text_id,rev_timestamp,rev_... [14:46:46] 3MediaWiki / 3Watchlist: Clearing large (39k+) watchlist @ Special:EditWatchlist/clear fails, HTTP error 503 - 10https://bugzilla.wikimedia.org/66212#c10 (10Andre Klapper) *** Bug 68559 has been marked as a duplicate of this bug. *** [14:46:51] 3MediaWiki / 3General/Unknown: Can not clear watch list - 10https://bugzilla.wikimedia.org/68559#c1 (10Andre Klapper) 5UNCO>3RESO/DUP Hi Dalba. Thanks for taking the time to report this! This particular problem has already been reported into our bug tracking system, but please feel free to report any fur... [14:48:17] 3Wikimedia / 3Bugzilla: Add pywikibot component(s) for other scripts - 10https://bugzilla.wikimedia.org/68542#c2 (10Andre Klapper) Has this been discussed with the other maintainers? +1 welcome. For general info what's needed: https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_projec... [14:49:13] 3MediaWiki / 3Revision deletion: Fatal error: Call to a member function getBits() on a non-object in SpecialRevisiondelete.php on line 166 - 10https://bugzilla.wikimedia.org/68566#c5 (10Aude) the title passed to RevDelRevisionList appears to be Special:RevisionDelete, hence rev_page = 0 [14:53:12] 3MediaWiki / 3General/Unknown: SqlBagOStuff.php on line 232 / Invalid argument supplied for foreach() - 10https://bugzilla.wikimedia.org/56661#c3 (10Umherirrender) 5NEW>3RESO/FIX (In reply to Umherirrender from comment #2) > Maybe fixed by Gerrit change #141619 Now merged, should be fixed. [14:53:42] 3MediaWiki / 3Unit tests: PHP unit tests don't work if not run from tests/phpunit directory - "Call to a member function numRows() on a non-object" - 10https://bugzilla.wikimedia.org/56909#c4 (10Umherirrender) 5NEW>3RESO/FIX (In reply to Umherirrender from comment #3) > Maybe fixed by Gerrit change #1416... [14:53:49] (03CR) 10Daniel Kinzler: [C: 04-1] "Please make smaller functions, and explain some more why TitleValue won't do." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/149293 (https://bugzilla.wikimedia.org/30723) (owner: 10TTO) [15:08:13] 3MediaWiki extensions / 3WikidataRepo: SnakUnserializer must not fail on mismatching hashes - 10https://bugzilla.wikimedia.org/68565 (10Lydia Pintscher) 5NEW>3ASSI [15:08:29] 3MediaWiki / 3Special pages: Make "Special:UnusedFiles" appear like "Special:ListFiles" - 10https://bugzilla.wikimedia.org/68575 (10[[kgh]]) 3NEW p:3Unprio s:3enhanc a:3None I think it will be great to have "Special:UnusedFiles" appear like "Special:ListFiles" to at least allows some kind of sorting... [15:11:12] 3MediaWiki / 3Special pages: Make "Special:UnusedFiles" appear like "Special:ListFiles" - 10https://bugzilla.wikimedia.org/68575#c1 (10[[kgh]]) Oh my gosh, full of typos: allows -> allow and suggesting -> suggestion. [15:11:24] (03CR) 10Nemo bis: "(I'll finish reading the patch later.)" [core] - 10https://gerrit.wikimedia.org/r/149293 (https://bugzilla.wikimedia.org/30723) (owner: 10TTO) [15:15:48] (03PS1) 10Cscott: Respect metabook lang setting when localizing attributions page. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149318 [15:16:12] 3MediaWiki / 3Special pages: Make "Special:UnusedFiles" appear like "Special:ListFiles" - 10https://bugzilla.wikimedia.org/68575#c2 (10[[kgh]]) In case the miser mode note [1] applies for the user name selection, too doing it without this option is still heaps better than the current state of the page. [1]... [15:17:39] (03CR) 10Cscott: [C: 04-2] "Some images in the multiwiki.zip bundle appear to be corrupt. Investigating." [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/149252 (owner: 10Cscott) [15:20:02] (03CR) 10Cscott: [C: 032] Use `jpegtran` to purge EXIF data from jpegs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138149 (owner: 10Cscott) [15:21:29] (03CR) 10BryanDavis: "hashar wrote:" [tools/scap] - 10https://gerrit.wikimedia.org/r/148112 (owner: 10BryanDavis) [15:22:29] (03Merged) 10jenkins-bot: Use `jpegtran` to purge EXIF data from jpegs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138149 (owner: 10Cscott) [15:22:58] (03PS1) 10Manybubbles: Upgrade to Elasticsearch 1.3.0 [search/highlighter] - 10https://gerrit.wikimedia.org/r/149319 [15:35:43] (03CR) 10BryanDavis: [C: 032] "Neat puppet trick! It takes a bit of reading in the docs to get an idea of how it really works. The doc for the metaparameter [0] says you" [vagrant] - 10https://gerrit.wikimedia.org/r/149254 (owner: 10Ori.livneh) [15:35:50] (03Merged) 10jenkins-bot: run apt-get update at most once every hour [vagrant] - 10https://gerrit.wikimedia.org/r/149254 (owner: 10Ori.livneh) [15:44:04] (03PS1) 10Cmcmahon: make new build for Math extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149323 [15:45:54] (03CR) 10Alex Monk: [C: 032] Fix incorrect variable name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149208 (https://bugzilla.wikimedia.org/68552) (owner: 10Bsitu) [15:46:07] (03Merged) 10jenkins-bot: Fix incorrect variable name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149208 (https://bugzilla.wikimedia.org/68552) (owner: 10Bsitu) [15:46:33] 3MediaWiki extensions / 3Collection: Reduce density from 600 ppi/dpi - 10https://bugzilla.wikimedia.org/68576 (10Nemo) 3NEW p:3Unprio s:3enhanc a:3None I see http://www.imagemagick.org/script/command-line-options.php#density is currently set at 600 dpi. https://gerrit.wikimedia.org/r/#/c/138149/7/lib... [15:46:52] (03CR) 10Nemo bis: "jpegtran is nice, I used it to un-progressive-fy many Commons files super-quick. :-)" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/138149 (owner: 10Cscott) [15:51:42] 3MediaWiki extensions / 3Collection: Reduce density from 600 ppi/dpi - 10https://bugzilla.wikimedia.org/68576#c1 (10C. Scott Ananian) 5NEW>3RESO/INV That -density argument doesn't do what you think it does. It just edits the EXIF metadata, it doesn't affect the file contents at all. It's necessary beca... [15:51:47] (03CR) 10Cmcmahon: "Bug 67221" [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149323 (owner: 10Cmcmahon) [15:52:09] (03CR) 10GWicke: [C: 032] Allow to push changes. A lot of contributions (2000 commits) have no changeIds and did not go though gerrit and probably won't go trough ger [services/mathoid] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/147870 (owner: 10Physikerwelt) [15:52:20] (03PS2) 10Cmcmahon: make new build for Math extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149323 [15:54:44] (03PS1) 1001tonythomas: Changed static function modules in the API class to another class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/149324 [15:57:48] (03CR) 10Krinkle: "@MaxSem: That's exactly the point I'm making. It's not a matter of adding a release note, that's just the process that naturally enforces " [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143320 (owner: 10Paladox) [15:58:05] (03PS1) 10Aude: Move adjustment of revision delete target in SpecialRevisiondelete to fix fatal [core] - 10https://gerrit.wikimedia.org/r/149325 (https://bugzilla.wikimedia.org/68566) [15:58:44] (03Abandoned) 10Krinkle: mediawiki.searchSuggest: Enable for iPhone and iPod touch [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/143320 (owner: 10Paladox) [15:58:57] (03PS1) 10Cmcmahon: Add job for PageTriage tests [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149327 [15:59:16] (03PS1) 10Alex Monk: Fix incorrect variable name [extensions/Echo] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149328 (https://bugzilla.wikimedia.org/68552) [15:59:36] Seems like your way or the highway [15:59:39] (03PS1) 10Alex Monk: Fix incorrect variable name [extensions/Echo] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149329 (https://bugzilla.wikimedia.org/68552) [16:00:10] (03PS2) 10Aude: Move adjustment of revision delete target in SpecialRevisiondelete to fix fatal [core] - 10https://gerrit.wikimedia.org/r/149325 (https://bugzilla.wikimedia.org/68566) [16:02:15] (03PS2) 10Zfilipin: Add job for PageTriage tests [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149327 (https://bugzilla.wikimedia.org/67134) (owner: 10Cmcmahon) [16:02:43] (03PS3) 10Zfilipin: The first job for Math extension [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149323 (https://bugzilla.wikimedia.org/67221) (owner: 10Cmcmahon) [16:04:56] (03CR) 10Hoo man: [C: 032] Move adjustment of revision delete target in SpecialRevisiondelete to fix fatal [core] - 10https://gerrit.wikimedia.org/r/149325 (https://bugzilla.wikimedia.org/68566) (owner: 10Aude) [16:05:42] 3MediaWiki / 3Revision deletion: Fatal error: Call to a member function getBits() on a non-object in SpecialRevisiondelete.php on line 166 - 10https://bugzilla.wikimedia.org/68566 (10Marius Hoch) 5PATC>3RESO/FIX [16:06:58] (03PS1) 10Cscott: Fetch authors in larger batches; fetch authors for specific article revid. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149330 [16:07:24] (03Merged) 10jenkins-bot: Move adjustment of revision delete target in SpecialRevisiondelete to fix fatal [core] - 10https://gerrit.wikimedia.org/r/149325 (https://bugzilla.wikimedia.org/68566) (owner: 10Aude) [16:07:31] hoo|away: Reedy does someone want to adopt https://gerrit.wikimedia.org/r/#/c/149325/ for swat on monday? [16:07:38] * aude on holiday [16:07:51] usually someone has to be around [16:08:13] aude: I can take care of it [16:08:17] great [16:08:39] if i have some time, i might try to make some basic tests for the special page [16:08:43] added a note so that I don't forget [16:08:45] it's quite complex though [16:08:55] yeah, it's an overly complex thing [16:10:03] i'll put it on swat [16:11:24] (03PS2) 10Manybubbles: Upgrade to Elasticsearch 1.3.0 [search/highlighter] - 10https://gerrit.wikimedia.org/r/149319 [16:16:48] (03PS2) 1001tonythomas: Changed static function modules in the API class to another class [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/149324 [16:22:24] (03CR) 10Physikerwelt: [C: 031] The first job for Math extension (032 comments) [integration/jenkins-job-builder-config] (cloudbees) - 10https://gerrit.wikimedia.org/r/149323 (https://bugzilla.wikimedia.org/67221) (owner: 10Cmcmahon) [16:23:42] (03PS1) 10EBernhardson: Remove double edit when taking over talkpage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149337 [16:26:10] (03PS1) 10Cscott: Skip wikitext fetch when `--no-compat` option is given. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149338 [16:27:59] (03CR) 10jenkins-bot: [V: 04-1] Skip wikitext fetch when `--no-compat` option is given. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149338 (owner: 10Cscott) [16:29:30] (03PS2) 10Cscott: Skip wikitext fetch when `--no-compat` option is given. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149338 [16:34:21] (03PS4) 10Physikerwelt: Fix: id-attribute [extensions/Math] - 10https://gerrit.wikimedia.org/r/148535 [16:35:38] (03CR) 10jenkins-bot: [V: 04-1] Fix: id-attribute [extensions/Math] - 10https://gerrit.wikimedia.org/r/148535 (owner: 10Physikerwelt) [16:36:15] (03CR) 10Gilles: Attaching Hooks to tweak MIME type detection (031 comment) [extensions/MolHandler] - 10https://gerrit.wikimedia.org/r/141241 (owner: 10Rillke) [16:37:44] (03PS5) 10Physikerwelt: Fix: id-attribute [extensions/Math] - 10https://gerrit.wikimedia.org/r/148535 [16:38:38] (03CR) 10jenkins-bot: [V: 04-1] Fix: id-attribute [extensions/Math] - 10https://gerrit.wikimedia.org/r/148535 (owner: 10Physikerwelt) [16:41:30] (03PS2) 10Aude: Add some tests for OldChangesList [core] - 10https://gerrit.wikimedia.org/r/149305 [16:41:32] (03PS2) 10Aude: Improvements to RCCacheEntryFactoryTest and helper class [core] - 10https://gerrit.wikimedia.org/r/149304 [16:41:34] (03PS3) 10Aude: Split code for making test RecentChange objects into own class [core] - 10https://gerrit.wikimedia.org/r/149263 [16:41:36] (03PS2) 10Aude: Remove unused param in RCCacheEntryFactoryTest [core] - 10https://gerrit.wikimedia.org/r/149264 [16:41:38] (03PS1) 10Aude: Add $logAction param for test recent changes helper [core] - 10https://gerrit.wikimedia.org/r/149340 [16:41:40] (03PS1) 10Aude: Add test case for recent changes flags in OldChangesList [core] - 10https://gerrit.wikimedia.org/r/149341 [16:41:42] (03PS1) 10Aude: Add @todo note in OldChangesListTest [core] - 10https://gerrit.wikimedia.org/r/149342 [16:41:44] (03CR) 10EBernhardson: [C: 032] Remove undocumented css [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149203 (https://bugzilla.wikimedia.org/67833) (owner: 10Jdlrobson) [16:42:11] bah [16:42:27] should be ok [16:42:35] (03PS6) 10Physikerwelt: Fix: id-attribute [extensions/Math] - 10https://gerrit.wikimedia.org/r/148535 [16:43:28] (03CR) 10Krinkle: "Yes, though without all the prefixes. Just compare against getUrl's return value directly. You may want to use mw.Uri to turn it into an a" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/146477 (https://bugzilla.wikimedia.org/68039) (owner: 10Se4598) [16:44:17] (03CR) 10Cscott: "@mwalker: would you might doing a quick look over this and +2'ing it? I've tested that it works with the latest version of https://gerrit" [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 (owner: 10Mwalker) [16:44:38] (03CR) 10Krinkle: "I don't know how http://webcloud.se/jQuery-Collapse/ is related to any of this. More likely we won't be using javascript at all (even mor" [core] - 10https://gerrit.wikimedia.org/r/145911 (owner: 10Paladox) [16:44:57] (03PS8) 10Krinkle: Vector: Add back collaspibleNav module [core] - 10https://gerrit.wikimedia.org/r/145911 (https://bugzilla.wikimedia.org/39035) (owner: 10Paladox) [16:45:18] (03PS5) 10EBernhardson: Hide load more button with JavaScript when infinite scroll supports [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145470 (owner: 10Jdlrobson) [16:45:49] (03CR) 10Cscott: [C: 032] Use proper page of any PDF figure. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/143564 (owner: 10Cscott) [16:45:57] (03PS9) 10Krinkle: Vector: Add back collaspibleNav module [core] - 10https://gerrit.wikimedia.org/r/145911 (https://bugzilla.wikimedia.org/67954) (owner: 10Paladox) [16:46:07] (03CR) 10Aude: Remove @todo in SpecialPage for making it into ContextSource (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148996 (owner: 10Aude) [16:47:27] (03Abandoned) 10Krinkle: Vector: Add back collaspibleNav module [core] - 10https://gerrit.wikimedia.org/r/145911 (https://bugzilla.wikimedia.org/67954) (owner: 10Paladox) [16:47:45] 3MediaWiki / 3Skin and page rendering: Vector: Remove slow collapsibleNav module - 10https://bugzilla.wikimedia.org/39035 (10Krinkle) 5PATC>3RESO/FIX [16:48:10] (03Merged) 10jenkins-bot: Use proper page of any PDF figure. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/143564 (owner: 10Cscott) [16:48:12] * Nemo_bis relieved [16:51:54] (03CR) 10EBernhardson: [C: 04-1] "I get the same problem as shahyar. Adding a break point inside isEndNear and letting it trigger at the top of the page I get this: http:" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145470 (owner: 10Jdlrobson) [16:52:03] (03CR) 10Jforrester: "Or we could just go back to saying "Please deploy"?" [wikimedia/bots/jouncebot] - 10https://gerrit.wikimedia.org/r/149202 (owner: 10Dzahn) [16:53:42] (03CR) 10Physikerwelt: "voila" [extensions/Math] - 10https://gerrit.wikimedia.org/r/148535 (owner: 10Physikerwelt) [16:55:29] 3Wikimedia / 3Site requests: 300GB of files on a hard disk in need of a URI or WMF direct upload - 10https://bugzilla.wikimedia.org/67477#c18 (10jeremyb) shipment is RT 8007. Fae is generating file description pages now and those can be uploaded to to tool labs to be used with the images on the HDD. Who wan... [17:00:14] (03CR) 10EBernhardson: "Whats happening is that in chrome $end.offset().top === $( window ).scrollTop() when $end is display: none. Sounds like a bug in chrome b" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/145470 (owner: 10Jdlrobson) [17:01:35] (03PS3) 10Physikerwelt: Move @namespace css style to top [extensions/Math] - 10https://gerrit.wikimedia.org/r/147865 [17:02:42] (03CR) 10Aaron Schulz: [C: 032] Cleanup some docs (includes/[e-l]) [core] - 10https://gerrit.wikimedia.org/r/149063 (owner: 10Umherirrender) [17:05:36] (03Merged) 10jenkins-bot: Cleanup some docs (includes/[e-l]) [core] - 10https://gerrit.wikimedia.org/r/149063 (owner: 10Umherirrender) [17:11:40] (03CR) 10Aaron Schulz: [C: 032] Cleanup some docs (includes/[m-r]) [core] - 10https://gerrit.wikimedia.org/r/149064 (owner: 10Umherirrender) [17:11:45] (03CR) 10Gilles: Split BitmapHandler into two classes. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/147718 (owner: 10Brian Wolff) [17:13:35] (03PS3) 10Aaron Schulz: Refactored duplicated code into JobRunner.php [core] - 10https://gerrit.wikimedia.org/r/149175 [17:14:55] (03Merged) 10jenkins-bot: Cleanup some docs (includes/[m-r]) [core] - 10https://gerrit.wikimedia.org/r/149064 (owner: 10Umherirrender) [17:15:01] (03CR) 10Physikerwelt: "I'm not against this change, but my goal is to improve the Math rendering for the visitors and provide MathML as output to them or if thei" [extensions/Math] - 10https://gerrit.wikimedia.org/r/149089 (owner: 10Cscott) [17:15:06] (03Merged) 10jenkins-bot: Cleanup some docs (includes/[s-z]) [core] - 10https://gerrit.wikimedia.org/r/149065 (owner: 10Umherirrender) [17:18:47] (03PS7) 10Physikerwelt: Fix: id-attribute [extensions/Math] - 10https://gerrit.wikimedia.org/r/148535 [17:19:31] (03PS10) 10Physikerwelt: Add default display options [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 [17:21:31] (03CR) 10Siebrand: [C: 04-1] "Please separate the updates in en.json from the rest of the patch. There are no issues with it, and they can be merged without changing th" [core] - 10https://gerrit.wikimedia.org/r/149293 (https://bugzilla.wikimedia.org/30723) (owner: 10TTO) [17:21:34] (03CR) 10Physikerwelt: ""Perhaps we want to move the @namespace at the top in this commit, in case this is causing CSS misinterpretation by browsers."" [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 (owner: 10Physikerwelt) [17:23:21] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/146440 (https://bugzilla.wikimedia.org/4488) (owner: 10Ebe123) [17:26:15] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) (owner: 10Rohan013) [17:27:47] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/145559 (owner: 10Joeytje50) [17:28:11] (03PS4) 10Ori.livneh: Refactored duplicated code into JobRunner.php [core] - 10https://gerrit.wikimedia.org/r/149175 (owner: 10Aaron Schulz) [17:28:28] (03CR) 10Siebrand: [C: 032] Add word "imported" to history/log summary during import [core] - 10https://gerrit.wikimedia.org/r/149292 (owner: 10TTO) [17:28:41] (03PS2) 10Siebrand: Add word "imported" to history/log summary during import [core] - 10https://gerrit.wikimedia.org/r/149292 (owner: 10TTO) [17:28:49] (03CR) 10Siebrand: [C: 032] Add word "imported" to history/log summary during import [core] - 10https://gerrit.wikimedia.org/r/149292 (owner: 10TTO) [17:29:33] (03PS1) 10EBernhardson: Prevent cross-wiki exception on newbie query [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149345 [17:29:48] (03CR) 10Ori.livneh: [C: 032] "> Release notes?" [core] - 10https://gerrit.wikimedia.org/r/149175 (owner: 10Aaron Schulz) [17:30:16] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/149290 (owner: 10Smuggli) [17:30:42] (03CR) 10Siebrand: [C: 032] Add Simple English translation to Persian [extensions/cldr] - 10https://gerrit.wikimedia.org/r/148971 (owner: 10Reza) [17:30:51] (03Merged) 10jenkins-bot: Add Simple English translation to Persian [extensions/cldr] - 10https://gerrit.wikimedia.org/r/148971 (owner: 10Reza) [17:31:32] MaxSem: hey seeing some prod exceptions for /wiki/Special:MobileDiff/1047997 which say 'Diff not implemented for Flow\Content\BoardContent'. This is correct(no diff possible), wondering what you think we should do about it? [17:32:35] (03Merged) 10jenkins-bot: Add word "imported" to history/log summary during import [core] - 10https://gerrit.wikimedia.org/r/149292 (owner: 10TTO) [17:33:31] (03Merged) 10jenkins-bot: Refactored duplicated code into JobRunner.php [core] - 10https://gerrit.wikimedia.org/r/149175 (owner: 10Aaron Schulz) [17:33:56] ebernhardson, implement a "diff" that just outputs a "no diff possible" message? [17:34:42] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149273 (owner: 10Wctaiwan) [17:35:02] MaxSem: sounds reasonable enough, will do :) [17:37:50] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/149272 (owner: 10Smuggli) [17:38:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/149027 (owner: 10Smuggli) [17:39:46] 3MediaWiki extensions / 3Translate: Show [edit]-link if needed - 10https://bugzilla.wikimedia.org/68578 (10Steinsplitter) 3NEW p:3Unprio s:3enhanc a:3None Create some magic word/function to enable the section [edit] link. This is needed if editable subpages are included in a TA-Page. [17:40:44] 3Wikimedia / 3Bugzilla: Add "contenthandler" version to MassMessage component - 10https://bugzilla.wikimedia.org/68555 (10Tyler Romeo) 5NEW>3ASSI p:5Unprio>3Normal a:3Tyler Romeo [17:41:10] (03CR) 1020after4: "Does beta run from it's own puppet repository? I could probably set it up pretty easily." [tools/scap] - 10https://gerrit.wikimedia.org/r/148112 (owner: 10BryanDavis) [17:41:41] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (034 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148987 (owner: 10Smuggli) [17:41:59] 3Wikimedia / 3Bugzilla: Add "contenthandler" version to MassMessage component - 10https://bugzilla.wikimedia.org/68555#c1 (10Tyler Romeo) I'm afraid Bugzilla does not allow us to change versions by component. We can only add versions for an entire product (i.e., I'd have to add the "contenthandler" version t... [17:42:11] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/148979 (owner: 10Smuggli) [17:42:14] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c18 (10James Forrester) (In reply to Erik Moeller from comment #15) > What's the issue with the following: > > "50px|border|Some text" behaves as before > "50px|Some text" beh... [17:42:40] (03PS4) 10Wctaiwan: Replace list with (None) when all items are removed [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149273 [17:42:56] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/146428 (owner: 10Smuggli) [17:43:27] twentyafterfour: Yes and no. Beta has a puppetmaster on deployment-salt. It serves the operations/puppet.git production branch with locally applied patches to let us change things before someone with +2 in the upstream gets around to merging. [17:43:46] (03CR) 10Siebrand: [C: 04-1] "Patch depends on an abandoned patch set. This should be rebased." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148976 (owner: 10Smuggli) [17:44:18] (03CR) 10Catrope: [C: 032] Wrap redirectpagesub in a [core] - 10https://gerrit.wikimedia.org/r/148883 (owner: 10Alex Monk) [17:44:23] (03CR) 10Siebrand: "i18n/L10n reviewed. Looks fine." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/148976 (owner: 10Smuggli) [17:45:23] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/149265 (owner: 10Mwalker) [17:45:41] (03PS5) 10Rohan013: Cleaner Special:Watchlist options form [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) [17:45:43] (03CR) 10Physikerwelt: [C: 032] "Thank you works amazing. Tested via" [extensions/Math] - 10https://gerrit.wikimedia.org/r/145453 (owner: 10Physikerwelt) [17:46:04] (03CR) 10Rohan013: "i18n/l10n issues fixed" [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) (owner: 10Rohan013) [17:47:20] (03Merged) 10jenkins-bot: Wrap redirectpagesub in a [core] - 10https://gerrit.wikimedia.org/r/148883 (owner: 10Alex Monk) [17:47:28] 3MediaWiki extensions / 3Translate: Translation page does not contain the latest translations/last translation - 10https://bugzilla.wikimedia.org/46716#c19 (10Steinsplitter) p:5Low>3Normal It is a problem that FuzzyBot didn't sync language subpages with the (newly) marked translatable page. [17:48:07] (03PS4) 10BearND: Add blue flag icon for article/page issues links [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148866 [17:49:10] (03CR) 10Siebrand: [C: 032] Add plural to message 'rcnotefrom' [core] - 10https://gerrit.wikimedia.org/r/146053 (owner: 10Umherirrender) [17:50:12] (03PS5) 10Siebrand: Replace list with "(none)" when all items are removed [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149273 (owner: 10Wctaiwan) [17:50:21] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149273 (owner: 10Wctaiwan) [17:50:47] (03CR) 10BryanDavis: "twentyafterfour: Yes and no. Beta has a puppetmaster on deployment-salt. It serves the operations/puppet.git production branch with locall" [tools/scap] - 10https://gerrit.wikimedia.org/r/148112 (owner: 10BryanDavis) [17:52:04] (03CR) 10MaxSem: Fix is cached template and rerender handling (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/149265 (owner: 10Mwalker) [17:52:21] (03Merged) 10jenkins-bot: Add plural to message 'rcnotefrom' [core] - 10https://gerrit.wikimedia.org/r/146053 (owner: 10Umherirrender) [17:52:41] bd808: it looks like it's as simple as adding deployment-salt to the list in ops/puppet/modules/ssh/manifests/hostkeys-collect.pp:4 [17:53:09] (03CR) 10Siebrand: [WIP] Interstitial notification page for renamed users (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [17:53:28] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c19 (10Fabrice Florin) Hi guys, thanks for your interesting ideas for improving the user experience around thumbnails. Could we please hold off on making quick decisions on thi... [17:53:34] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/148420 (https://bugzilla.wikimedia.org/67995) (owner: 10BryanDavis) [17:54:02] (03PS11) 10Physikerwelt: Add width and height to SVG image [extensions/Math] - 10https://gerrit.wikimedia.org/r/144939 (https://bugzilla.wikimedia.org/20202) [17:54:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 (owner: 10Werdna) [17:54:26] twentyafterfour: Ah. Cool. 'deployment-bastion' would be the host we really want them collected on. That's the beta equivalent of 'tin' [17:55:17] you wanna try it or should I? if you want me to, I need to know where puppet sources are and whatnot, I've never even logged in to deployment-bastion [17:55:38] twentyafterfour: So the way hashar and I have been doing changes like this is to make the patch, submit to gerrit, and then cherry-pick on the beta puppet master [17:55:55] * AaronSchulz wonders why gwt adds a bunch of cookies [17:56:18] twentyafterfour: A lot of what you'd want to know is documented at https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/How_code_is_updated#Converting_a_host_to_use_local_puppetmaster_and_salt_master [17:56:42] twentyafterfour: err... https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/How_code_is_updated#Cherry-picking_a_patch_from_gerrit [17:57:02] (03CR) 10Siebrand: [C: 04-1] "Per Max." (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/149265 (owner: 10Mwalker) [17:57:41] twentyafterfour: The best way for you to get comfortable is to dive in and start doing. :) [17:58:46] (03CR) 10Mwalker: Fix is cached template and rerender handling (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/149265 (owner: 10Mwalker) [17:58:57] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149268 (https://bugzilla.wikimedia.org/48615) (owner: 10Rohan013) [17:59:54] (03CR) 10Physikerwelt: "@Frédéric: So what's your opinion here. Do you see any realistic near future alternatives to the regexp approach?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/144939 (https://bugzilla.wikimedia.org/20202) (owner: 10Physikerwelt) [17:59:56] (03CR) 10Siebrand: Add onbeforeunload handler when navigating away from unsubmitted changes (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148983 (owner: 10SG) [18:00:32] 3MediaWiki extensions / 3Spam Blacklist: Warning: file_get_contents(): Peer certificate CN=`*.wikipedia.org' did not match expected CN=`meta.wikimedia.org' in .../extensions/SpamBlacklist/BaseBlacklist.php on line 273 - 10https://bugzilla.wikimedia.org/68581 (10Liangent) 3NEW p:3Unprio s:3normal a:3No... [18:01:10] (03PS2) 10Mwalker: Fix is cached template and rerender handling [extensions/Collection] - 10https://gerrit.wikimedia.org/r/149265 [18:01:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/148563 (owner: 10Bsitu) [18:05:03] (03CR) 10Scott-linder: "Sorry for the delay, I've only got time to work on this around the weekends." [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [18:06:06] (03CR) 10Siebrand: Fix is cached template and rerender handling (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/149265 (owner: 10Mwalker) [18:07:43] 3MediaWiki extensions / 3Spam Blacklist: regex expressions starting with caret (^) not functioning as per instructions say - 10https://bugzilla.wikimedia.org/64541#c3 (10Liangent) (In reply to billinghurst from comment #2) > The regex suggested while functional for a regex is unsuccessful in > preventing add... [18:09:35] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/145899 (https://bugzilla.wikimedia.org/57238) (owner: 10Ebe123) [18:10:28] 3Wikimedia / 3Bugzilla: Add "contenthandler" version to MassMessage component - 10https://bugzilla.wikimedia.org/68555#c2 (10Kunal Mehta (Legoktm)) 5ASSI>3RESO/FIX (In reply to Tyler Romeo from comment #1) > I'm afraid Bugzilla does not allow us to change versions by component. We > can only add versions... [18:12:26] (03PS3) 10Umherirrender: Parser: Clean up handling of editsections by using local variables [core] - 10https://gerrit.wikimedia.org/r/144182 [18:12:43] (03PS4) 10Umherirrender: Use Database::makeWhereFrom2d in LinkHolderArray::replaceInternal [core] - 10https://gerrit.wikimedia.org/r/143713 [18:13:00] (03PS5) 10Umherirrender: SpecialEditWatchlist: Avoid empty namespace sections [core] - 10https://gerrit.wikimedia.org/r/143363 [18:13:18] (03PS9) 10Umherirrender: Always escape 'word-separator' and 'parentheses' messages [core] - 10https://gerrit.wikimedia.org/r/136161 [18:14:50] (03PS8) 10Umherirrender: Sanitizer::escapeId: Decode entity before replacing spaces [core] - 10https://gerrit.wikimedia.org/r/143477 [18:15:03] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/SimpleChanges] - 10https://gerrit.wikimedia.org/r/148884 (owner: 10tosfos) [18:16:36] (03PS1) 10Jdlrobson: Remove concept of a default compiler [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 [18:17:11] (03CR) 10Siebrand: [C: 032] Making use of Special:MyLanguage for Terms of Use and Privacy links [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148881 (owner: 10Kaldari) [18:17:25] (03Merged) 10jenkins-bot: Making use of Special:MyLanguage for Terms of Use and Privacy links [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/148881 (owner: 10Kaldari) [18:17:50] (03CR) 10Jdlrobson: [C: 04-1] "Not to be merged until Icb9352e422dc105ac769bbe0db7e5525895204c7 is merged." [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 (owner: 10Jdlrobson) [18:17:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/149265 (owner: 10Mwalker) [18:18:45] (03CR) 10jenkins-bot: [V: 04-1] Remove concept of a default compiler [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 (owner: 10Jdlrobson) [18:18:53] (03CR) 10MaxSem: "The puppet change will be committed when we agree upon config format;)" [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148280 (owner: 10MaxSem) [18:19:33] (03PS2) 10Aaron Schulz: Made Special:RunJobs work for private wikis [core] - 10https://gerrit.wikimedia.org/r/149111 [18:25:58] (03CR) 10Legoktm: SpecialVersion: Handle Closures in $wgHooks nicer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/148922 (owner: 10Legoktm) [18:27:39] bd808: twentyafterfour is not allowed to run sudo on deployment-salt. This incident will be reported. [18:27:54] lame. Let's fix that [18:28:11] (03PS4) 10MaxSem: Configuration rewrite, part 1 [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148280 [18:28:22] (03CR) 10Aaron Schulz: "I already started messing around with https://gerrit.wikimedia.org/r/#/c/149362/." [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148280 (owner: 10MaxSem) [18:28:33] (03CR) 10Siebrand: Add grant for access to private information (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/139042 (https://bugzilla.wikimedia.org/66493) (owner: 10CSteipp) [18:28:49] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/139042 (https://bugzilla.wikimedia.org/66493) (owner: 10CSteipp) [18:29:06] (03CR) 10Bsimmers: Fixes per CR on github (031 comment) [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148523 (owner: 10MaxSem) [18:30:05] (03CR) 10Cscott: "I will probably fork texvc at some point then, so I can have a consistent input/output spec that all of texvc/texvccheck/texvcjs implement" [extensions/Math] - 10https://gerrit.wikimedia.org/r/149089 (owner: 10Cscott) [18:30:10] twentyafterfour: try it now? [18:30:30] twentyafterfour: The magic place to fix such issues is https://wikitech.wikimedia.org/wiki/Special:NovaSudoer [18:30:41] bd808: fixed thanks [18:30:51] You had not been added to the "under_NDA" sudoers group [18:33:07] There's NDA stuff in deployment-prep? [18:34:49] (03PS1) 10Bsitu: Clicking on 'Edit title' leads to edit title page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149365 [18:35:58] (03PS7) 10Phuedx: Configure logged in session length independently [core] - 10https://gerrit.wikimedia.org/r/141248 (https://bugzilla.wikimedia.org/66699) [18:36:23] (03Abandoned) 10Hashar: PMD job for mediawiki/core [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/130657 (owner: 10Hashar) [18:36:28] <^d> Krenair: zomg logs! ip addresses! [18:36:34] ahhh. :D [18:37:14] bd808|MEETING: Duplicate declaration: Package[python-gitdb] is already declared; cannot redeclare at /etc/puppet/modules/deployment/manifests/deployment_server.pp:26 on node i-0000010b.eqiad.wmflabs [18:37:45] (03PS5) 10MaxSem: Fixes per CR on github [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148523 [18:37:47] (03PS2) 10Hashar: Triggers for mediawiki/extensions/PhpTagsWiki [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/146023 (owner: 10BryanDavis) [18:37:55] (03CR) 10Hashar: [C: 032] "Long overdue. sorry." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/146023 (owner: 10BryanDavis) [18:38:00] (03Merged) 10jenkins-bot: Triggers for mediawiki/extensions/PhpTagsWiki [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/146023 (owner: 10BryanDavis) [18:38:54] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/149366 [18:38:59] twentyafterfour: Can you track down the cause? [18:39:00] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/149366 (owner: 10Hashar) [18:39:15] trying to [18:39:22] cool [18:40:35] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/149366 (owner: 10Hashar) [18:42:06] (03PS4) 10Hashar: Make PageTriage tests voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148135 (https://bugzilla.wikimedia.org/68205) (owner: 10MaxSem) [18:42:51] (03PS5) 10Hashar: Make PageTriage tests voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148135 (https://bugzilla.wikimedia.org/68205) (owner: 10MaxSem) [18:42:59] (03CR) 10Hashar: [C: 032] Make PageTriage tests voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148135 (https://bugzilla.wikimedia.org/68205) (owner: 10MaxSem) [18:43:04] (03Merged) 10jenkins-bot: Make PageTriage tests voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148135 (https://bugzilla.wikimedia.org/68205) (owner: 10MaxSem) [18:44:29] (03CR) 10Hashar: [C: 032] "Well done!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148989 (owner: 10Zfilipin) [18:44:42] (03PS2) 10Hashar: No longer running any jobs for qa/browsertests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148989 (owner: 10Zfilipin) [18:44:48] (03CR) 10Hashar: [C: 032] No longer running any jobs for qa/browsertests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148989 (owner: 10Zfilipin) [18:44:52] (03Merged) 10jenkins-bot: No longer running any jobs for qa/browsertests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148989 (owner: 10Zfilipin) [18:46:23] (03PS3) 10Hashar: Add zuul config for a bunch of extensions I maintain [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148352 (owner: 10Legoktm) [18:46:33] (03PS2) 10Jdlrobson: Remove concept of a default compiler [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 [18:46:41] (03CR) 10jenkins-bot: [V: 04-1] Remove concept of a default compiler [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 (owner: 10Jdlrobson) [18:47:15] (03CR) 10Hashar: [C: 032] "Jenkins jobs are already around \O/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148352 (owner: 10Legoktm) [18:47:22] (03Merged) 10jenkins-bot: Add zuul config for a bunch of extensions I maintain [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148352 (owner: 10Legoktm) [18:47:29] (03CR) 10Bsimmers: [C: 04-1] Fixes per CR on github (031 comment) [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148523 (owner: 10MaxSem) [18:49:01] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/149369 [18:49:20] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/149370 [18:49:22] (03CR) 10Phuedx: "> It seems like the better way to do this would be to see if the user" [core] - 10https://gerrit.wikimedia.org/r/141248 (https://bugzilla.wikimedia.org/66699) (owner: 10Phuedx) [18:49:35] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/149371 [18:49:56] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/149372 [18:50:16] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/149373 [18:50:40] (03PS6) 10MaxSem: Fixes per CR on github [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148523 [18:52:04] (03CR) 10Hashar: "recheck" [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/149371 (owner: 10Hashar) [18:53:41] (03PS1) 10Hashar: Typo in GlobalUserPage repo name [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/149375 [18:54:12] (03CR) 10Hashar: Add zuul config for a bunch of extensions I maintain (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148352 (owner: 10Legoktm) [18:54:27] (03CR) 10Hashar: [C: 032] Typo in GlobalUserPage repo name [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/149375 (owner: 10Hashar) [18:54:32] (03Merged) 10jenkins-bot: Typo in GlobalUserPage repo name [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/149375 (owner: 10Hashar) [18:54:48] (03CR) 10Hashar: "recheck" [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/149371 (owner: 10Hashar) [18:55:02] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/149371 (owner: 10Hashar) [18:55:12] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/149370 (owner: 10Hashar) [18:55:17] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/149369 (owner: 10Hashar) [18:55:21] (03PS1) 10Cicalese: removed fragment from title before query [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/149377 [18:55:23] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/149372 (owner: 10Hashar) [18:55:26] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/149373 (owner: 10Hashar) [18:55:49] (03CR) 10Hashar: "And all tests passes! As shown on https://gerrit.wikimedia.org/r/#/q/I672574386c11979398da6c52baac0dabf4064e89,n,z" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148352 (owner: 10Legoktm) [18:57:15] (03CR) 10Cicalese: [C: 032 V: 032] removed fragment from title before query [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/149377 (owner: 10Cicalese) [19:02:04] (03CR) 10Aaron Schulz: [C: 04-1] "One more thing" (031 comment) [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148280 (owner: 10MaxSem) [19:02:40] (03CR) 10Bsimmers: [C: 031] Fixes per CR on github [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148523 (owner: 10MaxSem) [19:04:22] (03PS3) 10Hashar: No longer running Ruby linter for Wikibase [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148988 (owner: 10Zfilipin) [19:05:13] (03PS5) 10MaxSem: Configuration rewrite, part 1 [services/jobrunner] - 10https://gerrit.wikimedia.org/r/148280 [19:06:04] (03PS1) 10Hashar: No longer running Ruby linter for Wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/149379 [19:06:17] (03CR) 10Hashar: [C: 032] "JJB clean up in https://gerrit.wikimedia.org/r/149379" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148988 (owner: 10Zfilipin) [19:06:25] (03Merged) 10jenkins-bot: No longer running Ruby linter for Wikibase [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148988 (owner: 10Zfilipin) [19:06:28] (03CR) 10Hashar: [C: 032] No longer running Ruby linter for Wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/149379 (owner: 10Hashar) [19:07:04] (03CR) 10Hashar: "And job mwext-Wikibase-ruby1.9.3lint deleted manually. \O/" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148988 (owner: 10Zfilipin) [19:09:38] (03PS1) 10Umherirrender: Rename Preprocessor_DOM/Preprocessor_Hash to PreprocessorDOM/PreprocessorHash [core] - 10https://gerrit.wikimedia.org/r/149382 [19:12:00] 3MediaWiki-Vagrant: HHVM Failed Assertion: assertion `false && "Unsupported DataType"' failed. - 10https://bugzilla.wikimedia.org/68491#c2 (10Brett Simmers) 5ASSI>3RESO/FIX This is fixed on hhvm master as of https://github.com/facebook/hhvm/commit/8e83cdd3230c732b28a1f66dd37750054e76d4eb [19:13:08] (03CR) 10Ori.livneh: [C: 032] Fixes per CR on github [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148523 (owner: 10MaxSem) [19:23:24] (03CR) 10Hashar: [C: 04-1] "The jobs proposed in integration/jenkins-jobs-config.git needs to be manually deployed. That requires a labs account which is a member of" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/144456 (owner: 10Phuedx) [19:27:44] 3MediaWiki / 3Export/Import: Importing does not work with HHVM - 10https://bugzilla.wikimedia.org/66023#c2 (10Brett Simmers) 5NEW>3ASSI a:3Brett Simmers This is being fixed by https://github.com/facebook/hhvm/pull/3249 [19:28:28] (03Merged) 10jenkins-bot: No longer running Ruby linter for Wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/149379 (owner: 10Hashar) [19:29:50] I wonder what that bot does [19:31:23] Hm. https://code.google.com/p/pircbotx/ [19:32:07] (03PS3) 10EBernhardson: Formatter Fix for related Echo change [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148011 (owner: 10Bsitu) [19:32:08] It might be here for jenkins fail notifications [19:32:12] yeah, pircbotx is a generic irc framework. I wonder what his specific instance on gallium does [19:32:15] But I don't think we ever configure those to happen. [19:32:17] (03PS5) 10EBernhardson: Add Flow notification to 'message' notification section [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148571 (owner: 10Bsitu) [19:32:31] hashar probably knows, but is a vacances. [19:32:38] Or...not [19:32:48] this* [19:32:50] (03PS2) 10Jdlrobson: Remove undocumented css [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149203 (https://bugzilla.wikimedia.org/67833) [19:32:58] (03CR) 10Jdlrobson: [C: 032] Remove undocumented css [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149203 (https://bugzilla.wikimedia.org/67833) (owner: 10Jdlrobson) [19:33:31] (03Merged) 10jenkins-bot: Remove undocumented css [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149203 (https://bugzilla.wikimedia.org/67833) (owner: 10Jdlrobson) [19:34:01] Yeah, Krenair, confirmed in -staff that it's Jenkins. [19:34:21] Er...maybe. [19:34:30] 3MediaWiki / 3Export/Import: Importing does not work with HHVM - 10https://bugzilla.wikimedia.org/66023#c3 (10MWJames) When do we expect to land this in the Travis hhvm-nightly? Our tests [0] running on HipHop VM 3.3.0-dev+2014.07.23 (rel) still fail for the import part! [0] https://travis-ci.org/SemanticMe... [19:34:35] vacances = french for holiday? [19:34:36] Yeah [19:34:41] Krenair: Yes, to both. [19:35:34] 3MediaWiki / 3Parser: HHVM: Array to string conversion in Parser.php - 10https://bugzilla.wikimedia.org/65830#c2 (10Brett Simmers) Are you sure this is hhvm only? Is there a consistent repro? [19:37:50] (03PS2) 10Hashar: Rename Preprocessor_DOM/Preprocessor_Hash [core] - 10https://gerrit.wikimedia.org/r/149382 (owner: 10Umherirrender) [19:38:09] (03CR) 10Hashar: "trivial commit message to retrigger tests" [core] - 10https://gerrit.wikimedia.org/r/149382 (owner: 10Umherirrender) [19:40:59] (03PS2) 10Hashar: Adding test support for wikimedia/bots/jouncebot [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/149206 (owner: 10Mwalker) [19:41:58] (03CR) 10jenkins-bot: [V: 04-1] Rename Preprocessor_DOM/Preprocessor_Hash [core] - 10https://gerrit.wikimedia.org/r/149382 (owner: 10Umherirrender) [19:42:13] (03CR) 10Hashar: [C: 032] "Jobs created following http://www.mediawiki.org/wiki/CI/JJB" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/149206 (owner: 10Mwalker) [19:43:14] (03PS2) 10Hashar: Adding test support for wikimedia/bots/jouncebot [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/149207 (owner: 10Mwalker) [19:43:22] (03CR) 10Hashar: [C: 032] "Excellent!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/149207 (owner: 10Mwalker) [19:43:27] (03Merged) 10jenkins-bot: Adding test support for wikimedia/bots/jouncebot [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/149207 (owner: 10Mwalker) [19:43:30] (03Merged) 10jenkins-bot: Adding test support for wikimedia/bots/jouncebot [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/149206 (owner: 10Mwalker) [19:44:25] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/bots/jouncebot] - 10https://gerrit.wikimedia.org/r/149387 [19:44:28] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [wikimedia/bots/jouncebot] - 10https://gerrit.wikimedia.org/r/149387 (owner: 10Hashar) [19:44:54] (03CR) 10Hashar: "pep8 / pyflakes fails :-(" [wikimedia/bots/jouncebot] - 10https://gerrit.wikimedia.org/r/149387 (owner: 10Hashar) [19:45:37] (03CR) 10EBernhardson: [C: 031] "Looks like this isn't blocked by the related change, rather this allows flow to work both before and after the echo change?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148011 (owner: 10Bsitu) [19:46:10] (03CR) 10EBernhardson: [C: 031] "Merging this should have no effect on echo, it will just ignore the new 'section' key until the new echo code drops." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148571 (owner: 10Bsitu) [19:48:20] (03PS3) 10Umherirrender: Rename Preprocessor_DOM/Preprocessor_Hash [core] - 10https://gerrit.wikimedia.org/r/149382 [19:48:54] (03CR) 10Umherirrender: "Patch Set 3: Fixed parser tests. Should search over all files in the repo, not only php and inc." [core] - 10https://gerrit.wikimedia.org/r/149382 (owner: 10Umherirrender) [19:53:48] (03CR) 10Parent5446: Configure logged in session length independently (032 comments) [core] - 10https://gerrit.wikimedia.org/r/141248 (https://bugzilla.wikimedia.org/66699) (owner: 10Phuedx) [19:55:16] (03CR) 10Yuvipanda: [C: 04-1] "In addition, aren't we also not going to set these styles on non-enwiki at all? Wouldn't that need a class set on head and a conditional b" (032 comments) [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148866 (owner: 10BearND) [19:57:01] (03CR) 10Ori.livneh: [C: 032 V: 032] Revert "Derive FastStringSearchResource from ResourceData, not SweepableResourceData" [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/148534 (owner: 10MaxSem) [20:00:33] 3MediaWiki / 3Skin and page rendering: Images with border parameter should display captions - 10https://bugzilla.wikimedia.org/68468#c20 (10Tisza Gergő) > "50px|border|Some text" behaves as before > "50px|Some text" behaves as before > "200px|thumb|Some text" has new styling > "200px|thumb|border|Some text"... [20:02:29] (03PS3) 10Ori.livneh: Made Special:RunJobs work for private wikis [core] - 10https://gerrit.wikimedia.org/r/149111 (owner: 10Aaron Schulz) [20:02:34] (03CR) 10Ori.livneh: [C: 032] Made Special:RunJobs work for private wikis [core] - 10https://gerrit.wikimedia.org/r/149111 (owner: 10Aaron Schulz) [20:04:29] (03CR) 10Chad: [C: 032] Move more escaping logic to Escaper [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148990 (owner: 10Manybubbles) [20:04:42] (03Merged) 10jenkins-bot: Move more escaping logic to Escaper [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/148990 (owner: 10Manybubbles) [20:05:04] (03CR) 10Chad: [C: 032] Stop tracing redirects on invalid content [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/149297 (https://bugzilla.wikimedia.org/68558) (owner: 10Manybubbles) [20:05:13] (03Merged) 10jenkins-bot: Stop tracing redirects on invalid content [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/149297 (https://bugzilla.wikimedia.org/68558) (owner: 10Manybubbles) [20:05:34] 3MediaWiki / 3Export/Import: Importing does not work with HHVM - 10https://bugzilla.wikimedia.org/66023#c4 (10Brett Simmers) I'm debugging an issue with it right now. I'm hoping to have it cleaned up and committed by Monday, so it should be in the next nightly after that. [20:06:00] (03Merged) 10jenkins-bot: Made Special:RunJobs work for private wikis [core] - 10https://gerrit.wikimedia.org/r/149111 (owner: 10Aaron Schulz) [20:12:25] (03PS1) 10Mwalker: Actually clean files after rendering? [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149391 [20:12:45] (03CR) 10Mwalker: [C: 032] Actually clean files after rendering? [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149391 (owner: 10Mwalker) [20:12:59] (03Merged) 10jenkins-bot: Actually clean files after rendering? [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149391 (owner: 10Mwalker) [20:14:44] (03PS1) 10Physikerwelt: Improve PNG fallback [extensions/Math] - 10https://gerrit.wikimedia.org/r/149393 [20:16:28] <^d> brion: Totally different subject. I removed gpc support from WebRequest the other day. That todo about memory from oh-so-long-ago is gone. [20:16:42] ^d: magic_quotes? [20:16:44] <^d> magic_quotes_gpc [20:16:45] <^d> Yeah [20:16:47] yessssss [20:16:49] awesome [20:16:56] <^d> The WebRequest constructor is super light now. [20:17:01] <^d> So $wgRequest isn't really needed. [20:17:07] kill the globals! [20:17:08] <^d> You could just construct on demand if you don't need state. [20:17:20] <^d> (And if you do, get it from RequestContext!) [20:17:33] good job [20:19:24] (03CR) 10Physikerwelt: "I think if there is interest in continued PNG support the way to go is to seperate texvccheck from texvc." [extensions/Math] - 10https://gerrit.wikimedia.org/r/149089 (owner: 10Cscott) [20:19:33] (03PS1) 10EBernhardson: Port Flow Makefile to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149394 [20:21:32] <^d> /\$wgRequest/ [20:21:34] <^d> 214 matches across 45 files [20:21:35] <^d> :( [20:21:43] <^d> Just core! Lord knows for extensions. [20:55:48] 3Wikimedia / 3Site requests: Allow bureaucrat's to add/remove petitiondata right on foundationWiki - 10https://bugzilla.wikimedia.org/68587 (10James Alexander) 3NEW p:3Unprio s:3normal a:3None By request of the fundraising department which installed the petition extension but needs to be able to get... [20:55:58] 3MediaWiki / 3Revision deletion: Fatal error: Call to a member function getBits() on a non-object in SpecialRevisiondelete.php on line 166 - 10https://bugzilla.wikimedia.org/68566 (10Vogone) 5RESO/?>3VERI p:5Unprio>3Normal [20:57:48] 3Wikimedia / 3Site requests: Allow bureaucrat's to add/remove petitiondata right on foundationWiki - 10https://bugzilla.wikimedia.org/68587 (10Vogone) p:5Unprio>3Normal s:5normal>3enhanc [20:57:49] 3Wikimedia / 3Site requests: Allow bureaucrat's to add/remove petitiondata right on foundationWiki - 10https://bugzilla.wikimedia.org/68587 (10John F. Lewis) s:5enhanc>3normal a:3James Alexander [20:59:06] 9.9 [20:59:29] 3Wikimedia / 3Site requests: Allow bureaucrat's to add/remove petitiondata right on foundationWiki - 10https://bugzilla.wikimedia.org/68587 (10John F. Lewis) s:5normal>3enhanc [21:00:00] (03CR) 10Jdlrobson: Highlight unread message from notifications link (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148310 (owner: 10EBernhardson) [21:03:45] (03PS5) 10BryanDavis: centralauth: Use hiera to allow variable customization [vagrant] - 10https://gerrit.wikimedia.org/r/148317 (https://bugzilla.wikimedia.org/67331) [21:04:15] (03CR) 10BryanDavis: centralauth: Use hiera to allow variable customization (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/148317 (https://bugzilla.wikimedia.org/67331) (owner: 10BryanDavis) [21:04:24] (03PS6) 10BryanDavis: centralauth: Use hiera to allow variable customization [vagrant] - 10https://gerrit.wikimedia.org/r/148317 (https://bugzilla.wikimedia.org/67331) [21:04:37] (03CR) 10Ori.livneh: [C: 032] centralauth: Use hiera to allow variable customization [vagrant] - 10https://gerrit.wikimedia.org/r/148317 (https://bugzilla.wikimedia.org/67331) (owner: 10BryanDavis) [21:04:42] (03Merged) 10jenkins-bot: centralauth: Use hiera to allow variable customization [vagrant] - 10https://gerrit.wikimedia.org/r/148317 (https://bugzilla.wikimedia.org/67331) (owner: 10BryanDavis) [21:04:57] thx ori [21:05:31] we beat operations/puppet to hiera! :D \o/ [21:05:56] Nice [21:06:10] MatmaRex: thoughts on https://gerrit.wikimedia.org/r/#/c/148144/ ? [21:06:34] If we used hiera to serve webfonts, would they be hiera-glyphs? [21:06:38] hiera can do some neat things [21:06:46] * bd808 looks for a trout [21:06:47] Oh, I thought it was a server. Damn. [21:09:57] ori: In theory, hiera_include('classes') could replace manifests.d [21:10:20] in practice, too [21:10:20] I'm not sure if it's worth the refactoring effort or not [21:10:46] I played with it a bit when I was setting hiera up [21:11:38] Now that it's landed I need to work on some cleanup patches for other multiwiki stuff to use it consistently [21:12:44] i think there are ways to integrate hiera that would be little more than reflexive "use hot feature" [21:12:52] and there are ways that could bring quite a lot of coherence and sanity to the code [21:13:13] just have to think it through a little. i'm pretty new to hiera. i thought it was a key-value store rather than an abstract api specification. [21:13:20] How do I tell if I'm running on HipHop? [21:13:31] werdna: you just kinda feel it. [21:13:34] also, Special:Version [21:13:36] :p [21:13:39] ori: I mean, in code [21:13:47] if defined( 'HHVM_VERSION' ) [21:13:58] I need to alter RedisBagOStuff, because HipHop's redis client returns null, rather than false, for nonexistent keys [21:13:59] werdna: inspect network request, X-Powered-By:HHVM/3.3.0-dev [21:14:08] oh, i suppose depends where :) [21:14:21] werdna: that sounds like a straightforward HHVM bug [21:14:32] HHVM's redis client implementation is in PHP [21:14:38] so you don't need to know C++ to fix it [21:14:50] ori: Wasn't sure if it was *supposed* to return false or null [21:14:54] https://github.com/facebook/hhvm/blob/master/hphp/system/php/redis/Redis.php [21:14:56] I do know C++ anyway :p [21:15:13] ish [21:15:27] (03PS3) 10Jdlrobson: Remove concept of a default compiler [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 [21:15:31] it's supposed to match the behavior of zend / phpredis in all except a few, well-documented and principled cases [21:15:37] (03CR) 10jenkins-bot: [V: 04-1] Remove concept of a default compiler [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/149360 (owner: 10Jdlrobson) [21:15:40] wfIsHipHop() I think [21:17:54] (03CR) 10Jdlrobson: Add mw-ui-checkbox (032 comments) [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [21:17:58] 3MediaWiki extensions / 3WikimediaIncubator: WikimediaIncubator assumes that it can mess with everything if it's included, breaking tests - 10https://bugzilla.wikimedia.org/67608#c3 (10Max Semenik) It's failing due to WikimediaIncubator which adds its own permission checks. Is seems to be a rather architectu... [21:18:08] (03PS8) 10Jdlrobson: Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 [21:21:31] (03PS9) 10Jdlrobson: Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 [21:22:31] 3MediaWiki / 3Revision deletion: Rev-suppressed-text-view not shown on suppressed pages - 10https://bugzilla.wikimedia.org/56380#c1 (10Vogone) 5UNCO>3ASSI a:3Vogone Taking this. [21:22:39] (03CR) 10BearND: "Can we do that (issues style only for enwiki) as a separate commit?" (032 comments) [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148866 (owner: 10BearND) [21:23:47] (03CR) 10Odder: "Need a lazy link to bug 67700." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/149091 (owner: 10Jforrester) [21:27:37] (03PS5) 10BearND: Add blue flag icon for article/page issues links [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148866 [21:28:20] (03PS6) 10BearND: Add blue flag icon for article/page issues links [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/148866 [21:31:59] 3MediaWiki-Vagrant: Standalone jobrunner does not start - 10https://bugzilla.wikimedia.org/68525#c2 (10Matthew Flaschen) 5NEW>3RESO/WOR This is now working for me. I believe it was due to low memory (I inadvertently had an old Vagrantfile-extra setting it to a low value). [21:33:20] 3MediaWiki / 3General/Unknown: FastStringSearch on HHVM: Assertion `!"Invalid Cell type"' failed. - 10https://bugzilla.wikimedia.org/68422#c1 (10Ori Livneh) Created attachment 16038 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16038&action=edit parser test case Invoke using tests/parserTests.php -... [21:35:09] (03Abandoned) 10Physikerwelt: Add jsdom module [services/mathoid] - 10https://gerrit.wikimedia.org/r/143272 (owner: 10Physikerwelt) [21:35:33] (03Abandoned) 10Physikerwelt: WIP:First node only mathoid protype [services/mathoid] - 10https://gerrit.wikimedia.org/r/143043 (owner: 10Physikerwelt) [21:36:42] (03CR) 10Legoktm: [C: 032] Replace list with "(none)" when all items are removed [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149273 (owner: 10Wctaiwan) [21:36:52] (03Merged) 10jenkins-bot: Replace list with "(none)" when all items are removed [extensions/MassMessage] (contenthandler) - 10https://gerrit.wikimedia.org/r/149273 (owner: 10Wctaiwan) [21:37:13] 3MediaWiki / 3General/Unknown: FastStringSearch on HHVM: Assertion `!"Invalid Cell type"' failed. - 10https://bugzilla.wikimedia.org/68422#c2 (10Ori Livneh) (Documenting my baby-steps.) I run gdb like this: $ TRACE=bcinterp:3 HPHP_TRACE_FILE=/tmp/hphp.log gdb -ex run --args /usr/local/bin/hhvm /srv/mediawi... [21:37:56] ori: any idea how I can make a change to HHVM's PHP code locally? [21:38:00] I am very new to this HHVM thing [21:38:05] found the appropriate place to make the change eventually :p [21:38:31] buuut I don't know where the actual file is [21:38:56] werdna: you need to build hhvm from source. if this is a one-off, and you want to test something quickly, you can use osmium, which is the host on the production cluster the mediawiki-core team is using for testing hhvm patches [21:39:05] i can walk you through that if you like; it's pretty easy. [21:39:16] building hhvm from source sounds like it might take some time [21:39:30] a couple of minutes, since you're not rebuilding everything [21:39:40] oh, well, I might as well do that [21:39:48] I imagine I'll end up making other changes if we keep testing Flow on HHVM [21:40:30] (03CR) 10Ladsgroup: "I really need this patch, Is anything going wrong that this patch hasn't been updated for two months?" [core] - 10https://gerrit.wikimedia.org/r/135293 (https://bugzilla.wikimedia.org/65058) (owner: 10MaxSem) [21:43:46] (03PS1) 10Mwalker: Add some doc comments [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149453 [21:43:48] (03PS1) 10Mwalker: Don't zip things and use tmpfs [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149454 [21:44:03] (03CR) 10jenkins-bot: [V: 04-1] Don't zip things and use tmpfs [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149454 (owner: 10Mwalker) [21:45:53] (03CR) 10Mwalker: [C: 032] Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 (owner: 10Mwalker) [21:47:03] (03CR) 10Mwalker: [C: 032] Respect metabook lang setting when localizing attributions page. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149318 (owner: 10Cscott) [21:47:59] (03CR) 10Mwalker: [C: 032] Fetch authors in larger batches; fetch authors for specific article revid. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149330 (owner: 10Cscott) [21:48:36] (03CR) 10Mwalker: [C: 032] Skip wikitext fetch when `--no-compat` option is given. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149338 (owner: 10Cscott) [21:48:43] 3MediaWiki-Vagrant / 3labs-vagrant: labs-vagrant: centralauth role doesn't work, tries to load from wmftest.net - 10https://bugzilla.wikimedia.org/67331 (10Bryan Davis) 5PATC>3RESO/FIX [21:49:00] 3MediaWiki / 3General/Unknown: FastStringSearch on HHVM: Assertion `!"Invalid Cell type"' failed. - 10https://bugzilla.wikimedia.org/68422#c3 (10Brett Simmers) I'd recommend not using TRACE=bcinterp. It's way too verbose for most use cases (I was using it as a bit of a last resort debugging that lua thing) a... [21:49:17] (03PS2) 10Mwalker: Don't zip things and use tmpfs [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149454 [21:49:35] (03CR) 10Mwalker: [C: 032] Add some doc comments [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149453 (owner: 10Mwalker) [21:49:54] (03Merged) 10jenkins-bot: Add some doc comments [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149453 (owner: 10Mwalker) [21:50:06] (03CR) 10Mwalker: [C: 032] Don't zip things and use tmpfs [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149454 (owner: 10Mwalker) [21:50:08] (03Merged) 10jenkins-bot: Create attribution page [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/145187 (owner: 10Mwalker) [21:50:25] (03Merged) 10jenkins-bot: Don't zip things and use tmpfs [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/149454 (owner: 10Mwalker) [21:51:15] (03Merged) 10jenkins-bot: Respect metabook lang setting when localizing attributions page. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149318 (owner: 10Cscott) [21:51:24] (03Merged) 10jenkins-bot: Fetch authors in larger batches; fetch authors for specific article revid. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149330 (owner: 10Cscott) [21:51:26] (03Merged) 10jenkins-bot: Skip wikitext fetch when `--no-compat` option is given. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/149338 (owner: 10Cscott) [21:53:43] 3MediaWiki / 3Unit tests: PHP unit tests don't work if not run from tests/phpunit directory - "Call to a member function numRows() on a non-object" - 10https://bugzilla.wikimedia.org/56909 (10Antoine "hashar" Musso) [21:54:24] (03CR) 10Hashar: "Can this be backported to REL1_23 please? :-]" [core] - 10https://gerrit.wikimedia.org/r/141619 (owner: 10Ori.livneh) [21:55:16] 3MediaWiki / 3Unit tests: PHP unit tests don't work if not run from tests/phpunit directory - "Call to a member function numRows() on a non-object" - 10https://bugzilla.wikimedia.org/56909#c5 (10Antoine "hashar" Musso) Could use the patch on REL1_23 since we will surely have that issue when running tests. [21:55:22] (03PS1) 10Mwalker: Updated to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/149456 [21:55:39] (03CR) 10Frédéric Wang: [C: 032] Fix: id-attribute [extensions/Math] - 10https://gerrit.wikimedia.org/r/148535 (owner: 10Physikerwelt) [21:56:05] (03PS1) 10Mwalker: Local syslogs should be in debug mode [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/149457 [21:56:20] (03CR) 10Mwalker: [C: 032 V: 032] Updated to latest masters [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/149456 (owner: 10Mwalker) [21:56:40] (03CR) 10Mwalker: [C: 032 V: 032] Local syslogs should be in debug mode [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/149457 (owner: 10Mwalker) [21:57:13] (03CR) 10Frédéric Wang: "Well, I don't think we can do better than a regexp for now. Doing the SVG parsing seems it would be a performance drop. A better database " [extensions/Math] - 10https://gerrit.wikimedia.org/r/144939 (https://bugzilla.wikimedia.org/20202) (owner: 10Physikerwelt) [21:57:21] (03PS1) 10Mwalker: Merge remote-tracking branch 'origin/master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/149458 [21:59:36] (03CR) 10Mwalker: [C: 032 V: 032] Merge remote-tracking branch 'origin/master' into wmf-deploy [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/149458 (owner: 10Mwalker) [22:02:55] (03CR) 10Physikerwelt: [C: 04-1] "one file already contains the group" (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/148899 (owner: 10MaxSem) [22:03:22] (03PS3) 10Gerrit Patch Uploader: Vector: Use
instead of for action menu [core] - 10https://gerrit.wikimedia.org/r/136711 (https://bugzilla.wikimedia.org/42241) [22:03:24] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/136711 (https://bugzilla.wikimedia.org/42241) (owner: 10Gerrit Patch Uploader) [22:03:49] ori: not sure if you set the perms right on that dir [22:03:52] (03PS6) 10Jdlrobson: Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 [22:03:56] (03PS10) 10Jdlrobson: Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 [22:03:59] (03CR) 10jenkins-bot: [V: 04-1] Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 (owner: 10Jdlrobson) [22:04:01] ori: remote: error: insufficient permission for adding an object to repository database ./objects [22:04:02] (03PS2) 10Physikerwelt: @group Math where it's missing [extensions/Math] - 10https://gerrit.wikimedia.org/r/148899 (owner: 10MaxSem) [22:05:23] werdna: oops, fixing [22:05:36] werdna: didn't want it to be too easy, you know [22:06:19] (03PS1) 10EBernhardson: Update flow.suite.xml to work with phpunit on mediawiki-vagrant [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149460 [22:06:21] werdna: fixed [22:07:28] ori: <3 [22:07:57] 3MediaWiki / 3General/Unknown: FastStringSearch on HHVM: Assertion `!"Invalid Cell type"' failed. - 10https://bugzilla.wikimedia.org/68422#c4 (10Ori Livneh) 5NEW>3RESO/WOR I am an idiot; I was loading dynamic extensions from the wrong path. Once I set the right hhvm.dynamic_extension_path, the test-case... [22:08:12] thanks wikibugs, advertise it to the world [22:08:35] (03CR) 10jenkins-bot: [V: 04-1] Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [22:08:37] ori: still taking a while to build but I'm sure much less than you'd expect [22:09:40] (03PS3) 10MaxSem: @group Math where it's missing [extensions/Math] - 10https://gerrit.wikimedia.org/r/148899 [22:09:51] (03PS7) 10Gerrit Patch Uploader: Use instead of for JavaScript click events [core] - 10https://gerrit.wikimedia.org/r/139795 (https://bugzilla.wikimedia.org/42241) [22:09:53] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/139795 (https://bugzilla.wikimedia.org/42241) (owner: 10Gerrit Patch Uploader) [22:10:38] (03PS7) 10Jdlrobson: Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 [22:10:43] (03CR) 10jenkins-bot: [V: 04-1] Upstream checkboxes to core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 (owner: 10Jdlrobson) [22:14:36] (03PS11) 10Jdlrobson: Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 [22:16:19] (03CR) 10Legoktm: "Thanks!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/148352 (owner: 10Legoktm) [22:16:20] 3MediaWiki / 3JavaScript: Cannot recover from invalid token error - 10https://bugzilla.wikimedia.org/41466 (10Matthew Flaschen) 5ASSI>3RESO/FIX a:5Matthew Flaschen>3Krinkle [22:19:54] (03PS2) 10EBernhardson: Port Flow Makefile to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/149394 [22:26:31] 3MediaWiki / 3Special pages: HHVM: Special:Version with $wgSpecialVersionShowHooks = true appends a hash after Closures - 10https://bugzilla.wikimedia.org/68592 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None See upstream report: https://github.com/facebook/hhvm/issues/3281 Special:Versio... [22:26:46] 3MediaWiki / 3Special pages: HHVM: Special:Version with $wgSpecialVersionShowHooks = true appends a hash after Closures - 10https://bugzilla.wikimedia.org/68592 (10Kunal Mehta (Legoktm)) [22:31:54] (03PS1) 10Mattflaschen: Close out extension and note TimedMediaHandler as replacement [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/149465 [22:32:05] petan: I just received an e-mail for the notification from https://wikitech.wikimedia.org/wiki/Special:Notifications which says "Petrb added you to project [[[No page]]] [22:32:06] 07:20, 21 June 2013 [22:32:06] " [22:32:34] did you change anything today? [22:33:13] (03CR) 10Gergő Tisza: "I traced back the errors I am getting to everything under /srv/images/ belonging to vagrant:vagrant but PHP trying to write it with the ub" [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [22:33:26] helderwiki: lol, see -labs [22:34:06] (03CR) 10Mattflaschen: "Good point, I didn't realize that. It's marked obsolete and discontinued on the wiki, and it's not on the cluster at all." [extensions/OggHandler] - 10https://gerrit.wikimedia.org/r/145562 (owner: 10Paladox) [22:34:09] helderwiki: sorry about that :P [22:34:25] helderwiki: some really old emails were stuck in the queue and didn't get sent until now [22:34:52] (03CR) 10Physikerwelt: [C: 032] @group Math where it's missing [extensions/Math] - 10https://gerrit.wikimedia.org/r/148899 (owner: 10MaxSem) [22:36:05] does anyone else see encoding problems on http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-labs/20140725.txt ? [22:36:31] I'm seeing lots of squares with numbers (e.g.:  ) [22:38:18] (03PS33) 10Paladox: Update jquery.validate from 1.8.1 to 1.9.0 [core] - 10https://gerrit.wikimedia.org/r/145311 [22:38:23] (03CR) 10BryanDavis: "tgr: Looks like a recent fix -- Id47ab5e8dacc8748491992b261b92c2adc589142" [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [22:38:25] (03PS23) 10Paladox: Update jQuery Cookie to v1.3.1 [core] - 10https://gerrit.wikimedia.org/r/145884 [22:38:31] (03PS4) 10Legoktm: Split code for making test RecentChange objects into own class [core] - 10https://gerrit.wikimedia.org/r/149263 (owner: 10Aude) [22:38:53] (03PS3) 10Jdlrobson: Add mw-ui-input to mediawiki ui [core] - 10https://gerrit.wikimedia.org/r/149173 [22:39:32] (03CR) 10BryanDavis: "s/recent/ancient/ 2013 !== 2014" [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [22:40:13] (03CR) 10Legoktm: [C: 032] Split code for making test RecentChange objects into own class [core] - 10https://gerrit.wikimedia.org/r/149263 (owner: 10Aude) [22:41:15] (03PS3) 10Legoktm: Remove unused param in RCCacheEntryFactoryTest [core] - 10https://gerrit.wikimedia.org/r/149264 (owner: 10Aude) [22:42:22] (03CR) 10Legoktm: [C: 032] Remove unused param in RCCacheEntryFactoryTest [core] - 10https://gerrit.wikimedia.org/r/149264 (owner: 10Aude) [22:42:34] (03PS4) 10Jdlrobson: Add mw-ui-input to mediawiki ui [core] - 10https://gerrit.wikimedia.org/r/149173 [22:43:31] (03PS5) 10Jdlrobson: Add mw-ui-input to mediawiki ui [core] - 10https://gerrit.wikimedia.org/r/149173 [22:43:37] (03Merged) 10jenkins-bot: Split code for making test RecentChange objects into own class [core] - 10https://gerrit.wikimedia.org/r/149263 (owner: 10Aude) [22:45:26] (03PS1) 10Vogone: Fix appearance of suppress messages on Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/149467 (https://bugzilla.wikimedia.org/56380) [22:45:28] (03CR) 10Gergő Tisza: "Might just have been me messing up something when I was trying to recover from bug 67976." [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [22:45:35] (03Merged) 10jenkins-bot: Remove unused param in RCCacheEntryFactoryTest [core] - 10https://gerrit.wikimedia.org/r/149264 (owner: 10Aude) [22:46:23] (03PS2) 10Vogone: Fix appearance of suppress messages at Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/149467 (https://bugzilla.wikimedia.org/56380) [22:46:39] tgr: I swear that thumbs from common.wiki.local worked for me. I'll retest [22:47:09] tgr: Also, VMs are meant to be killed when they get weird rather than fixed. :) [22:47:16] cattle, not pets [22:47:29] legoktm: ^ probably a small change, could you take a look at it? [22:47:34] bd808: full-sized thumbnails work for me but thumb transforms don't [22:48:06] yeah, killing VMs from time to time would be a good practice [22:48:25] I try to do it at least every other week [22:48:40] I have too much stuff invested in this one, seemed like a pain in the ass to port over [22:48:47] And I have test vms that I destroy every time I mess with a patch [22:48:55] Content? [22:49:00] test pages with a bunch of images and markup, shell settings... [22:49:01] YOu can dump and import [22:49:14] shell settings I do with a custom role [22:49:52] We should make an easy `vagrant export` command to dump the wikitext [22:50:04] (03CR) 10Legoktm: [C: 031] "Looks fine, haven't tested though." [core] - 10https://gerrit.wikimedia.org/r/149467 (https://bugzilla.wikimedia.org/56380) (owner: 10Vogone) [22:50:23] Vogone: I'll probably have time later in the weekend to take a closer look [22:50:23] ideally the extension should import its own test suite, I think [22:50:56] okay, thanks :) [22:51:09] tgr: That would be cool. We have an import define. Look at role::labs_initial_content [22:51:30] but it would be super-nice to have a vagrant rebuild command which keeps the content and stuff in settings.d but throws away all else [22:51:45] 3MediaWiki extensions / 3Cite: Cite: Provide a way for users to find articles which have the reference list inserted automatically - 10https://bugzilla.wikimedia.org/67700 (10James Forrester) 5REOP>3NEW [22:51:47] 3MediaWiki-Vagrant: Running tests results in a lot of bogus jobs - 10https://bugzilla.wikimedia.org/68593 (10Max Semenik) 3NEW p:3Unprio s:3normal a:3Ori Livneh After running tests, job queue gets overflown by jobs spawned by test data creation, which due to job runner, results in one process consisten... [22:51:57] (03PS3) 10Legoktm: Improvements to RCCacheEntryFactoryTest and helper class [core] - 10https://gerrit.wikimedia.org/r/149304 (owner: 10Aude) [22:51:58] tgr: It could be done [22:52:08] (03CR) 10Legoktm: [C: 032] Improvements to RCCacheEntryFactoryTest and helper class [core] - 10https://gerrit.wikimedia.org/r/149304 (owner: 10Aude) [22:52:29] (03PS3) 10Legoktm: Add some tests for OldChangesList [core] - 10https://gerrit.wikimedia.org/r/149305 (owner: 10Aude) [22:54:23] (03PS6) 10Jdlrobson: Add mw-ui-input to mediawiki ui [core] - 10https://gerrit.wikimedia.org/r/149173 [22:55:45] 3MediaWiki-Vagrant: Add a `vagrant export-dump` command to export the wiki contents - 10https://bugzilla.wikimedia.org/68594 (10Bryan Davis) 3NEW p:3Unprio s:3enhanc a:3Ori Livneh This would be a nice to have to convince people that killing and rebuilding a badly behaving vm is easier than debugging st... [22:55:58] (03Merged) 10jenkins-bot: Improvements to RCCacheEntryFactoryTest and helper class [core] - 10https://gerrit.wikimedia.org/r/149304 (owner: 10Aude) [22:56:29] 3MediaWiki-Vagrant: Add a `vagrant export-dump` command to export the wiki contents - 10https://bugzilla.wikimedia.org/68594 (10Bryan Davis) p:5Unprio>3Normal [22:58:05] <^d> bd808: If your wiki is big that could make vagrant reload really really slow. [22:58:29] ^d: Yeah, but awesome :) [22:58:41] <^d> ...imports are slow [22:58:52] <^d> Like really painfully slow. [22:59:11] ^d: tgr was pointing out that many roles should provide some testing pages [22:59:27] math is one I can think of for sure [23:00:47] <^d> Anyway, it's 5pm for you so we can figure it out later :) [23:01:10] ^d: Not leaving for the bar until 6 :) [23:02:32] tgr: I just tested commons thumbs by: enable role, provision, login to commons.wiki as admin, upload picture with upload wizard, visit file page, open thumb link, change px to random value. [23:02:49] tgr: Linke was like -- http://commons.wiki.local.wmftest.net:8080/commonsimages/thumb/e/e9/MG_8092-Edit-final.jpg/33px-MG_8092-Edit-final.jpg [23:03:17] Seems to work great for me. [23:03:43] What is broken still AFAIK is thumbs for things from instantcommons [23:03:51] There's an open bug report for that [23:04:08] I poked at it a bit a couple nights ago but got nowhere [23:04:48] it's pretty easy to work around though [23:05:05] (03CR) 10Mattflaschen: [C: 04-1] "There are a couple things being discussed:" [core] - 10https://gerrit.wikimedia.org/r/149173 (owner: 10Jdlrobson) [23:05:08] what's the workaround? [23:05:11] maybe the default setup for mw-vagrant should do that for the time being [23:05:17] just disable caching [23:05:30] I pasted the code in the bug, I think [23:05:35] (03PS7) 10Jdlrobson: Add mw-ui-input to mediawiki ui [core] - 10https://gerrit.wikimedia.org/r/149173 [23:05:56] Ah. That's the problem huh. The source image from commons isn't cached correctly? [23:06:40] I bet all the caches are pointing at redis or something dumb like that [23:06:40] yes, it's related to local storing of thumbnails [23:07:36] I started tracking it down a long time ago, but then MediaViewer development started and I forgot about it [23:07:38] (03CR) 10Yaron Koren: "I'm torn on this one... my instinct says that only a pure ID system would be secure enough in all cases; but maybe there's" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [23:08:22] (03CR) 10Yaron Koren: "(hit "Publish" too soon again)" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/147991 (owner: 10Scott-linder) [23:10:21] werdna: how did it go? [23:10:25] with the redis bug? [23:10:29] ori: still compiling [23:10:35] * ori boggles [23:10:46] 3MediaWiki-Vagrant: Running tests results in a lot of bogus jobs - 10https://bugzilla.wikimedia.org/68593#c1 (10Bryan Davis) (In reply to Max Semenik from comment #0) > The temporary solution is > echo flushall|redis-cli && sudo pkill -e -9 php > however a proper fix is needed. Like tests not leaving bogus... [23:11:19] (03CR) 10Mattflaschen: "Jared, May, is the left blue bar the intended input box focus indicator going forward?" [core] - 10https://gerrit.wikimedia.org/r/149173 (owner: 10Jdlrobson) [23:11:39] ori: Scanning dependencies of target ext_hhvm_static [23:12:07] (03CR) 10Legoktm: [C: 032] Add some tests for OldChangesList [core] - 10https://gerrit.wikimedia.org/r/149305 (owner: 10Aude) [23:12:29] 3MediaWiki extensions / 3WikidataClient: Featured and good article badges - 10https://bugzilla.wikimedia.org/40810#c53 (10Nemo) I moved the list to https://meta.wikimedia.org/wiki/Wikidata/Development/Badges [23:14:27] (03Merged) 10jenkins-bot: Add some tests for OldChangesList [core] - 10https://gerrit.wikimedia.org/r/149305 (owner: 10Aude) [23:17:10] (03CR) 10Mattflaschen: [C: 04-1] "Per above, I think we shouldn't have two focus indicators." [core] - 10https://gerrit.wikimedia.org/r/149173 (owner: 10Jdlrobson) [23:19:10] (03PS8) 10Jdlrobson: Add mw-ui-input to mediawiki ui [core] - 10https://gerrit.wikimedia.org/r/149173 [23:24:48] bd808: can you retest with zend role enabled? [23:25:09] Dear god why? :) [23:25:12] I think the problem is in puppet/modules/multiwiki/templates/apache.conf.erb [23:25:46] (03PS1) 10Legoktm: Add support for fetching branch lists from Gerrit [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/149474 [23:26:05] ^d: ^ [23:26:24] when in zend mode, the docroot is not set so the request is handled by the normal thumb.php script, not the multiwiki one [23:26:45] tgr: Yup "No MWMultiVersion instance initialized! MWScript.php wrapper not used?" [23:27:25] should I open a bug about that? [23:27:47] Sure. Assign to me. [23:29:13] (03CR) 10Legoktm: "I have really only tested the Gerrit provider so far" [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/149474 (owner: 10Legoktm) [23:29:14] I forgot to disable it after using xdebug, if that's what the dear god comment referred to [23:29:52] tgr: I've just become addicted to how much faster hhvm is already [23:30:41] (03PS14) 10Werdna: New topic notifications for watchers of a board. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/147520 [23:30:45] (03PS2) 10Werdna: Move watch star for boards next to the header. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/149210 [23:32:02] (03Abandoned) 10Werdna: Add tooltip for watching boards. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148294 (owner: 10Werdna) [23:33:12] tgr: /w is broken for multiwiki in general with zend [23:33:30] yeah [23:33:46] I think it's just missing an alias [23:33:54] I'll see if I can fix it [23:34:14] It has "Alias /w /vagrant/mediawiki" [23:34:17] But that's not right [23:34:54] Nemo_bis: I hope this helps: https://meta.wikimedia.org/w/index.php?diff=9310205 [23:36:02] tgr: It just needs to be changed to "Alias /w /srv/multiwiki" [23:37:42] tgr: I have a the fix if you haven't gotten there yet. [23:37:50] helderwiki: doesn't harm :) are you going to follow those links and fix the functions? ;) [23:37:56] I might be looking at the wrong file [23:38:01] I only see Alias /w <%= scope['::mediawiki::dir'] %> [23:38:01] maybe :-) [23:38:19] \o/ [23:38:30] in puppet/modules/multiwiki/templates/apache.conf.erb [23:38:44] (03PS1) 10BryanDavis: Fix /w for multiwiki [vagrant] - 10https://gerrit.wikimedia.org/r/149475 [23:38:49] tgr: ^ [23:38:52] helderwiki: you could finish fixing bi.wiki, our test case with Nikerabbit's selectors [23:39:30] For some reason it still doesn't work for me on https://bi.wikipedia.org/wiki/Germany [23:40:08] tgr: That matches what hhvm was doing because of the proxypassmatch line [23:40:39] which selectors are you referring to, Nemo_bis ? [23:40:46] yeah, I get that part [23:41:11] just not really grasping the scope[] concept yet [23:41:17] helderwiki: the [[bi:MediaWiki:Common.js]] snippet I linked from meta [23:41:22] is that hiera? [23:41:39] ori: +Warning: Host lookup failed [-10003]: Unknown error -10003 [23:41:39] + [23:41:39] +Warning: Failed connecting to redis server at : [23:41:41] when running tests [23:41:49] I guess osmium doesn't have the correct setup [23:42:02] tgr: Ah "scope" is a puppet thing to loookup a variable that is declared but not in local scope when the template is evaluated [23:42:47] tgr: So the prior setting was looking up the $dir variable declared in the scope of the mediawiki module [23:43:15] Which is /vargrant/mediawiki [23:43:30] (03PS8) 10Jdlrobson: Use mw-ui-checkbox from core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 [23:43:37] (03CR) 10jenkins-bot: [V: 04-1] Use mw-ui-checkbox from core [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/149122 (owner: 10Jdlrobson) [23:43:39] Will take a look tomorrow.. [23:43:46] I see [23:43:52] The change is to the $docroot variable in the multiwiki module [23:43:54] (03PS12) 10Jdlrobson: Add mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149121 [23:43:56] (03PS1) 10Jdlrobson: Make Special:UserLogin form use mw-ui-checkbox [core] - 10https://gerrit.wikimedia.org/r/149476 [23:45:04] (03CR) 10Gergő Tisza: [C: 032] "Works correctly with the zend role after this change." [vagrant] - 10https://gerrit.wikimedia.org/r/149475 (owner: 10BryanDavis) [23:45:09] to be even more confusing, `scope[...]` is syntatic sugar for the `scope.lookup(...)` function exposed to ruby by puppet [23:45:12] (03Merged) 10jenkins-bot: Fix /w for multiwiki [vagrant] - 10https://gerrit.wikimedia.org/r/149475 (owner: 10BryanDavis) [23:45:27] I really have to learn puppet [23:45:47] tgr: not if you value your sanity [23:45:51] It takes some time but it starts make sense eventually [23:49:17] (03CR) 10Jdlrobson: [C: 032] "GTD" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148246 (owner: 10EBernhardson) [23:49:26] (03CR) 10Gergő Tisza: "Brian helped to track this down to https://gerrit.wikimedia.org/r/#/c/149475/" [vagrant] - 10https://gerrit.wikimedia.org/r/147151 (owner: 10Gilles) [23:49:49] (03Merged) 10jenkins-bot: Fragments are also relative links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/148246 (owner: 10EBernhardson) [23:52:00] tgr: Oh god, now we have CORS things to work out too? [23:52:19] * bd808 goes to get drunk instead [23:52:28] ori: eeep, not sure what I've done: make[2]: *** No rule to make target `hphp/compiler/analysis/exceptions.h', needed by `hphp/compiler/CMakeFiles/hphp_analysis.dir/construct.cpp.o'. Stop. [23:52:32] (03CR) 10Mattflaschen: "Small note, may do a full review later." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/149121 (owner: 10Jdlrobson) [23:52:58] werdna: huh [23:53:10] werdna: do you mind if i poke in your home dir to see? [23:53:23] ori: you can, but right now what I'm doing is resetting to origin/master [23:54:45] bd808: I can probably figure that one out [23:55:08] where I could use a pointer is how to decouple roles [23:55:24] I want to put the uploadwizard stuff back to the uw role [23:55:41] I remember you told me once how to do that but I don't remember what you said [23:55:50] ori: probably switching branches has made it want to rebuild again, but I'll see [23:56:31] 3MediaWiki-Vagrant: npm install needs to be run on "vagrant provision" for guests using vagrant-proxyconf - 10https://bugzilla.wikimedia.org/61502 (10Bryan Davis) [23:56:44] werdna: yes, probably [23:56:57] seeeems to be going faster actually [23:56:59] (03PS1) 10Jdlrobson: Expose the count of users watching a given page [core] - 10https://gerrit.wikimedia.org/r/149478 [23:57:10] from a superficial reading of puppet docs, seems like it could be done with virtual resources and a collector in the commons role, but you mentioned some other feature and I can't recall the name [23:57:54] ori: look at me, stealing ur servers: https://www.dropbox.com/s/btzf495wnvp8ocm/Screenshot%202014-07-25%2016.57.42.png [23:58:09] heh [23:58:34] (03PS2) 10Jdlrobson: Expose the count of users watching a given page [core] - 10https://gerrit.wikimedia.org/r/149478 [23:59:04] jdlrobson: omg security [23:59:24] werdna: it's just a count.. why is that a security breach? [23:59:25] werdna: you probably shouldn't [23:59:40] ori: shouldn't? [23:59:47] it is friday though so maybe i'm missing something ;) [23:59:56] brett (our facebook volunteer) is using it to test a fix for a high-profile bug