[00:00:25] 3MediaWiki-Change-tagging, MediaWiki-API: Create ability to add / remove tags from edits / actions - https://phabricator.wikimedia.org/T20670#949968 (10matmarex) [00:01:03] 3MediaWiki-JavaScript: Users able to watch pages get a script error, breaking LiquidThreads - https://phabricator.wikimedia.org/T32372#949970 (10matmarex) 5Open>3Resolved [00:01:28] (03CR) 10Legoktm: [C: 032] Run composer when installing Elastica [vagrant] - 10https://gerrit.wikimedia.org/r/182302 (owner: 10BryanDavis) [00:01:34] (03CR) 10Legoktm: [C: 032] Verify composer via composer.lock [vagrant] - 10https://gerrit.wikimedia.org/r/182301 (owner: 10BryanDavis) [00:01:41] (03Merged) 10jenkins-bot: Verify composer via composer.lock [vagrant] - 10https://gerrit.wikimedia.org/r/182301 (owner: 10BryanDavis) [00:01:46] (03Merged) 10jenkins-bot: Run composer when installing Elastica [vagrant] - 10https://gerrit.wikimedia.org/r/182302 (owner: 10BryanDavis) [00:01:54] 3MediaWiki-JavaScript: MediaWiki AJAX interface (tracking) - https://phabricator.wikimedia.org/T45175#949976 (10matmarex) [00:01:55] 3MediaWiki-JavaScript: Some AJAX features seem to have stopped working in 1.18 - https://phabricator.wikimedia.org/T33545#949973 (10matmarex) 5Open>3Resolved a:3matmarex No longer occurs. [00:03:13] (03CR) 10BryanDavis: "Initially I thought about adding an include for 'extensions/*/composer.json' too but I'm not convinced that is the best thing to do. Thoug" [core] - 10https://gerrit.wikimedia.org/r/182323 (owner: 10BryanDavis) [00:04:55] 3MediaWiki-JavaScript: Dialog has no style applied and therefore is transparent (jQuery.UI) for RTL languages and monobook - https://phabricator.wikimedia.org/T37059#949977 (10matmarex) No longer occurs. >>! In T37059#402334, @eranroz wrote: > It is totaly unchecked, but MAYBE the resource: > http://en.wikipedi... [00:05:12] 3MediaWiki-JavaScript: Dialog has no style applied and therefore is transparent (jQuery.UI) for RTL languages and monobook - https://phabricator.wikimedia.org/T37059#949979 (10matmarex) 5Open>3Resolved [00:05:14] 3MediaWiki-Parser: RTL/bidirectional issues (tracking) - https://phabricator.wikimedia.org/T2745#949981 (10matmarex) [00:07:25] 3MediaWiki-JavaScript: Support "int-hack" in jqueryMsg - https://phabricator.wikimedia.org/T40381#949982 (10matmarex) [00:07:43] 3MediaWiki-JavaScript: Add support for rawParams to jqueryMsg - https://phabricator.wikimedia.org/T33260#949984 (10matmarex) [00:08:35] 3Librarization, MediaWiki-Core-Team: Blog post about work on librarization project and future hopes - https://phabricator.wikimedia.org/T85482#947869 (10bd808) [00:08:57] 3MediaWiki-Internationalization: Add parameter support to int: magic word in jQueryMsg - https://phabricator.wikimedia.org/T49840#949990 (10matmarex) [00:08:58] 3MediaWiki-JavaScript: Support "int-hack" in jqueryMsg - https://phabricator.wikimedia.org/T40381#474090 (10matmarex) [00:10:19] 3MediaWiki-Core-Team, Librarization: Have a check for reported security issues in dependencies - https://phabricator.wikimedia.org/T74193#949994 (10bd808) [00:10:27] 3MediaWiki-JavaScript: [Regression] jquery.ui.slider breaks IE9 on hewiki - https://phabricator.wikimedia.org/T40500#949995 (10matmarex) [00:14:57] 3MediaWiki-JavaScript: [mediawiki.feedback.js] Feedback should follow redirect - https://phabricator.wikimedia.org/T49729#950003 (10matmarex) 5Open>3Resolved a:3matmarex Fixed in 96c4e453ecfaba9cc5dca904301981e9d6e3492b (https://gerrit.wikimedia.org/r/#/c/143171/). [00:16:14] 3MediaWiki-JavaScript: Implement numParams in jqueryMsg - https://phabricator.wikimedia.org/T57775#950007 (10matmarex) [00:17:13] 3MediaWiki-JavaScript: mw.Title should provide a function to get a Title object from a link - https://phabricator.wikimedia.org/T58303#950010 (10matmarex) [00:19:19] (03Abandoned) 10Bartosz Dziewoński: Includes toggle handler in jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/110883 (https://bugzilla.wikimedia.org/57297) (owner: 10AalekhN) [00:19:51] 3MediaWiki-General-or-Unknown: Add JS component in Core for fullscreen handling - https://phabricator.wikimedia.org/T59297#950014 (10matmarex) [00:20:03] 3MediaWiki-General-or-Unknown: Add JS component in Core for fullscreen handling - https://phabricator.wikimedia.org/T59297#619233 (10matmarex) (The patch has been abandoned.) [00:21:57] (03CR) 10Mitar: "You are completely right! :-)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/153983 (owner: 10Mitar) [00:23:25] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: Javascript preview when editing users skin file should be loaded the same as in module mode - https://phabricator.wikimedia.org/T72526#950022 (10matmarex) [00:23:49] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: Javascript preview when editing users skin file should be loaded the same as in module mode - https://phabricator.wikimedia.org/T72526#769205 (10matmarex) T71924 has been fixed. Is this therefore fixed too? [00:24:27] 3Mobile-Web: No refresh icon on Special:Nearby in alpha - https://phabricator.wikimedia.org/T85578#950029 (10Jdlrobson) 3NEW [00:25:15] (03CR) 10Legoktm: "I think keeping it simple with composer.local.json is a good start." [core] - 10https://gerrit.wikimedia.org/r/182323 (owner: 10BryanDavis) [00:25:48] 3MediaWiki-JavaScript: New jquery.placeholder.js is slow/placeholder text does not disappear in IE8 - https://phabricator.wikimedia.org/T60536#950035 (10matmarex) [00:27:08] 3MediaWiki-JavaScript: New jquery.placeholder.js is slow/placeholder text does not disappear in IE8 - https://phabricator.wikimedia.org/T60536#617438 (10matmarex) [00:27:57] bugspam incoming [00:28:04] 3UI-Standardization, MediaWiki-Interface: Use a single suggestions/autocompletion component (instead of LookupInputWidget, jquery.suggestions, jquery.ui.autocomplete) - https://phabricator.wikimedia.org/T85394#950041 (10matmarex) [00:28:05] 3MediaWiki-Interface: [Regression] jquery.ui.slider breaks IE9 on hewiki - https://phabricator.wikimedia.org/T40500#950040 (10matmarex) [00:28:07] 3MediaWiki-Interface: New jquery.placeholder.js is slow/placeholder text does not disappear in IE8 - https://phabricator.wikimedia.org/T60536#950039 (10matmarex) [00:28:10] 3MediaWiki-Interface: jquery.makeCollapsible() very slow if many collapsible, initially collapsed elements - https://phabricator.wikimedia.org/T36876#950043 (10matmarex) [00:28:11] 3MediaWiki-Interface: Dynamic charts/graphs (JavaScript implementation) - https://phabricator.wikimedia.org/T41555#950042 (10matmarex) [00:28:12] 3Wikidata, MediaWiki-Interface, MediaWiki-extensions-WikibaseRepository: Unable to "Edit pages on double click" on Wikidata - https://phabricator.wikimedia.org/T75649#950045 (10matmarex) [00:28:13] 3MediaWiki-Interface: jquery.footHovzer: Don't cause a scrollbar to appear if content is shorter than window height - https://phabricator.wikimedia.org/T38273#950046 (10matmarex) [00:28:15] 3MediaWiki-Interface: Implement front-end for toggling the "resourceLoaderDebug" cookie - https://phabricator.wikimedia.org/T37063#950047 (10matmarex) [00:28:16] 3MediaWiki-Interface: Provide a standard addPortlet function - https://phabricator.wikimedia.org/T25515#950048 (10matmarex) [00:28:17] 3MediaWiki-Interface: jQuery.makeCollapsible.js should support 'autocollapse', 'innercollapse' and 'outercollapse' options - https://phabricator.wikimedia.org/T32352#950050 (10matmarex) [00:28:18] 3MediaWiki-Interface: Edit on double click: Try to target background (not inputs, etc) - https://phabricator.wikimedia.org/T74891#950049 (10matmarex) [00:28:20] 3MediaWiki-Interface: [mediawiki.feedback.js] Add checkbox to submit user-agent info - https://phabricator.wikimedia.org/T43291#950051 (10matmarex) [00:28:21] 3MediaWiki-Interface: [makeCollapsible.js] Provide an option to let the initial state depend on the number of collapsible elements - https://phabricator.wikimedia.org/T72762#950052 (10matmarex) [00:28:22] 3MediaWiki-Interface: mw.notification Usability Improvements - https://phabricator.wikimedia.org/T42307#950053 (10matmarex) [00:28:24] 3MediaWiki-Interface: Cursor jumps to the end of the summary field after pasting more text than is allowed - https://phabricator.wikimedia.org/T63450#950054 (10matmarex) [00:28:25] 3MediaWiki-Interface: Provide JavaScript login widget - https://phabricator.wikimedia.org/T71596#950055 (10matmarex) [00:28:28] 3MediaWiki-Interface: Invalid accesskey tooltip on Chrome - https://phabricator.wikimedia.org/T70798#950056 (10matmarex) [00:28:29] 3MediaWiki-Interface: jquery.highlightText.js needs to be able to highlight more than one word, numbers, spaces, and punctuation - https://phabricator.wikimedia.org/T69784#950058 (10matmarex) [00:28:30] 3MediaWiki-Interface: mw.notification: Postpone autoHide timer if window was not focused - https://phabricator.wikimedia.org/T42322#950057 (10matmarex) [00:28:32] 3MediaWiki-Interface: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state) - https://phabricator.wikimedia.org/T42812#950061 (10matmarex) [00:28:33] 3MediaWiki-Interface: Cloned collapsible contents are no longer collapsible - https://phabricator.wikimedia.org/T71288#950059 (10matmarex) [00:28:34] 3MediaWiki-Interface: jquery.makeCollapsible should allow setting standard toggles for remote handles - https://phabricator.wikimedia.org/T68991#950060 (10matmarex) [00:28:35] 3MediaWiki-Interface: Redirects to section are off in Firefox 29.0.1 if there are collapsed elements above the section - https://phabricator.wikimedia.org/T67468#950062 (10matmarex) [00:28:36] 3MediaWiki-Interface: jquery.byteLimit doesn't work when the content is pasted using the mouse - https://phabricator.wikimedia.org/T64319#950063 (10matmarex) [00:28:38] 3MediaWiki-Interface: Many characters disappear from edit summary after undoing the limitation imposed by jquery.byteLimit - https://phabricator.wikimedia.org/T64318#950065 (10matmarex) [00:28:39] 3MediaWiki-Interface: $.byteLimit gets confused when pasting text at the beginning of the input field that has a common prefix with the current text - https://phabricator.wikimedia.org/T64454#950064 (10matmarex) [00:28:40] 3MediaWiki-Interface: jQuery.makeCollapsible: Font color of collapsible button cannot be set - https://phabricator.wikimedia.org/T63018#950066 (10matmarex) [00:28:41] 3MediaWiki-Interface: mw.notify() with type to get different ui with predefined styles - https://phabricator.wikimedia.org/T61099#950068 (10matmarex) [00:28:43] 3MediaWiki-Interface: Support "lazy" image loading - https://phabricator.wikimedia.org/T36023#950067 (10matmarex) [00:28:44] 3MediaWiki-Interface: jquery.placeholder shouldn't hide the placeholder when focussing an empty input field - https://phabricator.wikimedia.org/T42645#950069 (10matmarex) [00:28:45] 3MediaWiki-Interface: New-style packed gallery shows ragged edges after window resize - https://phabricator.wikimedia.org/T55664#950070 (10matmarex) [00:28:46] 3MediaWiki-Interface: Search box deletes part of what the user types and go to the wrong page - https://phabricator.wikimedia.org/T53900#950071 (10matmarex) [00:28:48] 3MediaWiki-Interface: jquery.suggestions should obey maxRows setting - https://phabricator.wikimedia.org/T39316#950074 (10matmarex) [00:28:49] 3MediaWiki-Interface: mw.util.addPortletLink doesn't work for third party skins that have different portlet HTML - https://phabricator.wikimedia.org/T42813#950073 (10matmarex) [00:28:50] 3MediaWiki-Interface: jquery.ui.button: Buttonset in RTL languages has wrong border radius applied - https://phabricator.wikimedia.org/T42218#950072 (10matmarex) [00:28:51] 3MediaWiki-Interface: jquery.makeCollapsible should avoid page scroll when collapsing elements - https://phabricator.wikimedia.org/T42792#950075 (10matmarex) [00:28:53] 3MediaWiki-Interface: Include a time picker widget module in core - https://phabricator.wikimedia.org/T38794#950076 (10matmarex) [00:29:03] (done) [00:29:21] (03PS7) 10McIntireEvan: Moved getTitleInvalidRegex() from Title to MediaWikiTitleCodec [core] - 10https://gerrit.wikimedia.org/r/181942 [00:29:33] Wow, mass edit or something? [00:31:11] (03CR) 10McIntireEvan: "That's a good point, I'll do that and edit the commit message" [core] - 10https://gerrit.wikimedia.org/r/181954 (owner: 10McIntireEvan) [00:35:04] (03PS2) 10McIntireEvan: Remove normalizeAttributeValue() [core] - 10https://gerrit.wikimedia.org/r/181954 [00:35:36] 3Mobile-Web: Notification overlay back button behaviour broken - https://phabricator.wikimedia.org/T85292#950077 (10Florian) 5Open>3Resolved [00:36:22] Does HHVM have the same bug where global closures cause PHP to segfault? [00:37:04] Same bug? [00:37:20] Does Zend have that? Sounds nasty. [00:37:36] precise's version of 5.3 does [00:38:12] Fun. [00:39:33] legoktm or jackmcbarn: can either of you tell me if the new revision id is returned to me somehow when I do a mw.Api().postWithToken() or do I have to make a separate request to .get() that info back? [00:41:18] 3MediaWiki-Interface: New-style packed gallery shows ragged edges after window resize - https://phabricator.wikimedia.org/T55664#950080 (10matmarex) [00:41:49] 3MediaWiki-Interface: jquery.footHovzer: Don't cause a scrollbar to appear if content is shorter than window height - https://phabricator.wikimedia.org/T38273#950082 (10matmarex) [00:41:57] 3MediaWiki-Interface: jquery.suggestions should obey maxRows setting - https://phabricator.wikimedia.org/T39316#950084 (10matmarex) [00:42:10] Technical_13: it returns whatever the API returns. [00:42:32] 3MediaWiki-Interface: Search box deletes part of what the user types and go to the wrong page - https://phabricator.wikimedia.org/T53900#950091 (10matmarex) Should be easy to fix, now that the issue is known :) [00:42:39] Is that information in what the API returns is my question. [00:42:40] 3MediaWiki-Interface: New-style packed gallery shows ragged edges after window resize - https://phabricator.wikimedia.org/T55664#591073 (10matmarex) [00:42:51] Technical_13: there's one way to find out! [00:42:58] Fair enough... [00:43:50] random and here goes the page dependent on user language: https://en.wikipedia.org/wiki/Frederick enwiki:pcache:idhash:96979-0!*!0!!en!4!* [00:44:05] gwicke, ^^^ [00:44:34] this crap is even more widespread than I expected [00:44:59] 3MediaWiki-Interface: jquery.suggestions should obey maxRows setting - https://phabricator.wikimedia.org/T39316#950095 (10matmarex) jquery.suggestions is still used, most notably for the search suggestions dropdown in all skins. There was some other module that was killed off a long time ago, you must have meant... [00:45:53] Evan_M: yep, i'm doing some cleanup [00:46:48] I wonder what actually changes in there [00:47:04] Technical_13: legoktm: yes. https://www.mediawiki.org/wiki/API:Edit#Example (expand the result. also, that has xml, heh. but it's easy to guess how json output looks) [00:48:07] section edit links are language-dependent on all pages [00:48:32] I'm not 100% sure if they fragment the parser cache too [00:48:43] hopefully not, but who knows [00:49:18] there's also the TOC [00:49:21] gwicke: the toc too. they don't [00:49:24] ir shouldn't [00:49:33] there's some heavy magic applied to both of these [00:49:39] ah, yeah [00:49:43] (03PS3) 10McIntireEvan: Remove normalizeAttributeValue() [core] - 10https://gerrit.wikimedia.org/r/181954 [00:50:00] the toc is really UI [00:50:43] parsoid doesn't render it at all [00:50:51] 3wikidata-query-service, Wikidata, MediaWiki-Core-Team: Figure out quantity representation - https://phabricator.wikimedia.org/T85298#950096 (10Smalyshev) Titan allows indexing the floats, but not in vertex-centric indexes. Elasticsearch indexes support floats, for example. I'm not sure what is the actual impact... [00:50:53] so are the section edit links. skins can actually override their rendering. [00:51:00] and i think Minerva does [00:51:13] here is the Parsoid result: http://parsoid-lb.eqiad.wikimedia.org/enwiki/Frederick?oldid=638553731 [00:51:51] MatmaRex: response.query.edit.newrevid look right for json? [00:51:55] bd808 I'm having problems with MW-Vagrant similar to T69976. tgr did you ever solve your problem? [00:52:06] 3MediaWiki-Vagrant: Archives directory /vagrant/apt-cache/partial is missing. - https://phabricator.wikimedia.org/T69976#950097 (10Spage) >>! In T69976#718954, @Tgr wrote: > (In reply to Bryan Davis from comment #12) >> The fix was to make the old git cache happy by `mkdir -p apt-cache/partial` >> and then `vagr... [00:52:58] Do I have to specify I want the result as json? Is that the default? [00:53:21] Technical_13: when using mw.Api, yes it is default [00:53:31] 3Mobile-Web: Still issues with pinch zoom on images - https://phabricator.wikimedia.org/T76620#950101 (10kaldari) Hmm. The patch doesn't seem to have really fixed the problem, although it also doesn't make things any worse (and simplifies the CSS). [00:54:05] and becomes response.query.edit.newrevid ? [00:59:33] 3MediaWiki-ContentHandler: Handle existing #REDIRECT CSS/JS pages - https://phabricator.wikimedia.org/T85306#950103 (10matmarex) [00:59:37] 3MediaWiki-ContentHandler: Run a basic JavaScript syntax check when user/site JavaScript pages are saved - https://phabricator.wikimedia.org/T76204#950105 (10matmarex) [00:59:55] probably [01:00:06] 3MediaWiki-extensions-TextExtracts, MediaWiki-extensions-Popups: Reference lists appearing in extracts for some articles - https://phabricator.wikimedia.org/T74629#950106 (10Quiddity) [01:00:20] 3MediaWiki-API: allimages api query doesn't allow multiple mime types - https://phabricator.wikimedia.org/T78690#950107 (10Ricordisamoa) >>! In T78690#947831, @Anomie wrote: > Should be deployed to WMF wikis with 1.25wmf14, see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the schedule. Actually, th... [01:00:27] btw, re skins vs. the parser cache: skins can also override the rendering of links and thumbs; I would think that at least some of those actually fragment the parser cache [01:00:51] MaxSem: ^^ [01:01:22] 3MediaWiki-extensions-TextExtracts, MediaWiki-extensions-Popups: Reference lists appearing in extracts for some articles - https://phabricator.wikimedia.org/T74629#950109 (10Quiddity) p:5Triage>3Normal [01:01:32] that's parser cahe for page content gwicke [01:02:07] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Add mw.mmv.viewer to access the current MediaViewer instance - https://phabricator.wikimedia.org/T76923#950112 (10Tgr) 5Open>3Resolved a:3Tgr [01:02:19] MaxSem: yup [01:02:49] 3MediaWiki-General-or-Unknown: Add "test patch" option via address line - https://phabricator.wikimedia.org/T78476#950114 (10matmarex) [01:03:10] 3MediaWiki-General-or-Unknown: generateRandomSessionId on mediawiki.user.js not so random - https://phabricator.wikimedia.org/T78449#950115 (10matmarex) [01:03:19] 3MediaWiki-Vagrant: Archives directory /vagrant/apt-cache/partial is missing. - https://phabricator.wikimedia.org/T69976#950116 (10bd808) >>! In T69976#950097, @Spage wrote: > Me too, same situation (new virtualbox and latest vagrant code but using an old vagrant box). Don't do that. :) The change to the cache... [01:04:38] 3Librarization, MediaWiki-Vendor, MediaWiki-Core-Team: Upgrade monolog to 1.12.0 - https://phabricator.wikimedia.org/T85535#950117 (10bd808) [01:05:17] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Relax formatting stripping for description - https://phabricator.wikimedia.org/T69887#950121 (10Sn1per) 5Open>3Resolved [01:05:25] 3Librarization, MediaWiki-Vendor, MediaWiki-Core-Team: Upgrade monolog to 1.12.0 - https://phabricator.wikimedia.org/T85535#949087 (10bd808) We should hold off on doing this until @csteipp has had a chance to test his vulnerability scanner using this test case. [01:06:57] 3MediaWiki-Internationalization: Implement numParams in jqueryMsg - https://phabricator.wikimedia.org/T57775#950125 (10matmarex) [01:06:58] 3MediaWiki-Internationalization: Add support for rawParams to jqueryMsg - https://phabricator.wikimedia.org/T33260#950127 (10matmarex) [01:06:59] 3MediaWiki-Internationalization: Support "int-hack" in jqueryMsg - https://phabricator.wikimedia.org/T40381#950126 (10matmarex) [01:08:38] 3MediaWiki-General-or-Unknown: Add JS component in Core for fullscreen handling - https://phabricator.wikimedia.org/T59297#950130 (10Tgr) I think this can be closed - fullscreen handling was split into an external library (T58477 / [[ https://github.com/theopolisme/jquery-fullscreen | github:theopolisme/jquery-f... [01:09:34] 3MediaWiki-JavaScript, Project-Creators: Merge projects javascript and MediaWiki-JavaScript - https://phabricator.wikimedia.org/T76269#950132 (10matmarex) 52 left after: * Closing some old long-fixed bugs * Triaging newly filed reports (filed after this task) * Triaging reports that obviously belonged to `#Medi... [01:09:50] response.edit.newrevid worked. :) [01:10:47] 3MediaWiki-Internationalization: mediawiki.language.numbers.js truncates numbers instead of rounding - https://phabricator.wikimedia.org/T71836#950133 (10matmarex) [01:12:07] (03CR) 10GWicke: "@Parent5446: For now, the plan is to use this in" [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [01:13:14] (03PS1) 10Ricordisamoa: [WIP] enable native client-side rendering of SVG images [core] - 10https://gerrit.wikimedia.org/r/182332 [01:14:37] (03CR) 10GWicke: Make a VirtualRESTService class for Parsoid (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [01:14:57] 3MediaWiki-Documentation: docs/contenthandler.txt should be updated to include JSON - https://phabricator.wikimedia.org/T85580#950147 (10wctaiwan) 3NEW [01:15:13] (03CR) 10Krinkle: Cleanup SiteListFileCache test files in tearDown (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181047 (owner: 10Aude) [01:15:15] 3MediaWiki-Documentation: docs/contenthandler.txt should be updated to include JSON - https://phabricator.wikimedia.org/T85580#950147 (10wctaiwan) [01:15:54] 3Multimedia, MediaWiki-extensions-CommonsMetadata: Prefer information templates that are about the file - https://phabricator.wikimedia.org/T74084#950155 (10Sn1per) a:5Tgr>3Sn1per [01:18:11] (03PS1) 10McIntireEvan: Documented the Class ImportStringSource based on https://phabricator.wikimedia.org/T75283 [core] - 10https://gerrit.wikimedia.org/r/182333 [01:18:33] 3MediaWiki-Change-tagging, MediaWiki-API: Create ability to add / remove tags from edits / actions - https://phabricator.wikimedia.org/T20670#950159 (10TTO) a:3TTO So, what is the current situation here? * All defined tags [1] are defined by extensions. The other approach for defining tags (by adding a row to... [01:19:11] (03CR) 10Legoktm: [C: 04-1] Make a VirtualRESTService class for Parsoid (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [01:23:15] (03CR) 10GWicke: Make a VirtualRESTService class for Parsoid (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [01:25:12] (03CR) 10GWicke: Make a VirtualRESTService class for Parsoid (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [01:27:13] (03CR) 10TTO: [C: 04-1] "Please just use "T75283" in the commit message, not the entire URL. As you can see, Gerrit screws up the URL..." [core] - 10https://gerrit.wikimedia.org/r/182333 (owner: 10McIntireEvan) [01:29:32] (03CR) 10McIntireEvan: "Alright, thank you for the comment, I'll fix it up and submit a revision :)" [core] - 10https://gerrit.wikimedia.org/r/182333 (owner: 10McIntireEvan) [01:31:48] (03CR) 10Legoktm: Make a VirtualRESTService class for Parsoid (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [01:32:16] (03CR) 10TTO: "@Anomie: Thanks for the detailed review. There are a few lingering questions for you in some of my comments." (039 comments) [core] - 10https://gerrit.wikimedia.org/r/181958 (owner: 10TTO) [01:33:13] tto: So ImportStringSource imports XML dumps from strings, while ImportStreamSource does it from a file, and ImportStreamSource is more effecient, due to the intended purposes and variables used for storage? [01:33:55] It's more efficient because it doesn't have to load the entire file into memory at once, unlike ImportStringSource. For big dumps this can be an issue [01:34:05] That's basically why you use streams in the first place [01:34:39] Alright, thank you! I'll submit the new revision in a few minutes [01:35:47] (03CR) 10GWicke: Make a VirtualRESTService class for Parsoid (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [01:36:13] 3WMF-Design, Mobile-Web: Polish : Mobile experimental mode search header height is inconsistent - https://phabricator.wikimedia.org/T1165#20172 (10Jdlrobson) It's maybe a pixel off now on beta labs. The issue in your image is something else. [01:36:40] 3Mobile-Web, MediaWiki-extensions-TitleBlacklist: Mobile should have better support for TitleBlacklist errors - https://phabricator.wikimedia.org/T65335#950170 (10Jdlrobson) [01:38:15] 3Mobile-Web: Desktop interface reverts to mobile after opt out - https://phabricator.wikimedia.org/T71967#950175 (10Jdlrobson) 5Open>3declined a:3Jdlrobson Is this still a problem? Looks like more information is needed above... [01:38:52] (03PS2) 10McIntireEvan: Documented the Classses ImportStringSource and ImportSteamSource [core] - 10https://gerrit.wikimedia.org/r/182333 [01:39:29] 3MediaWiki-Search, Wikidata, Mobile-Web, MediaWiki-extensions-WikibaseRepository: search for WIkidata should use entity selector on mobile as well - https://phabricator.wikimedia.org/T85368#950178 (10Jdlrobson) I'm not sure I don't know the Wikidata code well enough. I'd suggest someone should do a spike or just... [01:40:17] (03PS1) 10Wctaiwan: Add JSON to docs/contenthandler.txt [core] - 10https://gerrit.wikimedia.org/r/182335 [01:40:53] Evan_M: Watch your spelling :) There's a bit of Steam in your patch as well as some Classses [01:41:03] Also some trailing whitespace, which some people are anal about [01:41:14] Note the red highlight in Gerrit... that's trailing whitespace [01:41:28] Blah, Im so sorry, editing on my laptop in a hotel room, I'll fix that up [01:42:03] I admire your dedication! [01:42:19] (03CR) 10Legoktm: [C: 032] Add JSON to docs/contenthandler.txt [core] - 10https://gerrit.wikimedia.org/r/182335 (owner: 10Wctaiwan) [01:42:38] Coding is the thing I love, so why not do it when on vacation? [01:46:44] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Measure how often users right-click the image in MediaViewer - https://phabricator.wikimedia.org/T75962#950192 (10Tgr) GCI task: https://www.google-melange.com/gci/task/view/google/gci2014/5815536596287488 [01:48:13] (03Merged) 10jenkins-bot: Add JSON to docs/contenthandler.txt [core] - 10https://gerrit.wikimedia.org/r/182335 (owner: 10Wctaiwan) [01:48:38] (03CR) 10Alex Monk: Make a VirtualRESTService class for Parsoid (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [01:49:52] 3MediaWiki-extensions-Flow: Duplicated topics in some views - https://phabricator.wikimedia.org/T85582#950196 (10Quiddity) 3NEW [01:50:00] 3MediaWiki-Documentation: docs/contenthandler.txt should be updated to include JSON - https://phabricator.wikimedia.org/T85580#950202 (10wctaiwan) 5Open>3Resolved a:3wctaiwan [01:51:45] 3MediaWiki-extensions-Flow: Duplicated topics in some views - https://phabricator.wikimedia.org/T85582#950206 (10Mattflaschen) p:5Triage>3Unbreak! [01:52:05] (03PS3) 10McIntireEvan: Documented the Classes ImportStringSource and ImportStreamSource [core] - 10https://gerrit.wikimedia.org/r/182333 [01:52:18] I hope I fixed all the typos, we'll see [01:53:12] (03CR) 10TTO: [C: 031] Documented the Classes ImportStringSource and ImportStreamSource [core] - 10https://gerrit.wikimedia.org/r/182333 (owner: 10McIntireEvan) [01:54:57] (03CR) 10Legoktm: [C: 032] Documented the Classes ImportStringSource and ImportStreamSource [core] - 10https://gerrit.wikimedia.org/r/182333 (owner: 10McIntireEvan) [02:00:59] (03Merged) 10jenkins-bot: Documented the Classes ImportStringSource and ImportStreamSource [core] - 10https://gerrit.wikimedia.org/r/182333 (owner: 10McIntireEvan) [02:01:50] :D [02:09:11] Is there any way to make mw.notify screen position relative? If I make a notification popup when a user is scrolled halfway down the page, they can't see it. Is there a better method to use? [02:15:09] 3Wiki-Release-Team: Mentor Google Code-in 2014 Student(s) Who Compile a List of Top Requested Features - https://phabricator.wikimedia.org/T953#950210 (10Palexis) Third: https://www.mediawiki.org/wiki/MediaWiki_Stakeholders%27_Group/Tasks/Feature_wishlist/Husun_Shujaat [02:17:00] Technical_13: it should be behaving the way you want it to. [02:17:23] (03CR) 10Gergő Tisza: [WIP] enable native client-side rendering of SVG images (032 comments) [core] - 10https://gerrit.wikimedia.org/r/182332 (owner: 10Ricordisamoa) [02:18:05] Sometimes it seems to be fixed to the very top right of the page. It seems to be working as I was hoping now, so maybe it was a wikibits issue I was having. (I'm going to blame that). [02:20:02] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Media viewer fails to give credit to all people in specific circumstances - https://phabricator.wikimedia.org/T68606#950211 (10Tgr) [02:23:23] 3MediaWiki-General-or-Unknown: Add JS component in Core for fullscreen handling - https://phabricator.wikimedia.org/T59297#950213 (10matmarex) [02:26:36] 3Multimedia, MediaWiki-Uploading: Special:Upload should pre-fill summary field without Javascript - https://phabricator.wikimedia.org/T72146#950218 (10Tgr) 5Open>3Resolved a:3Tgr As Umherirrender says, this is already possible. [02:27:11] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Click handler should be removed if MediaViewer fails to load - https://phabricator.wikimedia.org/T66527#950221 (10Tgr) [02:32:11] 3Fundraising-Backlog: Fix WP mobile forms - https://phabricator.wikimedia.org/T85583#950225 (10atgo) 3NEW [02:40:21] 3Fundraising-Backlog: Fix WP mobile forms - https://phabricator.wikimedia.org/T85583#950231 (10atgo) [02:40:25] Purge tool does not show up in dropdown(enabled as beta) - https://phabricator.wikimedia.org/T85460#950233 (10Quiddity) [02:43:53] (03CR) 10Florianschmidtwelzow: [C: 04-1] "And note: Asirra Integration was removed in Ieb3b0386f10d241e8d9b711ebf1ae2520e74c111" (032 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/122126 (https://bugzilla.wikimedia.org/61597) (owner: 10AalekhN) [02:45:08] Purge tool does not show up in dropdown(enabled as beta) - https://phabricator.wikimedia.org/T85460#950235 (10Quiddity) [02:45:10] 3MediaWiki-extensions-VectorBeta: compactPersonalBar.js breaks mw.util.addPortletLink for gadgets, user scripts and other extensions - https://phabricator.wikimedia.org/T67073#950236 (10Quiddity) [02:49:09] 3MediaWiki-extensions-VectorBeta: compactPersonalBar.js breaks mw.util.addPortletLink for gadgets, user scripts and other extensions - https://phabricator.wikimedia.org/T67073#950238 (10Quiddity) @Leaderboard reported a similar problem with the Purge Tab gadget at wikibooks https://en.wikibooks.org/wiki/MediaWik... [02:51:16] 3Wikimedia-SVG-rendering: textPath is not supported by rsvg - https://phabricator.wikimedia.org/T11420#950240 (10Perhelion) Partial patch upstream as: https://bugzilla.gnome.org/show_bug.cgi?id=725558 But they seems not really willing to take this. [02:55:42] 3Fundraising-Backlog: Fix WP mobile forms - https://phabricator.wikimedia.org/T85583#950241 (10atgo) p:5Triage>3Normal [02:56:11] (03CR) 10Florianschmidtwelzow: [C: 04-1] Add support for the AreYouAHuman/PlayThru CAPTCHA (035 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/65797 (owner: 10Strix) [02:57:27] 3MediaWiki-extensions-DonationInterface, Fundraising-Backlog: Show contribution tracking ID on "your transaction could not be accepted" page - https://phabricator.wikimedia.org/T85584#950242 (10atgo) 3NEW [02:59:34] 3MediaWiki-extensions-DonationInterface, Fundraising-Backlog: Add mailto link on "your transaction could not be accepted" page that would include contribution tracking ID in the body or subject of email - https://phabricator.wikimedia.org/T85585#950248 (10atgo) 3NEW [02:59:44] 3MediaWiki-extensions-DonationInterface, Fundraising-Backlog: Add mailto link on "your transaction could not be accepted" page that would include contribution tracking ID in the body or subject of email - https://phabricator.wikimedia.org/T85585#950248 (10atgo) [03:00:07] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/40553 (https://bugzilla.wikimedia.org/41522) (owner: 10Helder.wiki) [03:00:12] (03CR) 10jenkins-bot: [V: 04-1] Add new log of type "captcha" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/40553 (https://bugzilla.wikimedia.org/41522) (owner: 10Helder.wiki) [03:00:46] (03CR) 10Florianschmidtwelzow: [C: 04-1] "needs rebase." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/40553 (https://bugzilla.wikimedia.org/41522) (owner: 10Helder.wiki) [03:01:34] 3Fundraising Dash, Fundraising-Backlog: A/B Testing in Dash (Sahar reports replacement) - https://phabricator.wikimedia.org/T77913#950258 (10atgo) p:5Triage>3Normal [03:06:12] (03CR) 10Florianschmidtwelzow: [C: 04-1] Make Questy answers in arrays case-insensitive (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/33153 (owner: 10leucosticte) [03:06:19] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/33153 (owner: 10leucosticte) [03:08:30] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Doublicate of: I146b53cacf901c45ce27bd87fdf8125bfd2bc270" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/122104 (https://bugzilla.wikimedia.org/63272) (owner: 10JustJustin) [03:08:57] (03PS2) 10Florianschmidtwelzow: Make Questy answers in arrays case-insensitive [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/33153 (owner: 10leucosticte) [03:11:55] 3Multimedia, MediaWiki-Uploading: Special:Upload should pre-fill summary field without Javascript - https://phabricator.wikimedia.org/T72146#950261 (10Jdlrobson) 5Resolved>3Open This should be preloaded. Original bug was reported because people were uploading images without this. [03:12:50] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Click handler should be removed if MediaViewer fails to load - https://phabricator.wikimedia.org/T66527#950263 (10Tgr) 5Open>3Resolved a:3Tgr Already done - the fail hanlder in `MultimediaViewerBootstrap.loadViewer()` sets the flag `MultimediaViewerBootst... [03:14:28] 3Multimedia, MediaWiki-File-management: After re-uploading a PDF file to mediawiki.org, users still see the thumbnail for the old version - https://phabricator.wikimedia.org/T38380#950266 (10Tgr) [03:14:46] 3Multimedia, MediaWiki-File-management: After re-uploading a PDF file to mediawiki.org, users still see the thumbnail for the old version - https://phabricator.wikimedia.org/T38380#411389 (10Tgr) [03:19:59] 3MediaWiki-General-or-Unknown: MediaWiki should check ETags - https://phabricator.wikimedia.org/T49529#950269 (10Tgr) [03:21:36] 3Multimedia, MediaWiki-File-management: After re-uploading a PDF file to mediawiki.org, users still see the thumbnail for the old version - https://phabricator.wikimedia.org/T38380#950271 (10Tgr) >>! In T38380#948860, @TheDJ wrote: > eTags on the content should also be able to handle this situation. Images use... [03:27:48] 3Grantmaking-LearningPatterns: Update probox to allow all current pattern categories to be added by setting infobox parameters - https://phabricator.wikimedia.org/T85424#950272 (10BGibbs_WMF) Note: the category "Featured learning patterns" should be excluded from the available options in the list of categories t... [03:36:46] 3Multimedia, MediaWiki-Uploading: Special:Upload should pre-fill summary field without Javascript - https://phabricator.wikimedia.org/T72146#950273 (10Tgr) 5Open>3Resolved Not sure what you mean exactly by preloaded, but `MediaWiki:Upload-default-description` will be used as the default value of the upload d... [03:58:03] 3Multimedia, MediaWiki-File-management: bitdepth of UploadStashFile is wrong - https://phabricator.wikimedia.org/T36952#950276 (10polybuildr) While the efficiency is a valid argument, the `UploadStashFile` class has the comment "Arguably UnregisteredLocalFile should be handling its own file repo but that class i... [04:00:23] 3MediaWiki-extensions-TextExtracts, MediaWiki-extensions-Popups: Reference lists appearing in extracts for some articles - https://phabricator.wikimedia.org/T74629#950277 (10Aklapper) [offtopic] >>! In T74629#949725, @MaxSem wrote: > Caused by T73023 - phab shows an error when I try to add it as a blocker. As w... [04:04:39] 3MediaWiki-General-or-Unknown: Hyperlink that leads to a nonexistent page on Wikimedia Commons is blue instead of being red - https://phabricator.wikimedia.org/T85346#950278 (10Aklapper) 5Resolved>3Invalid DLindsey: Please do not reset the status without an explanation. See my previous comment and https://ww... [04:13:40] (03Abandoned) 10Jackmcbarn: Prefer earlier potential sections in summaries [core] - 10https://gerrit.wikimedia.org/r/147362 (https://bugzilla.wikimedia.org/68361) (owner: 10Jackmcbarn) [04:44:15] 3Wikimedia-Git-or-Gerrit, operations, Wikimedia-SSL-related: Chrome warns about insecure certificate on gerrit.wikimedia.org - https://phabricator.wikimedia.org/T76562#950281 (10MZMcBride) I agree with this task being a relatively high priority. I discussed this issue with @Krenair earlier today. The warning in... [04:49:26] 3Multimedia, MediaWiki-File-management: After re-uploading a PDF file to mediawiki.org, users still see the thumbnail for the old version - https://phabricator.wikimedia.org/T38380#950283 (10MZMcBride) In my opinion, this is a situation where showing a loading icon or no image at all would be preferable to showi... [04:52:51] 3operations, Wikimedia-SSL-related: Some Wikimedia servers don't send intermediary certificates - https://phabricator.wikimedia.org/T72326#950285 (10Krenair) Looks like stats is also OK now. Just ganglia. [04:53:13] 3operations, Wikimedia-SSL-related: Ganglia server doesn't send intermediary certificates - https://phabricator.wikimedia.org/T72326#950287 (10Krenair) [04:56:20] 3MediaWiki-extensions-Flow, Collaboration-Team: As a user I want to know when a topic I've created changes title - https://phabricator.wikimedia.org/T71884#950290 (10Mattflaschen) 5Resolved>3Open Reopening pending testing (see my previous comment). [05:01:58] Package extensions for MLEB - https://phabricator.wikimedia.org/T85136#950295 (10KartikMistry) 5Open>3Resolved [05:02:08] Release documentation and announcement - https://phabricator.wikimedia.org/T85209#950296 (10KartikMistry) 5Open>3Resolved [05:04:54] 3MediaWiki-Internationalization: Support "int-hack" in jqueryMsg - https://phabricator.wikimedia.org/T40381#950299 (10Mattflaschen) I fixed "The JS message object doesn't even glance at the {{int:....}} part" in {T45574}. To use it, you currently have to specify the message (ethereditor-collaborate-button) in t... [05:05:07] 3MediaWiki-JavaScript: JavaScript stopped working on Wikipedia in Spanish - https://phabricator.wikimedia.org/T85489#950301 (10TTO) Aha. That function `live()` has been deprecated for some years, and was finally removed a few weeks ago. I believe the modern equivalent is `on()`, although I'm no jQuery expert. T... [05:06:28] harvest microformats - https://phabricator.wikimedia.org/T78416#950302 (10murfel) a:5murfel>3None You would probably need bs4 4.2.1 (depends on python >= 2.7.5-5~) so mf2py works correctly. You can start with or take a look at my code: http://pastebin.com/acLfCrfD [05:06:45] 3MediaWiki-Internationalization: Support "int-hack" in jqueryMsg - https://phabricator.wikimedia.org/T40381#950304 (10Mattflaschen) [05:07:45] 3MediaWiki-Internationalization: Support "{{int:}}" (with parameters and auto-dependencies for messages) in jqueryMsg - https://phabricator.wikimedia.org/T40381#950307 (10Mattflaschen) [05:32:42] 3MediaWiki-extensions-OAuth: OAuth needs to define the change tags it uses - https://phabricator.wikimedia.org/T85586#950311 (10TTO) 3NEW [05:38:53] (03PS11) 10BryanDavis: Phab role based on IEGReview [vagrant] - 10https://gerrit.wikimedia.org/r/178643 (owner: 10Chad) [05:40:53] 3Wikimedia-Site-requests: Set a new namespace for nds.wiktionary - https://phabricator.wikimedia.org/T85122#950320 (10Glaisher) a:5Glaisher>3TTO .. [05:41:32] 3Wikimedia-Site-requests: Set a new namespace for nds.wiktionary - https://phabricator.wikimedia.org/T85122#950322 (10TTO) Ah sorry, didn't see that you had "claimed" this task. Bugzilla used to make that a lot more obvious.... [06:02:45] 3MediaWiki-Change-tagging, MediaWiki-API: Create ability to add / remove tags from edits / actions - https://phabricator.wikimedia.org/T20670#950325 (10NicoV) > * Add a `tags=` parameter to API `action=edit`, allowing users to add specific change tags to the edits they make. This will be of particular value to... [06:08:36] (03CR) 10BryanDavis: [C: 031] "The phd processes don't seem to start automatically for me. I've had to ssh in and start them manually each time I've built the vm. from t" [vagrant] - 10https://gerrit.wikimedia.org/r/178643 (owner: 10Chad) [06:17:15] 3MediaWiki-Change-tagging, MediaWiki-API: Create ability to add / remove tags from edits / actions - https://phabricator.wikimedia.org/T20670#950327 (10TTO) True, but what about IPs? They can `edit`, but they can't use Twinkle or AWB (don't know about WPCleaner). I'm not entirely comfortable letting IPs (and n... [06:17:24] 3Wikimedia-DNS, Wikimedia-General-or-Unknown, operations: m.{project}.org portal/redirect consistency and i18n issues - https://phabricator.wikimedia.org/T78421#950329 (10Glaisher) >>! In T78421#845553, @Glaisher wrote: > I think m.wikipedia.org to enwp redirect is silly.. which is {T69015} > But a better alt... [06:34:33] 3MediaWiki-Change-tagging, MediaWiki-API: Create ability to add / remove tags from edits / actions - https://phabricator.wikimedia.org/T20670#950338 (10NicoV) Same for WPCleaner, login is required to edit. I don't mind if tags are restricted to registered users. If tags are available only through the API and no... [06:58:12] 3MediaWiki-Documentation: docs/hooks.txt should not refer to deprecated wfRunHooks() function - https://phabricator.wikimedia.org/T85588#950351 (10TTO) 3NEW [06:58:55] 3MediaWiki-Documentation: docs/hooks.txt should not refer to deprecated wfRunHooks() function - https://phabricator.wikimedia.org/T85588#950351 (10TTO) p:5Unbreak!>3Triage [06:58:57] Category gives wrong number of pages - https://phabricator.wikimedia.org/T85527#948886 (10MZMcBride) I thought we solved this for smaller categories (less than X members) by allowing the purge action to refresh the category member count, maybe? This issue has definitely come up before. [07:02:18] Category gives wrong number of pages - https://phabricator.wikimedia.org/T85527#950362 (10MZMcBride) Probably related: {T23230} and {T18765}. [07:03:10] Category gives wrong number of pages - https://phabricator.wikimedia.org/T85527#950366 (10MZMcBride) And {T18036}. [07:25:13] 3Multimedia, MediaWiki-File-management: bitdepth of UploadStashFile is wrong - https://phabricator.wikimedia.org/T36952#950369 (10Tgr) I think `UploadStashFile` should have the same logic as `LocalFile` (except for the memcached layer): have private properties for all [[ https://www.mediawiki.org/wiki/Manual:Upl... [07:42:33] (03PS1) 10Georggi199: Bug T70750, replaced deprecated wfMsg*() functions [extensions/ShoutBox] - 10https://gerrit.wikimedia.org/r/182352 [07:46:14] (03CR) 10Gergő Tisza: [C: 032] Sanitize | characters in descriptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 (owner: 10MarkTraceur) [07:47:06] (03Merged) 10jenkins-bot: Sanitize | characters in descriptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 (owner: 10MarkTraceur) [07:59:07] (03PS2) 10Nemo bis: Move deprecated HTML attributes to CSS [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/182140 (owner: 10Phoenix303) [08:03:46] (03CR) 10jenkins-bot: [V: 04-1] Move deprecated HTML attributes to CSS [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/182140 (owner: 10Phoenix303) [08:11:10] 3Multimedia, MediaWiki-File-management: After re-uploading a PDF file to mediawiki.org, users still see the thumbnail for the old version - https://phabricator.wikimedia.org/T38380#950382 (10Tgr) Going to the file page linked from the description (I haven't visited it before) and looking up the request for the t... [08:18:45] (03CR) 10Nemo bis: [C: 04-1] "Thanks for the patch" (031 comment) [extensions/ShoutBox] - 10https://gerrit.wikimedia.org/r/182352 (owner: 10Georggi199) [08:47:32] 3MediaWiki-extensions-VectorBeta: compactPersonalBar.js breaks mw.util.addPortletLink for gadgets, user scripts and other extensions - https://phabricator.wikimedia.org/T67073#950390 (10Ricordisamoa) https://en.wikibooks.org/wiki/MediaWiki:Gadget-purge.js appears to use `#p-cactions`, while the CompactPersonalBa... [08:49:28] 3MediaWiki-extensions-Flow: Flow: moderation action when already moderated gives misleading Insufficient permissions error - https://phabricator.wikimedia.org/T66568#950394 (10Spage) p:5Triage>3Normal [08:50:31] 3MediaWiki-extensions-Flow: Flow: texts of topic summary history and change mention "post summary" - https://phabricator.wikimedia.org/T66390#950395 (10Spage) p:5Triage>3Normal [08:50:46] 3MediaWiki-extensions-Flow: Flow: texts of topic summary history and change mention "post summary" - https://phabricator.wikimedia.org/T66390#700483 (10Spage) [08:50:53] (03CR) 10Ricordisamoa: [C: 04-1] "Currently, $wgSVGConverter = null is supposed to disable SVG rendering completely." [core] - 10https://gerrit.wikimedia.org/r/182332 (owner: 10Ricordisamoa) [08:53:49] Allocate resources for the migration and maintenance - https://phabricator.wikimedia.org/T17#950406 (10Qgil) [09:00:43] (03PS2) 10Ricordisamoa: [WIP] enable native client-side rendering of SVG images [core] - 10https://gerrit.wikimedia.org/r/182332 [09:01:00] (03CR) 10Ricordisamoa: [WIP] enable native client-side rendering of SVG images (032 comments) [core] - 10https://gerrit.wikimedia.org/r/182332 (owner: 10Ricordisamoa) [09:01:30] (03CR) 10Ricordisamoa: "No longer breaks expected behavior." [core] - 10https://gerrit.wikimedia.org/r/182332 (owner: 10Ricordisamoa) [09:11:26] 3MediaWiki-extensions-ContentTranslation: Discard translation drafts - https://phabricator.wikimedia.org/T75979#950413 (10santhosh) https://gerrit.wikimedia.org/r/182065 does not have the confirmation dialog when user clicks on discard dialog. I am postponing it to make the patch compact and convenient for review. [09:12:49] 3MediaWiki-extensions-ContentTranslation: show a red interlanguage link only if the current ContentTranslation installation supports this language as a target - https://phabricator.wikimedia.org/T85223#950414 (10santhosh) [09:29:59] (03PS1) 10Gerrit Patch Uploader: mediawiki.action.edit.preview: Use DOM as event priority [core] - 10https://gerrit.wikimedia.org/r/182354 [09:30:01] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/182354 (owner: 10Gerrit Patch Uploader) [09:37:46] (03PS3) 10Niharika29: Add collaboration question in application [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182189 [09:38:50] (03CR) 10Niharika29: [C: 031] "Fixed." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182189 (owner: 10Niharika29) [09:39:13] Still, restricting access to tasks based on project membership - https://phabricator.wikimedia.org/T517#950437 (10Qgil) [09:40:09] (03PS1) 10Gerrit Patch Uploader: Remove trigger 'LivePreviewPrepare' [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/182355 [09:40:11] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/182355 (owner: 10Gerrit Patch Uploader) [09:40:25] 3Scrum-of-Scrums, MediaWiki-extensions-ZeroBanner, Mobile-Web, Zero: Language-aware redirects for mdot webroot in general - https://phabricator.wikimedia.org/T78172#950438 (10Yurik) [09:43:47] 3MediaWiki-extensions-ZeroPortal: Zero related API warnings - https://phabricator.wikimedia.org/T75468#950440 (10Yurik) 5Open>3Resolved Reedy, I suspect this was fixed a while ago. Let me know if you see it in the logs again. [09:44:14] 3MediaWiki-extensions-ZeroPortal: Zero related API warnings - https://phabricator.wikimedia.org/T75468#950442 (10Yurik) a:5Yurik>3Reedy [09:45:40] 3MediaWiki-API: API uses weird * (star/asterisk) key for the content property in JSON and PHP serialized formats - https://phabricator.wikimedia.org/T33629#950444 (10Yurik) a:5Yurik>3None [09:46:58] 3Engineering-Community: Establish minimum criteria to evaluate interns in outreach programs - https://phabricator.wikimedia.org/T1253#950446 (10Qgil) 5Open>3Resolved https://www.mediawiki.org/wiki/Outreach_programs/Evaluation_criteria created. The selection criteria is now official. I didn't receive any fee... [09:49:58] 3Engineering-Community: Move ECT's on-wiki backlogs to Phabricator - https://phabricator.wikimedia.org/T1034#950448 (10Qgil) a:3Qgil [09:50:01] 3Engineering-Community: Connect Wikimedia groups, Google Developer Groups, and computer science university departments - https://phabricator.wikimedia.org/T925#950449 (10Qgil) a:3Qgil [09:50:02] 3Engineering-Community: Report the Engineering Community activity for December 2014 - https://phabricator.wikimedia.org/T76164#950450 (10Qgil) a:3Qgil [09:50:15] (03PS4) 10Niharika29: Add collaboration question in application [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182189 [09:51:33] 3Engineering-Community: Connect Wikimedia groups, Google Developer Groups, and computer science university departments - https://phabricator.wikimedia.org/T925#15685 (10Qgil) [09:51:35] 3Engineering-Community, Project-Creators: Convert mw:Mentorship_programs/Possible_projects in two Phabricator projects - https://phabricator.wikimedia.org/T76341#950455 (10Qgil) [09:51:40] 3Engineering-Community: Qgil to mentor Google Code-in tasks and help as org admin - https://phabricator.wikimedia.org/T76338#950456 (10Qgil) [09:51:41] 3Human-Resources, Engineering-Community: Wrap-up GSoC 2014 and FOSS OPW round 8 - https://phabricator.wikimedia.org/T717#950457 (10Qgil) [09:52:18] (03CR) 10Niharika29: [C: 031] "Tested. Looks okay for merge." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182189 (owner: 10Niharika29) [09:56:40] 3Project-Creators, Community-Engagement: Phabricator projects for Wikimedia sister projects - https://phabricator.wikimedia.org/T802#950459 (10Steinsplitter) >>! In T802#947035, @Aklapper wrote: >>>! In T802#937818, @Qgil wrote: >> I'm not sure about bringing another icon-color label. Communities are people, tea... [09:57:18] 3MediaWiki-Vagrant: Better gerrit integration of git clones and VM configuration - https://phabricator.wikimedia.org/T85502#950460 (10Yurik) We could make the simplification steps as part of the setup script (would be better to convert it to ruby though - more readable/flexible/debugable), and ruby is guaranteed... [09:59:09] 3ops-eqiad: virt1003.eqiad.wmnet /dev/sdb failed - https://phabricator.wikimedia.org/T85516#950461 (10fgiunchedi) 5Open>3Resolved done ``` virt1003:~$ cat /proc/mdstat Personalities : [linear] [multipath] [raid0] [raid1] [raid6] [raid5] [raid4] [raid10] md1 : active raid10 sdb2[8] sda2[0] sdc2[2] sdg2[6]... [09:59:13] 3Engineering-Community: Way of working in a good MediaWiki software project - https://phabricator.wikimedia.org/T85590#950463 (10Qgil) 3NEW [10:03:04] 3MediaWiki-Vagrant: vagrant run-test parameter parsing is broken on Windows - https://phabricator.wikimedia.org/T72876#950469 (10Yurik) @bd808, I need run-tests to be usable in debugging - e.g. run tests for one file or even a single unit test, not the whole suite of tests that take forever. Thus, I want to be a... [10:04:48] 3ops-codfw: ms-be2003.codfw.wmnet: slot=3 dev=sdd failed - https://phabricator.wikimedia.org/T85591#950471 (10fgiunchedi) 3NEW [10:07:57] 3Engineering-Community: Sort out [[:Category:Tutorials]] - https://phabricator.wikimedia.org/T85592#950475 (10Qgil) 3NEW [10:09:08] 3Engineering-Community: Sort out MediaWiki and Wikimedia tech presentations - https://phabricator.wikimedia.org/T85593#950481 (10Qgil) 3NEW [10:17:09] 3MediaWiki-Special-pages, MediaWiki-User-blocking: "This user is currently blocked" show always the newest block, which is sometimes not the current - https://phabricator.wikimedia.org/T85543#950488 (10Aklapper) [10:25:10] 3Multimedia, MediaWiki-File-management: After re-uploading a PDF file to mediawiki.org, users still see the thumbnail for the old version - https://phabricator.wikimedia.org/T38380#950492 (10TheDJ) So either we add "Cache-control: must-revalidate" and get a lot more hits on the backend, or we need to change the... [10:25:20] 3Wikimedia-Site-requests: Please upload last of the CGPGrey files to Wikimedia Commons - https://phabricator.wikimedia.org/T85282#950493 (101Veertje) They failed because there was a [í](https://en.wikipedia.org/wiki/%C3%8D) in the filename. In the previous batch of upload the pictures of Iceland also had issue... [10:27:05] 3Multimedia, MediaWiki-extensions-UploadWizard: Selecting many/multiple (>7?) files at once: Some are missing in the batch - https://phabricator.wikimedia.org/T41902#950494 (10Aklapper) p:5High>3Normal [10:46:28] 3MediaWiki-Interface: Support "lazy" image loading - https://phabricator.wikimedia.org/T36023#950499 (10Subfader) Meanwhile I think it should be a browser feature. [10:51:37] 3Wikimedia-SVG-rendering: textPath is not supported by rsvg - https://phabricator.wikimedia.org/T11420#950505 (10Aklapper) >>! In T11420#950240, @Perhelion wrote: > Partial patch upstream as: > https://bugzilla.gnome.org/show_bug.cgi?id=725558 > > But they seems not really willing to take this. The upstream co... [10:54:21] 3MediaWiki-Interface: Support "lazy" image loading - https://phabricator.wikimedia.org/T36023#950507 (10Aklapper) p:5Normal>3Volunteer? [10:55:13] (03PS14) 10TTO: Allow sysops to delete change tags with <= 5000 uses [core] - 10https://gerrit.wikimedia.org/r/181958 [10:55:15] (03PS1) 10UltrasonicNXT: Allow wikifarms to have global avatars [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/182357 [10:55:18] 3Parsoid, MediaWiki-File-management, Multimedia: Use content hash based image / thumb URLs - https://phabricator.wikimedia.org/T66214#950509 (10Subfader) Some JS scripts in extensions rely on the image name as they grab it to pass it to the API or thumb.php. So if this comes, please make sure to provide the pro... [10:56:39] (03CR) 10jenkins-bot: [V: 04-1] Allow sysops to delete change tags with <= 5000 uses [core] - 10https://gerrit.wikimedia.org/r/181958 (owner: 10TTO) [10:57:53] (03CR) 10TTO: "PS14 addresses most of Anomie's concerns, although please see PS13 for my replies/questions." [core] - 10https://gerrit.wikimedia.org/r/181958 (owner: 10TTO) [11:05:05] 3Wikimedia-General-or-Unknown: Category gives wrong number of pages - https://phabricator.wikimedia.org/T85527#950512 (10Aklapper) [11:07:14] 3MediaWiki-Documentation: docs/hooks.txt should not refer to deprecated wfRunHooks() function - https://phabricator.wikimedia.org/T85588#950513 (10Aklapper) p:5Triage>3Volunteer? [11:08:03] 3MediaWiki-Documentation: docs/hooks.txt should not refer to deprecated wfRunHooks() function - https://phabricator.wikimedia.org/T85588#950351 (10Aklapper) @TTO: GCI 2014: [[ https://www.mediawiki.org/wiki/Google_Code-in_2014#Mentors.27_corner | Become a mentor! ]] [11:09:02] andre__: I don't really want to become a mentor... it was just a suggestion for a task that might be good for GCI [11:09:24] tto: then find a mentor for it! :) [11:09:47] all "easy" tasks should be good candidates, but we need mentors :) [11:10:17] Ah, I didn't realise things *had* to have mentors, I assumed there was just a pool of mentors who worked across the whole of GCI... [11:10:33] Maybe next year I'll mentor :) [11:17:00] (03PS2) 10UltrasonicNXT: Allow wikifarms to have global avatars [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/182357 [11:22:11] 3MediaWiki-extensions-ContentTranslation: The publishing target location should be configurable per wiki - https://phabricator.wikimedia.org/T78229#950521 (10santhosh) a:3santhosh [11:23:10] (03PS3) 10UltrasonicNXT: Allow wikifarms to have global avatars [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/182357 [11:25:12] 3MediaWiki-extensions-SocialProfile: Allow avatars to be global - https://phabricator.wikimedia.org/T85070#950528 (10UltrasonicNXT) a:5ashley>3UltrasonicNXT What Lewis said there is exactly what I'm doing (total coincidence though, I never saw that!) [11:26:14] (03PS4) 10UltrasonicNXT: Allow wikifarms to have global avatars [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/182357 [11:26:50] (03CR) 10Umherirrender: [C: 032] "Possible move of Title::legalChars is a new issue which maybe needs discussion and can be done in a separate patch set when needed." [core] - 10https://gerrit.wikimedia.org/r/181942 (owner: 10McIntireEvan) [11:29:39] (03PS8) 10Umherirrender: Moved getTitleInvalidRegex() from Title to MediaWikiTitleCodec [core] - 10https://gerrit.wikimedia.org/r/181942 (owner: 10McIntireEvan) [11:29:57] (03CR) 10Umherirrender: [C: 032] Moved getTitleInvalidRegex() from Title to MediaWikiTitleCodec [core] - 10https://gerrit.wikimedia.org/r/181942 (owner: 10McIntireEvan) [11:32:54] (03PS5) 10Lewis Cawte: Allow wikifarms to have global avatars [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/182357 (owner: 10UltrasonicNXT) [11:35:56] (03Merged) 10jenkins-bot: Moved getTitleInvalidRegex() from Title to MediaWikiTitleCodec [core] - 10https://gerrit.wikimedia.org/r/181942 (owner: 10McIntireEvan) [11:38:41] (03PS4) 10Umherirrender: Remove normalizeAttributeValue() [core] - 10https://gerrit.wikimedia.org/r/181954 (owner: 10McIntireEvan) [11:38:48] (03CR) 10Umherirrender: [C: 032] Remove normalizeAttributeValue() [core] - 10https://gerrit.wikimedia.org/r/181954 (owner: 10McIntireEvan) [11:44:34] (03Merged) 10jenkins-bot: Remove normalizeAttributeValue() [core] - 10https://gerrit.wikimedia.org/r/181954 (owner: 10McIntireEvan) [11:49:10] (03CR) 10Umherirrender: "With Icd8662ecb9eb0f6c0ff9841bdbd5736d6dd0d015 the timestamp of the file upload is part of the log params, maybe that already is enough fo" [core] - 10https://gerrit.wikimedia.org/r/182299 (owner: 10RowanBeentje) [11:51:02] (03CR) 10Umherirrender: "It is just my opinion. There are also other tests outside of /libs/ with the PHPUnit_Framework_TestCase class, so maybe this is okay. My c" [core] - 10https://gerrit.wikimedia.org/r/182144 (owner: 10Chad) [12:02:50] (03CR) 10Fomafix: "Maybe the element would better generated on server side." [core] - 10https://gerrit.wikimedia.org/r/182293 (owner: 10Gerrit Patch Uploader) [12:06:42] (03CR) 10RowanBeentje: "Thanks @umherirrender - I'm using 1.24 which includes that patch, and I think the log message is somehow associated. However the log mess" [core] - 10https://gerrit.wikimedia.org/r/182299 (owner: 10RowanBeentje) [12:08:33] 3Project-Creators: ShoutWiki Team - https://phabricator.wikimedia.org/T85595#950543 (10lcawte) 3NEW [12:12:08] 3Project-Creators: Social Tools Project - https://phabricator.wikimedia.org/T85596#950549 (10lcawte) 3NEW [12:13:36] 3Project-Creators: ShoutWiki Team - https://phabricator.wikimedia.org/T85595#950555 (10lcawte) [12:31:12] 3CirrusSearch, MediaWiki-Core-Team: PHP Warnings when "startingOver" an index - https://phabricator.wikimedia.org/T75457#950562 (10SmartK) I can confirm that this is **resolved** now. I tried the "master" version of CirrusSearch together with MediaWiki 1.24.1. Thank you again. [12:37:20] (03PS6) 10Sumit: Database::makeList() : Handle NULL when building 'IN' clause [core] - 10https://gerrit.wikimedia.org/r/181681 [12:38:27] (03CR) 10Sumit: "@Please Stand, I went ahead with the latter suggestion, and did away with the additional $cond variable" [core] - 10https://gerrit.wikimedia.org/r/181681 (owner: 10Sumit) [12:44:58] 3CirrusSearch: CirrusSearch: Using * should search exact matches, not stemmed matches - https://phabricator.wikimedia.org/T58163#950565 (10SmartK) 5Resolved>3Open The problem seems to be back with the master version of CirrusSearch and Elastica and mw 1.24.1. [12:48:03] 3MediaWiki-extensions-CodeEditor, MediaWiki-Page-editing: LivePreview: no changes reflected on preview/diff when using CodeEditor - https://phabricator.wikimedia.org/T78838#950567 (10Fomafix) https://gerrit.wikimedia.org/r/182354 is an other solution without trigger `LivePreviewPrepare`. [12:48:06] 3MediaWiki-JavaScript: JavaScript stopped working on Wikipedia in Spanish due to RefToolbar gadget which uses jQuery's .live() - https://phabricator.wikimedia.org/T85489#950568 (10Aklapper) [13:04:14] 3Wikimedia-Git-or-Gerrit: No "Change had a related patchset uploaded" message when bug reference is amended - https://phabricator.wikimedia.org/T85594#950570 (10Aklapper) [13:04:18] 3Wikimedia-Git-or-Gerrit: No "Change had a related patchset uploaded" message when bug reference is amended - https://phabricator.wikimedia.org/T85594#950534 (10Aklapper) https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines :) [13:17:57] 3MediaWiki-Interface: Section headings should have some clickable anchor for passing links - https://phabricator.wikimedia.org/T18691#950576 (10Dpkshrma) Hi all! Is anyone working on this bug or is it still open to take? If its open, I have tried to make a few changes to my test wiki to get the desired results... [13:28:26] (03PS6) 10Lewis Cawte: Allow wikifarms to have global avatars [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/182357 (owner: 10UltrasonicNXT) [13:29:17] (03CR) 10Jack Phoenix: [C: 032] Allow wikifarms to have global avatars [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/182357 (owner: 10UltrasonicNXT) [13:29:28] (03Merged) 10jenkins-bot: Allow wikifarms to have global avatars [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/182357 (owner: 10UltrasonicNXT) [13:36:52] 3Project-Creators: Social Tools Project - https://phabricator.wikimedia.org/T85596#950583 (10Aklapper) I'm afraid that the proposed scope might collide with projects already existing for specific extensions like https://phabricator.wikimedia.org/tag/mediawiki-extensions-socialprofile/ - wondering how to make cle... [13:36:59] 3Project-Creators: Social Tools Project - https://phabricator.wikimedia.org/T85596#950584 (10Aklapper) p:5Triage>3Normal [13:40:43] 3Project-Creators: ShoutWiki Team - https://phabricator.wikimedia.org/T85595#950585 (10Aklapper) p:5Triage>3Low Could you elaborate why you'd like to restrict joining that team? (Wondering whether to call this "ShoutWiki-Team" to differentiate from some potential codebase but probably that's overkill - we c... [13:46:52] 3MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-UniversalLanguageSelector, Wikidata: ULS on Wikidata.org does not work when"compact personal bar" beta feature is enabled - https://phabricator.wikimedia.org/T85541#950587 (10Aklapper) [13:47:05] 3MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-UniversalLanguageSelector, Wikidata: ULS on Wikidata.org does not work when "compact personal bar" beta feature is enabled - https://phabricator.wikimedia.org/T85541#949210 (10Aklapper) [13:48:49] 3Wikimedia-Site-requests: Restrict accountcreator permissions on enwiki - https://phabricator.wikimedia.org/T85538#950589 (10Aklapper) p:5Triage>3Normal [13:49:59] 3MediaWiki-extensions-SocialProfile: Allow avatars to be global - https://phabricator.wikimedia.org/T85070#950591 (10ashley) 5Open>3Resolved Thanks @lcawte and @UltrasonicNXT for the patch! [13:53:40] 3MediaWiki-Search: SpecialSearchResults hook, num/total counts aren't adjusted after hook execution - https://phabricator.wikimedia.org/T85597#950594 (10mwjames) 3NEW [13:56:04] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Move entity suggester blacklist to a MediaWiki-page - https://phabricator.wikimedia.org/T78399#950602 (10Lucie) Just wrote a tiny and very slowly script, whicht foung onlx four properties- P357, P107, P198 and P643. Is this a realistic number? Or are there supp... [13:57:45] This might be a dumb question, but if I load a stylesheet with js, can I unload it? Like a toggle function? [13:58:14] 3MediaWiki-extensions-GlobalUserPage: Purge varnish after GlobalUserPage is updated on the central wiki - https://phabricator.wikimedia.org/T76410#950603 (10Aklapper) p:5Triage>3Normal [13:58:22] 3MediaWiki-extensions-GlobalUserPage: Decide what to do about the global user page banner - https://phabricator.wikimedia.org/T75634#950605 (10Aklapper) p:5Triage>3Low [13:58:26] Or do I have to rebuild the whole thing as jQuery style changes? [13:58:29] 3MediaWiki-extensions-GlobalUserPage: GlobalUserPage: Improve border around footer - https://phabricator.wikimedia.org/T72629#950607 (10Aklapper) p:5Triage>3Volunteer? [13:58:37] T13|mobile: http://stackoverflow.com/questions/1598899/unload-css-from-webpage [13:58:45] 3CirrusSearch: CirrusSearch: Using * should search exact matches, not stemmed matches - https://phabricator.wikimedia.org/T58163#950609 (10Manybubbles) I'll check. [14:00:47] poxip: I don't see a link element for my vector.css... [14:01:06] How can I disable that? [14:01:08] how do you load it? [14:01:23] https://developerssolutions.wordpress.com/2010/07/28/load-css-dynamically/ [14:03:13] It's loaded through the parser as //bits.wikimedia.org/en.wikipedia.org/load.php....%7Cskins.vector.styles&... [14:03:47] If I disable load.php link element that blows the whole page up... [14:05:24] anomie: was my comment to red on your talkpage about needing to load stylesheets correct? [14:05:44] T13|mobile: Haven't seen it yet [14:06:57] (S)he was trying to importScript one of your scripts across wikis. [14:07:09] 3CirrusSearch: CirrusSearch: Using * should search exact matches, not stemmed matches - https://phabricator.wikimedia.org/T58163#950610 (10Manybubbles) Ok - its working for me on the branches I'm on now (basically master everywhere, settings that are mostly like enwiktionary.) Can you post the result of adding... [14:07:11] Templatemodified one. [14:07:13] 3Project-Creators: ShoutWiki Team - https://phabricator.wikimedia.org/T85595#950611 (10lcawte) As for the naming. It shouldn't - unless the Foundation is going to start hosting our code for us which I imagine is highly unlikely without the involvement of lawyers and cheques. The restriction is because we're a "... [14:08:33] (03CR) 10Manybubbles: [C: 032] Remove random support [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/182142 (owner: 10Chad) [14:08:58] (03Merged) 10jenkins-bot: Remove random support [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/182142 (owner: 10Chad) [14:09:54] poxip: "Sorry, no posts matched your criteria." For WordPress. [14:10:20] Nvm I was missing an s [14:10:22] brb [14:12:04] (03PS1) 10UltrasonicNXT: Move static functions into their own file [extensions/Comments] - 10https://gerrit.wikimedia.org/r/182361 [14:19:20] 3Wikidata, Project-Creators: create time-bomb - https://phabricator.wikimedia.org/T75893#950613 (10Aklapper) p:5Normal>3Low Lowering priority while waiting for input if other teams are interested in this too. [14:19:36] 3Wikidata, Project-Creators: Create "time-bomb" tag - https://phabricator.wikimedia.org/T75893#950615 (10Aklapper) [14:19:53] 3Engineering-Community: Self-help guide to organize events - https://phabricator.wikimedia.org/T85598#950616 (10Qgil) 3NEW [14:21:05] 3Engineering-Community: Guided Tour at mediawiki.org? - https://phabricator.wikimedia.org/T85599#950622 (10Qgil) 3NEW [14:21:39] 3Engineering-Community: Who are the top 50 independent contributors and what do they need from the WMF? - https://phabricator.wikimedia.org/T85600#950628 (10Qgil) 3NEW [14:22:20] 3Engineering-Community: Welcoming new users to mediawiki.org - https://phabricator.wikimedia.org/T85601#950634 (10Qgil) 3NEW [14:23:07] 3Project-Creators: Social Tools Project - https://phabricator.wikimedia.org/T85596#950640 (10lcawte) Maybe it would be better off as a team, I'm not really sure. As for the description, writing has never been my strong point, something like this perhaps? ``` Umbrella project for coordinating and managing all [[... [14:23:15] wikibugs: hush. [14:23:54] 3Engineering-Community: Reaching out to potential technical contributors in Wikimedia projects - https://phabricator.wikimedia.org/T85602#950641 (10Qgil) 3NEW [14:24:40] 3Engineering-Community: Greeters to greet new technical contributors - https://phabricator.wikimedia.org/T85603#950647 (10Qgil) 3NEW [14:28:21] 3Engineering-Community: Move ECT's on-wiki backlogs to Phabricator - https://phabricator.wikimedia.org/T1034#950653 (10Qgil) a:5Qgil>3Rfarrand I have created a bunch of (draft) tasks extracted from [[ https://www.mediawiki.org/w/index.php?title=User%3AQgil-WMF&diff=1337206&oldid=1129298 | here ]]. Passing t... [14:28:26] 3Project-Creators: Add needs-consensus tag for "contested" tickets - https://phabricator.wikimedia.org/T76311#950656 (10Aklapper) I understand the intention but I would still like to know why the "stalled" status is not sufficient or why you do not see the described situation as a sub-case of "stalled". When I... [14:35:28] 3Community-Engagement, Project-Creators: Phabricator projects for Wikimedia sister projects - https://phabricator.wikimedia.org/T802#950659 (10Qgil) Is there any problem with "Commons" for starters? [14:36:22] (03PS2) 10UltrasonicNXT: Rewrite [extensions/Comments] - 10https://gerrit.wikimedia.org/r/182361 [14:37:58] (03CR) 10Florianschmidtwelzow: [C: 04-1] Bug T70750, replaced deprecated wfMsg*() functions (035 comments) [extensions/ShoutBox] - 10https://gerrit.wikimedia.org/r/182352 (owner: 10Georggi199) [14:39:36] (03CR) 10Fomafix: [C: 031] resourceloader: Make arguments to mw.loader.implement optional [core] - 10https://gerrit.wikimedia.org/r/180659 (owner: 10Krinkle) [14:40:41] (03PS11) 10TheDJ: Only return CORS headers in the response as required [core] - 10https://gerrit.wikimedia.org/r/177545 [14:43:52] (03CR) 10PleaseStand: Database::makeList() : Handle NULL when building 'IN' clause (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181681 (owner: 10Sumit) [14:45:30] (03PS3) 10UltrasonicNXT: Rewrite [extensions/Comments] - 10https://gerrit.wikimedia.org/r/182361 [14:47:50] 3Project-Creators: MediaWiki-extensions-Farmer - https://phabricator.wikimedia.org/T85413#950687 (10Aklapper) 5Open>3stalled I'm asking for this because there's not much sense in creating a bugtracker somewhere on the internet if no maintainer (if existing) is aware of that bugtracker. Even worse if there is... [14:50:09] 3Project-Creators: Create "gerrit-patch-uploader" project - https://phabricator.wikimedia.org/T85359#950690 (10Aklapper) 5Open>3Resolved a:3Aklapper Requested project has been created. If for some reason you ever want to rename the project, please check [[ https://www.mediawiki.org/wiki/Phabricator/Creatin... [14:52:51] (03CR) 10Florianschmidtwelzow: Add version check for Vector (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/179887 (owner: 10Florianschmidtwelzow) [15:00:19] (03CR) 10Anomie: [C: 04-1] Only return CORS headers in the response as required (032 comments) [core] - 10https://gerrit.wikimedia.org/r/177545 (owner: 10TheDJ) [15:00:56] thedj: ^ If you can knock out the two bugs there, it'd be nice to get that merged finally. [15:04:17] 3MediaWiki-skins-Vector: Vector sidebar transition is not in sync with logo/content transition. - https://phabricator.wikimedia.org/T85614#950750 (10Krinkle) 3NEW [15:04:43] (03PS4) 10UltrasonicNXT: Rewrite [extensions/Comments] - 10https://gerrit.wikimedia.org/r/182361 [15:05:19] (03PS1) 10Niharika29: Fix an incorrectly placed closing div tag [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182362 [15:05:26] (03CR) 10Krinkle: "Introduced bug T85614. mw-panel transition was inadvertently changed from padding-left to padding-right. And since there is no padding-rig" [core] - 10https://gerrit.wikimedia.org/r/87165 (owner: 10Jdlrobson) [15:05:32] (03PS7) 10Sumit: Database::makeList() : Handle NULL when building 'IN' clause [core] - 10https://gerrit.wikimedia.org/r/181681 [15:05:44] 3MediaWiki-skins-Vector: Vector sidebar transition is not in sync with logo/content transition. - https://phabricator.wikimedia.org/T85614#950750 (10Krinkle) [15:06:18] (03CR) 10Niharika29: [C: 032] "Very trivial. Self-merging." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182362 (owner: 10Niharika29) [15:06:21] 3MediaWiki-skins-Vector: Vector sidebar transition is not in sync with logo/content transition. - https://phabricator.wikimedia.org/T85614#950761 (10Krinkle) Regression introduced in [99c92a87fc32fb8](https://gerrit.wikimedia.org/r/87165). [15:06:23] (03Merged) 10jenkins-bot: Fix an incorrectly placed closing div tag [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182362 (owner: 10Niharika29) [15:06:53] (03CR) 10Sumit: "@Please Stand, I noted semantic error, and incorporated the suggestion" [core] - 10https://gerrit.wikimedia.org/r/181681 (owner: 10Sumit) [15:09:29] (03Abandoned) 10Paladox: Convert entry point to use explicit globals [extensions/WikiEditor] (REL1_24) - 10https://gerrit.wikimedia.org/r/175296 (owner: 10Paladox) [15:09:50] (03PS13) 10Paladox: Update Moment.js from 2.8.3 to 2.8.4 [core] - 10https://gerrit.wikimedia.org/r/174796 [15:24:05] { "query": { "normalized": [ { "from": "User_talk:Technical_13/2014/4", "to": "User talk:Technical 13/2014/4" } ], "pages": { "44383636": { "pageid": 44383636, [15:24:20] How do I get to page id? [15:25:30] Technical_13: context? [15:26:15] I'm trying to get a page size of a page I'm not on through the API. [15:26:34] parseInt( archivePageData.query.pages[ ??? ].revisions[0]['size'], 10 ) How do I fill in the ??? with the other page's id so I can get to size? [15:26:48] this is JS? [15:26:55] yes [15:27:20] Technical_13: pages.values(), or something like that? [15:27:28] Do I have to create an extra $.map() function to get it? or is there an easier way? [15:27:47] trying [15:28:07] JS doesn't seem to have that :/ [15:28:11] (03PS3) 10Manybubbles: Remove $wgCirrusSearchEnablePref [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/180995 (owner: 10Chad) [15:28:17] anyway, you can enumerate over pages [15:28:39] (03CR) 10Manybubbles: "PS3 removes the actual config variable now that we don't use it." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/180995 (owner: 10Chad) [15:28:45] for (pageid in pages) { page = pages[pageid]; } [15:28:50] .query.pages.values is not a function [15:28:53] var size = 0; for (var pageid in archivePageData.query.pages) { parseInt( archivePageData.query.pages[pageid].revisions[0]['size'], 10); break; } [15:29:00] Technical_13: ^ [15:29:03] also tried val() and vals() with same result. [15:29:24] 3MediaWiki-History-or-Diffs, MediaWiki-Internationalization: Figure out how LTR edit summaries should display in a history listing using an RTL language, and the markup necessary to make that happen - https://phabricator.wikimedia.org/T85616#950776 (10Anomie) 3NEW [15:31:17] Vulpix: for ( var pageid in archivePageData.query.pages ) { var archivePageSize = parseInt( archivePageData.query.pages[pageid].revisions[0]['size'], 10 ); }//worked. :) [15:31:47] 3MediaWiki-Parser: Section edit containing "/*" is mis-parsed - https://phabricator.wikimedia.org/T70361#950788 (10Anomie) 5Open>3Resolved a:3Anomie This should be deployed to WMF wikis with 1.25wmf14, see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the schedule. [15:31:50] 3MediaWiki-History-or-Diffs: Edit summaries containing multiple autocomments are broken - https://phabricator.wikimedia.org/T18530#950791 (10Anomie) 5Open>3Resolved a:3Anomie This should be deployed to WMF wikis with 1.25wmf14, see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the schedule. [15:32:42] :) [15:33:49] 3MediaWiki-API: allimages api query doesn't allow multiple mime types - https://phabricator.wikimedia.org/T78690#950797 (10Anomie) True, but it'll be deployed with that version anyway. [15:39:51] 3MediaWiki-Search: Interwiki search results lack namespace in link - https://phabricator.wikimedia.org/T85618#950800 (10Nemo_bis) 3NEW [15:41:57] (03CR) 10Chad: [C: 031] Remove $wgCirrusSearchEnablePref [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/180995 (owner: 10Chad) [15:42:50] 3MediaWiki-Documentation: Clear documentation should be provided about the *my* permissions - https://phabricator.wikimedia.org/T69167#950811 (10Aklapper) @D_konto: Please provide a link to your change... [15:45:27] (03CR) 10Chad: "phd still seems hit-or-miss with me as well. sometimes it'll start but you can't assume it'll manage everything perfectly. I'm open to sug" [vagrant] - 10https://gerrit.wikimedia.org/r/178643 (owner: 10Chad) [15:46:54] 3MediaWiki-Parser: Subpage link syntax for files ([[File:Foo.jpg|link=/Subpage]]) doesn't work - https://phabricator.wikimedia.org/T36502#950815 (10Ciencia_Al_Poder) [15:48:16] 3MediaWiki-Internationalization: Create "how to rewrite a log to use the new system" tutorial/manual - https://phabricator.wikimedia.org/T44893#950823 (10Aklapper) What is "the new system"? What was "the old system"? I have no idea what this task is about and if this is still relevant. [15:48:59] 3MediaWiki-Documentation: Documentation is out of date, incomplete (tracking) - https://phabricator.wikimedia.org/T2001#950828 (10Aklapper) [15:50:52] (03CR) 10Manybubbles: [C: 032] Remove $wgCirrusSearchEnablePref [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/180995 (owner: 10Chad) [15:51:14] (03Merged) 10jenkins-bot: Remove $wgCirrusSearchEnablePref [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/180995 (owner: 10Chad) [15:51:18] 3Wikimedia-Site-requests: Create uploader on kowiki - https://phabricator.wikimedia.org/T85621#950838 (10Revi) 3NEW [15:53:30] (03CR) 10Hoo man: [C: 032] Use PHPUnit_Framework_TestCase in a few utils/ tests [core] - 10https://gerrit.wikimedia.org/r/182144 (owner: 10Chad) [15:54:32] in javascript, to make a URL, is encodeURI() still the best way to go? [15:55:13] Technical_13: to make an URL for what? A URL from a page name? [15:55:26] yes [15:55:35] wiki encoded page name. [15:56:06] Technical_13: mw.util.wikiGetlink('Page name') [15:56:14] encodeURI( 'User:Where are my shoez?' ) [15:56:18] ah.. yes, that will work better. thanks. [15:57:43] if you want to encode a query string parameter, use encodeURIComponent. For example "/api.php?action=" + encodeURIComponent("whatever") [15:57:51] 3Project-Creators: Create "Epic" project - https://phabricator.wikimedia.org/T78343#950846 (10Aklapper) > Long-themed tasks that teams are working on. Is that a requirement? Or can I set the "epic" tag on tasks that no teams are working on? I am tempted to add the "epic" tag to Task 59801 (Improving the skinnin... [15:58:12] in fact, I've never used encodeURI() in my lifetime [15:59:19] (03Merged) 10jenkins-bot: Use PHPUnit_Framework_TestCase in a few utils/ tests [core] - 10https://gerrit.wikimedia.org/r/182144 (owner: 10Chad) [16:01:22] Vulpix: errorLog.archivePageSize = '' + archiveName + '" does not exist.'; [16:01:54] mw.util or encodeURIComponent? [16:02:18] 3MediaWiki-Parser: title/tooltip missing on file with empty link - https://phabricator.wikimedia.org/T23454#950861 (10Ciencia_Al_Poder) a:5Umherirrender>3Jackmcbarn [16:03:48] 3Project-Creators: Create "Epic" project - https://phabricator.wikimedia.org/T78343#950865 (10Chad) >>! In T78343#950846, @Aklapper wrote: >> Long-themed tasks that teams are working on. > > Is that a requirement? Or can I set the "epic" tag on tasks that no teams are working on? > I am tempted to add the "epic... [16:04:05] Technical_13: '' + archiveName + '"' [16:05:07] modified my href. Still need the class and the title. :) [16:05:18] 3Wikimedia-Site-requests: Create uploader on kowiki - https://phabricator.wikimedia.org/T85621#950868 (10Glaisher) a:3Glaisher [16:05:35] 3Wikimedia-Site-requests: Create uploader on kowiki - https://phabricator.wikimedia.org/T85621#950838 (10Glaisher) [16:06:59] 3Wikimedia-Site-requests: Create uploader on kowiki - https://phabricator.wikimedia.org/T85621#950838 (10Glaisher) @revi who should be able to add/remove users from this group? [16:09:24] 3Wikimedia-Site-requests: Create uploader on kowiki - https://phabricator.wikimedia.org/T85621#950871 (10Revi) >>! In T85621#950868, @Glaisher wrote: > @revi who should be able to add/remove users from this group? Sysops should be able to promote/demote uploader. [16:09:32] (03CR) 10Anomie: [C: 032] Fix title equality checking and closure style [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/182196 (owner: 10Jackmcbarn) [16:09:56] (03Merged) 10jenkins-bot: Fix title equality checking and closure style [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/182196 (owner: 10Jackmcbarn) [16:12:10] anomie: perhaps after dinner [16:13:31] (03CR) 10Anomie: [C: 032] Use preview content when it transcludes itself [core] - 10https://gerrit.wikimedia.org/r/137153 (owner: 10Jackmcbarn) [16:14:21] (03CR) 10BryanDavis: [C: 032] "It is not prefect, but I think the role is a good start. If folks start using it then maybe they can find ways to make it better." [vagrant] - 10https://gerrit.wikimedia.org/r/178643 (owner: 10Chad) [16:14:31] (03Merged) 10jenkins-bot: Phab role based on IEGReview [vagrant] - 10https://gerrit.wikimedia.org/r/178643 (owner: 10Chad) [16:14:35] ^d: ^ [16:14:48] in other news I can't spell today [16:14:57] "prefect" [16:14:57] 3MediaWiki-Documentation, dev.wikimedia.org, Project-Creators, Engineering-Community: Create Documentation tag - https://phabricator.wikimedia.org/T85485#950876 (10Aklapper) Description says "//technical// documentation". Would e.g. Task 64446 still be "technical documentation" or already user docs (if something... [16:15:01] <^d> I owe you beers :D [16:15:15] <^d> ty bd808!! [16:15:24] yw. now make cool things [16:15:57] (03PS5) 10BryanDavis: Add collaboration question in application [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182189 (owner: 10Niharika29) [16:16:03] <^d> I've been making cool upstream things :) [16:16:21] oh yeah. you're fixing up search right? [16:16:57] <^d> https://secure.phabricator.com/differential/query/a.qxukYmOxmi/#R [16:16:59] <^d> Yepppp [16:19:28] (03Merged) 10jenkins-bot: Use preview content when it transcludes itself [core] - 10https://gerrit.wikimedia.org/r/137153 (owner: 10Jackmcbarn) [16:19:41] 3MediaWiki-General-or-Unknown: Add Zend Optimizer to object caching - https://phabricator.wikimedia.org/T21193#950884 (10Ciencia_Al_Poder) 5Open>3Invalid a:3Ciencia_Al_Poder https://en.wikipedia.org/wiki/List_of_PHP_accelerators#Zend_Opcache_.28ex._Zend_Optimizer.2B.29 > Zend Optimizer+ was renamed to Zen... [16:19:48] <^d> bd808: Evan's been super receptive to ES improvements since it's not really his thing. [16:19:55] <^d> Long as it works, he sees it as an improvement :) [16:20:18] That's cool. Now if he'd just review my xhprof patches... [16:20:26] jackmcbarn: Re 137153, I note that LinkCache has a tendency to decide the link is bad again after its linked to or transcluded despite the TitleExists hook, and #ifexist trusts LinkCache on that. I'm not sure what a good way to fix that might be, though. [16:22:26] (03PS1) 10Niharika29: Set value of "Primary language community" using jquery if primary project is Commons/Data/Outreach/Species [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182366 [16:26:32] 3Wikimedia-Site-requests: Create uploader on kowiki - https://phabricator.wikimedia.org/T85621#950906 (10Revi) [16:26:48] (03CR) 10Anomie: Allow sysops to delete change tags with <= 5000 uses (032 comments) [core] - 10https://gerrit.wikimedia.org/r/181958 (owner: 10TTO) [16:27:45] 3Multimedia: Test mw.fileApi - https://phabricator.wikimedia.org/T85040#950908 (10MarkTraceur) 5Open>3Resolved [16:27:51] (03CR) 10BryanDavis: [C: 032] Add collaboration question in application [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182189 (owner: 10Niharika29) [16:27:54] 3Multimedia, MediaWiki-extensions-UploadWizard: Test step controllers - https://phabricator.wikimedia.org/T78792#950909 (10MarkTraceur) 5Open>3Resolved [16:27:55] (03Merged) 10jenkins-bot: Add collaboration question in application [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182189 (owner: 10Niharika29) [16:28:16] (03PS2) 10BryanDavis: Set value of "Primary language community" using jquery if primary project is Commons/Data/Outreach/Species [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182366 (owner: 10Niharika29) [16:28:40] happy new year [16:29:06] Same to you! :) [16:29:23] * poxip kidding :> [16:29:25] huehue [16:30:01] Hello users! I added a new feature. If you are bored, and dont know what task to do, just do: 'gcibot, random orgname', example 'gcibot, random sugar' [16:30:02] it's not even 8PM [16:30:22] gcibot: random orgname [16:30:27] gcibot, random orgname [16:30:50] gcibot, random sugar [16:31:13] 3Wikimedia-Site-requests: Create uploader on kowiki - https://phabricator.wikimedia.org/T85621#950915 (10Revi) [16:31:21] (03CR) 10BryanDavis: [C: 032] "neat trick" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182366 (owner: 10Niharika29) [16:31:23] (03Merged) 10jenkins-bot: Set value of "Primary language community" using jquery if primary project is Commons/Data/Outreach/Species [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/182366 (owner: 10Niharika29) [16:31:26] *random sugarlabs* sorry. [16:31:45] gcibot: random sugar [16:32:24] 3MediaWiki-Parser: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing - https://phabricator.wikimedia.org/T14974#950920 (10Ciencia_Al_Poder) [16:34:00] gcibot, random wikimedia [16:34:00] GEOFBOT, random task in wikimedia: https://www.google-melange.com/gci/task/view/google/gci2014/5869078463905792 [16:34:00] Fix 3 todos in MediaWiki core (06) [16:34:00] Status: Open [16:34:00] Mentor(s): Nemo_bis [16:34:03] oh snap [16:34:30] gcibot, you rock [16:34:30] ignacio, I know, lml. [16:34:46] lol [16:37:02] gcibot, random apertium [16:37:03] Nemo_bis, random task in apertium: https://www.google-melange.com/gci/task/view/google/gci2014/6105778758877184 [16:37:03] Improve the quality of a language pair of choice by adding 50 words to its vocabulary [16:37:03] Status: Reopened [16:37:03] Mentor(s): Mikel Forcada, Jonathan, Kevin Brubeck Unhammer, Xavi Ivars, Raveesh [16:37:24] Usual stuff ;) [16:37:40] gcibot, i love you [16:37:40] ignacio, Sorry, I'm a bot. I haven't feelings. [16:37:41] XD [16:38:00] I heard this excuse before [16:39:20] (03CR) 10Anomie: [C: 04-1] "-1 for the unaddressed issues in PS13." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181958 (owner: 10TTO) [16:39:42] (03PS1) 10Chad: Keep backend param to search API as long as there's a backend [core] - 10https://gerrit.wikimedia.org/r/182368 [16:39:47] 3dev.wikimedia.org, MediaWiki-Documentation, Project-Creators, Engineering-Community: Create Documentation tag - https://phabricator.wikimedia.org/T85485#950935 (10Aklapper) @Spage: Let me try to understand your workflow needs by asking ignorant questions and adding high-level rants. : I'm not convinced h... [16:41:54] 3ops-core: Better abstractions for puppet & icinga/nagios/shinken - https://phabricator.wikimedia.org/T85624#950936 (10faidon) 3NEW [16:42:12] <^d> shouldn't that stuff go in operations? [16:43:39] probably :) [16:44:44] ^d: if you give https://gerrit.wikimedia.org/r/#/c/182235/ a lookover, it will happen =p [16:45:20] <^d> It looks ok and I could merge but I dunno what to do with it [16:45:21] <^d> :) [16:46:45] well, should (TM) work now [16:49:55] 3Project-Creators, MediaWiki-Documentation, dev.wikimedia.org, Engineering-Community: Create Documentation tag - https://phabricator.wikimedia.org/T85485#950947 (10Aklapper) Spontaneous thought after adding my last comment: If a "dev closes code task as fixed, now either docs and/or qa should do their work" work... [16:50:06] 3MediaWiki-Recent-changes: Mark edits in Special:Recentchanges with (top), as in Special:Contributions - https://phabricator.wikimedia.org/T10482#950948 (10Ciencia_Al_Poder) p:5Low>3Volunteer? [16:57:53] (03CR) 10PleaseStand: [C: 031] "Looks OK, seems to work in simple tests." [core] - 10https://gerrit.wikimedia.org/r/181681 (owner: 10Sumit) [16:57:59] (03CR) 10Manybubbles: [C: 031] "Makes sense to me. I'd +2 but everything in code deserves a bit more code review just in case." [core] - 10https://gerrit.wikimedia.org/r/182368 (owner: 10Chad) [16:58:46] <^d> manybubbles: It's easy enough to test :) [16:59:00] <^d> If you only have one backend, you should see the backend param available in the documentation. [16:59:09] ^d: but I've shut down vagrant :( [16:59:27] bringing it back up [16:59:46] (03PS10) 10BryanDavis: Ping server to keep the session alive [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/179471 (owner: 10Niharika29) [17:00:11] man, it was unacceptably cold this morning [17:00:12] <^d> manybubbles: http://localhost:8080/w/api.php?action=help&modules=query%2Bsearch [17:00:57] <^d> It was so nice last week too [17:02:58] (03CR) 10Manybubbles: [C: 032] Keep backend param to search API as long as there's a backend [core] - 10https://gerrit.wikimedia.org/r/182368 (owner: 10Chad) [17:03:04] (03CR) 10Manybubbles: "Works for me." [core] - 10https://gerrit.wikimedia.org/r/182368 (owner: 10Chad) [17:03:12] there [17:03:31] ^d: yeah! we had 70 degrees! [17:03:36] this morning it was 29 [17:03:56] <^d> That'll make it easier to shut off the last 3 lsearchds. [17:04:05] <^d> The param won't disappear, just the extra value. [17:08:38] (03Merged) 10jenkins-bot: Keep backend param to search API as long as there's a backend [core] - 10https://gerrit.wikimedia.org/r/182368 (owner: 10Chad) [17:11:28] (03CR) 10Parent5446: [C: 031] "I agree with composer.local.json. I might be wrong, but the goal should generally be to get rid of the extensions/ directory, and have ext" [core] - 10https://gerrit.wikimedia.org/r/182323 (owner: 10BryanDavis) [17:14:43] (03CR) 10tosfos: New version 3.0.0 (031 comment) [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/175309 (owner: 10DavisNT) [17:16:00] 3MediaWiki-skins-Vector: Vector sidebar transition is not in sync with logo/content transition. - https://phabricator.wikimedia.org/T85614#950960 (10Jdlrobson) I never understood the transitions. They come across as someone's excuse to play with CSS transitions/media queries for the first time. They don't actua... [17:17:27] 3MediaWiki-Documentation: Documentation is out of date, incomplete (tracking) - https://phabricator.wikimedia.org/T2001#950964 (10scfc) [17:19:19] 3MediaWiki-extensions-WikibaseRepository: When connecting links the suggester is suggesting pages that does not exist - https://phabricator.wikimedia.org/T85625#950965 (10Stryn) 3NEW [17:19:24] 3Wikimedia-Wikimania-Scholarships: Update scoring for Phase 2 - https://phabricator.wikimedia.org/T85486#950971 (10Shouston_WMF) Should be 50/50. [17:20:16] 3Wikimedia-Wikimania-Scholarships: Update "Most active Wiki" question - https://phabricator.wikimedia.org/T85287#950973 (10Shouston_WMF) Good catch, please add MediaWiki to the list. [17:20:45] 3Wiki-Release-Team: Mentor Google Code-in 2014 Student(s) Who Compile a List of Top Requested Features - https://phabricator.wikimedia.org/T953#950974 (10Palexis) Fourth: https://www.mediawiki.org/wiki/MediaWiki_Stakeholders%27_Group/Tasks/Feature_wishlist/Pranav_K_June [17:21:30] (03PS15) 1020after4: Huge refactor of security policy enforcer stuff. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 [17:22:47] (03PS5) 10BryanDavis: parsoid: Copy logs to logstash [vagrant] - 10https://gerrit.wikimedia.org/r/173936 [17:22:55] (03CR) 10BryanDavis: [C: 032] parsoid: Copy logs to logstash [vagrant] - 10https://gerrit.wikimedia.org/r/173936 (owner: 10BryanDavis) [17:23:05] (03Merged) 10jenkins-bot: parsoid: Copy logs to logstash [vagrant] - 10https://gerrit.wikimedia.org/r/173936 (owner: 10BryanDavis) [17:23:55] grrrit-wm: doesn't include links to phab from the commit msg [17:23:55] it does bugzilla [17:23:55] does for [17:27:33] grrrit-wm doesn't include links to phab from the commit msg - https://phabricator.wikimedia.org/T85626#950975 (10Glaisher) 3NEW [17:27:51] 3MediaWiki-extensions-ParserFunctions: ifexist: when creating a page - https://phabricator.wikimedia.org/T85408#950981 (10Jackmcbarn) 5Open>3Resolved a:3Jackmcbarn The fix will be live on all WMF wikis on January 14th. [17:28:27] 3MediaWiki-Templates: Self-including templates should reflect changes on preview - https://phabricator.wikimedia.org/T7278#950984 (10Jackmcbarn) 5Open>3Resolved a:3Jackmcbarn The fix will be live on all WMF wikis on January 14th. [17:28:28] 3MediaWiki-extensions-ParserFunctions: ifexist: when creating a page - https://phabricator.wikimedia.org/T85408#950987 (10Jackmcbarn) [17:35:41] (03CR) 10Jack Phoenix: "Looks sane. Most of my comments aren't even directly related to this changeset, just those "would be nice to get eventually done in order " (036 comments) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/182361 (owner: 10UltrasonicNXT) [17:41:13] (03PS12) 10TheDJ: Only return CORS headers in the response as required [core] - 10https://gerrit.wikimedia.org/r/177545 [17:42:53] (03PS1) 10Glaisher: Add task link to grrrit-wm irc message [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/182369 [17:43:10] (03CR) 10TheDJ: Only return CORS headers in the response as required (034 comments) [core] - 10https://gerrit.wikimedia.org/r/177545 (owner: 10TheDJ) [17:43:54] anomie: so in other fun news... Postman doesn't allow you to send a header with an empty value :) [17:45:07] 3Wiki-Release-Team: January 10, 2015 (Saturday) MediaWiki Stakeholders Group Meeting - https://phabricator.wikimedia.org/T76904#951008 (10Palexis) [17:49:35] 3MediaWiki-Change-tagging, MediaWiki-API: Create ability to add / remove tags from edits / actions - https://phabricator.wikimedia.org/T20670#951016 (10Anomie) >>! In T20670#950159, @TTO wrote: > ** Notably, the OAuth extension doesn't bother to define the tags it uses. Impolite, if you ask me! Defining every p... [17:51:01] thedj: Hmm. I just used ``echo -en '...' | nc localhost 80`` ;) [17:52:45] actually, i just notice it is sending it, it's just apache/php/mediawiki filtering them out.... at least the debug log doesn't show them [17:53:29] No idea, it went through locally. [17:54:00] might be very setup dependent, or the debug log is just lying. u never rly know [17:57:02] (03CR) 10UltrasonicNXT: "yeah yeah of course! Not finished yet! :P" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/182361 (owner: 10UltrasonicNXT) [17:59:15] (03CR) 10Anomie: [C: 032] Only return CORS headers in the response as required [core] - 10https://gerrit.wikimedia.org/r/177545 (owner: 10TheDJ) [17:59:22] (03PS2) 10Alex Monk: Make a VirtualRESTService class for Parsoid [core] - 10https://gerrit.wikimedia.org/r/181706 [18:01:08] (03CR) 10Alex Monk: "didn't properly test all the options" [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [18:01:20] (03PS3) 10Alex Monk: Make a VirtualRESTService class for Parsoid [core] - 10https://gerrit.wikimedia.org/r/181706 [18:04:39] 3MediaWiki-JavaScript: Deprecation warnings may not be consistent for jQuery - https://phabricator.wikimedia.org/T74451#951027 (10Krinkle) They were deprecated since MediaWiki 1.23. Deprecation warnings added in October 2013. Removed October 2014 (MediaWiki 1.25). Various mailing lists were notified of deprecat... [18:05:04] (03Merged) 10jenkins-bot: Only return CORS headers in the response as required [core] - 10https://gerrit.wikimedia.org/r/177545 (owner: 10TheDJ) [18:08:12] Sorry for the connect/disconnect spam guys. I had to repare some things. [18:08:28] 3MediaWiki-skins-Vector: Vector sidebar transition is not in sync with logo/content transition. - https://phabricator.wikimedia.org/T85614#951036 (10matmarex) Whatever. It's not like people are resizing their browsers to witness the glorious animations. [18:08:39] y2598, /msg gcibot amsg something [18:11:20] MatmaRex: not true !! [18:11:29] * thedj loves animations [18:11:33] :) [18:12:33] well sure, animations are neat, but this one is somewhat pointless [18:13:31] MatmaRex: lol at your comment :-) [18:16:10] 3MediaWiki-JavaScript: Deprecated mediawiki JS methods should have console warnings (like jQuery methods) - https://phabricator.wikimedia.org/T74451#951061 (10TheDJ) Something we could do perhaps, is to do sampled logging of the stack for deprecated functions ? Then we can gather the remaining locations that are... [18:16:20] (03PS3) 10BryanDavis: Implement support for a minimum log level in $wgDebugLogGroups [core] - 10https://gerrit.wikimedia.org/r/182131 (owner: 10Legoktm) [18:16:21] MatmaRex: :) [18:16:32] (03CR) 10BryanDavis: [C: 032] Implement support for a minimum log level in $wgDebugLogGroups [core] - 10https://gerrit.wikimedia.org/r/182131 (owner: 10Legoktm) [18:22:59] (03Merged) 10jenkins-bot: Implement support for a minimum log level in $wgDebugLogGroups [core] - 10https://gerrit.wikimedia.org/r/182131 (owner: 10Legoktm) [18:23:35] 3Wikimedia-Wikimania-Scholarships: Update "Most active Wiki" question - https://phabricator.wikimedia.org/T85287#951100 (10Shouston_WMF) @NiharikaKohli Yes, probably should add MediaWiki and Tool Labs into that option. Tool Labs also don't have language communities, right? [18:24:23] (03Abandoned) 10Jdlrobson: Upstream icons from MobileFrontend [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/174864 (owner: 10Robmoen) [18:25:02] (03PS5) 10Jdlrobson: Use Mustache templates for captcha instead of string stitching [core] - 10https://gerrit.wikimedia.org/r/168123 [18:26:07] 3Librarization, MediaWiki-Core-Team: Update WMF $wgDebugLogGroups config to set a level threshold for memcached errors - https://phabricator.wikimedia.org/T85628#951103 (10bd808) [18:26:08] (03CR) 10Jdlrobson: "@legoktm yeh I was surprised too but whilst it's here it might as well be nicer." [core] - 10https://gerrit.wikimedia.org/r/168123 (owner: 10Jdlrobson) [18:28:49] 3Multimedia, MediaWiki-extensions-UploadWizard: Make the transports mostly independent, and add tests for them - https://phabricator.wikimedia.org/T85629#951140 (10MarkTraceur) 3NEW a:3MarkTraceur [18:30:35] 3Mobile-Web: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#951148 (10Jdlrobson) 3NEW [18:30:54] (03CR) 10jenkins-bot: [V: 04-1] Use Mustache templates for captcha instead of string stitching [core] - 10https://gerrit.wikimedia.org/r/168123 (owner: 10Jdlrobson) [18:33:01] 3MediaWiki-API: Cleanup CORS reply by api - https://phabricator.wikimedia.org/T76701#951156 (10TheDJ) 5Open>3Resolved [18:39:50] 3Engineering-Community: Move ECT's on-wiki backlogs to Phabricator - https://phabricator.wikimedia.org/T1034#951157 (10Rfarrand) I am done, too! [18:40:09] 3Engineering-Community: Move ECT's on-wiki backlogs to Phabricator - https://phabricator.wikimedia.org/T1034#951158 (10Rfarrand) 5Open>3Resolved [18:45:05] 3Librarization: Publish MediaWiki codesniffer config on Packagist - https://phabricator.wikimedia.org/T85631#951161 (10bd808) 3NEW [18:49:35] (03CR) 10MaxSem: [C: 031] "I oppose the notion of users' sacred right to shoot themselves on foot." [core] - 10https://gerrit.wikimedia.org/r/176853 (owner: 10Krinkle) [18:58:53] (03PS16) 1020after4: Huge refactor of security policy enforcer stuff. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 [19:01:58] 3Engineering-Community: Update Events Schedule on MWDS wiki - https://phabricator.wikimedia.org/T85632#951169 (10Rfarrand) 3NEW a:3Rfarrand [19:02:41] 3Engineering-Community: Find new Tech Talks and get them scheduled for Dec, Jan & Feb. - https://phabricator.wikimedia.org/T1046#951176 (10Rfarrand) [19:03:10] 3Engineering-Community: Name Badges for Wikimedia Developers Summit - https://phabricator.wikimedia.org/T76503#951177 (10Rfarrand) [19:03:31] 3Engineering-Community: Finalize Logistics with Mission Bay Center - meeting specs & set-up - https://phabricator.wikimedia.org/T76501#951178 (10Rfarrand) [19:04:09] 3Engineering-Community: Finalize details for MediaWiki Developers Summit WMF Reception - https://phabricator.wikimedia.org/T76498#951179 (10Rfarrand) [19:04:11] 3Engineering-Community: Finalize MediaWiki Developer Summit Restaurant Event - https://phabricator.wikimedia.org/T76496#951180 (10Rfarrand) [19:04:12] 3Engineering-Community: Email to WMDS Participants - https://phabricator.wikimedia.org/T78618#951183 (10Rfarrand) [19:04:14] 3Engineering-Community, Team-Practices: Team Practices Group Retreat Coordination - https://phabricator.wikimedia.org/T78352#951182 (10Rfarrand) [19:04:15] 3Engineering-Community: Shuttles for MWDS - https://phabricator.wikimedia.org/T76499#951184 (10Rfarrand) [19:05:33] 3Engineering-Community: Engineering Community team report for November 2014 - https://phabricator.wikimedia.org/T810#951186 (10Rfarrand) Done! Thanks to Guillaume! https://www.mediawiki.org/wiki/Engineering_Community_Team#Current_activities he said that "The problem was that the Events activity wasn't in the E... [19:05:47] 3Engineering-Community: Engineering Community team report for November 2014 - https://phabricator.wikimedia.org/T810#951187 (10Rfarrand) 5Open>3Resolved [19:06:15] 3Engineering-Community: MediaWiki Developer Summit 2015 - Welcome and logistics - https://phabricator.wikimedia.org/T85147#951189 (10Rfarrand) p:5Triage>3Normal [19:07:09] 3Engineering-Community: Coordinate Developers Summit - https://phabricator.wikimedia.org/T76506#951190 (10Rfarrand) Continuing on into January... Everything is on track. [19:07:57] 3Engineering-Community: Publish the evaluation of the Wikimedia hackathon 2014 in Zurich - https://phabricator.wikimedia.org/T652#951192 (10Rfarrand) [19:13:54] (03PS17) 1020after4: Huge refactor of security policy enforcer stuff. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 [19:21:10] 3Mobile-Web: Still issues with pinch zoom on images - https://phabricator.wikimedia.org/T76620#951194 (10Jdlrobson) Moving back to patch needed [19:23:43] 3Wiki-Release-Team: Wiki Release Team December Goals - https://phabricator.wikimedia.org/T76672#951198 (10Mglaser) [19:24:49] legoktm, what are the negative implications of an exyension just using the 'main' config? [19:30:31] (03PS18) 1020after4: Huge refactor of security policy enforcer stuff. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 [19:31:10] (03CR) 10Jeroen De Dauw: [C: 031] Introduce Composer merge plugin [core] - 10https://gerrit.wikimedia.org/r/182323 (owner: 10BryanDavis) [19:33:34] 3MediaWiki-Documentation: Documentation is out of date, incomplete (tracking) - https://phabricator.wikimedia.org/T2001#951209 (10scfc) [19:35:36] (03CR) 10Phoenix303: "Hi Nemo Bis," [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/182140 (owner: 10Phoenix303) [19:40:37] MaxSem: it will break as soon as we stop using GlobalVarConfig everywhere, which I hope will happen in 6mo-1yr [19:41:47] (03CR) 10Nemo bis: "I'm not sure the failure is related to this patch, but yes, finding out its cause would help getting reviews. It didn't appear on your fir" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/182140 (owner: 10Phoenix303) [19:52:27] (03CR) 10Krinkle: mediawiki.action.edit.preview: Use DOM as event priority (031 comment) [core] - 10https://gerrit.wikimedia.org/r/182354 (owner: 10Gerrit Patch Uploader) [19:52:51] legoktm, what are your plans regarding it? [19:56:36] (03PS2) 10Krinkle: Remove trigger 'LivePreviewPrepare' [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/182355 (owner: 10Gerrit Patch Uploader) [19:56:49] (03CR) 10Krinkle: [C: 04-1] "Per I9a609639f." [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/182355 (owner: 10Gerrit Patch Uploader) [20:00:25] MaxSem: config will live in the db, and during initialization, the settings will be placed in their own Config instance, rather than being combined into one giant one [20:00:56] MaxSem: er, the settings will go into the Config instance that they belong to, so all of core's settings will go into 'main', Extension:Foo's will go into 'foo', etc. [20:01:34] (03CR) 10jenkins-bot: [V: 04-1] Remove trigger 'LivePreviewPrepare' [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/182355 (owner: 10Gerrit Patch Uploader) [20:23:56] (03CR) 10Krinkle: [C: 04-1] "This feels like a biased arms race. Not sure this is a justifiable change. It basically tailors it for CodeEditor which happens to need it" [core] - 10https://gerrit.wikimedia.org/r/182354 (owner: 10Gerrit Patch Uploader) [20:24:12] [13composer-merge-plugin] 15JeroenDeDauw created 06rui (+1 new commit): 02https://github.com/wikimedia/composer-merge-plugin/commit/4f5d8122b4e4 [20:24:12] 13composer-merge-plugin/06rui 144f5d812 15jeroendedauw: Remove unused imports [20:24:31] 3MediaWiki-Page-editing, MediaWiki-extensions-CodeEditor: LivePreview: no changes reflected on preview/diff when using CodeEditor - https://phabricator.wikimedia.org/T78838#951217 (10Krinkle) We already solved the underlying problem in MediaWiki core and CodeEditor by standardising on TextSelection API for retri... [20:25:06] (03CR) 10Krinkle: "See T78838." [core] - 10https://gerrit.wikimedia.org/r/182354 (owner: 10Gerrit Patch Uploader) [20:25:16] (03CR) 10Ori.livneh: [C: 04-1] "* Is there really a need for 'parsoid'-prefixed parameters that simply get mapped to unprefixed parameters, like "parsoidTimeout" and "par" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [20:26:11] wikimedia/composer-merge-plugin#17 (rui - 4f5d812 jeroendedauw): The build passed. - http://travis-ci.org/wikimedia/composer-merge-plugin/builds/45572269 [20:26:23] 3MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), MediaWiki-User-login-and-signup: Captcha positioning is inconsistent between JavaScript and non-JavaScript users - https://phabricator.wikimedia.org/T85192#951221 (10Sumit) a:3Sumit @Jdlrobson, I'll soon submit a patch, but I need a little advice on one th... [20:27:40] (03PS19) 1020after4: Huge refactor of security policy enforcer stuff. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 [20:27:58] [13composer-merge-plugin] 15JeroenDeDauw created 06private (+1 new commit): 02https://github.com/wikimedia/composer-merge-plugin/commit/e8ea6bcea70b [20:27:58] 13composer-merge-plugin/06private 14e8ea6bc 15jeroendedauw: Make fields and methods private [20:28:16] bd808: what is the deal with the MIT license? [20:28:30] I thought you needed to publish code written for WMF under GPL [20:28:49] I was matching the Composer license. [20:29:03] since its a composer plugin [20:29:11] bd808: sure. But is that not forbidden in your WMF contract? [20:29:39] JeroenDeDauw, actually, no. any FLOSS license woul do [20:29:41] *shrug* [20:29:53] wikimedia/composer-merge-plugin#18 (private - e8ea6bc jeroendedauw): The build passed. - http://travis-ci.org/wikimedia/composer-merge-plugin/builds/45572489 [20:30:03] [13composer-merge-plugin] 15JeroenDeDauw opened pull request #13: Remove unused imports (06master...06rui) 02https://github.com/wikimedia/composer-merge-plugin/pull/13 [20:31:41] bd808: mergheeeeeeeeeeeeeeeeeee ^ [20:32:29] JeroenDeDauw: why private all over the palce? [20:32:37] bd808: https://github.com/wikimedia/composer-merge-plugin/blob/master/src/MergePlugin.php#L164-L168 really? ;p [20:33:47] [13composer-merge-plugin] 15bd808 pushed 1 new commit to 06master: 02https://github.com/wikimedia/composer-merge-plugin/commit/6cd48483c7e1024a7b05ad0056bd1db71d956ff9 [20:33:47] 13composer-merge-plugin/06master 146cd4848 15Bryan Davis: Merge pull request #13 from wikimedia/rui... [20:35:15] bd808: why give the things more visibility than is needed? [20:35:34] If you do protected by default, then subclassing becomes even more probelamtic [20:35:46] how so? [20:35:47] wikimedia/composer-merge-plugin#21 (master - 6cd4848 Bryan Davis): The build passed. - http://travis-ci.org/wikimedia/composer-merge-plugin/builds/45572795 [20:35:55] Esp if the class is not package private [20:36:10] bd808: cause you have even more binding? [20:36:45] I did my time in enterprise java and using horrible reflection hacks to fix things that library providers has made private for no apparent reason [20:36:57] bd808: I used to do protected by default for years [20:37:03] And I switched over a year ago [20:37:06] Not seen any problems [20:37:13] And refactoring becomes so much more easy [20:37:49] bd808: sounds to me like either the library had bad design or you did something you should not do [20:38:04] yeah, welcome to software [20:38:15] both are always true [20:38:23] for anything non-trivial [20:38:24] ?? [20:38:55] bad design and users doing things authors didn't think of [20:39:36] (03CR) 10Manybubbles: [C: 031] Role for GeoData with Elasticsearch backend [vagrant] - 10https://gerrit.wikimedia.org/r/180297 (owner: 10MaxSem) [20:40:04] bd808: you can make everything public and package public to make sure users can get to everything you did not think of doing and can get around your design flaws yes. I do not think that is a wise approach though [20:40:59] Also, the difference between private and protected only affects subclasses... and subclassing accross component boundaries is questionable to begin with [20:41:11] You need to very carefully design the class if you want that to be done [20:41:23] (Assuming the class is not fully abstract) [20:43:02] bd808: I recommend you do this experiment: private all the things, and turn them protected when needed. And see how much problems it causes [20:43:44] It won't cause me any problems because I'm an owner of the project but I can't know what it closes off for a consumer [20:44:14] which is my rationale for protected vs private [20:45:02] bd808: you are right about that. I disagree this is a bad thing though, and in fact think it;s very valuable to have [20:45:11] I understand your argument but I don't subscribe to the philosophy [20:45:11] you define what your package can do and what it extension points are [20:46:04] if you allow abitray access and modification via subclassing... then you don't have a clear extension api, and you don't know what your users are doing. So you end up with not being able to change anything without those changes being breaking [20:48:26] access is provided via reflection anyway [20:48:55] so at the end of the day, you are relying on the good manners of the user of your api [20:48:55] bd808: I've actually not run into any cases where I had problems with something being private insread of protected, in either one of my libs or those of someone else. exactly 0 cases in the last 2 years [20:49:12] and since you're relying on good manners, you can simply documented what is and isn't private [20:49:19] (03CR) 10GWicke: "I would prefer to expose the restbase API to clients, even if the backend still uses the Parsoid v1 API right now." [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [20:49:26] ori: sure. if you use reflection to access something that is private and it changes, the break is your fault [20:50:35] i'm a big believer in [20:50:41] specifically: [20:50:42] "This doesn’t mean that, for example, no properties are considered private, and that no proper encapsulation is possible in Python. Rather, instead of relying on concrete walls erected by the developers between their code and other’s, the Python community prefers to rely on a set of conventions indicating that these elements should not be accessed directly." [20:50:48] bd808: hey, jhobs is about to ask for some help in labs getting added to a group... [20:51:18] bd808: hey Bryan, I don't think we've been introduced. I'm Jeff, I work with Adam on Wikipedia Zero. I was hoping you could give me permission to create labs instances via wikitech. I believe I'm currently not listed as a projectadmin? [20:51:20] the 'private' and 'protected' keywords are concrete walls, and they're not even very solid ones at that, given the reflection api [20:51:28] bd808: i told him you might be able to help. sounds like andrew's out, and i assume yuvi is just using his omnipresence to live in this channel [20:51:39] ori: that does not really affect my statement. What I said applies just as well to things that are package private, which you cannot enforce in PHP [20:52:10] jhobs: what project do you need access to? [20:52:20] (03CR) 10Ori.livneh: [C: 031] Introduce Composer merge plugin [core] - 10https://gerrit.wikimedia.org/r/182323 (owner: 10BryanDavis) [20:52:25] bd808: mobile [20:52:36] (03CR) 10Parent5446: "I'm just gonna ask rhetorically and then shut up b/c this is going to be merged anyway, but why are we making our own REST client rather t" [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [20:52:46] 3MediaWiki-General-or-Unknown: Bugs caught by mw.loader.inspect() (tracking) - https://phabricator.wikimedia.org/T57683#951223 (10matmarex) [20:53:17] * bd808 wonders how he ended up with projectadmin there [20:53:31] 3MediaWiki-ResourceLoader: localStorage nearly or totally filled with routine operation - https://phabricator.wikimedia.org/T58728#951227 (10matmarex) [20:53:45] jhobs: what's your wikitech user name? [20:53:52] (03CR) 10Ori.livneh: "Parent5446: Dunno; good question." [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [20:54:04] bd808: jhobs, same as here [20:54:35] (03PS20) 1020after4: Huge refactor of security policy enforcer stuff. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 [20:54:42] (03CR) 10GWicke: "@Parent: we looked into guzzle, and IIRC it didn't support parallel requests. We have a solid MultiHTTPClient that does that, so decided t" [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [20:55:29] dr0ptp4kt: you have project admin there too :) [20:55:55] jhobs: I added you as a project member, dr0ptp4kt can make you an admin if you need that too [20:56:02] bd808: thanks! [20:56:07] bd808: thanks :) [20:58:54] Tracking bug (tracking) - https://phabricator.wikimedia.org/T4007#951233 (10matmarex) [20:58:57] 3MediaWiki-JavaScript: MediaWiki AJAX interface (tracking) - https://phabricator.wikimedia.org/T45175#951230 (10matmarex) 5Open>3Resolved a:3matmarex Judging by lack of blocking tasks, this bug has fulfilled its purpose. [20:59:01] (03CR) 10Parent5446: "Guzzle uses curl_multi as well: http://guzzle3.readthedocs.org/batching/batching.html" [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [20:59:28] (03CR) 10GWicke: "I misremembered: In principle guzzle does support parallel requests, but I think Aaron looked at the code that implements that and decided" [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [21:00:08] parent5446: the question of MultiHTTPClient vs. guzzle vs. whatever is not too critical in any case [21:00:14] we can always swap those out later [21:00:34] the important part is having a stable internal interface [21:01:24] How would they be swapped out? We'd have to replace every instance where VirtualRESTService is used. And the more it is used, the more difficult it becomes to swap out [21:01:55] 3MediaWiki-JavaScript: Add wgContentNamespaces to mw.config - https://phabricator.wikimedia.org/T43881#951234 (10matmarex) a:3TTO [21:02:03] 3MediaWiki-JavaScript: Add wgContentNamespaces to mw.config - https://phabricator.wikimedia.org/T43881#951237 (10matmarex) 5Open>3Resolved Fixed by 3d87e3a86bcb39d444ef916129dd48bf80b5bb31 / https://gerrit.wikimedia.org/r/#/c/98143/. [21:02:17] 3Librarization: Publish MediaWiki codesniffer config on Packagist - https://phabricator.wikimedia.org/T85631#951240 (10bd808) a:3bd808 [21:02:23] (03CR) 10Bartosz Dziewoński: "This fixed T43881." [core] - 10https://gerrit.wikimedia.org/r/98143 (owner: 10TTO) [21:02:32] 3Librarization, MediaWiki-Core-Team: Publish MediaWiki codesniffer config on Packagist - https://phabricator.wikimedia.org/T85631#951161 (10bd808) [21:03:15] parent5446: VRS provides an API to any of those backends [21:03:49] as a user, you don't know whether MultiHTTPClient or guzzle or whatever is used behind the scenes, and nor should you have to [21:04:08] also, you should not have to care about actual server urls, protocols, etc pp [21:04:23] the service you are talking to might actually be a local php class in some installations [21:04:25] [13composer-merge-plugin] 15JeroenDeDauw 04deleted 06rui at 144f5d812: 02https://github.com/wikimedia/composer-merge-plugin/commit/4f5d812 [21:04:37] see https://www.mediawiki.org/wiki/Requests_for_comment/PHP_Virtual_REST_Service [21:04:45] So what you're saying is that we'd have VRS, an abstraction layer, on top of Guzzle, another abstraction layer? Guzzle does not just fulfill the functionality of MultiHTTPClient. It _also_ has the ability to create REST API clients from various formats of configuration [21:05:22] it's more specialized than VRS [21:05:32] it assumes that something is remote, for instance [21:06:42] No it doesn't. Guzzle has interfaces. It can be extended to do whatever you want. [21:06:53] think of VRS as something akin to VFS [21:07:21] everything is a file™, inspired by plan9 [21:07:23] bd808: any advice on how to start using the MW CS rules? I just checked for a single project, and found some valid warnings, though also a lot that will not be fixed for good reason. So it's not possible to have the CI fail when there are errors. And manual usage also becomes less effective [21:08:09] parent5446: how does an abstract interface that might be local or remote look in guzzle? [21:08:32] how do you configure the backends? [21:08:36] JeroenDeDauw: hmmm... so you want project local overrides or do you think the standard is wrong in some places? [21:08:57] JeroenDeDauw: I think addshore had a patch open with tweaking some MW CS rules... [21:09:17] https://gerrit.wikimedia.org/r/#/c/153399/ [21:09:36] bd808: local ones. Example: constant Diff_VERSION causes an error, since it should be DIFF_VERSION. But changing this is a breaking change, so that'd be silly [21:10:05] gwicke: Not sure exactly, but I know it involves extending http://api.guzzlephp.org/class-Guzzle.Http.ClientInterface.html [21:10:53] I'm checking more into it now, but my internet is terrible atm [21:12:25] JeroenDeDauw: *nod* I think there is a comment you can put in to tell codesniffer to ignore a line for something like that. Or you could make a custom standard that extends the MW standard [21:13:21] bd808: both rather suck :| [21:14:00] @codingStandardsIgnoreStart and @codingStandardsIgnoreEnd are the comment annotations [21:14:06] 3MediaWiki-JavaScript: Wikipedia pages freezes on Konqueror - https://phabricator.wikimedia.org/T34549#951244 (10matmarex) [21:14:36] * bd808 actually remembers asking for that feature back in the olden days [21:14:39] 3Wikimedia-Mailing-lists: oversight-l subscriber list: "Visit Subscriber List" results in "You must supply a valid email address." - https://phabricator.wikimedia.org/T23928#951246 (10Snowolf) 5declined>3Open [21:15:09] 3Wikimedia-Mailing-lists: oversight-l subscriber list: "Visit Subscriber List" results in "You must supply a valid email address." - https://phabricator.wikimedia.org/T23928#265749 (10Snowolf) I've re-opened the task, as I am told the mailing list is still in active use. We need to figure out if the problem stil... [21:18:28] (03CR) 10Legoktm: Make a VirtualRESTService class for Parsoid (031 comment) [core] - 10https://gerrit.wikimedia.org/r/181706 (owner: 10Alex Monk) [21:19:04] 3Wikimedia-Mailing-lists: oversight-l subscriber list: "Visit Subscriber List" results in "You must supply a valid email address." - https://phabricator.wikimedia.org/T23928#951249 (10Courcelles) Indeed, the mailing list is actively used for internal discussion, not for accepting oversight requests as it was in... [21:21:01] 3Librarization, MediaWiki-Core-Team: File upstream bug with composer about the autoloader being slow - https://phabricator.wikimedia.org/T85182#951251 (10Legoktm) a:3Legoktm https://github.com/composer/composer/issues/3603 [21:21:04] 3MediaWiki-General-or-Unknown: Wikipedia pages freezes on Konqueror 3.5.9 - https://phabricator.wikimedia.org/T34549#951253 (10matmarex) [21:21:25] gwicke: Ah nevermind. Backends are in the GuzzleHttp\Ring\Client namespace. It's not even an interface. It just uses a functor that returns a future. [21:21:27] Is there a way to tell on the CLI I want max line lenght 120 instead of 100? [21:21:46] Or to otherwise change this without creating a clone of the ruleset file? [21:22:04] parent5446: so how do you hook up backends to arbitrary requests? [21:22:36] Still checking. It's taking 15 seconds for every page load :( [21:22:50] At least IRC is still working [21:23:02] that sounds almost like ATT in San Francisco ;( [21:23:16] ssh over Christmas had ~15 seconds latency [21:23:17] an IRC based web browser sounds like a good idea :P [21:23:19] (03PS21) 1020after4: Huge refactor of security policy enforcer stuff. [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/179405 [21:23:23] lol [21:23:48] bd808: actually I'm thinking having a clone of the file per library might not be all that bad. It could just use that instead of the common thing then [21:23:49] tcp over dns is fun too [21:23:57] And also add in things that don't fit in the common one [21:24:13] * gwicke was playing with that as a way to get around closed wifi APs that still had DNS open [21:24:29] 3MediaWiki-extensions-WikibaseRepository: Adds a more prominent display of entity URIs - https://phabricator.wikimedia.org/T85633#951257 (10Tpt) 3NEW [21:24:47] Actually, thinking about it, unless the common one is release managed in a serious way, holding non MW libs into account, I can't use it anyway [21:25:50] JeroenDeDauw: Or just make a "jeroen" style and use it everywhere. Generally I don't care what the standard is I just think it should be checked and enforced by tooling to cut down on code review surprises and bike shedding. [21:27:50] bd808: I'd need a jeroen-old, jeroen-new, jeroen-new2, wikidata, wmde-fundraising, wmde-not-wd-or-fundraising, etc styles if I'd try to group them :) [21:28:10] Oh, and an smw one as well [21:28:15] that sounds like a personal problem :) [21:29:21] Grouping does not seem to make sense for most repos I contrib to given the overhead of having to need a new component and do release management for it [21:30:17] 3MediaWiki-ResourceLoader: ResourceLoader: Support CoffeeScript in MediaWiki:Common.js (and such) - https://phabricator.wikimedia.org/T40236#951263 (10matmarex) [21:30:36] 3MediaWiki-ResourceLoader: ResourceLoader: Support CoffeeScript in MediaWiki:Common.js (and such) - https://phabricator.wikimedia.org/T40236#454304 (10matmarex) Related: T56864. [21:30:45] 3MediaWiki-ResourceLoader: ResourceLoader: Implement support for LESS in wiki modules (user and site), supporting e.g. MediaWiki:Common.less - https://phabricator.wikimedia.org/T56864#630599 (10matmarex) Related: T40236. [21:33:41] 3MediaWiki-extensions-MultimediaViewer, Multimedia, MediaWiki-General-or-Unknown: Port mmv.performance.js to core - https://phabricator.wikimedia.org/T67605#951276 (10matmarex) [21:34:23] 3MediaWiki-ResourceLoader: Mediawiki:Common.js loading slowly/late - https://phabricator.wikimedia.org/T44532#951280 (10matmarex) 5Open>3Resolved [21:34:42] bd808: https://github.com/wikimedia/composer-merge-plugin/blob/master/composer.json#L15-L16 [21:34:56] You allow bigger variance for the 0.x one? [21:35:01] (03CR) 10Ori.livneh: [C: 032] Role for GeoData with Elasticsearch backend [vagrant] - 10https://gerrit.wikimedia.org/r/180297 (owner: 10MaxSem) [21:35:09] I'd think you would do it the other way round [21:35:10] (03Merged) 10jenkins-bot: Role for GeoData with Elasticsearch backend [vagrant] - 10https://gerrit.wikimedia.org/r/180297 (owner: 10MaxSem) [21:35:36] The first one allows breaks, the second one only fixes [21:36:03] (03PS2) 10Jdlrobson: Add tests for define and require methods [extensions/Mantle] - 10https://gerrit.wikimedia.org/r/182298 [21:36:39] JeroenDeDauw: copy-paste on the parallel-lint one [21:37:42] I took that from one of Timo's projects I think [21:37:56] but since it's a dev tool, meh [21:39:38] 3MediaWiki-extensions-CategoryTree: Category tree shows inexisting categories and inexisting content (caching issue) - https://phabricator.wikimedia.org/T35608#951285 (10jwhited) This is a hack and will harm server kittens. Disables ajax response caching if $wgCategoryTreeDisableAjaxCache == true ``` # cat... [21:40:28] 3MediaWiki-extensions-UploadWizard: UploadWizard: Make category suggestions case-insensitive - https://phabricator.wikimedia.org/T40785#951287 (10matmarex) [21:40:55] 3MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), MediaWiki-User-login-and-signup: Captcha positioning is inconsistent between JavaScript and non-JavaScript users - https://phabricator.wikimedia.org/T85192#951292 (10Jdlrobson) Don't move the header down as it may be used by other things. Instead the extensi... [21:41:11] 3Librarization, MediaWiki-Core-Team: Create RFC for library extraction (PHP & javascript) practices - https://phabricator.wikimedia.org/T1017#951293 (10bd808) 5Open>3Resolved Announced on list. [21:41:19] 3MediaWiki-extensions-UploadWizard: UploadWizard: Make category suggestions case-insensitive - https://phabricator.wikimedia.org/T40785#469654 (10matmarex) `getCategoriesByPrefix()` has no business caring about case sensitivity, the underlying API is case-sensitive by design. UploadWizard should use something li... [21:41:55] 3Librarization, MediaWiki-Core-Team: Update WMF $wgDebugLogGroups config to set a level threshold for memcached errors - https://phabricator.wikimedia.org/T85628#951300 (10bd808) [21:41:56] 3Librarization, MediaWiki-Core-Team: Support filtering log events by level in $wgDebugLogGroups - https://phabricator.wikimedia.org/T85073#951299 (10bd808) 5Open>3Resolved [21:44:55] 3MediaWiki-extensions-Flow, Parsoid: Parsoid does not interpret default parameters on non-transcluded pages the same way as the MW parser - https://phabricator.wikimedia.org/T85570#951304 (10ssastry) Confirmed as follows: ``` [subbu@earth lib] echo "[[File:Foo.jpg|{{{foo|48px}}}]]" | node parse --normalize

<... [21:45:41] 3MediaWiki-extensions-Flow, Parsoid: Parsoid does not interpret default parameters on non-transcluded pages the same way as the MW parser - https://phabricator.wikimedia.org/T85570#951306 (10ssastry) p:5Triage>3Normal [21:48:38] bd808: do you know if there is a default name for the ruleset.xml file that you can use to drop it in the project root and have phpcs automatically use it without specifying the path? [21:48:49] ie, like phpunit.xml or phpunit.xml.dist [21:49:41] 3MediaWiki-ContentHandler: Run a basic JavaScript syntax check when user/site JavaScript pages are saved - https://phabricator.wikimedia.org/T76204#951308 (10Edokter) This takes care of invalid scripts when saving, but... what about existing errors that block JS? Is it possible to wrap all user JS in a try..exce... [21:50:41] 3MediaWiki-ResourceLoader: ResourceLoader: Convey license information in HTTP requests serving minified builds of javascript files - https://phabricator.wikimedia.org/T38866#951310 (10matmarex) [21:50:52] JeroenDeDauw: I don't know. I've always used it with an explicit standard. You might hunt around in the manual -- http://pear.php.net/manual/en/package.php.php-codesniffer.php [21:51:09] 3MediaWiki-General-or-Unknown: Make sure our JavaScript - in particular jQuery and extensions - are GPL compatible - https://phabricator.wikimedia.org/T49429#951313 (10matmarex) [21:51:19] bd808: the manual does not say [21:51:26] it might just be missing tho [21:51:42] https://github.com/squizlabs/PHP_CodeSniffer/wiki/Annotated-ruleset.xml [21:51:44] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Add scroll metadata open/close events to dashboards - https://phabricator.wikimedia.org/T78797#951321 (10Tgr) [21:52:45] 3Mobile-Web, Wikidata, MediaWiki-extensions-WikibaseRepository: Wikidata references are not expandable/expanded on mobile - https://phabricator.wikimedia.org/T85364#951322 (10Jdlrobson) [21:53:09] recentchanges: New file pages should get rc_new = 1 - https://phabricator.wikimedia.org/T85634#951323 (10Subfader) 3NEW [21:53:15] 3Mobile-Web, Wikidata, MediaWiki-extensions-WikibaseRepository: Wikidata ranks are not shown on mobile - https://phabricator.wikimedia.org/T85367#951328 (10Jdlrobson) [21:54:39] 3MediaWiki-File-management, Multimedia: thumb.php redirection broken when there is no 404 handler - https://phabricator.wikimedia.org/T58926#951335 (10Tgr) [21:54:46] 3Mobile-Web: Can't scroll to top in editing window - https://phabricator.wikimedia.org/T71092#951336 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Assuming this is fixed as I cannot replicate it. Please reopen if not. [21:55:31] (03CR) 10Legoktm: [C: 031] "Looks sane, but Yuvi should take a look." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/182369 (owner: 10Glaisher) [21:55:31] 3MediaWiki-API: API initializes user preferences on every request - https://phabricator.wikimedia.org/T85635#951340 (10MaxSem) 3NEW [21:55:44] 3Mobile-Web, Wikidata, MediaWiki-extensions-WikibaseRepository: Wikidata qualifiers are not shown on mobile - https://phabricator.wikimedia.org/T85366#951346 (10Jdlrobson) [21:56:09] 3MediaWiki-extensions-GWToolset, Multimedia: Operational issues for very large TIFFs - https://phabricator.wikimedia.org/T67217#951352 (10Tgr) [21:58:29] JeroenDeDauw: If you don't give a standard then it looks for a default -- https://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer/CLI.php#L970-L973 -- haven't traced that out yet [22:02:51] 3MediaWiki-Internationalization: Provide a module to format sizes - https://phabricator.wikimedia.org/T59230#951359 (10matmarex) [22:02:59] (03PS1) 10Kaldari: Officially deprecating wikiloveimagelog (no longer needed) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/182381 [22:03:38] 3WMF-Design, Mobile-Web: Polish : Remove active border on search dismiss control for consistency on mobile - https://phabricator.wikimedia.org/T1162#951362 (10Jdlrobson) I will assume this is all buttons and write a patch.. [22:03:43] 3WMF-Design, Mobile-Web: Polish : Remove active border on search dismiss control for consistency on mobile - https://phabricator.wikimedia.org/T1162#951363 (10Jdlrobson) a:3Jdlrobson [22:03:49] JeroenDeDauw: Looks like you can set config settings in a $PHP_CODESNIFFER_CONFIG_DATA global (not too helpful). It might be neat to send them a pull request that allows a config file in the local dir. The defaults are at https://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer.conf.dist [22:04:47] 3VisualEditor, MediaWiki-General-or-Unknown, VisualEditor-MediaWiki: returnto and returntoquery in login/signup links doesn't get updated on pushState or popstate - https://phabricator.wikimedia.org/T64355#951367 (10matmarex) [22:05:00] Hmm yeah [22:05:04] thnx [22:05:14] gwicke: Finally found it. You can set the handler class in the client configuration. So you would set the handler upon instantiation of the client. [22:06:04] bd808: do you know if there is a way to tell phpcs to show the name of the violated constraint in the report, instead of just the nice message? [22:06:26] I'm now seeing some errors I want to get rid of cause I don't agree with them, but don't know what rule is causing them [22:06:28] Although I'd like to submit a way to have it configurable by scheme. [22:06:28] there is some way yes... [22:06:44] 3Mobile-Web: Mobile image viewer and back button behaviour - https://phabricator.wikimedia.org/T85636#951371 (10Jdlrobson) 3NEW [22:07:13] "To show source codes instead of friendly names, use the -s command line argument." [22:08:09] 3MediaWiki-extensions-Gadgets, MediaWiki-ResourceLoader: Remove gadget modules from local storage when the user disables them - https://phabricator.wikimedia.org/T58778#951377 (10matmarex) [22:09:03] (03PS2) 10Kaldari: Officially deprecating wikiloveimagelog (no longer needed) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/182381 [22:09:29] 3Mobile-Web: Failed to load resource: the server responded with a status of 404 (Not Found) - https://phabricator.wikimedia.org/T85637#951383 (10Jdlrobson) 3NEW [22:10:54] 3MediaWiki-JavaScript: Create jquery.accessibility library to handle accessibility attributes of actionable elements - https://phabricator.wikimedia.org/T54677#951389 (10matmarex) Today, I kind of doubt whether this would be useful. [22:11:32] 3MediaWiki-General-or-Unknown: Implement HTML5 caching manifests - https://phabricator.wikimedia.org/T47980#951391 (10matmarex) [22:11:35] (03CR) 10MaxSem: [C: 04-1] "Description messages need removal too." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/182381 (owner: 10Kaldari) [22:12:13] bd808: thnx again [22:12:21] sure [22:13:09] (03PS3) 10Kaldari: Officially deprecating wikiloveimagelog (no longer needed) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/182381 [22:15:04] incoming bugspam [22:15:13] 3MediaWiki-General-or-Unknown: mw.Title should provide a function to get a Title object from a link - https://phabricator.wikimedia.org/T58303#951395 (10matmarex) [22:15:14] 3MediaWiki-General-or-Unknown: Create jquery.accessibility library to handle accessibility attributes of actionable elements - https://phabricator.wikimedia.org/T54677#951394 (10matmarex) [22:15:15] 3MediaWiki-General-or-Unknown: mediawiki.util should be more modular - https://phabricator.wikimedia.org/T66564#951396 (10matmarex) [22:15:17] 3MediaWiki-General-or-Unknown: Restrict mediawiki.util to general JavaScript utilities only (branch off to mediawiki.page) - https://phabricator.wikimedia.org/T28799#951397 (10matmarex) [22:15:19] 3MediaWiki-General-or-Unknown: jquery.textSelection.js should provide a function to change the content - https://phabricator.wikimedia.org/T59229#951398 (10matmarex) [22:15:20] 3MediaWiki-General-or-Unknown: [Regression] jquery.textSelection fails in IE - https://phabricator.wikimedia.org/T36820#951401 (10matmarex) [22:15:22] 3MediaWiki-General-or-Unknown: Use mediawiki.cookie instead of jquery.cookie - https://phabricator.wikimedia.org/T67384#951400 (10matmarex) [22:15:23] 3MediaWiki-General-or-Unknown: Combine new mediawiki.inspect and debug toolbar - https://phabricator.wikimedia.org/T57618#951399 (10matmarex) [22:15:24] 3MediaWiki-General-or-Unknown: Add mw.hook event for wikipage: categories, langlinks, diff etc. - https://phabricator.wikimedia.org/T53583#951404 (10matmarex) [22:15:25] (03CR) 10MaxSem: [C: 032] Officially deprecating wikiloveimagelog (no longer needed) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/182381 (owner: 10Kaldari) [22:15:26] 3MediaWiki-General-or-Unknown: Implement immutable object constructors with caching for mw.User, mw.Title, mw.Page (tracking) - https://phabricator.wikimedia.org/T41813#951403 (10matmarex) [22:15:27] 3MediaWiki-General-or-Unknown: Show deprecation notices when accessing wg* JavaScript globals - https://phabricator.wikimedia.org/T58550#951402 (10matmarex) [22:15:28] 3MediaWiki-General-or-Unknown: make mediawiki.special.recentchanges.js reusable - https://phabricator.wikimedia.org/T38317#951405 (10matmarex) [22:15:29] 3MediaWiki-General-or-Unknown: Update mediawiki.api for new API token handling - https://phabricator.wikimedia.org/T72059#951406 (10matmarex) [22:15:31] 3MediaWiki-General-or-Unknown: Implement mw.Api convenience method for loading interface messages - https://phabricator.wikimedia.org/T40280#951407 (10matmarex) [22:15:32] 3MediaWiki-General-or-Unknown: encapsulateSelection don't return caret to prev. position after wrapping selected text - https://phabricator.wikimedia.org/T42261#951410 (10matmarex) [22:15:33] 3MediaWiki-General-or-Unknown: jquery.client shouldn't be fooled by "Request desktop site" option in mobile browsers - https://phabricator.wikimedia.org/T67255#951408 (10matmarex) [22:15:34] 3MediaWiki-General-or-Unknown: mw.Uri doesn't recognize URLs like http://wikimedia.org (requires slash at the end) - https://phabricator.wikimedia.org/T68617#951409 (10matmarex) [22:15:36] 3MediaWiki-General-or-Unknown: Add mw.hook event for when wpTextbox1's content is used (to beused by extensions providing WYSIWYG/code highlighting etc. functionality) - https://phabricator.wikimedia.org/T54071#951412 (10matmarex) [22:15:37] 3MediaWiki-General-or-Unknown: mediawiki.Uri does not support IPv6 URIs - https://phabricator.wikimedia.org/T66884#951413 (10matmarex) [22:15:38] 3MediaWiki-General-or-Unknown: The 'submit feedback' form does not add the feedback page to the user's watchlist - https://phabricator.wikimedia.org/T68848#951411 (10matmarex) [22:15:39] 3MediaWiki-General-or-Unknown: Add jQuery.hotkeys plugin for hooking keyboard events - https://phabricator.wikimedia.org/T29493#951415 (10matmarex) [22:15:40] 3MediaWiki-General-or-Unknown: [mediawiki.feedback.js] Provide a link to the article (and maybe the user's contributions) - https://phabricator.wikimedia.org/T55801#951414 (10matmarex) [22:15:43] 3MediaWiki-General-or-Unknown: Add a wgCurRevisionTimestamp to mw.config - https://phabricator.wikimedia.org/T56619#951416 (10matmarex) [22:15:44] 3MediaWiki-General-or-Unknown: Implement IndexedDB for offline content storage - https://phabricator.wikimedia.org/T47981#951418 (10matmarex) [22:15:45] 3MediaWiki-General-or-Unknown: The mw.user object needs to be rewritten - https://phabricator.wikimedia.org/T54894#951417 (10matmarex) [22:15:47] 3MediaWiki-General-or-Unknown: Add helper function to get the current wikicode of a page - https://phabricator.wikimedia.org/T37084#951422 (10matmarex) [22:15:48] 3MediaWiki-General-or-Unknown: wgRevisionId is 0 for edit page - https://phabricator.wikimedia.org/T62548#951419 (10matmarex) [22:15:49] 3MediaWiki-General-or-Unknown: mw.Title.newFromText should urldecode the title first - https://phabricator.wikimedia.org/T58466#951421 (10matmarex) [22:15:50] 3MediaWiki-General-or-Unknown: wgUserNewMsgRevisionId null when user talk page has only one revision - https://phabricator.wikimedia.org/T53640#951420 (10matmarex) [22:15:51] 3MediaWiki-General-or-Unknown: Implement a way to set the document title properly - https://phabricator.wikimedia.org/T33258#951425 (10matmarex) [22:15:53] 3MediaWiki-General-or-Unknown: Uncaught URIError: URI malformed mediawiki.Uri.js:188 - https://phabricator.wikimedia.org/T40814#951423 (10matmarex) [22:15:54] 3MediaWiki-General-or-Unknown: Expose action parameters in JavaScript (ViewAction diff, SpecialContributions target etc.) regardless of GET, POST or url encoding - https://phabricator.wikimedia.org/T33918#951424 (10matmarex) [22:15:55] 3MediaWiki-General-or-Unknown: wgTemplates in JavaScript - https://phabricator.wikimedia.org/T25104#951428 (10matmarex) [22:15:56] 3MediaWiki-General-or-Unknown: Replace $.client.test() with $.client.isBlacklisted() - https://phabricator.wikimedia.org/T34188#951427 (10matmarex) [22:15:58] 3MediaWiki-General-or-Unknown: Add protocol parameter to mw.Api. - https://phabricator.wikimedia.org/T42968#951426 (10matmarex) [22:16:02] done! [22:16:41] 3MediaWiki-extensions-Echo, MediaWiki-General-or-Unknown, Collaboration-Team: wgUserNewMsgRevisionId null when user talk page has only one revision - https://phabricator.wikimedia.org/T53640#544782 (10matmarex) [22:18:04] parent5446: a major point of VRS is that you don't even have to think about the scheme [22:18:44] Same with guzzle, I was just saying I thought it would be a good optional feature [22:19:08] all you see is paths and REST requests, but each request can be routed to a local or remote backend depending on the config [22:19:48] it's really just a local request routing layer [22:19:56] Yeah Guzzle does _exactly_ the same thing. You make a client (with w/e backend you want), and you make requests by passing paths to the client object. [22:20:24] so you have many backends, and they can match any request they like? [22:20:24] (03Merged) 10jenkins-bot: Officially deprecating wikiloveimagelog (no longer needed) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/182381 (owner: 10Kaldari) [22:20:41] 3MediaWiki-JavaScript, Project-Creators: Merge projects javascript and MediaWiki-JavaScript - https://phabricator.wikimedia.org/T76269#951436 (10matmarex) All done! Please close #mediawiki-javascript and put some instructions in the description, along the lines of "New reports should probably be filed under `#Me... [22:21:33] Going AFK. Will look more later [22:22:09] kk [22:23:00] (03CR) 10Spage: [C: 04-1] "This passes and it's fantastic to have a test for this." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/180213 (owner: 10Cmcmahon) [22:24:49] bd808: how was the ruleset file for the MW thing constructed anyway? Did someone check all the rules available and put in those that applied, or is this some random subset? [22:27:59] (03CR) 10Bartosz Dziewoński: [C: 031] Toolbar help: Make magic word from help string a param [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/178180 (owner: 10TheDJ) [22:45:08] 3Wikimedia-Site-requests: Restrict accountcreator permissions on enwiki - https://phabricator.wikimedia.org/T85538#951450 (10Dereckson) a:3Jackmcbarn Assigned to patch author. [22:45:28] 3Wikimedia-Site-requests: Grant tboverride-account instead of tboverride to account creators - https://phabricator.wikimedia.org/T76050#951453 (10Dereckson) a:3Jackmcbarn Assigned to patch author. [22:51:17] (03PS1) 10Kaldari: Some minor styling tweaks to the type selection interface [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/182383 [22:51:54] (03CR) 10Kaldari: [C: 032] Some minor styling tweaks to the type selection interface [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/182383 (owner: 10Kaldari) [22:52:06] (03Merged) 10jenkins-bot: Some minor styling tweaks to the type selection interface [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/182383 (owner: 10Kaldari) [22:54:21] (03CR) 10Cmcmahon: "testing for updates to Special:Contributions is not practical, because it takes on the order of minutes for those changes to propagate. th" (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/180213 (owner: 10Cmcmahon) [22:54:46] (03PS8) 10Cmcmahon: QA: add test for Flow in Recent Changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/180213 [22:58:59] Paging support - https://phabricator.wikimedia.org/T85640#951456 (10GWicke) 3NEW [23:01:31] 3MediaWiki-Interface: Section headings should have some clickable anchor for passing links - https://phabricator.wikimedia.org/T18691#951463 (10Quiddity) @Nemo_bis We already have a functional JS version, at [[https://www.mediawiki.org/wiki/MediaWiki:Gadget-vector-headanchor.js |mw:MediaWiki:Gadget-vector-headan... [23:02:34] (03PS1) 10MaxSem: Reorg:b move hooks to a separate class, introduce namespaces [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/182386 [23:03:07] (03CR) 10jenkins-bot: [V: 04-1] Reorg:b move hooks to a separate class, introduce namespaces [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/182386 (owner: 10MaxSem) [23:03:28] bd808: https://github.com/wmde/Diff/pull/25 [23:05:31] (03PS2) 10MaxSem: Reorg: move hooks to a separate class, introduce namespaces [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/182386 [23:09:51] Graphite stopped collecting MW profiling information - https://phabricator.wikimedia.org/T85641#951469 (10MaxSem) 3NEW [23:10:36] Graphite stopped collecting MW profiling information - https://phabricator.wikimedia.org/T85641#951469 (10MaxSem) [23:17:05] 3MediaWiki-extensions-SocialProfile: Allow avatars to be global - https://phabricator.wikimedia.org/T85070#951477 (10georgebarnick) Thanks guys! @lcawte @UltrasonicNXT @ashley [23:20:59] Add unit tests for YearPageGenerator and DayPageGenerator - https://phabricator.wikimedia.org/T85313#951478 (10Unicornisaurous) a:3Unicornisaurous I am a GCI student. [23:21:42] (03CR) 10Legoktm: Allow wikifarms to have global avatars (031 comment) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/182357 (owner: 10UltrasonicNXT) [23:28:29] MaxSem: clowncopterize? :P [23:28:48] because that' [23:28:55] s only a beginning! [23:31:06] :D [23:39:21] (03PS1) 10Legoktm: Use TEXT_EXTRACTS_INSTALLED instead of checking a class name [extensions/Popups] - 10https://gerrit.wikimedia.org/r/182387 [23:39:37] (03PS1) 10Legoktm: Use TEXT_EXTRACTS_INSTALLED instead of checking a class name [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/182388 [23:39:43] MaxSem: ^ [23:41:17] (03CR) 10Legoktm: [C: 031] "Works fine, except the class rename will break Popups and TwitterCards. Patches for those: https://gerrit.wikimedia.org/r/182387 https://g" [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/182386 (owner: 10MaxSem) [23:42:11] (03CR) 10MaxSem: [C: 032] Use TEXT_EXTRACTS_INSTALLED instead of checking a class name [extensions/Popups] - 10https://gerrit.wikimedia.org/r/182387 (owner: 10Legoktm) [23:42:40] (03CR) 10MaxSem: [C: 032] Use TEXT_EXTRACTS_INSTALLED instead of checking a class name [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/182388 (owner: 10Legoktm) [23:43:25] (03Merged) 10jenkins-bot: Use TEXT_EXTRACTS_INSTALLED instead of checking a class name [extensions/Popups] - 10https://gerrit.wikimedia.org/r/182387 (owner: 10Legoktm) [23:47:11] SUL Info - https://phabricator.wikimedia.org/T85642#951483 (10Jan.Kamenicek) 3NEW [23:47:43] (03Merged) 10jenkins-bot: Use TEXT_EXTRACTS_INSTALLED instead of checking a class name [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/182388 (owner: 10Legoktm) [23:48:32] (03CR) 10Legoktm: [C: 032] Reorg: move hooks to a separate class, introduce namespaces [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/182386 (owner: 10MaxSem) [23:48:49] (03Merged) 10jenkins-bot: Reorg: move hooks to a separate class, introduce namespaces [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/182386 (owner: 10MaxSem) [23:49:00] danke, legoktm! :) [23:49:07] np :)