[07:47:51] <tonythomas>	 Niharika: around ?
[07:48:21] <tonythomas>	 need your inputs on whether the implementing HTML emails project should stick to Mediawiki-Emails or a new one, say something like Mediawiki-HTML-Emails
[07:48:27] <tonythomas>	 andre__: if you are here too :)
[07:49:35] <tonythomas>	 qgil: andre__ : if you are around - ^^
[07:49:44] <qgil>	 hi
[07:51:16] <tonythomas>	 qgil: great! So, I was wondering if we should create a new project for the implement HTML email project
[07:51:17] <tonythomas>	 what do you think ?
[07:51:23] <tonythomas>	 close to what we have is Mediawiki-Email
[07:52:26] <qgil>	 In case of doubt, an own project is safer.
[07:56:59] <tonythomas>	 qgil: true. Then I think we should go for something like HTML-Emails or Mediawiki-HTML-Emails
[07:58:24] <tonythomas>	 qgil: you can create one for us :)
[07:58:25] <tonythomas>	 ?
[08:06:27] <andre__>	 As a user in Phabricator, I'd like to find the right project where to report my bugs. Will I really succeed, if my choices will be "Mail", "MediaWiki-Email" and "MediaWiki-HTML-Emails"?
[08:07:21] <tonythomas>	 well, might not :D
[08:08:16] <andre__>	 Does MediaWiki-Email have a workboard? Did you check?
[08:08:59] <tonythomas>	 it has apparently - https://phabricator.wikimedia.org/project/board/216/ -- only backlog there
[08:09:18] <tonythomas>	 most of them are people complaining the email didnt reach, and things like that :D
[08:10:47] <andre__>	 so it does not have a real workboard because there is only one column. So you could use that workboard and set up columns, just as one option.
[08:11:17] <andre__>	 I don't know. Maybe a better and more focused project name for a separate project might also work.
[08:12:52] <tonythomas>	 True. something more focused would be 'HTML-Emails' ?
[08:13:19] <tonythomas>	 I am not sure who should take a decision over this one :( parent5446 seems to be away
[08:19:31] <andre__>	 tonythomas: I don't see how that is more focused.
[08:19:46] <tonythomas>	 heh. I cannot come up with another name :(
[08:20:01] <andre__>	 Why do you need a project?
[08:20:24] <andre__>	 That's maybe the question to answer first.
[08:21:10] <tonythomas>	 andre__: true. I do not have anything in mind, that cannot be satisfied with https://phabricator.wikimedia.org/project/board/216/
[08:21:20] <tonythomas>	 so - lets use that then Galorefitz !
[08:21:26] <tonythomas>	 Mediawiki-Email
[08:22:04] <Galorefitz>	 andre__: But don't you think ti would be better work-wise, maintaining a separate project?
[08:22:12] <Galorefitz>	 making tracking work easier?
[08:23:18] <Galorefitz>	 That's mostly why tonythomas and I were discussing a new, separate project.
[08:23:37] <andre__>	 Maybe. I don't know, that's why I am asking "why do you need a project?".
[08:23:40] <andre__>	 If you could explain what "making tracking work easier" means *exactly*? :)
[08:24:11] <tonythomas>	 Galorefitz: well, since Phabricator is used (majority) for people reporting bugs -- three projects there can cause confusion
[08:24:11] <andre__>	 Or the other way round: What could not be tracked when reusing the MediaWiki-Email project and board?
[08:25:08] <andre__>	 (Three projects only create confusion if their names are very very similar)
[08:26:58] <Galorefitz>	 Yeah, that's true. I was guessing creating a separate project for tracking work I would be doing for GSoC '16 on Implementing HTML email support would be cleaner, but yes, filing bugs would definitely become troublesome
[08:27:19] <Galorefitz>	 Thank you, andre__! :)
[08:28:13] <andre__>	 A separate project would definitely be cleaner if nobody "clueless" filled tasks in it, sure. :P But that depends on the name
[08:28:25] <Galorefitz>	 ^ yes :P
[08:29:06] <andre__>	 but if there was a separate project, and once GSoC is over and there are open tasks left: Would they get moved into the "MediaWiki-Emails" project and would the separate project get archived?
[08:29:24] <andre__>	 This is the stuff that makes me wonder. :)
[08:29:50] <tonythomas>	 I hope someone come up with a pretty nerdy name :D maybe something like 'Multipart-Electronic-Mails' or something like that
[08:30:23] <andre__>	 tonythomas: if you can explain why you need a fresh separate project, maybe ;))
[08:30:30] <andre__>	 first step before the second.
[08:30:32] <tonythomas>	 hahah. I'm kidding
[08:30:41] <tonythomas>	 lets go for Mediawiki-Mail
[08:30:49] <andre__>	 MediaWiki-Email you mean
[08:30:53] <tonythomas>	 true.
[08:30:59] <Galorefitz>	 tonythomas: sounds good
[08:31:13] <andre__>	 in contrast to "Mail" (which is Wikimedia server stuff and also exists)
[08:31:41] <andre__>	 tonythomas, can tasks worked on in GSoC also be tagged with GSoC2016 in Phab? Or only the "parent" and org/administration tasks?
[08:32:18] <tonythomas>	 andre__: it seems like currently we are tagging only the administration tasks, and the parent proposal tasks
[08:32:24] <andre__>	 ah, ok :-/
[08:32:37] <tonythomas>	 The featured project ideas are still there
[08:32:42] <andre__>	 otherwise you could have filtered by them on the MW-Email workboard
[08:32:59] <tonythomas>	 True :(
[09:02:49] <Niharika>	 tonythomas: Sorry! I was away for lunch. I'd vote for reusing that board since it's quite barren and fits with what you're trying to implement. You can create new columns to manage your project tickets and leave the Backlog stuff in there. That's what we're doing for the Contributors project as well.
[09:04:14] <tonythomas>	 Niharika: okey. thats where we reached!
[09:04:32] <Niharika>	 tonythomas: Yeah, I just read through. :)
[09:05:12] <tonythomas>	 Niharika: the turning point was 'Why do you need a project?' by andre__ :D
[09:05:34] <Niharika>	 He has a knack for making people self-reflect. ;)
[09:07:57] <tonythomas>	 yeah. true that.
[10:30:06] <qgil>	 tinajohnson___, tonythomas addshore Glaisher this is a ping about the Newsletter meeting, or at least a ping so you can read the log later on.  :)
[10:30:17] <tonythomas>	 o/
[10:30:20] <tinajohnson___>	 Hi!
[10:31:09] <qgil>	 Hi there, it has been a bit silent since Jerusalem (except for Glaisher 's patches, mostly!)
[10:31:27] <qgil>	 https://phabricator.wikimedia.org/T115095 security review shows the work that MUST be done.
[10:31:50] <tonythomas>	 true
[10:31:54] <tinajohnson___>	 checking
[10:32:04] <tonythomas>	 https://phabricator.wikimedia.org/T132018 has a patch
[10:32:20] <qgil>	 I was wondering whether we (where "we"really means "you") have all the skills to complete these tasks.
[10:33:05] <tinajohnson___>	 I was thinking about the same
[10:33:05] <tonythomas>	 ah. I can fix https://phabricator.wikimedia.org/T132018 ( hope so )
[10:33:25] <tinajohnson___>	 I could go for https://phabricator.wikimedia.org/T132022
[10:33:36] <tinajohnson___>	 but would definitely need help
[10:33:52] <qgil>	 OK, and Glaisher started with https://phabricator.wikimedia.org/T132016 so perhaps he can finish that.
[10:34:15] <qgil>	 Three remaining blockers in the hands of three different developers. That sounds like a plan.
[10:34:20] <tonythomas>	 tinajohnson___: I think https://phabricator.wikimedia.org/T132016#2257073  would be easy than the abnuse filter thing
[10:34:26] <tonythomas>	 :D
[10:34:42] <tonythomas>	 sad that little moved after the hackcathon :(
[10:35:05] <qgil>	 If any of you needs help, we are in a good position to ask for it, as long we have specific requests (i.e. as in comments in tasks, or in patches)
[10:35:12] <tinajohnson___>	 Would it be okay if I try the bug for a few days and then unassign it if can't get around it?
[10:35:28] <tinajohnson___>	 I mean this one https://phabricator.wikimedia.org/T132022
[10:36:08] <qgil>	 addshore and tyler (parent-something) are likely to help with guidance, if the questions are within their domains of expertise (yes, I am using plural here)  ;)
[10:36:22] <qgil>	 ah, I meant parent5446 and he happens to be idling here  :)
[10:36:31] <addshore>	 in another meeting right now! ;)
[10:36:57] <tinajohnson___>	 qgil: I will take up https://phabricator.wikimedia.org/T132022 then
[10:36:59] <qgil>	 tinajohnson___, sure, take it it, try it, if you get stuck ask, and if it is just too much then leave it, no worries.
[10:37:42] <tinajohnson___>	 Assigned
[10:38:30] <tinajohnson___>	 All other tasks are taken up by one developer or the other. Great!
[10:39:14] <qgil>	 I wonder about https://phabricator.wikimedia.org/T119058 -- which is also in the Technical review column and sounds like a blocker
[10:39:37] <qgil>	 "Special:Newsletter fatals"
[10:39:59] <tinajohnson___>	 Yeah, it is a blocker
[10:40:28] <tinajohnson___>	 tonythomas: was the infinite recursion error solved ?
[10:40:37] <tonythomas>	 nope afaik.
[10:40:46] <tonythomas>	 it was due to some php bugs
[10:41:11] <tinajohnson___>	 Ah okay, was a task created for it? I didn't as far as I remember
[10:42:08] <qgil>	 Would it be an option to display an error message when main page doesn't exist, as a quick way to circumvent the fatal problem?
[10:43:28] <tinajohnson___>	 yeah, I think that would suffice for now
[10:43:52] <tinajohnson___>	 I think Glaisher had another way around the problem though
[10:44:29] <tinajohnson___>	 But yeah, an error message looks fine
[10:44:41] <qgil>	 Or define $mainTitle with a dummy value by default (say the wiki's MainPage) so at least the fatal is avoided.
[10:44:55] <qgil>	 Anything not so bad, so we can get through deployment.  :)
[10:45:21] <qgil>	 ah, my last advice was rather silly
[10:46:07] <qgil>	 Anyway, if we have three blockers in 3x2 hands for now, that is progress already.
[10:46:19] <tinajohnson___>	 yeah :)
[10:46:23] <qgil>	 Meanwhile, we can discuss about how to proceed with https://phabricator.wikimedia.org/T119058 in the task itself
[10:47:09] <qgil>	 The deployment to mediawiki.org for starters should be uneventful: https://phabricator.wikimedia.org/T116271
[10:47:18] <qgil>	 https://www.mediawiki.org/wiki/Topic:T2dqjshzbmpgnrbp
[10:47:45] <tinajohnson___>	 ah I see
[10:48:14] <tinajohnson___>	 So we have 3 blockers is it?
[10:48:23] <qgil>	 4
[10:48:54] <tinajohnson___>	 okay
[10:50:30] <tinajohnson___>	 adding the new blocking task
[10:51:15] <tinajohnson___>	 done
[10:53:34] <qgil>	 Triaged the two tasks that were needing triage.  :)
[10:54:43] <tinajohnson___>	 Thank you :)
[10:57:31] <qgil>	 So... progress!
[10:58:03] <qgil>	 Thank you, and I will try not to miss these weekly checkpoints (as I did many times in the past weeks, sorry). They are really useful and... revitalizing
[10:58:08] <qgil>	 (if that is a word at all)
[10:58:41] <tinajohnson___>	 I did miss a couple of them too. I'll try to not miss them as well.
[10:58:54] <tinajohnson___>	 Hope all these blockers would be done by next week
[10:59:32] <qgil>	 I will have an animated gif with champagne ready, in case that happens  ;)
[11:00:10] <tinajohnson___>	 haha! we'll see :)
[11:20:47] <tonythomas>	 addshore: around ?
[11:20:56] <addshore>	 yup
[11:20:56] <tonythomas>	 addshore: https://gerrit.wikimedia.org/r/#/c/284137/4  ?
[11:21:17] <tonythomas>	 I just found that we are not saving the summary of new issue **anywhere**
[11:21:18] <addshore>	 I havnt had tim to test it yet :/
[11:21:25] <addshore>	 ooooh
[11:21:40] <tonythomas>	 addshore: it had qqq missing. added now :)
[13:31:06] <parent5446>	 Was AFK. Online now
[18:43:17] <tonythomas>	 addshore: have time to review https://gerrit.wikimedia.org/r/#/c/288399/ ?
[18:43:31] <tonythomas>	 might fix one of our sec review blocker :)
[18:48:14] <addshore>	 :O
[18:48:16] <addshore>	 *looks*
[18:52:17] <addshore>	 tonythomas: commented on https://gerrit.wikimedia.org/r/288399
[18:52:38] <addshore>	 well, it sucks you cant look up deleted titles using the pageid....
[18:53:29] <tonythomas>	 addshore: exactly. This seems like the rude way of fixing it
[18:53:35] <tonythomas>	 the thing is, here it will show up the redlink
[18:53:58] <addshore>	 I might even be in favour of just displaying <main page deleted> or something
[18:54:45] <tonythomas>	 in that case :D https://phabricator.wikimedia.org/T119058#1905749
[18:54:56] <addshore>	 could even make a log entry saying that the main page was deleted or something do people can find out what the title was
[18:56:06] <tonythomas>	 addshore: how can we make a log entry when the main page was deleted ? Like - we will have to watch every page deletions ?
[18:56:08] <tonythomas>	 :o
[18:57:18] <addshore>	 added a comment to the tickt
[18:57:21] <addshore>	 tonythomas: hooks!
[18:57:44] <addshore>	 https://www.mediawiki.org/wiki/Manual:Hooks/ArticleDeleteComplete
[18:59:50] <tonythomas>	 okey - so this hook will be called each time a page is deleted! would be a waste of resources or something like that (as mainpage deletion would be a very low %)
[20:37:48] <andre47>	 First Code Review session in #wikimedia-codereview going well