[00:11:59] Thanks qgil ! [00:30:39] 3RT-Migration, Wikimedia-Blog: Blog post announcing the RT migration to Phabricator - https://phabricator.wikimedia.org/T76987#934489 (10gpaumier) I'll look at it tomorrow (Friday) and I should be able to publish it then, and if not, next week. [00:31:09] 3RT-Migration, Wikimedia-Blog: Blog post announcing the RT migration to Phabricator - https://phabricator.wikimedia.org/T76987#934491 (10gpaumier) a:5Qgil>3gpaumier [01:17:11] 3Phabricator: Cannot view Bugzilla migrated private/security tasks I am author/reporter of - https://phabricator.wikimedia.org/T75781#934628 (10matmarex) It seems that tasks imported from Bugzilla still have @bzimport in the ACL, even though they have the correct user in subscribers' list. Making any action on t... [02:52:05] 3Phabricator.org: Batch editing sends email updates - https://phabricator.wikimedia.org/T84964#935536 (10Quiddity) 3NEW [03:34:05] 3Phabricator.org: Ease moving tasks between two workboards - https://phabricator.wikimedia.org/T78826#935545 (10Spage) >>! In T78826#932421, @Qgil wrote: > 3. Click Batch edit ZOMG! I never scrolled down enough in a project to see that! So the needed feature is the ability to indicate a project's workboard col... [04:32:20] 3operations, RT-Migration: Schedule RT migration for Thu 18 Dec 00:00UTC (Wed 17 Dec 16:00PST) until Thu 18Dec 08:00UTC (00:00PST) - https://phabricator.wikimedia.org/T76773#935577 (10jeremyb) remove notice from phab front page? (or change to past tense) [06:17:42] 3Phabricator, Continuous-Integration: Create tag for zuul-cloner - https://phabricator.wikimedia.org/T84945#935666 (10Krinkle) 5Open>3declined Never mind for now. These should be filed upstream anyway. Tracking with #zuul, #uptream and a descriptive title should suffice. [06:17:52] 3Phabricator, Continuous-Integration: Create tag for zuul-cloner - https://phabricator.wikimedia.org/T84945#935668 (10Krinkle) [06:18:05] 3Phabricator, Continuous-Integration: Create tag for zuul-cloner - https://phabricator.wikimedia.org/T84945#934331 (10Krinkle) [07:07:05] 3Project-Management: "changed Security from none to none." - https://phabricator.wikimedia.org/T479#935690 (10jeremyb) This is extra confusing when a task has a non-public view policy. Security is none but also it's not visible to a typcial user. (maybe off-topic for this task. feel free to point me somewhere else) [07:25:28] 3Project-Management: "changed Security from none to none." - https://phabricator.wikimedia.org/T479#935695 (10Qgil) @jeremyb, can you post here the number of the task you are referring to? non-public tasks should have the Security field set to something other than "none", as it is the case reported in T76008 (... [07:31:47] 3Project-Management, ops-core: "changed Security from none to none." - https://phabricator.wikimedia.org/T479#935697 (10jeremyb-phone) look at almost any #ops-core task [07:40:19] jeremyb: You have a separate phabricator and mediawiki.org account for your phone? [07:40:32] Tell me that's an imposter. [07:40:40] :P [08:15:30] 3Project-Management, Fundraising-Backlog: Migration of Fundraising Tech team to Phabricator - https://phabricator.wikimedia.org/T831#935767 (10Qgil) There is some progress in https://phabricator.wikimedia.org/project/board/41/ Good! [08:20:23] 3Project-Management: Show percentage of teams migrated to Phabricator for project management - https://phabricator.wikimedia.org/T434#935778 (10Qgil) Fundraising-Tech has set a first foot in https://phabricator.wikimedia.org/project/board/41/ . @atgo reached out to find answers and some advice. Their current pla... [08:22:07] 3Phabricator, Phabricator.org: We need a Wikimedia process for filing tasks and patches upstream in the name of Wikimedia - https://phabricator.wikimedia.org/T1298#935785 (10Qgil) p:5Low>3Normal [08:45:20] 3Phabricator.org: Audit feedback form in Diffusion commits - https://phabricator.wikimedia.org/T75715#935807 (10Qgil) [08:51:04] 3Wikibugs, Phabricator.org: Batch editing sends email updates - https://phabricator.wikimedia.org/T84964#935808 (10Qgil) p:5Triage>3Low As far as I know, Batch Edit is literally what it says in the tin: a way to edit several tasks at once. Each task updated triggers the notifications that users have requeste... [09:03:11] 3Phabricator.org: Restrict access to comment removal - https://phabricator.wikimedia.org/T1185#935819 (10Qgil) A couple of ideas: * If the "This comment was removed by" text is indexed (and I'm not sure about this), a search query could be created and watched, so at least we would have an idea of the dimension... [09:33:30] 3RT-Migration, operations: Update wiki documentation related to RT - https://phabricator.wikimedia.org/T76990#935872 (10Qgil) [09:48:50] 3Mobile-Web, Phabricator.org: Ability to designate sub-workboards in Phabricator - https://phabricator.wikimedia.org/T78225#935901 (10Qgil) >>! In T78225#934093, @Jdlrobson wrote: > We are currently considering mobile web working on 2 very separate features that would have completely different bug and product ba... [10:00:07] 3Phabricator.org: Ease moving tasks between two workboards - https://phabricator.wikimedia.org/T78826#935928 (10Qgil) If the idea is that open tasks of a due sprint need to be associated with the next sprint, you don't really require the selection by column, selecting all open tasks should be enough, right? For... [10:00:26] 3Phabricator.org: Ease moving tasks between two workboards - https://phabricator.wikimedia.org/T78826#935931 (10Qgil) [10:00:27] 3Project-Management, Phabricator.org: Easily close all tasks in a particular workboard column - https://phabricator.wikimedia.org/T1284#22388 (10Qgil) [10:02:13] 3Project-Management, Phabricator.org: Batch edit all tasks in a particular workboard column - https://phabricator.wikimedia.org/T1284#935936 (10Qgil) [10:03:56] 3RT-Migration, operations: Schedule RT migration for Thu 18 Dec 00:00UTC (Wed 17 Dec 16:00PST) until Thu 18Dec 08:00UTC (00:00PST) - https://phabricator.wikimedia.org/T76773#935937 (10Qgil) Ooops! Done. Thank you. [10:23:47] 3Phabricator, Continuous-Integration: Create tag for zuul-cloner - https://phabricator.wikimedia.org/T84945#935973 (10hashar) Zuul cloner is indeed part of Zuul :-] [10:47:25] 3ops-core, Project-Management: "changed Security from none to none." - https://phabricator.wikimedia.org/T479#936037 (10mmodell) @qgil & @jeremyb-phone: The patch linked above will resolve the issue of confusing entries in the task transaction log. It will not prevent you from setting a custom policy yet leaving... [10:49:29] 3RT-Migration, Phabricator: Prevent private information being leaked via Herald notifications - https://phabricator.wikimedia.org/T493#936042 (10mmodell) @qgil: Yes, just as safe. Once the patch lands we can enable herald without worry of leaking any pre-existing private tasks. [11:22:25] 3Phabricator.org: Provide alternate style for non-public issues - https://phabricator.wikimedia.org/T76929#936075 (10Qgil) [11:52:30] 3RT-Migration, operations: access request test 2 - https://phabricator.wikimedia.org/T78806#936144 (10fgiunchedi) [11:56:41] 3Phabricator.org: Footer (font color vs background color) is hard to read - https://phabricator.wikimedia.org/T628#936150 (10Qgil) >>! In T628#931895, @Nemo_bis wrote: > There is already an accessibility project/tracking bug upstream, pushed by some wikimedians, but so far nothing was achieved. I guess you are... [11:58:11] 3Phabricator.org: Provide alternate style for non-public issues - https://phabricator.wikimedia.org/T76929#936159 (10mmodell) p:5Normal>3Low [13:13:20] 3Team-Practices, Code-Review, Engineering-Community: How to prioritize code review of patches submitted by volunteers - https://phabricator.wikimedia.org/T78768#936200 (10Aklapper) IMO this has parallels to 80/20 programs in companies: Everybody loves the idea to spend 20 percent (e.g. friday) of the time on "so... [13:23:28] 3Phabricator, Project-Creators, operations, WMF-Legal, Engineering-Community: Create WMF-NDA-Requests - https://phabricator.wikimedia.org/T84994#936209 (10Qgil) 3NEW a:3Qgil [13:26:07] 3Phabricator, Legalpad: Configure the permissions for Legalpad - https://phabricator.wikimedia.org/T218#936217 (10Qgil) [14:04:51] 3Phabricator: Configure Phabricator for our needs - https://phabricator.wikimedia.org/T34#936269 (10Qgil) [14:04:55] 3Phabricator, operations, WMF-Legal, Legalpad: Configure the permissions for Legalpad - https://phabricator.wikimedia.org/T218#936266 (10Qgil) 5Open>3Resolved Closing this task after setting these permissions: > Can Use Application: All Users > Can Configure Application: Administrators > Can Create Docume... [14:04:59] 3Phabricator, operations, WMF-Legal, Legalpad: Configure the permissions for Legalpad - https://phabricator.wikimedia.org/T218#936271 (10Qgil) [14:06:07] 3Phabricator, Project-Creators, operations, WMF-Legal, Engineering-Community: Create WMF-NDA-Requests - https://phabricator.wikimedia.org/T84994#936272 (10Qgil) [14:06:34] 3Phabricator, Project-Creators, operations, WMF-Legal, Engineering-Community: Create WMF-NDA-Requests - https://phabricator.wikimedia.org/T84994#936209 (10Qgil) [14:11:34] 3operations, Engineering-Community, Phabricator, Project-Creators, WMF-NDA-Requests, WMF-Legal: Create WMF-NDA-Requests - https://phabricator.wikimedia.org/T84994#936283 (10Qgil) 5Open>3Resolved I had discussed this setup with @dzahn, @csteipp, and @Robla-WMF some weeks ago. Project created: #WMF-NDA-Requests [14:23:48] bleh, after ~33000 emails from the RT migration syncing my local mailbox copy with the server takes ages [14:24:05] #firstworldproblems [14:28:27] andre__: https://imgur.com/IsuW1vT (I'm going to hell for this) [14:28:50] :D [14:29:21] Thank you. [14:29:57] guess I should print that and put it next to my desk [14:54:11] 3Phabricator.org, Wikibugs: Batch editing sends email updates - https://phabricator.wikimedia.org/T84964#936345 (10Aklapper) I don't see any valid bug here. If it didn't send email updates, people could complain that they were never notified for some changes while they did get notified for others (and debugging... [15:01:50] 3Phabricator.org: Status of a task (Open/Resolved/Declined/…) not easy to see when commenting - https://phabricator.wikimedia.org/T78836#936351 (10Aklapper) [15:17:17] 3Phabricator.org: Maniphest's advanced search is not linked by maniphest - https://phabricator.wikimedia.org/T1372#936383 (10Aklapper) Many things that might be helpful are written on the Phabricator frontpage and on the frontpages of tools like Maniphest. I don't think that we should replicate everything that's... [16:04:50] 3Phabricator.org: In the CC field, Phabricator should link to the list of project members and watchers - https://phabricator.wikimedia.org/T78604#936426 (10Aklapper) > I get a feeling that Aklapper might be Heh. Sorry, but I am just subscribed to your task. That's all, and that's why the field is called "Subscr... [16:09:14] 3Phabricator.org: When you close a task as "Resolved", Phabricator thinks you want to claim the task - https://phabricator.wikimedia.org/T84833#936429 (10Aklapper) >>! In T84833#934094, @Tgr wrote: > This causes assignee drift when people close and reopen a task. IMO if you closed a task you were responsible fo... [16:44:37] 3Phabricator.org: Cannot send comments in via email for tasks I receive updates for via email - https://phabricator.wikimedia.org/T85006#936471 (10Krenair) 3NEW [16:51:02] Krenair: maybe add the email + headers you received? [16:51:34] not sure if they give some clues, but who knows [16:51:39] maybe when its public [16:51:54] ohhhhhh [16:51:57] sorry, I missed that [16:51:58] one thing to note is that on this ticket, T84818 is not linked [16:53:32] Hm. It makes sense you cannot comment on a bug if you don't have edit rights there. [16:53:37] but the error is confusing [16:54:02] 3Phabricator.org: When you close a task as "Resolved", Phabricator thinks you want to claim the task - https://phabricator.wikimedia.org/T84833#936488 (10RobLa-WMF) This automatic behavior breaks a lot of team workflows, and clutters the task list . Frequently, a team will go through and do a triage, with a sin... [17:02:22] qgil: where do phabricator bugs we do want fixed, but upstream is not interested in go [17:02:23] ? [17:02:29] in #phabricator? [17:03:49] and is everything in #phabricator.org also supposed to be in #phabricator? *confused again* [17:31:24] 1) in #phabricator [17:31:59] 2) no, see https://phabricator.wikimedia.org/tag/phabricator/ [17:40:15] Mmm. Ok. [17:41:58] Well, in true Graphviz style my flowchart is not actually understandable: https://imgur.com/WClRO7C [17:48:41] andre__: got an easy "mark as spam" function? https://phabricator.wikimedia.org/T85011#936572 [17:49:27] no but I've disabled the user now. Thanks [17:49:41] or... wait [17:49:51] that user is correctly set as "bot"?! [17:50:07] argh, yeah [17:50:15] RT input. I guess I should NOT disable that :D [17:50:42] as the footer says: "this task filed by anonymous email". /me should read first [17:51:57] * andre__ wants folks to set user descriptions. Even if it's a bot. [18:14:17] <^d> Krinkle: I'm wondering if we should go ahead and start having Phab do the outbound replication to like github & zuul. It'll have to take over eventually anyway. So all replication would just go through Phab. [18:14:27] <^d> (maybe could test on a small scale first) [18:17:53] ^d: Sounds good. Start with a non-extension repo, I'd suggest – maybe VE core? [18:18:13] <^d> I'm actually thinking cdb. [18:18:16] <^d> Completely self-contained. [18:21:31] ^d: Yeah, though not much activity to see whether it works [18:21:40] <^d> true. [18:22:12] ^d: mediawiki-core maybe? Alternate destination on github and ci than the current targets naturally. So no interferences. [18:22:34] <^d> hmm [18:22:43] <^d> I want to fix Diffusion first and finish importing the rest :) [18:22:54] <^d> I'm finally pinging in #phabricator, I give up. [18:32:12] ^d: :-) [18:32:14] ^d: Keep fighting the good fight. [18:32:23] ^d: Target date for decomming gitblit: 31 January? :-) [18:32:45] <^d> provided we've fixed this issue by then I don't see why not. [18:42:45] 3Phabricator.org: Footer (font color vs background color) is hard to read - https://phabricator.wikimedia.org/T628#936662 (10Isarra) >>! In T628#936150, @Qgil wrote:> > Isarra, upstreaming this task will be useful if only to check what is their opinion. You (or anybody else interested) can do it. Nemo has alr... [18:46:31] 3Phabricator.org: Footer (font color vs background color) is hard to read - https://phabricator.wikimedia.org/T628#936673 (10Qgil) >>! In T628#936662, @Isarra wrote: > If the upstream does not care Right now upstream is not even aware that someone has a problem with the footer. Isarra, I think your arguments ar... [18:59:17] 3Phabricator.org: Cannot send comments in via email for tasks I receive updates for via email - https://phabricator.wikimedia.org/T85006#936697 (10Qgil) That task is not public, so maybe that is the problem. [19:08:26] 3Phabricator: Cannot send comments in via email for tasks I receive updates for via email - https://phabricator.wikimedia.org/T85006#936721 (10Aklapper) [19:08:49] 3Phabricator: Cannot send comments in via email for restricted tasks I receive updates for via email - https://phabricator.wikimedia.org/T85006#936724 (10Aklapper) [19:35:32] 3Phabricator.org, Wikibugs: Batch editing sends email updates - https://phabricator.wikimedia.org/T84964#936771 (10Quiddity) Ah, sorry the description is unclear. I was partially making a mea culpa, for anyone who got spammed by my ~900+ bug changes last night. (I processed 100 at a time, because doing them a... [19:39:51] 3Phabricator: Decide what to do with tracking bugs - https://phabricator.wikimedia.org/T75703#936775 (10Aklapper) I wonder if there's a sane way to get all the tasks under "Blocked by" on (e.g. T2745 for T78670) into a "Maniphest search query" format to then use the "Batch editing" mode and mass-add a newly crea... [19:42:43] Where can I find the MediaWiki OAuth and WMF Security phab extensions? They're not under https://git.wikimedia.org/project/phabricator [19:44:42] valhallasw`cloud, phabricator/extensions.git for the MW userpage custom field and security policy [19:45:01] Oh, right, I see. [19:46:11] valhallasw`cloud, hmm - https://secure.phabricator.com/T5096 [19:48:14] oh, it's basically in two differential revisions [19:48:16] I see. [19:48:19] Krenair: thanks for that link [19:48:30] although we already have something like this [19:48:48] I wonder if it's in our repos somewhere [19:49:21] maybe just as commit or something [19:49:27] 3Phabricator: Decide on "Needs Volunteer" Priority field value in Phabricator - https://phabricator.wikimedia.org/T78617#936795 (10Aklapper) >>! In T78617#854167, @Gryllida wrote: > This is specifically what I am trying to //avoid//; the Team should not exclude a certain priority level from its work and leave it... [19:49:28] or just as a floating commit that's rebased [19:49:55] 3Phabricator: Decide on "Needs Volunteer" Priority field value in Phabricator - https://phabricator.wikimedia.org/T78617#936805 (10Aklapper) So //if// there is interest of teams in keeping the "low" priority level (which still has a little bit of relevance for planning of teams) and one level below that one (is... [19:54:13] qgil: https://www.mediawiki.org/wiki/Phabricator/Code :-) [19:56:59] <^d> valhallasw`cloud: I've almost finished a role for mw-vagrant that provisions phabricator as well. [19:57:08] ^d: cool! [19:57:18] <^d> Uses elasticsearch like we do in prod, and actually uses trusty instead of lucid. [19:57:43] and pulls in WM extensions, I presume [19:57:53] <^d> Not yet, but would be trivial to add after it's done. [19:58:05] I basically copied an existing vagrant and added some dev tools to it [19:58:58] <^d> Yeah, I looked at bloomberg's vagrant and it made me a little sad inside looking at its puppet config :p [20:00:25] 3Phabricator: Do not send emails when importing changes to Diffusion - https://phabricator.wikimedia.org/T78154#936830 (10Chad) The "access denied" bit is indeed an upstream bug, confirmed today. [20:01:04] <^d> andre_ ^^ [20:01:12] whoot [20:01:21] at least less confusion on that front [20:01:40] <^d> Yeah, basically diffusion and differential are fighting for control of the object and differential wins. [20:01:51] <^d> Since we don't use differential, *boom* [20:02:20] <^d> Evan said he'd file a task and they'd get a fix out soonish. [20:04:01] <^d> https://secure.phabricator.com/T6790 [20:22:53] 3Phabricator, Phabricator.org: Do not send emails when importing changes to Diffusion - https://phabricator.wikimedia.org/T78154#936956 (10Qgil) [20:30:41] 3Phabricator.org, Wikibugs: Batch editing sends email updates - https://phabricator.wikimedia.org/T84964#936971 (10Qgil) What team members should probably do is to watch/unwatch projects. They can also unsubscribe from task as they receive notifications. And well they could also batch edit themselves instead to... [20:36:42] 3Phabricator: Decide what to do with tracking bugs - https://phabricator.wikimedia.org/T75703#936981 (10Qgil) So what about this guideline: * Subtasks and blockers of real tasks are totally fine. * If someone wants to convert a tracking task in a project, they just need to follow the regular process to request... [20:38:34] 3Phabricator.org: Phabricator has poor contrast, using grey on grey everywhere - https://phabricator.wikimedia.org/T62#936991 (10Quiddity) I've filed upstream as https://secure.phabricator.com/T6792 [20:38:43] 3Phabricator.org: Footer (font color vs background color) is hard to read - https://phabricator.wikimedia.org/T628#936994 (10Quiddity) I've filed upstream as https://secure.phabricator.com/T6792 [20:42:05] 3Phabricator: Decide on "Needs Volunteer" Priority field value in Phabricator - https://phabricator.wikimedia.org/T78617#936997 (10Jdforrester-WMF) That could work. I suppose people will be confused, but probably less so than the current name. :-) [20:43:56] 3Phabricator: Decide what to do with tracking bugs - https://phabricator.wikimedia.org/T75703#937000 (10Jdforrester-WMF) >>! In T75703#936775, @Aklapper wrote: > I wonder if there's a sane way to get all the tasks under "Blocked by" on (e.g. T2745 for T78670) into a "Maniphest search query" format to then use th... [20:45:27] 3Phabricator.org, Wikibugs: Batch editing sends email updates - https://phabricator.wikimedia.org/T84964#937004 (10Aklapper) I'm also digressing: >>! In T84964#936971, @Qgil wrote: > while bzimport was totally silent. For the records, not //totally// silent: https://lists.wikimedia.org/pipermail/wikidata-bugs/... [20:45:51] 3Phabricator: Decide what to do with tracking bugs - https://phabricator.wikimedia.org/T75703#937005 (10Jdforrester-WMF) >>! In T75703#936981, @Qgil wrote: > So what about this guideline: > > * Subtasks and blockers of real tasks are totally fine. > * If someone wants to convert a tracking task in a project, th... [20:51:21] 3Phabricator.org, Wikibugs: Batch editing sends email updates - https://phabricator.wikimedia.org/T84964#937009 (10valhallasw) [20:57:14] 3Phabricator: Decide what to do with tracking bugs - https://phabricator.wikimedia.org/T75703#937036 (10Qgil) # Select all the blocking tasks # Paste in Gedit or equivalent # Save as csv # Open in Calc or equivalent, using "space" as separator # Copy the column with the reference numbers # Paste it in Gedit or e... [20:58:03] 3Phabricator, Phabricator.org: Don't email users on cc changes by default - https://phabricator.wikimedia.org/T624#937038 (10valhallasw) [20:58:35] 3Phabricator.org: Footer (font color vs background color) is hard to read - https://phabricator.wikimedia.org/T628#937039 (10matmarex) Oh huh, there's text in the footer? I've never noticed before. [21:01:25] 3Phabricator, Phabricator.org: Don't email users on cc changes by default - https://phabricator.wikimedia.org/T624#937045 (10valhallasw) [21:02:39] 3Phabricator.org: Phabricator inline diffs are weird - https://phabricator.wikimedia.org/T78824#937047 (10Qgil) Can https://secure.phabricator.com/T6791 (just reported today) serve as related upstream task? >>! In https://secure.phabricator.com/T6791#88110, epriestley wrote: > We use `diff`, `git diff`, etc. We... [21:04:37] 3Phabricator.org: Diff adds artificial newlines - https://phabricator.wikimedia.org/T239#937064 (10Qgil) ... or maybe we could just merge this task into the more generic and complete {T78824} [21:08:50] 3Phabricator.org: Phabricator inline diffs are weird - https://phabricator.wikimedia.org/T78824#937073 (10Qgil) [21:11:42] 3Phabricator.org, Wikibugs: Batch editing sends email updates - https://phabricator.wikimedia.org/T84964#937076 (10Quiddity) >>! In T84964#936971, @Qgil wrote: > What team members should probably do is to watch/unwatch projects. In the future, yes. But that doesn't help for all the bugzilla converted subscribe... [21:12:45] 3Phabricator.org: Footer (font color vs background color) is hard to read - https://phabricator.wikimedia.org/T628#937085 (10Qgil) Not even the blue links? :) [21:13:42] 3Phabricator.org: Phabricator inline diffs are weird - https://phabricator.wikimedia.org/T78824#937087 (10Tgr) >>! In T78824#937047, @Qgil wrote: > Can https://secure.phabricator.com/T6791 (just reported today) serve as related upstream task? Related but not the same. That ticket is unclear (could use an exampl... [21:25:01] 3Phabricator: Decide on "Needs Volunteer" Priority field value in Phabricator - https://phabricator.wikimedia.org/T78617#937095 (10Qgil) Ok, we can settle in keeping the current level of priorities (which is the current consensus until it is replaced with a better consensus). And we can also agree on not using... [21:39:46] can someone help me with adding someone (to have access) to a security bug? [21:44:09] thank you valhallasw`cloud ! [21:44:23] greg-g, is that someone the person you want to assign the task? [21:44:41] qgil: nope :/ [21:58:43] twentyafterfour: can you write up a howto on how to add someone to a security task? (so they can see it) [21:59:34] greg-g: step 1. merge https://gerrit.wikimedia.org/r/#/c/179405/ step 2. add them as a subscriber ;) [22:00:13] greg-g: I could write it up, or I could just do it for you pending this patch getting merged [22:00:51] twentyafterfour: i want to add tgr to https://phabricator.wikimedia.org/T84952 [22:02:23] so you go to edit task, then click on the "custom policy" dropdown to edit the custom policy, then add the username to the list of allowed users in the policy dialog. I'm doing that now so you don't have to [22:02:58] addied tgr to the "visible to" policy's user list... [22:03:01] I tried that and it didn't let him in (when I go back to edit I no longer see his name) [22:03:08] hmm [22:03:44] probably because herald resets the policy [22:03:50] that's why we really need to merge my patch [22:04:04] :/ yeah [22:04:12] I don't think there is any reason to wait, that code is a lot better than what is in production now [22:04:15] a LOT better [22:05:37] yeah herald overwrites the change.. [22:06:23] only workaround for now is to set the "security" field to none [22:06:26] which I just did [22:06:55] and that's safe? :) [22:07:24] it doesn't change anything it just shuts off the herald rule [22:07:40] the current incarnation of the herald rule is not really very good. [22:08:48] If I could get a +2 I'd go ahead and push the patch into production but I don't think anyone is around to +2 me [22:11:56] 3Phabricator.org: Footer (font color vs background color) is hard to read - https://phabricator.wikimedia.org/T628#937179 (10Isarra) I don't know how it came into question whether or not this actually affects anyone, considering the task literally says 'this text is hardly readable', but if it helps, I do also f... [22:15:41] twentyafterfour, it's not ready to be +2'd [22:15:49] it depends on something that's abandoned and outdated [22:16:10] it doesn't depend on that, not sure why gerrit thinks it does [22:16:18] then rebase it on master [22:16:28] gerrit won't let it get merged until that's done [22:21:08] Krenair: rebased :) [22:26:50] twentyafterfour, who is actually able to +2 here anyway? [22:27:15] https://gerrit.wikimedia.org/r/#/admin/groups/753,members and gerrit admins? [22:27:30] Krenair: I'm actually not sure, maybe just me and chase. I can technically +2 it but I didn't wanna do anything without a review from someone [22:28:00] and ldap/ops? [22:28:15] yeah, you can't +2 your own commits [22:36:44] Krenair: technically I can ;) but that's not nice thing to do [22:43:25] technically anyone able to +2 can to their own commits [22:43:31] it is not allowed, however [22:47:33] <^d> \o/ https://secure.phabricator.com/D11020 [22:55:49] Krenair: I suppose jenkins-bot could stop it technically :-p [22:57:11] and I think these kinds of rules will become easier with phab [23:06:40] ldap/wmf seems to have a lot of control over jenkins, wouldn't be surprised if a lot of us can get around it [23:20:05] Krenair: not allowed? ops does it all the time :-/ [23:20:39] ops gets away with it. [23:20:47] it's required to self-merge in puppet [23:20:52] not just 'get away with' [23:21:10] why's it required? [23:21:25] "+2-ing your own code is tolerated in some cases where the project only has one maintainer and doesn't contain deployed code. In projects deployed on the Wikimedia cluster, +2-ing your own code is unacceptable and can be grounds for revocation." [23:21:27] from the +2 policy [23:21:29] the person who merges it must deploy it, and the best person to deploy it is the person who wrote it, thus... [23:21:43] Krenair: the "+2 policy" does not apply to operations/ [23:22:08] it doesn't? [23:23:02] greg-g: just because someone merges it doesn't mean they should do that without someone else reviewing it [23:23:07] greg-g: right, but then you just want +2 and merge to be seperate steps [23:23:22] which they are in gerrit, but jenkins pushes that button for you currently [23:23:25] twentyafterfour: yeah, of course, and they should, they don't always [23:24:03] I'm not sure I understand WHY jenkins does that actually, seems like a bad idea to have it auto merge [23:24:21] greg-g, where does it say not applicable to operations/? [23:25:25] twentyafterfour: depends on the repo, I'd say. It makes sense to 'auto merge after tests are OK' for mediawiki/core, I think, because there is no step after that [23:25:28] you're a strict constitutionalist aren't you? :) [23:25:40] lol [23:25:52] I think it's kinda like how police are above the law, so are ops [23:25:56] https://en.wikipedia.org/wiki/Strict_constructionism [23:26:36] I mean not officially but in practice they are [23:26:46] hmm. does operations/ stuff apply on the fundraising hosts? don't they require peer review? [23:56:23] 3RT-Migration, operations: Migrate RT to Phabricator - https://phabricator.wikimedia.org/T38#937340 (10gpaumier) [23:56:24] 3Wikimedia-Blog, RT-Migration: Blog post announcing the RT migration to Phabricator - https://phabricator.wikimedia.org/T76987#937338 (10gpaumier) 5Open>3Resolved And it's out :) https://blog.wikimedia.org/2014/12/19/wikimedia-technical-operations-joins-the-phabricator-party/