[00:30:05] 3Phabricator: Blank Phabricator spam task descriptions - https://phabricator.wikimedia.org/T88888#1023983 (10Aklapper) [00:30:57] 3Phabricator: Blank Phabricator spam task descriptions - https://phabricator.wikimedia.org/T88888#1022459 (10Aklapper) > I don't really like that the Spam tag/project is used for both actual spam and spam-related tasks. Project description is clear. So whoever uses it for spam-related tasks shall stop that. :) [00:47:26] 3Phabricator: Make non-standard "opening" links normal links - https://phabricator.wikimedia.org/T88939#1024000 (10Aklapper) p:5Triage>3Volunteer? [00:49:38] 3Phabricator.org: Make non-standard "opening" links normal links - https://phabricator.wikimedia.org/T88939#1024003 (10Aklapper) [00:50:47] 3Phabricator.org: Make non-standard "opening" links normal links - https://phabricator.wikimedia.org/T88939#1023711 (10Aklapper) Hmm, really upstream. The link in the dashboard editor is a "normal" one. Anyway, I propose to decline this for Wikimedia Phabricator. If you feel strongly about this, you might want... [00:51:12] 3Phabricator.org: Some links open in a new window (target=blank) instead of having normal behavior - https://phabricator.wikimedia.org/T88939#1024005 (10Aklapper) [04:22:56] I've got a Phabricator bot request, when someone gets a chance: https://phabricator.wikimedia.org/T88953 [05:06:59] 3Phabricator: Adapting Gadget-BugStatusUpdate.js to Phabricator - https://phabricator.wikimedia.org/T539#1024128 (10Mattflaschen) [05:09:14] 3Phabricator: Adapting Gadget-BugStatusUpdate.js to Phabricator - https://phabricator.wikimedia.org/T539#1024132 (10Mattflaschen) This is mostly done. I'll be able to finish and test the server-side part, then port the gadget, once the bot is created. [05:13:45] 3Engineering-Community, Code-Review, Team-Practices: Organize a Gerrit Cleanup Day - https://phabricator.wikimedia.org/T88531#1024141 (10Quiddity) >>! In T88531#1017429, @Qgil wrote: > This is a query showing unassigned tasks with Patch-For-Review (let's assume that assigned tasks are in good hands, for the sake... [07:51:59] 3Engineering-Community, Code-Review, Team-Practices: Organize a Gerrit Cleanup Day - https://phabricator.wikimedia.org/T88531#1024186 (10Qgil) [07:53:21] 3Engineering-Community, Code-Review, Team-Practices: Organize a Gerrit Cleanup Day - https://phabricator.wikimedia.org/T88531#1014128 (10Qgil) @quiddity good catch. Fixed. Do you all agree with the goals of this first terrestrial day, as specified in the description? [08:54:28] 3Phabricator.org: Exact matches should always win when suggesting/auto-completing - https://phabricator.wikimedia.org/T76732#1024211 (10Amire80) [08:58:53] 3Phabricator.org: Exact matches should always win when suggesting/auto-completing - https://phabricator.wikimedia.org/T76732#1024214 (10Amire80) >>! In T76732#1019339, @Qgil wrote: > What about renaming Wikidata to #Wikidata_ , as an interim solution? +1, if it's technically possible. This is an intuitive solu... [09:58:19] 3Phabricator.org: External links open in a new window (target=blank) instead of having normal behavior - https://phabricator.wikimedia.org/T88939#1024365 (10Qgil) [10:12:19] 3Phabricator.org: External links open in a new window (target=blank) instead of having normal behavior - https://phabricator.wikimedia.org/T88939#1024389 (10Qgil) Phabricator seems to open external links in a new window consistently. If anybody has found more cases, please list them here. Nemo, your use of the... [10:19:14] 3Phabricator.org: Date fields (created before etc) in Phabricator should have a date picker - https://phabricator.wikimedia.org/T88869#1024395 (10Qgil) This is about https://phabricator.wikimedia.org/maniphest/query/advanced/ I guess. I agree that something like this would be useful. Currently there is not even... [10:24:34] 3Phabricator.org: Allow sorting by oldest and newest in Date Update/Created in search queries - https://phabricator.wikimedia.org/T88899#1024415 (10Qgil) I find myself starting the scanning of tasks from the bottom of query sections, so yes, I can see the point of this request. Then again, if you think about how... [10:26:00] 3Phabricator.org: Provide a way to upload a file if drag'n'drop is not available or not wanted - https://phabricator.wikimedia.org/T165#1024424 (10Qgil) [10:28:56] qgil: I keep being confused by your time zone :-D [10:29:37] 3Phabricator.org: Provide a way to upload a file if drag'n'drop is not available or not wanted - https://phabricator.wikimedia.org/T165#1024465 (10Qgil) [10:32:27] Qgil: I originally thought you were living in Barcelona, but then your user page said you live in California, but now you're either up at 2.30am or not in CA :-D [10:36:46] 3Phabricator.org: Support copy and paste of tag pills - https://phabricator.wikimedia.org/T88937#1024480 (10Qgil) p:5Normal>3Volunteer? [10:37:28] 3Phabricator.org: Support copy and paste of tag pills - https://phabricator.wikimedia.org/T88937#1023684 (10Qgil) [10:42:27] 3Phabricator.org: Exact matches should always win when suggesting/auto-completing - https://phabricator.wikimedia.org/T76732#1024490 (10daniel) how would renaming to "#Wikidata_" work around the issue? Alphabetical sorting isn't the problem, as far as I can tell. [10:45:10] 3Phabricator: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#1024493 (10Qgil) >>! In T75854#1020525, @Aklapper wrote: >>>! In T75854#1019135, @Qgil wrote: >> and we are not gaining anything from having Elasticsearch. > > The default backend now supports stemming... [10:46:13] 3Phabricator.org: Exact matches should always win when suggesting/auto-completing - https://phabricator.wikimedia.org/T76732#1024494 (10Qgil) At least you could type "#Wikidata_" and get the result. But yes, mentioning the project in comments/descriptions is simpler and cleaner. [10:47:44] 3operations, Project-Creators, Phabricator, Triagers: Broaden the group of users that can create projects in Phabricator - https://phabricator.wikimedia.org/T706#1024495 (10Qgil) @awight, if you need to create projects, just follow https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects and req... [10:51:36] 3Phabricator.org: Phabricator should let you add dependencies both ways (depending and blocking) - https://phabricator.wikimedia.org/T33#1024514 (10Qgil) Useful background: https://secure.phabricator.com/T5021 & https://secure.phabricator.com/T5494 [10:54:40] 3Phabricator: Task creation by email is unclear - https://phabricator.wikimedia.org/T865#1024524 (10Qgil) @valhallasw, could you upload a screenshot of your test instance with the change, please? [10:58:11] 3Phabricator: Task creation by email is unclear - https://phabricator.wikimedia.org/T865#1024542 (10valhallasw) I don't have my external HD with the phab VM at hand, but the link rendered properly (I assume that's what you're wondering about) [11:02:57] 3Phabricator, MediaWiki-Core-Team, Security-Reviews: Install PHPExcel so I can export reports - https://phabricator.wikimedia.org/T152#1024566 (10Aklapper) [11:08:57] 3Phabricator: Enable select Fundraising people to modify policy for tasks - https://phabricator.wikimedia.org/T88762#1024581 (10Qgil) Note that "Fundraising-Backlog" was initially the Fundraising "people" project. There is also "Wikimedia-Fundraising", which is the backlog new bugs... Maybe these two could be or... [11:14:12] 3Zero, Phabricator: Migration of the Zero team to Phabricator - https://phabricator.wikimedia.org/T88978#1024601 (10Qgil) 3NEW [11:15:53] 3Phabricator: Process to request a private project - https://phabricator.wikimedia.org/T823#1024613 (10Qgil) There is an ongoing discussion about the possibility for the Fundraising-Tech team to get permissions to mark some tasks private. See {T88762}. [11:36:01] 3Phabricator.org: 'Attaching' two mediawiki accounts results in AphrontCountQueryException - https://phabricator.wikimedia.org/T75720#1024653 (10Aklapper) @mmodell: Ping on the last two comments [11:39:05] 3Phabricator: Sending email to create tasks doesn't work for me - https://phabricator.wikimedia.org/T1077#1024659 (10Aklapper) @MarkAHershberger: Seeing the last two comments, is this still a problem? [11:44:18] 3Phabricator.org: Cursor should not exit a field after autocompletion - https://phabricator.wikimedia.org/T75844#1024671 (10Qgil) Back to the feature requested here. > If I autocomplete with enter, though, the cursor stays. How hard is it to press enter instead of tab, then? The current situation looks good... [11:54:35] 3Phabricator.org: Interpret #alias in quicksearch box as "in project #alias" - https://phabricator.wikimedia.org/T86110#1024687 (10Qgil) [12:38:06] 3Phabricator: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#1024711 (10Aklapper) Oh, I'm totally fine with temporarily changing the backend to the SQL-backed standard search. @Chad also proposes that in https://lists.wikimedia.org/pipermail/wikitech-l/2015-Februa... [12:43:27] 3Phabricator: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#1024713 (10chasemp) Very sick today but in general I can do this, probably wed as it will create an unknown period of search outage. I wanted to give @springle a heads up since any fallout likely affect... [13:43:31] 3Engineering-Community, Code-Review, Team-Practices: Organize a Gerrit Cleanup Day - https://phabricator.wikimedia.org/T88531#1024746 (10Qgil) [15:18:20] 3Phabricator.org: Exact matches should always win when suggesting/auto-completing - https://phabricator.wikimedia.org/T76732#1024884 (10JanZerebecki) Why not deploy the fix, that was merged upstream a month ago? [15:54:51] 3Phabricator.org: Exact matches should always win when suggesting/auto-completing - https://phabricator.wikimedia.org/T76732#1024953 (10Aklapper) >>! In T76732#1024884, @JanZerebecki wrote: > Why not deploy the fix -> T86772 [16:11:55] 3Phabricator: Next Phabricator upgrade on YYYY-MM-DD - https://phabricator.wikimedia.org/T86772#1025039 (10JanZerebecki) [16:24:23] 3Phabricator: Prevent private information being leaked via Herald notifications - https://phabricator.wikimedia.org/T493#1025120 (10scfc) What's stalling this? [16:25:25] 3Phabricator: Next Phabricator upgrade on YYYY-MM-DD - https://phabricator.wikimedia.org/T86772#1025124 (10JanZerebecki) Could someone take this up? It seems counter productive to work on workarounds when the we could deploy the real fix instead. [16:50:54] 3Phabricator.org: Provide a way to upload a file if drag'n'drop is not available or not wanted - https://phabricator.wikimedia.org/T165#1025184 (10Nnemo) [16:54:15] 3Phabricator.org: Provide a way to upload a file if drag'n'drop is not available or not wanted - https://phabricator.wikimedia.org/T165#1025192 (10Nnemo) [17:24:59] 3Phabricator, Wikimedia-Bugzilla: Create a static HTML version of Bugzilla - https://phabricator.wikimedia.org/T85140#1025297 (10Dzahn) a:5JohnLewis>3Dzahn [17:25:11] 3Phabricator, Wikimedia-Bugzilla: Create a static HTML version of Bugzilla - https://phabricator.wikimedia.org/T85140#939794 (10Dzahn) [17:25:48] 3Phabricator.org: Links open in a new tab (target="_blank") instead of having normal behaviour - https://phabricator.wikimedia.org/T88939#1025300 (10Nnemo) [17:33:59] 3Phabricator.org: Links open in a new tab (target="_blank") instead of having normal behaviour - https://phabricator.wikimedia.org/T88939#1025317 (10Nnemo) >>! In T88939#1024389, @Qgil wrote: > Phabricator seems to open external links in a new window consistently. If anybody has found more cases, please list the... [17:34:46] 3Phabricator.org: Links open in a new tab or new window (target="_blank") instead of having normal behaviour - https://phabricator.wikimedia.org/T88939#1025318 (10Nnemo) [17:38:37] 3Phabricator: Enable select Fundraising people to modify policy for tasks - https://phabricator.wikimedia.org/T88762#1025327 (10atgo) @qgil I guess we could do that, but I'm not sure how that addresses this need? As @chasemp said, our confidentiality needs are somewhat fluid so a static group would miss the mark. [17:46:39] 3Phabricator: Enable select Fundraising people to modify policy for tasks - https://phabricator.wikimedia.org/T88762#1025349 (10Krenair) So you want to be able to define custom visibility policies with only user-based access on each object, not against just a restricted-join project? That sounds like a good way... [17:59:12] 3Phabricator: Decide on "Needs Volunteer" Priority field value in Phabricator - https://phabricator.wikimedia.org/T78617#1025359 (10Aklapper) [18:02:52] 3Phabricator: Decide on "Needs Volunteer" Priority field value in Phabricator - https://phabricator.wikimedia.org/T78617#1025377 (10Dzahn) I would suggest do simply call the priorities: Lowest, Low, Normal, High and Highest. So replace "needs volunteer" with lowest and 'unbreak now' with highest. Other name... [18:17:26] 3Phabricator: Decide on "Needs Volunteer" Priority field value in Phabricator - https://phabricator.wikimedia.org/T78617#1025431 (10matmarex) [18:19:02] 3Phabricator: Decide on "Needs Volunteer" Priority field value in Phabricator - https://phabricator.wikimedia.org/T78617#849449 (10matmarex) [19:00:06] 3Phabricator: Decide on "Needs Volunteer" Priority field value in Phabricator - https://phabricator.wikimedia.org/T78617#1025573 (10Qgil) >>! In T78617#1025377, @Dzahn wrote: > I would suggest do simply call the priorities: Lowest, Low, Normal, High and Highest. Looking at the description of the problem, this... [19:07:57] 3Phabricator.org: Links open in a new tab or new window (target="_blank") instead of having normal behaviour - https://phabricator.wikimedia.org/T88939#1025596 (10Qgil) "Report a problem" is typed as an external link even if it points to this site: ==== {icon bug} [[ https://phabricator.wikimedia.org/maniphes... [19:09:46] 3Phabricator, Wikimedia-Bugzilla: Create a static HTML version of Bugzilla - https://phabricator.wikimedia.org/T85140#1025603 (10Dzahn) p:5Volunteer?>3Low [20:15:03] 3Engineering-Community, Code-Review: Organize a Gerrit Cleanup Day - https://phabricator.wikimedia.org/T88531#1025761 (10Awjrichards) [20:17:05] 3Phabricator.org: Bug - When editing a task description, in "full screen", the cloud upload button is broken - https://phabricator.wikimedia.org/T88998#1025769 (10Krenair) [20:33:35] 3Engineering-Community, Code-Review: Organize a Gerrit Cleanup Day - https://phabricator.wikimedia.org/T88531#1025864 (10hashar) Slightly out topic but giving some context about how I do my reviews: For my review I use a [[ https://gerrit.wikimedia.org/r/#/q/status:open+reviewer:self+label:code-review%253D0%252... [20:35:05] 3MediaWiki-General-or-Unknown, Project-Creators, Phabricator, MediaWiki-Core-Team: Allow to search tasks about MediaWiki core and core only (create MediaWiki umbrella project?) - https://phabricator.wikimedia.org/T76942#1025866 (10matmarex) >>! In T76942#946690, @Nemo_bis wrote: >> rename MediaWiki-General-or-Un... [20:42:28] 3Phabricator: Get rid of "Export to Excel" - https://phabricator.wikimedia.org/T257#1025894 (10Dzahn) It now says "(disabled)" to clarify that. I merged the change above. [20:43:04] 3Phabricator: Get rid of "Export to Excel" - https://phabricator.wikimedia.org/T257#1025895 (10Dzahn) >>! In T257#3253, @flimport wrote: > **aklapper** wrote on `2014-06-18 00:35:57 (UTC)` > > Installing PHPExcel on the server is already covered by T243 ^ wrong ticket number, that's something else [20:44:08] 3Phabricator: Get rid of "Export to Excel" - https://phabricator.wikimedia.org/T257#1025897 (10valhallasw) >>! In T257#1025895, @Dzahn wrote: >>>! In T257#3253, @flimport wrote: >> **aklapper** wrote on `2014-06-18 00:35:57 (UTC)` >> >> Installing PHPExcel on the server is already covered by T243 > > ^ wrong t... [20:44:29] 3Phabricator: Get rid of "Export to Excel" - https://phabricator.wikimedia.org/T257#1025898 (10valhallasw) 5Open>3Resolved a:3valhallasw [21:14:40] legoktm: remember how my commit message didn't trigger gerritbot because of the extra line at the end? I think `git review` encourages the problem: [21:14:50] remote: ERROR: missing Change-Id in commit message footer [21:14:50] remote: Suggestion for commit message: [21:14:50] remote: Add example to ApiBase::getExamples() [21:14:50] remote: [21:14:50] remote: Bug: T89035 [21:14:53] remote: [21:14:55] remote: Change-Id: Ia3410a35d7bfb1c234f2356b272c56a94cb11efb [21:15:00] ew :( [21:15:16] <^d> `git review` is a flaming pile of donkey shit [21:15:17] <^d> Don't use it [21:15:18] ^ I think that extra line is wrong amirite? [21:15:27] spagewmf: what ^d said basically. [21:16:10] ^d: I'm just following procedure. How else would I get a Change-id: ? [21:16:14] I ended up writing my own much lighter-weight git-review replacement: https://github.com/legoktm/grr [21:16:16] well, git-review adds it correctly [21:16:18] install the change-id hook? [21:16:22] er, actually [21:16:31] the message spagewmf posted is not git-review [21:16:34] it's gerrit itself [21:16:41] see where it says 'remote: '? ;-) [21:16:43] <^d> Yes, but he's saying git-review gave him that commit message [21:16:48] <^d> Which gerrit bitched at [21:17:24] ^d: eh, no? that message is gerrit giving a suggestion for the commit message when no change-id is provided [21:17:34] "ERROR: missing Change-Id in commit message footer " [21:18:04] <^d> then git-review sucks more than I thought if it can't even get the change-id right [21:18:12] <^d> IT HAS LIKE 2 JOBS [21:18:19] 3Phabricator: Enable select Fundraising people to modify policy for tasks - https://phabricator.wikimedia.org/T88762#1026036 (10atgo) I'm happy to start with visibility based on a "people" project as a first pass if that makes people more comfortable. If we get into problems from there, we can revisit. [21:18:39] ^d: not quite. I tried to make a commit in a local core/extensions/PageImages which I'd never checked out properly (https url not ssh, no .gitreview) So the git commit didn't add a change ID. I fixed up the repo, but then someone printed out misleading instruction [21:18:40] ...and adding the change-id isn't even git-review's task [21:18:50] it just installs the hook for you :-p [21:19:01] but don't let me keep you from hating git-review [21:19:06] <^d> Way too much complicated! [21:20:00] <^d> spagewmf: You should know better than to trust idiots on IRC!! [21:20:01] <^d> :) [21:20:34] maybe we can also just fix gerritbot to be less stupid? :p [21:20:56] <^d> You lost me at "fix gerrit*" [21:20:57] <^d> :P [21:21:10] :D [21:21:20] EVERYTHING WILL BE BETTER WITH PHABRICATOR [21:21:23] <^d> YES [21:21:34] except arc [21:21:44] valhallasw`cloud: I don't mind it being strict to encourage consistency, but it does seem like removing that `remote: ` would be a win. I'll phile a phab [21:21:46] which you will hate if you hate git-review :-p [21:22:36] can we just change the order of things? like.. it may sound crazy, but find replacement that works, migrate, stop using old one :p [21:23:19] <^d> valhallasw`cloud: No I won't, I've used arc. It's actually useful unlike git-review :) [21:23:58] I'll admit it does more useful stuff, yeah. It's also deeper black magic... [21:24:06] <^d> mmmm, the best kind of magic [21:32:52] 3Engineering-Community, Code-Review: Organize a Gerrit Cleanup Day - https://phabricator.wikimedia.org/T88531#1026070 (10scfc) Changing the default Gerrit front page makes sense to me. To avoid confusion, I would rename the table caption though ("Incoming open reviews" or something similar). [22:25:17] 3Phabricator: Get rid of "Export to Excel" - https://phabricator.wikimedia.org/T257#1026241 (10Dzahn) thanks, valhallasw. note to self: andre__ told me how to check for the new number of old tickets imported from fab labs. use prefix "fl" in the reference field in advanced search [23:34:36] 3Phabricator.org: When editing a task description, in "full screen", the cloud upload button is broken - https://phabricator.wikimedia.org/T88998#1026609 (10Aklapper) p:5Normal>3Volunteer?