[10:53:30] greg-g hi, it seems i made a mistake with how the logo should be set which is fixed in https://gerrit.wikimedia.org/r/#/c/308308/ [10:53:54] but anyways in the new phab update it should become less noticble that configs doint exist [10:54:25] since they removed the red ribbon and replace it with a little circle icon on the top bar next to the message icon [10:54:38] it shows how many notifications there are now in yellow. [10:54:41] :) [13:38:50] 10Phabricator, 07Availability, 13Patch-For-Review, 07WorkType-NewFunctionality: Deploy phabricator to phab2001.codfw.wmnet - https://phabricator.wikimedia.org/T137928#2608817 (10Volans) @Dzahn @mmodell FYI looks like Salt is not properly configured for phab2001, it doesn't answer to normal test.ping or oth... [15:12:23] qchris Hi, im wondering do you know how i could change the default CodeMirror options please in gerrit 2.12.4 [15:12:33] i want to change https://github.com/gerrit-review/gerrit/blob/7f4c48f37b9a8970ae2f8c8dc881f603ec9e707f/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySide.java#L254 [15:13:02] to true but doint know how to change it without manually changing it then rebuilding the war. [15:13:03] ? [15:13:46] paladox: No clue. Not sure if that is possible. [15:13:52] Let alone on a per-user basis. [15:14:23] I guess you'd need to patch gerrit to get that working. [15:14:53] Make that line something like: [15:14:54] .set("lineWrapping", prefs.enableLineWrapping()) [15:15:09] And add the enableLineWrapping method to the prefs object. [15:15:20] And also exposing it to the User preference screen. [15:15:31] Oh [15:15:58] thanks [15:16:06] I will see if ostriches will be ok with that [15:16:11] But not sure [15:16:24] If you implement that ... you should send it upstream. [15:16:37] I am sure they'd merge it :-) [15:16:42] Oh, but you have to sign something which i doint like doing. [15:16:48] What would the signing bit [15:16:49] do [15:17:13] I guess i could create a seperate google account that dosent have my real name and photo. [15:17:24] Yup, you can do that. [15:17:30] ok thanks [15:17:43] Singing "just" gives them the right to use your patch and do with it whatever they want. [15:18:27] Ok [15:18:29] thanks [15:28:49] * paladox my first time at editing java :) [18:07:01] 10Phabricator: Disable blogs on Phabricator - https://phabricator.wikimedia.org/T135689#2307197 (10Nemo_bis) [18:21:44] 10Phabricator: Disable blogs on Phabricator - https://phabricator.wikimedia.org/T135689#2609588 (10Aklapper) This task could be reopened (and the task summary be potentially adjusted) as [[ https://lists.wikimedia.org/pipermail/wikitech-l/2016-August/086379.html | there are now actual concerns brought up ]] (whi... [19:10:19] 10Phabricator: Disable blogs on Phabricator - https://phabricator.wikimedia.org/T135689#2307197 (10Paladox) According to T144338 two teams at Wikimedia have started using phame (blog), I doint know why you want this disabled. Why do you want it disabled? Since it is not in the way and plus it allowed teams suc... [19:12:07] 10Phabricator: Disable blogs on Phabricator - https://phabricator.wikimedia.org/T135689#2609662 (10Paladox) @Aklapper he in https://lists.wikimedia.org/pipermail/wikitech-l/2016-August/086379.html is referring to T14338 he wasent asking for it to be disabled he just wants to be able to comment unless I'm wrong. [19:19:07] 10Phabricator: Disable blogs on Phabricator - https://phabricator.wikimedia.org/T135689#2609674 (10Aklapper) No, see that email. It says "Apparently there hasn't been much discussion or deliberation about the advantages and disadvantages of this new feature compared to other communication channels." [19:22:58] 10Phabricator: Disable blogs on Phabricator - https://phabricator.wikimedia.org/T135689#2609677 (10Paladox) But https://blog.wikimedia.org/ is not as widly used as phabricator, I never read https://blog.wikimedia.org/ due to the fact it is not easy to find stuff about mw or anything like phabricator related eit... [19:26:20] 10Phabricator: Disable blogs on Phabricator - https://phabricator.wikimedia.org/T135689#2609678 (10Aklapper) And that's **exactly** why to potentially discuss the **scope** here. > But https://blog.wikimedia.org/ is not as widly used as phabricator Citation needed. ;) [19:28:14] 10Phabricator: Disable blogs on Phabricator - https://phabricator.wikimedia.org/T135689#2609679 (10Paladox) >>! In T135689#2609678, @Aklapper wrote: > And that's **exactly** why to potentially discuss the **scope** here. > >> But https://blog.wikimedia.org/ is not as widly used as phabricator > > Citation need... [20:42:29] qchris_away hi, yay it worked [20:42:37] all works now, through preference [20:42:42] \o/ [20:42:47] how can i now do some css customisations [20:42:54] for if we use linewrapping or [20:42:55] not [20:43:10] since it needs a bit more csss otherwise it will wrap to much in [20:43:21] qchris_away ^^ [20:46:24] qchris_away also if i submit the patch can it be backported to 2.13 and 2.12 please? Even though it looks like it is a new feature it is not, but it will fix T144565 [20:46:24] T144565: Gerrit's new side-by-side diff screen sometimes cuts off the last few characters of a line - https://phabricator.wikimedia.org/T144565 [20:46:32] also this was my first time at java yay for me [20:47:30] It's hard to say where to best add css. It depends a bit how you implemented things. But gerrit only comes with some 2 dozen css files. So I'd just add it to whatever file looks like a best fit. People doing code review on gerrit will advise you where to put it. [20:47:50] ok thanks [20:48:14] If it is a bug fix, just open a corresponding bug in gerrit's bug tracker (if it does not exist already), and [20:48:43] mention the bug number in you commit message. Then do not submit for review on master, but for review on the stable-2.12. [20:49:24] If they accept the patch, they'll merge it to 2.12 and it will automatically flow to 2.13 and master too. [20:49:46] qchris_away ok thankyou [20:49:47] Pretty cool, if that's your first java coding :-) [20:49:49] and yes theres two bugs [20:51:03] qchris_away https://bugs.chromium.org/p/gerrit/issues/detail?id=4292 and https://bugs.chromium.org/p/gerrit/issues/detail?id=2410 [20:51:58] Cool beans. Be sure to mention them in the commit message :-) [20:52:35] Ok [20:52:51] qchris_away how do you meantion them? is there a special way? [20:53:32] qchris_away also im signing the cla but it is asking for my address [20:54:20] I just put england as my address lol [20:54:40] Bug: Issue 4292 [20:54:53] Having ^ in the footer should do the trick. [20:58:31] Ok thanks [21:36:30] qchris_away should i switch it on by default or leave it off [21:36:48] and is there a way for a admin to set its default for logged out users please? [21:37:27] It's `false` now, so I'd keep that as default. [21:38:13] To set it for logged out users as admin, you have to additionally make it a config option (which is different from a user pref). [21:38:21] I am not sure if it's worth it. [21:39:15] (If os-triches is ok with the current default, it's for sure not worth adding that config option) [21:43:05] Ok [21:45:05] qchris_away would we be able to set it as true in gerrit 2.13 due to it has not been released yet and seems like a perfect candidate :) [21:45:44] I guess that's a question for the gerrit maintainers :-) [21:45:47] Ok [21:47:13] qchris_away when i upload in a few mins can i add you as reviewer please? [21:47:39] I have not worked on gerrit in >1 year ... not sure I can help much there. [21:48:00] But sure, if you think I can be of help. Add me. [21:49:27] Ok [21:49:29] thanks [21:57:24] 10Phabricator: Herald_rule_for_iOS - https://phabricator.wikimedia.org/T143948#2609855 (10MBinder_WMF) @mmodell hiya, just checking in on this. Not urgent, but it's simply on my list of things to resolve. Anything I can do to help? [22:07:10] volans are you watching the apple iphone event on wednesday, also did you know theres the #wikimedia-offtopic channel :) [22:33:36] qchris_away https://gerrit-review.googlesource.com/85355 [22:33:38] :) [22:34:09] Yay! [22:34:12] Should i add the min-width to https://github.com/gerrit-review/gerrit/blob/80ebb4529edfae9dad7b509b1bf9ab191c63bc95/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySideTable.ui.xml#L81 [22:34:17] qchris_away ^^ [22:34:27] i will probaly do min-width: 60em [22:34:42] as it will look ugly for lineWrapping if not done [22:35:12] qchris_away but i would like to know can i, since i doint want to add it for it to get rejected or course other problems i havent seen [22:35:13] yet [22:35:49] see test here http://gerrit-new.wmflabs.org/r/#/c/2/2/tests/fixtures/layout-cloner.yaml [22:36:10] Totally not sure about the min-width. If you want to get it in, put it in and wait if the reviewers complain about it :-) [22:36:22] Ok [22:36:40] It seems you're touching plugins/* ... is that on purpose? [22:37:06] (I would not expect your change to need to update plugins) [22:37:39] Oh nope [22:37:44] i should not have included that [22:38:48] qchris_away it seems they rejected my cla once i uploaded that patch [22:39:05] https://gerrit-review.googlesource.com/#/c/85355/1/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditPreferencesBox.ui.xml [22:39:17] ^ seems to hold the same change three times. [22:39:32] They rejected your CLA? Mhmm. [22:39:34] Oh woops [22:39:38] wrong account [22:39:56] qchris_away how can i had that patch i uploaded under my real name [22:40:04] had = hide [22:40:06] or delete [22:40:11] it has my photo [22:41:05] qchris_away is there also a way for me to get rid of the changes to the plugins please? [22:41:28] First about the picture ... email the gerrit maintainers. [22:41:36] Ok, how? [22:41:38] And ask them to nuke that change [22:42:07] Ok [22:42:38] I just sent an email address in pm. [22:42:47] He is a gerrit account and very nice and helpful. [22:43:15] I am sure he can either nuke the change for you, or tell you whom to ask to get it deleted. [22:44:17] About getting rid of the plugin changes ... just upload a new revision that does not touch plugins/* [22:44:29] They are not picky if previous patch sets had issues. [22:44:52] Ok [22:44:53] thanks [22:44:58] and thanks for your help [22:45:03] yw. [22:45:19] Do i include some kind of .gitignore rule [22:45:22] to ignore plugins [22:45:25] Glad you managed to put the commit together and upstream it! [22:45:31] your welcome [22:45:33] :_ [22:45:34] :) [22:45:43] The plugins are submodules. [22:45:48] .gitignore will get messy. [22:45:51] Oh [22:46:07] Best thing will be to just reset them to the state before your commit. [22:46:13] Ok [22:53:45] qchris_away also patch 4, i keep mistakly going onto the wrong browser [22:53:47] please [22:56:48] Be careful :-) If you bug the Gerrit maintainers at gerrit-review.googlesource.com too often, they may push back :-) [22:58:24] Ok [22:58:25] sorry