[08:33:22] any Phabricator ops around? [08:33:34] tgr: I am [08:33:39] what's up? [08:33:49] please set https://phabricator.wikimedia.org/F5039980 to private [08:34:43] I don't know if I can ... [08:34:59] I can delete it [08:35:05] it's under "edit file", normally [08:35:38] admins don't get extra rights like that [08:35:55] twentyafterfour: deleting works too, I just downloaded it [08:36:01] files inherit their rights from the task they are attached to [08:36:11] ok I'll delete it since that's the only thing I can do immediately [08:36:33] other stuff takes a bit longer (manal sql query to change visibility ) [08:36:33] thanks [08:38:18] done [08:39:31] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864215 (10mmodell) @paladox: I always test before deploying to prod. Thanks for catching this though. [08:42:11] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864221 (10Paladox) Oh, your welcome. [08:43:08] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864222 (10mmodell) 05Open>03Resolved a:03mmodell [08:48:37] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864227 (10Paladox) @mmodell hi why close this as resolved? [08:58:45] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864236 (10mmodell) I pushed the fix to wmf/stable. [09:00:56] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864239 (10mmodell) [09:14:52] 10Phabricator, 06Labs, 06Operations, 10Tool-Labs, and 2 others: Install Arcanist in toollabs::dev_environ - https://phabricator.wikimedia.org/T139738#2864252 (10hashar) Puppet patch https://gerrit.wikimedia.org/r/#/c/297975/ will add arcanist on tools development environment for Trust and Jessie. Precise... [14:09:59] 10Phabricator: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2864731 (10faidon) [14:29:13] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2864777 (10Krenair) See also T142516 [15:54:42] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2864973 (10mmodell) a:03mmodell [15:56:44] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2864982 (10mmodell) the "security field" no longer has any affect. It's only remaining for historical reasons - to not lose the bit of information on old tasks which had a value set.... [15:58:37] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2864989 (10Aklapper) ( https://www.mediawiki.org/wiki/Phabricator/Security might also welcome an overhaul) [16:00:06] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2864991 (10mmodell) The task that @krenair linked above is about making a form specifically for 'other confidential issues' ... It's not currently linked from anywhere prominent, but... [16:05:31] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2865019 (10Aklapper) Also see https://phabricator.wikimedia.org/T152395#2863188 for potentially related confusion [16:07:33] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2865036 (10mmodell) I've hidden the security field from the 'advanced' task form. In other places the field is visible but locked. [16:08:09] 10Phabricator: Custom task form for #WMF-NDA - https://phabricator.wikimedia.org/T142516#2865038 (10mmodell) I think this task should be marked as complete? the primary purpose has been fulfilled. [16:09:17] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2865055 (10mmodell) 05Open>03Resolved [16:16:33] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2865071 (10mmodell) @paladox: There was no need to ping epriestley about this, it's not his problem. [16:17:03] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2865072 (10Paladox) ok sorry. [17:13:04] 10GitHub-Mirrors, 06Analytics-Kanban, 07Documentation, 07Easy: Mark documentation about limn as deprecated - https://phabricator.wikimedia.org/T148058#2865249 (10Nuria) [17:13:15] 10GitHub-Mirrors, 06Analytics-Kanban, 07Documentation, 07Easy: Mark documentation about limn as deprecated - https://phabricator.wikimedia.org/T148058#2713665 (10Nuria) a:03mforns [17:58:30] 10Phabricator: Custom task form for #WMF-NDA - https://phabricator.wikimedia.org/T142516#2865453 (10AlexMonk-WMF) I think it's close, it just needs the tag field to always include #WMF-NDA and I think the only way to do that right now is to lock it. [17:58:37] andre__: can Legalpad signature seeing be restricted to a certain Space? [18:00:04] MarcoA: no, as Spaces are something very different :) [18:00:16] did you mean "a certain group of people" instead? :) [18:00:23] andre__: Ah, sigh. [18:00:46] andre__: yes, well, I'm still figuring out a solution for Access Policy - Approvers group [18:00:47] in case of the latter: yes. [18:01:15] well, can you can use an ACL to restrict a space and the same ACL for teh legalpad? I can't recall if they can have individual acls [18:01:42] spaces have acl*xxx_policy_admins [18:02:25] indeed [18:04:06] that's how Spaces do work now, right? [18:05:06] so, maybe, Access_Policy - Approvers should be turned into an acl*xxx [18:05:24] That's how we configure our Spaces: Setting Edit and Join policy to members of a project that we call acl*, and removing the default that allows everybody to join that project. [18:13:04] andre__: right, but apparently Visible-To / Editable-By fields cannot be space-restricted in Legalpad for signatures? [18:13:28] I'm a bit lost with policies and spaces and restrictions [18:14:43] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2865536 (10faidon) Thanks, that was fast :) When was this changed? Shouldn't we audit all the tasks opened using that functionality since it was deprecated to make sure we don't have... [18:15:51] MarcoA: Simply forget that "Spaces" exist. Problem solved. [18:16:15] andre__: I'm not that type of guy :P [18:16:32] Legalpad objects (documents) have Edit/Visible properties, just like any other objects such as tasks or projects. [18:16:58] and you can add specific users names as values of these properties. Or "member of project XYZ". Or "Phab admins". :) [18:19:50] andre__: right, that I know. I'll read some more docs for fun though. Thanks. [18:20:17] andre__: fwiw, I'd like to move on converting some old tracking tasks into tags which were proposed for conversion some time ago, any objections? [18:21:05] MarcoA, if I didn't comment on the task I hope I don't have any objections :D [18:21:15] I guess you are aware of https://www.mediawiki.org/wiki/Phabricator/Project_management/Tracking_tasks [18:21:18] Thanks! :) [18:21:28] andre__: in any case I'll comment on the task /before/ conversion [18:21:35] aye [18:23:24] haha... thank you! [18:28:21] bot: https://phabricator.wikimedia.org/p/Liugev6/ [18:28:25] 10Phabricator, 06Project-Admins, 06Discovery, 06Maps: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2865578 (10Yurik) Bummer, now we no longer get any of the Phabricator notifications in the wikimedia-interact... [18:29:17] twentyafterfour, where did the security dropdown go? I think it caused Herald to revert my tag change [18:29:46] Krenair: it's just hidden, it shouldn't affect anything ... [18:29:50] link? [18:30:19] 10Phabricator, 06Project-Admins, 06Discovery, 06Maps: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2865584 (10Aklapper) @Yurik: https://phabricator.wikimedia.org/diffusion/TWBT/browse/master/channels.yaml [18:31:21] 10Phabricator, 06Project-Admins, 06Discovery, 06Maps: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2865590 (10Yurik) @aklapper but it was there -- https://phabricator.wikimedia.org/diffusion/TWBT/browse/maste... [18:31:45] twentyafterfour, on https://phabricator.wikimedia.org/T148108 [18:32:00] at the bottom it says 'Herald added a project: Security' [18:33:31] ah crap [18:33:35] hmm.. [18:41:44] 10Phabricator, 06Project-Admins, 06Discovery, 06Maps: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2865635 (10Aklapper) @Yurik: https://phabricator.wikimedia.org/T148650 might provide some insights on milesto... [18:50:07] 10Phabricator, 06Project-Admins, 06Discovery, 06Maps: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2865657 (10Yurik) @Aklapper uploaded https://gerrit.wikimedia.org/r/#/c/326496/ - please +2, thx! [19:39:15] 06Project-Admins, 06Release-Engineering-Team, 10ReleaseTaggerBot: Move all WMF-deploy-* projects to be milestones of ?? the "MW-1.XX-release-notes" projects? - https://phabricator.wikimedia.org/T152999#2865940 (10Jdforrester-WMF) [19:51:40] 10Phabricator, 06Developer-Relations (Oct-Dec-2016), 07Performance: Review and consolidate current Herald rules - https://phabricator.wikimedia.org/T141703#2865999 (10Aklapper) [19:51:42] 06Project-Admins, 06Release-Engineering-Team, 10ReleaseTaggerBot: Move all WMF-deploy-* projects to be milestones of ?? the "MW-1.XX-release-notes" projects? - https://phabricator.wikimedia.org/T152999#2865940 (10greg) Sure? :) [19:52:47] 06Project-Admins, 06Release-Engineering-Team, 10ReleaseTaggerBot: Move all WMF-deploy-* projects to be milestones of ?? the "MW-1.XX-release-notes" projects? - https://phabricator.wikimedia.org/T152999#2866007 (10Aklapper) Yo! [20:35:56] 10Phabricator, 10Elasticsearch: Collect test cases for phabricator search - https://phabricator.wikimedia.org/T151500#2819387 (10matmarex) Search for "english wikipedia collation" (https://phabricator.wikimedia.org/search/query/Lcdmm9jP357z/#R) currently does not find T136150. {F5043709} [21:27:10] 10Phabricator: Phabricator workboard layout breaks with too many sidebar links - https://phabricator.wikimedia.org/T152143#2866382 (10Aklapper) 05Open>03stalled @jhobs: ping? [23:17:12] 06Project-Admins, 10AbuseFilter: Rename the tag for rEABF - https://phabricator.wikimedia.org/T152536#2866636 (10MarcoAurelio) Indeed. This is just confusing as it is.