[01:46:39] 10Phabricator: Phabricator activity feed on dashboard not working properly - https://phabricator.wikimedia.org/T158947#3054654 (10Paladox) The query was changed here https://phabricator.wikimedia.org/W726 by @mmodell [05:29:08] 10Phabricator: Phabricator activity feed on dashboard not working properly - https://phabricator.wikimedia.org/T158947#3054889 (10mmodell) My intention was that the default dashboard should show activity for projects that a user is subscribed to. You can of course customize the dashboard with different settings... [07:29:48] 10Phabricator, 13Patch-For-Review: Restrict maximum file size for Phabricator file uploads - https://phabricator.wikimedia.org/T151544#3054944 (10mmodell) 05Open>03Resolved a:03mmodell [12:01:04] 10Phabricator: Create custom task form for #wikitech.wikimedia.org for user access/permission requests - https://phabricator.wikimedia.org/T158952#3055102 (10MarcoAurelio) @Aklapper @mmodell There's no formal on-wiki page where permissions are currently requested. All permissions requests I am aware of have been... [12:07:23] 10Phabricator: Create custom task form for #wikitech.wikimedia.org for user access/permission requests - https://phabricator.wikimedia.org/T158952#3052614 (10Peachey88) Is there any reason we are jumping straight to phabricator form request instead of trying a on wiki page? [12:29:37] 10Phabricator: Create custom task form for #wikitech.wikimedia.org for user access/permission requests - https://phabricator.wikimedia.org/T158952#3055120 (10MarcoAurelio) There's no jumping if wiki pages were never used as far as I am aware. [13:44:24] 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Migrate gerri's its-phabricator plugin to use maniphest.edit conduit - https://phabricator.wikimedia.org/T159041#3055172 (10Paladox) [13:44:30] 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Migrate gerrit's its-phabricator plugin to use maniphest.edit conduit - https://phabricator.wikimedia.org/T159041#3055184 (10Paladox) [13:45:35] 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Migrate gerrit's its-phabricator plugin to use maniphest.edit conduit - https://phabricator.wikimedia.org/T159041#3055172 (10Paladox) p:05Triage>03High It's using the deprecated code here https://gerrit.googlesource.com/plugins/its-phabricator/+/master... [13:46:16] 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Migrate gerrit's its-phabricator plugin to use maniphest.edit conduit - https://phabricator.wikimedia.org/T159041#3055187 (10Paladox) @mmodell is it easy just to switch to maniphest.edit or does some code need changing to support it? [13:49:11] 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Migrate gerrit's its-phabricator plugin to use maniphest.edit conduit - https://phabricator.wikimedia.org/T159041#3055188 (10Paladox) Benefits of this is we can then add support for removing tags with the api as maniphest.update does not support that. [13:53:09] 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Migrate gerrit's its-phabricator plugin to use maniphest.edit conduit - https://phabricator.wikimedia.org/T159041#3055189 (10Paladox) Heres my starting patch https://gerrit-review.googlesource.com/#/c/98576/ not sure if it is that easy to switch like that. [14:15:03] 10Phabricator, 06Operations, 06Release-Engineering-Team: Update file phab_epipe.py to use maniphest.edit conduit api - https://phabricator.wikimedia.org/T159043#3055204 (10Paladox) [14:21:49] 10Phabricator, 06Operations: Update phabricator.py file to use maniphest.edit conduit api - https://phabricator.wikimedia.org/T159045#3055228 (10Paladox) [14:32:20] 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3055253 (10Paladox) [14:33:08] 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3055172 (10Paladox) [14:33:55] qchris__ Hi, im wondering could you help with ^^ please if your not busy :). Im trying to do it but am unsure how to do it. [14:34:33] I do have an initial patch https://gerrit-review.googlesource.com/#/c/98576/ [14:35:45] 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3055256 (10Paladox) [14:58:45] 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3055258 (10Paladox) Its not actually that easy to convert it, it seems. @mmodell would you be able to convert it please? [17:03:23] 10Phabricator: Create custom task form for #wikitech.wikimedia.org for user access/permission requests - https://phabricator.wikimedia.org/T158952#3055338 (10mmodell) Created: https://phabricator.wikimedia.org/maniphest/task/edit/form/30/ [18:01:59] 10Phabricator, 06Operations, 07Technical-Debt: Update phabricator.py file to use maniphest.edit conduit api - https://phabricator.wikimedia.org/T159045#3055365 (10Aklapper) [18:02:05] 10Phabricator, 06Operations, 06Release-Engineering-Team, 07Technical-Debt: Update file phab_epipe.py to use maniphest.edit conduit api - https://phabricator.wikimedia.org/T159043#3055367 (10Aklapper) [18:02:11] 10Phabricator, 10Gerrit, 06Release-Engineering-Team, 07Technical-Debt: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3055369 (10Aklapper) [18:03:11] 10Phabricator, 06Operations, 07Technical-Debt: Update wmf_auto_reimage.py file to use maniphest.edit conduit api - https://phabricator.wikimedia.org/T159045#3055371 (10Paladox) [18:11:35] 10Phabricator, 06Operations, 06Operations-Software-Development, 07Technical-Debt: Update wmf_auto_reimage.py file to use maniphest.edit conduit api - https://phabricator.wikimedia.org/T159045#3055379 (10Volans) a:03Volans [18:17:56] 10Phabricator, 06Operations, 06Operations-Software-Development, 07Technical-Debt: Update wmf_auto_reimage.py file to use maniphest.edit conduit api - https://phabricator.wikimedia.org/T159045#3055383 (10Volans) p:05Triage>03Normal [18:25:49] 10Phabricator, 06Operations, 06Operations-Software-Development, 07Technical-Debt: Update Puppet repo code that uses maniphest.edit conduit api - https://phabricator.wikimedia.org/T159045#3055400 (10Volans) [18:27:14] 10Phabricator, 06Operations, 06Operations-Software-Development, 07Technical-Debt: Update Puppet repo code that uses maniphest.update and maniphest.createtask conduit api - https://phabricator.wikimedia.org/T159045#3055404 (10Paladox) [18:28:46] 10Phabricator, 10GerritBot: make gerritbot remove the "patch-for-review" tag once a patch is merged (or abandoned) - https://phabricator.wikimedia.org/T95309#3055407 (10Paladox) This requires T159041 first be fixed. As the maniphest.update conduit api docent support this but maniphest.edit conduit does. [18:29:02] 10Phabricator, 10Gerrit, 06Release-Engineering-Team, 07Technical-Debt: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3055172 (10Paladox) [18:29:10] 10Phabricator, 10GerritBot: make gerritbot remove the "patch-for-review" tag once a patch is merged (or abandoned) - https://phabricator.wikimedia.org/T95309#3055409 (10Paladox) [18:29:31] 10Phabricator, 10GerritBot: Create a phabricator api method to remove 'patch-for-review' tag from a task - https://phabricator.wikimedia.org/T95307#1186257 (10Paladox) maniphest.edit supports this now. [19:23:02] paladox: Sure we can make that Phabricator API change work. I've got a few crazy week ahead of me, so I wondered if you know when WMF would switch to a Phab without the old API? Also, is there a test Phab instance with the new API? [19:25:47] qchris__ the api has been there for a while i think maybe a year or two [19:26:10] Ah. Neat :-) [19:26:11] qchris__ we can use phab-01 for testing [19:27:03] Cool. Thanks. I'll work on an update :-) [19:27:17] Do we know when Phab will remove the old API? [19:27:25] Days? Weeks? Months? [19:28:07] Nope, upstream haven't said [19:28:16] Ok. [19:28:27] Sounds like we do not need it extra-urgently. [19:28:35] But I'll see to getting it done. [19:28:41] Ok thanks [19:29:28] Thanks for noticing /before/ they removed the API. This was not always smooth in the past :-) [19:29:36] Yep [19:29:39] your welcome :) [19:29:46] the plugin seems to also use maniphest.info which needs replacing with maniphest.search and project.query to project.search. [19:30:07] it seems that the way i did it https://gerrit-review.googlesource.com/#/c/98576/ [19:30:23] fails to build as JsonObject exists in gson but also in javax. [19:30:50] We'll sort these issues out. No doubt :-) [19:31:07] Yep :) [19:31:24] Probably, an easy with either using the full class name, or messing with the imports a bit. [19:31:50] oh [19:57:28] 10Phabricator: Create custom task form for #wikitech.wikimedia.org for user access/permission requests - https://phabricator.wikimedia.org/T158952#3055485 (10MarcoAurelio) @mmodell Please lock & hide the tags field for the creation of the task if at all possible. Thanks. [19:59:40] 10Phabricator: Create custom task form for #wikitech.wikimedia.org for user access/permission requests - https://phabricator.wikimedia.org/T158952#3055486 (10MarcoAurelio) If possible, place #Labs before #wikitech.wikimedia.org (I know the order doesn't matter but looks cleaner that way). [20:02:15] 10Phabricator: Create custom task form for #wikitech.wikimedia.org for user access/permission requests - https://phabricator.wikimedia.org/T158952#3055488 (10MarcoAurelio) Ah, the "(modifiable)" in the title was a note for the form creator that the field should be able to be editted. You can remove that too if p... [22:43:00] qchris__ hi, i managed to update https://gerrit-review.googlesource.com/#/c/98576/ and it builds correctly but i haven't tested weather it will work. [22:43:19] Awesome! [22:44:29] Took alot of research. But it seems that ArryaList does [] not {}. [22:49:18] qchris__ i wonder how to do [ { in java per docs at https://secure.phabricator.com/book/phabricator/article/conduit_edit/ ? [22:49:53] You don't. You code it out. [22:50:14] oh [22:50:27] ArrayList for [] is a good choice. [22:50:38] You could use HashMap for {}. [22:52:30] Oh [22:52:52] so doing Arraylist then using hashmap in it will that work? [22:55:32] actually ArrayList will break it as it needs to be "transactions": { "type": "title", "value": "test" } [22:56:09] I have not yet had time to look at your code, but [ { } ] would be a List of Maps, so an ArrayList of HashMaps would work. [22:56:35] oh ah [22:56:35] I do not see [] in the previous line ... ;-) [22:57:06] Oh [22:57:19] "transactions": [ { "type": "title", "value": "test" } ] [22:57:30] * paladox will try testing the plugin now. [22:58:14] HashMap map = new HashMap(); [22:58:23] map.put("type", "title"); [22:58:30] map.put("value", "test"); [22:58:56] i did [22:58:56] HashMap params = new HashMap<>(); [22:58:57] List> list = new ArrayList<>(); [22:59:05] oh [22:59:06] ah [22:59:14] list.add(map) [22:59:19] i was missing that one [22:59:20] i had it as ArrayList list = new ArrayList<>(); [22:59:33] containerOfTransactions.put("transactions", list); [22:59:45] Meh: [22:59:46] HashMap map = new HashMap(); [22:59:48] should be [22:59:53] HashMap map = new HashMap(); [23:00:02] Oh [23:00:08] But your HashMap should work too. [23:00:22] yep, i would need HashMap map = new HashMap(); and HashMap map = new HashMap(); [23:01:28] Not sure I follow, but the above should model your "transactions=[...]" from the CR. [23:01:38] But I've got to work on other things. [23:01:48] I hope the above helped to unblock you. [23:02:02] s/other things/other things now/ [23:02:31] Yep, thanks, that helps :) [23:06:14] I guess the list part is like [23:06:15] HashMap params = new HashMap<>(); [23:06:22] params.put("objectIdentifier", taskId); [23:06:26] List> list = new ArrayList<>(); [23:06:32] HashMap params2 = new HashMap(); [23:06:39] HashMap params3 = new HashMap(); [23:06:44] params2.put("type", "comment"); [23:06:48] params3.put("value", comment); [23:06:56] params2.put("type", "projects.add"); [23:07:01] params3.put("value", projects); [23:07:07] list.add(params2); [23:07:07] list.add(params3); [23:07:07] params.put("transactions", list); [23:07:21] qchris__ ^^ ? [23:07:38] HashMap params3 = new HashMap(); [23:07:45] ^ that will fail [23:07:48] It should be: [23:07:48] it incloh [23:07:50] ohh [23:07:53] HashMap params3 = new HashMap(); [23:08:01] You can abbreviate that to: [23:08:03] ah i see [23:08:04] HashMap params3 = new HashMap<>(); [23:08:13] That spares duplication. [23:08:22] Yeh [23:08:24] thanks [23:08:40] And one other thing... [23:08:59] You're throwing in two different kind of HashMaps into a List generic. [23:09:00] yep [23:09:04] oh [23:09:09] That would fail too. [23:09:18] Make that: [23:09:18] oh [23:09:28] List list = new ArrayList<>(); [23:09:37] Oh, thanks :) [23:09:49] yw. [23:09:52] :) [23:11:42] Yay that builds too :) [23:11:47] * paladox tests it. [23:47:43] 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Update its-phabricator gerrit plugin to use cli- tokens instead of certificates. - https://phabricator.wikimedia.org/T159060#3055605 (10Paladox) [23:48:01] 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Update its-phabricator gerrit plugin to use tokens instead of certificates. - https://phabricator.wikimedia.org/T159060#3055617 (10Paladox) [23:48:08] 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Update its-phabricator gerrit plugin to use tokens instead of certificates - https://phabricator.wikimedia.org/T159060#3055605 (10Paladox) [23:51:24] qchris__ im going to see if i can replace certificates with tokens in the plugin [23:52:00] Sure. Run wild :-) [23:53:50] Yep :)