[00:04:38] (CR) Mwalker: [C: -1] "(1 comment)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/85354 (owner: Adamw) [00:32:49] (CR) Mwalker: [C: 2 V: 2] "(1 comment)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86041 (owner: Adamw) [00:46:53] (CR) Mwalker: [C: 2 V: 2] (FR #918) Send rejects to the -damaged queues. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/85354 (owner: Adamw) [00:52:15] (CR) Mwalker: [C: 2 V: 2] (FR #1070) Drupal registry supports namespaces [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/82265 (owner: Adamw) [01:33:18] (PS1) Adamw: Skeletal admin page for rejection queue recovery [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86062 [17:12:43] (CR) Mwalker: [C: 2 V: 2] Skeletal admin page for rejection queue recovery [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86062 (owner: Adamw) [18:14:35] !log updating fr crm from aa79ff40f3ce1534d899c21c81dfb914caad3fae to 1c10b4b181925d882ada0024011e28f75b781390 [18:15:01] Logged the message, Master [21:32:53] (PS1) Adamw: fix a deprecated reference to old dequeue function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86177 [21:33:09] mwalker: ^^ [21:33:40] (CR) Mwalker: [C: 2 V: 2] fix a deprecated reference to old dequeue function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86177 (owner: Adamw) [21:36:09] (PS1) Mwalker: Return a valid result from enqueue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86178 [21:39:53] (CR) Adamw: [C: 2] "thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86178 (owner: Mwalker) [21:39:58] (PS2) Adamw: Return a valid result from enqueue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86178 (owner: Mwalker) [21:40:04] (CR) Adamw: [C: 2] Return a valid result from enqueue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86178 (owner: Mwalker) [21:40:12] (CR) Adamw: [V: 2] Return a valid result from enqueue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86178 (owner: Mwalker) [21:41:49] !log update crm from 1c10b4b181925d882 to 8180a18a7cb9a4bf64f5 [21:42:04] Logged the message, Master [21:46:44] (PS1) Adamw: Return a result from requeue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86180 [21:48:11] (CR) Katie Horn: [C: 2 V: 2] "Hah." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86180 (owner: Adamw) [21:49:18] !log updated crm from 8180a18a7cb9a4bf64f5a8a7e192ca6f8f910a0a to bf4c7090099a866389105a3a38be4f950dd78b89 [21:49:29] Logged the message, Master [22:57:18] (PS1) Mwalker: Do not set a null checked variable to false [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86195 [22:57:30] (PS2) Mwalker: Do not set a null checked variable to false [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86195 [22:58:49] (CR) Adamw: [C: 2 V: 2] Do not set a null checked variable to false [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/86195 (owner: Mwalker) [23:01:39] !log updating fundraising crm from bf4c7090099a866389105a3a38be4f950dd78b89 to 1f659b73fddd26939081d21c3ff4098a77589e61 [23:01:49] Logged the message, Master [23:23:33] (PS1) Mwalker: Correct Banner Over Allocation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/86201 [23:34:57] (CR) Adamw: [C: -1] "The if statement is a very good improvement, but I disagree with the "infinite loop" approach. Underallocation will not exceed 1 slot per" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/86201 (owner: Mwalker) [23:52:28] (PS2) Mwalker: Correct Banner Over Allocation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/86201 [23:54:04] huh; where is slander? [23:54:05] :( [23:54:19] awight: ^?